Re: [PATCH 2/2] target/riscv: Trap on writes to stimecmp from VS when hvictl.VTI=1

2023-01-15 Thread Alistair Francis
On Fri, Dec 16, 2022 at 8:46 AM Andrew Bresticker wrote: > > Per the AIA specification, writes to stimecmp from VS level should > trap when hvictl.VTI is set since the write may cause vsip.STIP to > become unset. > > Fixes: 3ec0fe18a31f ("target/riscv: Add vstimecmp support") > Signed-off-by: Andr

Re: [RFC v2 06/13] vhost: delay set_vring_ready after DRIVER_OK

2023-01-15 Thread Jason Wang
在 2023/1/13 16:19, Eugenio Perez Martin 写道: On Fri, Jan 13, 2023 at 5:36 AM Jason Wang wrote: On Fri, Jan 13, 2023 at 1:25 AM Eugenio Pérez wrote: To restore the device at the destination of a live migration we send the commands through control virtqueue. For a device to read CVQ it must ha

Re: [PATCH v2 01/21] hw/block: Rename TYPE_PFLASH_CFI02 'width' property as 'device-width'

2023-01-15 Thread Markus Armbruster
Peter Maydell writes: > On Mon, 9 Jan 2023 at 14:19, Philippe Mathieu-Daudé wrote: >> >> On 9/1/23 14:33, BALATON Zoltan wrote: >> > On Mon, 9 Jan 2023, Philippe Mathieu-Daudé wrote: >> >> Use the same property name than the TYPE_PFLASH_CFI01 model. >> > >> > Nothing uses it? Can this break comm

Re: [PATCH 1/7] hw/acpi: Add missing includes

2023-01-15 Thread Markus Armbruster
Bernhard Beschow writes: > When removing the "hw/boards.h" include from > hw/acpi/acpi_dev_interface.h, these include directives must be added to make > the code compile again. > > Signed-off-by: Bernhard Beschow You don't actually remove #include "hw/boards.h" from hw/acpi/acpi_dev_interface.h

Re: [RFC v2 08/13] vdpa: Negotiate _F_SUSPEND feature

2023-01-15 Thread Jason Wang
在 2023/1/13 16:45, Eugenio Perez Martin 写道: On Fri, Jan 13, 2023 at 5:39 AM Jason Wang wrote: On Fri, Jan 13, 2023 at 1:25 AM Eugenio Pérez wrote: This is needed for qemu to know it can suspend the device to retrieve its status and enable SVQ with it, so all the process is transparent to th

Re: [RFC v2 11/13] vdpa: add vdpa net migration state notifier

2023-01-15 Thread Jason Wang
在 2023/1/13 17:00, Eugenio Perez Martin 写道: On Fri, Jan 13, 2023 at 5:55 AM Jason Wang wrote: On Fri, Jan 13, 2023 at 1:25 AM Eugenio Pérez wrote: This allows net to restart the device backend to configure SVQ on it. Ideally, these changes should not be net specific. However, the vdpa net

Re: [RFC v2 12/13] vdpa: preemptive kick at enable

2023-01-15 Thread Jason Wang
在 2023/1/13 17:06, Eugenio Perez Martin 写道: On Fri, Jan 13, 2023 at 4:39 AM Jason Wang wrote: On Fri, Jan 13, 2023 at 11:25 AM Zhu, Lingshan wrote: On 1/13/2023 10:31 AM, Jason Wang wrote: On Fri, Jan 13, 2023 at 1:27 AM Eugenio Pérez wrote: Spuriously kick the destination device's que

Re: [PATCH 0/3] Fix UNMAP notifier for intel-iommu

2023-01-15 Thread Jason Wang
On Mon, Jan 16, 2023 at 7:30 AM Viktor Prutyanov wrote: > > On Tue, Nov 29, 2022 at 11:10 AM Jason Wang wrote: > > > > Hi All: > > > > According to ATS, device should work if ATS is disabled. This is not > > correctly implemented in the current intel-iommu since it doesn't > > handle the UNMAP no

Re: [PATCH v2] Fix exec migration on Windows (w32+w64).

2023-01-15 Thread Marc-André Lureau
Hi On Mon, Jan 16, 2023 at 5:35 AM John Berberian, Jr wrote: > > * Use cmd instead of /bin/sh on Windows. > > * Try to auto-detect cmd.exe's path, but default to a hard-coded path. > > Note that this will require that gspawn-win[32|64]-helper.exe and > gspawn-win[32|64]-helper-console.exe are inc

RE: [PULL v4 76/83] vhost-user: Support vhost_dev_start

2023-01-15 Thread Yajun Wu
Not quite sure about the whole picture. Seems while qemu waiting response of vhost_user_get_status, dpdk send out VHOST_USER_SLAVE_IOTLB_MSG and trigger qemu function vhost_backend_update_device_iotlb. Qemu wait on reply of VHOST_USER_IOTLB_MSG but get VHOST_USER_GET_STATUS reply. Break on firs

Re: Call qemu_socketpair() instead of socketpair() when possible

2023-01-15 Thread Thomas Huth
On 16/01/2023 05.56, Guoyi Tu wrote: As qemu_socketpair() was introduced in commit 3c63b4e9 ("oslib-posix: Introduce qemu_socketpair()"), it's time to replace the other existing socketpair() calls with qemu_socketpair() if possible Signed-off-by: Guoyi Tu ---  backends/tpm/tpm_emulator.c  

<    1   2