Re: [RFC PATCH v2 02/22] xen: add CONFIG_XENFV_MACHINE and CONFIG_XEN_EMU options for Xen emulation

On Tue, 2022-12-13 at 23:32 +0100, Paolo Bonzini wrote: > Il mar 13 dic 2022, 01:59 David Woodhouse ha scritto: > > There was *also* a call to xen_emulated_machine_init() added to > > pc_init1() by the 'pc_piix: handle XEN_EMULATE backend init' patch. > > I've dropped that for now; once we are rea

RE: [PATCH] target/i386/hax: Add XCR0 support

Thanks for Peter's reply. Since it is better to pull the patch by x86 maintainers, could any maintainer help to merge it, @Paolo Bonzini or @Stefan Hajnoczi? The original patch is attached below. Thanks a lot. Best Regards, Wenchao - From b1789f2523d06798b88836

Re: [PATCH] virtio-mem: Fix the bitmap index of the section offset

On 16.12.22 07:22, Chenyi Qiang wrote: vmem->bitmap indexes the memory region of the virtio-mem backend at a granularity of block_size. To calculate the index of target section offset, the block_size should be divided instead of the bitmap_size. I'm curious, what's the user-visible effect and h

Re: [PATCH v2] hw/cxl/device: Add Flex Bus Port DVSEC

On Thu, 15 Dec 2022 09:28:30 -0800 Ira Weiny wrote: > On Thu, Dec 15, 2022 at 05:16:33PM +, Jonathan Cameron wrote: > > On Wed, 14 Dec 2022 12:54:11 -0800 > > Ira Weiny wrote: > > > > > The Flex Bus Port DVSEC was missing on type 3 devices which was blocking > > > RAS checks.[1] > > > >

Re: [PATCH v4] riscv: Allow user to set the satp mode

Hi Alexandre, Thanks for the contribution. This is really helpful. It seems like if we want to specify the SATP mode for the "named" CPUs, we have to do, e.g.: cpu->cfg.satp_mode.map |= (1 << idx_satp_mode_from_str("sv39")); in each CPU's init function. Can we add another helper function to wrap

Re: [PATCH 2/2] block: Add no_coroutine_fn and coroutine_mixed_fn marker

Am 15.12.2022 um 18:44 hat Paolo Bonzini geschrieben: > From: Alberto Faria > > Add more annotations to functions, describing valid and invalid > calls from coroutine to non-coroutine context. > > When applied to a function, no_coroutine_fn advertises that it should > not be called from coroutin

Re: [PATCH v9 06/12] vdpa: request iova_range only once

On Fri, Dec 16, 2022 at 8:29 AM Jason Wang wrote: > > On Thu, Dec 15, 2022 at 7:32 PM Eugenio Pérez wrote: > > > > Currently iova range is requested once per queue pair in the case of > > net. Reduce the number of ioctls asking it once at initialization and > > reusing that value for each vhost_v

Re: [PATCH v2 0/2] qga: improve "syslog" domain logging

Reviewed-by: Konstantin Kostiuk Tested-by: Konstantin Kostiuk Hi Andrey, Do you expect Event Viewer to be empty by default in the current implementation? Currently, all logs that we write in the guest agent do not have "syslog" domain so we will have logs only in file. On Mon, Dec 12, 2022 at

[PATCH] tests/qapi-schema: remove Meson workaround

The referenced issue has been fixed since version 0.61, so remove the workaround. Signed-off-by: Paolo Bonzini --- tests/qapi-schema/meson.build | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tests/qapi-schema/meson.build b/tests/qapi-schema/meson.build index 406bc7255d

[PATCH] linux-user: Fix SO_ERROR return code of getsockopt()

Add translation for the host error return code of: getsockopt(19, SOL_SOCKET, SO_ERROR, [ECONNREFUSED], [4]) = 0 This fixes the testsuite of the cockpit debian package with a hppa-linux guest on a x86-64 host. Signed-off-by: Helge Deller --- linux-user/syscall.c | 5 +++-- 1 file changed, 3

[PATCH 2/2] docs: add no-padding firmware feature

Signed-off-by: Gerd Hoffmann --- docs/interop/firmware.json | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/interop/firmware.json b/docs/interop/firmware.json index 56814f02b3c0..74f404d745b0 100644 --- a/docs/interop/firmware.json +++ b/docs/interop/firmware.json @@

[PATCH 1/2] hw/arm: allow flash images being smaller than the available space

Query block device backing flash for size and use that instead of requiring the block device being exactly 64M in size. This allows to use edk2 firmware builds without padding, i.e. use QEMU_EFI.fd (which is /way/ smaller than 64M) as-is. -rw-r--r--. 1 root root 67108864 Dec 12 23:45 QEMU_EFI-pfl

[PATCH 0/2] hw/arm: allow flash images being smaller than the available space

Gerd Hoffmann (2): hw/arm: allow flash images being smaller than the available space docs: add no-padding firmware feature hw/arm/virt.c | 16 docs/interop/firmware.json | 5 - 2 files changed, 20 insertions(+), 1 deletion(-) -- 2.38.1

[PATCH] docs: do not talk about past removal as happening in the future

KVM guest support on 32-bit Arm hosts *has* been removed, so rephrase the sentence describing it. Signed-off-by: Paolo Bonzini --- docs/about/removed-features.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/about/removed-features.rst b/docs/about/removed-feature

[PATCH] meson: accept relative symlinks in "meson introspect --installed" data

When installing shared libraries, as is the case for libvfio-user.so, Meson will include relative symbolic links in the output of "meson introspect --installed": { "libvfio-user.so": "/usr/local/lib64/libvfio-user.so", ... } In the case of scripts/symlink-install-tree.py, this will be

Re: [PATCH 2/2] tpm: add backend for mssim

On Thu, Dec 15, 2022 at 03:53:43PM -0500, Stefan Berger wrote: > > > On 12/15/22 15:30, James Bottomley wrote: > > On Thu, 2022-12-15 at 15:22 -0500, Stefan Berger wrote: > > > On 12/15/22 15:07, James Bottomley wrote: > > [...] > > > > don't really have much interest in the migration use case, b

Re: [PATCH] virtio-mem: Fix the bitmap index of the section offset

On 16.12.22 09:52, David Hildenbrand wrote: On 16.12.22 07:22, Chenyi Qiang wrote: vmem->bitmap indexes the memory region of the virtio-mem backend at a granularity of block_size. To calculate the index of target section offset, the block_size should be divided instead of the bitmap_size. I'm

Re: [PATCH 2/2] io/channel-tls: fix handling of bigger read buffers

On Wed, Nov 16, 2022 at 10:52:20AM +, Daniel P. Berrangé wrote: > On Tue, Nov 15, 2022 at 03:23:29PM +0100, antoine.dam...@shadow.tech wrote: > > From: Antoine Damhet > > > > Since the TLS backend can read more data from the underlying QIOChannel > > we introduce a minimal child GSource to no

Re: [PATCH 1/5] io: Add support for MSG_PEEK for socket channel

On 15/12/22 11:05 pm, Peter Xu wrote: On Thu, Dec 15, 2022 at 09:40:41AM +, Daniel P. Berrangé wrote: On Wed, Dec 14, 2022 at 04:30:48PM -0500, Peter Xu wrote: On Wed, Dec 14, 2022 at 09:14:09AM +, Daniel P. Berrangé wrote: On Tue, Dec 13, 2022 at 04:38:46PM -0500, Peter Xu wrote: F

Re: [PATCH] docs: do not talk about past removal as happening in the future

On 16/12/22 11:15, Paolo Bonzini wrote: KVM guest support on 32-bit Arm hosts *has* been removed, so rephrase the sentence describing it. Signed-off-by: Paolo Bonzini --- docs/about/removed-features.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/about/remov

Re: [PATCH 2/2] io/channel-tls: fix handling of bigger read buffers

On Fri, Dec 16, 2022 at 11:38:03AM +0100, Antoine Damhet wrote: > On Wed, Nov 16, 2022 at 10:52:20AM +, Daniel P. Berrangé wrote: > > On Tue, Nov 15, 2022 at 03:23:29PM +0100, antoine.dam...@shadow.tech wrote: > > > From: Antoine Damhet > > > > > > Since the TLS backend can read more data fro

Re: [PATCH 1/2] hw/arm: allow flash images being smaller than the available space

On Fri, 16 Dec 2022 at 10:12, Gerd Hoffmann wrote: > > Query block device backing flash for size and use that instead of > requiring the block device being exactly 64M in size. This allows > to use edk2 firmware builds without padding, i.e. use QEMU_EFI.fd > (which is /way/ smaller than 64M) as-i

[PATCH v2 1/2] coroutine: annotate coroutine_fn for libclang

From: Alberto Faria Clang has a generic __annotate__ attribute that can be used by static analyzers to understand properties of functions and analyze the control flow. Furthermore, unlike TSA annotations, the __annotate__ attribute applies to function pointers as well. As a first step towards s

[PATCH 0/2] Make coroutine annotations ready for static analysis

Clang has a generic __annotate__ attribute that can be used by static analyzers to understand properties of functions and analyze the control flow. Unlike TSA annotations, the __annotate__ attribute applies to function pointers as well, which is very fortunate because many BlockDriver function dri

[PATCH v2 2/2] block: Add no_coroutine_fn and coroutine_mixed_fn marker

From: Alberto Faria Add more annotations to functions, describing valid and invalid calls from coroutine to non-coroutine context. When applied to a function, no_coroutine_fn advertises that it should not be called from coroutine_fn functions. This can be because the function blocks or, in the

Re: [PATCH 2/2] docs: add no-padding firmware feature

On Fri, Dec 16, 2022 at 11:12:34AM +0100, Gerd Hoffmann wrote: Hi, > Signed-off-by: Gerd Hoffmann > --- > docs/interop/firmware.json | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/docs/interop/firmware.json b/docs/interop/firmware.json > index 56814f02b3c0..74f404

Re: [PATCH 1/3] block: mention 'password-secret' option for -iscsi

On Thu, Dec 01, 2022 at 09:58:12AM -0300, Fabiano Rosas wrote: > Daniel P. Berrangé writes: > > > The 'password-secret' option was added > > > > commit b189346eb1784df95ed6fed610411dbf23d19e1f > > Author: Daniel P. Berrangé > > Date: Thu Jan 21 14:19:21 2016 + > > > > iscsi: add

[PATCH v1 03/10] gdbstub: Make syscall_complete/[gs]et_reg target-agnostic typedefs

From: Philippe Mathieu-Daudé Prototypes using gdb_syscall_complete_cb() or gdb_?et_reg_cb() don't depend on "cpu.h", thus are not target-specific. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20221214143659.62133-1-phi...@linaro.org> Signed-off-by: Alex Ben

[PATCH v1 09/10] gdbstub: move chunks of user code into own files

The process was pretty similar to the softmmu move except we take the time to split stuff between user.c and user-target.c to avoid as much target specific compilation as possible. We also start to make use of our shiny new header scheme so the user-only helpers can be included without the rest of

[PATCH v1 06/10] includes: move tb_flush into its own header

This aids subsystems (like gdbstub) that want to trigger a flush without pulling target specific headers. Signed-off-by: Alex Bennée --- v2 - actually include the header and rename to tb-flush.h --- include/exec/exec-all.h | 1 - include/exec/tb-flush.h | 19 +++ linu

[PATCH v1 05/10] gdbstub: move GDBState to shared internals header

We are about to split softmmu and user mode helpers into different files. To facilitate this we will need to share access to the GDBState between those files. Signed-off-by: Alex Bennée --- gdbstub/internals.h | 53 + gdbstub/gdbstub.c | 47 ++---

[PATCH v1 01/10] gdbstub/internals.h: clean up include guard

Use something more specific to avoid name clashes. Signed-off-by: Alex Bennée --- gdbstub/internals.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gdbstub/internals.h b/gdbstub/internals.h index eabb0341d1..b444f24ef5 100644 --- a/gdbstub/internals.h +++ b/gdbstub/in

[PATCH v1 04/10] gdbstub: split GDBConnection from main structure

In preparation for moving user/softmmu specific bits from the main gdbstub file we need to separate the connection details to what will eventually become an anonymous pointer. Signed-off-by: Alex Bennée --- gdbstub/gdbstub.c | 99 +++ 1 file changed, 5

[PATCH v1 10/10] gdbstub: retire exec/gdbstub.h

Finally split the gdbstub API across multiple headers: - common.h, all the standard APIs registering and semihosting - user.h, user-mode specific APIs - helpers.h, the register helpers that need to be host/target aware The aim is to reduce the dependence on cpu.h and target specific awarene

[PATCH v1 07/10] includes: add new gdbstub include directory

To avoid having a messy set of include files containing system and user APIs lets prepare for a cleaner layout. Signed-off-by: Alex Bennée --- include/gdbstub/common.h | 14 ++ include/gdbstub/user.h | 14 ++ MAINTAINERS | 1 + 3 files changed, 29 insertio

[PATCH v1 00/10] split user and system code in gdbstub

Hi, We currently re-compile gdbstub for every single target on the system. Part of the reason for this is we have a lot of conditional #ifdefs to handle the differences between user and system mode debugging. To use the CONFIG_USER_ONLY and CONFIG_SOFTMMU defines you require using NEED_CPU which e

[PATCH v1 02/10] gdbstub: fix-up copyright and license files

When I started splitting gdbstub apart I was a little too boilerplate with my file headers. Fix up to carry over Fabrice's copyright and the LGPL license header. Fixes: ae7467b1ac (gdbstub: move breakpoint logic to accel ops) Signed-off-by: Alex Bennée --- gdbstub/softmmu.c | 3 ++- gdbstub/user

[PATCH v1 08/10] gdbstub: move chunk of softmmu functionality to own file

This is mostly code motion but a number of things needed to be done for this minimal patch set: - move shared structures to internals.h - convert some helpers to public gdb_ functions (via internals.h) - splitting some functions into user and softmmu versions - fixing a few casting issues

[PATCH v2 1/3] block: mention 'password-secret' option for -iscsi

The 'password-secret' option was added commit b189346eb1784df95ed6fed610411dbf23d19e1f Author: Daniel P. Berrangé Date: Thu Jan 21 14:19:21 2016 + iscsi: add support for getting CHAP password via QCryptoSecret API but was not mentioned in the command line docs Reviewed-by: Mark

[PATCH v2 2/3] block: deprecate iSCSI 'password' in favour of 'password-secret'

Support for referencing secret objects was added in commit b189346eb1784df95ed6fed610411dbf23d19e1f Author: Daniel P. Berrangé Date: Thu Jan 21 14:19:21 2016 + iscsi: add support for getting CHAP password via QCryptoSecret API The existing 'password' option is overdue for deprec

Re: [PATCH v1 00/24] vfio-user client

On 11/9/22 00:13, John Johnson wrote: Hello, This is the 6th revision of the vfio-user client implementation. It is the first patch series (the previous revisions were RFCs) First of all, thank you for your time reviewing the RFC versions. The vfio-user framework consists of 3 parts: 1) The

[PATCH v2 3/3] ui: remove deprecated 'password' option for SPICE

This has been replaced by the 'password-secret' option, which references a 'secret' object instance. Reviewed-by: Markus Armbruster Signed-off-by: Daniel P. Berrangé --- docs/about/deprecated.rst | 8 docs/about/removed-features.rst | 7 +++ qemu-options.hx

[PATCH v2 0/3] More work on deprecation/removal of clear text passwords

This deprecates the -iscsi clear text 'password' option and deletes the previously deprecated -spice 'password' option. Changed in v2: * Fixed section placement for iscsi deprecation docs * Fixed missing brackets in -iscsi help * Write in past tense for -spice password removal docs Daniel P.

Re: [PULL v2 00/28] target-arm queue

Peter Maydell writes: > drop the sysregs patch as the tcg sysregs test fails > (probably a bug in the test) Well I assume because it complains about extra bits leaking into userspace: ➜ ./qemu-aarch64 ./tests/tcg/aarch64-linux-user/sysregs Checking Counter registers ctr_el0

Re: [PATCH v3 2/8] accel/tcg: Rename page_flush_tb

Richard Henderson writes: > Rename to tb_remove_all, to remove the PageDesc "page" from the name, > and to avoid suggesting a "flush" in the icache sense. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PULL v2 00/28] target-arm queue

On Fri, 16 Dec 2022 at 11:49, Alex Bennée wrote: > > > Peter Maydell writes: > > > drop the sysregs patch as the tcg sysregs test fails > > (probably a bug in the test) > > Well I assume because it complains about extra bits leaking into > userspace: > > ➜ ./qemu-aarch64 ./tests/tcg/aarch64-li

Re: [PATCH v3 4/8] accel/tcg: Use interval tree for TARGET_PAGE_DATA_SIZE

Richard Henderson writes: > Continue weaning user-only away from PageDesc. > > Use an interval tree to record target data. > Chunk the data, to minimize allocation overhead. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v3 6/8] accel/tcg: Use interval tree for user-only page tracking

Philippe Mathieu-Daudé writes: > On 9/12/22 06:19, Richard Henderson wrote: >> Finish weaning user-only away from PageDesc. >> Using an interval tree to track page permissions means that >> we can represent very large regions efficiently. >> Resolves: https://gitlab.com/qemu-project/qemu/-/issu

Re: [PULL v2 00/23] First batch of s390x, qtest, CI and misc patches for 8.0

On Thu, 15 Dec 2022 at 15:12, Thomas Huth wrote: > > The following changes since commit 48804eebd4a327e4b11f902ba80a00876ee53a43: > > Merge tag 'pull-misc-2022-12-14' of https://repo.or.cz/qemu/armbru into > staging (2022-12-15 10:13:46 +) > > are available in the Git repository at: > > h

Re: [PATCH-for-8.0 1/5] accel/tcg: Restrict cpu_io_recompile() to system emulation

Philippe Mathieu-Daudé writes: > Missed in commit 6526919224 ("accel/tcg: Restrict cpu_io_recompile() > from other accelerators"). > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH-for-8.0 2/5] accel/tcg: Remove trace events from trace-root.h

Philippe Mathieu-Daudé writes: > Commit d9bb58e510 ("tcg: move tcg related files into accel/tcg/ > subdirectory") introduced accel/tcg/trace-events, so we don't > need to use the root trace-events anymore. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée BTW I wonder how m

Re: [PATCH-for-8.0 3/5] accel/tcg: Rename tb_invalidate_phys_page_[locked_]fast()

Philippe Mathieu-Daudé writes: > Emphasize this function is called with pages locked. The _locked should be a suffix rather than in the function and possibly a __locked for continuity with the other __locked functions in the file. Otherwise: Reviewed-by: Alex Bennée > > Signed-off-by: Phi

Re: [PATCH-for-8.0 4/5] accel/tcg: Factor tb_invalidate_phys_range_fast() out

Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH-for-8.0 5/5] accel/tcg: Restrict page_collection structure to system TB maintainance

Philippe Mathieu-Daudé writes: > Only the system emulation part of TB maintainance uses the > page_collection structure. Restrict its declaration (and the > functions requiring it) to tb-maint.c. > > Convert the 'len' argument of tb_invalidate_phys_page_locked_fast() > from signed to unsigned.

misleading error message when converting an empty raw file to VMDK

Hi Fam, the following commands produce an error message that's unexpected IMO: truncate --size=0 z.raw qemu-img convert -f raw -O vmdk z.raw z.vmdk qemu-img: Could not open 'z.vmdk': Unsupported image type 'monolithicSparse' The exit status is 1, and the attached z.vmdk file is created. My und

Re: [PATCH 2/2] tpm: add backend for mssim

On 12/16/22 05:27, Daniel P. Berrangé wrote: On Thu, Dec 15, 2022 at 03:53:43PM -0500, Stefan Berger wrote: On 12/15/22 15:30, James Bottomley wrote: On Thu, 2022-12-15 at 15:22 -0500, Stefan Berger wrote: On 12/15/22 15:07, James Bottomley wrote: [...] don't really have much interest i

Re: [PATCH v2] hw/cxl/device: Add Flex Bus Port DVSEC

On Fri, Dec 16, 2022 at 09:31:36AM +, Jonathan Cameron wrote: > On Thu, 15 Dec 2022 09:28:30 -0800 > Ira Weiny wrote: > > > On Thu, Dec 15, 2022 at 05:16:33PM +, Jonathan Cameron wrote: > > > On Wed, 14 Dec 2022 12:54:11 -0800 > > > Ira Weiny wrote: > > > > > > > The Flex Bus Port DVS

Re: [PATCH 2/2] tpm: add backend for mssim

On Fri, Dec 16, 2022 at 07:28:59AM -0500, Stefan Berger wrote: > > > On 12/16/22 05:27, Daniel P. Berrangé wrote: > > On Thu, Dec 15, 2022 at 03:53:43PM -0500, Stefan Berger wrote: > > > > > > > > > On 12/15/22 15:30, James Bottomley wrote: > > > > On Thu, 2022-12-15 at 15:22 -0500, Stefan Berg

[PATCH 2/5] hw/isa: add trace events for ICH9 LPC chip config access

These tracepoints aid in understanding and debugging the guest drivers for the TCO watchdog. Reviewed-by: Richard W.M. Jones Signed-off-by: Daniel P. Berrangé --- hw/isa/lpc_ich9.c | 3 +++ hw/isa/trace-events | 4 2 files changed, 7 insertions(+) diff --git a/hw/isa/lpc_ich9.c b/hw/isa

[PATCH 0/5] hw: make TCO watchdog actually work by default for Q35

The TCO watchdog is unconditionally integrated into the Q35 machine type by default, but at the same time is unconditionally disabled from firing by a host config option that overrides guest OS attempts to enable it. People have to know to set a magic -global to make it non-broken IOW we're exposi

[PATCH 3/5] hw/watchdog: add trace events for watchdog action handling

The tracepoints aid in debugging the triggering of watchdog devices. Reviewed-by: Richard W.M. Jones Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- hw/watchdog/trace-events | 4 hw/watchdog/watchdog.c | 4 2 files changed, 8 insertions(+) diff --git a/hw

[PATCH 5/5] ich9: honour 'enable_tco' property

An 'ICH9-LPC.enable_tco' property has been exposed for a very long time, but attempts to set it have never been honoured. Originally, any user provided 'enable_tco' value was force replaced by a value passed from the machine type setup code that was determine by machine type compat properties.

[PATCH 4/5] hw/isa: enable TCO watchdog reboot pin strap by default

The TCO watchdog implementation default behaviour from POV of the guest OS relies on the initial values for two I/O ports: * TCO1_CNT == 0x0 Since bit 11 (TCO Timer Halt) is clear, the watchdog state is considered to be initially running * GCS == 0x20 Since bit 5 (No Reboot) is

[PATCH 1/5] hw/acpi: add trace events for TCO watchdog register access

These tracepoints aid in understanding and debugging the guest drivers for the TCO watchdog. Reviewed-by: Richard W.M. Jones Signed-off-by: Daniel P. Berrangé --- hw/acpi/tco.c| 41 - hw/acpi/trace-events | 2 ++ 2 files changed, 30 insertions(+)

Re: [PATCH v4] riscv: Allow user to set the satp mode

Hi Frank, On Fri, Dec 16, 2022 at 10:32 AM Frank Chang wrote: > > Hi Alexandre, > > Thanks for the contribution. This is really helpful. > > It seems like if we want to specify the SATP mode for the "named" CPUs, > we have to do, e.g.: > cpu->cfg.satp_mode.map |= (1 << idx_satp_mode_from_str("sv3

[PATCH v2 0/7] Clean up dependencies of ACPI controllers

This small series establishes consistency between ICH9, PIIX4 and VT82C686 ACPI controllers to select ACPI, ACPI_SMBUS and APM since they are provided by the device models. Due to the PIIX4 PM cleanup PEGASOS2's dependency can be reduced to just ACPI, eliminating 9 dependencies from the softmmu-pp

[PATCH v2 3/7] hw/acpi/Kconfig: Do not needlessly build TYPE_PIIX4_PM in non-PC/Malta machines

TYPE_PIIX4_PM is only used in machines where PIIX chipsets are used which is currently PC and Malta. There is no point building it for the other ACPI_X86 machines. Note that this also removes unneeded ACPI_PIIX4 from PEGASOS2. Signed-off-by: Bernhard Beschow --- hw/acpi/Kconfig | 1 - hw/i386/K

[PATCH v2 5/7] hw/isa/Kconfig: Add missing dependency to VT82C686

The ACPIREGS are provided by TYPE_VIA_PM, so needs to select ACPI. Signed-off-by: Bernhard Beschow --- hw/isa/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig index 0a6a04947c..0156a66889 100644 --- a/hw/isa/Kconfig +++ b/hw/isa/Kconfig @@ -52,6 +52,7 @

[PATCH v2 4/7] hw/acpi/Kconfig: Add missing dependencies to ACPI_PIIX4

piix4_pm_realize() uses apm_init() and pm_smbus_init(), so both APM and ACPI_SMBUS are provided by the device model managed by ACPI_PIIX4. The ACPIREGS are also provided by ACPI_PIIX4, so needs to select ACPI. Signed-off-by: Bernhard Beschow --- hw/acpi/Kconfig | 4 +++- 1 file changed, 3 inser

[PATCH v2 6/7] i386, mips: Resolve redundant ACPI and APM dependencies

Now that all ACPI controllers select the ACPI and APM dependencies themselves, these explicit dependencies became redundant. Remove them. Signed-off-by: Bernhard Beschow --- configs/devices/mips-softmmu/common.mak | 3 --- hw/i386/Kconfig | 2 -- 2 files changed, 5 deleti

[PATCH v2 1/7] hw/acpi/Kconfig: Rename ACPI_X86_ICH to ACPI_ICH9

Although the ICH9 ACPI controller may currently be tied to x86 it doesn't have to. Furthermore, the source files this configuration switch manages contain a '9', so this name fits more. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé --- hw/acpi/Kconfig | 2 +- hw/acpi/m

[PATCH v2 7/7] hw/ppc/Kconfig: Remove unused dependencies from PEGASOS2

Removes the following dependencies from ppc-softmmu: - CONFIG_ACPI_CPU_HOTPLUG - CONFIG_ACPI_CXL - CONFIG_ACPI_HMAT - CONFIG_ACPI_MEMORY_HOTPLUG - CONFIG_ACPI_NVDIMM - CONFIG_ACPI_PCIHP - CONFIG_ACPI_X86 - CONFIG_MEM_DEVICE Signed-off-by: Bernhard Beschow --- hw/ppc/Kconfig | 2 -- 1 file change

[PATCH v2 2/7] hw/acpi/Kconfig: Add missing dependencies to ACPI_ICH9

ich9_lpc_realize() uses apm_init() and ich9_smbus_realize() uses pm_smbus_init(), so both APM and ACPI_SMBUS are provided by the device models managed by ACPI_ICH9. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé --- hw/acpi/Kconfig | 2 ++ hw/isa/Kconfig | 1 - 2 files cha

Re: [PATCH v2] hostmem: Honor multiple preferred nodes if possible

On 15.12.22 10:55, Michal Privoznik wrote: If a memory-backend is configured with mode HOST_MEM_POLICY_PREFERRED then host_memory_backend_memory_complete() calls mbind() as: mbind(..., MPOL_PREFERRED, nodemask, ...); Here, 'nodemask' is a bitmap of host NUMA nodes and corresponds to the .hos

Re: [PATCH v2] hostmem: Honor multiple preferred nodes if possible

On 12/16/22 14:41, David Hildenbrand wrote: > On 15.12.22 10:55, Michal Privoznik wrote: >> If a memory-backend is configured with mode >> HOST_MEM_POLICY_PREFERRED then >> host_memory_backend_memory_complete() calls mbind() as: >> >>    mbind(..., MPOL_PREFERRED, nodemask, ...); >> >> Here, 'nodem

Re: [PATCH v2 1/3] block: mention 'password-secret' option for -iscsi

Daniel P. Berrangé writes: > The 'password-secret' option was added > > commit b189346eb1784df95ed6fed610411dbf23d19e1f > Author: Daniel P. Berrangé > Date: Thu Jan 21 14:19:21 2016 + > > iscsi: add support for getting CHAP password via QCryptoSecret API > > but was not mentioned

Re: [PATCH 2/2] tpm: add backend for mssim

On Fri, 2022-12-16 at 08:32 -0500, Stefan Berger wrote: > On 12/16/22 07:54, Daniel P. Berrangé wrote: > > On Fri, Dec 16, 2022 at 07:28:59AM -0500, Stefan Berger wrote: [...] > > > Nevertheless it needs documentation and has to handle migration > > > scenarios either via a blocker or it has to han

[PULL 1/8] qga: Move FS TRIM code to commands-linux.c

From: Alexander Ivanov In the next patch ZFS TRIM support for FreeBSD will be added. Move Linux-specific TRIM code to commands-linux.c file. Signed-off-by: Alexander Ivanov Reviewed-by: Konstantin Kostiuk Signed-off-by: Konstantin Kostiuk --- qga/commands-linux.c | 73 +++

[PULL 6/8] qga-win: choose the right libpcre version to include in MSI package

From: Andrey Drobyshev via According to GLib changelog [1], since version 2.73.2 GLib is using libpcre2 instead of libpcre. As a result, qemu-ga MSI installation fails due to missing DLL when linked with the newer GLib. This commit makes wixl to put the right libpcre version into the MSI bundle

[PULL 0/8] QEMU Guest Agent misc patches

The following changes since commit edc93f455fa823a9a5fcb3a8da430104c7375a0a: Revert "hw/loongarch/virt: Add cfi01 pflash device" (2022-12-05 11:24:35 -0500) are available in the Git repository at: g...@github.com:kostyanf14/qemu.git tags/qga-pull-2022-12-16 for you to fetch changes up to 1

Re: [PATCH v2 2/3] block: deprecate iSCSI 'password' in favour of 'password-secret'

Daniel P. Berrangé writes: > Support for referencing secret objects was added in > > commit b189346eb1784df95ed6fed610411dbf23d19e1f > Author: Daniel P. Berrangé > Date: Thu Jan 21 14:19:21 2016 + > > iscsi: add support for getting CHAP password via QCryptoSecret API > > The exis

[PULL 2/8] qga: Add ZFS TRIM support for FreeBSD

From: Alexander Ivanov Use zpool tool for ZFS pools trimming in FreeBSD. Signed-off-by: Alexander Ivanov Reviewed-by: Konstantin Kostiuk Signed-off-by: Konstantin Kostiuk --- qga/commands-bsd.c| 109 ++ qga/commands-common.h | 1 + 2 files change

Re: [PATCH v2 3/3] ui: remove deprecated 'password' option for SPICE

Daniel P. Berrangé writes: > This has been replaced by the 'password-secret' option, > which references a 'secret' object instance. > > Reviewed-by: Markus Armbruster > Signed-off-by: Daniel P. Berrangé Reviewed-by: Fabiano Rosas Just a small detail below. > --- > docs/about/deprecated.rst

[PULL 8/8] qga: map GLib log levels to system levels

From: Andrey Drobyshev via This patch translates GLib-specific log levels to system ones, so that they may be used by both *nix syslog() (as a "priority" argument) and Windows ReportEvent() (as a "wType" argument). Currently the only codepath to write to "syslog" domain is slog() function. Howe

[PULL 4/8] qga:/qga-win: adding a empty PCI address creation function

From: Kfir Manor Refactoring code to avoid duplication of creating an empty PCI address code. Signed-off-by: Kfir Manor Reviewed-by: Konstantin Kostiuk Reviewed-by: Marc-André Lureau Signed-off-by: Konstantin Kostiuk --- qga/commands-win32.c | 20 +--- 1 file changed, 13 ins

[PULL 5/8] qga:/qga-win: skip getting pci info for USB disks

From: Kfir Manor Skip getting PCI info from disks type USB and give them an empty PCI address instead. Signed-off-by: Kfir Manor Reviewed-by: Konstantin Kostiuk Reviewed-by: Marc-André Lureau Signed-off-by: Konstantin Kostiuk --- qga/commands-win32.c | 12 1 file changed, 8 in

[PULL 7/8] qga-win: add logging to Windows event log

From: Andrey Drobyshev via This commit allows QGA to write to Windows event log using Win32 API's ReportEvent() [1], much like syslog() under *nix guests. In order to generate log message definitions we use a very basic message text file [2], so that every QGA's message gets ID 1. The tools "wi

[PULL 3/8] qga: Add initial OpenBSD and NetBSD support

From: Brad Smith qga: Add initial OpenBSD and NetBSD support Signed-off-by: Brad Smith Reviewed-by: Konstantin Kostiuk Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Konstantin Kostiuk --- meson.build | 2 +- qga/commands-bsd.c | 5 + qga/commands-posix.c | 9 +++-- q

Re: [PATCH 2/2] tpm: add backend for mssim

On 12/16/22 08:53, James Bottomley wrote: On Fri, 2022-12-16 at 08:32 -0500, Stefan Berger wrote: On 12/16/22 07:54, Daniel P. Berrangé wrote: On Fri, Dec 16, 2022 at 07:28:59AM -0500, Stefan Berger wrote: [...] Nevertheless it needs documentation and has to handle migration scenarios eith

Re: [PATCH 2/2] tpm: add backend for mssim

On 12/16/22 07:54, Daniel P. Berrangé wrote: On Fri, Dec 16, 2022 at 07:28:59AM -0500, Stefan Berger wrote: On 12/16/22 05:27, Daniel P. Berrangé wrote: On Thu, Dec 15, 2022 at 03:53:43PM -0500, Stefan Berger wrote: On 12/15/22 15:30, James Bottomley wrote: On Thu, 2022-12-15 at 15:22

Re: [PATCH 01/14] block-coroutine-wrapper: support void functions

On 12/13/22 11:53, Kevin Wolf wrote: From: Emanuele Giuseppe Esposito Just omit the various 'return' when the return type is void. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Kevin Wolf Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH 02/14] block: Convert bdrv_io_plug() to co_wrapper

On 12/13/22 11:53, Kevin Wolf wrote: From: Emanuele Giuseppe Esposito BlockDriver->bdrv_io_plug is categorized as IO callback, and it currently doesn't run in a coroutine. We should let it take a graph rdlock since the callback traverses the block nodes graph, which however is only possible in

Re: [PATCH v3] hw/rtc/mc146818rtc: Make this rtc device target independent

Am 12. Dezember 2022 07:56:00 UTC schrieb Thomas Huth : >The only reason for this code being target dependent is the apic-related >code in rtc_policy_slew_deliver_irq(). Since these apic functions are rather >simple, we can easily move them into a new, separate file (apic_irqcount.c) >which will

Re: [PATCH 2/2] tpm: add backend for mssim

On Fri, Dec 16, 2022 at 08:32:44AM -0500, Stefan Berger wrote: > > > On 12/16/22 07:54, Daniel P. Berrangé wrote: > > On Fri, Dec 16, 2022 at 07:28:59AM -0500, Stefan Berger wrote: > > > > > > > > > On 12/16/22 05:27, Daniel P. Berrangé wrote: > > > > On Thu, Dec 15, 2022 at 03:53:43PM -0500, S

Re: [PATCH 1/5] io: Add support for MSG_PEEK for socket channel

On Fri, Dec 16, 2022 at 04:10:22PM +0530, manish.mishra wrote: > Yes sorry, noticed it now, should i send another patch to update it. Also > in our internal testing we noticed multifd_init was skipped for 1 case, > so if this patch series is not yet submitted should i send another > version of it e

Re: [PATCH 01/30] configure: remove useless write_c_skeleton

On Fri, Dec 09, 2022 at 12:23:40PM +0100, Paolo Bonzini wrote: > This is not needed ever since QEMU stopped detecting -liberty; this > happened with the Meson switch but it is quite likely that the > library was not really necessary years before. > > Signed-off-by: Paolo Bonzini > --- > configur

Re: [PATCH 02/30] configure: remove dead function

On Fri, Dec 09, 2022 at 12:23:41PM +0100, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > configure | 4 > 1 file changed, 4 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |:

Re: [PATCH 03/30] configure: remove useless test

On Fri, Dec 09, 2022 at 12:23:42PM +0100, Paolo Bonzini wrote: > $cpu is derived from preprocessor defines rather than uname these days, > so do not bother using isainfo on Solaris. Likewise do not recognize > BeOS's uname -m output. > > Signed-off-by: Paolo Bonzini > --- > configure | 12 +

Re: [PATCH v4 6/7] hw/sd/sdhci: Implement Freescale eSDHC device model

Am 1. November 2022 10:49:20 UTC schrieb Bernhard Beschow : >Am 31. Oktober 2022 12:11:37 UTC schrieb "Philippe Mathieu-Daudé" >: >>On 30/10/22 12:46, Bernhard Beschow wrote: >>> >>> >>> On Sun, Oct 30, 2022 at 1:10 AM Philippe Mathieu-Daudé >> > wrote: >>> >>>

Re: [PATCH 04/30] configure: preserve qemu-ga variables

On Fri, Dec 09, 2022 at 12:23:43PM +0100, Paolo Bonzini wrote: > Ensure that qemu-ga variables set at configure time are kept > later when the script is rerun. For preserve_env to work, > the variables need to be empty so move the default values > to config-host.mak generation. > > Signed-off-by:

  1   2   3   4   >