On 09/12/2022 12.23, Paolo Bonzini wrote:
This allows cleanups cleanups in modinfo collection and supports the
Scratch one "cleanups" ?
equivalent of QEMU's --static option to configure.
Signed-off-by: Paolo Bonzini
---
configure | 2 +-
meson | 2 +-
meson.build | 2 +-
3 file
On 08/12/2022 10.44, Pierre Morel wrote:
Hi,
Implementation discussions
==
CPU models
--
Since the S390_FEAT_CONFIGURATION_TOPOLOGY is already in the CPU model
for old QEMU we could not activate it as usual from KVM but needed
a KVM capability: KVM_CAP_S390_CPU_
hw/pci/pcie_sriov.h needs PCI_NUM_REGIONS. Without the previous
commit, this would close an inclusion loop: hw/pci/pci.h used to
include hw/pci/pcie.h for PCIExpressDevice, which includes
pcie_sriov.h for PCIESriovPF, which now includes hw/pci/pci.h for
PCI_NUM_REGIONS.
Signed-off-by: Markus Armb
Back in 2016, we discussed[1] rules for headers, and these were
generally liked:
1. Have a carefully curated header that's included everywhere first. We
got that already thanks to Peter: osdep.h.
2. Headers should normally include everything they need beyond osdep.h.
If exceptions are need
Signed-off-by: Markus Armbruster
---
hw/alpha/alpha_sys.h | 1 -
hw/rdma/rdma_utils.h | 1 -
hw/rdma/vmw/pvrdma.h | 1 -
hw/usb/hcd-ehci.h | 1 -
hw/xen/xen_pt.h | 1 -
include/hw/cxl/cxl.h | 1 -
include/hw/cxl
Fix a few style violations so that checkpatch.pl won't complain when I
move this code.
Signed-off-by: Markus Armbruster
---
include/hw/pci/pci.h | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index 6ccaaf5154..01
PCIDeviceClass and PCIDevice are defined in pci.h. Many users of the
header don't actually need them. Similar structs live in their own
headers: PCIBusClass and PCIBus in pci_bus.h, PCIBridge in
pci_bridge.h, PCIHostBridgeClass and PCIHostState in pci_host.h,
PCIExpressHost in pcie_host.h, and PC
hw/cxl/cxl_component.h needs CDATObject from hw/cxl/cxl_cdat.h.
hw/cxl/cxl_device.h needs CXLComponentState from
hw/cxl/cxl_component.h.
Signed-off-by: Markus Armbruster
---
include/hw/cxl/cxl_component.h | 1 +
include/hw/cxl/cxl_device.h| 1 +
2 files changed, 2 insertions(+)
diff --git
On 08/12/2022 10.44, Pierre Morel wrote:
We will need a Topology device to transfer the topology
during migration and to implement machine reset.
The device creation is fenced by s390_has_topology().
Signed-off-by: Pierre Morel
---
[...]
diff --git a/hw/s390x/cpu-topology.c b/hw/s390x/cpu-to
On Tue, Nov 08, 2022 at 03:13:24PM -0800, John Johnson wrote:
> Add an abstract base class both the kernel driver
> and user socket implementations can use to share code.
LGTM
Reviewed-by: John Levon
regards
john
On 12/9/22 13:55, Philippe Mathieu-Daudé wrote:
+ printf "%s\n" ' --disable-debug-info Enable debug symbols and
other information'
We should get '--enable-debug-info' here, ...
printf "%s\n" ' --disable-install-blobs install provided
firmware blobs'
... and here. Do we have a
On 12/9/22 12:52, Peter Maydell wrote:
The new code makes it much harder to move our compiler version
requirements forward in future, because there's no longer a simple
"check for normal clang X or apple clang Y" test where we can
bump up X and Y based on what's provided in the various host
platf
On Tue, Nov 08, 2022 at 03:13:25PM -0800, John Johnson wrote:
> Used for communication with VFIO driver
> (prep work for vfio-user, which will communicate over a socket)
> index e573f5a..6fd40f1 100644
> --- a/include/hw/vfio/vfio-common.h
> +++ b/include/hw/vfio/vfio-common.h
> +
> +extern VFIOC
On 9/12/22 12:43, Peter Maydell wrote:
On Fri, 9 Dec 2022 at 11:07, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
softmmu/physmem.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/softmmu/physmem.c b/softmmu/physmem.c
index 1b606a3002..d562c0bb93 100644
--- a/s
The watchpoint API is specific to TCG system emulation.
Move it to a new compile unit. The inlined stubs are used
for user-mode and non-TCG accelerators.
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 1 +
include/hw/core/cpu.h | 2 +-
softmmu/meson.build | 3 +-
soft
On 9/12/22 14:48, Markus Armbruster wrote:
Fix a few style violations so that checkpatch.pl won't complain when I
move this code.
Signed-off-by: Markus Armbruster
---
include/hw/pci/pci.h | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
Reviewed-by: Philippe Mathieu
On Tue, Nov 08, 2022 at 03:13:26PM -0800, John Johnson wrote:
> cache VFIO_DEVICE_GET_REGION_INFO results to reduce
> memory alloc/free cycles and as prep work for vfio-user
LGTM
Reviewed-by: John Levon
regards
john
On 9/12/22 14:48, Markus Armbruster wrote:
hw/pci/pcie_sriov.h needs PCI_NUM_REGIONS. Without the previous
commit, this would close an inclusion loop: hw/pci/pci.h used to
include hw/pci/pcie.h for PCIExpressDevice, which includes
pcie_sriov.h for PCIESriovPF, which now includes hw/pci/pci.h for
On Fri, 9 Dec 2022 at 14:09, Paolo Bonzini wrote:
>
> On 12/9/22 12:52, Peter Maydell wrote:
> > The new code makes it much harder to move our compiler version
> > requirements forward in future, because there's no longer a simple
> > "check for normal clang X or apple clang Y" test where we can
>
On 9/12/22 14:54, Paolo Bonzini wrote:
On 12/9/22 13:55, Philippe Mathieu-Daudé wrote:
+ printf "%s\n" ' --disable-debug-info Enable debug symbols and
other information'
We should get '--enable-debug-info' here, ...
printf "%s\n" ' --disable-install-blobs install provided
firmw
On 9/12/22 12:15, Thomas Huth wrote:
The only reason for this code being target dependent is the apic-related
code in rtc_policy_slew_deliver_irq(). Since these apic functions are rather
simple, we can easily move them into a new, separate file (apic_irqcount.c)
which will always be compiled and
Hi, Peter!
This email is a supplement to my previous email 7 hours ago.
On 2022/12/9 上午12:00, Peter Xu wrote:
If the assert will work that'll be even better. I'm actually worried this
can trigger like what you mentioned in the virtio path, I didn't expect it
comes that soon. So if there's a mi
On Tue, Nov 08, 2022 at 03:13:27PM -0800, John Johnson wrote:
> Used for communication with VFIO driver
> (prep work for vfio-user, which will communicate over a socket)
>
> @@ -1166,12 +1178,13 @@ uint32_t vfio_pci_read_config(PCIDevice *pdev,
> uint32_t addr, int len)
> if (~emu_bits & (0
On 12/8/22 10:44, Pierre Morel wrote:
Hi,
Implementation discussions
==
CPU models
--
Since the S390_FEAT_CONFIGURATION_TOPOLOGY is already in the CPU model
for old QEMU we could not activate it as usual from KVM but needed
a KVM capability: KVM_CAP_S390_CPU_TOP
On 12/8/22 10:44, Pierre Morel wrote:
We will need a Topology device to transfer the topology
during migration and to implement machine reset.
The device creation is fenced by s390_has_topology().
Some of the info you gave in the cover letter would help the reader
of this commit log.
Signe
On 12/8/22 10:44, Pierre Morel wrote:
The migration can only take place if both source and destination
of the migration both use or both do not use the CPU topology
facility.
We indicate a change in topology during migration postload for the
case the topology changed between source and destinati
On 12/9/22 02:51, Markus Armbruster wrote:
Richard Henderson writes:
On 12/8/22 23:12, Markus Armbruster wrote:
I stumbled over this:
../include/ui/qemu-pixman.h:12:10: fatal error: pixman.h: No such file or
directory
12 | #include
| ^~
Works when
hw/cxl/cxl_pci.h and hw/cxl/cxl_cdat.h include each other. Neither
header actually needs the other one. Drop both #include directives.
Signed-off-by: Markus Armbruster
---
include/hw/cxl/cxl_cdat.h | 1 -
include/hw/cxl/cxl_pci.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/include/hw
From: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
---
hw/mips/Kconfig | 6 ++
hw/mips/meson.build | 3 ++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/hw/mips/Kconfig b/hw/mips/Kconfig
index 725525358d..d6bbbe7069 100644
--- a/hw/mips/Kconfig
+++ b/hw/
From: Philippe Mathieu-Daudé
Per the comment in the Malta board, the [0x.-0x2000.]
range is decoded by the GT64120, so move the "empty_slot" there.
Signed-off-by: Philippe Mathieu-Daudé
---
configs/devices/mips-softmmu/common.mak | 1 -
hw/mips/Kconfig | 1 +
Propagate the controller endianess from the machine, setting
the "cpu-little-endian" property.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/mips/malta.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/mips/malta.c b/hw/mips/malta.c
index ba92022f87..1f4e0c7acc 100644
--
From: Philippe Mathieu-Daudé
This device does not have to be TARGET-dependent.
Add a 'cpu_big_endian' property which sets the byte-swapping
options if required.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/mips/gt64xxx_pci.c | 19 ++-
1 file changed, 14 insertions(+), 5 deletio
From: Philippe Mathieu-Daudé
The single machine using this device explicitly sets its
endianness. We don't need to set a default. This allow us
to remove the target specificity from the build system.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/mips/gt64xxx_pci.c | 2 +-
hw/mips/meson.build
Respining an old/unfinished series... Add the 'cpu-little-endian'
qdev property to the GT64120 north bridge so [target-specific]
machines can set its endianness, allowing it to be endian agnostic.
Philippe Mathieu-Daudé (7):
hw/mips/Kconfig: Introduce CONFIG_GT64120 to select gt64xxx_pci.c
hw/
From: Philippe Mathieu-Daudé
The GT-64120 is a north-bridge, and it is not MIPS specific.
Move it with the other north-bridge devices.
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 2 +-
hw/mips/Kconfig | 6 --
hw/mi
Signed-off-by: Philippe Mathieu-Daudé
---
hw/mips/gt64xxx_pci.c | 37 +
1 file changed, 25 insertions(+), 12 deletions(-)
diff --git a/hw/mips/gt64xxx_pci.c b/hw/mips/gt64xxx_pci.c
index 1b9ac7f792..8c9ec80f7c 100644
--- a/hw/mips/gt64xxx_pci.c
+++ b/hw/mips/g
On 12/9/22 05:17, Philippe Mathieu-Daudé wrote:
+++ b/target/arm/machine.c
@@ -6,6 +6,45 @@
#include "internals.h"
#include "migration/cpu.h"
+/* This mapping is common between ID_AA64MMFR0.PARANGE and TCR_ELx.{I}PS. */
+static const uint8_t pamax_map[] = {
+[0] = 32,
+[1] = 36,
+
On Tue, Nov 08, 2022 at 03:13:28PM -0800, John Johnson wrote:
> New class for vfio-user with its class and instance
> constructors and destructors, and its pci ops.
LGTM
Reviewed-by: John Levon
regards
john
On Tue, Nov 08, 2022 at 03:13:29PM -0800, John Johnson wrote:
> add user.c & user.h files for vfio-user code
> add proxy struct to handle comms with remote server
LGTM
Reviewed-by: John Levon
regards
john
On 20/11/22 16:05, Bernhard Beschow wrote:
v1:
===
During my PIIX consolidation work [1] I've noticed that both PIIX models have
quite different pci_slot_get_pirq() implementations. These functions seem to
map PCI INTx pins to input pins of a programmable interrupt router which is
AFAIU board-sp
+Peter/Laurent
On 9/12/22 15:12, Philippe Mathieu-Daudé wrote:
The watchpoint API is specific to TCG system emulation.
Move it to a new compile unit. The inlined stubs are used
for user-mode and non-TCG accelerators.
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 1 +
On Tue, Nov 08, 2022 at 03:13:30PM -0800, John Johnson wrote:
> Add infrastructure needed to receive incoming messages
>
> +static void vfio_user_process(VFIOProxy *proxy, VFIOUserMsg *msg, bool
> isreply)
> +{
> +
> +/*
> + * Replies signal a waiter, if none just check for errors
> +
On 12/8/22 10:44, Pierre Morel wrote:
The guest uses the STSI instruction to get information on the
CPU topology.
Let us implement the STSI instruction for the basis CPU topology
level, level 2.
Signed-off-by: Pierre Morel
---
target/s390x/cpu.h | 76 +
target/s390
On Tue, Nov 08, 2022 at 03:13:31PM -0800, John Johnson wrote:
> Also negotiate protocol version with remote server
LGTM
Reviewed-by: John Levon
regards
john
On Tue, Nov 08, 2022 at 03:13:32PM -0800, John Johnson wrote:
> +/*
> + * VFIO_USER_DEVICE_GET_INFO
> + * imported from struct_device_info
> + */
> +typedef struct {
> +VFIOUserHdr hdr;
> +uint32_t argsz;
> +uint32_t flags;
> +uint32_t num_regions;
> +uint32_t num_irqs;
> +
On 9/12/22 16:02, Richard Henderson wrote:
On 12/9/22 02:51, Markus Armbruster wrote:
Richard Henderson writes:
On 12/8/22 23:12, Markus Armbruster wrote:
I stumbled over this:
../include/ui/qemu-pixman.h:12:10: fatal error: pixman.h: No
such file or directory
12 | #include
On 9/12/22 16:19, Richard Henderson wrote:
On 12/9/22 05:17, Philippe Mathieu-Daudé wrote:
+++ b/target/arm/machine.c
@@ -6,6 +6,45 @@
#include "internals.h"
#include "migration/cpu.h"
+/* This mapping is common between ID_AA64MMFR0.PARANGE and
TCR_ELx.{I}PS. */
+static const uint8_t pamax
Hello John,
On 11/9/22 00:13, John Johnson wrote:
Add an abstract base class both the kernel driver
and user socket implementations can use to share code.
Signed-off-by: John G Johnson
Signed-off-by: Elena Ufimtseva
Signed-off-by: Jagannathan Raman
I would help the reader if the header fil
Hello John,
On 11/9/22 00:13, John Johnson wrote:
Used for communication with VFIO driver
(prep work for vfio-user, which will communicate over a socket)
Signed-off-by: John G Johnson
---
hw/vfio/common.c | 126 --
include/hw/vfio/vfio-co
On 12/9/22 15:19, Peter Maydell wrote:
I think really I just don't want a check that is "we happen to
know that this particular option switch is supported only
from these versions onward", because as soon as we say
"OK, we can move forward to a clang 7 baseline" we either
need to search around fo
On 12/9/22 15:21, Philippe Mathieu-Daudé wrote:
On 9/12/22 14:54, Paolo Bonzini wrote:
On 12/9/22 13:55, Philippe Mathieu-Daudé wrote:
+ printf "%s\n" ' --disable-debug-info Enable debug symbols
and other information'
We should get '--enable-debug-info' here, ...
printf "%s\n" '
If a memory-backend is configured with mode
HOST_MEM_POLICY_PREFERRED then
host_memory_backend_memory_complete() calls mbind() as:
mbind(..., MPOL_PREFERRED, nodemask, ...);
Here, 'nodemask' is a bitmap of host NUMA nodes and corresponds
to the .host-nodes attribute. Therefore, there can be mul
On 12/9/22 12:34, Peter Maydell wrote:
-# Using uname is really, really broken. Once we have the right set of checks
-# we can eliminate its usage altogether.
I note that the fallback if we match no #defines is still "use uname".
We can only get rid of that if we're willing to say "must be a
kn
On non-x86_64 host, if KVM is not available we get:
Traceback (most recent call last):
File "tests/vm/basevm.py", line 634, in main
vm = vmcls(args, config=config)
File "tests/vm/basevm.py", line 104, in __init__
mem = max(4, args.jobs)
TypeError: '>' not supported between
On 12/9/22 09:51, Markus Armbruster wrote:
Because of where [pixman] is added as a dependency in meson.build.
Is it added where it is for a reason, or is it accidental?
Dependencies are usually added near the .c files that use them. That's
a bit messy of course if you have an "#include <>"
On Fri, 9 Dec 2022 at 16:49, Paolo Bonzini wrote:
>
> On 12/9/22 09:51, Markus Armbruster wrote:
> >> Because of where [pixman] is added as a dependency in meson.build.
> >
> > Is it added where it is for a reason, or is it accidental?
>
> Dependencies are usually added near the .c files that use
On 11/18/22 18:41, Kevin Wolf wrote:
In order to make sure that bdrv_replace_child_noperm() doesn't have to
poll any more, get rid of the bdrv_parent_drained_begin_single() call.
This is possible now because we can require that the parent is already
drained through the child in question when the
With this series my '--enable-tcg --enable-system'
config reduced from 7713 to 7706 objects!
Philippe Mathieu-Daudé (3):
hw/display: Move omap_lcdc.c out of target-specific source set
hw/intc: Move omap_lcdc.c out of target-specific source set
hw/tpm: Move tpm_ppc.c out of target-specific so
While only used by the ARM targets, this device can be built
once for all.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/display/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/meson.build b/hw/display/meson.build
index 7a725ed80e..2cab7a8ff2 100644
---
The TPM Physical Presence Interface is not target specific.
Build this file once for all targets.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/tpm/meson.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/tpm/meson.build b/hw/tpm/meson.build
index 1c68d81d6a..3eacbe8
The Goldfish interrupt controller is not target specific.
While the Exynos interrupt combiner is only used by the ARM
targets, we can build this device once for all.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/intc/meson.build | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --
On Fri, Dec 09, 2022 at 02:47:58PM +0100, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
Thanks!
How can I verify this is correct, i.e. that none
of the headers that we remove is actually needed?
> ---
> hw/alpha/alpha_sys.h | 1 -
> hw/rdma/rdma_utils.h
On Tue, Nov 08, 2022 at 03:13:33PM -0800, John Johnson wrote:
> Add per-region FD to support mmap() of remote device regions
>
> +/*
> + * VFIO_USER_DEVICE_GET_REGION_INFO
> + * imported from struct_vfio_region_info
s/struct_vfio_region_info/struct vfio_region_info/
regards
john
On Tue, Nov 08, 2022 at 03:13:34PM -0800, John Johnson wrote:
> Add support for posted writes on remote devices
LGTM
Reviewed-by: John Levon
regards
john
On 09/12/2022 18.00, Philippe Mathieu-Daudé wrote:
The TPM Physical Presence Interface is not target specific.
Build this file once for all targets.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/tpm/meson.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/tpm/mes
On 09/12/2022 18.00, Philippe Mathieu-Daudé wrote:
The Goldfish interrupt controller is not target specific.
It's also only used by m68k which is only built once, so this does help
reducing the compile time ... but I agree, it will be more helpful in the
future the more code we move to softmm
On Tue, Nov 08, 2022 at 03:13:35PM -0800, John Johnson wrote:
> PCI BARs read from remote device
> PCI config reads/writes sent to remote server
Reviewed-by: John Levon
regards
john
On Tue, Nov 08, 2022 at 03:13:36PM -0800, John Johnson wrote:
> +static int vfio_user_io_get_irq_info(VFIODevice *vbasedev,
> + struct vfio_irq_info *irq)
> +{
> +int ret;
> +
> +ret = vfio_user_get_irq_info(vbasedev->proxy, irq);
> +if (ret) {
> +
On 9/12/22 18:14, Thomas Huth wrote:
On 09/12/2022 18.00, Philippe Mathieu-Daudé wrote:
The TPM Physical Presence Interface is not target specific.
Build this file once for all targets.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/tpm/meson.build | 4 ++--
1 file changed, 2 insertions(+), 2
On 12/9/22 17:52, Peter Maydell wrote:
Dependencies are usually added near the .c files that use them. That's
a bit messy of course if you have an "#include <>" in a heavily-included
QEMU header. You can consider it a way to discourage heavily-included
headers.
This has always seemed to me to
On 9/12/22 18:21, Thomas Huth wrote:
On 09/12/2022 18.00, Philippe Mathieu-Daudé wrote:
The Goldfish interrupt controller is not target specific.
It's also only used by m68k which is only built once, so this does help
reducing the compile time ... but I agree, it will be more helpful in
the
On Tue, Nov 08, 2022 at 03:13:37PM -0800, John Johnson wrote:
> Server holds device current device pending state
> Use irq masking commands in socket case
As far as I'm able to tell, this looks good to me
regards
john
I tried both.
Option 1
What I did:
#undef TARGET_VIRT_ADDR_SPACE_BITS and #define
TARGET_VIRT_ADDR_SPACE_BITS 64
The Result:
perror reports "Cannot allocate memory"
Option 2:
What I did:
TARGET_VIRT_ADDR_SPACE_BITS for me is 30 so I masked by 0x3FFF
The
On Tue, Nov 08, 2022 at 03:13:38PM -0800, John Johnson wrote:
> +/*
> + * The proxy uses a SW IOMMU in lieu of the HW one
> + * used in the ioctl() version. Mascarade as TYPE1
> + * for maximum capatibility
> + */
capability
> @@ -3692,12 +3698,18 @@ static void vfio_user_in
On Tue, Nov 08, 2022 at 03:13:40PM -0800, John Johnson wrote:
> Signed-off-by: John G Johnson
> Signed-off-by: Elena Ufimtseva
> Signed-off-by: Jagannathan Raman
> ---
> +static int vfio_user_io_dirty_bitmap(VFIOContainer *container,
> +struct vfio_iommu_type1_dirty_bit
On Tue, Nov 08, 2022 at 03:13:41PM -0800, John Johnson wrote:
> Secure DMA forces the remote process to use DMA r/w messages
> instead of directly mapping guest memeory.
I don't really get why this is called "secure" - shouldn't have an option name
more closely resembling what it actually does?
On Tue, Nov 08, 2022 at 03:13:42PM -0800, John Johnson wrote:
> static void vfio_user_pci_process_req(void *opaque, VFIOUserMsg *msg)
> {
> +VFIOPCIDevice *vdev = opaque;
> +VFIOUserHdr *hdr = msg->hdr;
> +
> +/* no incoming PCI requests pass FDs */
> +if (msg->fds != NULL) {
> +
On Tue, Nov 08, 2022 at 03:13:43PM -0800, John Johnson wrote:
> Message to tell the server to reset the device.
LGTM
Reviewed-by: John Levon
regards
john
LGTM
Reviewed-by: John Levon
regards
john
On Tue, Nov 08, 2022 at 03:13:45PM -0800, John Johnson wrote:
> Add new message to send multiple writes to server
LGTM - but maybe commit message could have some context as to why this is
useful?
Reviewed-by: John Levon
regards
john
Am 09.12.2022 um 13:20 hat Emanuele Giuseppe Esposito geschrieben:
> Am 09/12/2022 um 13:18 schrieb Emanuele Giuseppe Esposito:
> > Am 05/12/2022 um 14:01 schrieb Kevin Wolf:
> >> I wonder if we need a more general solution for this because this test
> >> is not the only place that calls this kind
On Fri, 9 Dec 2022 at 17:42, Paolo Bonzini wrote:
>
> On 12/9/22 17:52, Peter Maydell wrote:
> >> Dependencies are usually added near the .c files that use them. That's
> >> a bit messy of course if you have an "#include <>" in a heavily-included
> >> QEMU header. You can consider it a way to di
ISM device firmware stores unique state information that can
can cause a wholesale unmap of the associated IOMMU (e.g. when
we get a termination signal for QEMU) to trigger firmware errors
because firmware believes we are attempting to invalidate entries
that are still in-use by the guest OS (when
> 2022年12月9日 17:44，Christopher Wrogg 写道：
>
> I tried both.
>
> Option 1
> What I did:
> #undef TARGET_VIRT_ADDR_SPACE_BITS and #define
> TARGET_VIRT_ADDR_SPACE_BITS 64
> The Result:
> perror reports "Cannot allocate memory"
> Option 2:
> What I did:
> TA
Il ven 9 dic 2022, 20:54 Peter Maydell ha
scritto:
> > - placing pkg-config output directly in $(QEMU_CFLAGS) and $(LIBS).
> > This caused binaries to have unnecessary dependencies at times.
>
> Yeah, this is what I think of as "the standard thing".
>
Got it, and it wasn't exactly what QEMU was
Markus Armbruster writes:
> hw/cxl/cxl_pci.h and hw/cxl/cxl_cdat.h include each other. Neither
> header actually needs the other one. Drop both #include directives.
>
> Signed-off-by: Markus Armbruster
> ---
> include/hw/cxl/cxl_cdat.h | 1 -
> include/hw/cxl/cxl_pci.h | 1 -
> 2 files chang
"Michael S. Tsirkin" writes:
> On Fri, Dec 09, 2022 at 02:47:58PM +0100, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster
>
> Thanks!
> How can I verify this is correct, i.e. that none
> of the headers that we remove is actually needed?
I think the pragmatic way forward is to let th
101 - 187 of 187 matches
Mail list logo
