On 12/9/22 15:21, Philippe Mathieu-Daudé wrote:
On 9/12/22 14:54, Paolo Bonzini wrote:
On 12/9/22 13:55, Philippe Mathieu-Daudé wrote:

+  printf "%s\n" '  --disable-debug-info     Enable debug symbols and other information'

We should get '--enable-debug-info' here, ...

    printf "%s\n" '  --disable-install-blobs  install provided firmware blobs'

... and here. Do we have a bug in meson-buildoptions.py?

No, for boolean options it only includes the non-default setting. This behavior was copied from the prior handcrafted help output:

   --with-devices-ARCH=NAME override default configs/devices
   --enable-debug           enable common debug build options
   --enable-sanitizers      enable default sanitizers
   --enable-tsan            enable thread sanitizer
   --disable-strip          disable stripping binaries
   --disable-werror         disable compilation abort on warning
   --disable-stack-protector disable compiler-provided stack protection

These are correct... For debug-info I'd expect that (change on top of
your patch):

-  printf "%s\n" '  --disable-debug-info     Enable debug symbols and other information' +  printf "%s\n" '  --disable-debug-info     Disable debug symbols and other information'

Ahh, I see now.  Yeah, it is inconsistent, I'll just drop this patch.

Paolo


Reply via email to