Monitor commands related to display server passwords

We have a couple of password-related commands, and I'm not sure about which ones should be used. In order of appearance: * HMP change vnc Change a VNC server password. Unlike set_password below, there's no way to select a display other than the first. Note: if change's second argument is

[PATCH] vhost: Not return fail while the device does not support send_iotlb_msg

Some device does not support vhost_send_device_iotlb_msg() such as vDPA device, which is as expected. So we should not return fail here. Signed-off-by: Cindy Lu --- hw/virtio/vhost-backend.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio/vhost-backend.c b/hw/vi

Re: [PATCH v14 4/5] hw/riscv: virt: Add PMU DT node to the device tree

On Tue, Nov 29, 2022 at 3:54 PM wrote: > > +CC Rob, which I probably should've done earlier, so > context all preserved > > On 29/11/2022 09:42, Conor Dooley wrote: > > On 29/11/2022 09:27, Atish Kumar Patra wrote: > >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the >

Re: regression: insmod module failed in VM with nvdimm on

On Wed, 30 Nov 2022 at 08:53, Marc Zyngier wrote: > > On Wed, 30 Nov 2022 02:52:35 +, > "chenxiang (M)" wrote: > > > > Hi, > > > > We boot the VM using following commands (with nvdimm on) (qemu > > version 6.1.50, kernel 6.0-r4): > > How relevant is the presence of the nvdimm? Do you observe

Re: [PATCH 1/1] Fix some typos

On 30/11/22 02:53, Dongdong Zhang wrote: Fix some typos in 'python' directory. Signed-off-by: Dongdong Zhang Reviewed-by: Philippe Mathieu-Daudé --- python/qemu/machine/console_socket.py | 2 +- python/qemu/machine/qtest.py | 2 +- python/qemu/qmp/protocol.py | 2 +-

Re: [PATCH v14 4/5] hw/riscv: virt: Add PMU DT node to the device tree

On 30/11/2022 08:13, Atish Kumar Patra wrote: > In Linux DT binding or dt schema repo ? I am a bit confused now as we > talked about both above :). I asked about a dt-binding and not a schema change, so the former ;)

Re: [PATCH for-7.2] target/arm: Set TCGCPUOps.restore_state_to_opc for v7m

On 29/11/22 21:41, Richard Henderson wrote: This setting got missed, breaking v7m. Fixes: 56c6c98df85c ("target/arm: Convert to tcg_ops restore_state_to_opc") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1347 Signed-off-by: Richard Henderson --- target/arm/internals.h | 4

Re: Monitor commands related to display server passwords

On Wed, Nov 30, 2022 at 09:02:56AM +0100, Markus Armbruster wrote: > We have a couple of password-related commands, and I'm not sure about > which ones should be used. In order of appearance: > > * HMP change vnc > > Change a VNC server password. Unlike set_password below, there's no > way

Re: QEMU 7.2 non-deterministic migration-test CI failure

* Stefan Hajnoczi (stefa...@redhat.com) wrote: > Hi, > The following cross-i386-tci migration-test failure was triggered by CI: > > >>> MALLOC_PERTURB_=133 > >>> G_TEST_DBUS_DAEMON=/builds/qemu-project/qemu/tests/dbus-vmstate-daemon.sh > >>> QTEST_QEMU_BINARY=./qemu-system-i386 > >>> /builds/qe

Re: [PATCH 1/1] tcg: convert tcg/README to rst

On 24/11/2022 13:21, Peter Maydell wrote: On Wed, 23 Nov 2022 at 09:54, Mark Cave-Ayland wrote: Convert tcg/README to rst and move it to docs/devel as a new "TCG Intermediate Representation" page. There are a few minor changes to improve the aesthetic of the final output which are as follows:

Re: [PATCH for-8.0 17/19] target/sparc: Convert to 3-phase reset

On 24/11/2022 11:50, Peter Maydell wrote: Convert the sparc CPU class to use 3-phase reset, so it doesn't need to use device_class_set_parent_reset() any more. Signed-off-by: Peter Maydell --- target/sparc/cpu-qom.h | 4 ++-- target/sparc/cpu.c | 12 2 files changed, 10 i

Re: [PATCH v2 for-8.0 0/5] scripts/make-release: Decrease size of the release tarballs

On 28/11/2022 19:25, Paolo Bonzini wrote: Il lun 28 nov 2022, 18:04 Daniel P. Berrangé > ha scritto: With my distro maintainer hat I would rather QEMU ship neither the ROM source, nor the ROM binaries. Annd since QEMU can finally cross compile its embedded

Re: [PATCH v9 1/8] mm: Introduce memfd_restricted system call to create restricted user memory

On Tue, Nov 29, 2022 at 01:18:15PM -0600, Michael Roth wrote: > On Tue, Nov 29, 2022 at 01:06:58PM -0600, Michael Roth wrote: > > On Tue, Nov 29, 2022 at 10:06:15PM +0800, Chao Peng wrote: > > > On Mon, Nov 28, 2022 at 06:37:25PM -0600, Michael Roth wrote: > > > > On Tue, Oct 25, 2022 at 11:13:37PM

[PATCH v4 03/14] vfio/migration: Fix NULL pointer dereference bug

As part of its error flow, vfio_vmstate_change() accesses MigrationState->to_dst_file without any checks. This can cause a NULL pointer dereference if the error flow is taken and MigrationState->to_dst_file is not set. For example, this can happen if VM is started or stopped not during migration a

[PATCH v4 04/14] vfio/migration: Allow migration without VFIO IOMMU dirty tracking support

Currently, if IOMMU of a VFIO container doesn't support dirty page tracking, migration is blocked. This is because a DMA-able VFIO device can dirty RAM pages without updating QEMU about it, thus breaking the migration. However, this doesn't mean that migration can't be done at all. In such case, a

[PATCH v4 08/14] vfio/migration: Rename functions/structs related to v1 protocol

To avoid name collisions, rename functions and structs related to VFIO migration protocol v1. This will allow the two protocols to co-exist when v2 protocol is added, until v1 is removed. No functional changes intended. Signed-off-by: Avihai Horon --- hw/vfio/common.c | 6 +- hw/v

[PATCH v4 09/14] vfio/migration: Implement VFIO migration protocol v2

Add implementation of VFIO migration protocol v2. The two protocols, v1 and v2, will co-exist and in next patch v1 protocol will be removed. There are several main differences between v1 and v2 protocols: - VFIO device state is now represented as a finite state machine instead of a bitmap. - Mi

[PATCH v4 01/14] migration: No save_live_pending() method uses the QEMUFile parameter

From: Juan Quintela So remove it everywhere. Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Dr. David Alan Gilbert --- hw/s390x/s390-stattrib.c | 2 +- hw/vfio/migration.c| 3 +-- include/migration/register.h | 3 +-- migration/block-d

[PATCH v4 11/14] vfio: Alphabetize migration section of VFIO trace-events file

Sort the migration section of VFIO trace events file alphabetically and move two misplaced traces to common.c section. Signed-off-by: Avihai Horon --- hw/vfio/trace-events | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/hw/vfio/trace-events b/hw/vfio/tr

[PATCH v4 02/14] migration: Simplify migration_iteration_run()

From: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Avihai Horon --- migration/migration.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index edefba954e..630e4af02f 100644 --- a/migrati

[PATCH v4 00/14] vfio/migration: Implement VFIO migration protocol v2

Hello, A long time has passed since v2 of this series was posted. During this time we had several KVM calls discussing the problems that were needed to be solved in order to move forward. This version of the series includes quite some changes, and I believe that it addresses all the major problem

[PATCH v4 14/14] vfio/migration: Optimize vfio_save_pending()

During pre-copy phase of migration vfio_save_pending() is called repeatedly and queries the VFIO device for its pending data size. As long as pending RAM size is over the threshold, migration can't converge and be completed. Therefore, during this time there is no point in querying the VFIO device

[PATCH v4 13/14] vfio/migration: Use VFIO_DEVICE_FEATURE_MIG_DATA_SIZE ioctl

Use VFIO_DEVICE_FEATURE_MIG_DATA_SIZE ioctl to query the device stop copy data size and report this value in vfio_save_pending() instead of the hardcoded value that is currently used. Use this ioctl in vfio_save_setup() as well, to adjust the migration data buffer size. Signed-off-by: Avihai Horo

[PATCH v4 12/14] docs/devel: Align vfio-migration docs to VFIO migration v2

Align the vfio-migration documentation to VFIO migration protocol v2. Signed-off-by: Avihai Horon --- docs/devel/vfio-migration.rst | 68 --- 1 file changed, 30 insertions(+), 38 deletions(-) diff --git a/docs/devel/vfio-migration.rst b/docs/devel/vfio-migration.

[PATCH v4 06/14] vfio/common: Change vfio_devices_all_running_and_saving() logic to equivalent one

vfio_devices_all_running_and_saving() is used to check if migration is in pre-copy phase. This is done by checking if migration is in setup or active states and if all VFIO devices are in pre-copy state, i.e. _SAVING | _RUNNING. In VFIO migration protocol v2 pre-copy support is made optional. Henc

[PATCH v4 05/14] migration/qemu-file: Add qemu_file_get_to_fd()

Add new function qemu_file_get_to_fd() that allows reading data from QEMUFile and writing it straight into a given fd. This will be used later in VFIO migration code. Signed-off-by: Avihai Horon Reviewed-by: Vladimir Sementsov-Ogievskiy --- migration/qemu-file.c | 34 ++

[PATCH v4 10/14] vfio/migration: Remove VFIO migration protocol v1

Now that v2 protocol implementation has been added, remove the deprecated v1 implementation. Signed-off-by: Avihai Horon --- hw/vfio/common.c | 19 +- hw/vfio/migration.c | 695 +- hw/vfio/trace-events | 8 - include/hw/vfio/vfio

[PATCH v4 07/14] vfio/migration: Move migration v1 logic to vfio_migration_init()

Move vfio_dev_get_region_info() logic from vfio_migration_probe() to vfio_migration_init(). This logic is specific to v1 protocol and moving it will make it easier to add the v2 protocol implementation later. No functional changes intended. Signed-off-by: Avihai Horon --- hw/vfio/migration.c |

Re: [qemu-web PATCH v2] Add a blog post about zoned storage emulation

On 28/11/2022 22.13, Stefan Hajnoczi wrote: Cool, thanks for writing up your zoned block emulation work! Reviewed-by: Stefan Hajnoczi Thanks, I've pushed it now to the server: https://www.qemu.org/2022/11/17/zoned-emulation/ Thomas

[PATCH v2 0/1] tcg: convert tcg/README to rst

This is something I've had lying around in the background for a while, and I finally managed to get it in a state suitable for submission. The main motivation was that I wanted to have a TCG operation reference that was easily viewable online in a web browser. The patch converts tcg/README to rst

Re: [PATCH for-8.0 2/2] hw/input/ps2.c: Convert TYPE_PS2_{KBD, MOUSE}_DEVICE to 3-phase reset

On 9/11/22 18:00, Peter Maydell wrote: Convert the child classes TYPE_PS2_KBD_DEVICE and TYPE_PS2_MOUSE_DEVICE to the 3-phase reset system. This allows us to stop using the old device_class_set_parent_reset() function. We don't need to register an 'exit' phase function for the subclasses, becau

[PATCH v2 1/1] tcg: convert tcg/README to rst

Convert tcg/README to rst and move it to docs/devel as a new "TCG Intermediate Representation" page. There are a few minor changes to improve the aesthetic of the final output which are as follows: - Rename the title from "Tiny Code Generator - Fabrice Bellard" to "TCG Intermediate Represent

Re: [PATCH for-8.0 1/9] hw/s390x/s390-pci-inst.c: Use device_cold_reset() to reset PCI devices

On 4/11/22 17:15, Peter Maydell wrote: The semantic difference between the deprecated device_legacy_reset() function and the newer device_cold_reset() function is that the new function resets both the device itself and any qbuses it owns, whereas the legacy function resets just the device itself

[PATCH v4] hw/loongarch/virt: Add cfi01 pflash device

Add cfi01 pflash device for LoongArch virt machine Signed-off-by: Xiaojuan Yang --- hw/loongarch/Kconfig| 1 + hw/loongarch/acpi-build.c | 18 +++ hw/loongarch/virt.c | 62 + include/hw/loongarch/virt.h | 5 +++ 4 files changed, 86

Re: regression: insmod module failed in VM with nvdimm on #forregzbot

[Note: this mail is primarily send for documentation purposes and/or for regzbot, my Linux kernel regression tracking bot. That's why I removed most or all folks from the list of recipients, but left any that looked like a mailing lists. These mails usually contain '#forregzbot' in the subject, to

Re: [PATCH for-8.0 4/9] hw/usb/hcd-xhci: Reset the XHCIState with device_cold_reset()

On 4/11/22 17:15, Peter Maydell wrote: Currently the hcd-xhci-pci and hcd-xhci-sysbus devices, which are s/which// ? mostly wrappers around the TYPE_XHCI device, which is a direct subclass of TYPE_DEVICE. Since TYPE_DEVICE devices are not on any qbus and do not get automatically reset, the w

Re: [PATCH for-8.0 6/9] hw/hyperv/vmbus: Use device_cold_reset() and bus_cold_reset()

On 4/11/22 17:15, Peter Maydell wrote: In the vmbus code we currently use the legacy functions qdev_reset_all() and qbus_reset_all(). These perform a recursive reset, starting from either a qbus or a qdev. However they do not permit any of the devices in the tree to use three-phase reset, becau

Re: [PATCH for-8.0 7/9] Replace use of qdev_reset_all() with device_cold_reset()

On 4/11/22 17:15, Peter Maydell wrote: The legacy function qdev_reset_all() performs a recursive reset, starting from a qdev. However, it does not permit any of the devices in the tree to use three-phase reset, because device reset goes through the device_legacy_reset() function that only calls

Re: [PATCH 17/26] target/s390x: Introduce help_goto_indirect

On Wed, Oct 05, 2022 at 08:44:12PM -0700, Richard Henderson wrote: > Add a small helper to handle unconditional indirect jumps. > > Signed-off-by: Richard Henderson > --- > target/s390x/tcg/translate.c | 19 ++- > 1 file changed, 10 insertions(+), 9 deletions(-) Reviewed-by: Ily

Re: [PATCH for-8.0 2/2] hw/misc: Convert TYPE_MOS6522 subclasses to 3-phase reset

On 10/11/22 15:34, Peter Maydell wrote: Convert the various subclasses of TYPE_MOS6522 to 3-phase reset. This removes some uses of device_class_set_parent_reset(), which we would eventually like to be able to get rid of. Signed-off-by: Peter Maydell --- include/hw/misc/mos6522.h | 2 +- hw/

Re: [PATCH for-8.0 3/7] pci: Convert TYPE_PCIE_ROOT_PORT to 3-phase reset

On 25/11/22 12:52, Peter Maydell wrote: Convert the TYPE_PCIE_ROOT_PORT device to 3-phase reset; this is a necessary precursor to converting any of its child classes. Signed-off-by: Peter Maydell --- hw/pci-bridge/pcie_root_port.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-)

Re: [PATCH for-8.0 5/7] hw/intc/xics: Reset TYPE_ICS objects with device_cold_reset()

On 25/11/22 14:45, Greg Kurz wrote: On Fri, 25 Nov 2022 13:24:00 +0100 Cédric Le Goater wrote: On 11/25/22 12:52, Peter Maydell wrote: The realize method for the TYPE_ICS class uses qemu_register_reset() to register a reset handler, as a workaround for the fact that currently objects which di

Re: [PATCH for-8.0 6/7] hw/intc/xics: Convert TYPE_ICS to 3-phase reset

On 25/11/22 12:52, Peter Maydell wrote: Convert the TYPE_ICS class to 3-phase reset; this will allow us to convert the TYPE_PHB3_MSI class which inherits from it. Signed-off-by: Peter Maydell --- hw/intc/xics.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) Reviewed-by: Phi

Re: [PATCH for-8.0 7/7] hw/pci-host/pnv_phb3_msi: Convert TYPE_PHB3_MSI to 3-phase reset

On 25/11/22 12:52, Peter Maydell wrote: Convert the TYPE_PHB3_MSI class to 3-phase reset, so we can avoid using the device_class_set_parent_reset() function. Signed-off-by: Peter Maydell --- include/hw/ppc/xics.h | 2 +- hw/pci-host/pnv_phb3_msi.c | 15 +-- 2 files changed

Re: [PATCH] docs/devel/reset.rst: Correct function names

On 25/11/22 15:06, Akihiko Odaki wrote: resettable_class_set_parent_phases() was mistakenly called resettable_class_set_parent_reset_phases() in some places. Signed-off-by: Akihiko Odaki --- docs/devel/reset.rst | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) Review

Re: [PATCH v2] e1000: Configure ResettableClass

On 25/11/22 15:32, Akihiko Odaki wrote: This is part of recent efforts of refactoring e1000 and e1000e. DeviceClass's reset member is deprecated so migrate to ResettableClass. Thre is no behavioral difference. Typo "There" (also in your e1000e v2 patch). Signed-off-by: Akihiko Odaki ---

Re: [PATCH v3 7/7] hw/virtio: generalise CHR_EVENT_CLOSED handling

Raphael Norwitz writes: >> On Nov 29, 2022, at 12:30 AM, Michael S. Tsirkin wrote: >> >> On Tue, Nov 29, 2022 at 05:18:58AM +, Raphael Norwitz wrote: On Nov 28, 2022, at 11:41 AM, Alex Bennée wrote: ..and use for both virtio-user-blk and virtio-user-gpio. This avoids

Re: [PATCH v3 7/7] hw/virtio: generalise CHR_EVENT_CLOSED handling

On Wed, Nov 30, 2022 at 10:25:58AM +, Alex Bennée wrote: > > Raphael Norwitz writes: > > >> On Nov 29, 2022, at 12:30 AM, Michael S. Tsirkin wrote: > >> > >> On Tue, Nov 29, 2022 at 05:18:58AM +, Raphael Norwitz wrote: > On Nov 28, 2022, at 11:41 AM, Alex Bennée wrote: > >

Re: [PATCH for-8.0 2/9] hw/arm: Convert TYPE_ARM_SMMUV3 to 3-phase reset

On 9/11/22 17:14, Peter Maydell wrote: Convert the TYPE_ARM_SMMUV3 device to 3-phase reset. The legacy reset method doesn't do anything that's invalid in the hold phase, so the conversion only requires changing it to a hold phase method, and using the 3-phase versions of the "save the parent res

Re: [PATCH for-8.0 4/9] hw/intc: Convert TYPE_ARM_GIC_KVM to 3-phase reset

On 9/11/22 17:14, Peter Maydell wrote: Now we have converted TYPE_ARM_GIC_COMMON, we can convert the TYPE_ARM_GIC_KVM subclass to 3-phase reset. Signed-off-by: Peter Maydell --- hw/intc/arm_gic_kvm.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) Reviewed-by: Philippe

Re: [PATCH for-8.0 5/9] hw/intc: Convert TYPE_ARM_GICV3_COMMON to 3-phase reset

On 9/11/22 17:14, Peter Maydell wrote: Convert the TYPE_ARM_GICV3_COMMON parent class to 3-phase reset. Signed-off-by: Peter Maydell --- hw/intc/arm_gicv3_common.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH for-8.0 6/9] hw/intc: Convert TYPE_KVM_ARM_GICV3 to 3-phase reset

On 9/11/22 17:14, Peter Maydell wrote: Convert the TYPE_KVM_ARM_GICV3 device to 3-phase reset. Signed-off-by: Peter Maydell --- hw/intc/arm_gicv3_kvm.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH for-8.0 9/9] hw/intc: Convert TYPE_KVM_ARM_ITS to 3-phase reset

On 9/11/22 17:14, Peter Maydell wrote: Convert the TYPE_KVM_ARM_ITS device to 3-phase reset. Signed-off-by: Peter Maydell --- hw/intc/arm_gicv3_its_kvm.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH for-8.0 8/9] hw/intc: Convert TYPE_ARM_GICV3_ITS to 3-phase reset

On 9/11/22 17:14, Peter Maydell wrote: Convert the TYPE_ARM_GICV3_ITS device to 3-phase reset. Signed-off-by: Peter Maydell --- hw/intc/arm_gicv3_its.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH for-8.0 4/7] pci: Convert child classes of TYPE_PCIE_ROOT_PORT to 3-phase reset

On 25/11/22 12:52, Peter Maydell wrote: Convert the TYPE_CXL_ROOT_PORT and TYPE_PNV_PHB_ROOT_PORT classes to 3-phase reset, so they don't need to use the deprecated device_class_set_parent_reset() function any more. We have to do both in the same commit, because they keep the parent_reset field

Re: [PATCH for-8.0 2/7] hw/display/virtio-vga: Convert TYPE_VIRTIO_VGA_BASE to 3-phase reset

On 25/11/22 12:52, Peter Maydell wrote: Convert the TYPE_VIRTIO_VGA_BASE class to 3-phase reset, so we don't need to use device_class_set_parent_reset() any more. Note that this is an abstract class itself; none of the subclasses override its reset method. Signed-off-by: Peter Maydell --- hw

Re: [PATCH v4] hw/loongarch/virt: Add cfi01 pflash device

On 30/11/22 11:06, Xiaojuan Yang wrote: Add cfi01 pflash device for LoongArch virt machine Signed-off-by: Xiaojuan Yang --- hw/loongarch/Kconfig| 1 + hw/loongarch/acpi-build.c | 18 +++ hw/loongarch/virt.c | 62 + include/hw/l

Re: [PATCH v2 for-8.0 0/5] scripts/make-release: Decrease size of the release tarballs

On 28/11/2022 18.04, Daniel P. Berrangé wrote: On Mon, Nov 28, 2022 at 10:25:50AM +0100, Thomas Huth wrote: Our release tarballs are huge - qemu-7.2.0-rc2.tar.xz has a size of 116 MiB. If you look at the contents, approx. 80% of the size is used for the firmware sources that we ship along to pro

Re: [PATCH for-8.0 00/19] Convert most CPU classes to 3-phase reset

On 24/11/22 14:46, Philippe Mathieu-Daudé wrote: On 24/11/22 12:50, Peter Maydell wrote: This patchset converts the TYPE_CPU base class and most subclasses to use 3-phase reset. (The exception is s390, which is doing something a bit odd with its reset, so the conversion there isn't going to be s

Re: [PATCH v2 for-8.0 5/5] scripts/make-release: Move roms into separate tarball

On 28/11/2022 17.51, Stefan Hajnoczi wrote: On Mon, 28 Nov 2022 at 04:28, Thomas Huth wrote: Our current release tarballs are huge and caused already some trouble with the server traffic in the past. However, the biggest chunk (~80%) of the tarball is caused by the firmware sources - which mos

[PATCH for-8.0] hw/misc: Move some arm-related files from specific_ss into softmmu_ss

By removing #include "kvm-consts.h" from arm-powerctl.h (seems not to be required there) and adjusting the header includes in some files, we can move them from specific_ss into softmmu_ss, so that they only need to be compiled once and not for qemu-system-arm and qemu-system-aarch64 individually.

Re: [PATCH v2 for-8.0 2/2] pci: drop redundant PCIDeviceClass::is_bridge field

On Tue, 29 Nov 2022 11:13:41 +0100 Igor Mammedov wrote: > and use cast to TYPE_PCI_BRIDGE instead. > > Signed-off-by: Igor Mammedov > Reviewed-by: Philippe Mathieu-Daudé > --- > v2: >(Philippe Mathieu-Daudé ) > - replace leftover IS_PCI_BRIDGE cast with is_bridge variable > --- > in

[PATCH for 7.2 v4 0/5] final vhost-user fixes

Hi Michael, Following feedback from the previous posting I've dropped the setting of host_features (probably and overfix while chasing other issues). I've re-ordered the series so the "VM state takes precedence" patch is the last one. I'm going to demur on fixing up vhost-net which on the surface

[PATCH v4 3/5] hw/virtio: add started_vu status field to vhost-user-gpio

As per the fix to vhost-user-blk in f5b22d06fb (vhost: recheck dev state in the vhost_migration_log routine) we really should track the connection and starting separately. Signed-off-by: Alex Bennée Reviewed-by: Michael S. Tsirkin --- include/hw/virtio/vhost-user-gpio.h | 10 ++ hw/virt

[PATCH v4 4/5] hw/virtio: generalise CHR_EVENT_CLOSED handling

..and use for both virtio-user-blk and virtio-user-gpio. This avoids the circular close by deferring shutdown due to disconnection until a later point. virtio-user-blk already had this mechanism in place so generalise it as a vhost-user helper function and use for both blk and gpio devices. While

[PATCH v4 2/5] vhost: enable vrings in vhost_dev_start() for vhost-user devices

From: Stefano Garzarella Commit 02b61f38d3 ("hw/virtio: incorporate backend features in features") properly negotiates VHOST_USER_F_PROTOCOL_FEATURES with the vhost-user backend, but we forgot to enable vrings as specified in docs/interop/vhost-user.rst: If ``VHOST_USER_F_PROTOCOL_FEATURES``

[PATCH v4 5/5] include/hw: VM state takes precedence in virtio_device_should_start

The VM status should always preempt the device status for these checks. This ensures the device is in the correct state when we suspend the VM prior to migrations. This restores the checks to the order they where in before the refactoring moved things around. While we are at it lets improve our do

[PATCH v4 1/5] tests/qtests: override "force-legacy" for gpio virtio-mmio tests

The GPIO device is a VIRTIO_F_VERSION_1 devices but running with a legacy MMIO interface we miss out that feature bit causing confusion. For the GPIO test force the mmio bus to support non-legacy so we can properly test it. Signed-off-by: Alex Bennée Reviewed-by: Michael S. Tsirkin Resolves: htt

Re: [PATCH v3 7/7] hw/virtio: generalise CHR_EVENT_CLOSED handling

"Michael S. Tsirkin" writes: > On Wed, Nov 30, 2022 at 10:25:58AM +, Alex Bennée wrote: >> >> Raphael Norwitz writes: >> >> >> On Nov 29, 2022, at 12:30 AM, Michael S. Tsirkin wrote: >> >> >> >> On Tue, Nov 29, 2022 at 05:18:58AM +, Raphael Norwitz wrote: >> On Nov 28, 2022, a

Re: [PATCH v3 3/3] tests/qtest: sifive-e-aon-watchdog-test.c : Add QTest of watchdog of sifive_e

On 30/11/2022 02.54, Tommy Wu wrote: Add some simple tests of the watchdog timer in the always-on domain device of HiFive 1 rev b. Signed-off-by: Tommy Wu --- ... diff --git a/tests/qtest/sifive-e-aon-watchdog-test.c b/tests/qtest/sifive-e-aon-watchdog-test.c new file mode 100644 index 0

[RESEND PATCH] ide: Add "ide-cf" driver, a CompactFlash card

This allows attaching IDE_CFATA device to an IDE bus. Behaves like a CompactFlash card in True IDE mode. Tested with: qemu-system-i386 \ -device driver=ide-cf,drive=cf,bus=ide.0 \ -drive id=cf,index=0,format=raw,if=none,file=cf.img Signed-off-by: Lubomir Rintel --- hw/ide/qdev.c | 32

[RESEND PATCH] ide: Add 8-bit data mode

CompactFlash uses features 0x01 and 0x81 to enable/disable 8-bit data path. Implement them. Signed-off-by: Lubomir Rintel --- hw/ide/core.c | 43 ++- include/hw/ide/internal.h | 1 + 2 files changed, 34 insertions(+), 10 deletions(-) diff --git a

Re: [PATCH 19/26] target/s390x: Simplify help_branch

On Wed, Oct 05, 2022 at 08:44:14PM -0700, Richard Henderson wrote: > Always use a tcg branch, instead of movcond. The movcond > was not a bad idea before PER was added, but since then > we have either 2 or 3 actions to perform on each leg of > the branch, and multiple movcond is inefficient. > >

Re: [PATCH v2 for-8.0 0/5] scripts/make-release: Decrease size of the release tarballs

On Wed, Nov 30, 2022 at 11:49:50AM +0100, Thomas Huth wrote: > On 28/11/2022 18.04, Daniel P. Berrangé wrote: > > On Mon, Nov 28, 2022 at 10:25:50AM +0100, Thomas Huth wrote: > > > Our release tarballs are huge - qemu-7.2.0-rc2.tar.xz has a size of 116 > > > MiB. If you look at the contents, approx

Re: [PATCH 20/26] target/s390x: Split per_breaking_event from per_branch_*

On Wed, Oct 05, 2022 at 08:44:15PM -0700, Richard Henderson wrote: > This allows us to update gbea before other updates to psw_addr, > which will be important for TARGET_TB_PCREL. > > Signed-off-by: Richard Henderson > --- > target/s390x/tcg/translate.c | 7 --- > 1 file changed, 4 insertion

Re: [PATCH v4 1/5] tests/qtests: override "force-legacy" for gpio virtio-mmio tests

On 30/11/2022 12.24, Alex Bennée wrote: The GPIO device is a VIRTIO_F_VERSION_1 devices but running with a legacy MMIO interface we miss out that feature bit causing confusion. For the GPIO test force the mmio bus to support non-legacy so we can properly test it. Signed-off-by: Alex Bennée Revi

Re: [PATCH for-8.0 0/7] virtio, pci, xics: 3-phase reset conversions

On 11/25/22 08:52, Peter Maydell wrote: This patchset converts a miscellaneous collection of classes to 3-phase reset. The common link, as with other series I've sent out recently, is converting child classes that currently use device_class_set_parent_reset() so that we can remove that functio

Re: [PATCH v2 5/8] hw/arm/virt: Fix devicetree warnings about the GPIO node

On Tue, 29 Nov 2022 at 20:56, Rob Herring wrote: > > On Tue, Sep 27, 2022 at 6:25 AM Peter Maydell > wrote: > > > > On Tue, 27 Sept 2022 at 11:12, Jean-Philippe Brucker > > wrote: > > > > > > Since the pl061 device can be used as interrupt controller, its node > > > should contain "interrupt-co

Re: Who / what uses QMP command add_client?

Daniel P. Berrangé writes: > On Tue, Nov 29, 2022 at 03:54:56PM +0100, Markus Armbruster wrote: >> QMP command add_client's schema: >> >> ## >> # @add_client: >> # >> # Allow client connections for VNC, Spice and socket based >> # character devices to be passed in to QEMU via

Re: [PATCH for-8.0 00/19] Convert most CPU classes to 3-phase reset

On Wed, 30 Nov 2022 at 10:51, Philippe Mathieu-Daudé wrote: > > On 24/11/22 14:46, Philippe Mathieu-Daudé wrote: > > On 24/11/22 12:50, Peter Maydell wrote: > >> This patchset converts the TYPE_CPU base class and most subclasses > >> to use 3-phase reset. (The exception is s390, which is doing > >

Re: Who / what uses QMP command add_client?

Marc-André Lureau writes: > Hi > > On Tue, Nov 29, 2022 at 6:55 PM Markus Armbruster wrote: > >> QMP command add_client's schema: >> >> ## >> # @add_client: >> # >> # Allow client connections for VNC, Spice and socket based >> # character devices to be passed in to QEMU via S

Re: Who / what uses QMP command add_client?

On Wed, Nov 30, 2022 at 01:30:43PM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Tue, Nov 29, 2022 at 03:54:56PM +0100, Markus Armbruster wrote: > >> QMP command add_client's schema: > >> > >> ## > >> # @add_client: > >> # > >> # Allow client connections f

Re: [PATCH for-8.0 00/19] Convert most CPU classes to 3-phase reset

On 30/11/22 13:38, Peter Maydell wrote: On Wed, 30 Nov 2022 at 10:51, Philippe Mathieu-Daudé wrote: On 24/11/22 14:46, Philippe Mathieu-Daudé wrote: On 24/11/22 12:50, Peter Maydell wrote: This patchset converts the TYPE_CPU base class and most subclasses to use 3-phase reset. (The exception

Re: Monitor commands related to display server passwords

Daniel P. Berrangé writes: > On Wed, Nov 30, 2022 at 09:02:56AM +0100, Markus Armbruster wrote: >> We have a couple of password-related commands, and I'm not sure about >> which ones should be used. In order of appearance: >> >> * HMP change vnc >> >> Change a VNC server password. Unlike se

[PATCH-for-8.0 3/3] tcg: Replace tcg_target_ulong -> uintptr_t

Mechanical transformation using: $ sed -e 's/tcg_target_ulong/uintptr_t/g' \ -e 's/TCG_PRIlx/PRIxPTR/g' \ -i $(git grep -lE '(tcg_target_ulong|TCG_PRIlx)') Simplify the check for unsupported TCG_TARGET_REG_BITS in include/tcg/tcg.h. Suggested-by: Richard Henderson Signed-off-by:

[PATCH-for-8.0 1/3] tcg/s390x: Fix coding style

We are going to modify this code, so fix its style first to avoid: ERROR: spaces required around that '*' (ctx:VxV) #281: FILE: tcg/s390x/tcg-target.c.inc:1224: +uintptr_t mask = ~(0xull << i*16); ^ Signed-off-by: Philippe Mathieu-Daud

[PATCH-for-8.0 0/3] tcg: Replace tcg_target_[u]long -> [u]intptr_t

Trivial cleanup (99% mechanical) suggested by rth: the tcg_target_[u]long type is redundant with [u]intptr_t. Philippe Mathieu-Daudé (3): tcg/s390x: Fix coding style tcg: Replace tcg_target_long -> intptr_t tcg: Replace tcg_target_ulong -> uintptr_t accel/tcg/cputlb.c|

[PATCH-for-8.0 2/3] tcg: Replace tcg_target_long -> intptr_t

Mechanical transformation using: $ sed -e 's/tcg_target_long/intptr_t/g' \ -i $(git grep -l tcg_target_long) Note, the TCG_PRIld format was not used; simply remove it. Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- accel/tcg/cputlb.c | 4 +--

Re: Monitor commands related to display server passwords

On Wed, Nov 30, 2022 at 02:25:53PM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > In 6.0 I introduced support for 'password-secret' to SPICE and VNC > > command line. > > > > I don't know why, but I only deprecated 'password' in SPICE and > > not in VNC. > > I figure you mean >

Re:[PATCH v7 9/9] disas/riscv.c: add disasm support for Zc*

At 2022-11-29 10:43:43, "Weiwei Li" wrote: >Zcmp/Zcmt instructions will override disasm for c.fld*/c.fsd* >instructions currently we might make a encode using top 16 bits of flags in struct disassemble_info, to describe enable status of zc-subsets. Then we can pass it to disasm_inst in print_ins

Re:[PATCH v7 9/9] disas/riscv.c: add disasm support for Zc*

At 2022-11-29 10:43:43, "Weiwei Li" wrote: >Zcmp/Zcmt instructions will override disasm for c.fld*/c.fsd* >instructions currently > >Signed-off-by: Weiwei Li >Signed-off-by: Junqiang Wang >Acked-by: Alistair Francis >--- > disas/riscv.c | 287 +-

Re: Who / what uses QMP command add_client?

Daniel P. Berrangé writes: > On Wed, Nov 30, 2022 at 01:30:43PM +0100, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Tue, Nov 29, 2022 at 03:54:56PM +0100, Markus Armbruster wrote: >> >> QMP command add_client's schema: >> >> >> >> ## >> >> # @add_client: >> >>

Re: [RESEND PATCH] ide: Add 8-bit data mode

Queued, thanks. Paolo

[PATCH-for-8.0 0/5] cpu: Move target-independent code to common code

Trivial housekeeping in cpu*.c. Philippe Mathieu-Daudé (5): cpu: Remove capstone meson dependency cpu: Move cpu_class_init_props() to common code cpu: Move breakpoint helpers to common code cpu: Move cpu_abort() to common code cpu: Remove unused includes cpu.c | 165 ---

Re: [RESEND PATCH] ide: Add "ide-cf" driver, a CompactFlash card

Queued, thanks. Paolo

[PATCH-for-8.0 5/5] cpu: Remove unused includes

Signed-off-by: Philippe Mathieu-Daudé --- cpu.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/cpu.c b/cpu.c index d6936a536b..d512b24c0a 100644 --- a/cpu.c +++ b/cpu.c @@ -31,10 +31,7 @@ #endif #include "sysemu/tcg.h" #include "sysemu/kvm.h" -#include "exec/cpu-common.h" -#include "exe

[PATCH-for-8.0 4/5] cpu: Move cpu_abort() to common code

This code is not target-specific. Signed-off-by: Philippe Mathieu-Daudé --- cpu.c | 38 -- cpus-common.c | 38 ++ 2 files changed, 38 insertions(+), 38 deletions(-) diff --git a/cpu.c b/cpu.c index 385e72e140..d6936

[PATCH-for-8.0 3/5] cpu: Move breakpoint helpers to common code

This code is not target-specific. Signed-off-by: Philippe Mathieu-Daudé --- cpu.c | 71 -- cpus-common.c | 72 +++ 2 files changed, 72 insertions(+), 71 deletions(-) diff --git a/cpu.c b/cpu.

[PATCH-for-8.0 2/5] cpu: Move cpu_class_init_props() to common code

This code is not target-specific. Signed-off-by: Philippe Mathieu-Daudé --- cpu.c | 53 --- cpus-common.c | 53 +++ 2 files changed, 53 insertions(+), 53 deletions(-) diff --git a/cpu.c b/cpu

[PATCH-for-8.0 1/5] cpu: Remove capstone meson dependency

Only disas.c requires capstone CFLAGS, not cpu.c. Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 5c6b5a1c75..92d449f854 100644 --- a/meson.build +++ b/meson.build @@ -3097,11 +3097,12 @@

  1   2   >