On 3/11/22 02:50, Akihiko Odaki wrote:
This is yet another minor cleanup to ease understanding and
future refactoring of the tests.
Signed-off-by: Akihiko Odaki
---
tests/qtest/libqos/e1000e.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/qtest/libqos/e1000e.
On Thu, Nov 3, 2022 at 4:21 AM Jason Wang wrote:
>
> On Wed, Nov 2, 2022 at 7:19 PM Eugenio Perez Martin
> wrote:
> >
> > On Tue, Nov 1, 2022 at 9:10 AM Jason Wang wrote:
> > >
> > > On Fri, Oct 28, 2022 at 5:30 PM Eugenio Perez Martin
> > > wrote:
> > > >
> > > > On Fri, Oct 28, 2022 at 3:59
I'm not aware of any bug reports. L1 cache is typically shared between
logical threads, so it seemed reasonable to correct this.
On Fri, Oct 28, 2022 at 9:54 AM Wang, Lei wrote:
>
> On 10/10/2022 10:49 AM, Ilya Oleinik wrote:
> > For EBX bits 23 - 16 in CPUID[01] Intel's manual states:
> > "
> >
Nemonics E1000_STATUS_LAN_INIT_DONE and E1000_STATUS_ASDV_1000 have
the same value, and E1000_STATUS_ASDV_1000 should be used here because
E1000_STATUS_ASDV_1000 represents the auto-detected speed tested here
while E1000_STATUS_LAN_INIT_DONE is a value used for a different purpose
with a variant of
This fixes some compiler warnings with compiler flag
-Wmissing-variable-declarations (tested with clang):
aarch64_be-linux-user-gdbstub-xml.c:564:19: warning: no previous extern
declaration for non-static variable 'xml_builtin'
[-Wmissing-variable-declarations]
aarch64-linux-user-gdbstub
From: Helge Deller
Signed-off-by: Helge Deller
Reviewed-by: Richard Henderson
Message-Id:
Signed-off-by: Laurent Vivier
---
linux-user/strace.list | 3 +++
linux-user/syscall.c | 19 +++
2 files changed, 22 insertions(+)
diff --git a/linux-user/strace.list b/linux-user/st
x-user-for-7.2-pull-request
for you to fetch changes up to 16c81dd563b94e9392a578ccf5aa762d01e8f165:
linux-user: always translate cmsg when recvmsg (2022-11-02 17:29:17 +0100)
linux-user pull request 20221103
Fix recvmsg
Fix hppa
From: Icenowy Zheng
It's possible that a message contains both normal payload and ancillary
data in the same message, and even if no ancillary data is available
this information should be passed to the target, otherwise the target
cmsghdr will be left uninitialized and the target is going to acce
From: Helge Deller
The glibc on the hppa platform uses the "iitlbp %r0,(%sr0, %r0)"
assembler instruction as ABORT_INSTRUCTION.
If this (in userspace context) illegal assembler statement is found,
dump the registers and report the failure to userspace the same way as
the Linux kernel on physical
From: Helge Deller
Add missing timer_settime64() strace output and specify format for
timer_settime().
Signed-off-by: Helge Deller
Message-Id:
Signed-off-by: Laurent Vivier
---
linux-user/strace.list | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/linux-user/strace.l
On Wed, Nov 02, 2022 at 09:22:58PM +0100, Stefan Weil via wrote:
> The configure script fails because it tries to compile small C programs
> with a main function which is declared with arguments argc and argv
> although those arguments are unused.
>
> Running `configure -extra-cflags=-Wunused-para
Am 03.11.22 um 09:58 schrieb Daniel P. Berrangé:
On Wed, Nov 02, 2022 at 09:22:58PM +0100, Stefan Weil via wrote:
The configure script fails because it tries to compile small C programs
with a main function which is declared with arguments argc and argv
although those arguments are unused.
Run
On 01/11/22 9:15 pm, Daniel P. Berrangé wrote:
On Tue, Nov 01, 2022 at 09:10:14PM +0530, manish.mishra wrote:
On 01/11/22 8:21 pm, Daniel P. Berrangé wrote:
On Tue, Nov 01, 2022 at 02:30:29PM +, manish.mishra wrote:
Current logic assumes that channel connections on the destination side a
On Thu, Nov 03, 2022 at 02:50:25PM +0530, manish.mishra wrote:
>
> On 01/11/22 9:15 pm, Daniel P. Berrangé wrote:
> > On Tue, Nov 01, 2022 at 09:10:14PM +0530, manish.mishra wrote:
> > > On 01/11/22 8:21 pm, Daniel P. Berrangé wrote:
> > > > On Tue, Nov 01, 2022 at 02:30:29PM +, manish.mishra
On 10/28/22 07:04, Jason Wang wrote:
在 2022/10/21 17:09, Laurent Vivier 写道:
Signed-off-by: Laurent Vivier
Acked-by: Michael S. Tsirkin
---
I got this:
63/63 ERROR:../tests/qtest/netdev-socket.c:139:test_stream_inet_ipv6: assertion failed
(resp == expect): ("st0: index=0,type=stream,conne
Le 02/11/2022 à 21:24, Alex Bennée a écrit :
Bernhard Beschow writes:
GCC issues a false positive warning, resulting in build failure with -Werror:
In file included from /usr/lib/glib-2.0/include/glibconfig.h:9,
from /usr/include/glib-2.0/glib/gtypes.h:34,
Am 02.11.2022 um 03:49 hat Eric Biggers geschrieben:
> On Tue, Nov 01, 2022 at 07:27:16PM -0700, Eric Biggers wrote:
> > On Tue, Nov 01, 2022 at 03:00:30PM -0400, Stefan Hajnoczi wrote:
> > > Linux dm-crypt returns errno EIO from unaligned O_DIRECT pread(2) calls.
> >
> > Citation needed. For dir
The register definitions in tests/qtest/e1000e-test.c had names
different from hw/net/e1000_regs.h, which made it hard to understand
what test codes corresponds to the implementation. Use
hw/net/e1000_regs.h from tests/qtest/libqos/e1000e.c to remove
these duplications.
Signed-off-by: Akihiko Odak
Hi Gavin,
On 10/30/22 00:43, Gavin Shan wrote:
> The 3 high memory regions are usually enabled by default, but they may
> be not used. For example, VIRT_HIGH_GIC_REDIST2 isn't needed by GICv2.
> This leads to waste in the PA space.
>
> Add properties ("highmem-redists", "highmem-ecam", "highmem-mmi
This avoids some compilers complaining about a potentially
un-initialised [src|dst]argv. In retrospect using GString was overkill
for what we are constructing.
Signed-off-by: Alex Bennée
---
tests/unit/test-io-channel-command.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-
On 3/11/22 11:23, Alex Bennée wrote:
This avoids some compilers complaining about a potentially
un-initialised [src|dst]argv. In retrospect using GString was overkill
for what we are constructing.
Signed-off-by: Alex Bennée
---
tests/unit/test-io-channel-command.c | 14 --
1 file
Le 03/11/2022 à 11:23, Alex Bennée a écrit :
This avoids some compilers complaining about a potentially
un-initialised [src|dst]argv. In retrospect using GString was overkill
for what we are constructing.
Signed-off-by: Alex Bennée
---
tests/unit/test-io-channel-command.c | 14 --
On Wed, Oct 26, 2022 at 12:17 PM Stefano Garzarella wrote:
>
> On Wed, Oct 26, 2022 at 05:39:23PM +0800, Yongji Xie wrote:
> >Hi Stefano,
> >
> >On Wed, Oct 26, 2022 at 5:12 PM Stefano Garzarella
> >wrote:
> >>
> >> Hi Xie,
> >> I was testing libblkio [1] with QSD vduse-blk export and had some
>
This script is necessary to choose the best machine type in the
appropriate cases. Also we have to check compat_props of the old MT
after changes to be sure that they haven't broken old the MT. For
example, pc_compat_3_1 of pc-q35-3.1 has Icelake-Client which was
removed in March.
v3 -> v2:
* simp
After modification of "query-machines" command the buffer size should be
more than 452kB to contain output with compat-props.
Signed-off-by: Maksim Davydov
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
python/qemu/qmp/qmp_client.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
This script run QEMU to obtain compat_props of machines and default
values of different types and produce appropriate table. This table
can be used to compare machine types to choose the most suitable
machine. Also this table in json or csv format should be used to check that
new machine doesn't af
qmp_qom_list_properties can print default values if they are available
as qmp_device_list_properties does, because both of them use the
ObjectPropertyInfo structure with default_value field. This can be useful
when working with "not device" types.
Signed-off-by: Maksim Davydov
Reviewed-by: Vladim
To control that creating new machine type doesn't affect the previous
types (their compat_props) and to check complex compat_props inheritance
we need qmp command to print machine type compatible properties.
This patch adds the ability to get list of all the compat_props of the
corresponding suppor
On Wed, Oct 05, 2022 at 08:43:56PM -0700, Richard Henderson wrote:
> Replace tcg_const_* with tcg_constant_* in contexts
> where the free to remove is nearby.
>
> Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: Richard Henderson
> ---
> target/s390x/tcg/translate.c | 408 +-
Since the amount of prealloc-threads to smp-cpus is
defaulted in hostmem, so sync this information.
Signed-off-by: Zhenyu Zhang
---
qapi/qom.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/qom.json b/qapi/qom.json
index 87fcad2423..ac4cd213a7 100644
--- a/qapi/qom.j
On Wed, Oct 05, 2022 at 08:43:57PM -0700, Richard Henderson wrote:
> The a and b fields are not modified by the consumer,
> and while we need not free a constant, tcg will quietly
> ignore such frees, so free_compare need not be changed.
>
> Signed-off-by: Richard Henderson
> ---
> target/s390x/
On Wed, Oct 05, 2022 at 08:43:58PM -0700, Richard Henderson wrote:
> Return a constant or NULL, which means the free may be
> removed from all callers of fpinst_extract_m34.
>
> Signed-off-by: Richard Henderson
> ---
> target/s390x/tcg/translate.c | 26 +-
> 1 file change
On 3/11/22 11:47, Zhenyu Zhang wrote:
Since the amount of prealloc-threads to smp-cpus is
defaulted in hostmem, so sync this information.
Signed-off-by: Zhenyu Zhang
---
qapi/qom.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/qom.json b/qapi/qom.json
index 87fc
On Wed, Oct 05, 2022 at 08:43:59PM -0700, Richard Henderson wrote:
> In most cases, this is a simple local allocate and free
> replaced by tcg_constant_*. In three cases, a variable
> temp was initialized with a constant value -- reorg to
> localize the constant.
>
> Signed-off-by: Richard Hender
On 3/11/22 10:54, Akihiko Odaki wrote:
The register definitions in tests/qtest/e1000e-test.c had names
different from hw/net/e1000_regs.h, which made it hard to understand
what test codes corresponds to the implementation. Use
hw/net/e1000_regs.h from tests/qtest/libqos/e1000e.c to remove
these d
On 3/11/22 10:33, Laurent Vivier wrote:
On 10/28/22 07:04, Jason Wang wrote:
在 2022/10/21 17:09, Laurent Vivier 写道:
Signed-off-by: Laurent Vivier
Acked-by: Michael S. Tsirkin
---
I got this:
63/63 ERROR:../tests/qtest/netdev-socket.c:139:test_stream_inet_ipv6:
assertion failed (resp ==
On 3/11/22 09:34, Akihiko Odaki wrote:
Nemonics E1000_STATUS_LAN_INIT_DONE and E1000_STATUS_ASDV_1000 have
the same value, and E1000_STATUS_ASDV_1000 should be used here because
E1000_STATUS_ASDV_1000 represents the auto-detected speed tested here
while E1000_STATUS_LAN_INIT_DONE is a value used
On Wed, Oct 05, 2022 at 08:44:00PM -0700, Richard Henderson wrote:
> In preparation for TARGET_TB_PCREL, reduce reliance on absolute values.
>
> Signed-off-by: Richard Henderson
> ---
> target/s390x/tcg/translate.c | 11 +++
> 1 file changed, 7 insertions(+), 4 deletions(-)
Reviewed-by:
On Wed, Oct 05, 2022 at 08:44:03PM -0700, Richard Henderson wrote:
> This is slightly more complicated that a straight displacement
> for 31 and 24-bit modes. Dont bother with a cant-happen assert.
>
> Signed-off-by: Richard Henderson
> ---
> target/s390x/tcg/translate.c | 21 --
On 11/3/22 12:07, Philippe Mathieu-Daudé wrote:
On 3/11/22 10:33, Laurent Vivier wrote:
On 10/28/22 07:04, Jason Wang wrote:
在 2022/10/21 17:09, Laurent Vivier 写道:
Signed-off-by: Laurent Vivier
Acked-by: Michael S. Tsirkin
---
I got this:
63/63 ERROR:../tests/qtest/netdev-socket.c:139:t
Laurent Vivier writes:
> Le 03/11/2022 à 11:23, Alex Bennée a écrit :
>> This avoids some compilers complaining about a potentially
>> un-initialised [src|dst]argv. In retrospect using GString was overkill
>> for what we are constructing.
>> Signed-off-by: Alex Bennée
>> ---
>> tests/unit/te
On Wed, Oct 05, 2022 at 08:44:01PM -0700, Richard Henderson wrote:
> In preparation for TARGET_TB_PCREL, reduce reliance on absolute values.
>
> Signed-off-by: Richard Henderson
> ---
> target/s390x/tcg/translate.c | 69
> 1 file changed, 46 insertions(+), 23
On Wed, Oct 05, 2022 at 08:44:02PM -0700, Richard Henderson wrote:
> All callers pass s->pc_tmp.
>
> Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: Richard Henderson
> ---
> target/s390x/tcg/translate.c | 10 ++
> 1 file changed, 6 insertions(+), 4 deletions(-)
Reviewed-by: Ilya
On 3/11/22 09:38, Stefan Weil via wrote:
This fixes some compiler warnings with compiler flag
-Wmissing-variable-declarations (tested with clang):
aarch64_be-linux-user-gdbstub-xml.c:564:19: warning: no previous extern
declaration for non-static variable 'xml_builtin'
[-Wmissing-variable-
On Wed, 2 Nov 2022 at 20:24, Stefan Weil via wrote:
>
> The configure script fails because it tries to compile small C programs
> with a main function which is declared with arguments argc and argv
> although those arguments are unused.
>
> Running `configure -extra-cflags=-Wunused-parameter` trig
ping
On 2022/10/24 16:41, Qi Hu wrote:
In sequence:
---
lock negl -0x14(%rbp)
pushf
pop%rax
---
%rax will obtain the wrong value becasue the "lock neg" calculates the
wrong eflags. The "s->T0" is updated by the wrong value.
You can use this to do some test:
---
#include
int main()
{
_
Am 03.11.22 um 12:48 schrieb Peter Maydell:
On Wed, 2 Nov 2022 at 20:24, Stefan Weil via wrote:
The configure script fails because it tries to compile small C programs
with a main function which is declared with arguments argc and argv
although those arguments are unused.
Running `configure -
On Nov 3 09:51, Jinhao Fan wrote:
> at 7:13 PM, Klaus Jensen wrote:
>
> > Otherwise, it all looks fine. I'm still seeing the weird slowdown when
> > an iothread is enabled. I have yet to figure out why that is... But it
> > scales! :)
>
> How much slowdown do you observe on your machine?
>
I
On Nov 3 10:18, Jinhao Fan wrote:
> at 7:10 PM, Klaus Jensen wrote:
>
> > This doesn't do what you expect it to. By not updaring the eventidx it
> > will fall behind the actual head, causing the host to think that the
> > device is not processing events (but it is!), resulting in doorbell
> > ri
On Wed, Nov 02, 2022 at 03:47:43PM -0400, Stefan Hajnoczi wrote:
> On Wed, Nov 02, 2022 at 12:02:14PM -0400, Michael S. Tsirkin wrote:
> > Changes from v1:
> >
> > Applied and squashed fixes by Igor, Lei He, Hesham Almatary for
> > bugs that tripped up the pipeline.
> > Updated expected files for
On Tue, Oct 25, 2022 at 8:48 PM Chao Peng wrote:
>
> This patch series implements KVM guest private memory for confidential
> computing scenarios like Intel TDX[1]. If a TDX host accesses
> TDX-protected guest memory, machine check can happen which can further
> crash the running host system, this
On 2022/11/2 16:17, Michael S. Tsirkin wrote:
> On Tue, Nov 01, 2022 at 03:10:42PM +0800, Yicong Yang wrote:
>> From: Yicong Yang
>>
>> This series mainly change the policy for building a cluster topology node
>> in PPTT. Previously we'll always build a cluster node in PPTT without
>> asking the u
We need to emulate it to generate a floating point disable exception
when CSR.EUEN.FPE is zero.
Signed-off-by: Rui Wang
---
target/loongarch/cpu.c| 2 ++
target/loongarch/cpu.h| 13 +++
.../loongarch/insn_trans/trans_farith.c.inc | 30 ++
When the address is invalid address, We should set exception_index
according to MMUAccessType, and EXCCODE_ADEF need't update badinstr.
Otherwise, The system enters an infinite loop. e.g:
run test.c on system mode
test.c:
#include
void (*func)(int *);
int main()
{
int i =
The following changes since commit a11f65ec1b8adcb012b89c92819cbda4dc25aaf1:
Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into
staging (2022-11-01 13:49:33 -0400)
are available in the Git repository at:
https://gitlab.com/gaosong/qemu.git tags/pull-loongarc
From: Xiaojuan Yang
Load FDT table into dram memory space, and the addr is 2 MiB.
Since lowmem region starts from 0, FDT base address is located
at 2 MiB to avoid NULL pointer access.
Signed-off-by: Xiaojuan Yang
Acked-by: Song Gao
Message-Id: <20221028014007.2718352-2-yangxiaoj...@loongson.cn
From: Xiaojuan Yang
Converting the MemoryRegionOps read/write handlers to
with_attrs in LoongArch extioi emulation.
Signed-off-by: Xiaojuan Yang
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20221021015307.2570844-2-yangxiaoj...@loongson.cn>
Signed-off-by: So
From: Xiaojuan Yang
Add new items into LoongArch FDT, including rtc and uart info.
Signed-off-by: Xiaojuan Yang
Reviewed-by: Song Gao
Message-Id: <20221028014007.2718352-3-yangxiaoj...@loongson.cn>
Signed-off-by: Song Gao
---
hw/loongarch/virt.c| 31 +++
i
We need subcodes to distinguish the same excode cs->exception_indexs,
such as EXCCODE_ADEF/EXCCODE_ADEM.
Signed-off-by: Song Gao
Reviewed-by: Richard Henderson
Message-ID: <20221101073210.3934280-1-gaos...@loongson.cn>
---
target/loongarch/cpu.c | 7 +++--
target/loongarch/cpu.h | 58 +
From: Xiaojuan Yang
Add TPM device for LoongArch virt machine, including
establish TPM acpi info and add TYPE_TPM_TIS_SYSBUS
to dynamic_sysbus_devices list.
Signed-off-by: Xiaojuan Yang
Reviewed-by: Song Gao
Message-Id: <20221028014007.2718352-4-yangxiaoj...@loongson.cn>
Signed-off-by: Song Ga
From: Xiaojuan Yang
1. When cpu read or write extioi COREISR reg, it should access
the reg belonged to itself, so the cpu index of 's->coreisr'
is current cpu number. Using MemTxAttrs' requester_id to get
the cpu index.
2. it need not to mask 0x1f when calculate the coreisr array index.
Signed-o
On Wed, 2 Nov 2022, Daniel Henrique Barboza wrote:
On 11/1/22 19:29, Philippe Mathieu-Daudé wrote:
This is a respin of Bernhard's v4 with Freescale eSDHC implemented
as an 'UNIMP' region. See v4 cover here:
https://lore.kernel.org/qemu-devel/20221018210146.193159-1-shen...@gmail.com/
Since v5:
On Wed, Oct 05, 2022 at 08:44:04PM -0700, Richard Henderson wrote:
> Trivial but non-mechanical conversion away from pc_tmp.
>
> Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: Richard Henderson
> ---
> target/s390x/tcg/translate.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions
Add a small test to prevent regressions.
Signed-off-by: Ilya Leoshkevich
---
tests/tcg/s390x/Makefile.softmmu-target | 1 +
tests/tcg/s390x/bal.S | 24
2 files changed, 25 insertions(+)
create mode 100644 tests/tcg/s390x/bal.S
diff --git a/tests/tcg/
On Wed, Oct 05, 2022 at 08:44:05PM -0700, Richard Henderson wrote:
> Complicated because we may now require a runtime jump.
>
> Signed-off-by: Richard Henderson
> ---
> target/s390x/tcg/translate.c | 40 +---
> 1 file changed, 28 insertions(+), 12 deletions(-)
Re
On 11/3/2022 8:11 PM, Klaus Jensen wrote:
I'll rerun some experiments and get back to you 😄
Thanks Klaus. I'll also run some experments on my machine, to see if the
reenabling cqe batching patch solves this problem.
On Wed, Oct 05, 2022 at 08:44:06PM -0700, Richard Henderson wrote:
> Remove the remaining uses of pc_tmp, and remove the variable.
>
> Signed-off-by: Richard Henderson
> ---
> target/s390x/tcg/translate.c | 13 +++--
> 1 file changed, 3 insertions(+), 10 deletions(-)
Reviewed-by: Ilya L
On Wed, 2 Nov 2022 at 05:33, Richard Henderson
wrote:
>
> On 11/1/22 17:42, Ake Koomsin wrote:
> > We need to check HCR_E2H and HCR_TGE to select the right MMU index for
> > the correct translation regime.
> >
> > To check for EL2&0 translation regime:
> > - For S1E0*, S1E1* and S12E* ops, check b
On 11/3/2022 8:10 PM, Klaus Jensen wrote:
I agree that the spec is a little unclear on this point. In any case, in
Linux, when the driver has decided that the sq tail must be updated,
it will use this check:
(new_idx - event_idx - 1) < (new_idx - old)
When eventidx is already behind, it's l
On Wed, 2 Nov 2022 at 05:47, Richard Henderson
wrote:
>
> Reversed the sense of non-secure in get_phys_addr_lpae,
> and failed to initialize attrs.secure for ARMMMUIdx_Phys_S.
>
> Fixes: 48da29e4 ("target/arm: Add ptw_idx to S1Translate")
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1
On Thu, 3 Nov 2022 at 13:19, Peter Maydell wrote:
>
> On Wed, 2 Nov 2022 at 05:47, Richard Henderson
> wrote:
> >
> > Reversed the sense of non-secure in get_phys_addr_lpae,
> > and failed to initialize attrs.secure for ARMMMUIdx_Phys_S.
> >
> > Fixes: 48da29e4 ("target/arm: Add ptw_idx to S1Tran
On Thu, 3 Nov 2022 at 08:14, Michael S. Tsirkin wrote:
> On Wed, Nov 02, 2022 at 03:47:43PM -0400, Stefan Hajnoczi wrote:
> > On Wed, Nov 02, 2022 at 12:02:14PM -0400, Michael S. Tsirkin wrote:
> > > Changes from v1:
> > >
> > > Applied and squashed fixes by Igor, Lei He, Hesham Almatary for
> > >
On 3/11/22 13:13, Michael S. Tsirkin wrote:
On Wed, Nov 02, 2022 at 03:47:43PM -0400, Stefan Hajnoczi wrote:
On Wed, Nov 02, 2022 at 12:02:14PM -0400, Michael S. Tsirkin wrote:
Changes from v1:
Applied and squashed fixes by Igor, Lei He, Hesham Almatary for
bugs that tripped up the pipeline.
U
On Wed, Oct 05, 2022 at 08:44:07PM -0700, Richard Henderson wrote:
> Masking after the fact in s390x_tr_init_disas_context
> provides incorrect information to tb_lookup.
>
> Signed-off-by: Richard Henderson
> ---
> target/s390x/cpu.h | 13 +++--
> target/s390x/tcg/translate.c |
vmdk_co_create_opts() is a coroutine_fn, and calls vmdk_co_do_create()
which in turn can call two callbacks: vmdk_co_create_opts_cb and
vmdk_co_create_cb.
Mark all these functions as coroutine_fn, since vmdk_co_create_opts()
is the only caller.
Signed-off-by: Emanuele Giuseppe Esposito
---
bloc
bdrv_can_store_new_dirty_bitmap and bdrv_remove_persistent_dirty_bitmap
check if they are running in a coroutine, directly calling the
coroutine callback if it's the case.
Except that no coroutine calls such functions, therefore that check
can be removed.
Signed-off-by: Emanuele Giuseppe Esposito
block_copy_reset_unallocated and block_copy_is_cluster_allocated are
only called by backup_run, a corotuine_fn itself.
Same applies to block_copy_block_status, called by
block_copy_dirty_clusters.
Therefore mark them as coroutine too.
Signed-off-by: Emanuele Giuseppe Esposito
---
block/block-c
This is a dump of all minor coroutine-related fixes found while looking
around and testing various things in the QEMU block layer.
Patches aim to:
- add missing coroutine_fn annotation to the functions
- simplify to avoid the typical "if in coroutine: fn()
// else create_coroutine(fn)" already p
There are probably more missing, but right now it is necessary that
we extend coroutine_fn to block{allock/status}_to_extents, because
they use bdrv_* functions calling the generated_co_wrapper API, which
checks for the qemu_in_coroutine() case.
Signed-off-by: Emanuele Giuseppe Esposito
---
nbd/
Call two different functions depending on whether bdrv_create
is in coroutine or not, following the same pattern as
generated_co_wrapper functions.
This allows to also call the coroutine function directly,
without using CreateCo or relying in bdrv_create().
Signed-off-by: Emanuele Giuseppe Esposi
Avoid mixing bdrv_* functions with blk_*, so create blk_* counterparts
for:
- bdrv_block_status_above
- bdrv_is_allocated_above
Signed-off-by: Emanuele Giuseppe Esposito
---
block/block-backend.c | 21 +
block/commit.c| 4 ++--
include/sysemu/
Delete the if case and make sure it won't be called again
in coroutines.
Signed-off-by: Emanuele Giuseppe Esposito
---
block.c | 37 -
1 file changed, 16 insertions(+), 21 deletions(-)
diff --git a/block.c b/block.c
index e5e70acf15..1ee76a8694 100644
--- a/b
It is always called in coroutine_fn callbacks, therefore
it can directly call bdrv_co_create().
Signed-off-by: Emanuele Giuseppe Esposito
---
block.c| 6 --
include/block/block-global-state.h | 3 ++-
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/
It seems that bdrv_open_driver() forgot to create a coroutine
where to call bs->drv->bdrv_co_drain_begin(), a callback
marked as coroutine_fn.
Signed-off-by: Emanuele Giuseppe Esposito
---
block.c | 32 +++-
1 file changed, 27 insertions(+), 5 deletions(-)
diff --git
On Wed, Oct 05, 2022 at 08:44:08PM -0700, Richard Henderson wrote:
> Rename to update_psw_addr_disp at the same time.
>
> Signed-off-by: Richard Henderson
> ---
> target/s390x/tcg/translate.c | 22 +++---
> 1 file changed, 11 insertions(+), 11 deletions(-)
Reviewed-by: Ilya Leos
On Wed, Oct 05, 2022 at 08:44:09PM -0700, Richard Henderson wrote:
> The rest of the per_* functions have this ifdef;
> this one seemed to be missing.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Ilya Leoshkevich
On Wed, Oct 05, 2022 at 08:44:10PM -0700, Richard Henderson wrote:
> Hoist the test of FLAG_MASK_PER to a helper.
>
> Signed-off-by: Richard Henderson
> ---
> target/s390x/tcg/translate.c | 23 ---
> 1 file changed, 16 insertions(+), 7 deletions(-)
Reviewed-by: Ilya Leoshkev
We need to emulate it to generate a floating point disable exception
when CSR.EUEN.FPE is zero.
Signed-off-by: Rui Wang
---
target/loongarch/cpu.c| 2 ++
.../loongarch/insn_trans/trans_farith.c.inc | 36 +++
target/loongarch/insn_trans/trans_fcmp.c.inc
On Thu, Nov 03, 2022 at 10:52:43AM +0100, Kevin Wolf wrote:
> Am 02.11.2022 um 03:49 hat Eric Biggers geschrieben:
> > On Tue, Nov 01, 2022 at 07:27:16PM -0700, Eric Biggers wrote:
> > > On Tue, Nov 01, 2022 at 03:00:30PM -0400, Stefan Hajnoczi wrote:
> > > > Linux dm-crypt returns errno EIO from u
Stefan Hajnoczi writes:
> On Wed, 26 Oct 2022 at 14:44, Markus Armbruster wrote:
>>
>> The following changes since commit e750a7ace492f0b450653d4ad368a77d6f660fb8:
>>
>> Merge tag 'pull-9p-20221024' of https://github.com/cschoenebeck/qemu into
>> staging (2022-10-24 14:27:12 -0400)
>>
>> are
This attempts to deal with the problem of login prompts not being
guaranteed to be terminated with a newline. The solution to this is to
peek at the incoming data looking to see if we see an up-coming match
before we fall back to the old readline() logic. The reason to mostly
rely on readline is be
On Wed, Oct 05, 2022 at 08:44:11PM -0700, Richard Henderson wrote:
> For PER, we require a conditional call to helper_per_branch
> for the conditional branch. Fold the remaining optimization
> into a call to helper_goto_direct, which will take care of
> the remaining gbea adjustment.
>
> Signed-o
On Wed, Oct 05, 2022 at 08:44:13PM -0700, Richard Henderson wrote:
> Split into per_branch_dest and per_branch_disp, which can be
> used for direct and indirect. In preperation for TARGET_TB_PCREL,
> call per_branch_* before indirect branches.
>
> Signed-off-by: Richard Henderson
> ---
> target
You're right, that's a much better approach. New patch coming up
shortly.
On Thu, Nov 03, 2022 at 09:29:56AM -0400, Stefan Hajnoczi wrote:
> On Thu, 3 Nov 2022 at 08:14, Michael S. Tsirkin wrote:
> > On Wed, Nov 02, 2022 at 03:47:43PM -0400, Stefan Hajnoczi wrote:
> > > On Wed, Nov 02, 2022 at 12:02:14PM -0400, Michael S. Tsirkin wrote:
> > > > Changes from v1:
> > > >
References: https://gitlab.com/qemu-project/qemu/-/issues/1007
Signed-off-by: Drew DeVault
---
linux-user/syscall.c | 204 +++
1 file changed, 111 insertions(+), 93 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index f55cdebee5..57f
On 11/3/22 09:51, BALATON Zoltan wrote:
On Wed, 2 Nov 2022, Daniel Henrique Barboza wrote:
On 11/1/22 19:29, Philippe Mathieu-Daudé wrote:
This is a respin of Bernhard's v4 with Freescale eSDHC implemented
as an 'UNIMP' region. See v4 cover here:
https://lore.kernel.org/qemu-devel/2022101821
> To pull this image:
> $ docker pull registry.gitlab.com/qemu-project/qemu/fedora:latest
Actually the URL is:
$ docker pull registry.gitlab.com/qemu-project/qemu/qemu/fedora:latest
> (or to be sure to pull the very same:)
> $ docker pull
> registry.gitlab.com/qemu-project/qemu/fedora:d6d20c1
gitlab-runner can run locally with minimal setup:
https://bagong.gitlab.io/posts/run-gitlab-ci-locally/
I haven't tried it yet, but that seems like the most reliable (and
easiest) way to reproduce the CI environment.
Stefan
On Thu, Nov 03, 2022 at 11:49:21AM -0400, Stefan Hajnoczi wrote:
> gitlab-runner can run locally with minimal setup:
> https://bagong.gitlab.io/posts/run-gitlab-ci-locally/
>
> I haven't tried it yet, but that seems like the most reliable (and
> easiest) way to reproduce the CI environment.
>
> S
1 - 100 of 236 matches
Mail list logo
