[PATCH v4 5/6] tests: acpi: aarch64: Add topology test for aarch64

From: Yicong Yang Add test for aarch64's ACPI topology building for all the supported levels. Acked-by: Michael S. Tsirkin Signed-off-by: Yicong Yang --- tests/qtest/bios-tables-test.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/qtest/bios-tables-test.c b/te

[PATCH v4 6/6] tests: acpi: aarch64: Add *.topology tables

From: Yicong Yang Add *.topology tables for the aarch64's topology test and empty bios-tables-test-allowed-diff.h The disassembled differences between actual and expected PPTT (the table which we actually care about): +/* + * Intel ACPI Component Architecture + * AML/ASL+ Disassembler versio

[PATCH v4 1/6] tests: virt: Allow changes to PPTT test table

From: Yicong Yang Allow changes to test/data/acpi/virt/PPTT, prepare to change the building policy of the cluster topology. Signed-off-by: Yicong Yang --- tests/qtest/bios-tables-test-allowed-diff.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h

[PATCH v4 3/6] tests: virt: Update expected ACPI tables for virt test

From: Yicong Yang Update the ACPI tables according to the acpi aml_build change, also empty bios-tables-test-allowed-diff.h. The disassembled differences between actual and expected PPTT: /* * Intel ACPI Component Architecture * AML/ASL+ Disassembler version 20180105 (64-bit version)

[PATCH v4 4/6] tests: acpi: Add and whitelist *.topology blobs

From: Yicong Yang Add and whitelist *.topology blobs, prepares for the aarch64's ACPI topology building test. Signed-off-by: Yicong Yang --- tests/data/acpi/virt/APIC.topology | 0 tests/data/acpi/virt/DSDT.topology | 0 tests/data/acpi/virt/PPTT.topology | 0 tests/

[PATCH v4 0/6] Only generate cluster node in PPTT when specified

From: Yicong Yang This series mainly change the policy for building a cluster topology node in PPTT. Previously we'll always build a cluster node in PPTT without asking the user, after this set the cluster node will be built only the the user specify through "-smp clusters=X". One problem is rel

[PATCH v4 2/6] hw/acpi/aml-build: Only generate cluster node in PPTT when specified

From: Yicong Yang Currently we'll always generate a cluster node no matter user has specified '-smp clusters=X' or not. Cluster is an optional level and will participant the building of Linux scheduling domains and only appears on a few platforms. It's unnecessary to always build it when it canno

[PATCH 1/2] target/loongarch: Add exception subcode

We need subcodes to distinguish the same excode cs->exception_indexs, such as EXCCODE_ADEF/EXCCODE_ADEM. Signed-off-by: Song Gao --- target/loongarch/cpu.c | 7 +++-- target/loongarch/cpu.h | 58 ++ 2 files changed, 36 insertions(+), 29 deletions(-) diff

[PATCH 2/2] target/loongarch: Fix raise_mmu_exception() set wrong exception_index

When the address is invalid address, We should set exception_index according to MMUAccessType, and EXCCODE_ADEF need't update badinstr. Otherwise, The system enters an infinite loop. e.g: run test.c on system mode test.c: #include void (*func)(int *); int main() { int i =

Re: [PATCH 3/3] vdpa: Expose VIRTIO_NET_F_STATUS unconditionally

On Fri, Oct 28, 2022 at 5:30 PM Eugenio Perez Martin wrote: > > On Fri, Oct 28, 2022 at 3:59 AM Jason Wang wrote: > > > > On Thu, Oct 27, 2022 at 6:18 PM Eugenio Perez Martin > > wrote: > > > > > > On Thu, Oct 27, 2022 at 8:54 AM Jason Wang wrote: > > > > > > > > On Thu, Oct 27, 2022 at 2:47 PM

Re: [PATCH v3 16/24] disas/nanomips: Remove IMMEDIATE functions

Am 12.09.22 um 14:26 schrieb Milica Lazarevic: Both versions of IMMEDIATE functions have been removed. Before this patch, we'd been calling img_format twice, the first time through the IMMEDIATE to get an appropriate string and the second time to print that string. There's no more need for that.

[PULL v2 for 7.2 00/31] testing and plugin updates

warn: No match for commit 339bf0c071eff5e6ff1d9ddb3ad5cd02e4cd9ca3 found at https://github.com/stsquad/qemu.git warn: Are you sure you pushed 'pull-target-arm-20221027-326-g339bf0c071' there? The following changes since commit 5107fd3effb1cfec3b96d9e819f1605048640e31: net/vhost-vdpa.c: Fix clan

Re: [PATCH v3 16/24] disas/nanomips: Remove IMMEDIATE functions

On 1/11/22 09:28, Stefan Weil via wrote: Am 12.09.22 um 14:26 schrieb Milica Lazarevic: Both versions of IMMEDIATE functions have been removed. Before this patch, we'd been calling img_format twice, the first time through the IMMEDIATE to get an appropriate string and the second time to print t

Re: [PULL 08/30] target/arm: Add ptw_idx to S1Translate

On 1/11/22 00:14, Philippe Mathieu-Daudé wrote: On 25/10/22 18:39, Peter Maydell wrote: From: Richard Henderson Hoist the computation of the mmu_idx for the ptw up to get_phys_addr_with_struct and get_phys_addr_twostage. This removes the duplicate check for stage2 disabled from the middle of t

HMAT patches failure (was Re: [PULL 00/86] pci,pc,virtio: features, tests, fixes, cleanups)

On Mon, Oct 31, 2022 at 04:06:03PM -0400, Stefan Hajnoczi wrote: > Here is another CI failure: > > qemu-system-i386: current -smp configuration requires kernel irqchip > and X2APIC API support. > Broken pipe > ../tests/qtest/libqtest.c:179: kill_qemu() tried to terminate QEMU > process but encount

Re: [PATCH v3 0/8] AArch64/HMAT support and tests

On Thu, Oct 27, 2022 at 11:00:29AM +0100, Hesham Almatary wrote: > This patchset adds support for AArch64/HMAT including a test. > It relies on other two patch sets from: > > Brice Goglin: to support -numa without initiators on q35/x86. > https://lore.kernel.org/all/ed23accb-2c8b-90f4-a7a3-f81cc

Re: [PATCH] hw/nvme: reenable cqe batching

On Oct 20 13:35, Klaus Jensen wrote: > From: Klaus Jensen > > Commit 2e53b0b45024 ("hw/nvme: Use ioeventfd to handle doorbell > updates") had the unintended effect of disabling batching of CQEs. > > This patch changes the sq/cq timers to bottom halfs and instead of > calling nvme_post_cqes() imm

Re: [PATCH v2 1/4] virtio-crypto: Support asynchronous mode

On Sat, Oct 08, 2022 at 04:50:27PM +0800, Lei He wrote: > virtio-crypto: Modify the current interface of virtio-crypto > device to support asynchronous mode. > > Signed-off-by: lei he > --- > backends/cryptodev-builtin.c| 69 ++--- > backends/cryptodev-vhost-user.c | 51 +-- > back

Re: [PATCH v5 6/6] hw/ppc/e500: Add Freescale eSDHC to e500plat

On Mon, Oct 31, 2022 at 4:19 PM Philippe Mathieu-Daudé wrote: > On 31/10/22 16:12, Philippe Mathieu-Daudé wrote: > > On 31/10/22 12:54, Philippe Mathieu-Daudé wrote: > >> From: Bernhard Beschow > >> > >> Adds missing functionality to e500plat machine which increases the > >> chance of given "rea

Re: [PATCH v5 0/6] ppc/e500: Add support for two types of flash, cleanup

On Mon, Oct 31, 2022 at 12:54 PM Philippe Mathieu-Daudé wrote: > This is a respin of Bernhard's v4 with Freescale eSDHC implemented > as an 'UNIMP' region. See v4 cover here: > > https://lore.kernel.org/qemu-devel/20221018210146.193159-1-shen...@gmail.com/ > > Only tested with the ppce500 machine

Re: [PATCH] qapi: virtio: Fix the introduced version

Le 01/11/2022 à 02:46, Han Han a écrit : The items of qapi/virtio.json are introduced at a5ebce38576. They will be in the version 7.2 not 7.1. Signed-off-by: Han Han --- qapi/virtio.json | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) Reviewed-by:

Re: [PATCH v4 6/7] hw/sd/sdhci: Implement Freescale eSDHC device model

Am 31. Oktober 2022 12:11:37 UTC schrieb "Philippe Mathieu-Daudé" : >On 30/10/22 12:46, Bernhard Beschow wrote: >> >> >> On Sun, Oct 30, 2022 at 1:10 AM Philippe Mathieu-Daudé > > wrote: >> >> On 29/10/22 20:28, Bernhard Beschow wrote: >> > Am 29. Oktober 2022

Re: [PATCH 1/9] target/s390x: Use a single return for helper_divs32/u32

On Fri, Oct 21, 2022 at 05:29:58PM +1000, Richard Henderson wrote: > Pack the quotient and remainder into a single uint64_t. > > Signed-off-by: Richard Henderson > --- > target/s390x/helper.h | 2 +- > target/s390x/tcg/int_helper.c | 26 +- > target/s390x/tcg/tra

[PATCH] tests/tcg/s390x: Add div.c

Add a basic test to prevent regressions. Signed-off-by: Ilya Leoshkevich --- tests/tcg/s390x/Makefile.target | 1 + tests/tcg/s390x/div.c | 40 + 2 files changed, 41 insertions(+) create mode 100644 tests/tcg/s390x/div.c diff --git a/tests/tcg/s390x/M

Re: [PATCH v3 16/24] disas/nanomips: Remove IMMEDIATE functions

Am 01.11.22 um 10:27 schrieb Philippe Mathieu-Daudé: On 1/11/22 09:28, Stefan Weil via wrote: Am 12.09.22 um 14:26 schrieb Milica Lazarevic: Both versions of IMMEDIATE functions have been removed. Before this patch, we'd been calling img_format twice, the first time through the IMMEDIATE to g

Re: [PATCH v1 09/12] accel/xen/xen-all: export xenstore_record_dm_state

"Garhwal, Vikram" writes: > Thanks, Alex, for reviewing this one. I built for all the archs and it was > fine. Can you please share more about what > environment builds are breaking? So, I can test the changes for v2. My cross build environment failed: ../../configure' '--disable-docs' '--

Re: [PATCH v3 16/24] disas/nanomips: Remove IMMEDIATE functions

On 1/11/22 12:28, Stefan Weil wrote: Am 01.11.22 um 10:27 schrieb Philippe Mathieu-Daudé: On 1/11/22 09:28, Stefan Weil via wrote: Am 12.09.22 um 14:26 schrieb Milica Lazarevic: Both versions of IMMEDIATE functions have been removed. Before this patch, we'd been calling img_format twice, the

Re: [PATCH v9 1/8] mm: Introduce memfd_restricted system call to create restricted user memory

On Mon, Oct 31, 2022 at 12:47:38PM -0500, Michael Roth wrote: > On Tue, Oct 25, 2022 at 11:13:37PM +0800, Chao Peng wrote: > > From: "Kirill A. Shutemov" > > > > Introduce 'memfd_restricted' system call with the ability to create > > memory areas that are restricted from userspace access through

Re: [PATCH v9 7/8] KVM: Handle page fault for private memory

On Mon, Oct 31, 2022 at 05:02:50PM -0700, Isaku Yamahata wrote: > On Fri, Oct 28, 2022 at 02:55:45PM +0800, > Chao Peng wrote: > > > On Wed, Oct 26, 2022 at 02:54:25PM -0700, Isaku Yamahata wrote: > > > On Tue, Oct 25, 2022 at 11:13:43PM +0800, > > > Chao Peng wrote: > > > > > > > A memslot wit

[PATCH 3/5] disas/nanomips: Use G_GNUC_PRINTF to avoid invalid string formats

Suggested-by: Stefan Weil Signed-off-by: Philippe Mathieu-Daudé --- disas/nanomips.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/disas/nanomips.c b/disas/nanomips.c index e4b21e7c45..3f45447292 100644 --- a/disas/nanomips.c +++ b/disas/nanomips.c @@ -95,7 +95,7 @@ typedef

[PATCH 0/5] disas/nanomips: Format string fixes

Fix invalid string formats reported by Stefan: https://lore.kernel.org/qemu-devel/78553699-00c1-ad69-1d58-02f75a1f4...@weilnetz.de/ Philippe Mathieu-Daudé (5): disas/nanomips: Fix invalid PRId64 format calling img_format() disas/nanomips: Fix invalid PRIx64 format calling img_format() disas/

[PATCH 2/5] disas/nanomips: Fix invalid PRIx64 format calling img_format()

Fix: disas/nanomips.c:12231:62: warning: format specifies type 'char *' but the argument has type 'uint64' (aka 'unsigned long long') [-Wformat] return img_format("RESTOREF 0x%" PRIx64 ", %s", u_value, count_value); ~~^~~

[PATCH 1/5] disas/nanomips: Fix invalid PRId64 format calling img_format()

Fix warnings such: disas/nanomips.c:3251:64: warning: format specifies type 'char *' but the argument has type 'int64' (aka 'long long') [-Wformat] return img_format("CACHE 0x%" PRIx64 ", %s(%s)", op_value, s_value, rs); ~~ ^~~

[PATCH 5/5] MAINTAINERS: Inherit from nanoMIPS

6 months ago Stefan Pejic stepped in as nanoMIPS maintainer (see commit a 8e0e23445a "target/mips: Undeprecate nanoMIPS ISA support in QEMU"), however today his email is bouncing: ** Message blocked ** Your message to stefan.pe...@syrmia.com has been blocked. See technical details below for

[PATCH 4/5] disas/nanomips: Remove headers already included by "qemu/osdep.h"

Signed-off-by: Philippe Mathieu-Daudé --- disas/nanomips.c | 4 1 file changed, 4 deletions(-) diff --git a/disas/nanomips.c b/disas/nanomips.c index 3f45447292..821d4f8832 100644 --- a/disas/nanomips.c +++ b/disas/nanomips.c @@ -30,10 +30,6 @@ #include "qemu/osdep.h" #include "disas/dis-

Re: [PATCH v4 1/3] util/main-loop: Fix maximum number of wait objects for win32

On Tue, Nov 01, 2022 at 09:14:55AM +0800, Bin Meng wrote: > Hi Daniel, > > On Wed, Oct 26, 2022 at 12:41 AM Bin Meng wrote: > > > > On Wed, Oct 19, 2022 at 6:20 PM Bin Meng wrote: > > > > > > From: Bin Meng > > > > > > The maximum number of wait objects for win32 should be > > > MAXIMUM_WAIT_OB

Re: [PATCH 1/5] disas/nanomips: Fix invalid PRId64 format calling img_format()

Am 01.11.22 um 12:44 schrieb Philippe Mathieu-Daudé: Fix warnings such: disas/nanomips.c:3251:64: warning: format specifies type 'char *' but the argument has type 'int64' (aka 'long long') [-Wformat] return img_format("CACHE 0x%" PRIx64 ", %s(%s)", op_value, s_value, rs);

Re: [PATCH 2/5] disas/nanomips: Fix invalid PRIx64 format calling img_format()

Am 01.11.22 um 12:44 schrieb Philippe Mathieu-Daudé: Fix: disas/nanomips.c:12231:62: warning: format specifies type 'char *' but the argument has type 'uint64' (aka 'unsigned long long') [-Wformat] return img_format("RESTOREF 0x%" PRIx64 ", %s", u_value, count_value);

Re: [PATCH 3/5] disas/nanomips: Use G_GNUC_PRINTF to avoid invalid string formats

Am 01.11.22 um 12:44 schrieb Philippe Mathieu-Daudé: Suggested-by: Stefan Weil Signed-off-by: Philippe Mathieu-Daudé --- disas/nanomips.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/disas/nanomips.c b/disas/nanomips.c index e4b21e7c45..3f45447292 100644 --- a/disas/n

Re: [PATCH 4/5] disas/nanomips: Remove headers already included by "qemu/osdep.h"

Am 01.11.22 um 12:44 schrieb Philippe Mathieu-Daudé: Signed-off-by: Philippe Mathieu-Daudé --- disas/nanomips.c | 4 1 file changed, 4 deletions(-) diff --git a/disas/nanomips.c b/disas/nanomips.c index 3f45447292..821d4f8832 100644 --- a/disas/nanomips.c +++ b/disas/nanomips.c @@ -30,

Re: [PATCH 0/4] hw: make TCO watchdog actually work by default for Q35

On Tue, Nov 01, 2022 at 01:57:24PM +0100, Igor Mammedov wrote: > On Mon, 31 Oct 2022 11:48:58 -0400 > "Michael S. Tsirkin" wrote: > > > On Mon, Oct 31, 2022 at 01:50:24PM +, Daniel P. Berrangé wrote: > > > On Mon, Oct 31, 2022 at 01:19:30PM +, Daniel P. Berrangé wrote: > > > > The TCO w

[PATCH v8 11/17] pci/shpc: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of shpc_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci-bridge/pci_bridge_dev.c | 2 +- hw/pci-bridge/pcie_pci_bridg

[PATCH v8 14/17] hw/pci-bridge/pcie_pci_bridge: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate heare because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v8 07/17] hw/nvme: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v8 02/17] pci: Allow to omit errp for pci_add_capability

pci_add_capability appears most PCI devices. Its error handling required lots of code, and led to inconsistent behaviors such as: - passing error_abort - passing error_fatal - asserting the returned value - propagating the error to the caller - skipping the rest of the function - just ignoring The

[PATCH] fixup! bios-tables-test: add test for number of cores > 255

testcase requires KVM for execution and would fail with " qemu-system-i386: current -smp configuration requires kernel irqchip and X2APIC API support " move it to kvm guarded section. This fixes CI failure on hosts that doesn't have KVM enabled for Q35 machine type. Signed-off-by: Igor Mamme

RE: [PATCH 07/16] hw/9pfs: Implement Windows specific utilities functions for 9pfs

> -Original Message- > From: Christian Schoenebeck > Sent: Tuesday, November 1, 2022 22:28 > To: qemu-devel@nongnu.org > Cc: Shi, Guohuai ; Greg Kurz ; > Meng, Bin > Subject: Re: [PATCH 07/16] hw/9pfs: Implement Windows specific utilities > functions for 9pfs > > [Please note: This e-

Re: [PATCH v8 01/17] hw/vfio/pci: Ensure MSI and MSI-X do not overlap

On 1/11/22 14:57, Akihiko Odaki wrote: pci_add_capability() checks whether capabilities overlap, and notifies its caller so that it can properly handle the case. However, in the most cases, the capabilities actually never overlap, and the interface incurred extra error handling code, which is oft

Re: [PATCH 04/16] hw/9pfs: Introduce an opaque type 9P_FILE_ID

On Monday, October 24, 2022 6:57:47 AM CET Bin Meng wrote: > Introduce an opaque type to represent a file in the 9pfs. This is > file descriptor on POSIX systems. In the upcoming patches, we can > extend it to support Windows. > > With this new opaque type, it significantly reduces the number of >

Re: [PULL 21/86] bios-tables-test: add test for number of cores > 255

On Mon, 31 Oct 2022 08:51:44 -0400 "Michael S. Tsirkin" wrote: > From: Julia Suvorova > > The new test is run with a large number of cpus and checks if the > core_count field in smbios_cpu_test (structure type 4) is correct. > > Choose q35 as it allows to run with -smp > 255. Getting a failur

Re: [PATCH v4 3/3] util/aio-win32: Correct the event array size in aio_poll()

On 19/10/22 12:20, Bin Meng wrote: From: Bin Meng WaitForMultipleObjects() can only wait for MAXIMUM_WAIT_OBJECTS object handles. Correct the event array size in aio_poll() and add a assert() to ensure it does not cause out of bound access. Signed-off-by: Bin Meng Reviewed-by: Stefan Weil Re

Re: [PATCH v9 1/8] mm: Introduce memfd_restricted system call to create restricted user memory

On Tue, Nov 01, 2022 at 07:37:29PM +0800, Chao Peng wrote: > On Mon, Oct 31, 2022 at 12:47:38PM -0500, Michael Roth wrote: > > On Tue, Oct 25, 2022 at 11:13:37PM +0800, Chao Peng wrote: > > > From: "Kirill A. Shutemov" > > > > > > +struct restrictedmem_data { > > > + struct mutex lock; > > > + st

Re: [PATCH] fixup! bios-tables-test: add test for number of cores > 255

I will wait for Michael's v2 pull request in the coming days. Stefan

[PATCH] migration: check magic value for deciding the mapping of channels

Current logic assumes that channel connections on the destination side are always established in the same order as the source and the first one will always be the default channel followed by the multifid or post-copy preemption channel. This may not be always true, as even if a channel has a connec

[PATCH v9 13/17] pci/slotid: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of slotid_cap_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci/slotid_cap.c | 8 ++-- 1 file changed, 2 insertions(

RE: [PATCH 09/16] hw/9pfs: Disable unsupported flags and features for Windows

> -Original Message- > From: Christian Schoenebeck > Sent: Tuesday, November 1, 2022 23:04 > To: qemu-devel@nongnu.org > Cc: Shi, Guohuai ; Greg Kurz ; > Meng, Bin > Subject: Re: [PATCH 09/16] hw/9pfs: Disable unsupported flags and features > for Windows > > [Please note: This e-mail

[PATCH v9 12/17] msix: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of msix_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci/msix.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deleti

[PATCH v8 10/17] pcie: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of a PCIe function which calls pci_add_capability() in turn is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki Acked-by: Jonathan Cameron (for CXL parts) --- docs/pcie_sriov.txt

Re: [PATCH 08/16] hw/9pfs: Handle current directory offset for Windows

On Monday, October 24, 2022 6:57:51 AM CET Bin Meng wrote: > From: Guohuai Shi > > On Windows 'struct dirent' does not have current directory offset. > We have to save current directory offset and update offset when > reading directory. > > Signed-off-by: Guohuai Shi > Signed-off-by: Bin Meng

Re: [PULL 00/86] pci,pc,virtio: features, tests, fixes, cleanups

On Mon, 31 Oct 2022 08:50:41 -0400 "Michael S. Tsirkin" wrote: > > Holiday here tomorrow, so most likely this is it for features for this > release. > > The following changes since commit 75d30fde55485b965a1168a21d016dd07b50ed32: > > Merge tag 'block-pull-request' of https://gitlab.com/stef

Re: [PATCH v4 1/3] util/main-loop: Fix maximum number of wait objects for win32

On 19/10/22 12:20, Bin Meng wrote: From: Bin Meng The maximum number of wait objects for win32 should be MAXIMUM_WAIT_OBJECTS, not MAXIMUM_WAIT_OBJECTS + 1. Signed-off-by: Bin Meng --- Changes in v4: - make the out of bounds access protection explicit Changes in v3: - move the check of addi

[PATCH v4] qapi/qmp: Add timestamps to qmp command responses

Add "start" & "end" time values to QMP command responses. These time values are added to let the qemu management layer get the exact command execution time without any other time variance which might be brought by other parts of management layer or qemu internals. This helps to look for problems p

[PATCH v9 06/17] eepro100: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v9 16/17] virtio-pci: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PULL v3 for 7.2 00/31] testing and plugin updates

The following changes since commit 5107fd3effb1cfec3b96d9e819f1605048640e31: net/vhost-vdpa.c: Fix clang compilation failure (2022-10-31 13:01:31 -0400) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-testing-for-7.2-011122-3 for you to fetch changes up

Re: [PULL 21/86] bios-tables-test: add test for number of cores > 255

On Tue, Nov 1, 2022 at 19:22 Jonathan Cameron wrote: > On Mon, 31 Oct 2022 08:51:44 -0400 > "Michael S. Tsirkin" wrote: > > > From: Julia Suvorova > > > > The new test is run with a large number of cpus and checks if the > > core_count field in smbios_cpu_test (structure type 4) is correct. > >

[PATCH v8 06/17] eepro100: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

Re: [PATCH 11/16] hw/9pfs: Add Linux error number definition

On Monday, October 24, 2022 6:57:54 AM CET Bin Meng wrote: > From: Guohuai Shi > > When using 9p2000.L protocol, the errno should use the Linux errno. > Currently magic numbers with comments are used. Replace these with > macros for future expansion. > > Signed-off-by: Guohuai Shi > Signed-off-

[PATCH v8 09/17] hw/pci/pci_bridge: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of pci_bridge_ssvid_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci-bridge/i82801b11.c | 14 ++ h

Re: [PATCH] migration: check magic value for deciding the mapping of channels

Sorry for late patch on this. I mentioned i will send it last week itself, but later reliased it was festival week in India, so was mostly holidays. Thanks Manish Mishra On 01/11/22 8:00 pm, manish.mishra wrote: Current logic assumes that channel connections on the destination side are always

[PATCH v8 13/17] pci/slotid: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of slotid_cap_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci/slotid_cap.c | 8 ++-- 1 file changed, 2 insertions(

Re: [PATCH v8 01/17] hw/vfio/pci: Ensure MSI and MSI-X do not overlap

On 1/11/22 14:57, Akihiko Odaki wrote: pci_add_capability() checks whether capabilities overlap, and notifies its caller so that it can properly handle the case. However, in the most cases, the capabilities actually never overlap, and the interface incurred extra error handling code, which is oft

Re: [PATCH v5 0/6] ppc/e500: Add support for two types of flash, cleanup

Am 1. November 2022 10:41:51 UTC schrieb Bernhard Beschow : >On Mon, Oct 31, 2022 at 12:54 PM Philippe Mathieu-Daudé >wrote: > >> This is a respin of Bernhard's v4 with Freescale eSDHC implemented >> as an 'UNIMP' region. See v4 cover here: >> >> https://lore.kernel.org/qemu-devel/20221018210146.1

[PATCH v8 05/17] e1000e: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

Re: [PATCH v8 17/17] pci: Remove legacy errp from pci_add_capability

On 1/11/22 14:57, Akihiko Odaki wrote: Signed-off-by: Akihiko Odaki --- hw/pci/pci.c | 20 +--- include/hw/pci/pci.h | 12 ++-- 2 files changed, 7 insertions(+), 25 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index cce57f572c..41de7643af 100644 ---

[PATCH v9 04/17] ahci: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

Re: [PATCH 0/4] hw: make TCO watchdog actually work by default for Q35

On Mon, 31 Oct 2022 11:48:58 -0400 "Michael S. Tsirkin" wrote: > On Mon, Oct 31, 2022 at 01:50:24PM +, Daniel P. Berrangé wrote: > > On Mon, Oct 31, 2022 at 01:19:30PM +, Daniel P. Berrangé wrote: > > > The TCO watchdog is unconditionally integrated into the Q35 machine > > > type by de

Re: [PATCH v4 1/3] util/main-loop: Fix maximum number of wait objects for win32

On Tue, Nov 1, 2022 at 8:03 PM Daniel P. Berrangé wrote: > > On Tue, Nov 01, 2022 at 09:14:55AM +0800, Bin Meng wrote: > > Hi Daniel, > > > > On Wed, Oct 26, 2022 at 12:41 AM Bin Meng wrote: > > > > > > On Wed, Oct 19, 2022 at 6:20 PM Bin Meng wrote: > > > > > > > > From: Bin Meng > > > > > > >

[PATCH v9 05/17] e1000e: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

Re: [PATCH v5 0/6] ppc/e500: Add support for two types of flash, cleanup

On 1/11/22 17:01, Bernhard Beschow wrote: Am 1. November 2022 10:41:51 UTC schrieb Bernhard Beschow : On Mon, Oct 31, 2022 at 12:54 PM Philippe Mathieu-Daudé wrote: This is a respin of Bernhard's v4 with Freescale eSDHC implemented as an 'UNIMP' region. See v4 cover here: https://lore.kernel

[PATCH v9 03/17] hw/i386/amd_iommu: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

Re: [PATCH 09/16] hw/9pfs: Disable unsupported flags and features for Windows

On Monday, October 24, 2022 6:57:52 AM CET Bin Meng wrote: > From: Guohuai Shi > > Some flags and features are not supported on Windows, like mknod, > readlink, file mode, etc. Update the codes for Windows. > > Signed-off-by: Guohuai Shi > Signed-off-by: Bin Meng > --- > > hw/9pfs/9p-util.h

[PATCH v9 01/17] hw/vfio/pci: Ensure MSI and MSI-X do not overlap

pci_add_capability() checks whether capabilities overlap, and notifies its caller so that it can properly handle the case. However, in the most cases, the capabilities actually never overlap, and the interface incurred extra error handling code, which is often incorrect or suboptimal. For such case

[PATCH v8 03/17] hw/i386/amd_iommu: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v9 14/17] hw/pci-bridge/pcie_pci_bridge: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate heare because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

Re: [PATCH 07/16] hw/9pfs: Implement Windows specific utilities functions for 9pfs

On Monday, October 24, 2022 6:57:50 AM CET Bin Meng wrote: > From: Guohuai Shi > > Windows POSIX API and MinGW library do not provide the NO_FOLLOW > flag, and do not allow opening a directory by POSIX open(). This > causes all xxx_at() functions cannot work directly. However, we > can provide Wi

Re: [PULL 08/30] target/arm: Add ptw_idx to S1Translate

On 1/11/22 11:10, Philippe Mathieu-Daudé wrote: On 1/11/22 00:14, Philippe Mathieu-Daudé wrote: On 25/10/22 18:39, Peter Maydell wrote: From: Richard Henderson Hoist the computation of the mmu_idx for the ptw up to get_phys_addr_with_struct and get_phys_addr_twostage. This removes the duplica

[PATCH v8 08/17] msi: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of msi_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci/msi.c | 9 + 1 file changed, 1 insertion(+), 8 deletion

RE: [PATCH 07/16] hw/9pfs: Implement Windows specific utilities functions for 9pfs

> -Original Message- > From: Shi, Guohuai > Sent: Tuesday, November 1, 2022 23:13 > To: Christian Schoenebeck ; qemu-devel@nongnu.org > Cc: Greg Kurz ; Meng, Bin > Subject: RE: [PATCH 07/16] hw/9pfs: Implement Windows specific utilities > functions for 9pfs > > > > > -Original Me

Re: HMAT patches failure (was Re: [PULL 00/86] pci,pc,virtio: features, tests, fixes, cleanups)

On Tue, 1 Nov 2022 06:32:05 -0400 "Michael S. Tsirkin" wrote: > On Mon, Oct 31, 2022 at 04:06:03PM -0400, Stefan Hajnoczi wrote: > > Here is another CI failure: > > > > qemu-system-i386: current -smp configuration requires kernel irqchip > > and X2APIC API support. > > Broken pipe > > ../tests/q

[PATCH v8 16/17] virtio-pci: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v8 00/17] pci: Abort if pci_add_capability fails

pci_add_capability appears most PCI devices. Its error handling required lots of code, and led to inconsistent behaviors such as: - passing error_abort - passing error_fatal - asserting the returned value - propagating the error to the caller - skipping the rest of the function - just ignoring The

UI layer threading and locking strategy; memory_region_snapshot_and_clear_dirty() races

Hi; I'm trying to find out what the UI layer's threading and locking strategy is, at least as far as it applies to display device models. Specifically: * is the device's GraphicHwOps::gfx_update method always called from one specific thread, or might it be called from any thread? * is that me

[PATCH v8 12/17] msix: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of msix_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci/msix.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deleti

Re: [PULL 00/14] qemu-macppc queue 20221031

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH 15/16] tests/qtest: virtio-9p-test: Adapt the case for win32

On Monday, October 24, 2022 6:57:58 AM CET Bin Meng wrote: > From: Guohuai Shi > > Windows does not provide the getuid() API. Let's create a local > one and return a fixed value 0 as the uid for testing. > > Signed-off-by: Guohuai Shi > Signed-off-by: Xuzhou Cheng > Signed-off-by: Bin Meng >

[PATCH v9 15/17] hw/vfio/pci: Omit errp for pci_add_capability

The code generating errors in pci_add_capability has a comment which says: > Verify that capabilities don't overlap. Note: device assignment > depends on this check to verify that the device is not broken. > Should never trigger for emulated devices, but it's helpful for > debugging these. Indeed

Re: [PATCH] migration: check magic value for deciding the mapping of channels

On 01/11/22 8:21 pm, Daniel P. Berrangé wrote: On Tue, Nov 01, 2022 at 02:30:29PM +, manish.mishra wrote: Current logic assumes that channel connections on the destination side are always established in the same order as the source and the first one will always be the default channel follo

[PATCH v9 11/17] pci/shpc: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of shpc_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- include/hw/pci/shpc.h | 3 +-- hw/pci-bridge/pci_bridge_de

[PATCH v8 04/17] ahci: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

  1   2   >