When one has a lot of keys in ~/.ssh directory, the ssh command will
try all of them before the one specified on the command line, and this
may cause the remote ssh server to reject the connection due to too
many failed authentication attempts.
Fix by adding -o IdentitiesOnly=yes, which makes the
On 10/27/22 21:18, Ilya Leoshkevich wrote:
On Fri, Oct 21, 2022 at 05:30:05PM +1000, Richard Henderson wrote:
Signed-off-by: Richard Henderson
---
target/s390x/helper.h | 22 +++
target/s390x/tcg/fpu_helper.c | 29 ++--
target/s390x/tcg/translate.c |
The primary motivator here are the numerous bug reports (e.g. #290)
about not being able to handle very large memory allocations.
I presume all or most of these are due to guest use of the clang
address sanitizer, which allocates a massive shadow vma.
This patch set copies the linux kernel code fo
On 10/27/22 13:30, Richard Henderson wrote:
> On 10/27/22 20:40, Claudio Fontana wrote:
>> On 10/27/22 12:02, Richard Henderson wrote:
>>> Add a way to examine the unwind data without actually
>>> restoring the data back into env.
>>>
>>> Signed-off-by: Richard Henderson
>>> ---
>>> accel/tcg/in
On Tue, Sep 06, 2022 at 10:26:35AM +0100, Richard W.M. Jones wrote:
> On Tue, Sep 06, 2022 at 09:41:42AM +0100, Daniel P. Berrangé wrote:
> > Both the master key and key slot passphrases are run through the PBKDF2
> > algorithm. The iterations count is expected to be generally very large
> > (many
On Mon, 17 Oct 2022 12:21:35 +0200
Igor Mammedov wrote:
> Series continues refactoring started at recently merged [1].
> It replaces special cases/quirks for ISA/SMB bridges and PCI
> attached VGA devices with generic AcpiDevAmlIf interface,
> which allows device to provide its own AML descriptio
On 27.10.22 09:27, Emanuele Giuseppe Esposito wrote:
blk_set_enable_write_cache() is defined as GLOBAL_STATE_CODE
but can be invoked from iothreads when handling scsi requests.
This triggers an assertion failure:
0x7fd6c3515ce1 in raise () from /lib/x86_64-linux-gnu/libc.so.6
0x7fd6c
On 27.10.22 12:14, Fiona Ebner wrote:
Commit 85c4bf8aa6 ("vl: Unlink absolute PID file path") made it a
critical error when the PID file path cannot be resolved. Before this
commit, it was possible to invoke QEMU when the PID file was a file
created with mkstemp that was already unlinked at the t
27.10.2022 13:42, Michael Tokarev wrote:
27.10.2022 09:40, Laurent Vivier wrote:
..
I tried O_CLOEXEC, but it seems the fd is closed before it is needed by execveat() to re-spawn the process, so it exits with an error (something
like EBADF)
It works here for me with a simple test program:
#in
On Thu, Oct 27, 2022 at 12:14:43PM +0200, Fiona Ebner wrote:
> Commit 85c4bf8aa6 ("vl: Unlink absolute PID file path") made it a
> critical error when the PID file path cannot be resolved. Before this
> commit, it was possible to invoke QEMU when the PID file was a file
> created with mkstemp that
On 27/10/2022 13.30, Ilya Leoshkevich wrote:
When one has a lot of keys in ~/.ssh directory, the ssh command will
try all of them before the one specified on the command line, and this
may cause the remote ssh server to reject the connection due to too
many failed authentication attempts.
Fix by
On 10/27/22 12:02, Richard Henderson wrote:
> Avoid cpu_restore_state, and modifying env->eip out from
> underneath the translator with TARGET_TB_PCREL. There is
> some slight duplication from x86_restore_state_to_opc,
> but it's just a few lines.
>
> Resolves: https://gitlab.com/qemu-project/qem
On Thu, 27 Oct 2022, Howard Spoelstra wrote:
I applied these patches and they seem to work as expected. I like the way
this makes it clearer which machine is actually emulated, even though it is
still not easy to understand which default hardware the emulated machine
actually presents.
Thanks f
On 26/10/2022 18.18, Alex Bennée wrote:
Daniel P. Berrangé writes:
CC'ing Marc-André as original author of the change
On Tue, Oct 25, 2022 at 01:57:23PM +0100, Alex Bennée wrote:
Juan Quintela writes:
Previous commit removed the creation of the fifo. Without it, I get
random failure du
Thanks, it works for us
On Thu, Oct 27, 2022 at 03:27:26AM -0400, Emanuele Giuseppe Esposito wrote:
> blk_set_enable_write_cache() is defined as GLOBAL_STATE_CODE
> but can be invoked from iothreads when handling scsi requests.
> This triggers an assertion failure:
>
> 0x7fd6c3515ce1 in rais
As usual, we held a QEMU Summit meeting at KVM Forum.
This is an invite-only meeting for the most active maintainers
and submaintainers in the project, and we discuss various
project-wide issues, usually process stuff. We then post
the minutes of the meeting to the list as a jumping off point
for w
On 10/26/22 14:33, Daniel P. Berrangé wrote:
> On Wed, Oct 26, 2022 at 09:30:24AM +0200, Michal Privoznik wrote:
>> Upon failure, a libseccomp API returns actual errno value very
>> rarely. Fortunately, after its commit 34bf78ab (contained in
>> 2.5.0 release), the SCMP_FLTATR_API_SYSRAWRC attribut
available in the Git repository at:
https://git.linaro.org/people/pmaydell/qemu-arm.git
tags/pull-target-arm-20221027
for you to fetch changes up to 6233a138599bea89ad683b883dca38388f12fd2d:
mips/malta: pass RNG seed via env var and re-randomize on reboot (2022-10-27
11:4
On Thu, Oct 27, 2022 at 01:50:37PM +0100, Peter Maydell wrote:
> Infrastructure
> ==
snip
> Alex Bennee has successfully signed the QEMU project up for the GitLab
> Open Source Program, which grants Ultimate tier features. This includes
> 50,000 CI minutes per month, 500 GB of transfe
On Thu, Oct 27, 2022 at 02:55:02PM +0200, Michal Prívozník wrote:
> On 10/26/22 14:33, Daniel P. Berrangé wrote:
> > On Wed, Oct 26, 2022 at 09:30:24AM +0200, Michal Privoznik wrote:
> >> Upon failure, a libseccomp API returns actual errno value very
> >> rarely. Fortunately, after its commit 34bf7
On 2022/10/27 15:50, Jason Wang wrote:
We used to have a macro for VTD_PE_GET_FPD_ERR() but it has an
internal goto which prevents it from being reused. This patch convert
that macro to a dedicated function and let the caller to decide what
to do (e.g using goto or not). This makes sure it can be
On 2022/10/27 15:50, Jason Wang wrote:
We use to warn on wrong rid2pasid entry. But this error could be
triggered by the guest and could happens during initialization. So
let's don't warn in this case.
Signed-off-by: Jason Wang
---
hw/i386/intel_iommu.c | 6 --
1 file changed, 4 insertio
On Thu, 27 Oct 2022 01:59:22 -0400
"Michael S. Tsirkin" wrote:
> Just noticed this when disassembling:
>
> Parsing completed
> ACPI Warning: NsLookup: Type mismatch on ODAT (RegionField), searching for
> (Buffer) (20210604/nsaccess-760)
> Disassembly completed
> ASL Output:/tmp/old-asl2/tes
Thomas Huth writes:
> On 26/10/2022 18.18, Alex Bennée wrote:
>> Daniel P. Berrangé writes:
>>
>>> CC'ing Marc-André as original author of the change
>>>
>>> On Tue, Oct 25, 2022 at 01:57:23PM +0100, Alex Bennée wrote:
Juan Quintela writes:
> Previous commit removed the cr
When we direct boot a kernel on a CPU which emulates EL3, we need to
set up the EL3 system registers as the Linux kernel documentation
specifies:
https://www.kernel.org/doc/Documentation/arm64/booting.rst
For CPUs with FEAT_HCX support this includes:
- SCR_EL3.HXEn (bit 38) must be initia
When we direct boot a kernel on a CPU which emulates EL3, we need to
set up the EL3 system registers as the Linux kernel documentation
specifies:
https://www.kernel.org/doc/Documentation/arm64/booting.rst
Mostly we get this right, but working through the list of config
bits that need to be set
> The helpers for reset_rf, cli, sti, clac, stac are
> completely trivial; implement them inline.
>
> Drop some nearby #if 0 code.
Reviewed-by: Paolo Bonzini
When we direct boot a kernel on a CPU which emulates EL3, we need
to set up the EL3 system registers as the Linux kernel documentation
specifies:
https://www.kernel.org/doc/Documentation/arm64/booting.rst
For SVE and SME this includes:
- ZCR_EL3.LEN must be initialised to the same value for a
Queued, thanks.
Paolo
On Thu, 27 Oct 2022 02:11:23 -0400
"Michael S. Tsirkin" wrote:
> On Tue, Oct 11, 2022 at 01:17:31PM +0200, Julia Suvorova wrote:
> > Changes in the tables (for 275 cores):
> > FACP:
> > + Use APIC Cluster Model (V4) : 1
> >
> > APIC:
> > +[02Ch 0044 1]Subtable T
On 27/10/22 08:46, Thomas Huth wrote:
On 26/10/2022 01.50, Philippe Mathieu-Daudé wrote:
We use the .h.inc extension to include C headers. To be consistent
with the rest of the codebase, rename the C headers using the .def
extension.
IDE/tools using our .editorconfig / .gitattributes will lever
On Thu, Oct 27, 2022 at 03:52:53PM +0200, Igor Mammedov wrote:
> On Thu, 27 Oct 2022 01:59:22 -0400
> "Michael S. Tsirkin" wrote:
>
> > Just noticed this when disassembling:
> >
> > Parsing completed
> > ACPI Warning: NsLookup: Type mismatch on ODAT (RegionField), searching for
> > (Buffer) (20
On Thu, Oct 27, 2022 at 02:06:40PM +0200, Igor Mammedov wrote:
> On Mon, 17 Oct 2022 12:21:35 +0200
> Igor Mammedov wrote:
>
> > Series continues refactoring started at recently merged [1].
> > It replaces special cases/quirks for ISA/SMB bridges and PCI
> > attached VGA devices with generic Acpi
This test is hanging under heavy load when the two socats race while
trying to create the socket. I've tried various approaches to avoid
the race but it seems "creat=0" won't stop socat trying to create a
pipe if it executes first. In the end I just use a small sleep which
seems to be reliable enou
On Tue, Oct 04, 2022 at 12:52:36PM -0700, Richard Henderson wrote:
> Wrap the bare TranslationBlock pointer into a structure.
>
> Reviewed-by: Alex Bennée
> Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: Richard Henderson
> ---
> accel/tcg/tb-hash.h | 1 +
> accel/tcg/tb-jmp-cache
On Thu, Oct 27, 2022 at 02:59:04PM +0100, Alex Bennée wrote:
>
> Thomas Huth writes:
>
> > On 26/10/2022 18.18, Alex Bennée wrote:
> >> Daniel P. Berrangé writes:
> >>
> >>> CC'ing Marc-André as original author of the change
> >>>
> >>> On Tue, Oct 25, 2022 at 01:57:23PM +0100, Alex Bennée wro
ok to summarize then:
patch 1) e820 - submitted as a separate patch/bugfix for mst to pick up
patch 2&3) Pickup by Jonathan for his branch as it depends on DOE and other
changes.
patch 4) incorrect, this should be done in bios/efi, drop entirely
On Thu, Oct 27, 2022 at 11:58:54AM +0100, Jonath
On Thu, Oct 27, 2022 at 03:50:38PM +0800, Jason Wang wrote:
> Hi All:
>
> This series tries to introduce PASID support for Intel IOMMU. The work
> is based on the previous scalabe mode support by implement the
> ECAP_PASID. A new "x-pasid-mode" is introduced to enable this
> mode. All internal vIO
Cc'ing stable
On Fri, 21 Oct 2022 12:57:34 +0200
Greg Kurz wrote:
> When `-D ${logfile} -d tid` is passed, qemu_log_trylock() creates
> a dedicated log file for the current thread and opens it. The
> corresponding file descriptor is cached in a __thread variable.
> Nothing is done to close the c
Philippe Mathieu-Daudé writes:
> We use the .h.inc extension to include C headers. To be consistent
> with the rest of the codebase, rename the C headers using the .def
> extension.
>
> IDE/tools using our .editorconfig / .gitattributes will leverage
> this consistency.
>
> Philippe Mathieu-Daudé
On Thu, Oct 27, 2022 at 04:18:56PM +0200, Ilya Leoshkevich wrote:
> On Tue, Oct 04, 2022 at 12:52:36PM -0700, Richard Henderson wrote:
> > Wrap the bare TranslationBlock pointer into a structure.
> >
> > Reviewed-by: Alex Bennée
> > Reviewed-by: Philippe Mathieu-Daudé
> > Signed-off-by: Richard
A ping on this one, is there anything more that needs to be urgently addressed
before it can be queued for inclusion?
This is currently creating problems for upstream kubevirt, due to the error
handling not properly reporting permissions errors on module file access.
Thanks,
Claudio
On 10/21/2
On Thu, 27 Oct 2022 at 15:40, Markus Armbruster wrote:
> I wonder why we use any of .def, .h.inc, .inc.h, .c.inc, .inc.c. Why
> not .h and call it a day? No need to configure each and every editor to
> tread these as C code.
It says "this isn't actually a header in the usual sense". That's
usef
Hi Alex,
On Thu, Oct 20, 2022 at 9:53 PM Alex Bennée wrote:
>
> Hi,
>
> The testing/next changes have accumulated a few more fixes since the
> last posting. Including:
>
> - a bunch of Bin Meng's test cleanups for windows
> - some avocado test fixes and tweaks
> - disabling an sh4 avocado t
we had such a beautiful structure for updating
expected files, designed to keep bisect working.
It turns out that we ignored the result of
the allow list checks unless all tables matched
anyway.
Sigh.
Let's at least make it work going forward.
Signed-off-by: Michael S. Tsirkin
---
tests/qtest/
On 27/10/2022 16.12, Philippe Mathieu-Daudé wrote:
On 27/10/22 08:46, Thomas Huth wrote:
On 26/10/2022 01.50, Philippe Mathieu-Daudé wrote:
We use the .h.inc extension to include C headers. To be consistent
with the rest of the codebase, rename the C headers using the .def
extension.
IDE/tools
On Thu, Oct 27, 2022 at 03:40:31PM +0800, Cindy Lu wrote:
> Move the function vfio_get_xlat_addr to softmmu/memory.c, and
> change the name to memory_get_xlat_addr().So we can use this
> function in other devices,such as vDPA device.
>
> Signed-off-by: Cindy Lu
Acked-by: Peter Xu
Trivial nit b
On Thu, Oct 27, 2022 at 8:41 PM Michael S. Tsirkin wrote:
>
> we had such a beautiful structure for updating
> expected files, designed to keep bisect working.
> It turns out that we ignored the result of
> the allow list checks unless all tables matched
> anyway.
Doh! Seems the bug is present f
Putting zoned/non-zoned BlockDrivers on top of each other is not
allowed.
Signed-off-by: Sam Li
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Hannes Reinecke
Reviewed-by: Dmitry Fomichev
---
block.c | 19 +++
block/file-posix.c | 12 +
Add the documentation about the zoned device support to virtio-blk
emulation.
Signed-off-by: Sam Li
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Damien Le Moal
Reviewed-by: Dmitry Fomichev
---
docs/devel/zoned-storage.rst | 43 ++
docs/system/qemu-block-drivers.
Signed-off-by: Sam Li
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Damien Le Moal
Reviewed-by: Hannes Reinecke
---
include/block/block-common.h | 43
1 file changed, 43 insertions(+)
diff --git a/include/block/block-common.h b/include/block/block-common.h
ind
Use get_sysfs_str_val() to get the string value of device
zoned model. Then get_sysfs_zoned_model() can convert it to
BlockZoneModel type of QEMU.
Use get_sysfs_long_val() to get the long value of zoned device
information.
Signed-off-by: Sam Li
Reviewed-by: Hannes Reinecke
Reviewed-by: Stefan H
Signed-off-by: Sam Li
---
block/file-posix.c | 3 +++
block/trace-events | 2 ++
2 files changed, 5 insertions(+)
diff --git a/block/file-posix.c b/block/file-posix.c
index 02476c011e..fe52e91da4 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -3259,6 +3259,7 @@ static int coroutine_
Zoned Block Devices (ZBDs) devide the LBA space to block regions called zones
that are larger than the LBA size. It can only allow sequential writes, which
reduces write amplification in SSD, leading to higher throughput and increased
capacity. More details about ZBDs can be found at:
https://zone
raw-format driver usually sits on top of file-posix driver. It needs to
pass through requests of zone commands.
Signed-off-by: Sam Li
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Damien Le Moal
Reviewed-by: Hannes Reinecke
Reviewed-by: Dmitry Fomichev
---
block/raw-format.c | 13 +
Ilya Leoshkevich writes:
> When one has a lot of keys in ~/.ssh directory, the ssh command will
> try all of them before the one specified on the command line, and this
> may cause the remote ssh server to reject the connection due to too
> many failed authentication attempts.
>
> Fix by adding
We have added new block layer APIs of zoned block devices. Test it as
follows: Run each zone operation on a newly created null_blk device
and see whether the logs show the correct zone information. By:
$ ./tests/qemu-iotests/tests/zoned.sh
Signed-off-by: Sam Li
Reviewed-by: Stefan Hajnoczi
---
v5:
- fix locking conditions and error handling
- drop some trival optimizations
- add tracing points for zone append
v4:
- fix lock related issues[Damien]
- drop all field in zone_mgmt op [Damien]
- fix state checks in zong_mgmt command [Damien]
- return start sector of wp when issuing zap req [D
Signed-off-by: Sam Li
---
block/file-posix.c | 3 +++
block/trace-events | 2 ++
2 files changed, 5 insertions(+)
diff --git a/block/file-posix.c b/block/file-posix.c
index 9c1afb7749..b23cfb02e3 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -2489,6 +2489,8 @@ out:
if
On 24/10/2022 12.54, Christian Schoenebeck wrote:
The following changes since commit 0529245488865038344d64fff7ee05864d3d17f6:
Merge tag 'pull-target-arm-20221020' of
https://git.linaro.org/people/pmaydell/qemu-arm into staging (2022-10-20
14:36:12 -0400)
are available in the Git repositor
Add a new zoned_host_device BlockDriver. The zoned_host_device option
accepts only zoned host block devices. By adding zone management
operations in this new BlockDriver, users can use the new block
layer APIs including Report Zone and four zone management operations
(open, close, finish, reset, re
This tests is mainly a helper to indicate append writes in block layer
behaves as expected.
Signed-off-by: Sam Li
---
qemu-io-cmds.c | 63 ++
tests/qemu-iotests/tests/zoned.out | 7
tests/qemu-iotests/tests/zoned.sh | 9 +
3 files chang
A zone append command is a write operation that specifies the first
logical block of a zone as the write position. When writing to a zoned
block device using zone append, the byte offset of writes is pointing
to the write pointer of that zone. Upon completion the device will
respond with the positi
Since Linux doesn't have a user API to issue zone append operations to
zoned devices from user space, the file-posix driver is modified to add
zone append emulation using regular writes. To do this, the file-posix
driver tracks the wp location of all zones of the device. It uses an
array of uint64_
On 20/10/2022 13.52, Alex Bennée wrote:
From: Peter Maydell
The avocado test
tests/avocado/boot_linux_console.py:BootLinuxConsole.test_arm_raspi2_initrd
finishes wiith
exec_command(self, 'halt')
# Wait for VM to shut down gracefully
self.vm.wait()
In theory this should be fin
On 20/10/2022 13.51, Alex Bennée wrote:
Changes to the build files are a bit special in that they usually go
through other maintainer trees. However considering the build system
is the root of everything a developer is likely to do we should at
least set it out in MAINTAINERS.
I'm going to nomin
On 20/10/2022 13.52, Alex Bennée wrote:
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
Signed-off-by: Alex Bennée
Message-Id: <20221013131304.623740-1-pbonz...@redhat.com>
---
configure | 3 +++
1 file changed, 3 insertions(+)
diff --git a/configure b/configure
index 8c2c4c1a04..4275f54
Hi Christian,
On Mon, Oct 24, 2022 at 1:16 PM Bin Meng wrote:
>
> At present there is no Windows support for 9p file system.
> This series adds initial Windows support for 9p file system.
>
> 'local' file system backend driver is supported on Windows,
> including open, read, write, close, rename,
On Thursday, October 27, 2022 6:19:27 PM CEST Bin Meng wrote:
> Hi Christian,
>
> On Mon, Oct 24, 2022 at 1:16 PM Bin Meng wrote:
> >
> > At present there is no Windows support for 9p file system.
> > This series adds initial Windows support for 9p file system.
> >
> > 'local' file system backend
On Thursday, October 27, 2022 5:53:47 PM CEST Thomas Huth wrote:
> On 24/10/2022 12.54, Christian Schoenebeck wrote:
> > The following changes since commit 0529245488865038344d64fff7ee05864d3d17f6:
> >
> >Merge tag 'pull-target-arm-20221020' of
> > https://git.linaro.org/people/pmaydell/qemu-
This series mainly includes fixes discovered while developing nested
virtualization running on QEMU.
These patches can also be found in the riscv_nested_fixes_v1 branch at:
https://github.com/avpatel/qemu.git
Anup Patel (5):
target/riscv: Typo fix in sstc() predicate
target/riscv: Update VS t
We should call decode_save_opc() for all relevant instructions which
can potentially generate a virtual instruction fault or a guest page
fault because generating transformed instruction upon guest page fault
expects opcode to be available. Without this, hypervisor will see
transformed instruction
We should use "&&" instead of "&" when checking hcounteren.TM and
henvcfg.STCE bits.
Fixes: 3ec0fe18a31f ("target/riscv: Add vstimecmp suppor")
Signed-off-by: Anup Patel
---
target/riscv/csr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/riscv/csr.c b/target/riscv/c
Instead of clearing mask in riscv_cpu_update_mip() for VSTIP, we
should call riscv_cpu_update_mip() with mask == 0 from timer_helper.c
for VSTIP.
Fixes: 3ec0fe18a31f ("target/riscv: Add vstimecmp suppor")
Signed-off-by: Anup Patel
---
target/riscv/cpu_helper.c | 2 --
target/riscv/time_helper.
The time CSR will wrap-around immediately after reaching UINT64_MAX
so we don't need to re-start QEMU timer when timecmp == UINT64_MAX
in riscv_timer_write_timecmp().
Signed-off-by: Anup Patel
---
target/riscv/time_helper.c | 8
1 file changed, 8 insertions(+)
diff --git a/target/riscv
The htimedelta[h] CSR has impact on the VS timer comparison so we
should call riscv_timer_write_timecmp() whenever htimedelta changes.
Fixes: 3ec0fe18a31f ("target/riscv: Add vstimecmp suppor")
Signed-off-by: Anup Patel
---
target/riscv/csr.c | 16
1 file changed, 16 insertions(
The fid instruction (Floating-Point Identify) puts the FPU model and
revision into the Status Register. Since those values shouldn't be 0,
store values there which a PCX-L2 (for 32-bit) or a PCX-W2 (for 64-bit)
would return. Noticed while trying to install MPE/iX.
Signed-off-by: Helge Deller
---
Am 13.10.2022 um 14:37 hat Paolo Bonzini geschrieben:
> From: Alberto Faria
>
> Signed-off-by: Alberto Faria
> Signed-off-by: Paolo Bonzini
> @@ -1699,8 +1699,8 @@ static int coroutine_fn qcow2_do_open(BlockDriverState
> *bs, QDict *options,
> }
>
> s->image_backing_file =
Am 13.10.2022 um 14:37 hat Paolo Bonzini geschrieben:
> From: Alberto Faria
>
> Signed-off-by: Alberto Faria
> Signed-off-by: Paolo Bonzini
> @@ -1624,12 +1624,11 @@ static int coroutine_fn
> get_cluster_offset(BlockDriverState *bs,
> }
> l2_table = (char *)extent->l2_cache + (min_i
Am 13.10.2022 um 14:36 hat Paolo Bonzini geschrieben:
> Most of these were extracted from Alberto's static analysis series.
> After this series, the only errors reported by the analyzer are:
>
> - a call to bs->drv->bdrv_co_drain_begin from bdrv_open_driver. This
> relies on bdrv_co_drain_begin
I've posted an RFC to fix the regression in test-io-command and once that
is reviewed I'll push out the pr.
On Thu, 27 Oct 2022, 16:06 Bin Meng, wrote:
> Hi Alex,
>
> On Thu, Oct 20, 2022 at 9:53 PM Alex Bennée
> wrote:
> >
> > Hi,
> >
> > The testing/next changes have accumulated a few more fi
Peter Maydell writes:
> On Thu, 27 Oct 2022 at 15:40, Markus Armbruster wrote:
>> I wonder why we use any of .def, .h.inc, .inc.h, .c.inc, .inc.c. Why
>> not .h and call it a day? No need to configure each and every editor to
>> tread these as C code.
>
> It says "this isn't actually a header
On Thu, 27 Oct 2022 at 18:17, Markus Armbruster wrote:
>
> Peter Maydell writes:
>
> > On Thu, 27 Oct 2022 at 15:40, Markus Armbruster wrote:
> >> I wonder why we use any of .def, .h.inc, .inc.h, .c.inc, .inc.c. Why
> >> not .h and call it a day? No need to configure each and every editor to
>
On Fri, 27 May 2022 at 22:05, Richard Henderson
wrote:
>
> This is in line with how we treat uzp, and will
> eliminate the special case code during translation.
>
> Signed-off-by: Richard Henderson
> ---
Sorry, a bit late, but I believe this change broke the implementation
of the ZIP2 SVE instru
From: Michal Privoznik
Upon failure, a libseccomp API returns actual errno value very
rarely. Fortunately, after its commit 34bf78ab (contained in
2.5.0 release), the SCMP_FLTATR_API_SYSRAWRC attribute can be set
which makes subsequent APIs return true errno on failure.
This is especially critic
From: Bin Meng
There is no need to do a type cast on ssource->socket as it is
already declared as a SOCKET.
Suggested-by: Marc-André Lureau
Signed-off-by: Bin Meng
Reviewed-by: Marc-André Lureau
Signed-off-by: Daniel P. Berrangé
---
io/channel-watch.c | 6 +++---
1 file changed, 3 insertion
Using FILE * APIs for writing the PSK file results in translation from
UNIX to DOS line endings on Windows. When the crypto PSK code later
loads the credentials the stray \r will result in failure to load the
PSK credentials into GNUTLS.
Rather than switching the FILE* APIs to open in binary forma
Validate that we diagnose each malformed LUKS header scenario with a
distinct error report.
Reviewed-by: Richard W.M. Jones
Signed-off-by: Daniel P. Berrangé
---
tests/unit/test-crypto-block.c | 299 +
1 file changed, 299 insertions(+)
diff --git a/tests/unit/te
If setting credentials fails, the handshake will later fail to complete
with an obscure error message which is hard to diagnose.
Reviewed-by: Bin Meng
Tested-by: Bin Meng
Signed-off-by: Daniel P. Berrangé
---
crypto/tlscredspsk.c | 16 +---
1 file changed, 13 insertions(+), 3 delet
Currently we check status of each submodule, before actually checking
if we're in a git repo. These status commands will all fail, but we
are hiding their output so we don't see it currently.
Reviewed-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
---
scripts/git-submodule.sh | 12 ++
If given a malformed LUKS header, it is possible that the algorithm
names end up being an empty string. This leads to confusing error
messages unless quoting is used to highlight where the empty string
is subsituted in the error message.
Reviewed-by: Richard W.M. Jones
Signed-off-by: Daniel P. Be
Both the master key and key slot passphrases are run through the PBKDF2
algorithm. The iterations count is expected to be generally very large
(many 10's or 100's of 1000s). It is hard to define a low level cutoff,
but we can certainly say that iterations count should be non-zero. A
zero count like
Although the LUKS stripes are encoded in the keyslot header and so
potentially configurable, in pratice the cryptsetup impl mandates
this has the fixed value 4000. To avoid incompatibility apply the
same enforcement in QEMU too. This also caps the memory usage for
key material when QEMU tries to op
From: Bin Meng
Random failure was observed when running qtests on Windows due to
"Broken pipe" detected by qmp_fd_receive(). What happened is that
the qtest executable sends testing data over a socket to the QEMU
under test but no response is received. The errno of the recv()
call from the qtest
From: Bin Meng
Replace the existing logic to get the directory for temporary files
with g_get_tmp_dir(), which works for win32 too.
Signed-off-by: Bin Meng
Reviewed-by: Marc-André Lureau
Signed-off-by: Daniel P. Berrangé
---
util/qemu-sockets.c | 5 ++---
1 file changed, 2 insertions(+), 3 d
This will allow unit testing code to use the structs.
Reviewed-by: Richard W.M. Jones
Signed-off-by: Daniel P. Berrangé
---
crypto/block-luks-priv.h | 137 +++
crypto/block-luks.c | 94 +--
2 files changed, 138 insertions(+), 93
The LUKS spec requires that header strings are NUL-terminated, and our
code relies on that. Protect against maliciously crafted headers by
adding validation.
Reviewed-by: Richard W.M. Jones
Signed-off-by: Daniel P. Berrangé
---
crypto/block-luks.c | 18 ++
1 file changed, 18 ins
We already validate that LUKS keyslots don't overlap with the
header, or with each other. This closes the remaining hole in
validation of LUKS file regions.
Reviewed-by: Richard W.M. Jones
Signed-off-by: Daniel P. Berrangé
---
crypto/block-luks.c | 7 +++
1 file changed, 7 insertions(+)
di
From: Jungmin Park
When the user creates a LUKS-encrypted qcow2 image using the qemu-img
program, the passphrase is hashed using PBKDF2 with a dynamic
number of iterations. The number of iterations is determined by
measuring thread cpu time usage, such that it takes approximately
2 seconds to com
The LUKS header data on disk is a fixed size, however, there's expected
to be a gap between the end of the header and the first key slot to get
alignment with the 2nd sector on 4k drives. This wasn't originally part
of the LUKS spec, but was always part of the reference implementation,
so it is wor
101 - 200 of 419 matches
Mail list logo
