[PATCH v2] seccomp: Get actual errno value from failed seccomp functions

2022-10-26 Thread Michal Privoznik
Upon failure, a libseccomp API returns actual errno value very rarely. Fortunately, after its commit 34bf78ab (contained in 2.5.0 release), the SCMP_FLTATR_API_SYSRAWRC attribute can be set which makes subsequent APIs return true errno on failure. This is especially critical when seccomp_load() fa

Re: [PATCH] chardev/char-win-stdio: Pass Ctrl+C to guest with a multiplexed monitor

2022-10-26 Thread Marc-André Lureau
On Tue, Oct 25, 2022 at 6:15 PM Bin Meng wrote: > > At present when pressing Ctrl+C from a guest running on QEMU Windows > with a multiplexed monitor, e.g.: -serial mon:stdio, QEMU executable > just exits. This behavior is inconsistent with the Linux version. > > Such behavior is caused by uncondi

Re: [PULL v2 00/11] Dump patches

2022-10-26 Thread Marc-André Lureau
Hi Janosch On Wed, Oct 26, 2022 at 1:37 AM Stefan Hajnoczi wrote: > Please solve this CI failure: > > c++ -o qemu-system-s390x ... > /usr/bin/ld: libqemu-s390x-softmmu.fa.p/target_s390x_arch_dump.c.o: in > function `arch_sections_add': > > /home/gitlab-runner/builds/Y1MP9VSY/0/qemu-project/qemu/

Re: [PATCH v2 1/4] hw/virtio: incorporate backend features in features

2022-10-26 Thread Alex Bennée
Yajun Wu writes: > Hi Alex, > > With this change, VHOST_USER_F_PROTOCOL_FEATURES bit will be set to > backend for virtio block device (previously not). > > From https://www.qemu.org/docs/master/interop/vhost-user.html spec: > If VHOST_USER_F_PROTOCOL_FEATURES has not been negotiated, the ring s

[PATCH v2 1/2] xen/pt: fix syntax error that causes FTBFS in some configurations

2022-10-26 Thread Chuck Zmudzinski
When Qemu is built with --enable-xen and --disable-xen-pci-passthrough and the target os is linux, the build fails with: meson.build:3477:2: ERROR: File xen_pt_stub.c does not exist. Fixes: 582ea95f5f93 ("meson: convert hw/xen") Signed-off-by: Chuck Zmudzinski --- v2: Remove From: tag at top o

[PATCH v2 2/2] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2022-10-26 Thread Chuck Zmudzinski
Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, as noted in docs/igd-assign.txt in the Qemu source code. Currently, when the xl toolstack is used to configure a Xen HVM guest with Intel IGD passthrough to the guest with the Qemu upstream device model, a Qemu emulated PCI devi

[PATCH v2 0/2] xen/pt: fix FTBFS and reserve PCI slot 2 for the Intel IGD

2022-10-26 Thread Chuck Zmudzinski
This is a series of two patches: The first fixes FTBFS when --enable-xen and --disable-xen-pci-passthrough configure options are set with when building for the linux target os. The second fixes a regression that was introduced many years ago with the upgrade from the Qemu traditional device model

Re: [PATCH 3/3] target/tricore: Rename csfr.def -> csfr.h.inc

2022-10-26 Thread Bastian Koppelmann
On Wed, Oct 26, 2022 at 01:50:06AM +0200, Philippe Mathieu-Daudé wrote: > We use the .h.inc extension to include C headers. To be consistent > with the rest of the codebase, rename the C headers using the .def > extension. > > IDE/tools using our .editorconfig / .gitattributes will leverage > this

Re: [PULL v2 00/11] Dump patches

2022-10-26 Thread Janosch Frank
On 10/26/22 09:42, Marc-André Lureau wrote: Hi Janosch On Wed, Oct 26, 2022 at 1:37 AM Stefan Hajnoczi wrote: Please solve this CI failure: c++ -o qemu-system-s390x ... /usr/bin/ld: libqemu-s390x-softmmu.fa.p/target_s390x_arch_dump.c.o: in function `arch_sections_add': /home/gitlab-runner/b

Re: [PATCH v10 1/9] s390x/cpu topology: core_id sets s390x CPU topology

2022-10-26 Thread Pierre Morel
On 10/25/22 21:58, Janis Schoetterl-Glausch wrote: On Wed, 2022-10-12 at 18:20 +0200, Pierre Morel wrote: In the S390x CPU topology the core_id specifies the CPU address and the position of the core withing the topology. Let's build the topology based on the core_id. s390x/cpu topology: core

[PATCH v1] block/rbd: Add support for layered encryption

2022-10-26 Thread Or Ozeri
Starting from ceph Reef, RBD has built-in support for layered encryption, where each ancestor image (in a cloned image setting) can be possibly encrypted using a unique passphrase. A new function, rbd_encryption_load2, was added to librbd API. This new function supports an array of passphrases (vi

[PULL v3 01/11] dump: Use a buffer for ELF section data and headers

2022-10-26 Thread marcandre . lureau
From: Janosch Frank Currently we're writing the NULL section header if we overflow the physical header number in the ELF header. But in the future we'll add custom section headers AND section data. To facilitate this we need to rearange section handling a bit. As with the other ELF headers we sp

[PULL v3 00/11] Dump patches

2022-10-26 Thread marcandre . lureau
From: Marc-André Lureau The following changes since commit e750a7ace492f0b450653d4ad368a77d6f660fb8: Merge tag 'pull-9p-20221024' of https://github.com/cschoenebeck/qemu into staging (2022-10-24 14:27:12 -0400) are available in the Git repository at: https://gitlab.com/marcandre.lureau/qe

[PULL v3 02/11] dump: Write ELF section headers right after ELF header

2022-10-26 Thread marcandre . lureau
From: Janosch Frank Let's start bundling the writes of the headers and of the data so we have a clear ordering between them. Since the ELF header uses offsets to the headers we can freely order them. Signed-off-by: Janosch Frank Reviewed-by: Marc-André Lureau Message-Id: <20221017083822.43118-

[PULL v3 07/11] s390x: Introduce PV query interface

2022-10-26 Thread marcandre . lureau
From: Janosch Frank Introduce an interface over which we can get information about UV data. Signed-off-by: Janosch Frank Reviewed-by: Steffen Eiden Reviewed-by: Janis Schoetterl-Glausch Acked-by: Thomas Huth Message-Id: <20221017083822.43118-8-fran...@linux.ibm.com> --- include/hw/s390x/pv.

[PULL v3 04/11] dump: Reintroduce memory_offset and section_offset

2022-10-26 Thread marcandre . lureau
From: Janosch Frank section_offset will later be used to store the offset to the section data which will be stored last. For now memory_offset is only needed to make section_offset look nicer. Signed-off-by: Janosch Frank Reviewed-by: Marc-André Lureau Message-Id: <20221017083822.43118-5-fran.

[PULL v3 11/11] dump/win_dump: limit number of processed PRCBs

2022-10-26 Thread marcandre . lureau
From: Viktor Prutyanov When number of CPUs utilized by guest Windows is less than defined in QEMU (i.e., desktop versions of Windows severely limits number of CPU sockets), patch_and_save_context routine accesses non-existent PRCB and fails. So, limit number of processed PRCBs by NumberProcessors

[PULL v3 06/11] s390x: Add protected dump cap

2022-10-26 Thread marcandre . lureau
From: Janosch Frank Add a protected dump capability for later feature checking. Signed-off-by: Janosch Frank Reviewed-by: Steffen Eiden Reviewed-by: Thomas Huth Reviewed-by: Janis Schoetterl-Glausch Message-Id: <20221017083822.43118-7-fran...@linux.ibm.com> [ Marc-André - Add missing stubs w

[PULL v3 05/11] dump: Add architecture section and section string table support

2022-10-26 Thread marcandre . lureau
From: Janosch Frank Add hooks which architectures can use to add arbitrary data to custom sections. Also add a section name string table in order to identify section contents Signed-off-by: Janosch Frank Reviewed-by: Marc-André Lureau Message-Id: <20221017113210.41674-1-fran...@linux.ibm.com>

[PULL v3 10/11] s390x: pv: Add dump support

2022-10-26 Thread marcandre . lureau
From: Janosch Frank Sometimes dumping a guest from the outside is the only way to get the data that is needed. This can be the case if a dumping mechanism like KDUMP hasn't been configured or data needs to be fetched at a specific point. Dumping a protected guest from the outside without help fro

[PULL v3 08/11] include/elf.h: add s390x note types

2022-10-26 Thread marcandre . lureau
From: Janosch Frank Adding two s390x note types Signed-off-by: Janosch Frank Reviewed-by: Thomas Huth Message-Id: <20221017083822.43118-9-fran...@linux.ibm.com> --- include/elf.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/elf.h b/include/elf.h index 3d6b9062c0..8bf1e72720 1

[PULL v3 09/11] s390x: Add KVM PV dump interface

2022-10-26 Thread marcandre . lureau
From: Janosch Frank Let's add a few bits of code which hide the new KVM PV dump API from us via new functions. Signed-off-by: Janosch Frank Reviewed-by: Janis Schoetterl-Glausch Reviewed-by: Steffen Eiden [ Marc-André: fix up for compilation issue ] Signed-off-by: Marc-André Lureau Message-I

[PULL v3 03/11] dump: Reorder struct DumpState

2022-10-26 Thread marcandre . lureau
From: Janosch Frank Let's move ELF related members into one block and guest memory related ones into another to improve readability. Signed-off-by: Janosch Frank Reviewed-by: Richard Henderson Reviewed-by: Marc-André Lureau Message-Id: <20221017083822.43118-4-fran...@linux.ibm.com> --- inclu

Re: [PATCH v10 7/9] s390x/cpu topology: add max_threads machine class attribute

2022-10-26 Thread Pierre Morel
On 10/18/22 19:36, Cédric Le Goater wrote: On 10/12/22 18:21, Pierre Morel wrote: The S390 CPU topology accepts the smp.threads argument while in reality it does not effectively allow multthreading. Let's keep this behavior for machines older than 7.3 and refuse to use threads in newer machi

Re: [PATCH] aspeed: Add Supermicro X11 SPI machine type

2022-10-26 Thread Philippe Mathieu-Daudé
On 25/10/22 18:51, Guenter Roeck wrote: supermicrox11-bmc is configured with ast2400-a1 SoC. This does not match the Supermicro documentation for X11 BMCs, and it does not match the devicetree file in the Linux kernel. As it turns out, some Supermicro X11 motherboards use AST2400 SoCs, while oth

Re: Issue with VDUSE (QSD vduse-blk export) and vhost-vdpa

2022-10-26 Thread Yongji Xie
Hi Stefano, On Wed, Oct 26, 2022 at 5:12 PM Stefano Garzarella wrote: > > Hi Xie, > I was testing libblkio [1] with QSD vduse-blk export and had some > issues. > > In a nutshell, QSD prints me the following messages when using > vhost-vdpa to access the device: > > Failed to get vq[0] iova mapp

Re: [PATCH v2 19/43] hw/isa/piix3: Allow board to provide PCI interrupt routes

2022-10-26 Thread Bernhard Beschow
Hi Phil, Am 25. Oktober 2022 23:34:15 UTC schrieb "Philippe Mathieu-Daudé" : >On 22/10/22 17:04, Bernhard Beschow wrote: >> PIIX3 initializes the PIRQx route control registers to the default >> values as described in the 82371AB PCI-TO-ISA/IDE XCELERATOR (PIIX4) >> April 1997 manual. PIIX4, howev

Re: [PATCH 0/3] target: Rename headers using .def extension to .h.inc

2022-10-26 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > We use the .h.inc extension to include C headers. To be consistent > with the rest of the codebase, rename the C headers using the .def > extension. > > IDE/tools using our .editorconfig / .gitattributes will leverage > this consistency. Reviewed-by: Alex Benné

[PATCH 2/3] virtio_net: Handle _F_STATUS emulation in virtio_net_get_config

2022-10-26 Thread Eugenio Pérez
At this moment this code path is not reached, but vdpa devices can offer VIRTIO_NET_F_STATUS unconditionally. While the guest must assume that link is always up by the standard, qemu will set the status bit to 1 always in this case. This makes little use by itself, but VIRTIO_NET_F_STATUS is neede

[PATCH 3/3] vdpa: Expose VIRTIO_NET_F_STATUS unconditionally

2022-10-26 Thread Eugenio Pérez
Now that qemu can handle and emulate it if the vdpa backend does not support it we can offer it always. Signed-off-by: Eugenio Pérez --- include/net/vhost-vdpa.h | 1 + hw/net/vhost_net.c | 16 ++-- net/vhost-vdpa.c | 3 +++ 3 files changed, 18 insertions(+), 2 deleti

[PATCH 1/3] virtio_net: Modify virtio_net_get_config to early return

2022-10-26 Thread Eugenio Pérez
Next patches introduce more code on vhost-vdpa branch, with already have too much indentation. Signed-off-by: Eugenio Pérez --- hw/net/virtio-net.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index e

[PATCH 0/3] Emulate status feature in vhost-vdpa net

2022-10-26 Thread Eugenio Pérez
The net config space is already copied from the device so it can me modified by qemu. In particular, this is already done to fix cases where the NIC does not expose the right fields. It's trivial to emulate _F_STATE with qemu if not supported by the device, sice a valid approach is to always show

Re: [PATCH 1/3] target/m68k: Rename qregs.def -> qregs.h.inc

2022-10-26 Thread Laurent Vivier
Le 26/10/2022 à 01:50, Philippe Mathieu-Daudé a écrit : We use the .h.inc extension to include C headers. To be consistent with the rest of the codebase, rename the C headers using the .def extension. IDE/tools using our .editorconfig / .gitattributes will leverage this consistency. Signed-off-

Re: Issue with VDUSE (QSD vduse-blk export) and vhost-vdpa

2022-10-26 Thread Stefano Garzarella
On Wed, Oct 26, 2022 at 05:39:23PM +0800, Yongji Xie wrote: Hi Stefano, On Wed, Oct 26, 2022 at 5:12 PM Stefano Garzarella wrote: Hi Xie, I was testing libblkio [1] with QSD vduse-blk export and had some issues. In a nutshell, QSD prints me the following messages when using vhost-vdpa to acc

Re: [PATCH v2 0/3] Performance optimizations for PPC64

2022-10-26 Thread Daniel Henrique Barboza
Patches 2 and 3 queued in ppc-next (Richard is queueing patch 1 via tcg-next). Thanks, Daniel On 10/25/22 17:24, Leandro Lupori wrote: Changes from v1: - Turn macro into an inline function - Rename functions Leandro Lupori (3): accel/tcg: Add a quicker check for breakpoints target/ppc:

Re: [PATCH v6 5/7] hw/arm/virt: Improve high memory region address assignment

2022-10-26 Thread Cornelia Huck
On Wed, Oct 26 2022, Gavin Shan wrote: > Hi Eric, > > On 10/26/22 12:29 AM, Eric Auger wrote: >> On 10/24/22 05:54, Gavin Shan wrote: >>> There are three high memory regions, which are VIRT_HIGH_REDIST2, >>> VIRT_HIGH_PCIE_ECAM and VIRT_HIGH_PCIE_MMIO. Their base addresses >>> are floating on hig

Re: [PATCH 0/4] Allow to pass pre-created VFIO container/group to QEMU

2022-10-26 Thread Andrey Ryabinin
On 10/17/22 14:05, Daniel P. Berrangé wrote: > On Mon, Oct 17, 2022 at 01:54:03PM +0300, Andrey Ryabinin wrote: >> These patches add possibility to pass VFIO device to QEMU using file >> descriptors of VFIO container/group, instead of creating those by QEMU. >> This allows to take away permissions

Re: [PATCH v6 7/7] hw/arm/virt: Add properties to disable high memory regions

2022-10-26 Thread Cornelia Huck
On Wed, Oct 26 2022, Gavin Shan wrote: > Hi Connie, > > On 10/25/22 6:54 PM, Cornelia Huck wrote: >> On Mon, Oct 24 2022, Gavin Shan wrote: >> >>> These 3 high memory regions are usually enabled by default, but >> >> s/These 3/The/ ? >> > > Ok. > >>> they may be not used. For example, VIRT_HI

[RESEND PATCH v2] target/i386: Switch back XFRM value

2022-10-26 Thread Yang Zhong
The previous patch wrongly replaced FEAT_XSAVE_XCR0_{LO|HI} with FEAT_XSAVE_XSS_{LO|HI} in CPUID(EAX=12,ECX=1):{ECX,EDX}, which made SGX enclave only supported SSE and x87 feature(xfrm=0x3). Fixes: 301e90675c3f ("target/i386: Enable support for XSAVES based features") Signed-off-by: Yang Zhong -

Re: [PATCH 0/4] Allow to pass pre-created VFIO container/group to QEMU

2022-10-26 Thread Andrey Ryabinin
On 10/17/22 18:21, Alex Williamson wrote: > On Mon, 17 Oct 2022 13:54:03 +0300 > Andrey Ryabinin wrote: > >> These patches add possibility to pass VFIO device to QEMU using file >> descriptors of VFIO container/group, instead of creating those by QEMU. >> This allows to take away permissions t

Re: [PATCH v2] seccomp: Get actual errno value from failed seccomp functions

2022-10-26 Thread Daniel P . Berrangé
On Wed, Oct 26, 2022 at 09:30:24AM +0200, Michal Privoznik wrote: > Upon failure, a libseccomp API returns actual errno value very > rarely. Fortunately, after its commit 34bf78ab (contained in > 2.5.0 release), the SCMP_FLTATR_API_SYSRAWRC attribute can be set > which makes subsequent APIs return

Re: [PATCH 21/24] accel/tcg: Move page_{get, set}_flags to user-exec.c

2022-10-26 Thread Alex Bennée
Richard Henderson writes: > This page tracking implementation is specific to user-only, > since the system softmmu version is in cputlb.c. Move it > out of translate-all.c to user-exec.c. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH 1/3] qemu-img: Add checksum command

2022-10-26 Thread Hanna Reitz
On 01.09.22 16:32, Nir Soffer wrote: The checksum command compute a checksum for disk image content using the blkhash library[1]. The blkhash library is not packaged yet, but it is available via copr[2]. Example run: $ ./qemu-img checksum -p fedora-35.qcow2 6e5c00c995056319d52395f8d91

Re: [PATCH v5 0/7] qga: Add FreeBSD support

2022-10-26 Thread Alexander Ivanov
Could you please clarify the status of the patchset? Thank you. On 17.10.2022 09:28, Alexander Ivanov wrote: Add freeze/thaw, shutdown/halt/reboot, password setting and guest-network-get-interfaces command support for FreeBSD. v5: 2: Left ga_wait_child() static in commands-posix.c. v4: 6,7: R

Re: [PATCH 2/3] iotests: Test qemu-img checksum

2022-10-26 Thread Hanna Reitz
On 01.09.22 16:32, Nir Soffer wrote: Add simple tests creating an image with all kinds of extents, different formats, different backing chain, different protocol, and different image options. Since all images have the same guest visible content they must have the same checksum. To help debugging

[PATCH 3/4] hw/i386/acpi-build: Resolve PIIX ISA bridge rather than ACPI controller

2022-10-26 Thread Bernhard Beschow
Resolving the PIIX ISA bridge rather than the PIIX ACPI controller mirrors the ICH9 code one line below. Signed-off-by: Bernhard Beschow --- hw/i386/acpi-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index f3131fee60..f0a2

[PATCH 0/4] Cleanup AML generation for north and south bridges

2022-10-26 Thread Bernhard Beschow
While refactoring of PCI AML generation seems to be still ongoing, this series attempts to be an intermediate, short-term step to improve comprehensibility of the code. It also simplifies experimentation with different south bridges (PIIX4 and VT82xx) in the pc machine. Testing done: * `mache chec

[PATCH 1/4] hw/i386/acpi-build: Remove unused struct

2022-10-26 Thread Bernhard Beschow
Ammends commit b23046abe78f48498a423b802d6d86ba0172d57f 'pc: acpi-build: simplify PCI bus tree generation'. Signed-off-by: Bernhard Beschow --- hw/i386/acpi-build.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 4f54b61904..b4d9a05760

[PATCH 4/4] hw/i386/acpi-build: Generate AML for north and south bridges separately

2022-10-26 Thread Bernhard Beschow
The code currently assumes Q35 iff ICH9 and i440fx iff PIIX. This is slightly confusing when trying to understand the code. Split north and south bridge code to communicate which piece of code assumes which type of bridge. Signed-off-by: Bernhard Beschow --- hw/i386/acpi-build.c | 22 +++

Re: [PATCH 1/3] virtio_net: Modify virtio_net_get_config to early return

2022-10-26 Thread Philippe Mathieu-Daudé
On 26/10/22 11:53, Eugenio Pérez wrote: Next patches introduce more code on vhost-vdpa branch, with already have too much indentation. Signed-off-by: Eugenio Pérez --- hw/net/virtio-net.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) Reviewed-by: Phil

[PATCH 2/4] hw/i386/acpi-build: Resolve redundant attribute

2022-10-26 Thread Bernhard Beschow
The is_piix4 attribute is set once in one location and read once in another. Doing both in one location allows for removing the attribute altogether. Signed-off-by: Bernhard Beschow --- hw/i386/acpi-build.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a

Re: [PATCH 22/24] accel/tcg: Use interval tree for user-only page tracking

2022-10-26 Thread Alex Bennée
Richard Henderson writes: > Finish weaning user-only away from PageDesc. > > Using an interval tree to track page permissions means that > we can represent very large regions efficiently. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/290 > Resolves: https://gitlab.com/qemu-project

Re: [PATCH 24/24] accel/tcg: Move remainder of page locking to tb-maint.c

2022-10-26 Thread Alex Bennée
Richard Henderson writes: > The only thing that still touches PageDesc in translate-all.c > are some locking routines related to tb-maint.c which have not > yet been moved. Do so now. > > Move some code up in tb-maint.c as well, to untangle the maze > of ifdefs, and allow a sensible final orde

Re: [PATCH 3/3] qemu-img: Speed up checksum

2022-10-26 Thread Hanna Reitz
On 01.09.22 16:32, Nir Soffer wrote: Add coroutine based loop inspired by `qemu-img convert` design. Changes compared to `qemu-img convert`: - State for the entire image is kept in ImgChecksumState - State for single worker coroutine is kept in ImgChecksumworker. - "Writes" are always in-orde

Re: [PULL 0/8] Linux user for 7.2 patches

2022-10-26 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/11] Trivial branch for 7.2 patches

2022-10-26 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH v4 5/5] test/acpi/bios-tables-test: SSDT: update golden master binaries

2022-10-26 Thread Michael S. Tsirkin
On Thu, Sep 22, 2022 at 08:21:55PM +0800, Robert Hoo wrote: > And empty bios-tables-test-allowed-diff.h. > > Diff of ASL form, from qtest testlog.txt: > > --- /tmp/asl-RFWZS1.dsl 2022-09-22 18:25:06.191519589 +0800 > +++ /tmp/asl-B1ZZS1.dsl 2022-09-22 18:25:06.187519182 +0800 Adding

Re: [PULL 00/30] target-arm queue

2022-10-26 Thread Stefan Hajnoczi
On Tue, 25 Oct 2022 at 12:51, Peter Maydell wrote: > target-arm queue: > * Implement FEAT_E0PD > * Implement FEAT_HAFDBS This commit breaks CI: i686-w64-mingw32-gcc -m32 -Ilibqemu-aarch64-softmmu.fa.p -I. -I.. -Itarget/arm -I../target/arm -I../dtc/libfdt -Iqapi -Itrace -Iui -Iui/shader -I/usr/

Re: [PULL 00/30] target-arm queue

2022-10-26 Thread Stefan Hajnoczi
On Tue, 25 Oct 2022 at 12:51, Peter Maydell wrote: > target-arm queue: > * Implement FEAT_E0PD > * Implement FEAT_HAFDBS A second CI failure: arm-linux-gnueabi-gcc -Ilibqemu-aarch64-softmmu.fa.p -I. -I.. -Itarget/arm -I../target/arm -Iqapi -Itrace -Iui -Iui/shader -I/usr/include/pixman-1 -I/us

Re: [PATCH 0/4] Only generate cluster node in PPTT when specified

2022-10-26 Thread Michael S. Tsirkin
On Thu, Sep 22, 2022 at 09:11:39PM +0800, Yicong Yang wrote: > From: Yicong Yang > > This series mainly change the policy for building a cluster topology node > in PPTT. Previously we'll always build a cluster node in PPTT without > asking the user, after this set the cluster node will be built o

Re: [PATCH 0/2] Fix the virito features negotiation flaw

2022-10-26 Thread Michael S. Tsirkin
I guess I'll apply this. Can you fix a typo in subject though? Would also be nice if we had a test for this behaviour. On Wed, Oct 05, 2022 at 04:17:30PM +0800, Hyman Huang wrote: > Ping, >Hi, Michael and Jason, how does this patchset feel think? :) >Sorry if i made noise. > > Yong > >

Re: [PATCH v2 0/2] linux-user: handle /proc/self/exe with execve() syscall

2022-10-26 Thread Michael Tokarev
27.09.2022 15:43, Laurent Vivier wrote: Use exec_path to re-execute the binary from /proc/self/exe Fix do_openat() that should not use execfd. v2: - don't use execfd as it can't be closed and is usable by the child Why can't it be closed? I mean, how about O_CLOEXEC? Your initial usage of ex

Re: [PULL 00/30] target-arm queue

2022-10-26 Thread Jason A. Donenfeld
On Wed, Oct 26, 2022 at 10:49:18AM -0400, Stefan Hajnoczi wrote: > On Tue, 25 Oct 2022 at 12:51, Peter Maydell wrote: > > target-arm queue: > > * Implement FEAT_E0PD > > * Implement FEAT_HAFDBS > > This commit breaks CI: Ah, so when this is respun, there'll be an opportunity for Peter to pull

Re: [PATCH 1/4] hw/i386/acpi-build: Remove unused struct

2022-10-26 Thread Philippe Mathieu-Daudé
On 26/10/22 15:31, Bernhard Beschow wrote: Ammends commit b23046abe78f48498a423b802d6d86ba0172d57f 'pc: acpi-build: simplify PCI bus tree generation'. Signed-off-by: Bernhard Beschow --- hw/i386/acpi-build.c | 7 --- 1 file changed, 7 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

[PATCH v3 2/2] qtests/arm: add some mte tests

2022-10-26 Thread Cornelia Huck
Signed-off-by: Cornelia Huck --- tests/qtest/arm-cpu-features.c | 76 ++ 1 file changed, 76 insertions(+) diff --git a/tests/qtest/arm-cpu-features.c b/tests/qtest/arm-cpu-features.c index 5a145273860c..e264d2178a8b 100644 --- a/tests/qtest/arm-cpu-features.c +++

[PATCH v3 0/2] arm: enable MTE for QEMU + kvm

2022-10-26 Thread Cornelia Huck
After wayyy too long (last version was sent in *July*), a respin of my kvm/mte series. Still no migration support. I've been hacking around on a device for transferring tags while stopped, but don't really have anything to show, probably because I get distra- ...I guess you get the point :( Anyw

[PATCH v3 1/2] arm/kvm: add support for MTE

2022-10-26 Thread Cornelia Huck
Introduce a new cpu feature flag to control MTE support. To preserve backwards compatibility for tcg, MTE will continue to be enabled as long as tag memory has been provided. If MTE has been enabled, we need to disable migration, as we do not yet have a way to migrate the tags as well. Therefore,

Re: [PATCH] tests: Create fifo for test-io-channel-command

2022-10-26 Thread Alex Bennée
Daniel P. Berrangé writes: > CC'ing Marc-André as original author of the change > > On Tue, Oct 25, 2022 at 01:57:23PM +0100, Alex Bennée wrote: >> >> Juan Quintela writes: >> >> > Previous commit removed the creation of the fifo. Without it, I get >> > random failure during tests with high

Re: [PATCH v3] target/i386: Set maximum APIC ID to KVM prior to vCPU creation

2022-10-26 Thread Paolo Bonzini
Queued, thanks. Paolo

Re: [PATCH 0/2] Fix the virito features negotiation flaw

2022-10-26 Thread Hyman Huang
在 2022/10/26 23:00, Michael S. Tsirkin 写道: I guess I'll apply this. Can you fix a typo in subject though? Of course yes. :) Would also be nice if we had a test for this behaviour. Ok, i'll add a test patch next version. On Wed, Oct 05, 2022 at 04:17:30PM +0800, Hyman Huang wrote: Ping,

[PATCH v3 0/2] xen/pt: fix FTBFS and reserve PCI slot 2 for the Intel IGD

2022-10-26 Thread Chuck Zmudzinski
This is a series of two patches: The first fixes FTBFS when --enable-xen and --disable-xen-pci-passthrough configure options are set with when building for the linux target os. The second fixes a regression that was introduced many years ago with the upgrade from the Qemu traditional device model

Re: [PATCH v4 5/7] hw/ppc/e500: Implement pflash handling

2022-10-26 Thread Daniel Henrique Barboza
On 10/18/22 18:01, Bernhard Beschow wrote: Allows e500 boards to have their root file system reside on flash using only builtin devices located in the eLBC memory region. Note that the flash memory area is only created when a -pflash argument is given, and that the size is determined by the g

[PATCH v3 2/2] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2022-10-26 Thread Chuck Zmudzinski
Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, as noted in docs/igd-assign.txt in the Qemu source code. Currently, when the xl toolstack is used to configure a Xen HVM guest with Intel IGD passthrough to the guest with the Qemu upstream device model, a Qemu emulated PCI devi

[PATCH v3 1/2] xen/pt: fix syntax error that causes FTBFS in some configurations

2022-10-26 Thread Chuck Zmudzinski
When Qemu is built with --enable-xen and --disable-xen-pci-passthrough and the target os is linux, the build fails with: meson.build:3477:2: ERROR: File xen_pt_stub.c does not exist. Fixes: 582ea95f5f93 ("meson: convert hw/xen") Signed-off-by: Chuck Zmudzinski --- v2: Remove From: tag at top o

Re: [PATCH v4 7/7] hw/ppc/e500: Add Freescale eSDHC to e500plat

2022-10-26 Thread Daniel Henrique Barboza
On 10/18/22 18:01, Bernhard Beschow wrote: Adds missing functionality to e500plat machine which increases the chance of given "real" firmware images to access SD cards. Signed-off-by: Bernhard Beschow --- Reviewed-by: Daniel Henrique Barboza docs/system/ppc/ppce500.rst | 12 ++

Re: [PATCH v4 0/7] ppc/e500: Add support for two types of flash, cleanup

2022-10-26 Thread Daniel Henrique Barboza
Hi, Since this is being sent to qemu-ppc and has to do with e500 I decided to take a look. I acked the e500 related patches, 5 and 7. Patch 6 LGTM as well but I'd rather not ack it it's SD specific code. I'll send a PowerPC pull request this week. I can grab this series via the ppc tree if someo

Re: [PATCH 0/4] Allow to pass pre-created VFIO container/group to QEMU

2022-10-26 Thread Alex Williamson
On Wed, 26 Oct 2022 15:07:32 +0300 Andrey Ryabinin wrote: > On 10/17/22 18:21, Alex Williamson wrote: > > On Mon, 17 Oct 2022 13:54:03 +0300 > > Andrey Ryabinin wrote: > > > >> These patches add possibility to pass VFIO device to QEMU using file > >> descriptors of VFIO container/group, inste

Re: [PATCH] qga: add channel path to error messages

2022-10-26 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Fri, Oct 21, 2022 at 1:04 AM Bjørn Forsman wrote: > It's useful to know which device was used if/when it fails. > > channel-win32.c had this since 2015, with > c69403fcd4a0cb89f838a212ab71e4a1a3464c95 ("qemu-ga: debug printouts to > help troubleshoot installat

Re: [PATCH v9 1/8] mm: Introduce memfd_restricted system call to create restricted user memory

2022-10-26 Thread Isaku Yamahata
On Tue, Oct 25, 2022 at 11:13:37PM +0800, Chao Peng wrote: > +int restrictedmem_get_page(struct file *file, pgoff_t offset, > +struct page **pagep, int *order) > +{ > + struct restrictedmem_data *data = file->f_mapping->private_data; > + struct file *memfd = data->

[PULL 6/8] qga: Move HW address getting to a separate function

2022-10-26 Thread Konstantin Kostiuk
From: Alexander Ivanov In the next patch FreeBSD support for guest-network-get-interfaces will be added. Previously move Linux-specific code of HW address getting to a separate functions and add a dumb function to commands-bsd.c. Reviewed-by: Konstantin Kostiuk Reviewed-by: Marc-André Lureau S

[PULL 2/8] qga: Move Linux-specific FS freeze/thaw code to a separate file

2022-10-26 Thread Konstantin Kostiuk
From: Alexander Ivanov In the next patches we are going to add FreeBSD support for QEMU Guest Agent. In the result, code in commands-posix.c will be too cumbersome. Move Linux-specific FS freeze/thaw code to a separate file commands-linux.c keeping common POSIX code in commands-posix.c. Reviewe

[PULL 5/8] qga: Add support for user password setting in FreeBSD

2022-10-26 Thread Konstantin Kostiuk
From: Alexander Ivanov Move qmp_guest_set_user_password() from __linux__ condition to (__linux__ || __FreeBSD__) condition. Add command and arguments for password setting in FreeBSD. Reviewed-by: Konstantin Kostiuk Reviewed-by: Marc-André Lureau Signed-off-by: Alexander Ivanov Signed-off-by:

[PULL 1/8] qga: Add initial FreeBSD support

2022-10-26 Thread Konstantin Kostiuk
From: Alexander Ivanov - Fix device path. - Fix virtio-serial channel initialization. - Make the code buildable in FreeBSD. Reviewed-by: Konstantin Kostiuk Acked-by: Marc-André Lureau Signed-off-by: Alexander Ivanov Signed-off-by: Konstantin Kostiuk --- meson.build | 2 +- qga/cha

[PULL 8/8] qga: add channel path to error messages

2022-10-26 Thread Konstantin Kostiuk
From: Bjørn Forsman It's useful to know which device was used if/when it fails. channel-win32.c had this since 2015, with c69403fcd4a0cb89f838a212ab71e4a1a3464c95 ("qemu-ga: debug printouts to help troubleshoot installation"), this brings channel-posix.c up to speed. Signed-off-by: Bjørn Forsma

[PULL 7/8] qga: Add HW address getting for FreeBSD

2022-10-26 Thread Konstantin Kostiuk
From: Alexander Ivanov Replace a dumb function in commands-bsd.c by the code of HW address getting. Reviewed-by: Konstantin Kostiuk Reviewed-by: Marc-André Lureau Signed-off-by: Alexander Ivanov Signed-off-by: Konstantin Kostiuk --- qga/commands-bsd.c | 15 +++ 1 file changed, 1

Re: [PATCH v5 0/7] qga: Add FreeBSD support

2022-10-26 Thread Konstantin Kostiuk
Thanks for the reminder. PR was sent https://patchew.org/QEMU/20221026175518.2636846-1-kkost...@redhat.com/ Best Regards, Konstantin Kostiuk. On Wed, Oct 26, 2022 at 4:25 PM Alexander Ivanov < alexander.iva...@virtuozzo.com> wrote: > Could you please clarify the status of the patchset? > > Than

Re: [PATCH] qga: add channel path to error messages

2022-10-26 Thread Konstantin Kostiuk
PR was sent https://patchew.org/QEMU/20221026175518.2636846-1-kkost...@redhat.com/ On Wed, Oct 26, 2022 at 8:31 PM Konstantin Kostiuk wrote: > Reviewed-by: Konstantin Kostiuk > > On Fri, Oct 21, 2022 at 1:04 AM Bjørn Forsman > wrote: > >> It's useful to know which device was used if/when it fa

[PULL 3/8] qga: Add UFS freeze/thaw support for FreeBSD

2022-10-26 Thread Konstantin Kostiuk
From: Alexander Ivanov UFS supports FS freezing through ioctl UFSSUSPEND on /dev/ufssuspend. Frozen FS can be thawed by closing /dev/ufssuspend file descriptior. Use getmntinfo to get a list of mounted FS. Reviewed-by: Konstantin Kostiuk Reviewed-by: Marc-André Lureau Signed-off-by: Alexander

[PULL 4/8] qga: Add shutdown/halt/reboot support for FreeBSD

2022-10-26 Thread Konstantin Kostiuk
From: Alexander Ivanov Add appropriate shutdown command arguments to qmp_guest_shutdown() for FreeBSD. Reviewed-by: Konstantin Kostiuk Reviewed-by: Marc-André Lureau Signed-off-by: Alexander Ivanov Signed-off-by: Konstantin Kostiuk --- qga/commands-posix.c | 7 +++ 1 file changed, 7 ins

[PULL 0/8] QEMU Guest Agent patches

2022-10-26 Thread Konstantin Kostiuk
The following changes since commit 79fc2fb685f35a5e71e23629760ef4025d6aba31: Merge tag 'trivial-branch-for-7.2-pull-request' of https://gitlab.com/laurent_vivier/qemu into staging (2022-10-25 11:37:17 -0400) are available in the Git repository at: g...@github.com:kostyanf14/qemu.git tags/qg

[PULL v2 02/28] qapi: Tidy up whitespace in generated code

2022-10-26 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrangé Message-Id: <20221018062849.3420573-3-arm...@redhat.com> --- docs/devel/qapi-code-gen.rst | 1 - scripts/qapi/commands.py | 7 +++ scripts/qapi/events.py | 1 - 3 files changed, 3 insertions(+), 6 deletions(-) diff -

[PULL v2 19/28] qapi replay: Elide redundant has_FOO in generated C

2022-10-26 Thread Markus Armbruster
The has_FOO for pointer-valued FOO are redundant, except for arrays. They are also a nuisance to work with. Recent commit "qapi: Start to elide redundant has_FOO in generated C" provided the means to elide them step by step. This is the step for qapi/replay.json. Said commit explains the transfo

[PULL v2 04/28] qapi: Start to elide redundant has_FOO in generated C

2022-10-26 Thread Markus Armbruster
In QAPI, absent optional members are distinct from any present value. We thus represent an optional schema member FOO as two C members: a FOO with the member's type, and a bool has_FOO. Likewise for function arguments. However, has_FOO is actually redundant for a pointer-valued FOO, which can be

[PULL v2 03/28] docs/devel/qapi-code-gen: Extend example for next commit's change

2022-10-26 Thread Markus Armbruster
The next commit will change the code generated for some optional members. The example schema contains an optional member affected by the change. Add one that is not affected. Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrangé Message-Id: <20221018062849.3420573-4-arm...@redhat.co

[PULL v2 16/28] qapi net: Elide redundant has_FOO in generated C

2022-10-26 Thread Markus Armbruster
The has_FOO for pointer-valued FOO are redundant, except for arrays. They are also a nuisance to work with. Recent commit "qapi: Start to elide redundant has_FOO in generated C" provided the means to elide them step by step. This is the step for qapi/net.json. Said commit explains the transforma

[PULL v2 20/28] qapi rocker: Elide redundant has_FOO in generated C

2022-10-26 Thread Markus Armbruster
The has_FOO for pointer-valued FOO are redundant, except for arrays. They are also a nuisance to work with. Recent commit "qapi: Start to elide redundant has_FOO in generated C" provided the means to elide them step by step. This is the step for qapi/rocker.json. Said commit explains the transfo

[PULL v2 17/28] qapi pci: Elide redundant has_FOO in generated C

2022-10-26 Thread Markus Armbruster
The has_FOO for pointer-valued FOO are redundant, except for arrays. They are also a nuisance to work with. Recent commit "qapi: Start to elide redundant has_FOO in generated C" provided the means to elide them step by step. This is the step for qapi/pci.json. Said commit explains the transforma

[PULL v2 10/28] qapi crypto: Elide redundant has_FOO in generated C

2022-10-26 Thread Markus Armbruster
The has_FOO for pointer-valued FOO are redundant, except for arrays. They are also a nuisance to work with. Recent commit "qapi: Start to elide redundant has_FOO in generated C" provided the means to elide them step by step. This is the step for qapi/crypto.json. Said commit explains the transfo

[PULL v2 25/28] qapi ui: Elide redundant has_FOO in generated C

2022-10-26 Thread Markus Armbruster
The has_FOO for pointer-valued FOO are redundant, except for arrays. They are also a nuisance to work with. Recent commit "qapi: Start to elide redundant has_FOO in generated C" provided the means to elide them step by step. This is the step for qapi/ui.json. Said commit explains the transformat

[PULL v2 24/28] qapi transaction: Elide redundant has_FOO in generated C

2022-10-26 Thread Markus Armbruster
The has_FOO for pointer-valued FOO are redundant, except for arrays. They are also a nuisance to work with. Recent commit "qapi: Start to elide redundant has_FOO in generated C" provided the means to elide them step by step. This is the step for qapi/transaction.json. Said commit explains the tr

  1   2   3   >