Re: has anybody looked at the long-standing intermittent raspi2 avocado test failure?

2022-10-20 Thread Thomas Huth
On 19/10/2022 22.38, John Snow wrote: On Tue, Oct 18, 2022 at 6:23 AM Peter Maydell wrote: If you run this single avocado test: while ./build/x86/tests/venv/bin/avocado run build/x86/tests/avocado/boot_linux_console.py:BootLinuxConsole.test_arm_raspi2_initrd ; do true; done then on my machin

Re: [PATCH] dump/win_dump: limit number of processed PRCBs

2022-10-20 Thread Marc-André Lureau
Hi On Thu, Oct 20, 2022 at 3:59 AM Viktor Prutyanov < viktor.prutya...@redhat.com> wrote: > When number of CPUs utilized by guest Windows is less than defined in > QEMU (i.e., desktop versions of Windows severely limits number of CPU > sockets), patch_and_save_context routine accesses non-existen

[PATCH] vdpa: Delete duplicated vdpa_feature_bits entry

2022-10-20 Thread Eugenio Pérez
This entry was duplicated on referenced commit. Removing it. Fixes: 402378407dbd ("vhost-vdpa: multiqueue support") Signed-off-by: Eugenio Pérez Acked-by: Jason Wang --- net/vhost-vdpa.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index 4bc3fd01a8..eeb

[PATCH] vdpa: Remove shadow CVQ command check

2022-10-20 Thread Eugenio Pérez
The guest will see undefined behavior if it issue not negotiate commands, bit it is expected somehow. Simplify code deleting this check. Signed-off-by: Eugenio Pérez Acked-by: Jason Wang --- net/vhost-vdpa.c | 48 1 file changed, 48 deletions(-)

Re: [RFC PATCH v2 6/8] vdpa: handle VIRTIO_NET_CTRL_ANNOUNCE in vhost_vdpa_net_handle_ctrl_avail

2022-10-20 Thread Eugenio Perez Martin
On Thu, Oct 20, 2022 at 6:35 AM Jason Wang wrote: > > On Wed, Oct 19, 2022 at 8:52 PM Eugenio Pérez wrote: > > > > Since this capability is emulated by qemu shadowed CVQ cannot forward it > > to the device. > > I wonder what happens for a device that has GUEST_ANNOUNCE support on its own? > If S

Re: [RFC PATCH v2 0/8] Guest announce feature emulation using Shadow VirtQueue

2022-10-20 Thread Eugenio Perez Martin
On Thu, Oct 20, 2022 at 6:24 AM Jason Wang wrote: > > On Wed, Oct 19, 2022 at 8:52 PM Eugenio Pérez wrote: > > > > A gratuitous ARP is recommended after a live migration to reduce the amount > > of > > time needed by the network links to be aware of the new location. > > A question: I think we n

Re: [PATCH v2 1/2] util/log: Derive thread id from getpid() on hosts w/o gettid() syscall

2022-10-20 Thread Greg Kurz
On Wed, 19 Oct 2022 16:57:54 +0100 Daniel P. Berrangé wrote: > On Wed, Oct 19, 2022 at 05:16:50PM +0200, Greg Kurz wrote: > > A subsequent patch needs to be able to differentiate the main QEMU > > thread from other threads. An obvious way to do so is to compare > > log_thread_id() and getpid(), b

[PATCH v7 0/2] Fix LoongArch extioi coreisr accessing

2022-10-20 Thread Xiaojuan Yang
When cpu read or write extioi COREISR reg, it should access the reg belonged to itself, so the cpu index of 's->coreisr' is current cpu number. Using MemTxAttrs' requester_id to get the cpu index. Changes for v7: Split v6 patch to two patches: 1. Converting the MemoryRegionOps read/write handlers

[PATCH v12 01/17] net: introduce convert_host_port()

2022-10-20 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Stefano Brivio Reviewed-by: David Gibson Acked-by: Michael S. Tsirkin --- include/qemu/sockets.h | 2 ++ net/net.c | 62 ++ 2 files changed, 34 insertions(+), 30 deletions(-) diff --git a/include/

[PATCH v12 08/17] net: stream: Don't ignore EINVAL on netdev socket connection

2022-10-20 Thread Laurent Vivier
From: Stefano Brivio Other errors are treated as failure by net_stream_client_init(), but if connect() returns EINVAL, we'll fail silently. Remove the related exception. Signed-off-by: Stefano Brivio [lvivier: applied to net/stream.c] Signed-off-by: Laurent Vivier Reviewed-by: Daniel P. Berran

[PATCH] .gitignore: add multiple items to .gitignore

2022-10-20 Thread Wang, Lei
Add /.vscode/, .clang-format and .gdb_history to .gitignore because: - For VSCode, workspace settings as well as debugging and task configurations are stored at the root in a .vscode folder; - For ClangFormat, the .clang-format file is searched relative to the current working directory when re

[PATCH v12 15/17] net: stream: move to QIO to enable additional parameters

2022-10-20 Thread Laurent Vivier
Use QIOChannel, QIOChannelSocket and QIONetListener. This allows net/stream to use all the available parameters provided by SocketAddress. Signed-off-by: Laurent Vivier Acked-by: Michael S. Tsirkin --- meson | 2 +- net/stream.c| 493 +

[PATCH v12 07/17] net: socket: Don't ignore EINVAL on netdev socket connection

2022-10-20 Thread Laurent Vivier
From: Stefano Brivio Other errors are treated as failure by net_socket_connect_init(), but if connect() returns EINVAL, we'll fail silently. Remove the related exception. Signed-off-by: Stefano Brivio Signed-off-by: Laurent Vivier Reviewed-by: David Gibson Acked-by: Michael S. Tsirkin --- n

[PATCH v12 02/17] net: remove the @errp argument of net_client_inits()

2022-10-20 Thread Laurent Vivier
The only caller passes &error_fatal, so use this directly in the function. It's what we do for -blockdev, -device, and -object. Suggested-by: Markus Armbruster Signed-off-by: Laurent Vivier Reviewed-by: Markus Armbruster Reviewed-by: David Gibson Acked-by: Michael S. Tsirkin --- include/net

[PATCH v12 09/17] net: stream: add unix socket

2022-10-20 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Stefano Brivio Acked-by: Michael S. Tsirkin QAPI schema Acked-by: Markus Armbruster --- net/stream.c| 107 +--- qapi/net.json | 2 +- qemu-options.hx | 1 + 3 files changed, 104 insertions(+), 6 de

[PATCH v7 1/2] hw/intc: Convert the memops to with_attrs in LoongArch extioi

2022-10-20 Thread Xiaojuan Yang
Converting the MemoryRegionOps read/write handlers to with_attrs in LoongArch extioi emulation. Signed-off-by: Xiaojuan Yang --- hw/intc/loongarch_extioi.c | 32 +--- hw/intc/trace-events| 3 +-- target/loongarch/iocsr_helper.c | 18 ++---

[PATCH v12 10/17] net: dgram: make dgram_dst generic

2022-10-20 Thread Laurent Vivier
dgram_dst is a sockaddr_in structure. To be able to use it with unix socket, use a pointer to a generic sockaddr structure. Rename it dest_addr, and store socket length in dest_len. Signed-off-by: Laurent Vivier Reviewed-by: Stefano Brivio Acked-by: Michael S. Tsirkin --- net/dgram.c | 82 +++

[PATCH v12 12/17] net: dgram: add unix socket

2022-10-20 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Stefano Brivio Reviewed-by: David Gibson Acked-by: Michael S. Tsirkin QAPI schema Acked-by: Markus Armbruster --- net/dgram.c | 54 - qapi/net.json | 2 +- qemu-options.hx | 1 + 3 files changed

[PATCH v12 17/17] net: stream: add QAPI events to report connection state

2022-10-20 Thread Laurent Vivier
The netdev reports NETDEV_STREAM_CONNECTED event when the backend is connected, and NETDEV_STREAM_DISCONNECTED when it is disconnected. The NETDEV_STREAM_CONNECTED event includes the URI of the destination address. Signed-off-by: Laurent Vivier Acked-by: Michael S. Tsirkin --- net/stream.c |

[PATCH v12 04/17] qapi: net: introduce a way to bypass qemu_opts_parse_noisily()

2022-10-20 Thread Laurent Vivier
As qemu_opts_parse_noisily() flattens the QAPI structures ("type" field of Netdev structure can collides with "type" field of SocketAddress), we introduce a way to bypass qemu_opts_parse_noisily() and use directly visit_type_Netdev() to parse the backend parameters. More details from Markus: qemu

[PATCH v12 16/17] tests/qtest: netdev: test stream and dgram backends

2022-10-20 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Acked-by: Michael S. Tsirkin --- tests/qtest/meson.build | 1 + tests/qtest/netdev-socket.c | 417 2 files changed, 418 insertions(+) create mode 100644 tests/qtest/netdev-socket.c diff --git a/tests/qtest/meson.build b/t

[PATCH v7 2/2] hw/intc: Fix LoongArch extioi coreisr accessing

2022-10-20 Thread Xiaojuan Yang
1. When cpu read or write extioi COREISR reg, it should access the reg belonged to itself, so the cpu index of 's->coreisr' is current cpu number. Using MemTxAttrs' requester_id to get the cpu index. 2. It need not to mask 0x1f when calculate the coreisr array index. Signed-off-by: Xiaojuan Yang

[PATCH v12 05/17] net: introduce qemu_set_info_str() function

2022-10-20 Thread Laurent Vivier
Embed the setting of info_str in a function. Signed-off-by: Laurent Vivier Reviewed-by: David Gibson Acked-by: Michael S. Tsirkin --- hw/net/xen_nic.c | 5 ++--- include/net/net.h | 1 + net/l2tpv3.c | 3 +-- net/net.c | 17 - net/slirp.c | 5 ++--- net/

[PATCH v12 14/17] qemu-sockets: update socket_uri() and socket_parse() to be consistent

2022-10-20 Thread Laurent Vivier
To be consistent with socket_uri(), add 'tcp:' prefix for inet type in socket_parse(), by default socket_parse() use tcp when no prefix is provided (format is host:port). In socket_uri(), use 'vsock:' prefix for vsock type rather than 'tcp:' because it makes a vsock address look like an inet addre

[PATCH v12 11/17] net: dgram: move mcast specific code from net_socket_fd_init_dgram()

2022-10-20 Thread Laurent Vivier
It is less complex to manage special cases directly in net_dgram_mcast_init() and net_dgram_udp_init(). Signed-off-by: Laurent Vivier Reviewed-by: Stefano Brivio Acked-by: Michael S. Tsirkin --- net/dgram.c | 143 1 file changed, 76 insertio

[PATCH v12 13/17] qemu-sockets: move and rename SocketAddress_to_str()

2022-10-20 Thread Laurent Vivier
Rename SocketAddress_to_str() to socket_uri() and move it to util/qemu-sockets.c close to socket_parse(). socket_uri() generates a string from a SocketAddress while socket_parse() generates a SocketAddress from a string. Signed-off-by: Laurent Vivier Reviewed-by: David Gibson Reviewed-by: Dr. D

[PATCH v12 06/17] qapi: net: add stream and dgram netdevs

2022-10-20 Thread Laurent Vivier
Copied from socket netdev file and modified to use SocketAddress to be able to introduce new features like unix socket. "udp" and "mcast" are squashed into dgram netdev, multicast is detected according to the IP address type. "listen" and "connect" modes are managed by stream netdev. An optional p

[PATCH v12 03/17] net: simplify net_client_parse() error management

2022-10-20 Thread Laurent Vivier
All net_client_parse() callers exit in case of error. Move exit(1) to net_client_parse() and remove error checking from the callers. Suggested-by: Markus Armbruster Signed-off-by: Laurent Vivier Reviewed-by: Markus Armbruster Reviewed-by: David Gibson Acked-by: Michael S. Tsirkin --- includ

Re: [PATCH v2 2/2] util/log: Always send errors to logfile when daemonized

2022-10-20 Thread Greg Kurz
On Thu, 20 Oct 2022 12:21:27 +1000 Richard Henderson wrote: > On 10/20/22 01:16, Greg Kurz wrote: > > When QEMU is started with `-daemonize`, all stdio descriptors get > > redirected to `/dev/null`. This basically means that anything > > printed with error_report() and friends is lost. > > > > O

Re: [PATCH v5 6/6] hw/arm/virt: Add 'compact-highmem' property

2022-10-20 Thread Marc Zyngier
On Thu, 20 Oct 2022 00:57:32 +0100, Gavin Shan wrote: > > For Marc's suggestion to add properties so that these high memory > regions can be disabled by users. I can add one patch after this one > to introduce the following 3 properties. Could you please confirm > the property names are good enou

[PATCH v3 2/2] virtio-net: fix TX timer with tx_burst

2022-10-20 Thread Laurent Vivier
When virtio_net_flush_tx() reaches the tx_burst value all the queue is not flushed and nothing restart the timer. Fix that by doing for TX timer as we do for bottom half TX: rearming the timer if we find any packet to send during the virtio_net_flush_tx() call. Fixes: e3f30488e5f8 ("virtio-net: L

Re: [PATCH v7 1/2] hw/intc: Convert the memops to with_attrs in LoongArch extioi

2022-10-20 Thread Philippe Mathieu-Daudé
On 20/10/22 11:04, Xiaojuan Yang wrote: Converting the MemoryRegionOps read/write handlers to with_attrs in LoongArch extioi emulation. Signed-off-by: Xiaojuan Yang --- hw/intc/loongarch_extioi.c | 32 +--- hw/intc/trace-events| 3 +-- target/lo

[PATCH v12 00/17] qapi: net: add unix socket type support to netdev backend

2022-10-20 Thread Laurent Vivier
"-netdev socket" only supports inet sockets. It's not a complex task to add support for unix sockets, but the socket netdev parameters are not defined to manage well unix socket parameters. As discussed in: "socket.c added support for unix domain socket datagram transport" https://lore.kern

[PATCH v3 0/2] virtio-net: re-arm/re-schedule when tx_burst stops virtio_net_flush_tx()

2022-10-20 Thread Laurent Vivier
When virtio_net_flush_tx() reaches the tx_burst value all the queue is not flushed and nothing restart the timer or the bottom half function. For BH, this is only missing in the virtio_net_tx_complete() function. For the timer, the same fix is needed in virtio_net_tx_complete() but it must be also

Re: [PATCH v11 17/17] net: stream: add QAPI events to report connection state

2022-10-20 Thread Markus Armbruster
Sorry for the slow replay, too many distractions... Laurent Vivier writes: > On 10/17/22 15:23, Markus Armbruster wrote: >> Laurent Vivier writes: >> >>> The netdev reports NETDEV_STREAM_CONNECTED event when the backend >>> is connected, and NETDEV_STREAM_EOC when it is disconnected. >>> >>> T

[PATCH v3 1/2] virtio-net: fix bottom-half packet TX on asynchronous completion

2022-10-20 Thread Laurent Vivier
When virtio-net is used with the socket netdev backend, the backend can be busy and not able to collect new packets. In this case, net_socket_receive() returns 0 and registers a poll function to detect when the socket is ready again. In virtio_net_tx_bh(), virtio_net_flush_tx() forwards the 0, th

Re: [PATCH] tests/avocado: raspi2_initrd: Wait for guest shutdown message before stopping

2022-10-20 Thread Thomas Huth
On 20/10/2022 12.20, Peter Maydell wrote: The avocado test tests/avocado/boot_linux_console.py:BootLinuxConsole.test_arm_raspi2_initrd finishes wiith exec_command(self, 'halt') # Wait for VM to shut down gracefully self.vm.wait() In theory this should be fine. In practice it ru

Re: [PATCH v2 2/2] util/log: Always send errors to logfile when daemonized

2022-10-20 Thread Daniel P . Berrangé
On Thu, Oct 20, 2022 at 11:49:37AM +0200, Greg Kurz wrote: > On Thu, 20 Oct 2022 12:21:27 +1000 > Richard Henderson wrote: > > > On 10/20/22 01:16, Greg Kurz wrote: > > > > I don't understand why daemonize changes -d tid at all. > > If there's a bug there, please separate it out. > > > > I don'

Re: [PATCH] .gitignore: add multiple items to .gitignore

2022-10-20 Thread Philippe Mathieu-Daudé
On 20/10/22 19:19, Wang, Lei wrote: Add /.vscode/, .clang-format and .gdb_history to .gitignore because: - For VSCode, workspace settings as well as debugging and task configurations are stored at the root in a .vscode folder; - For ClangFormat, the .clang-format file is searched relative

[PATCH] tests/avocado: raspi2_initrd: Wait for guest shutdown message before stopping

2022-10-20 Thread Peter Maydell
The avocado test tests/avocado/boot_linux_console.py:BootLinuxConsole.test_arm_raspi2_initrd finishes wiith exec_command(self, 'halt') # Wait for VM to shut down gracefully self.vm.wait() In theory this should be fine. In practice it runs into two bugs: * when the test calls self.v

[PATCH 6/7] virtio_net: copy VIRTIO_NET_S_ANNOUNCE if device model has it

2022-10-20 Thread Eugenio Pérez
Status part of the emulated feature. It will follow device model, so we must copy it as long as NIC device model has it set. Signed-off-by: Eugenio Pérez --- hw/net/virtio-net.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 51fe6d5c1a..49674d

[PATCH 2/7] virtio_net: Modify virtio_net_get_config to early return

2022-10-20 Thread Eugenio Pérez
Next patches introduce more code on vhost-vdpa branch, with already have too much indentation. Signed-off-by: Eugenio Pérez --- hw/net/virtio-net.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index e

[PATCH 3/7] virtio_net: Handle _F_STATUS emulation in virtio_net_get_config

2022-10-20 Thread Eugenio Pérez
At this moment this code path is not reached, but vdpa devices can offer VIRTIO_NET_F_STATUS unconditionally. While the guest must assume that link is always up by the standard, qemu will set the status bit to 1 always in this case. This makes little use by itself, but VIRTIO_NET_F_STATUS is neede

Re: [PATCH v2 1/2] util/log: Derive thread id from getpid() on hosts w/o gettid() syscall

2022-10-20 Thread Paolo Bonzini
On 10/19/22 17:57, Daniel P. Berrangé wrote: +if (my_id == -1) { +my_id = getpid() + qatomic_fetch_inc(&counter); +} +return my_id; This doesn't look safe for linux-user when we fork, but don't exec. Linux-user won't ever get here, however bsd-user might. We should have g

Re: has anybody looked at the long-standing intermittent raspi2 avocado test failure?

2022-10-20 Thread Peter Maydell
On Thu, 20 Oct 2022 at 08:52, Thomas Huth wrote: > > On 19/10/2022 22.38, John Snow wrote: > > On Tue, Oct 18, 2022 at 6:23 AM Peter Maydell > > wrote: > >> > >> If you run this single avocado test: > >> > >> while ./build/x86/tests/venv/bin/avocado run > >> build/x86/tests/avocado/boot_linux_co

[RFC PATCH 0/3] Fix some TCG RISC-V backend bugs

2022-10-20 Thread LIU Zhiwei
This patch set fix some bugs in RISC-V backend. It includes: 1. guest regiser using bug in tcg_out_qemu_ld and tcg_out_qemu_st 2. immediate range bug in tcg_out_opc_imm 3. a wrong optimization in tcg_out_addsub2 After this patch set, I can run the 400.perlbench case(spec2006-simple). Besides, it

[RFC PATCH 2/3] tcg/riscv: Fix tcg_out_opc_imm when imm exceeds

2022-10-20 Thread LIU Zhiwei
TYPE-I immediate can only represent a signed 12-bit value. If immediate exceed, mov it to an register. Signed-off-by: LIU Zhiwei --- tcg/riscv/tcg-target.c.inc | 28 +++- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/tcg/riscv/tcg-target.c.inc b/tcg/riscv

[PATCH 1/7] vdpa: Save emulated features list in vhost_vdpa

2022-10-20 Thread Eugenio Pérez
At this moment only _F_LOG is added there. However future patches add features that depend on the kind of device. In particular, only net devices can add VIRTIO_F_GUEST_ANNOUNCE. So let's allow vhost_vdpa creator to set custom emulated device features. Signed-off-by: Eugenio Pérez --- include/h

[PATCH 5/7] vdpa: handle VIRTIO_NET_CTRL_ANNOUNCE in vhost_vdpa_net_handle_ctrl_avail

2022-10-20 Thread Eugenio Pérez
Since this capability is emulated by qemu shadowed CVQ cannot forward it to the device. Process all that command within qemu. Signed-off-by: Eugenio Pérez --- net/vhost-vdpa.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c

[PATCH 0/7] Guest announce feature emulation using Shadow VirtQueue

2022-10-20 Thread Eugenio Pérez
A gratuitous ARP is recommended after a live migration to reduce the amount of time needed by the network links to be aware of the new location. A hypervisor may not have the knowledge of the guest network configuration, and this is especially true on passthrough devices, so its simpler to ask the

[PATCH 7/7] vdpa: Offer VIRTIO_NET_F_GUEST_ANNOUNCE feature if SVQ is enabled

2022-10-20 Thread Eugenio Pérez
So qemu emulates it in case the device does not support it. Signed-off-by: Eugenio Pérez --- net/vhost-vdpa.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index 5fda405a66..64442e8455 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -566,6 +56

Re: [PATCH v8 0/9] target/arm: pc-relative translation blocks

2022-10-20 Thread Peter Maydell
On Thu, 20 Oct 2022 at 04:14, Richard Henderson wrote: > > This is the Arm specific changes required to reduce the > amount of translation for address space randomization. > > Changes for v8: > * Add a comment to both gen_goto_tb concerning the ordering > of the pc update vs the goto_tb opco

[RFC PATCH 1/3] tcg/riscv: Fix base regsiter for qemu_ld/st

2022-10-20 Thread LIU Zhiwei
When guest base is zero, we should use addr_regl as base regiser instead of the initial register TCG_REG_TMP0. Signed-off-by: LIU Zhiwei --- tcg/riscv/tcg-target.c.inc | 4 1 file changed, 4 insertions(+) diff --git a/tcg/riscv/tcg-target.c.inc b/tcg/riscv/tcg-target.c.inc index 81a83e45b1

Re: [PATCH v2 2/2] util/log: Always send errors to logfile when daemonized

2022-10-20 Thread Paolo Bonzini
On 10/20/22 11:58, Daniel P. Berrangé wrote: The '-d' option enables logging in QEMU, primary for things related to TCG. By default that logging goes to stderr, but it can be sent to 1 or mnay files, using -D. IOW, -D is NOT about controlling where stderr/out is connected. It is about where TCG

Re: [PATCH v8 1/8] mm/memfd: Introduce userspace inaccessible memfd

2022-10-20 Thread Vishal Annapurve
On Wed, Oct 19, 2022 at 9:02 PM Kirill A . Shutemov wrote: > > On Tue, Oct 18, 2022 at 07:12:10PM +0530, Vishal Annapurve wrote: > > On Tue, Oct 18, 2022 at 3:27 AM Kirill A . Shutemov > > wrote: > > > > > > On Mon, Oct 17, 2022 at 06:39:06PM +0200, Gupta, Pankaj wrote: > > > > On 10/17/2022 6:19

Re: [PATCH] tests/avocado: raspi2_initrd: Wait for guest shutdown message before stopping

2022-10-20 Thread Alex Bennée
Peter Maydell writes: > The avocado test > tests/avocado/boot_linux_console.py:BootLinuxConsole.test_arm_raspi2_initrd > finishes wiith > > exec_command(self, 'halt') > # Wait for VM to shut down gracefully > self.vm.wait() > > In theory this should be fine. In practice it runs int

Re: [RFC PATCH 1/4] docs/devel: add a maintainers section to development process

2022-10-20 Thread Peter Maydell
On Fri, 14 Oct 2022 at 14:31, Alex Bennée wrote: > > > Markus Armbruster writes: > > > Mark Cave-Ayland writes: > > > >> On 12/10/2022 13:11, Alex Bennée wrote: > > > > [...] > > > >>> +Becoming a maintainer > >>> +- > >>> + > >>> +Maintainers are volunteers who put themselve

Re: [PATCH] tests/avocado: raspi2_initrd: Wait for guest shutdown message before stopping

2022-10-20 Thread Philippe Mathieu-Daudé
On 20/10/22 12:20, Peter Maydell wrote: The avocado test tests/avocado/boot_linux_console.py:BootLinuxConsole.test_arm_raspi2_initrd finishes wiith Typo "with" exec_command(self, 'halt') # Wait for VM to shut down gracefully self.vm.wait() In theory this should be fine. In

Re: [PATCH v12 15/17] net: stream: move to QIO to enable additional parameters

2022-10-20 Thread Philippe Mathieu-Daudé
On 20/10/22 11:16, Laurent Vivier wrote: Use QIOChannel, QIOChannelSocket and QIONetListener. This allows net/stream to use all the available parameters provided by SocketAddress. Signed-off-by: Laurent Vivier Acked-by: Michael S. Tsirkin --- meson | 2 +- net/stream.c| 493

[RFC PATCH 3/3] tcg/riscv: Remove a wrong optimization for addsub2

2022-10-20 Thread LIU Zhiwei
It's not clear what it is doing here. And it's wrong because bl and al are both register, so we can't add them by an ADDI instruction. Signed-off-by: LIU Zhiwei --- tcg/riscv/tcg-target.c.inc | 3 --- 1 file changed, 3 deletions(-) diff --git a/tcg/riscv/tcg-target.c.inc b/tcg/riscv/tcg-target.

Re: [PATCH v5 05/10] acpi/tests/avocado/bits: add SPDX license identifiers for bios bits smilatency tests

2022-10-20 Thread Alex Bennée
Ani Sinha writes: > On Wed, Oct 19, 2022 at 9:02 PM Alex Bennée wrote: >> >> >> Ani Sinha writes: >> >> > Added the SPDX license identifier for smilatency tests. >> > Also added a comment indicating that smilatency test is run from within the >> > biosbits environment/VM and hence is not subj

Re: [RFC PATCH] target/s390x: fake instruction loading when handling 'ex'

2022-10-20 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 19/10/22 13:35, Alex Bennée wrote: >> The s390x EXecute instruction is a bit weird as we synthesis the >> executed instruction from what we have stored in memory. When plugins >> are enabled this breaks because we detect the ld_code2() loading from >> a non z

[PATCH 4/7] vdpa: Expose VIRTIO_NET_F_STATUS unconditionally

2022-10-20 Thread Eugenio Pérez
Now that qemu can handle and emulate it if the vdpa backend does not support it we can offer it always. Signed-off-by: Eugenio Pérez --- net/vhost-vdpa.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index e7db40b7cd..3374c21b4d 100644 --- a/net/vhost

Re: [PATCH v6 10/10] s390x: pv: Add dump support

2022-10-20 Thread Steffen Eiden
On 10/17/22 10:38, Janosch Frank wrote: Sometimes dumping a guest from the outside is the only way to get the data that is needed. This can be the case if a dumping mechanism like KDUMP hasn't been configured or data needs to be fetched at a specific point. Dumping a protected guest from the o

Re: [PATCH v3 3/4] hw/nvme: add iothread support

2022-10-20 Thread Klaus Jensen
On Aug 27 17:12, Jinhao Fan wrote: > Add an option "iothread=x" to do emulation in a seperate iothread. > This improves the performance because QEMU's main loop is responsible > for a lot of other work while iothread is dedicated to NVMe emulation. > Moreover, emulating in iothread brings the poten

Re: [PATCH v5 05/10] acpi/tests/avocado/bits: add SPDX license identifiers for bios bits smilatency tests

2022-10-20 Thread Ani Sinha
On Thu, Oct 20, 2022 at 4:17 PM Alex Bennée wrote: > > > Ani Sinha writes: > > > On Wed, Oct 19, 2022 at 9:02 PM Alex Bennée wrote: > >> > >> > >> Ani Sinha writes: > >> > >> > Added the SPDX license identifier for smilatency tests. > >> > Also added a comment indicating that smilatency test is

Re: [RISU PATCH v2 0/5] Add LoongArch architectures support

2022-10-20 Thread Peter Maydell
On Thu, 13 Oct 2022 at 09:28, Song Gao wrote: > > hi, > > This series adds LoongArch architectures support, we had tested two > mode: > 1. LoongArch host server + LoongArch host client; > 2. LoongArch host server + qemu client. > > You can find all LoongArch instructions at [1]. > This series no

Re: [PATCH v3 4/4] hw/nvme: add polling support

2022-10-20 Thread Klaus Jensen
On Aug 27 17:12, Jinhao Fan wrote: > Add AioContext polling handlers for NVMe SQ and CQ. By employing polling, > the latency of NVMe IO emulation is greatly reduced. The SQ polling > handler checks for updates on the SQ tail shadow doorbell buffer. The CQ > polling handler is an empty function beca

Re: [PATCH v3 0/4] irqfd, iothread and polling support

2022-10-20 Thread Klaus Jensen
On Aug 27 17:12, Jinhao Fan wrote: > This series of performance enhancements brings iothread and polling > capabilities to qemu-nvme. The first two patches implements support > for irqfd, which solves thread safety problems for interrupt emulation > outside the main loop thread. The third patch add

Re: [PATCH v12 12/17] net: dgram: add unix socket

2022-10-20 Thread Philippe Mathieu-Daudé
On 20/10/22 11:16, Laurent Vivier wrote: Signed-off-by: Laurent Vivier Reviewed-by: Stefano Brivio Reviewed-by: David Gibson Acked-by: Michael S. Tsirkin QAPI schema Acked-by: Markus Armbruster Eventually: Acked-by: Markus Armbruster (QAPI schema) --- net/dgram.c | 54 +

Re: [PATCH v6 09/10] s390x: Add KVM PV dump interface

2022-10-20 Thread Steffen Eiden
On 10/17/22 10:38, Janosch Frank wrote: Let's add a few bits of code which hide the new KVM PV dump API from us via new functions. Signed-off-by: Janosch Frank Reviewed-by: Janis Schoetterl-Glausch Reviewed-by: Steffen Eiden --- hw/s390x/pv.c | 51 ++

Re: [PATCH] tests/avocado: raspi2_initrd: Wait for guest shutdown message before stopping

2022-10-20 Thread Richard Henderson
On 10/20/22 20:20, Peter Maydell wrote: The avocado test tests/avocado/boot_linux_console.py:BootLinuxConsole.test_arm_raspi2_initrd finishes wiith exec_command(self, 'halt') # Wait for VM to shut down gracefully self.vm.wait() In theory this should be fine. In practice it runs

[PATCH v3 01/26] tests/docker: update fedora-win[32|64]-cross with lcitool

2022-10-20 Thread Alex Bennée
Convert another two dockerfiles to lcitool and update. I renamed the helper because it is not Debian specific. We need an updated lcitool for this to deal with the weirdness of a 32bit nsis tool for both 32 and 64 bit builds. As a result there are some minor whitespace and re-order changes in a bun

[PATCH v3 14/26] hw/usb: dev-mtp: Use g_mkdir()

2022-10-20 Thread Alex Bennée
From: Bin Meng Use g_mkdir() to create a directory on all platforms. Signed-off-by: Bin Meng Acked-by: Gerd Hoffmann Signed-off-by: Alex Bennée Message-Id: <20221006151927.2079583-8-bmeng...@gmail.com> --- hw/usb/dev-mtp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v3 04/26] configure: don't enable cross compilers unless in target_list

2022-10-20 Thread Alex Bennée
This avoids the unfortunate effect of always builds the pc-bios blobs for targets the user isn't interested in. Suggested-by: Paolo Bonzini Signed-off-by: Alex Bennée --- configure | 9 + 1 file changed, 9 insertions(+) diff --git a/configure b/configure index 81561be7c1..dd6f58dcde 10

Re: [PATCH v5 6/6] hw/arm/virt: Add 'compact-highmem' property

2022-10-20 Thread Gavin Shan
Hi Marc, On 10/20/22 5:44 PM, Marc Zyngier wrote: On Thu, 20 Oct 2022 00:57:32 +0100, Gavin Shan wrote: For Marc's suggestion to add properties so that these high memory regions can be disabled by users. I can add one patch after this one to introduce the following 3 properties. Could you ple

Re: [PATCH v4 5/5] test/acpi/bios-tables-test: SSDT: update golden master binaries

2022-10-20 Thread Igor Mammedov
On Thu, 20 Oct 2022 08:48:36 +0800 Robert Hoo wrote: > Ping... sorry, series got lost among the rest. I've just acked 4/5, but this patch doesn't apply anymore with error: corrupt patch at line 172 > On Fri, 2022-10-07 at 21:27 +0800, Robert Hoo wrote: > > Ping... > > On Tue, 2022-09-27 at 08:

Re: [RFC PATCH 1/3] tcg/riscv: Fix base regsiter for qemu_ld/st

2022-10-20 Thread Richard Henderson
On 10/20/22 20:41, LIU Zhiwei wrote: When guest base is zero, we should use addr_regl as base regiser instead of the initial register TCG_REG_TMP0. Signed-off-by: LIU Zhiwei --- tcg/riscv/tcg-target.c.inc | 4 1 file changed, 4 insertions(+) diff --git a/tcg/riscv/tcg-target.c.inc b/tc

[PATCH v3 21/26] tests/tcg: re-enable linux-test for sh4

2022-10-20 Thread Alex Bennée
This test was marked as broken due to bug #704 which was fixed by aee14c77f4 (linux-user: Rewrite do_getdents, do_getdents64). Local testing shows this is solid now so lets re-enable the test. Signed-off-by: Alex Bennée Cc: Yoshinori Sato --- tests/tcg/sh4/Makefile.target | 6 -- 1 file cha

Re: [RFC PATCH 1/3] tcg/riscv: Fix base regsiter for qemu_ld/st

2022-10-20 Thread LIU Zhiwei
On 2022/10/20 19:26, Philippe Mathieu-Daudé wrote: On 20/10/22 12:41, LIU Zhiwei wrote: When guest base is zero, we should use addr_regl as base regiser instead of Typo "register" here and in patch subject. the initial register TCG_REG_TMP0. Signed-off-by: LIU Zhiwei ---   tcg/riscv/tcg-

Re: [PATCH v3 0/2] virtio-net: re-arm/re-schedule when tx_burst stops virtio_net_flush_tx()

2022-10-20 Thread Michael S. Tsirkin
On Thu, Oct 20, 2022 at 11:58:44AM +0200, Laurent Vivier wrote: > When virtio_net_flush_tx() reaches the tx_burst value all the queue is > not flushed and nothing restart the timer or the bottom half function. > > For BH, this is only missing in the virtio_net_tx_complete() function. > For the tim

[PATCH 02/31] tcg: Introduce paired register allocation

2022-10-20 Thread Richard Henderson
There are several instances where we need to be able to allocate a pair of registers to related inputs/outputs. Add 'p' and 'm' register constraints for this, in order to be able to allocate the even/odd register first or second. Signed-off-by: Richard Henderson --- include/tcg/tcg.h | 2 + tc

[PATCH v3 10/26] tcg: Avoid using hardcoded /tmp

2022-10-20 Thread Alex Bennée
From: Bin Meng Use g_get_tmp_dir() to get the directory to use for temporary files. Signed-off-by: Bin Meng Reviewed-by: Marc-André Lureau Reviewed-by: Alex Bennée Signed-off-by: Alex Bennée Message-Id: <20221006151927.2079583-3-bmeng...@gmail.com> --- tcg/tcg.c | 3 ++- 1 file changed, 2 i

[PATCH v3 06/26] tests/avocado: extend the timeout for x86_64 tcg tests

2022-10-20 Thread Alex Bennée
These are timeing out on gitlab. Signed-off-by: Alex Bennée --- tests/avocado/boot_linux.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/avocado/boot_linux.py b/tests/avocado/boot_linux.py index b7522ad3a1..571d33882a 100644 --- a/tests/avocado/boot_linux.py +++ b/tests/avocado/boot

Re: [PATCH v12 10/17] net: dgram: make dgram_dst generic

2022-10-20 Thread Philippe Mathieu-Daudé
On 20/10/22 11:16, Laurent Vivier wrote: dgram_dst is a sockaddr_in structure. To be able to use it with unix socket, use a pointer to a generic sockaddr structure. Rename it dest_addr, and store socket length in dest_len. Signed-off-by: Laurent Vivier Reviewed-by: Stefano Brivio Acked-by: Mi

Re: [PATCH v12 09/17] net: stream: add unix socket

2022-10-20 Thread Philippe Mathieu-Daudé
On 20/10/22 11:16, Laurent Vivier wrote: Signed-off-by: Laurent Vivier Reviewed-by: Stefano Brivio Acked-by: Michael S. Tsirkin QAPI schema Acked-by: Markus Armbruster Eventually: Acked-by: Markus Armbruster (QAPI schema) Reviewed-by: Philippe Mathieu-Daudé --- net/stream.c| 1

[PATCH v3 07/26] tests/docker: Add flex/bison to `debian-hexagon-cross`

2022-10-20 Thread Alex Bennée
From: Anton Johansson debian-hexagon-cross contains two images, one to build the toolchain used for building the Hexagon tests themselves, and one image to build QEMU and run the tests. This commit adds flex/bison to the final image that builds QEMU so that it can also build idef-parser. Note:

[PATCH 15/31] tcg: Replace TCG_TARGET_CALL_ALIGN_ARGS with TCG_TARGET_CALL_ARG_I64

2022-10-20 Thread Richard Henderson
For 32-bit hosts when TCG_TARGET_CALL_ALIGN_ARGS was set, use TCG_CALL_ARG_EVEN. For 64-bit hosts, TCG_TARGET_CALL_ALIGN_ARGS was silently ignored, so always use TCG_CALL_ARG_NORMAL. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.h | 2 +- tcg/arm/tcg-target.h | 2 +-

Re: [PATCH v12 05/17] net: introduce qemu_set_info_str() function

2022-10-20 Thread Philippe Mathieu-Daudé
On 20/10/22 11:16, Laurent Vivier wrote: Embed the setting of info_str in a function. Signed-off-by: Laurent Vivier Reviewed-by: David Gibson Acked-by: Michael S. Tsirkin --- hw/net/xen_nic.c | 5 ++--- include/net/net.h | 1 + net/l2tpv3.c | 3 +-- net/net.c | 17 ++

[PATCH 25/31] tcg: Add TCG_CALL_{RET,ARG}_BY_REF

2022-10-20 Thread Richard Henderson
These will be used by some hosts, 32 and 64-bit to pass and return i128. Not yet used, because allocation is not yet enabled. Signed-off-by: Richard Henderson --- tcg/tcg-internal.h | 10 ++-- tcg/tcg.c | 124 - 2 files changed, 129 insertio

[PATCH 16/31] tcg: Replace TCG_TARGET_EXTEND_ARGS with TCG_TARGET_CALL_ARG_I32

2022-10-20 Thread Richard Henderson
For 64-bit hosts that had TCG_TARGET_EXTEND_ARGS, set TCG_TARGET_CALL_ARG_I32 to TCG_CALL_ARG_EXTEND. Otherwise, use TCG_CALL_ARG_NORMAL. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.h | 1 + tcg/arm/tcg-target.h | 1 + tcg/i386/tcg-target.h| 1 + tcg/loonga

[PATCH v3 20/26] tests/avocado: disable sh4 rd2 tests on Gitlab

2022-10-20 Thread Alex Bennée
Running repeated invocations on a number of test boxes show a fairly high error rate: $ retry.py -n 100 -c -- ./tests/venv/bin/avocado run tests/avocado/boot_linux_console.py:BootLinuxConsole.test_sh4_r2d retry.py called with ['./tests/venv/bin/avocado', 'run', 'tests/avocado/boot_linux_cons

[PATCH v3 05/26] configure: fix the --enable-static --disable-pie case

2022-10-20 Thread Alex Bennée
The previous tweak was incomplete as it missed a leg. Fixes: abafb64b6d (configure: explicitly set cflags for --disable-pie) Signed-off-by: Alex Bennée --- configure | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index dd6f58dcde..8c2c4c1a04 100755

[PULL 20/24] target/arm: Change gen_jmp* to work on displacements

2022-10-20 Thread Peter Maydell
From: Richard Henderson In preparation for TARGET_TB_PCREL, reduce reliance on absolute values. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20221020030641.2066807-7-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/translate.c | 37 +

[PATCH v3 08/26] tests/tcg: use regular semihosting for nios2-softmmu

2022-10-20 Thread Alex Bennée
The nios2 code now plugs into the common semihosting code so we can use the same redirect invocation as the other boards. There is however a bug raised for the fact the tests don't seem to be completing properly and silently passing anyway: https://gitlab.com/qemu-project/qemu/-/issues/1258 Sig

[PATCH 30/31] tcg: Add temp allocation for TCGv_i128

2022-10-20 Thread Richard Henderson
This enables allocation of i128. The type is not yet usable, as we have not yet added data movement ops. Signed-off-by: Richard Henderson --- include/tcg/tcg.h| 32 tcg/tci/tcg-target.h | 3 +++ tcg/tcg.c| 32 +++- 3

Re: [PATCH v12 17/17] net: stream: add QAPI events to report connection state

2022-10-20 Thread Philippe Mathieu-Daudé
On 20/10/22 11:16, Laurent Vivier wrote: The netdev reports NETDEV_STREAM_CONNECTED event when the backend is connected, and NETDEV_STREAM_DISCONNECTED when it is disconnected. The NETDEV_STREAM_CONNECTED event includes the URI of the destination address. Signed-off-by: Laurent Vivier Acked-by

[PATCH v6 03/10] acpi/tests/avocado/bits: disable acpi PSS tests that are failing in biosbits

2022-10-20 Thread Ani Sinha
PSS tests in acpi test suite seems to be failing in biosbits. This is because the test is unable to find PSS support in QEMU bios. Let us disable them for now so that make check does not fail. We can fix the tests and re-enable them later. Example failure: ACPI _PSS (Pstate) table conformanc

[PATCH 21/31] tcg: Define TCG_TYPE_I128 and related helper macros

2022-10-20 Thread Richard Henderson
Begin staging in support for TCGv_i128 with Int128. Define the type enumerator, the typedef, and the helper-head.h macros. This cannot yet be used, because you can't allocate temporaries of this new type. Signed-off-by: Richard Henderson --- include/exec/helper-head.h | 7 +++ include/tcg/

[PULL 00/24] target-arm queue

2022-10-20 Thread Peter Maydell
'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2022-10-18 11:14:31 -0400) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20221020 for you to fetch changes up to 5db899303799e49209016a93289b8694afa1

  1   2   3   4   >