On 10/19/22 17:57, Daniel P. Berrangé wrote:
+ if (my_id == -1) { + my_id = getpid() + qatomic_fetch_inc(&counter); + } + return my_id;This doesn't look safe for linux-user when we fork, but don't exec.
Linux-user won't ever get here, however bsd-user might. We should have get_thread_id() somewhere in util/, for example
https://github.com/wine-mirror/wine/blob/master/dlls/ntdll/unix/server.c
The getpid() will change after the fork, but counter won't be reset, so a thread in the parent could clash with a thread in the forked child.
It might clash even if the counter is reset for that matter. Paolo
