Re: [PATCH v3 4/5] acpi/nvdimm: Implement ACPI NVDIMM Label Methods

On Tue, 2022-09-20 at 11:13 +0200, Igor Mammedov wrote: > On Fri, 16 Sep 2022 21:15:35 +0800 > Robert Hoo wrote: > > > On Fri, 2022-09-16 at 09:37 +0200, Igor Mammedov wrote: > > > > > > Fine, get your point now. > > > > In ASL it will look like this: > > > > Local1 = Package

Re: [PATCH] This patch is to solve the problem that the bitmap file in memory is lost after creating a snapshot

[Cc Eric and John] On 9/20/22 05:47, Hongleilee wrote: From: Hongleili Li (李红磊)-云数据中心集团 Signed-off-by: Hongleili Li (李红磊)-云数据中心集团 --- blockdev.c | 4 1 file changed, 4 insertions(+) diff --git a/blockdev.c b/blockdev.c index 9230888e34..a6b85d06b7 100644 --- a/blockdev.c +++ b/blockd

RE: [RFC PATCH v2] gdbstub: only send stop-reply packets when allowed to

> Alex Bennée wrote: > > Matheus Tavares Bernardino writes: > > > > > Although this behavior doesn't seem to cause problems with GDB itself, > > it does with other debuggers that implement the GDB remote serial > > protocol, like hexagon-lldb. In this case, the debugger fails upon an > > unexpe

[PATCH v3 1/3] configure: make sure tcg tests can see HAVE_GDB_BIN

HAVE_GDB_BIN is only used by tests/tcg/* makefiles, but it is currently written at /config-host.mak, which those makefiles don't have access to. Let's instead write it to /tests/tcg/config-host.mak, which is included by the makefiles. Signed-off-by: Matheus Tavares Bernardino --- configure | 1

[PATCH v3 2/3] gdbstub: only send stop-reply packets when allowed to

GDB's remote serial protocol allows stop-reply messages to be sent by the stub either as a notification packet or as a reply to a GDB command (provided that the cmd accepts such a response). QEMU currently does not implement notification packets, so it should only send stop-replies synchronously an

[PATCH v3 3/3] gdbstub: add test for untimely stop-reply packets

In the previous commit, we modified gdbstub.c to only send stop-reply packets as a response to GDB commands that accept it. Now, let's add a test for this intended behavior. Running this test before the fix from the previous commit fails as QEMU sends a stop-reply packet asynchronously, when GDB wa

[PATCH v3 0/3] gdbstub: avoid untimely stop-reply msgs

This series limits gdbstub to send stop-reply packets only as a reply to commands that accept them, following the RSP specification. Changes since v2[1]: - Replaced char buffer with boolean at struct GDBState. - Covered other functions that might send stop-reply packets. - Added test. Note: I wa

Re: [PULL 00/11] semihosting patch queue

On Sat, 17 Sept 2022 at 21:20, Stefan Hajnoczi wrote: > > Applied, thanks. > > Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any > user-visible changes. I have updated the changelog with a note in the 'incompatible changes' section to let users know in what case they mig

[PATCH] ratelimit: restrict the delay time to a non-negative value

From: Wang Liang The delay time should never be a negative value. Signed-off-by: Wang Liang --- include/qemu/ratelimit.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qemu/ratelimit.h b/include/qemu/ratelimit.h index 48bf59e857..c8ea855fc1 100644 --- a/include/qem

Re: [PATCH] virtio-net: set the max of queue size to 4096

On Tue, Sep 20, 2022 at 10:03:23AM +0800, Jason Wang wrote: > On Tue, Sep 20, 2022 at 9:38 AM Jason Wang wrote: > > > > On Tue, Sep 20, 2022 at 9:10 AM liuhaiwei wrote: > > > > > > From: liuhaiwei > > > > > > the limit of maximum of rx_queue_size and tx_queue to 1024 is so small as > > > to aff

Re: [PULL 00/20] target-arm.next patch queue

On Sat, 17 Sept 2022 at 21:22, Stefan Hajnoczi wrote: > > Applied, thanks. > > Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any > user-visible changes. I've updated the changelog for this one too. thanks -- PMM

loongson3-virt machine does not support if=ide,bus=0,unit=0

I create the disk with qemu-img create -f qcow2 zbkylin_mips64el.img 50G Then, start the machine with qemu-system-mips64el -M loongson3-virt -bios pmon-3avirt.bin -hda zbkylin_mips64el.img And get the following error. qemu-system-mips64el: -hda zbkylin_mips64el.img: machine type does not support

Re: [PATCH] This patch is to solve the problem that bitmaps in memory are lost after dirve-mirror is completed.

[Cc John] Hi! Please make subject line shorter and do longer description in the body of commit message. About the patch - same thing. Please move/copy bitmaps using Bitmap API. On 9/20/22 08:47, Hongleilee wrote: Signed-off-by: Hongleilee <281773...@qq.com> --- block/mirror.c | 29

Re: [PATCH v9 3/7] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls

Klaus Jensen 于2022年9月20日周二 16:51写道： > > On Sep 10 13:27, Sam Li wrote: > > Add a new zoned_host_device BlockDriver. The zoned_host_device option > > accepts only zoned host block devices. By adding zone management > > operations in this new BlockDriver, users can use the new block > > layer APIs i

Re: [PATCH v2] hw/acpi: Add ospm_status hook implementation for acpi-ged

On Wed, 24 Aug 2022 at 16:04, Igor Mammedov wrote: > > On Tue, 16 Aug 2022 17:49:57 +0800 > Keqian Zhu wrote: > > > Setup an ARM virtual machine of machine virt and execute qmp > > "query-acpi-ospm-status" > > causes segmentation fault with following dumpstack: > > #1 0xab64235c in qmp

Re: [PATCH v2 01/66] target/arm: Create GetPhysAddrResult

On Mon, 22 Aug 2022 at 16:42, Richard Henderson < richard.hender...@linaro.org> wrote: > > Combine 5 output pointer arguments from get_phys_addr > into a single struct. Adjust all callers. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH] linux-user: use 'max' instead of 'qemu32' / 'qemu64' by defualt

Typo "default" in subject line. On Fri, Aug 26, 2022 at 1:46 PM Daniel P. Berrangé wrote: > > The 'qemu64' CPU model implements the least featureful x86_64 CPU that's > possible. Historically this hasn't been an issue since it was rare for > OS distros to build with a higher mandatory CPU baselin

Re: [RFC PATCH] libvduse: Do not truncate terminating NUL character with strncpy()

On Tue, Sep 20, 2022 at 7:25 PM Markus Armbruster wrote: > > Philippe Mathieu-Daudé writes: > > > GCC 8 added a -Wstringop-truncation warning: > > > > The -Wstringop-truncation warning added in GCC 8.0 via r254630 for > > bug 81117 is specifically intended to highlight likely unintended > >

Re: [PATCH 4/9] hw/ppc/spapr: Fix code style problems reported by checkpatch

On 9/19/22 20:17, Bernhard Beschow wrote: Signed-off-by: Bernhard Beschow --- Reviewed-by: Daniel Henrique Barboza And I've queued it in gitlab.com/danielhb/qemu/tree/ppc-next since it's not tied with the rest of the series. Thanks, Daniel include/hw/ppc/spapr.h | 5 +++-- 1 file c

Re: [PATCH] linux-user: fix readlinkat handling with magic exe symlink

bump?? This is just copying the existing f17f4989fa193fa8279474c5462289a3cfe69aea commit to cover all code paths, so I was hoping it would be trivial to get an ack for this. Thanks! On Mon, Aug 29, 2022 at 5:49 PM Jameson Nash wrote: > bump? This helps fix one of the libuv tests when run under q

[PATCH] checkpatch: ignore target/hexagon/imported/* files

These files come from an external project (the hexagon archlib), so they deliberately do not follow QEMU's coding style. To avoid false positives from checkpatch.pl, let's disable the checking for those. Signed-off-by: Matheus Tavares Bernardino --- scripts/checkpatch.pl | 1 + 1 file changed, 1

Re: [PATCH v2 09/39] fsdev/virtfs-proxy-helper: Use g_mkdir()

On Dienstag, 20. September 2022 12:31:29 CEST Bin Meng wrote: > From: Bin Meng > > Use g_mkdir() to create a directory on all platforms. > > Signed-off-by: Bin Meng > --- Reviewed-by: Christian Schoenebeck > > Changes in v2: > - Change to use g_mkdir() > > fsdev/virtfs-proxy-helper.c | 3

Re: [PATCH v2 02/66] target/arm: Fix ipa_secure in get_phys_addr

On Mon, 22 Aug 2022 at 16:28, Richard Henderson wrote: > > The starting security state comes with the translation regime, > not the current state of arm_is_secure_below_el3(). > > More use of the local variable, ipa_secure, which does not need > to be written back to result->attrs.secure -- we com

Re: [PATCH] ratelimit: restrict the delay time to a non-negative value

On Tue 20 Sep 2022 08:33:50 PM +08, wanglian...@126.com wrote: > From: Wang Liang > > The delay time should never be a negative value. > > -return limit->slice_end_time - now; > +return MAX(limit->slice_end_time - now, 0); How can this be negative? slice_end_time is guaranteed to be large

Re: [PATCH v2 09/66] target/arm: Use GetPhysAddrResult in pmsav8_mpu_lookup

On Mon, 22 Aug 2022 at 16:49, Richard Henderson wrote: > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 03/66] target/arm: Use GetPhysAddrResult in get_phys_addr_lpae

On Mon, 22 Aug 2022 at 16:47, Richard Henderson wrote: > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson > --- > target/arm/ptw.c | 69 ++-- > 1 file changed, 26 insertions(+), 43 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v6 2/2] i386: Add notify VM exit support

On Tue, Sep 20, 2022 at 01:55:20PM +0800, Chenyi Qiang wrote: > > > @@ -5213,6 +5213,7 @@ int kvm_arch_handle_exit(CPUState *cs, struct > > > kvm_run > > > *run) > > > break; > > > case KVM_EXIT_NOTIFY: > > > ret = 0; > > > +warn_report_once("KVM: notify window wa

Re: [PATCH v2 08/66] target/arm: Use GetPhysAddrResult in get_phys_addr_pmsav8

On Mon, 22 Aug 2022 at 16:29, Richard Henderson wrote: > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

[PATCH] i386: Fix KVM_CAP_ADJUST_CLOCK capability check

KVM commit c68dc1b577ea ("KVM: x86: Report host tsc and realtime values in KVM_GET_CLOCK") broke migration of certain workloads, e.g. Win11 + WSL2 guest reboots immediately after migration. KVM, however, is not to blame this time. When KVM_CAP_ADJUST_CLOCK capability is checked, the result is all s

Re: [PATCH v2 11/66] target/arm: Add is_secure parameter to v8m_security_lookup

On Mon, 22 Aug 2022 at 16:29, Richard Henderson wrote: > > Remove the use of regime_is_secure from v8m_security_lookup, > passing the new parameter to the lookup instead. > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 10/66] target/arm: Remove is_subpage argument to pmsav8_mpu_lookup

On Mon, 22 Aug 2022 at 16:54, Richard Henderson wrote: > > This can be made redundant with result->page_size, by moving the basic > set of page_size from get_phys_addr_pmsav8. We still need to overwrite > page_size when v8m_security_lookup signals a subpage. > > Signed-off-by: Richard Henderson

Re: [PATCH v2 13/66] target/arm: Add is_secure parameter to get_phys_addr_v5

On Mon, 22 Aug 2022 at 16:59, Richard Henderson wrote: > > Remove the use of regime_is_secure from get_phys_addr_v5, > passing the new parameter to the lookup instead. > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson > --- > target/arm/ptw.c | 11 +-- > 1 file changed, 5

Re: [PATCH v2 12/66] target/arm: Add secure parameter to pmsav8_mpu_lookup

On Mon, 22 Aug 2022 at 16:53, Richard Henderson wrote: > > Remove the use of regime_is_secure from pmsav8_mpu_lookup, > passing the new parameter to the lookup instead. > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 04/66] target/arm: Use GetPhysAddrResult in get_phys_addr_v6

On Mon, 22 Aug 2022 at 16:34, Richard Henderson wrote: > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson > --- > target/arm/ptw.c | 30 ++ > 1 file changed, 14 insertions(+), 16 deletions(-) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 06/30] tests/avocado: split the AST2x00Machine classes

Richard Henderson writes: > On 9/14/22 16:59, Alex Bennée wrote: >> The SDK tests take a lot longer to run and hence need a longer >> timeout. As they run well over the 60 second maximum for CI lets also >> disable them for CI as well. >> I suspect they also suffer from the inability to detect

Re: [PATCH v2 14/66] target/arm: Add is_secure parameter to get_phys_addr_v6

On Mon, 22 Aug 2022 at 16:54, Richard Henderson wrote: > > Remove the use of regime_is_secure from get_phys_addr_v6, > passing the new parameter to the lookup instead. > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 05/66] target/arm: Use GetPhysAddrResult in get_phys_addr_v5

On Mon, 22 Aug 2022 at 16:43, Richard Henderson wrote: > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 16/66] target/arm: Add is_secure parameter to pmsav7_use_background_region

On Mon, 22 Aug 2022 at 16:36, Richard Henderson wrote: > > Remove the use of regime_is_secure from pmsav7_use_background_region, > using the new parameter instead. > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v1 0/3] ui/gtk: Add a new parameter to assign connectors/monitors to Guests' windows

Any overlap with Dongwon Kim's "[PATCH v5 0/2] handling guest multiple displays"? Message-Id: <20220718233009.18780-1-dongwon@intel.com> https://lists.nongnu.org/archive/html/qemu-devel/2022-07/msg03212.html

Re: [PATCH v2 06/66] target/arm: Use GetPhysAddrResult in get_phys_addr_pmsav5

On Mon, 22 Aug 2022 at 16:42, Richard Henderson wrote: > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 23/66] target/arm: Add TBFLAG_M32.SECURE

On Mon, 22 Aug 2022 at 17:10, Richard Henderson wrote: > > Remove the use of regime_is_secure from arm_tr_init_disas_context. > Instead, provide the value of v8m_secure directly from tb_flags. > Rather than use regime_is_secure, use the env->v7m.secure directly, > as per arm_mmu_idx_el. > > Signed

Re: [PATCH] virtio: add VIRTQUEUE_ERROR QAPI event

Vladimir Sementsov-Ogievskiy writes: > For now we only log the vhost device error, when virtqueue is actually > stopped. Let's add a QAPI event, which makes possible: > > - collect statistics of such errors > - make immediate actions: take coredums or do some other debugging Core dumps, I pres

Re: [PATCH v2 07/66] target/arm: Use GetPhysAddrResult in get_phys_addr_pmsav7

On Mon, 22 Aug 2022 at 16:50, Richard Henderson wrote: > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson > --- > target/arm/ptw.c | 36 +--- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 24/66] target/arm: Merge regime_is_secure into get_phys_addr

On Mon, 22 Aug 2022 at 17:56, Richard Henderson wrote: > > This is the last use of regime_is_secure; remove it > entirely before changing the layout of ARMMMUIdx. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [RFC PATCH] libvduse: Do not truncate terminating NUL character with strncpy()

Yongji Xie writes: > On Tue, Sep 20, 2022 at 7:25 PM Markus Armbruster wrote: >> >> Philippe Mathieu-Daudé writes: >> >> > GCC 8 added a -Wstringop-truncation warning: >> > >> > The -Wstringop-truncation warning added in GCC 8.0 via r254630 for >> > bug 81117 is specifically intended to hig

Re: [PATCH v2 25/66] target/arm: Add is_secure parameter to do_ats_write

On Mon, 22 Aug 2022 at 16:54, Richard Henderson wrote: > > Use get_phys_addr_with_secure directly. This is the one place > where the value of is_secure may not equal arm_is_secure(env). Is there an implicit "for A-profile" here? Various of the m_helper.c calls to get_phys_addr() still pass in an

Re: [Phishing Risk] [External] Re: [PATCH 0/3] Add a host power device

Hi Philippe, Thanks for your reply. On Tue, Sep 20, 2022 at 7:09 AM Philippe Mathieu-Daudé wrote: > > Hi Jian, > > On 19/9/22 19:21, Jian Zhang wrote: > > This patchset adds a host power device and added it into the g220a > > mahcine. The BMC have a important is to control the power of the host,

Re: [PATCH v2 19/66] target/arm: Add is_secure parameter to regime_translation_disabled

On Mon, 22 Aug 2022 at 16:38, Richard Henderson wrote: > > Remove the use of regime_is_secure from regime_translation_disabled, > using the new parameter instead. > > This fixes a bug in S1_ptw_translate and get_phys_addr where we had > passed ARMMMUIdx_Stage2 and not ARMMMUIdx_Stage2_S to determi

[PULL 01/15] tests: mark io-command test as skipped if socat is missing

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Message-Id: <20220901110414.2892954-1-marcandre.lur...@redhat.com> Signed-off-by: Thomas Huth --- tests/unit/test-io-channel-command.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[PULL 08/15] bios-tables-test: Make oem-fields tests be consistent

From: Juan Quintela Every other test function is named: test_acpi__() Just make this test the same. Once there, rename "acpi/oem-fields" to "acpi/piix4/oem-fields" so it is consistent with everything else. Signed-off-by: Juan Quintela Message-Id: <20220902173452.1904-2-quint...@redha

Re: [PATCH v2 20/66] target/arm: Add is_secure parameter to get_phys_addr_pmsav5

On Mon, 22 Aug 2022 at 17:49, Richard Henderson wrote: > > Remove the use of regime_is_secure from get_phys_addr_pmsav5. > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 21/66] target/arm: Split out get_phys_addr_with_secure

On Mon, 22 Aug 2022 at 16:44, Richard Henderson wrote: > > Retain the existing get_phys_addr interface using > the security state derived from mmu_idx. > > Signed-off-by: Richard Henderson > diff --git a/target/arm/ptw.c b/target/arm/ptw.c > index c338e2324a..c132d0cada 100644 > --- a/target/arm/

Re: [PATCH v2 15/66] target/arm: Add secure parameter to get_phys_addr_pmsav8

On Mon, 22 Aug 2022 at 16:53, Richard Henderson wrote: > > Remove the use of regime_is_secure from get_phys_addr_pmsav8. > Since we already had a local variable named secure, use that. > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson > --- > target/arm/ptw.c | 5 ++--- > 1 file c

[PULL 14/15] qga: Replace 'blacklist' command line and config file options by 'block-rpcs'

Let's use a more appropriate wording for this command line and config file option. The old ones are still accepted for compatibility reasons, but marked as deprecated now so that it could be removed in a future version of QEMU. This change is based on earlier patches from Philippe Mathieu-Daudé, w

[PULL 02/15] tests/vm: update NetBSD to 9.3

From: Brad Smith Update NetBSD to 9.3 Signed-off-by: Brad Smith Message-Id: Signed-off-by: Thomas Huth --- tests/vm/netbsd | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/vm/netbsd b/tests/vm/netbsd index da6773ff59..aa54338dfa 100755 --- a/tests/vm/netbsd +++ b

Re: [PATCH v2 22/66] target/arm: Add is_secure parameter to v7m_read_half_insn

On Mon, 22 Aug 2022 at 17:57, Richard Henderson wrote: > > Remove the use of regime_is_secure from v7m_read_half_insn, using > the new parameter instead. > > As it happens, both callers pass true, propagated from the argument > to arm_v7m_mmu_idx_for_secstate which created the mmu_idx argument, >

Re: [PATCH v2 17/66] target/arm: Add is_secure parameter to get_phys_addr_lpae

On Mon, 22 Aug 2022 at 17:33, Richard Henderson wrote: > > Remove the use of regime_is_secure from get_phys_addr_lpae, > using the new parameter instead. > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson > @@ -2334,7 +2334,7 @@ bool get_phys_addr(CPUARMState *env, target_ulong >

Re: [PATCH 0/9] Deprecate sysbus_get_default() and get_system_memory() et. al

On 20/09/2022 10:55, Peter Maydell wrote: On Tue, 20 Sept 2022 at 00:18, Bernhard Beschow wrote: In address-spaces.h it can be read that get_system_memory() and get_system_io() are temporary interfaces which "should only be used temporarily until a proper bus interface is available". This sta

[PULL 03/15] .gitlab-ci.d/windows.yml: Drop the sed processing in the 64-bit build

From: Bin Meng The sed processing of build/config-host.mak seems to be no longer needed, and there is no such in the 32-bit build too. Drop it. Signed-off-by: Bin Meng Message-Id: <20220908132817.1831008-5-bmeng...@gmail.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth ---

Re: [PULL 0/3] hmp queue

On 15/09/2022 17.46, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" The following changes since commit 79dfa177ae348bb5ab5f97c0915359b13d6186e2: Merge tag 'pull-qapi-2022-09-07' of git://repo.or.cz/qemu/armbru into staging (2022-09-07 13:13:30 -0400) are available in t

[PULL 05/15] qtest/fuzz-lsi53c895a-test: set guest RAM to 2G

From: Mauro Matteo Cascella test_lsi_do_msgout_cancel_req does not run on machines with small size memory. Reduce guest memory from 4G to 2G to alleviate the problem. Reported-by: Bin Meng Signed-off-by: Mauro Matteo Cascella Message-Id: <20220902133853.834065-1-mcasc...@redhat.com> Reviewed-b

[PULL 00/15] Testing, qga and misc patches

The following changes since commit d29201ff34a135cdfc197f4413c1c5047e4f58bb: Merge tag 'pull-hmp-20220915a' of https://gitlab.com/dagrh/qemu into staging (2022-09-17 10:31:11 -0400) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2022-09-20 for y

[PULL 09/15] bios-tables-test: Sort all x86_64 tests by machine type

From: Juan Quintela No code change here, just move test around. Signed-off-by: Juan Quintela Message-Id: <20220902173452.1904-3-quint...@redhat.com> Reviewed-by: Ani Sinha Signed-off-by: Thomas Huth --- tests/qtest/bios-tables-test.c | 60 +++--- 1 file changed, 3

Re: [PATCH v2 29/66] target/arm: Introduce arm_hcr_el2_eff_secstate

On Mon, 22 Aug 2022 at 17:22, Richard Henderson wrote: > > For page walking, we may require HCR for a security state > that is not "current". > > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h| 20 +--- > target/arm/helper.c | 11 --- > 2 files changed, 21

[PULL 04/15] tests/qtest: npcm7xx-emc-test: Skip checking MAC

From: Patrick Venture The register tests walks all the registers to verify they are initially 0 when appropriate. However, if the MAC address is set in the register space, this should not be checked against 0. Reviewed-by: Hao Wu Signed-off-by: Patrick Venture Message-Id: <20220906163138.2831

[PULL 10/15] bios-tables-test: Only run test for machine types compiled in

From: Juan Quintela Signed-off-by: Juan Quintela Message-Id: <20220902173452.1904-4-quint...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- tests/qtest/bios-tables-test.c | 145 ++--- 1 file changed, 78 insertions(+), 67 deletions(-)

Re: [PATCH v2 30/66] target/arm: Hoist read of *is_secure in S1_ptw_translate

On Mon, 22 Aug 2022 at 16:55, Richard Henderson wrote: > > Rename the argument to is_secure_ptr, and introduce a > local variable is_secure with the value. We only write > back to the pointer toward the end of the function. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thank

Re: [PATCH] virtio: add VIRTQUEUE_ERROR QAPI event

On 9/20/22 17:47, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: For now we only log the vhost device error, when virtqueue is actually stopped. Let's add a QAPI event, which makes possible: - collect statistics of such errors - make immediate actions: take coredums or do s

[PULL 07/15] meson-build: Enable CONFIG_REPLICATION only when replication is set

From: Juan Quintela Signed-off-by: Juan Quintela Message-Id: <20220902165126.1482-8-quint...@redhat.com> Signed-off-by: Thomas Huth --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index c2adb7caf4..3885fc1076 100644 --- a/meson.buil

Re: [PATCH] virtio: add VIRTQUEUE_ERROR QAPI event

On Tue, Sep 20, 2022 at 06:10:08PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 9/20/22 17:47, Markus Armbruster wrote: > > Vladimir Sementsov-Ogievskiy writes: > > > > > For now we only log the vhost device error, when virtqueue is actually > > > stopped. Let's add a QAPI event, which makes p

[PULL 15/15] qga: Replace 'blacklist' and 'whitelist' in the guest agent sources

Let's use better, more inclusive wording here. Message-Id: <20220727092135.302915-3-th...@redhat.com> Reviewed-by: Daniel P. Berrangé Reviewed-by: Konstantin Kostiuk Signed-off-by: Thomas Huth --- qga/qapi-schema.json | 4 +-- qga/guest-agent-core.h | 2 +- qga/commands-posix.c | 16

Re: [PATCH v2 18/66] target/arm: Add secure parameter to get_phys_addr_pmsav7

On Mon, 22 Aug 2022 at 16:58, Richard Henderson wrote: > > Remove the use of regime_is_secure from get_phys_addr_pmsav7, > using the new parameter instead. > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

[PULL 12/15] tests: sb16 has both pc and q35 tests

From: Juan Quintela Check that the machines are compiled in before calling it Signed-off-by: Juan Quintela Message-Id: <20220902173452.1904-6-quint...@redhat.com> Signed-off-by: Thomas Huth --- tests/qtest/fuzz-sb16-test.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff

[PULL 06/15] tests: Fix error strings

From: Juan Quintela They were copy-pasted from e1000e and never changed. Signed-off-by: Juan Quintela Message-Id: <20220902165126.1482-7-quint...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- tests/qtest/e1000-test.c | 2 +- tests/qtest/es1370-test.c | 2 +-

Re: [PATCH v2 27/66] target/arm: Reorg regime_translation_disabled

On Mon, 22 Aug 2022 at 17:13, Richard Henderson wrote: > > Use a switch on mmu_idx for the a-profile indexes, instead of > three different if's vs regime_el and arm_mmu_idx_is_stage1_of_2. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 28/39] hw/pci-host: pnv_phb{3, 4}: Fix heap out-of-bound access failure

Bin, Since I'll send a ppc pull request shortly, I'll queue up both this and patch 27 via the ppc tree. These are good fixes that are independent of what happens with the 'tests/qtest: Enable running qtest on Windows​' series. Thanks, Daniel On 9/20/22 07:31, Bin Meng wrote: From: Xuzhou C

[PULL 11/15] tests: Only run intel-hda-tests if machine type is compiled in

From: Juan Quintela Signed-off-by: Juan Quintela Message-Id: <20220902173452.1904-5-quint...@redhat.com> Reviewed-by: Ani Sinha Signed-off-by: Thomas Huth --- tests/qtest/intel-hda-test.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/tests/qtest/intel-hda-t

[PATCH 0/1] hw/display: expose linear framebuffer address in Bochs VBE registers

Recently I submitted patches to the SerenityOS project in regard to enhancing the overall abstractions of x86-specific hardware support code in the SerenityOS kernel in preparation for aarch64 support. Then, I moved on to submit another patch to introduce support of the isa-vga device, as we curren

[PULL 13/15] gitlab-ci: Update the FreeBSD 13 job from 13.0 to 13.1

The FreeBSD 13 job in our CI started failing since the python port stopped working after 13.1 has been released. Thus update our CI job to FreeBSD 13.1 to get it working again. Suggested-by: Daniel P. Berrangé Message-Id: <20220920102041.45067-1-th...@redhat.com> Reviewed-by: Daniel P. Berrangé

Re: [PATCH v2 35/66] target/arm: Split out get_phys_addr_disabled

On Mon, 22 Aug 2022 at 18:52, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/ptw.c | 138 +-- > 1 file changed, 74 insertions(+), 64 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

[PATCH 1/1] hw/display: expose linear framebuffer address in Bochs VBE registers

This is quite useful on the isa-vga device, because it lets guest drivers to determine where is the framebuffer located in physical memory instead of blindly hardcoding an address. It also allows future movements of the framebuffer to other locations. Signed-off-by: Liav Albani --- hw/display/bo

Re: [PATCH v2 28/66] target/arm: Drop secure check for HCR.TGE vs SCTLR_EL1.M

On Mon, 22 Aug 2022 at 16:50, Richard Henderson wrote: > > The effect of TGE does not only apply to non-secure state, > now that Secure EL2 exists. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 31/66] target/arm: Fix S2 disabled check in S1_ptw_translate

On Mon, 22 Aug 2022 at 17:23, Richard Henderson wrote: > > Pass the correct stage2 mmu_idx to regime_translation_disabled, > which we computed afterward. > > Signed-off-by: Richard Henderson > --- > target/arm/ptw.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/ta

Re: [PATCH v2 26/66] target/arm: Fold secure and non-secure a-profile mmu indexes

On Mon, 22 Aug 2022 at 18:13, Richard Henderson wrote: > > For a-profile, which does not bank system registers, 32-bit A-profile has a pile of banked system registers... > it takes > quite a lot of code to switch between security states. In the > process, registers such as TCR_EL{1,2} must be s

Re: [PULL 0/4] Merge tpm 2022/09/13 v1

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes.

Re: [PATCH] chardev: fix segfault in finalize

Hi!Could you send a pull request? 26.08.2022, 11:21, "Marc-André Lureau" :Hi  On Thu, Aug 25, 2022 at 9:02 PM Maksim Davydov wrote:If finalize chardev-msmouse or chardev-wctable is called immediately afterinit it cases QEMU to crash with segfault. This happens because o

Re: Maximum QMP reply size

* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Thu, 15 Sept 2022 at 16:21, Dr. David Alan Gilbert > wrote: > > > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > > On Tue, 6 Sept 2022 at 20:41, John Snow wrote: > > > > Hi, I suspect I have asked this before, but I didn't write it d

Re: [PATCH v2 34/66] target/arm: Fix ATS12NSO* from S PL1

On Mon, 22 Aug 2022 at 17:50, Richard Henderson wrote: > > Use arm_hcr_el2_eff_secstate instead of arm_hcr_el2_eff, so > that we use is_state instead of the currend security state. "is_secure", "current" > These AT* operations have been broken since arm_hcr_el2_eff > gained a check for "el2 enab

Re: [PATCH v2 33/66] target/arm: Pass HCR to attribute subroutines.

On Mon, 22 Aug 2022 at 17:43, Richard Henderson wrote: > > These subroutines did not need ENV for anything except > retrieving the effective value of HCR anyway. > > We have computed the effective value of HCR in the callers, > and this will be especially important for interpreting HCR > in a non-

[PULL 02/30] tests/avocado/boot_linux_console: Fix the test_aarch64_xlnx_versal_virt test

From: Thomas Huth The assets that this test tries to download have been removed from the server. Update to a newer version to get it working again. Signed-off-by: Thomas Huth Reviewed-by: Alistair Francis Message-Id: <20220829080940.110831-1-th...@redhat.com> Signed-off-by: Alex Bennée Messag

[PULL 01/30] gitlab: reduce targets in cross_user_build_job

We already limit the scope of the cross system build to reduce the cross build times. With the recent addition of more targets we are also running into timeout issues for some of the cross user builds. I've selected a few of those linux-user targets which are less likely to be in common use as dis

Re: [PATCH v2 32/66] target/arm: Remove env argument from combined_attrs_fwb

On Mon, 22 Aug 2022 at 17:41, Richard Henderson wrote: > > This value is unused. > > Signed-off-by: Richard Henderson > --- > target/arm/ptw.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/target/arm/ptw.c b/target/arm/ptw.c > index 680139b478..5c6e5eea88 100644 >

Re: [PATCH v2 36/66] target/arm: Reorg get_phys_addr_disabled

On Mon, 22 Aug 2022 at 16:59, Richard Henderson wrote: > > Use a switch. Do not apply memattr or shareability for Stage2 > translations. Make sure to apply HCR_{DC,DCT} only to Regime_EL10, > per the pseudocode in AArch64.S1DisabledOutput. > > Signed-off-by: Richard Henderson > --- > +chec

[PULL 11/30] tests/docker: update and flatten debian-mips64-cross

Update to the latest stable Debian. While we are at it flatten into a single dockerfile. We really don't need the rest of the stuff from the QEMU base image just to compile test images. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-Id: <20220914155950.804707-12-alex.ben...@linaro.o

[PATCH 0/3] fix for two ACPI GTDT physical addresses

The ACPI GTDT table contains two invalid 64-bit physical addresses according to the ACPI spec. 6.5 [1]. Those are the Counter Control Base physical address and the Counter Read Base physical address. Those fields of the GTDT table should be set to 0x if not provided, rather than 0x0

[PATCH 2/3] acpi: arm/virt: build_gtdt: fix invalid 64-bit physical addresses

Per the ACPI 6.5 specification, on the GTDT Table Structure, the Counter Control Block Address and Counter Read Block Address fields of the GTDT table should be set to 0x if not provided, rather than 0x0. Fixes: 41041e57085 ("acpi: arm/virt: build_gtdt: use acpi_table_begin()/acpi

[PATCH 3/3] tests/acpi: virt: update ACPI GTDT binaries

Step 6 & 7 of the bios-tables-test.c documented procedure. Differences between disassembled ASL files for GTDT: @@ -13,14 +13,14 @@ [000h 4]Signature : "GTDT"[Generic Timer Description Table] [004h 0004 4] Table Length : 0060

[PULL 22/30] tests/docker: flatten debian-riscv64-test-cross

Flatten into a single dockerfile and update to match the rest of the test cross compile dockerfiles. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20220914155950.804707-23-alex.ben...@linaro.org> diff --git a/.gitlab-ci.d/container-cross.yml b/.gitlab-ci.d/container-cro

[PULL 29/30] tests/docker: remove FROM qemu/ support from docker.py

We want to migrate from docker.py to building our images directly with docker/podman. Before we get there we need to make sure we don't re-introduce our layered builds so bug out if we see FROM qemu/ in a Dockerfile. Signed-off-by: Alex Bennée Acked-by: Thomas Huth Reviewed-by: Richard Henderson

Re: [PATCH 2/4] target/m68k: increase size of m68k CPU features from uint32_t to uint64_t

On 17/09/2022 13:09, BALATON Zoltan wrote: On Sat, 17 Sep 2022, Mark Cave-Ayland wrote: There are already 32 feature bits in use, so change the size of the m68k CPU features to uint64_t (allong with the associated m68k_feature() functions) to allow up to 64 feature bits to be used. Signed-off-

<    1   2   3   4   >