On Mon, 22 Aug 2022 at 16:44, Richard Henderson <richard.hender...@linaro.org> wrote: > > Retain the existing get_phys_addr interface using > the security state derived from mmu_idx. > > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > diff --git a/target/arm/ptw.c b/target/arm/ptw.c > index c338e2324a..c132d0cada 100644 > --- a/target/arm/ptw.c > +++ b/target/arm/ptw.c > @@ -2282,12 +2282,12 @@ static ARMCacheAttrs combine_cacheattrs(CPUARMState > *env, > * @result: set on translation success. > * @fi: set to fault info if the translation fails > */
This doc comment needs updating to add the new parameter. > -bool get_phys_addr(CPUARMState *env, target_ulong address, > - MMUAccessType access_type, ARMMMUIdx mmu_idx, > - GetPhysAddrResult *result, ARMMMUFaultInfo *fi) > +bool get_phys_addr_with_secure(CPUARMState *env, target_ulong address, > + MMUAccessType access_type, ARMMMUIdx mmu_idx, > + bool is_secure, GetPhysAddrResult *result, > + ARMMMUFaultInfo *fi) > { > ARMMMUIdx s1_mmu_idx = stage_1_mmu_idx(mmu_idx); > - bool is_secure = regime_is_secure(env, mmu_idx); > > if (mmu_idx != s1_mmu_idx) { > /* Otherwise Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM