Re: [PATCH v2 0/4] Add 'q35' machine type to hotplug tests

2022-08-31 Thread Denis V. Lunev
On 29.08.2022 19:01, Michael Labiuk wrote: Add pci bridge setting to run hotplug tests on q35 machine type. Hotplug tests was bounded to 'pc' machine type by commit 7b172333f1b Michael Labiuk (4): tests/x86: Add subtest with 'q35' machine type to device-plug-test tests/x86: Add 'q35' machi

Re: [PATCH] pci: Abort if pci_add_capability fails

2022-08-31 Thread Markus Armbruster
Alex Williamson writes: > On Tue, 30 Aug 2022 13:37:35 +0200 > Markus Armbruster wrote: >>if (!offset) { >>offset = pci_find_space(pdev, size); >>/* out of PCI config space is programming error */ >>assert(offset); >>} else { >>/* V

Re: [PATCH] osdep: Introduce qemu_get_fd() to wrap the common codes

2022-08-31 Thread Guoyi Tu
On 8/18/22 20:58, Christian Schoenebeck wrote: On Donnerstag, 18. August 2022 14:06:04 CEST Guoyi Tu wrote: Ping... Any comments are welcome On 8/12/22 19:01, Guoyi Tu wrote: socket_get_fd() have much the same codes as monitor_fd_param(), so qemu_get_fd() is introduced to implement the common

Re: [PATCH] target/sh4: Fix TB_FLAG_UNALIGN

2022-08-31 Thread Yoshinori Sato
On Tue, 30 Aug 2022 01:10:29 +0900, Richard Henderson wrote: > > On 8/29/22 02:05, BALATON Zoltan wrote: > > On Sun, 28 Aug 2022, Richard Henderson wrote: > >> The value previously chosen overlaps GUSA_MASK. > >> > >> Cc: qemu-sta...@nongnu.org > >> Fixes: 4da06fb3062 ("target/sh4: Implement prct

Re: [PATCH v8 3/7] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls

2022-08-31 Thread Markus Armbruster
Sam Li writes: > Markus Armbruster 于2022年8月30日周二 19:57写道: >> >> Sam Li writes: >> >> > By adding zone management operations in BlockDriver, storage controller >> > emulation can use the new block layer APIs including Report Zone and >> > four zone management operations (open, close, finish, res

[PATCH 0/2] target/riscv: improvements to GDB target descriptions

2022-08-31 Thread Andrew Burgess
I was running some GDB tests against QEMU, and noticed some oddities with the target description QEMU sends, the following two patches address these issues. Thanks, Andrew --- Andrew Burgess (2): target/riscv: remove fflags, frm, and fcsr from riscv-*-fpu.xml target/riscv: remove fixed numbe

[PATCH 1/2] target/riscv: remove fflags, frm, and fcsr from riscv-*-fpu.xml

2022-08-31 Thread Andrew Burgess
While testing some changes to GDB's handling for the RISC-V registers fcsr, fflags, and frm, I spotted that QEMU includes these registers twice in the target description it sends to GDB, once in the fpu feature, and once in the csr feature. Right now things basically work OK, QEMU maps these regis

[PATCH 2/2] target/riscv: remove fixed numbering from GDB xml feature files

2022-08-31 Thread Andrew Burgess
The fixed register numbering in the various GDB feature files for RISC-V only exists because these files were originally copied from the GDB source tree. However, the fixed numbering only exists in the GDB source tree so that GDB, when it connects to a target that doesn't provide a target descript

Re: [PATCH] osdep: Introduce qemu_get_fd() to wrap the common codes

2022-08-31 Thread Guoyi Tu
On 8/30/22 14:03, Markus Armbruster wrote: Christian Schoenebeck writes: On Donnerstag, 18. August 2022 14:06:04 CEST Guoyi Tu wrote: Ping... Any comments are welcome On 8/12/22 19:01, Guoyi Tu wrote: socket_get_fd() have much the same codes as monitor_fd_param(), so qemu_get_fd() is int

Re: [PATCH v8 3/7] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls

2022-08-31 Thread Sam Li
Markus Armbruster 于2022年8月31日周三 16:35写道: > > Sam Li writes: > > > Markus Armbruster 于2022年8月30日周二 19:57写道: > >> > >> Sam Li writes: > >> > >> > By adding zone management operations in BlockDriver, storage controller > >> > emulation can use the new block layer APIs including Report Zone and > >

Re: [Qemu-devel] [RFC PATCH] Add qemu .clang-format

2022-08-31 Thread Daniel P . Berrangé
On Wed, Aug 31, 2022 at 02:23:51PM +0800, Wang, Lei wrote: > > On 10/2/2015 1:30 AM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > clang-format is awesome to reflow your code according to qemu coding > > style in an editor (in the region you modify). > > > > (note: clan

Re: [PATCH v7 00/14] KVM: mm: fd-based approach for supporting KVM guest private memory

2022-08-31 Thread Fuad Tabba
Hi Chao, Thank you for your reply. On Mon, Aug 29, 2022 at 4:23 PM Chao Peng wrote: > > On Fri, Aug 26, 2022 at 04:19:25PM +0100, Fuad Tabba wrote: > > Hi, > > > > On Wed, Jul 6, 2022 at 9:24 AM Chao Peng > > wrote: > > > > > > This is the v7 of this series which tries to implement the fd-base

Re: [Qemu-devel] [RFC PATCH] Add qemu .clang-format

2022-08-31 Thread Wang, Lei
On 8/31/2022 4:49 PM, Daniel P. Berrangé wrote: On Wed, Aug 31, 2022 at 02:23:51PM +0800, Wang, Lei wrote: On 10/2/2015 1:30 AM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau clang-format is awesome to reflow your code according to qemu coding style in an editor (in the regio

[PATCH v3 01/10] hw/isa/vt82c686: Resolve chip-specific realize methods

2022-08-31 Thread Bernhard Beschow
The object creation now happens in chip-specific init methods which allows the realize methods to be consolidated into one method. Shifting the logic into the init methods has the addidional advantage that the parent object's init methods are called implicitly - like constructors in object-oriented

[PATCH v3 00/10] Instantiate VT82xx functions in host device

2022-08-31 Thread Bernhard Beschow
v3: * Replace pre increment by post increment in for loop (Zoltan) * Move class defines close to where the class is defined (Zoltan) Testing done: * `make check-avocado` Passes for boot_linux_console.py for mips64el_fuloong2e * `qemu-system-ppc -machine pegasos2 -rtc base=localtime -device ati-

[PATCH v3 10/10] hw/isa/vt82c686: Create rtc-time alias in boards instead

2022-08-31 Thread Bernhard Beschow
According to good QOM practice, an object should only deal with objects of its own sub tree. Having devices create an alias on the machine object doesn't respect this good practice. To resolve this, create the alias in the machine's code. Signed-off-by: Bernhard Beschow --- hw/isa/vt82c686.c |

[PATCH v3 05/10] hw/isa/vt82c686: Instantiate IDE function in host device

2022-08-31 Thread Bernhard Beschow
The IDE function is closely tied to the ISA function (e.g. the IDE interrupt routing happens there), so it makes sense that the IDE function is instantiated within the south bridge itself. Signed-off-by: Bernhard Beschow --- configs/devices/mips64el-softmmu/default.mak | 1 - hw/isa/Kconfig

[PATCH v3 06/10] hw/isa/vt82c686: Instantiate USB functions in host device

2022-08-31 Thread Bernhard Beschow
The USB functions can be enabled/disabled through the ISA function. Also its interrupt routing can be influenced there. Signed-off-by: Bernhard Beschow --- hw/isa/vt82c686.c | 12 hw/mips/fuloong2e.c | 3 --- hw/ppc/pegasos2.c | 4 3 files changed, 12 insertions(+), 7 del

[PATCH v3 02/10] hw/isa/vt82c686: Resolve unneeded attribute

2022-08-31 Thread Bernhard Beschow
Now that also the super io device is realized in the common realize method, the isa_bus attribute can be turned into a temporary. Signed-off-by: Bernhard Beschow --- hw/isa/vt82c686.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/isa/vt82c686.c b/hw/isa/

[PATCH v3 04/10] hw/isa/vt82c686: Reuse errp

2022-08-31 Thread Bernhard Beschow
Rather than terminating abruptly, make use of the already present errp and propagate the error to the caller. Signed-off-by: Bernhard Beschow --- hw/isa/vt82c686.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c index 5582c0b179..37

[PATCH v3 03/10] hw/isa/vt82c686: Prefer pci_address_space() over get_system_memory()

2022-08-31 Thread Bernhard Beschow
Unlike get_system_memory(), pci_address_space() respects the memory tree available to the parent device. Signed-off-by: Bernhard Beschow --- hw/isa/vt82c686.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c index 9d12e1cae4..5582c0b179 10

[PATCH v3 07/10] hw/isa/vt82c686: Instantiate PM function in host device

2022-08-31 Thread Bernhard Beschow
The PM controller has activity bits which monitor activity of other built-in devices in the host device. Signed-off-by: Bernhard Beschow --- hw/isa/vt82c686.c | 13 + hw/mips/fuloong2e.c | 2 +- hw/ppc/pegasos2.c | 3 +-- include/hw/isa/vt82c686.h | 2 -- 4 f

[PATCH v3 08/10] hw/isa/vt82c686: Instantiate AC97 and MC97 functions in host device

2022-08-31 Thread Bernhard Beschow
The AC97 function's wakeup status is wired to the PM function and both the AC97 and MC97 interrupt routing is determined by the ISA function. Signed-off-by: Bernhard Beschow --- hw/isa/vt82c686.c | 16 hw/mips/fuloong2e.c | 4 hw/ppc/pegasos2.c | 5 - 3 files chan

Re: [PATCH v2 06/10] hw/isa/vt82c686: Instantiate USB functions in host device

2022-08-31 Thread BB
Am 31. August 2022 00:33:33 MESZ schrieb BALATON Zoltan : >On Tue, 30 Aug 2022, Bernhard Beschow wrote: >> The USB functions can be enabled/disabled through the ISA function. Also >> its interrupt routing can be influenced there. >> >> Signed-off-by: Bernhard Beschow >> --- >> hw/isa/vt82c686.

[PATCH v3 09/10] hw/isa/vt82c686: Embed RTCState in host device

2022-08-31 Thread Bernhard Beschow
Embed the rtc in the host device, analoguous to the other child devices and analoguous to PIIX4. Signed-off-by: Bernhard Beschow --- hw/isa/vt82c686.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c index 691a467b2c..0ddb04b4

Re: [PATCH v2 07/10] hw/isa/vt82c686: Instantiate PM function in host device

2022-08-31 Thread BB
Am 31. August 2022 00:39:22 MESZ schrieb BALATON Zoltan : >On Tue, 30 Aug 2022, Bernhard Beschow wrote: >> The PM controller has activity bits which monitor activity of other >> built-in devices in the host device. >> >> Signed-off-by: Bernhard Beschow >> --- >> hw/isa/vt82c686.c | 12

Re: [PATCH] tests/x86: Add 'q35' machine type to hotplug tests

2022-08-31 Thread Michael Labiuk
On 8/26/22 15:39, Denis V. Lunev wrote: On 26.08.2022 13:41, Michael Labiuk wrote: +static void test_q35_pci_unplug_request(void) that seems a little bit wrong. we have pcie test and thus the naming should be appropriate. What about test_pcie_unplug_request()? I don't think so. Device type r

Re: [Qemu-devel] [RFC PATCH] Add qemu .clang-format

2022-08-31 Thread Marc-André Lureau
Hi On Wed, Aug 31, 2022 at 10:24 AM Wang, Lei wrote: > > On 10/2/2015 1:30 AM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > clang-format is awesome to reflow your code according to qemu coding > > style in an editor (in the region you modify). > > > > (note: clang-tidy

Re: [Qemu-devel] [RFC PATCH] Add qemu .clang-format

2022-08-31 Thread Daniel P . Berrangé
On Wed, Aug 31, 2022 at 05:18:34PM +0800, Wang, Lei wrote: > > > On 8/31/2022 4:49 PM, Daniel P. Berrangé wrote: > > On Wed, Aug 31, 2022 at 02:23:51PM +0800, Wang, Lei wrote: > > > > > > On 10/2/2015 1:30 AM, marcandre.lur...@redhat.com wrote: > > > > From: Marc-André Lureau > > > > > > > > c

Re: [PATCH 1/2] tpm_emulator: Use latest tpm_ioctl.h from swtpm project

2022-08-31 Thread Marc-André Lureau
On Fri, Aug 26, 2022 at 7:52 PM Stefan Berger wrote: > Use the latest tpm_ioctl.h from upstream swtpm project. > > Signed-off-by: Stefan Berger > Reviewed-by: Marc-André Lureau > --- > backends/tpm/tpm_ioctl.h | 96 +++- > 1 file changed, 76 insertions(+)

Re: [PATCH v1 08/16] qapi: fix example of NIC_RX_FILTER_CHANGED event

2022-08-31 Thread Markus Armbruster
Victor Toso writes: > Example output has an extra ending curly bracket. Fix it. > > Problem was noticed when trying to load the example into python's json > library. > > Signed-off-by: Victor Toso > --- > qapi/net.json | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qap

Re: [PATCH v1 12/16] qapi: fix example of blockdev-add command

2022-08-31 Thread Markus Armbruster
Victor Toso writes: > The example output is setting optional member "backing" with null. > This has no runtime impact. Remove it. > > Problem was noticed when using the example as a test case for Go > bindings. "Fix example" and "problem" implies there's something wrong. "No runtime impact" sou

Re: [PATCH v1 03/16] qapi: fix example of query-spice command

2022-08-31 Thread Markus Armbruster
Victor Toso writes: > Example output has an extra ',' delimiter and a foreign comment > format. Fix it. > > Problem was noticed when trying to load the example into python's json > library. > > Signed-off-by: Victor Toso > --- > qapi/ui.json | 3 +-- > 1 file changed, 1 insertion(+), 2 deletion

Re: [PATCH v1 04/16] qapi: fix example of query-rocker-of-dpa-flows command

2022-08-31 Thread Markus Armbruster
Victor Toso writes: > Example output has an extra ',' delimiter and a foreign comment > format. Fix it. > > Problem was noticed when trying to load the example into python's json > library. > > Signed-off-by: Victor Toso > --- > qapi/rocker.json | 3 +-- > 1 file changed, 1 insertion(+), 2 dele

Re: [PATCH v1 14/16] qapi: fix example of query-migrate command

2022-08-31 Thread Markus Armbruster
Victor Toso writes: > The example's return type has several missing mandatory member names. > Fix it. > > Problem was noticed when using the example as a test case for Go > bindings. > > Signed-off-by: Victor Toso > --- > qapi/migration.json | 56 + >

Re: [PATCH v1 16/16] RFC: add a generator for qapi's examples

2022-08-31 Thread Markus Armbruster
Victor Toso writes: > The goal of this generator is to validate QAPI examples and transform > them into a format that can be used for 3rd party applications to > validate their QAPI/QMP introspection. > > For each Example section, we parse server and client messages into a > python dictionary. Th

Re: [PATCH] audio: exit(1) if audio backend failed to be found or initialized

2022-08-31 Thread Marc-André Lureau
Hi On Tue, Aug 23, 2022 at 10:53 PM Volker Rümelin wrote: > > From: Marc-André Lureau > > > > If you specify a known backend but it isn't compiled in, or failed to > > initialize, you get a simple warning and the "none" backend as a > > fallback, and QEMU runs happily: > > > > $ qemu-system-x86_

Re: [PATCH] pci: Abort if pci_add_capability fails

2022-08-31 Thread Akihiko Odaki
On Wed, Aug 31, 2022 at 5:18 PM Markus Armbruster wrote: > > Alex Williamson writes: > > > On Tue, 30 Aug 2022 13:37:35 +0200 > > Markus Armbruster wrote: > >>if (!offset) { > >>offset = pci_find_space(pdev, size); > >>/* out of PCI config space is programming err

Re: [PATCH v1 12/16] qapi: fix example of blockdev-add command

2022-08-31 Thread Victor Toso
Hi, On Wed, Aug 31, 2022 at 01:40:50PM +0200, Markus Armbruster wrote: > Victor Toso writes: > > > The example output is setting optional member "backing" with null. > > This has no runtime impact. Remove it. > > > > Problem was noticed when using the example as a test case for Go > > bindings. >

[PATCH 2/2] [RfC] expose host-phys-bits to guest

2022-08-31 Thread Gerd Hoffmann
Move "host-phys-bits" property from cpu->host_phys_bits to cpu->env.features[FEAT_KVM_HINTS] (KVM_HINTS_HOST_PHYS_BITS). This has the effect that the guest can see whenever host-phys-bits is turned on or not and act accordingly. Current mode of operation for firmware is to be conservative with ad

[PATCH 0/2] expose host-phys-bits to guest

2022-08-31 Thread Gerd Hoffmann
When the guest (firmware specifically) knows how big the address space actually is it can be used better. Some more background: https://bugzilla.redhat.com/show_bug.cgi?id=2084533 This is a RfC series exposes the information via cpuid. take care, Gerd Gerd Hoffmann (2): [hack] reserve bit

[PATCH 1/2] [hack] reserve bit KVM_HINTS_HOST_PHYS_BITS

2022-08-31 Thread Gerd Hoffmann
The KVM_HINTS_HOST_PHYS_BITS bit indicates that qemu has host-phys-bits turned on. This implies the guest can actually work with the full available physical address space as advertised by CPUID(0x8008). Temporary hack for RfC patch and testing. This change must actually be done in the linux

Re: [PATCH 03/51] block: Unify the get_tmp_filename() implementation

2022-08-31 Thread Marc-André Lureau
Hi Bin On Wed, Aug 24, 2022 at 1:42 PM Bin Meng wrote: > From: Bin Meng > > At present get_tmp_filename() has platform specific implementations > to get the directory to use for temporary files. Switch over to use > g_get_tmp_dir() which works on all supported platforms. > > It "works" quite di

Re: [PATCH 2/2] [RfC] expose host-phys-bits to guest

2022-08-31 Thread Claudio Fontana
Ccing some folks, since we are just now adding host bits awareness through the higher level tools. On 8/31/22 14:50, Gerd Hoffmann wrote: > Move "host-phys-bits" property from cpu->host_phys_bits to > cpu->env.features[FEAT_KVM_HINTS] (KVM_HINTS_HOST_PHYS_BITS). > > This has the effect that the

Re: [PATCH v1 03/16] qapi: fix example of query-spice command

2022-08-31 Thread Victor Toso
Hi, On Wed, Aug 31, 2022 at 01:50:31PM +0200, Markus Armbruster wrote: > Victor Toso writes: > > > Example output has an extra ',' delimiter and a foreign comment > > format. Fix it. > > > > Problem was noticed when trying to load the example into python's json > > library. > > > > Signed-off-by:

Re: [PATCH 04/51] semihosting/arm-compat-semi: Avoid using hardcoded /tmp

2022-08-31 Thread Marc-André Lureau
Hi On Wed, Aug 24, 2022 at 1:54 PM Bin Meng wrote: > From: Bin Meng > > Use g_get_tmp_dir() to get the directory to use for temporary files. > > Signed-off-by: Bin Meng > --- > > semihosting/arm-compat-semi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/semihosti

Re: [PATCH 05/51] tcg: Avoid using hardcoded /tmp

2022-08-31 Thread Marc-André Lureau
Hi On Wed, Aug 24, 2022 at 2:06 PM Bin Meng wrote: > From: Bin Meng > > Use g_get_tmp_dir() to get the directory to use for temporary files. > > Signed-off-by: Bin Meng > --- > > tcg/tcg.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tcg/tcg.c b/tcg/tcg.c > inde

Re: [PATCH 06/51] util/qemu-sockets: Use g_get_tmp_dir() to get the directory for temporary files

2022-08-31 Thread Marc-André Lureau
Hi On Wed, Aug 24, 2022 at 1:59 PM Bin Meng wrote: > From: Bin Meng > > Replace the existing logic to get the directory for temporary files > with g_get_tmp_dir(), which works for win32 too. > > Signed-off-by: Bin Meng > Makes sense to me here, Reviewed-by: Marc-André Lureau > --- > > uti

Re: [PATCH 1/2] [hack] reserve bit KVM_HINTS_HOST_PHYS_BITS

2022-08-31 Thread Michael S. Tsirkin
On Wed, Aug 31, 2022 at 02:50:58PM +0200, Gerd Hoffmann wrote: > The KVM_HINTS_HOST_PHYS_BITS bit indicates that qemu has host-phys-bits > turned on. This implies the guest can actually work with the full > available physical address space as advertised by CPUID(0x8008). > > Temporary hack fo

Re: [PATCH 08/51] block/vvfat: Unify the mkdir() call

2022-08-31 Thread Marc-André Lureau
Hi On Wed, Aug 24, 2022 at 2:20 PM Bin Meng wrote: > From: Bin Meng > > There is a difference in the mkdir() call for win32 and non-win32 > platforms, and currently is handled in the codes with #ifdefs. > > glib provides a portable g_mkdir_with_parents() API and we can use > it to unify the cod

Re: [PATCH 10/51] hw/usb: dev-mtp: Use g_mkdir_with_parents()

2022-08-31 Thread Marc-André Lureau
On Wed, Aug 24, 2022 at 1:48 PM Bin Meng wrote: > From: Bin Meng > > Use the same g_mkdir_with_parents() call to create a directory on > all platforms. > > Same comment as earlier regarding g_mkdir() vs _with_parent(). > Signed-off-by: Bin Meng > --- > > hw/usb/dev-mtp.c | 2 +- > 1 file cha

Re: [PATCH v3 05/10] hw/isa/vt82c686: Instantiate IDE function in host device

2022-08-31 Thread BALATON Zoltan
On Wed, 31 Aug 2022, Bernhard Beschow wrote: The IDE function is closely tied to the ISA function (e.g. the IDE interrupt routing happens there), so it makes sense that the IDE function is instantiated within the south bridge itself. Signed-off-by: Bernhard Beschow --- configs/devices/mips64el-

Re: [PATCH v1 12/16] qapi: fix example of blockdev-add command

2022-08-31 Thread Markus Armbruster
Cc: Kevin for an improved chance of getting any nonsense I might write corrected. Victor Toso writes: > Hi, > > On Wed, Aug 31, 2022 at 01:40:50PM +0200, Markus Armbruster wrote: >> Victor Toso writes: >> >> > The example output is setting optional member "backing" with null. >> > This has no r

Re: [PATCH 03/51] block: Unify the get_tmp_filename() implementation

2022-08-31 Thread Daniel P . Berrangé
On Wed, Aug 31, 2022 at 04:54:41PM +0400, Marc-André Lureau wrote: > Hi Bin > > On Wed, Aug 24, 2022 at 1:42 PM Bin Meng wrote: > > > From: Bin Meng > > > > At present get_tmp_filename() has platform specific implementations > > to get the directory to use for temporary files. Switch over to us

Re: [PATCH 14/51] backends/tpm: Exclude headers and macros that don't exist on win32

2022-08-31 Thread Marc-André Lureau
Hi On Wed, Aug 24, 2022 at 5:26 PM Stefan Berger wrote: > > > On 8/24/22 05:39, Bin Meng wrote: > > From: Bin Meng > > > > These headers and macros do not exist on Windows. Exclude them. > > > > Signed-off-by: Bin Meng > > --- > > > > backends/tpm/tpm_ioctl.h | 4 > > 1 file changed, 4

Re: [PATCH v1 03/16] qapi: fix example of query-spice command

2022-08-31 Thread Markus Armbruster
Victor Toso writes: > Hi, > > On Wed, Aug 31, 2022 at 01:50:31PM +0200, Markus Armbruster wrote: >> Victor Toso writes: >> >> > Example output has an extra ',' delimiter and a foreign comment >> > format. Fix it. >> > >> > Problem was noticed when trying to load the example into python's json >>

Re: [PATCH v3 06/10] hw/isa/vt82c686: Instantiate USB functions in host device

2022-08-31 Thread BALATON Zoltan
On Wed, 31 Aug 2022, Bernhard Beschow wrote: The USB functions can be enabled/disabled through the ISA function. Also its interrupt routing can be influenced there. Signed-off-by: Bernhard Beschow --- hw/isa/vt82c686.c | 12 hw/mips/fuloong2e.c | 3 --- hw/ppc/pegasos2.c | 4 --

Re: [PATCH 19/51] tests/qtest: Build test-filter-{mirror, redirector} cases for posix only

2022-08-31 Thread Marc-André Lureau
On Wed, Aug 24, 2022 at 2:10 PM Bin Meng wrote: > From: Bin Meng > > The test-filter-{mirror,redirector} cases use socketpair() API that > is only available on POSIX and should only be built for POSIX. > It is possible to implement a pretty good alternative, like I did for glib ( https://gitlab

Re: [PATCH 17/51] tests/qtest: Build virtio-net-test for posix only

2022-08-31 Thread Marc-André Lureau
Hi On Wed, Aug 24, 2022 at 2:24 PM Bin Meng wrote: > From: Bin Meng > > All of the virtio-net-test test cases require socketpair() to do the > test setup. > It is possible to implement a pretty good alternative, like I did for glib ( https://gitlab.gnome.org/GNOME/glib/-/blob/main/gio/tests/so

Re: [PATCH v3 08/10] hw/isa/vt82c686: Instantiate AC97 and MC97 functions in host device

2022-08-31 Thread BALATON Zoltan
On Wed, 31 Aug 2022, Bernhard Beschow wrote: The AC97 function's wakeup status is wired to the PM function and both the AC97 and MC97 interrupt routing is determined by the ISA function. Signed-off-by: Bernhard Beschow --- hw/isa/vt82c686.c | 16 hw/mips/fuloong2e.c | 4

Re: [PATCH v1 16/16] RFC: add a generator for qapi's examples

2022-08-31 Thread Victor Toso
Hi, On Wed, Aug 31, 2022 at 02:01:54PM +0200, Markus Armbruster wrote: > Victor Toso writes: > > > The goal of this generator is to validate QAPI examples and transform > > them into a format that can be used for 3rd party applications to > > validate their QAPI/QMP introspection. > > > > For eac

Re: [PATCH 20/51] tests/qtest: i440fx-test: Skip running request_{bios, pflash} for win32

2022-08-31 Thread Marc-André Lureau
Hi On Wed, Aug 24, 2022 at 2:15 PM Bin Meng wrote: > From: Bin Meng > > The request_{bios,pflash} test cases call mmap() which does not > exist on win32. Exclude them. > > We can fairly easily rewrite the create_blob_file() function to be portable though, something like: static char *create_bl

Re: [PATCH v1 12/16] qapi: fix example of blockdev-add command

2022-08-31 Thread Victor Toso
Hi, On Wed, Aug 31, 2022 at 03:16:54PM +0200, Markus Armbruster wrote: > Cc: Kevin for an improved chance of getting any nonsense I might write > corrected. > > Victor Toso writes: > > > Hi, > > > > On Wed, Aug 31, 2022 at 01:40:50PM +0200, Markus Armbruster wrote: > >> Victor Toso writes: > >>

Re: [PATCH 23/51] accel/qtest: Support qtest accelerator for Windows

2022-08-31 Thread Marc-André Lureau
Hi On Wed, Aug 24, 2022 at 2:31 PM Bin Meng wrote: > From: Xuzhou Cheng > > Currently signal SIGIPI [=SIGUSR1] is used to kick the dummy CPU > when qtest accelerator is used. However SIGUSR1 is unsupported on > Windows. To support Windows, we add a QemuSemaphore CPUState::sem > to kick the dumm

Re: [PATCH 24/51] tests/qtest: libqos: Drop inclusion of

2022-08-31 Thread Marc-André Lureau
On Wed, Aug 24, 2022 at 2:43 PM Bin Meng wrote: > From: Xuzhou Cheng > > There is no in the Windows build environment. Actually > this is not needed in the non-win32 builds too. Drop it. > > Signed-off-by: Xuzhou Cheng > Signed-off-by: Bin Meng > Reviewed-by: Marc-André Lureau > --- > >

Re: [PATCH 25/51] tests/qtest: libqos: Rename malloc.h to libqos-malloc.h

2022-08-31 Thread Marc-André Lureau
On Wed, Aug 24, 2022 at 2:22 PM Bin Meng wrote: > From: Xuzhou Cheng > > The qtest/libqos directory is included via the "-I" option to search > for header files when building qtest. Unfortunately the malloc.h has > a name conflict with the standard libc header, leading to a build > failure on th

Re: [RFC PATCH v2] gdbstub: only send stop-reply packets when allowed to

2022-08-31 Thread Matheus Tavares Bernardino
On Wed, 24 Aug 2022 at 14:51, Matheus Tavares Bernardino wrote: > > Instead, let's change gdb_set_stop_cpu() to send stop messages only as a > response to a previous GDB command, also making sure to check that the > command accepts such a reply. > > Signed-off-by: Matheus Tavares Bernardino > -

Re: [PATCH 27/51] tests/qtest: Use send/recv for socket communication

2022-08-31 Thread Marc-André Lureau
Hi On Fri, Aug 26, 2022 at 10:27 PM Thomas Huth wrote: > On 26/08/2022 16.59, Bin Meng wrote: > > On Thu, Aug 25, 2022 at 9:04 PM Thomas Huth wrote: > >> > >> On 24/08/2022 11.40, Bin Meng wrote: > >>> From: Xuzhou Cheng > >>> > >>> Socket communication in the libqtest and libqmp codes uses re

Re: [PATCH 28/51] tests/qtest: libqtest: Exclude the *_fds APIs for win32

2022-08-31 Thread Marc-André Lureau
On Wed, Aug 24, 2022 at 2:38 PM Bin Meng wrote: > From: Bin Meng > > libqmp.c::qmp_fd_vsend_fds() is not available on Windows, hence any > APIs in libqtest that call libqmp.c::qmp_fd_vsend_fds() should be > excluded for win32 too. This includes the following: > > * qtest_qmp_vsend_fds() > *

Re: [PATCH 29/51] tests/qtest: libqtest: Install signal handler via signal()

2022-08-31 Thread Marc-André Lureau
Hi On Wed, Aug 24, 2022 at 2:47 PM Bin Meng wrote: > From: Bin Meng > > At present the codes uses sigaction() to install signal handler with > a flag SA_RESETHAND. Such usage can be covered by the signal() API > that is a simplified interface to the general sigaction() facility. > > Update to u

Re: [PATCH 27/51] tests/qtest: Use send/recv for socket communication

2022-08-31 Thread Daniel P . Berrangé
On Wed, Aug 31, 2022 at 06:05:51PM +0400, Marc-André Lureau wrote: > Hi > > On Fri, Aug 26, 2022 at 10:27 PM Thomas Huth wrote: > > > On 26/08/2022 16.59, Bin Meng wrote: > > > On Thu, Aug 25, 2022 at 9:04 PM Thomas Huth wrote: > > >> > > >> On 24/08/2022 11.40, Bin Meng wrote: > > >>> From: Xu

Re: [PATCH v7 00/14] KVM: mm: fd-based approach for supporting KVM guest private memory

2022-08-31 Thread Kirill A . Shutemov
On Sat, Aug 20, 2022 at 10:15:32PM -0700, Hugh Dickins wrote: > > I will try next week to rework it as shim to top of shmem. Does it work > > for you? > > Yes, please do, thanks. It's a compromise between us: the initial TDX > case has no justification to use shmem at all, but doing it that way >

Re: [PATCH v3 05/10] hw/isa/vt82c686: Instantiate IDE function in host device

2022-08-31 Thread BB
Am 31. August 2022 15:12:26 MESZ schrieb BALATON Zoltan : >On Wed, 31 Aug 2022, Bernhard Beschow wrote: >> The IDE function is closely tied to the ISA function (e.g. the IDE >> interrupt routing happens there), so it makes sense that the IDE >> function is instantiated within the south bridge it

Re: [PATCH v3 06/10] hw/isa/vt82c686: Instantiate USB functions in host device

2022-08-31 Thread BB
Am 31. August 2022 15:23:37 MESZ schrieb BALATON Zoltan : >On Wed, 31 Aug 2022, Bernhard Beschow wrote: >> The USB functions can be enabled/disabled through the ISA function. Also >> its interrupt routing can be influenced there. >> >> Signed-off-by: Bernhard Beschow >> --- >> hw/isa/vt82c686.

Re: [PATCH v3 08/10] hw/isa/vt82c686: Instantiate AC97 and MC97 functions in host device

2022-08-31 Thread BB
Am 31. August 2022 15:24:28 MESZ schrieb BALATON Zoltan : >On Wed, 31 Aug 2022, Bernhard Beschow wrote: >> The AC97 function's wakeup status is wired to the PM function and both >> the AC97 and MC97 interrupt routing is determined by the ISA function. >> >> Signed-off-by: Bernhard Beschow >> -

Re: [PATCH v1 12/16] qapi: fix example of blockdev-add command

2022-08-31 Thread Markus Armbruster
Victor Toso writes: > Hi, > > On Wed, Aug 31, 2022 at 03:16:54PM +0200, Markus Armbruster wrote: >> Cc: Kevin for an improved chance of getting any nonsense I might write >> corrected. >> >> Victor Toso writes: >> >> > Hi, >> > >> > On Wed, Aug 31, 2022 at 01:40:50PM +0200, Markus Armbruster wro

Re: [PATCH v1 16/16] RFC: add a generator for qapi's examples

2022-08-31 Thread Markus Armbruster
Victor Toso writes: > Hi, > > On Wed, Aug 31, 2022 at 02:01:54PM +0200, Markus Armbruster wrote: >> Victor Toso writes: >> >> > The goal of this generator is to validate QAPI examples and transform >> > them into a format that can be used for 3rd party applications to >> > validate their QAPI/QM

Re: [PATCH v3 06/10] hw/isa/vt82c686: Instantiate USB functions in host device

2022-08-31 Thread BALATON Zoltan
On Wed, 31 Aug 2022, BB wrote: Am 31. August 2022 15:23:37 MESZ schrieb BALATON Zoltan : On Wed, 31 Aug 2022, Bernhard Beschow wrote: The USB functions can be enabled/disabled through the ISA function. Also its interrupt routing can be influenced there. Signed-off-by: Bernhard Beschow --- hw/

Re: [PATCH v3 05/10] hw/isa/vt82c686: Instantiate IDE function in host device

2022-08-31 Thread BALATON Zoltan
On Wed, 31 Aug 2022, BB wrote: Am 31. August 2022 15:12:26 MESZ schrieb BALATON Zoltan : On Wed, 31 Aug 2022, Bernhard Beschow wrote: The IDE function is closely tied to the ISA function (e.g. the IDE interrupt routing happens there), so it makes sense that the IDE function is instantiated with

Re: [PATCH v3 06/10] hw/isa/vt82c686: Instantiate USB functions in host device

2022-08-31 Thread BB
Am 31. August 2022 17:03:35 MESZ schrieb BALATON Zoltan : >On Wed, 31 Aug 2022, BB wrote: >> Am 31. August 2022 15:23:37 MESZ schrieb BALATON Zoltan : >>> On Wed, 31 Aug 2022, Bernhard Beschow wrote: The USB functions can be enabled/disabled through the ISA function. Also its interrupt

[RFC PATCH 0/3] CXL Performance Monitoring Unit QEMU emulation.

2022-08-31 Thread Jonathan Cameron via
CXL 3.0 introduces a CXL Performance Monitoring Unit. (13.2 Performance Monitoring) These unit may be present in any CXL component but for now the kernel code only supports them in Type 3 Memory devices. Add basic emulation of such units and instantiate 2 in each CXL Type 3 device. Kernel driver

[RFC PATCH 1/3] hw/mem/cxl-type3: Add MSI/MSIX support

2022-08-31 Thread Jonathan Cameron via
This will be used by several upcoming patch sets so break it out such that it doesn't matter which one lands first. Signed-off-by: Jonathan Cameron --- hw/mem/cxl_type3.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/mem/cxl_type3.c b/hw/mem/cxl_type3.c index e0c1535b73..68d

[RFC PATCH 2/3] hw/cxl: Switch to using an array for CXLRegisterLocator base addresses.

2022-08-31 Thread Jonathan Cameron via
Allows for easier looping over entries when adding CPMU instances. Signed-off-by: Jonathan Cameron --- hw/mem/cxl_type3.c | 8 hw/pci-bridge/cxl_downstream.c | 4 ++-- hw/pci-bridge/cxl_root_port.c | 4 ++-- hw/pci-bridge/cxl_upstream.c | 4 ++-- include/hw/cxl/cxl_pc

[RFC PATCH 3/3] hw/cxl: CXL Performance Monitoring Unit (CPMU) Emulation

2022-08-31 Thread Jonathan Cameron via
CXL 3.0 introduces a CXL Performance Monitoring Unit. Add basic emulation of such units and instantiate 2 in CXL Type 3 devices. Limitations: - Random selection of supported events. - Mixture of fixed purpose and configurable counters is intended to hit some edge cases in the discovery code,

[PATCH v4 00/12] Instantiate VT82xx functions in host device

2022-08-31 Thread Bernhard Beschow
v3: * Fix in comment: AC97 Modem -> MC97 Modem (Zoltan) * Introduce TYPE_VT82C686B_USB_UHCI define (Zoltan) * Introduce TYPE_VIA_IDE define (for consistency) v3: * Replace pre increment by post increment in for loop (Zoltan) * Move class defines close to where the class is defined (Zoltan) Testin

[PATCH v4 03/12] hw/isa/vt82c686: Prefer pci_address_space() over get_system_memory()

2022-08-31 Thread Bernhard Beschow
Unlike get_system_memory(), pci_address_space() respects the memory tree available to the parent device. Signed-off-by: Bernhard Beschow --- hw/isa/vt82c686.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c index 9d12e1cae4..5582c0b179 10

[PATCH v4 01/12] hw/isa/vt82c686: Resolve chip-specific realize methods

2022-08-31 Thread Bernhard Beschow
The object creation now happens in chip-specific init methods which allows the realize methods to be consolidated into one method. Shifting the logic into the init methods has the addidional advantage that the parent object's init methods are called implicitly - like constructors in object-oriented

[PATCH v4 10/12] hw/isa/vt82c686: Instantiate AC97 and MC97 functions in host device

2022-08-31 Thread Bernhard Beschow
The AC97 function's wakeup status is wired to the PM function and both the AC97 and MC97 interrupt routing is determined by the ISA function. Signed-off-by: Bernhard Beschow --- hw/isa/vt82c686.c | 16 hw/mips/fuloong2e.c | 4 hw/ppc/pegasos2.c | 5 - 3 files chan

[PATCH v4 02/12] hw/isa/vt82c686: Resolve unneeded attribute

2022-08-31 Thread Bernhard Beschow
Now that also the super io device is realized in the common realize method, the isa_bus attribute can be turned into a temporary. Signed-off-by: Bernhard Beschow --- hw/isa/vt82c686.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/isa/vt82c686.c b/hw/isa/

[PATCH v4 08/12] hw/isa/vt82c686: Instantiate USB functions in host device

2022-08-31 Thread Bernhard Beschow
The USB functions can be enabled/disabled through the ISA function. Also its interrupt routing can be influenced there. Signed-off-by: Bernhard Beschow --- hw/isa/vt82c686.c | 12 hw/mips/fuloong2e.c | 3 --- hw/ppc/pegasos2.c | 4 3 files changed, 12 insertions(+), 7 del

[PATCH v4 11/12] hw/isa/vt82c686: Embed RTCState in host device

2022-08-31 Thread Bernhard Beschow
Embed the rtc in the host device, analoguous to the other child devices and analoguous to PIIX4. Signed-off-by: Bernhard Beschow --- hw/isa/vt82c686.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c index 91686e9570..48cd4d00

[PATCH v4 04/12] hw/isa/vt82c686: Reuse errp

2022-08-31 Thread Bernhard Beschow
Rather than terminating abruptly, make use of the already present errp and propagate the error to the caller. Signed-off-by: Bernhard Beschow --- hw/isa/vt82c686.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c index 5582c0b179..37

[PATCH v4 06/12] hw/isa/vt82c686: Instantiate IDE function in host device

2022-08-31 Thread Bernhard Beschow
The IDE function is closely tied to the ISA function (e.g. the IDE interrupt routing happens there), so it makes sense that the IDE function is instantiated within the south bridge itself. Signed-off-by: Bernhard Beschow --- configs/devices/mips64el-softmmu/default.mak | 1 - hw/isa/Kconfig

[PATCH v4 12/12] hw/isa/vt82c686: Create rtc-time alias in boards instead

2022-08-31 Thread Bernhard Beschow
According to good QOM practice, an object should only deal with objects of its own sub tree. Having devices create an alias on the machine object doesn't respect this good practice. To resolve this, create the alias in the machine's code. Signed-off-by: Bernhard Beschow --- hw/isa/vt82c686.c |

[PATCH v4 05/12] hw/isa/vt82c686: Introduce TYPE_VIA_IDE define

2022-08-31 Thread Bernhard Beschow
Establishes consistency with other (VIA) devices. Signed-off-by: Bernhard Beschow --- hw/ide/via.c | 2 +- hw/mips/fuloong2e.c | 2 +- hw/ppc/pegasos2.c | 2 +- include/hw/isa/vt82c686.h | 1 + 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/ide/via.c

[PATCH v4 07/12] hw/isa/vt82c686: Introduce TYPE_VT82C686B_USB_UHCI define

2022-08-31 Thread Bernhard Beschow
Suggested-by: BALATON Zoltan Signed-off-by: Bernhard Beschow --- hw/mips/fuloong2e.c| 4 ++-- hw/ppc/pegasos2.c | 4 ++-- hw/usb/vt82c686-uhci-pci.c | 4 ++-- include/hw/isa/vt82c686.h | 1 + 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/hw/mips/fuloong2e.c b/h

[PATCH v4 09/12] hw/isa/vt82c686: Instantiate PM function in host device

2022-08-31 Thread Bernhard Beschow
The PM controller has activity bits which monitor activity of other built-in devices in the host device. Signed-off-by: Bernhard Beschow --- hw/isa/vt82c686.c | 13 + hw/mips/fuloong2e.c | 2 +- hw/ppc/pegasos2.c | 3 +-- include/hw/isa/vt82c686.h | 2 -- 4 f

Re: Any interest in a QEMU emulation BoF at KVM Forum?

2022-08-31 Thread Mark Burton
I am VERY interested in these topics from a Qualcomm perspective. I’ll be there from Tuesday morning, I think a “BoF” would be very helpful … Cheers Mark. On 31/08/2022, 17:20, "Alex Bennée" wrote: WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attac

Re: [PATCH v3 06/10] hw/isa/vt82c686: Instantiate USB functions in host device

2022-08-31 Thread BALATON Zoltan
On Wed, 31 Aug 2022, BB wrote: Am 31. August 2022 17:03:35 MESZ schrieb BALATON Zoltan : On Wed, 31 Aug 2022, BB wrote: Am 31. August 2022 15:23:37 MESZ schrieb BALATON Zoltan : On Wed, 31 Aug 2022, Bernhard Beschow wrote: The USB functions can be enabled/disabled through the ISA function. Al

Re: Any interest in a QEMU emulation BoF at KVM Forum?

2022-08-31 Thread Edgar E. Iglesias
On Wed, Aug 31, 2022 at 03:35:19PM +0100, Alex Bennée wrote: > Hi, > > Given our slowly growing range of TCG emulations and the evident > interest in keeping up with modern processor architectures is it worth > having an emulation focused BoF at the up-coming KVM Forum? Hi Alex, Yes, I'd be int

  1   2   3   >