Re: [RFC] Unable to use qemu-ppc to run 32-bit powerpc executables generated on gcc110 machine

2022-08-12 Thread Pierre Muller
Le 12/08/2022 à 06:16, Thomas Huth a écrit : On 11/08/2022 23.38, Pierre Muller wrote:   I am using qemu to check code generated by Free Pascal compiler for various CPUs.   Recently, this allowed me to find out that Free Pascal was generating wrong instructions, leading to SIGBUS errors

Re: [PATCH] hw/riscv: opentitan: bump opentitan version

2022-08-12 Thread Alistair Francis
On Fri, Aug 12, 2022 at 10:54 AM Wilfred Mallawa wrote: > > From: Wilfred Mallawa > > The following patch updates opentitan to match the new configuration, > as per, lowRISC/opentitan@217a0168ba118503c166a9587819e3811eeb0c0c > > Note: with this patch we now skip the usage of the opentitan > `boot

Re: Missing dll

2022-08-12 Thread Stefan Weil via
Am 12.08.22 um 01:34 schrieb Philippe Mathieu-Daudé: Cc'ing qemu-windows@ team On 10/8/22 23:42, Peter Butler wrote: In x64 win10 I today I d/l QEMU into new directory. Then navigated to that dir and… qemu-system-aarch64 -boot d -cdrom f:\Downloads\debian-11.4.0-arm64-netinst.iso -m 2048

Re: [PATCH v7 00/14] KVM: mm: fd-based approach for supporting KVM guest private memory

2022-08-12 Thread Gupta, Pankaj
This is the v7 of this series which tries to implement the fd-based KVM guest private memory. The patches are based on latest kvm/queue branch commit:     b9b71f43683a (kvm/queue) KVM: x86/mmu: Buffer nested MMU split_desc_cache only by default capacity Introduction In general

Re: [PATCH v3 1/1] os-posix: asynchronous teardown for shutdown on Linux

2022-08-12 Thread Claudio Imbrenda
On Thu, 11 Aug 2022 23:05:52 -0300 Murilo Opsfelder Araújo wrote: > On 8/11/22 11:02, Daniel P. Berrangé wrote: > [...] > >>> Hmm, I was hoping you could just use SIGKILL to guarantee that this > >>> gets killed off. Is SIGKILL delivered too soon to allow for the > >>> main QEMU process to have

[PATCH for-7.1?] Fix some typos in documentation (most of them found by codespell)

2022-08-12 Thread Stefan Weil via
Signed-off-by: Stefan Weil --- docs/about/deprecated.rst | 2 +- docs/specs/acpi_erst.rst| 4 ++-- docs/system/devices/canokey.rst | 8 docs/system/devices/cxl.rst | 12 ++-- 4 files changed, 13 insertions(+), 13 deletions(-) diff --git a/docs/about/deprecat

Re: [RFC] Testing 7.1.0-rc2, qemu-ppc does not give valid disassembly

2022-08-12 Thread Peter Maydell
On Thu, 11 Aug 2022 at 22:26, Pierre Muller wrote: >But as I use machines on which I am not admin, > I needed to compile capstone locally, install it inside my home dir, > and export PKG_CONFIG_PATH to allow the meson configuration > to correctly detect this local installation... Yes, like al

[BUG] Qemu abort with error "kvm_mem_ioeventfd_add: error adding ioeventfd: File exists (17)"

2022-08-12 Thread Hao Wang via
Hi list, When I did some tests in my virtual domain with live-attached virtio deivces, I got a coredump file of Qemu. The error print from qemu is "kvm_mem_ioeventfd_add: error adding ioeventfd: File exists (17)". And the call trace in the coredump file displays as below: #0 0x89acecc8

Re: [PATCH for-7.1?] Fix some typos in documentation (most of them found by codespell)

2022-08-12 Thread Hongren Zheng
On Fri, Aug 12, 2022 at 09:56:42AM +0200, Stefan Weil wrote: > diff --git a/docs/system/devices/canokey.rst b/docs/system/devices/canokey.rst > index c2c58ae3e7..cfa6186e48 100644 > --- a/docs/system/devices/canokey.rst > +++ b/docs/system/devices/canokey.rst > @@ -28,9 +28,9 @@ With the same softw

Re: [PATCH v7 00/14] KVM: mm: fd-based approach for supporting KVM guest private memory

2022-08-12 Thread Nikunj A. Dadhania
On 12/08/22 12:48, Gupta, Pankaj wrote: > >> >> However, fallocate() preallocates full guest memory before starting the >> guest. >> With this behaviour guest memory is *not* demand pinned. Is there a way >> to >> prevent fallocate() from reserving full guest memory? >

[PATCH for-7.1] docs/system/loongarch: Update the LoongArch document

2022-08-12 Thread Xiaojuan Yang
1. Add some information about how to boot the LoongArch virt machine by uefi bios and linux kernel and how to access the source code or binary file. 2. Move the explanation of LoongArch system emulation in the target/loongarch/README to docs/system/loongarch/loongson3.rst Signed-off-by: Xiaojuan

Re: [PATCH 2/3] hw/ssi: fixup coverity issue

2022-08-12 Thread Andrew Jones
On Fri, Aug 12, 2022 at 02:21:40AM +, Wilfred Mallawa wrote: > On Thu, 2022-08-11 at 16:23 +0200, Andrew Jones wrote: > > On Thu, Aug 11, 2022 at 09:02:00AM +1000, Wilfred Mallawa wrote: > > > From: Wilfred Mallawa > > > > > > This patch addresses the coverity issues specified in [1], > > > a

Re: qemu-system-aarch64: Failed to retrieve host CPU features

2022-08-12 Thread Peter Maydell
I've added some more relevant mailing lists to the cc. On Fri, 12 Aug 2022 at 09:45, Vitaly Chikunov wrote: > On Fri, Aug 12, 2022 at 05:14:27AM +0300, Vitaly Chikunov wrote: > > I noticed that we starting to get many errors like this: > > > > qemu-system-aarch64: Failed to retrieve host CPU fe

Re: [PATCH for-7.1] docs/system/loongarch: Update the LoongArch document

2022-08-12 Thread gaosong
On 2022/8/12 下午5:19, Xiaojuan Yang wrote: 1. Add some information about how to boot the LoongArch virt machine by uefi bios and linux kernel and how to access the source code or binary file. 2. Move the explanation of LoongArch system emulation in the target/loongarch/README to docs/system/loon

Re: [PATCH v7 00/14] KVM: mm: fd-based approach for supporting KVM guest private memory

2022-08-12 Thread Gupta, Pankaj
However, fallocate() preallocates full guest memory before starting the guest. With this behaviour guest memory is *not* demand pinned. Is there a way to prevent fallocate() from reserving full guest memory? Isn't the pinning being handled by the corresponding host memory backend with mmu >

Re: [PATCH v2 0/5] hw/smbios: add core_count2 to smbios table type 4

2022-08-12 Thread Michael S. Tsirkin
On Sun, Jul 31, 2022 at 06:21:36PM +0200, Julia Suvorova wrote: > The SMBIOS 3.0 specification provides the ability to reflect over > 255 cores. The 64-bit entry point has been used for a while, but > structure type 4 has not been updated before, so the dmidecode output > looked like this (-smp 280

Re: [PATCH for-7.1?] Fix some typos in documentation (most of them found by codespell)

2022-08-12 Thread Peter Maydell
On Fri, 12 Aug 2022 at 08:59, Stefan Weil via wrote: > > Signed-off-by: Stefan Weil > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH for-7.1?] Fix some typos in documentation (most of them found by codespell)

2022-08-12 Thread Peter Maydell
On Fri, 12 Aug 2022 at 08:59, Stefan Weil via wrote: > > Signed-off-by: Stefan Weil > --- > docs/about/deprecated.rst | 2 +- > docs/specs/acpi_erst.rst| 4 ++-- > docs/system/devices/canokey.rst | 8 > docs/system/devices/cxl.rst | 12 ++-- > 4 files change

Re: [PATCH] tests/unit: fix a -Wformat-trunction warning

2022-08-12 Thread Peter Maydell
On Wed, 10 Aug 2022 at 13:20, wrote: > > From: Marc-André Lureau > > ../tests/test-qobject-input-visitor.c: In function ‘test_visitor_in_list’: > ../tests/test-qobject-input-visitor.c:454:49: warning: ‘%d’ directive output > may be truncated writing between 1 and 10 bytes into a region of size 6

Re: [PATCH] hw/arm/virt-acpi-build: Present the GICR structure properly for GICv4

2022-08-12 Thread Peter Maydell
On Fri, 12 Aug 2022 at 03:20, Zenghui Yu wrote: > > With the introduction of the new TCG GICv4, build_madt() is badly broken > as we do not present any GIC Redistributor structure in MADT for GICv4 > guests, so that they have no idea about where the Redistributor > register frames are. This fixes

Re: add qemu_fdt_setprop_strings() and use it in most places

2022-08-12 Thread Peter Maydell
On Tue, 9 Aug 2022 at 19:57, Ben Dooks wrote: > > Add a helper for qemu_fdt_setprop_strings() to take a set of strings > to put into a device-tree, which removes several open-coded methods > such as setting an char arr[] = {..} or setting char val[] = "str\0str2"; > > This is for hw/arm, hw/mips a

[PULL 1/1] linux-user/aarch64: Reset target data on MADV_DONTNEED

2022-08-12 Thread Laurent Vivier
From: Vitaly Buka aarch64 stores MTE tags in target_date, and they should be reset by MADV_DONTNEED. Signed-off-by: Vitaly Buka Reviewed-by: Richard Henderson Message-Id: <20220711220028.2467290-1-vitalyb...@google.com> [lv: fix code style issues] Signed-off-by: Laurent Vivier --- accel/tcg/

Re: [PATCH for-7.1] cutils: Add missing dyld(3) include on macOS

2022-08-12 Thread Peter Maydell
On Tue, 9 Aug 2022 at 23:22, Philippe Mathieu-Daudé via wrote: > > Commit 06680b15b4 moved qemu_*_exec_dir() to cutils but forgot > to move the macOS dyld(3) include, resulting in the following > error (when building with Homebrew GCC on macOS Monterey 12.4): > > [313/1197] Compiling C object li

[PULL 0/1] Linux user for 7.1 patches

2022-08-12 Thread Laurent Vivier
r/qemu.git tags/linux-user-for-7.1-pull-request for you to fetch changes up to dbbf89751b14aa5d281bad3af273e9ffaae82262: linux-user/aarch64: Reset target data on MADV_DONTNEED (2022-08-11 11:34:17 +0200) Pull request linux-use

[PATCH] osdep: Introduce qemu_get_fd() to wrap the common codes

2022-08-12 Thread Guoyi Tu
socket_get_fd() have much the same codes as monitor_fd_param(), so qemu_get_fd() is introduced to implement the common logic. now socket_get_fd() and monitor_fd_param() directly call this function. Signed-off-by: Guoyi Tu ---  include/qemu/osdep.h |  1 +  monitor/misc.c   | 21 +-

[PATCH] hw/nvme: remove param zoned.auto_transition

2022-08-12 Thread Niklas Cassel via
The intention of the Zoned Namespace Command Set Specification was never to make an automatic zone transition optional. Excerpt from the nvmexpress.org zns mailing list: """ A question came up internally on the differences between ZNS and ZAC/ZBC that asked about when a controller should transitio

Re: [PATCH] riscv: Make semihosting configurable for all privilege modes

2022-08-12 Thread Andrew Jones
On Thu, Aug 11, 2022 at 01:41:04PM -0700, Furquan Shaikh wrote: > Unlike ARM, RISC-V does not define a separate breakpoint type for > semihosting. Instead, it is entirely ABI. Thus, we need an option > to allow users to configure what the ebreak behavior should be for > different privilege levels -

Re: [PATCH] riscv: Make semihosting configurable for all privilege modes

2022-08-12 Thread Peter Maydell
On Thu, 11 Aug 2022 at 21:47, Furquan Shaikh wrote: > > Unlike ARM, RISC-V does not define a separate breakpoint type for > semihosting. Instead, it is entirely ABI. Thus, we need an option > to allow users to configure what the ebreak behavior should be for > different privilege levels - M, S, U,

Re: [PATCH v3 1/1] os-posix: asynchronous teardown for shutdown on Linux

2022-08-12 Thread Murilo Opsfelder Araújo
On 8/12/22 04:26, Claudio Imbrenda wrote: On Thu, 11 Aug 2022 23:05:52 -0300 Murilo Opsfelder Araújo wrote: On 8/11/22 11:02, Daniel P. Berrangé wrote: [...] Hmm, I was hoping you could just use SIGKILL to guarantee that this gets killed off. Is SIGKILL delivered too soon to allow for the ma

[PATCH 1/2] osdeps: Introduce qemu_socketpair()

2022-08-12 Thread tugy
From: Guoyi Tu qemu_socketpair() will create a pair of connected sockets with FD_CLOEXEC set Signed-off-by: Guoyi Tu --- include/qemu/sockets.h | 3 +++ util/osdep.c | 24 2 files changed, 27 insertions(+) diff --git a/include/qemu/sockets.h b/include/qemu/

[PULL 4/5] hw/arm/virt-acpi-build: Present the GICR structure properly for GICv4

2022-08-12 Thread Peter Maydell
From: Zenghui Yu With the introduction of the new TCG GICv4, build_madt() is badly broken as we do not present any GIC Redistributor structure in MADT for GICv4 guests, so that they have no idea about where the Redistributor register frames are. This fixes a Linux guest crash at boot time with AC

[PATCH 0/2] introduce qemu_socketpiar()

2022-08-12 Thread tugy
From: Guoyi Tu introduce qemu_socketpair() to create socket pair fd, and set the close-on-exec flag at default as with the other type of socket does. besides, the live update feature is developing, so it's necessary to do that. Guoyi Tu (2): osdeps: Introduce qemu_socketpair() vhost-user:

[PATCH 2/2] vhost-user: Call qemu_socketpair() instead of socketpair()

2022-08-12 Thread tugy
From: Guoyi Tu set close-on-exec flag on the new opened file descriptors at default Signed-off-by: Guoyi Tu --- hw/display/vhost-user-gpu.c | 3 ++- hw/virtio/vhost-user.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/display/vhost-user-gpu.c b/hw/display/vhost

[PULL 2/5] Fix some typos in documentation (most of them found by codespell)

2022-08-12 Thread Peter Maydell
From: Stefan Weil Signed-off-by: Stefan Weil Reviewed-by: Hongren (Zenithal) Zheng Message-id: 20220812075642.1200578-1...@weilnetz.de Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- docs/about/deprecated.rst | 2 +- docs/specs/acpi_erst.rst| 4 ++-- docs/system/d

[PULL 1/5] target/arm: Don't report Statistical Profiling Extension in ID registers

2022-08-12 Thread Peter Maydell
The newly added neoverse-n1 CPU has ID register values which indicate the presence of the Statistical Profiling Extension, because the real hardware has this feature. QEMU's TCG emulation does not yet implement SPE, though (not even as a minimal stub implementation), so guests will crash if they t

[PULL 5/5] cutils: Add missing dyld(3) include on macOS

2022-08-12 Thread Peter Maydell
From: Philippe Mathieu-Daudé Commit 06680b15b4 moved qemu_*_exec_dir() to cutils but forgot to move the macOS dyld(3) include, resulting in the following error (when building with Homebrew GCC on macOS Monterey 12.4): [313/1197] Compiling C object libqemuutil.a.p/util_cutils.c.o FAILED: libq

[PULL 0/5] target-arm queue

2022-08-12 Thread Peter Maydell
es since commit a6b1c53e79d08a99a28cc3e67a3e1a7c34102d6b: Merge tag 'linux-user-for-7.1-pull-request' of https://gitlab.com/laurent_vivier/qemu into staging (2022-08-10 10:26:57 -0700) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20220812 for y

Re: [PATCH 2/2] vhost-user: Call qemu_socketpair() instead of socketpair()

2022-08-12 Thread Peter Maydell
On Fri, 12 Aug 2022 at 12:44, wrote: > > From: Guoyi Tu > > set close-on-exec flag on the new opened file descriptors at default What goes wrong if we don't do this? The commit message is a good place to explain what bug the commit is fixing, and its consequences. thanks -- PMM

[PULL 3/5] tests/unit: fix a -Wformat-truncation warning

2022-08-12 Thread Peter Maydell
From: Marc-André Lureau ../tests/test-qobject-input-visitor.c: In function ‘test_visitor_in_list’: ../tests/test-qobject-input-visitor.c:454:49: warning: ‘%d’ directive output may be truncated writing between 1 and 10 bytes into a region of size 6 [-Wformat-truncation=] 454 | snprintf

Re: [PATCH v3 1/1] os-posix: asynchronous teardown for shutdown on Linux

2022-08-12 Thread Claudio Imbrenda
On Fri, 12 Aug 2022 08:38:59 -0300 Murilo Opsfelder Araújo wrote: > On 8/12/22 04:26, Claudio Imbrenda wrote: > > On Thu, 11 Aug 2022 23:05:52 -0300 > > Murilo Opsfelder Araújo wrote: > > > >> On 8/11/22 11:02, Daniel P. Berrangé wrote: > >> [...] > > Hmm, I was hoping you could just use

Re: [PATCH 1/2] osdeps: Introduce qemu_socketpair()

2022-08-12 Thread Peter Maydell
On Fri, 12 Aug 2022 at 12:44, wrote: > > From: Guoyi Tu > > qemu_socketpair() will create a pair of connected sockets > with FD_CLOEXEC set > > Signed-off-by: Guoyi Tu > --- > include/qemu/sockets.h | 3 +++ > util/osdep.c | 24 > 2 files changed, 27 insertio

Re: [PATCH v2 2/9] target/arm: Don't add all MIDR aliases for Cortex-R

2022-08-12 Thread Peter Maydell
On Mon, 18 Jul 2022 at 12:54, Tobias Roehmel wrote: > > From: Tobias Röhmel > > Cortex-R52 has the MPUIR register which has the same encoding > has the MIDR alias with opc2=4. So we only add that alias > when we are not realizing a Cortex-R. > > Signed-off-by: Tobias Röhmel > --- > target/arm/h

Re: [PATCH v2 3/9] target/arm: Make RVBAR available for all ARMv8 CPUs

2022-08-12 Thread Peter Maydell
(I've added your rwth-aachen.de address because the quicinc one seems to be bouncing :-( ) On Mon, 18 Jul 2022 at 12:54, Tobias Roehmel wrote: > > From: Tobias Röhmel > > Signed-off-by: Tobias Röhmel Having looked a bit more carefully at the architecture manual, I think this is not complete. I

[PATCH 2/2] target/riscv: fence: reconcile with specification

2022-08-12 Thread Philipp Tomsich
Our decoding of fence-instructions is problematic in respect to the RISC-V ISA specification: - rs and rd are ignored, but need to be 0 - fm is ignored This change adjusts the decode pattern to enfore rs and rd being 0, and validates the fm-field (together with pred/succ for FENCE.TSO) to determin

[PATCH 1/2] target/riscv: fence.i: update decode pattern

2022-08-12 Thread Philipp Tomsich
The RISC-V specification specifies imm12, rs1 and rd to be all-zeros, so we can't ignore these bits when decoding into fence.i. Update the decode pattern to reflect the specification. Signed-off-by: Philipp Tomsich --- target/riscv/insn32.decode | 2 +- 1 file changed, 1 insertion(+), 1 deleti

Re: [PATCH 2/2] target/riscv: fence: reconcile with specification

2022-08-12 Thread Peter Maydell
On Fri, 12 Aug 2022 at 14:17, Philipp Tomsich wrote: > > Our decoding of fence-instructions is problematic in respect to the > RISC-V ISA specification: > - rs and rd are ignored, but need to be 0 > - fm is ignored > > This change adjusts the decode pattern to enfore rs and rd being 0, > and valid

[PATCH v4 1/1] os-posix: asynchronous teardown for shutdown on Linux

2022-08-12 Thread Claudio Imbrenda
This patch adds support for asynchronously tearing down a VM on Linux. When qemu terminates, either naturally or because of a fatal signal, the VM is torn down. If the VM is huge, it can take a considerable amount of time for it to be cleaned up. In case of a protected VM, it might take even longe

[PATCH v2] hw/smbios: support for type 8 (port connector)

2022-08-12 Thread Hal Martin
PATCH v1: add support for SMBIOS type 8 to qemu PATCH v2: incorporate patch v1 feedback and add smbios type=8 to qemu-options internal_reference: internal reference designator external_reference: external reference designator connector_type: hex value for port connector type (see SMBIOS 7.9.2) por

Re: [PATCH 1/2] target/riscv: fence.i: update decode pattern

2022-08-12 Thread Andrew Jones
Please use a cover-letter for multi-patch patch series. On Fri, Aug 12, 2022 at 03:13:03PM +0200, Philipp Tomsich wrote: > The RISC-V specification specifies imm12, rs1 and rd to be all-zeros, > so we can't ignore these bits when decoding into fence.i. > > Update the decode pattern to reflect t

Re: [PATCH 2/2] target/riscv: fence: reconcile with specification

2022-08-12 Thread Andrew Jones
On Fri, Aug 12, 2022 at 03:13:04PM +0200, Philipp Tomsich wrote: > Our decoding of fence-instructions is problematic in respect to the > RISC-V ISA specification: > - rs and rd are ignored, but need to be 0 > - fm is ignored > > This change adjusts the decode pattern to enfore rs and rd being 0, >

Re: [PATCH 1/2] target/riscv: fence.i: update decode pattern

2022-08-12 Thread Philipp Tomsich
On Fri, 12 Aug 2022 at 16:01, Andrew Jones wrote: > > > Update the decode pattern to reflect the specification. > > I got hung-up on this for a bit since there isn't any "must-be-0" fields, Please refer to '“Zifencei” Instruction-Fetch Fence, Version 2.0' in the specification. The encoding diagra

Re: [PATCH v2 1/8] parallels: Out of image offset in BAT leads to image inflation

2022-08-12 Thread Denis V. Lunev
On 11.08.2022 17:00, Alexander Ivanov wrote: When an image is opened, data_end field in BDRVParallelsState is setted as the biggest offset in the BAT plus cluster size. If there is a corrupted offset pointing outside the image, the image size increase accordingly. It potentially leads to attempts

Re: [PATCH 2/2] target/riscv: fence: reconcile with specification

2022-08-12 Thread Philipp Tomsich
Happy to lower it back into the decode file. However, I initially pulled it up into the trans-function to more closely match the ISA specification: there is only one FENCE instruction with 3 arguments (FM, PRED, and SUCC). One might argue that the decode table for "RV32I Base Instruction Set" in th

Re: [PATCH 1/2] target/riscv: fence.i: update decode pattern

2022-08-12 Thread Peter Maydell
On Fri, 12 Aug 2022 at 15:11, Philipp Tomsich wrote: > > On Fri, 12 Aug 2022 at 16:01, Andrew Jones wrote: > > > > > Update the decode pattern to reflect the specification. > > > > I got hung-up on this for a bit since there isn't any "must-be-0" fields, > > Please refer to '“Zifencei” Instructio

Re: [PATCH v2 2/8] parallels: Move BAT entry setting to a separate function

2022-08-12 Thread Denis V. Lunev
On 11.08.2022 17:00, Alexander Ivanov wrote: Will need to set BAT entry in multiple places. Move the code of settings entries and marking relevant blocks dirty to a separate helper parallels_set_bat_entry. The comment and the patch text is ambiguous. You say that we need to set BAT in multiple p

Re: [PATCH v2 3/8] parallels: Replace bdrv_co_pwrite_sync by bdrv_co_flush for BAT flushing

2022-08-12 Thread Denis V. Lunev
Use generic infrastructure for BAT writing in parallels_co_check() On 11.08.2022 17:00, Alexander Ivanov wrote: It's too costly to write all the BAT to the disk. Let the flush function write only dirty blocks. Use parallels_set_bat_entry for setting a BAT entry and marking a relevant block as di

Re: [PATCH for-7.2 v4 02/11] ppc/pnv: add phb-id/chip-id PnvPHB4RootBus properties

2022-08-12 Thread Frederic Barrat
On 11/08/2022 18:39, Daniel Henrique Barboza wrote: The same rationale provided in the PHB3 bus case applies here. Note: we could have merged both buses in a single object, like we did with the root ports, and spare some boilerplate. The reason we opted to preserve both buses objects is twofo

Re: [PATCH for-7.2 v4 03/11] ppc/pnv: set root port chassis and slot using Bus properties

2022-08-12 Thread Frederic Barrat
On 11/08/2022 18:39, Daniel Henrique Barboza wrote: For default root ports we have a way of accessing chassis and slot, before root_port_realize(), via pnv_phb_attach_root_port(). For the future user created root ports this won't be the case: we can't use this helper because we don't have acce

Re: [PATCH v2 4/8] parallels: Move check of unclean image to a separate function

2022-08-12 Thread Denis V. Lunev
On 11.08.2022 17:00, Alexander Ivanov wrote: v2: Revert the condition with s->header_unclean. same comment about change log as previously And commit message misses motivation part, why we are doing this rework. What is the goal of this change? The code part is clean. Signed-off-by: Alexander

Re: [PATCH for-7.2 v4 01/11] ppc/pnv: add phb-id/chip-id PnvPHB3RootBus properties

2022-08-12 Thread Frederic Barrat
On 11/08/2022 18:39, Daniel Henrique Barboza wrote: We rely on the phb-id and chip-id, which are PHB properties, to assign chassis and slot to the root port. For default devices this is no big deal: the root port is being created under pnv_phb_realize() and the values are being passed on via t

Re: [PATCH v2 5/8] parallels: Move check of cluster outside image to a separate function

2022-08-12 Thread Denis V. Lunev
On 11.08.2022 17:00, Alexander Ivanov wrote: v2: Move unrelated helper parallels_set_bat_entry creation to a separate patch. same notes as for previous patch Signed-off-by: Alexander Ivanov --- block/parallels.c | 48 ++- 1 file changed, 35

Re: [PULL 02/28] target/arm: Add coproc parameter to syn_fp_access_trap

2022-08-12 Thread Peter Maydell
On Fri, 10 Jun 2022 at 17:07, Peter Maydell wrote: > > From: Richard Henderson > > With ARMv8, this field is always RES0. > With ARMv7, targeting EL2 and TA=0, it is always 0xA. I was just looking at this change again because we still have the loose end of syn_simd_access_trap() not being used,

Re: [PATCH v2 6/8] parallels: Move check of leaks to a separate function

2022-08-12 Thread Denis V. Lunev
On 11.08.2022 17:00, Alexander Ivanov wrote: v2: No changes. same notes about motivation, changelog as before Signed-off-by: Alexander Ivanov --- block/parallels.c | 85 +-- 1 file changed, 52 insertions(+), 33 deletions(-) diff --git a/block/pa

Re: [PATCH v2 7/8] parallels: Move statistic collection to a separate function

2022-08-12 Thread Denis V. Lunev
On 11.08.2022 17:00, Alexander Ivanov wrote: v2: Move fragmentation counting code to this function too. same note here about ChnageLog and motivation Signed-off-by: Alexander Ivanov --- block/parallels.c | 54 +++ 1 file changed, 31 insertions(+

Re: [PATCH for-7.2 v4 04/11] ppc/pnv: add helpers for pnv-phb user devices

2022-08-12 Thread Frederic Barrat
On 11/08/2022 18:39, Daniel Henrique Barboza wrote: pnv_parent_qom_fixup() and pnv_parent_bus_fixup() are versions of the helpers that were reverted by commit 9c10d86fee "ppc/pnv: Remove user-created PHB{3,4,5} devices". They are needed to amend the QOM and bus hierarchies of user created pnv-

Re: [PATCH for-7.2 v4 05/11] ppc/pnv: turn chip8->phbs[] into a PnvPHB* array

2022-08-12 Thread Frederic Barrat
On 11/08/2022 18:39, Daniel Henrique Barboza wrote: When enabling user created PHBs (a change reverted by commit 9c10d86fee) we were handling PHBs created by default versus by the user in different manners. The only difference between these PHBs is that one will have a valid phb3->chip that is

Re: qemu-system-aarch64: Failed to retrieve host CPU features

2022-08-12 Thread Marc Zyngier
Hi Peter, On Fri, 12 Aug 2022 10:25:55 +0100, Peter Maydell wrote: > > I've added some more relevant mailing lists to the cc. > > On Fri, 12 Aug 2022 at 09:45, Vitaly Chikunov wrote: > > On Fri, Aug 12, 2022 at 05:14:27AM +0300, Vitaly Chikunov wrote: > > > I noticed that we starting to get ma

Re: [PATCH v2 8/8] parallels: Replace qemu_co_mutex_lock by WITH_QEMU_LOCK_GUARD

2022-08-12 Thread Denis V. Lunev
On 11.08.2022 17:00, Alexander Ivanov wrote: Replace the way we use mutex in parallels_co_check() for more clean code. I think that "cleaness" is the same, but new code would be just shorter ;) or less error prone. v2: Fix an incorrect usage of WITH_QEMU_LOCK_GUARD. Signed-off-by: Alexander I

Re: [PATCH v2] hw/smbios: support for type 8 (port connector)

2022-08-12 Thread Michael S. Tsirkin
On Fri, Aug 12, 2022 at 03:51:53PM +0200, Hal Martin wrote: > PATCH v1: add support for SMBIOS type 8 to qemu > PATCH v2: incorporate patch v1 feedback and add smbios type=8 to qemu-options history after --- pls > internal_reference: internal reference designator > external_reference: external re

Re: [PATCH v3 1/4] accel/tcg: Invalidate translations when clearing PAGE_EXEC

2022-08-12 Thread Ilya Leoshkevich
On Thu, 2022-08-11 at 08:42 -0700, Richard Henderson wrote: > On 8/11/22 02:28, Ilya Leoshkevich wrote: > > How is qemu-user's get_page_addr_code() involved here? > > > > I tried to experiment with it, and while I agree that it looks > > buggy, > > it's called only from translation code paths. If

Re: [PATCH v2 0/8] parallels: Refactor the code of images checks and fix a bug

2022-08-12 Thread Denis V. Lunev
On 11.08.2022 17:00, Alexander Ivanov wrote: Fix image inflation when offset in BAT is out of image. Replace whole BAT syncing by flushing only dirty blocks. Move all the checks outside the main check function in separate functions Use WITH_QEMU_LOCK_GUARD for more clean code. Alexander Ivano

Re: qemu-system-aarch64: Failed to retrieve host CPU features

2022-08-12 Thread Marc Zyngier
On Fri, 12 Aug 2022 10:25:55 +0100, Peter Maydell wrote: > > I've added some more relevant mailing lists to the cc. > > On Fri, 12 Aug 2022 at 09:45, Vitaly Chikunov wrote: > > On Fri, Aug 12, 2022 at 05:14:27AM +0300, Vitaly Chikunov wrote: > > > I noticed that we starting to get many errors l

[PATCH] hw/arm/bcm2835_property: Add support for RPI_FIRMWARE_FRAMEBUFFER_GET_NUM_DISPLAYS

2022-08-12 Thread Enrik Berkhan
In more recent Raspbian OS Linux kernels, the fb driver gives up immediately if RPI_FIRMWARE_FRAMEBUFFER_GET_NUM_DISPLAYS fails or no displays are reported. This change simply always reports one display. It makes bcm2835_fb work again with these more recent kernels. Signed-off-by: Enrik Berkhan

Re: [PATCH for-7.2 v4 07/11] ppc/pnv: add PHB4 helpers for user created pnv-phb

2022-08-12 Thread Frederic Barrat
On 11/08/2022 18:39, Daniel Henrique Barboza wrote: The PHB4 backend relies on a link with the corresponding PEC element. This is trivial to do during machine_init() time for default devices, but not so much for user created ones. pnv_phb4_get_pec() is a small variation of the function that w

Re: [PATCH for-7.2 v4 09/11] ppc/pnv: change pnv_phb4_get_pec() to also retrieve chip10->pecs

2022-08-12 Thread Frederic Barrat
On 11/08/2022 18:39, Daniel Henrique Barboza wrote: The function assumes that we're always dealing with a PNV9_CHIP() object. This is not the case when the pnv-phb device belongs to a powernv10 machine. Change pnv_phb4_get_pec() to be able to work with PNV10_CHIP() if necessary. Signed-off-b

Re: [PATCH for-7.2 v4 10/11] ppc/pnv: user creatable pnv-phb for powernv10

2022-08-12 Thread Frederic Barrat
On 11/08/2022 18:39, Daniel Henrique Barboza wrote: Given that powernv9 and powernv10 uses the same pnv-phb backend, the logic to allow user created pnv-phbs for powernv10 is already in place. Let's flip the switch. Reviewed-by: Cédric Le Goater Signed-off-by: Daniel Henrique Barboza ---

Re: [BUG] cxl can not create region

2022-08-12 Thread Jonathan Cameron via
On Thu, 11 Aug 2022 18:08:57 +0100 Jonathan Cameron via wrote: > On Tue, 9 Aug 2022 17:08:25 +0100 > Jonathan Cameron wrote: > > > On Tue, 9 Aug 2022 21:07:06 +0800 > > Bobo WL wrote: > > > > > Hi Jonathan > > > > > > Thanks for your reply! > > > > > > On Mon, Aug 8, 2022 at 8:37 PM Jonat

Re: [RFC v2 00/10] Introduce an extensible static analyzer

2022-08-12 Thread Alberto Faria
On Thu, Aug 4, 2022 at 12:44 PM Marc-André Lureau wrote: > Hi > > Great work so far! This seems easier to hack than my attempt to use > clang-tidy to write some qemu checks > (https://github.com/elmarco/clang-tools-extra) > > The code seems quite generic, I wonder if such a tool in python wasn't >

Re: [RFC v2 02/10] Drop unused static function return values

2022-08-12 Thread Alberto Faria
On Wed, Aug 3, 2022 at 1:30 PM Peter Maydell wrote: > The problem with a patch like this is that it rolls up into a > single patch changes to the API of many functions in multiple > subsystems across the whole codebase. Some of those changes > might be right; some might be wrong. No single person

Re: [PATCH for-7.2 v4 11/11] ppc/pnv: fix QOM parenting of user creatable root ports

2022-08-12 Thread Frederic Barrat
On 11/08/2022 18:39, Daniel Henrique Barboza wrote: User creatable root ports are being parented by the 'peripheral' or the 'peripheral-anon' container. This happens because this is the regular QOM schema for sysbus devices that are added via the command line. Let's make this QOM hierarchy si

Re: [BUG] cxl can not create region

2022-08-12 Thread Dan Williams
Jonathan Cameron wrote: > On Thu, 11 Aug 2022 18:08:57 +0100 > Jonathan Cameron via wrote: > > > On Tue, 9 Aug 2022 17:08:25 +0100 > > Jonathan Cameron wrote: > > > > > On Tue, 9 Aug 2022 21:07:06 +0800 > > > Bobo WL wrote: > > > > > > > Hi Jonathan > > > > > > > > Thanks for your reply! >

Re: [PATCH for-7.2 v4 08/11] ppc/pnv: enable user created pnv-phb for powernv9

2022-08-12 Thread Frederic Barrat
On 11/08/2022 18:39, Daniel Henrique Barboza wrote: Enable pnv-phb user created devices for powernv9 now that we have everything in place. Reviewed-by: Cédric Le Goater Signed-off-by: Daniel Henrique Barboza --- Same comment as in patch 6 regarding the QOM relationship of the user-creat

Re: [BUG] cxl can not create region

2022-08-12 Thread Jonathan Cameron via
On Fri, 12 Aug 2022 09:03:02 -0700 Dan Williams wrote: > Jonathan Cameron wrote: > > On Thu, 11 Aug 2022 18:08:57 +0100 > > Jonathan Cameron via wrote: > > > > > On Tue, 9 Aug 2022 17:08:25 +0100 > > > Jonathan Cameron wrote: > > > > > > > On Tue, 9 Aug 2022 21:07:06 +0800 > > > > Bobo WL

Re: [PATCH for-7.2 v4 06/11] ppc/pnv: enable user created pnv-phb for powernv8

2022-08-12 Thread Frederic Barrat
On 11/08/2022 18:39, Daniel Henrique Barboza wrote: The bulk of the work was already done by previous patches. Use defaults_enabled() to determine whether we need to create the default devices or not. Reviewed-by: Cédric Le Goater Signed-off-by: Daniel Henrique Barboza --- The QOM relat

Re: [RFC v2 02/10] Drop unused static function return values

2022-08-12 Thread Alberto Faria
On Wed, Aug 3, 2022 at 12:15 PM Richard W.M. Jones wrote: > If it helps to think about this, Coverity checks for consistency. > Across the whole code base, is the return value of a function used or > ignored consistently. You will see Coverity errors like: > > Error: CHECKED_RETURN (CWE-252

Re: [PATCH 00/62] target/arm: Implement FEAT_HAFDBS

2022-08-12 Thread Peter Maydell
On Sun, 3 Jul 2022 at 09:25, Richard Henderson wrote: > > This is a major reorg to arm page table walking. While the result > here is "merely" Hardware-assited Access Flag and Dirty Bit Setting > (HAFDBS), the ultimate goal is the Realm Management Extension (RME). > RME "recommends" that HAFDBS b

[PATCH] target/arm: Rearrange cpu64.c so all the CPU initfns are together

2022-08-12 Thread Peter Maydell
cpu64.c has ended up in a slightly odd order -- it starts with the initfns for most of the models-real-hardware CPUs; after that comes a bunch of support code for SVE, SME, pauth and LPA2 properties. Then come the initfns for the 'host' and 'max' CPU types, and then after that one more models-real

Re: [PULL 0/1] Linux user for 7.1 patches

2022-08-12 Thread Richard Henderson
:17 +0200) Pull request linux-user 20220812 Applied, thanks. Please update https://wiki.qemu.org/ChangeLog/7.1 as appropriate. r~ Vitaly Buka (1): linux-user/aarch64: Reset target data on MADV_DONTNEED accel/tcg

Re: [PATCH 00/62] target/arm: Implement FEAT_HAFDBS

2022-08-12 Thread Richard Henderson
On 8/12/22 09:31, Peter Maydell wrote: Is it possible to rearrange this patchset so the easy refactoring patches that do "use a struct to return values from get_phys_addr and friends" are at the front (ie before the stuff that touches core code) ? That way they're easy to take into the tree early

Re: [PATCH v3 1/4] accel/tcg: Invalidate translations when clearing PAGE_EXEC

2022-08-12 Thread Richard Henderson
On 8/12/22 08:02, Ilya Leoshkevich wrote: tb_lookup() skips get_page_addr_code() if tb is found in tb_jmp_cache. I assume it's a bug? Yes, I think so. I've rearranged that for other reasons, and so may have inadvertently fix this. I'll post the in-progress work in a moment. r~

[PATCH for-7.2 00/21] accel/tcg: minimize tlb lookups during translate + user-only PROT_EXEC fixes

2022-08-12 Thread Richard Henderson
This is part of a larger body of work, but in the process of reorganizing I was reminded that PROT_EXEC wasn't being enforced properly for user-only. As this has come up in the context of some of Ilya's patches, I thought I'd go ahead and post this part. r~ Ilya Leoshkevich (1): accel/tcg: I

[PATCH for-7.2 05/21] tests/tcg/i386: Move smc_code2 to an executable section

2022-08-12 Thread Richard Henderson
We're about to start validating PAGE_EXEC, which means that we've got to put this code into a section that is both writable and executable. Note that this test did not run on hardware beforehand either. Signed-off-by: Richard Henderson --- tests/tcg/i386/test-i386.c | 2 +- 1 file changed, 1 in

[PATCH for-7.2 01/21] linux-user/arm: Mark the commpage executable

2022-08-12 Thread Richard Henderson
We're about to start validating PAGE_EXEC, which means that we've got to mark the commpage executable. We had been placing the commpage outside of reserved_va, which was incorrect and lead to an abort. Signed-off-by: Richard Henderson --- linux-user/arm/target_cpu.h | 4 ++-- linux-user/elfload

[PATCH for-7.2 18/21] accel/tcg: Remove translator_ldsw

2022-08-12 Thread Richard Henderson
The only user can easily use translator_lduw and adjust the type to signed during the return. Signed-off-by: Richard Henderson --- include/exec/translator.h | 1 - target/i386/tcg/translate.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/exec/translator.h b/incl

[PATCH for-7.2 04/21] linux-user: Honor PT_GNU_STACK

2022-08-12 Thread Richard Henderson
Map the stack executable if required by default or on demand. Signed-off-by: Richard Henderson --- include/elf.h| 1 + linux-user/qemu.h| 1 + linux-user/elfload.c | 19 ++- 3 files changed, 20 insertions(+), 1 deletion(-) diff --git a/include/elf.h b/include/elf.h

[PATCH for-7.2 02/21] linux-user/hppa: Allocate page zero as a commpage

2022-08-12 Thread Richard Henderson
We're about to start validating PAGE_EXEC, which means that we've got to mark page zero executable. We had been special casing this entirely within translate. Signed-off-by: Richard Henderson --- linux-user/elfload.c | 34 +++--- 1 file changed, 31 insertions(+), 3 d

[PATCH for-7.2 03/21] linux-user/x86_64: Allocate vsyscall page as a commpage

2022-08-12 Thread Richard Henderson
We're about to start validating PAGE_EXEC, which means that we've got to the vsyscall page executable. We had been special casing this entirely within translate. Signed-off-by: Richard Henderson --- linux-user/elfload.c | 21 + 1 file changed, 21 insertions(+) diff --git a/

[PATCH for-7.2 08/21] accel/tcg: Merge tb_htable_lookup into caller

2022-08-12 Thread Richard Henderson
This function is used only once, so merge it into its only caller, tb_lookup. This requires moving the support routine, tb_lookup_cmp, and its private data structure, tb_desc, up in the file. Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 3 - accel/tcg/cpu-exec.c| 134 +++

[PATCH for-7.2 07/21] accel/tcg: Use bool for page_find_alloc

2022-08-12 Thread Richard Henderson
Bool is more appropriate type for the alloc parameter. Signed-off-by: Richard Henderson --- accel/tcg/translate-all.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index cf99b2b876..65a23f47d6 100644 --- a

[PATCH for-7.2 06/21] accel/tcg: Remove PageDesc code_bitmap

2022-08-12 Thread Richard Henderson
This bitmap is created and discarded immediately. We gain nothing by its existence. Signed-off-by: Richard Henderson --- accel/tcg/translate-all.c | 78 ++- 1 file changed, 4 insertions(+), 74 deletions(-) diff --git a/accel/tcg/translate-all.c b/accel/tcg/tr

  1   2   >