Re: [PATCH] acpi/nvdimm: Define trace events for NVDIMM and substitute nvdimm_debug()

2022-07-18 Thread Robert Hoo
On Thu, 2022-07-07 at 11:21 +0200, Igor Mammedov wrote: > On Mon, 4 Jul 2022 16:58:52 +0800 > Robert Hoo wrote: > > > Signed-off-by: Robert Hoo > > Reviewed-by: Jingqi Liu > > Reviewed-by: Igor Mammedov Thanks for review Igor. BTW, during the unit test, I met some bios-table test error, ht

Re: [RFC PATCH 01/12] vhost: Get vring base from vq, not svq

2022-07-18 Thread Eugenio Perez Martin
On Mon, Jul 18, 2022 at 7:48 AM Jason Wang wrote: > > On Sat, Jul 16, 2022 at 7:34 PM Eugenio Pérez wrote: > > > > The SVQ vring used idx usually match with the guest visible one, as long > > as all the guest buffers (GPA) maps to exactly one buffer within qemu's > > VA. However, as we can see in

Re: [RFC PATCH 02/12] vhost: Move SVQ queue rewind to the destination

2022-07-18 Thread Eugenio Perez Martin
On Mon, Jul 18, 2022 at 7:50 AM Jason Wang wrote: > > On Sat, Jul 16, 2022 at 7:34 PM Eugenio Pérez wrote: > > > > Migration with SVQ already migrate the inflight descriptors, > > How is this done? > Migration between vhost-vdpa with x-svq=on maintain the guest's visible state in VirtQueues, and

Re: [RFC PATCH 03/12] vdpa: Small rename of error labels

2022-07-18 Thread Eugenio Perez Martin
On Mon, Jul 18, 2022 at 7:50 AM Jason Wang wrote: > > On Sat, Jul 16, 2022 at 7:34 PM Eugenio Pérez wrote: > > > > So later patches are cleaner > > > > Signed-off-by: Eugenio Pérez > > --- > > hw/virtio/vhost-vdpa.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --g

Re: Building tools on unsupported cpu/arch

2022-07-18 Thread Thomas Huth
On 30/04/2022 16.11, Michael Tokarev wrote: Hello! Previously, it was possible to build qemu tools (such as qemu-img, or qemu-ga) on an unsupported cpu/architecture.  In a hackish way, by specifying --enable-tcg-interpreter on the ./configure line. Today (with 7.0), it does not work anymore, wi

RE: [PATCH] i386: Disable BTS and PEBS

2022-07-18 Thread Duan, Zhenzhong
>-Original Message- >From: Like Xu >Sent: Monday, July 18, 2022 11:57 AM >To: Duan, Zhenzhong >Cc: pbonz...@redhat.com; mtosa...@redhat.com; Christopherson,, Sean >; Ma, XiangfeiX ; qemu- >de...@nongnu.org >Subject: Re: [PATCH] i386: Disable BTS and PEBS > >On 18/7/2022 11:22 am, Zhenzh

Re: [PATCH v4 00/12] Improve reliability of VM tests

2022-07-18 Thread Thomas Huth
On 12/07/2022 20.34, John Snow wrote: On Fri, Jul 8, 2022 at 11:35 AM John Snow wrote: Note: patches 10-12 are included for testing simplicity, they shouldn't be merged. They will be included in a forthcoming block PR. Patches 1-9 are fully reviewed. Whose tree should this go in? I can tak

Re: [PATCH v4 00/12] Improve reliability of VM tests

2022-07-18 Thread Thomas Huth
On 08/07/2022 17.34, John Snow wrote: Note: patches 10-12 are included for testing simplicity, they shouldn't be merged. They will be included in a forthcoming block PR. V4: - Addressed concern by Marc-Andre in patch 01. - Squashed Ubuntu patches (rth) This patch series attempts to improve the

[PATCH] x86: cpu: Error out if memory exceeds addressable range

2022-07-18 Thread Nikunj A Dadhania
Currently it is possible to start a guest with memory that is beyond the addressable range of CPU and QEMU does not even warn about it. The default phys_bits is 40 and can address 1TB. However it allows to start a guest with greater than 1TB memory. Prevent this by erroring out in such a scenario.

Re: [PATCH 1/4] Modifying ‘migrate’ qmp command to add multi-FD socket on particular source and destination pair

2022-07-18 Thread Markus Armbruster
Het Gala writes: > i) Modified the format of the qemu monitor command : 'migrate' by adding a > list, >each element in the list consists of multi-FD connection parameters: source >and destination uris and of the number of multi-fd channels between each > pair. > > ii) Information of all

Re: [RFC PATCH 8/8] block: remove all unused ->can_set_aio_ctx and ->set_aio_ctx callbacks

2022-07-18 Thread Emanuele Giuseppe Esposito
Am 15/07/2022 um 16:34 schrieb Hanna Reitz: > On 12.07.22 23:19, Emanuele Giuseppe Esposito wrote: >> Together with all _can_set_ and _set_ APIs, as they are not needed >> anymore. >> >> Signed-off-by: Emanuele Giuseppe Esposito >> --- >>   block.c    | 196 -

Re: [RFC PATCH 3/8] RFC: block: use transactions as a replacement of ->{can_}set_aio_context()

2022-07-18 Thread Emanuele Giuseppe Esposito
Am 14/07/2022 um 18:45 schrieb Hanna Reitz: > On 12.07.22 23:19, Emanuele Giuseppe Esposito wrote: >> - >> RFC because I am not sure about the AioContext locks. >> - Do we need to take the new AioContext lock? what does it protect? >> - Taking the old AioContext lock is required now, bec

[PATCH v2 0/1] MAINTAINERS: Add myself as Guest Agent co-maintainer

2022-07-18 Thread Konstantin Kostiuk
v1 -> v2: Rebase to current master v1: https://patchew.org/QEMU/20220713133249.2229623-1-kkost...@redhat.com/ Konstantin Kostiuk (1): MAINTAINERS: Add myself as Guest Agent co-maintainer MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1

[PATCH v2 1/1] MAINTAINERS: Add myself as Guest Agent co-maintainer

2022-07-18 Thread Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk Acked-by: Michael Roth --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index ead2bed652..6af9cd985c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2881,7 +2881,7 @@ T: git https://repo.or.cz/qemu/armb

Re: [RFC PATCH 07/12] vhost: Add VhostVDPAStartOp operation

2022-07-18 Thread Jason Wang
On Sat, Jul 16, 2022 at 7:34 PM Eugenio Pérez wrote: > > It allows to run commands at start of the device, before it have enabled > any queue. > > Signed-off-by: Eugenio Pérez > --- > hw/virtio/vhost-shadow-virtqueue.h | 3 +++ > include/hw/virtio/vhost-vdpa.h | 5 + > hw/virtio/vhost-vd

Re: [RFC PATCH 09/12] vdpa: Extract vhost_vdpa_net_svq_add from vhost_vdpa_net_handle_ctrl_avail

2022-07-18 Thread Jason Wang
在 2022/7/16 19:34, Eugenio Pérez 写道: So we can reuse to inject state messages. Signed-off-by: Eugenio Pérez --- net/vhost-vdpa.c | 89 +++- 1 file changed, 51 insertions(+), 38 deletions(-) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index

Re: [PATCH v2 1/1] python/machine: Fix AF_UNIX path too long on macOS

2022-07-18 Thread Daniel P . Berrangé
On Sat, Jul 16, 2022 at 10:34:34AM -0700, Peter Delevoryas wrote: > On macOS, private $TMPDIR's are the default. These $TMPDIR's are > generated from a user's unix UID and UUID [1], which can create a > relatively long path: > > /var/folders/d7/rz20f6hd709c1ty8f6_6y_z4gn/T/ > > QEMU's avo

Re: [RFC PATCH 11/12] vdpa: Add virtio-net mac address via CVQ at start

2022-07-18 Thread Jason Wang
在 2022/7/16 19:34, Eugenio Pérez 写道: This is needed so the destination vdpa device see the same state a the guest set in the source. Signed-off-by: Eugenio Pérez --- net/vhost-vdpa.c | 53 +++- 1 file changed, 52 insertions(+), 1 deletion(-) dif

Re: Internal MAC addresses list (mac_table) usage

2022-07-18 Thread Jason Wang
On Thu, Jul 14, 2022 at 7:54 PM Ovchinnikov, Vitalii wrote: > > Hi Jason, > > Thanks for pointing out that corner case with "52:54:00:12:34:XX". > > In the NIC model I'm developing qemu_macaddr_default_if_unset is called every > time MAC is updated in the NIC registers. > This way a just assigned

Re: [PATCH v4 2/2] ui/gtk: a new array param monitor to specify the target displays

2022-07-18 Thread Markus Armbruster
Dongwon Kim writes: > On Tue, Jul 12, 2022 at 08:11:08AM +0200, Markus Armbruster wrote: >> Dongwon Kim writes: >> >> > New integer array parameter, 'monitor' is for specifying the target >> > monitors where individual GTK windows are placed upon launching. >> > >> > Monitor numbers in the arra

Re: [RFC PATCH 11/12] vdpa: Add virtio-net mac address via CVQ at start

2022-07-18 Thread Eugenio Perez Martin
On Mon, Jul 18, 2022 at 10:55 AM Jason Wang wrote: > > > 在 2022/7/16 19:34, Eugenio Pérez 写道: > > This is needed so the destination vdpa device see the same state a the > > guest set in the source. > > > > Signed-off-by: Eugenio Pérez > > --- > > net/vhost-vdpa.c | 53 ++

Re: [RFC PATCH 3/8] RFC: block: use transactions as a replacement of ->{can_}set_aio_context()

2022-07-18 Thread Emanuele Giuseppe Esposito
Am 14/07/2022 um 18:45 schrieb Hanna Reitz: >> + * First, go recursively through all nodes in the graph, and see if they >> + * can change their AioContext. >> + * If so, add for each node a new transaction with a callback to >> change the >> + * AioContext with the new one. >> + * Once recursio

Re: [RFC PATCH 07/12] vhost: Add VhostVDPAStartOp operation

2022-07-18 Thread Eugenio Perez Martin
On Mon, Jul 18, 2022 at 10:50 AM Jason Wang wrote: > > On Sat, Jul 16, 2022 at 7:34 PM Eugenio Pérez wrote: > > > > It allows to run commands at start of the device, before it have enabled > > any queue. > > > > Signed-off-by: Eugenio Pérez > > --- > > hw/virtio/vhost-shadow-virtqueue.h | 3 +++

Re: [PATCH 1/2] block/parallels: Fix buffer-based write call

2022-07-18 Thread Denis V. Lunev
On 14.07.2022 15:28, Hanna Reitz wrote: Commit a4072543ccdddbd241d5962d9237b8b41fd006bf has changed the I/O here from working on a local one-element I/O vector to just using the buffer directly (using the bdrv_co_pread()/bdrv_co_pwrite() helper functions introduced shortly before). However, it o

Re: [PATCH 2/2] iotests/131: Add parallels regression test

2022-07-18 Thread Denis V. Lunev
On 14.07.2022 15:28, Hanna Reitz wrote: Test an allocating write to a parallels image that has a backing node. Before HEAD^, doing so used to give me a failed assertion (when the backing node contains only `42` bytes; the results varies with the value chosen, for `0` bytes, for example, all I get

Re: [PATCH 0/3] target: RFC: display deprecation note for '-cpu help'

2022-07-18 Thread Thomas Huth
On 14/07/2022 17.07, Daniel P. Berrangé wrote: When querying '-cpu help' there is no presentation of fact that a CPU may be deprecated. The user just has to try it and see if they get a depecation message at runtime. The QMP command for querying CPUs report a deprecation bool flag, but not the e

[PULL 0/1] MAINTAINERS: Add myself as Guest Agent co-maintainer

2022-07-18 Thread Konstantin Kostiuk
The following changes since commit 0ebf76aae58324b8f7bf6af798696687f5f4c2a9: Merge tag 'nvme-next-pull-request' of git://git.infradead.org/qemu-nvme into staging (2022-07-15 15:38:13 +0100) are available in the Git repository at: g...@github.com:kostyanf14/qemu.git tags/qga-win32-pull-202

[PULL 1/1] MAINTAINERS: Add myself as Guest Agent co-maintainer

2022-07-18 Thread Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk Acked-by: Michael Roth --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index ead2bed652..6af9cd985c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2881,7 +2881,7 @@ T: git https://repo.or.cz/qemu/armb

Re: [PATCH 0/3] target: RFC: display deprecation note for '-cpu help'

2022-07-18 Thread Cornelia Huck
On Mon, Jul 18 2022, Thomas Huth wrote: > On 14/07/2022 17.07, Daniel P. Berrangé wrote: >> $ qemu-system-x86_64 -cpu help: >> Available CPUs: >> x86 486 (alias configured by machine type) (deprecated: >> use at least 'Nehalem' / 'Opteron_G4', or 'host' / 'max') >> >> I wonder

Re: [PATCH 0/3] target: RFC: display deprecation note for '-cpu help'

2022-07-18 Thread Daniel P . Berrangé
On Mon, Jul 18, 2022 at 11:37:35AM +0200, Cornelia Huck wrote: > On Mon, Jul 18 2022, Thomas Huth wrote: > > > On 14/07/2022 17.07, Daniel P. Berrangé wrote: > >> $ qemu-system-x86_64 -cpu help: > >> Available CPUs: > >> x86 486 (alias configured by machine type) (deprecated: >

Re: [PATCH v5 5/8] blockdev: Add a new IF type IF_OTHER

2022-07-18 Thread Markus Armbruster
Hao Wu writes: > This type is used to represent block devs that are not suitable to > be represented by other existing types. > > A sample use is to represent an at24c eeprom device defined in > hw/nvram/eeprom_at24c.c. The block device can be used to contain the > content of the said eeprom devi

Re: [PATCH v5 7/8] hw/arm: Set drive property for at24c eeprom

2022-07-18 Thread Markus Armbruster
Hao Wu writes: > This patch allows the user to attach an external drive as a property > for an onboard at24c eeprom device. What's the contents of the EEPROM before the patch? I guess the patch lets users replace that contents. Why would a user want to do that? >

Re: [PATCH v5 5/8] blockdev: Add a new IF type IF_OTHER

2022-07-18 Thread Thomas Huth
On 18/07/2022 11.49, Markus Armbruster wrote: [...] An OTP device isn't really a parallel flash, and neither are eFuses. More fast-and-lose use of IF_PFLASH may exist in the tree, and maybe of other interface types, too. This patch introduces IF_OTHER. The patch after next uses it for an EEPROM

Re: [PATCH v2] gtk: Add show_tabs=on|off command line option.

2022-07-18 Thread Thomas Huth
On 12/07/2022 15.37, Felix xq Queißner wrote: The patch adds "show_tabs" command line option for GTK ui similar to "grab_on_hover". This option allows tabbed view mode to not have to be enabled by hand at each start of the VM. Nit: In case you have to respin again, please replace "show_tabs" wi

Re: [PATCH 0/3] target: RFC: display deprecation note for '-cpu help'

2022-07-18 Thread Cornelia Huck
On Mon, Jul 18 2022, Daniel P. Berrangé wrote: > On Mon, Jul 18, 2022 at 11:37:35AM +0200, Cornelia Huck wrote: >> Is it easy enough the figure out the deprecation note? I think you >> either have to actually start something with the deprecated entity, or >> use qmp (which is not that straightfor

[PATCH] target/arm: Add MO_128 entry to pred_esz_masks[]

2022-07-18 Thread Peter Maydell
In commit 7390e0e9ab8475, we added support for SME loads and stores. Unlike SVE loads and stores, these include handling of 128-bit elements. The SME load/store functions call down into the existing sve_cont_ldst_elements() function, which uses the element size MO_* value as an index into the pred

Re: [PATCH 1/7] pci: designware: add 64-bit viewport limit

2022-07-18 Thread Ben Dooks
On 13/07/2022 17:54, Ben Dooks wrote: Versions 4 and above add support for 64-bit viewport limit. Add support for the DESIGNWARE_PCIE_ATU_UPPER_LIMIT regiser where supported. Signed-off-by: Ben Dooks Whoops, just noticed this was my old ct address. --- hw/pci-host/designware.c | 2

Re: [PATCH] gpio: designware gpio driver

2022-07-18 Thread Ben Dooks
On 13/07/2022 18:20, Ben Dooks wrote: A model for the DesignWare GPIO (v1) block. Is there anyone else who should be reviewing these that was missed off the original list? I'd like to get an idea if there is any work to do. I've got a couple more drivers to submit and was waiting on feedback fr

Re: [PATCH] gpio: designware gpio driver

2022-07-18 Thread Peter Maydell
On Mon, 18 Jul 2022 at 11:05, Ben Dooks wrote: > > On 13/07/2022 18:20, Ben Dooks wrote: > > A model for the DesignWare GPIO (v1) block. > > Is there anyone else who should be reviewing these that > was missed off the original list? I'd like to get an idea > if there is any work to do. I've got a

Re: [RFC PATCH 09/12] vdpa: Extract vhost_vdpa_net_svq_add from vhost_vdpa_net_handle_ctrl_avail

2022-07-18 Thread Eugenio Perez Martin
On Mon, Jul 18, 2022 at 10:53 AM Jason Wang wrote: > > > 在 2022/7/16 19:34, Eugenio Pérez 写道: > > So we can reuse to inject state messages. > > > > Signed-off-by: Eugenio Pérez > > --- > > net/vhost-vdpa.c | 89 +++- > > 1 file changed, 51 insertions

Re: [PATCH] gpio: designware gpio driver

2022-07-18 Thread Ben Dooks
On 18/07/2022 11:15, Peter Maydell wrote: On Mon, 18 Jul 2022 at 11:05, Ben Dooks wrote: On 13/07/2022 18:20, Ben Dooks wrote: A model for the DesignWare GPIO (v1) block. Is there anyone else who should be reviewing these that was missed off the original list? I'd like to get an idea if the

[PATCH v4 00/19] vdpa net devices Rx filter change notification with Shadow VQ

2022-07-18 Thread Eugenio Pérez
Control virtqueue is used by networking device for accepting various commands from the driver. It's a must to support advanced configurations. Rx filtering event is issues by qemu when device's MAC address changed once and the previous one has not been queried by external agents. Shadow VirtQueue

[PATCH v4 01/19] vhost: move descriptor translation to vhost_svq_vring_write_descs

2022-07-18 Thread Eugenio Pérez
It's done for both in and out descriptors so it's better placed here. Acked-by: Jason Wang Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.c | 38 +- 1 file changed, 27 insertions(+), 11 deletions(-) diff --git a/hw/virtio/vhost-shadow-virtqueue.c

[PATCH v4 03/19] virtio-net: Expose ctrl virtqueue logic

2022-07-18 Thread Eugenio Pérez
This allows external vhost-net devices to modify the state of the VirtIO device model once the vhost-vdpa device has acknowledged the control commands. Signed-off-by: Eugenio Pérez --- include/hw/virtio/virtio-net.h | 4 ++ hw/net/virtio-net.c| 84 --

[PATCH v4 11/19] vhost: Expose vhost_svq_add

2022-07-18 Thread Eugenio Pérez
This allows external parts of SVQ to forward custom buffers to the device. Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.h | 3 +++ hw/virtio/vhost-shadow-virtqueue.c | 6 +++--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/virtio/vhost-shadow-virtqueue.h

[PATCH v4 02/19] virtio-net: Expose MAC_TABLE_ENTRIES

2022-07-18 Thread Eugenio Pérez
vhost-vdpa control virtqueue needs to know the maximum entries supported by the virtio-net device, so we know if it is possible to apply the filter. Signed-off-by: Eugenio Pérez --- include/hw/virtio/virtio-net.h | 3 +++ hw/net/virtio-net.c| 1 - 2 files changed, 3 insertions(+), 1

[PATCH v4 15/19] vdpa: manual forward CVQ buffers

2022-07-18 Thread Eugenio Pérez
Do a simple forwarding of CVQ buffers, the same work SVQ could do but through callbacks. No functional change intended. Signed-off-by: Eugenio Pérez --- include/hw/virtio/vhost-vdpa.h | 3 ++ hw/virtio/vhost-vdpa.c | 3 +- net/vhost-vdpa.c | 58 +++

[PATCH v4 04/19] vhost: Reorder vhost_svq_kick

2022-07-18 Thread Eugenio Pérez
Future code needs to call it from vhost_svq_add. No functional change intended. Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/hw/virtio/vhost-shadow-virtqueue.c b/hw/virtio/

[PATCH v4 06/19] vhost: Check for queue full at vhost_svq_add

2022-07-18 Thread Eugenio Pérez
The series need to expose vhost_svq_add with full functionality, including checking for full queue. Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.c | 59 +- 1 file changed, 33 insertions(+), 26 deletions(-) diff --git a/hw/virtio/vhost-shadow-virt

[PATCH v4 08/19] vhost: Add SVQDescState

2022-07-18 Thread Eugenio Pérez
This will allow SVQ to add context to the different queue elements. This patch only store the actual element, no functional change intended. Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.h | 8 ++-- hw/virtio/vhost-shadow-virtqueue.c | 16 2 files chang

[PATCH v4 12/19] vhost: add vhost_svq_poll

2022-07-18 Thread Eugenio Pérez
It allows the Shadow Control VirtQueue to wait for the device to use the available buffers. Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.h | 1 + hw/virtio/vhost-shadow-virtqueue.c | 27 +++ 2 files changed, 28 insertions(+) diff --git a/hw/virtio/v

[PATCH v4 16/19] vdpa: Buffer CVQ support on shadow virtqueue

2022-07-18 Thread Eugenio Pérez
Introduce the control virtqueue support for vDPA shadow virtqueue. This is needed for advanced networking features like rx filtering. Virtio-net control VQ copies the descriptors to qemu's VA, so we avoid TOCTOU with the guest's or device's memory every time there is a device model change. Otherw

[PATCH v4 05/19] vhost: Move vhost_svq_kick call to vhost_svq_add

2022-07-18 Thread Eugenio Pérez
The series needs to expose vhost_svq_add with full functionality, including kick Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/vhost-shadow-virtqueue.c b/hw/virtio/vhost-shadow-virtqueue.c index

[PATCH v4 10/19] vhost: add vhost_svq_push_elem

2022-07-18 Thread Eugenio Pérez
This function allows external SVQ users to return guest's available buffers. Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.h | 3 +++ hw/virtio/vhost-shadow-virtqueue.c | 16 2 files changed, 19 insertions(+) diff --git a/hw/virtio/vhost-shadow-virtqueue.h

[PATCH v4 18/19] vdpa: Add device migration blocker

2022-07-18 Thread Eugenio Pérez
Since the vhost-vdpa device is exposing _F_LOG, adding a migration blocker if it uses CVQ. Signed-off-by: Eugenio Pérez --- include/hw/virtio/vhost-vdpa.h | 1 + hw/virtio/vhost-vdpa.c | 14 ++ 2 files changed, 15 insertions(+) diff --git a/include/hw/virtio/vhost-vdpa.h b/

[PATCH v4 14/19] vdpa: Export vhost_vdpa_dma_map and unmap calls

2022-07-18 Thread Eugenio Pérez
Shadow CVQ will copy buffers on qemu VA, so we avoid TOCTOU attacks from the guest that could set a different state in qemu device model and vdpa device. To do so, it needs to be able to map these new buffers to the device. Signed-off-by: Eugenio Pérez Acked-by: Jason Wang --- include/hw/virti

[PATCH v4 13/19] vhost: Add svq avail_handler callback

2022-07-18 Thread Eugenio Pérez
This allows external handlers to be aware of new buffers that the guest places in the virtqueue. When this callback is defined the ownership of the guest's virtqueue element is transferred to the callback. This means that if the user wants to forward the descriptor it needs to manually inject it.

[PATCH v4 19/19] vdpa: Add x-svq to NetdevVhostVDPAOptions

2022-07-18 Thread Eugenio Pérez
Finally offering the possibility to enable SVQ from the command line. Signed-off-by: Eugenio Pérez Acked-by: Markus Armbruster --- qapi/net.json| 9 +- net/vhost-vdpa.c | 72 ++-- 2 files changed, 77 insertions(+), 4 deletions(-) diff --git

[PATCH v4 07/19] vhost: Decouple vhost_svq_add from VirtQueueElement

2022-07-18 Thread Eugenio Pérez
VirtQueueElement comes from the guest, but we're heading SVQ to be able to modify the element presented to the device without the guest's knowledge. To do so, make SVQ accept sg buffers directly, instead of using VirtQueueElement. Add vhost_svq_add_element to maintain element convenience. Signed

[PATCH v4 17/19] vdpa: Extract get features part from vhost_vdpa_get_max_queue_pairs

2022-07-18 Thread Eugenio Pérez
To know the device features is needed for CVQ SVQ, so SVQ knows if it can handle all commands or not. Extract from vhost_vdpa_get_max_queue_pairs so we can reuse it. Signed-off-by: Eugenio Pérez Acked-by: Jason Wang --- net/vhost-vdpa.c | 30 -- 1 file changed, 20 in

Re: [PATCH] gpio: designware gpio driver

2022-07-18 Thread Peter Maydell
On Mon, 18 Jul 2022 at 11:25, Ben Dooks wrote: > > On 18/07/2022 11:15, Peter Maydell wrote: > > On Mon, 18 Jul 2022 at 11:05, Ben Dooks wrote: > >> > >> On 13/07/2022 18:20, Ben Dooks wrote: > >>> A model for the DesignWare GPIO (v1) block. > >> > >> Is there anyone else who should be reviewing

[PATCH v4 09/19] vhost: Track number of descs in SVQDescState

2022-07-18 Thread Eugenio Pérez
A guest's buffer continuos on GPA may need multiple descriptors on qemu's VA, so SVQ should track its length sepparatedly. Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.h | 6 ++ hw/virtio/vhost-shadow-virtqueue.c | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-)

Re: [RFC PATCH] qobject: Rewrite implementation of QDict for in-order traversal

2022-07-18 Thread Markus Armbruster
Peter Maydell writes: > On Mon, 11 Jul 2022 at 12:09, Daniel P. Berrangé wrote: >> >> On Mon, Jul 11, 2022 at 11:32:35AM +0100, Peter Maydell wrote: >> > I'm pretty sure that nothing needs sparse array elements like >> > that. The major reason for the len-PROP field is an implementation >> > one

Re: [RISU PATCH v4 15/29] Rearrange reginfo and memblock buffers

2022-07-18 Thread Peter Maydell
On Fri, 8 Jul 2022 at 17:06, Richard Henderson wrote: > > For send_register_info from master_sigill, do not keep a > reginfo buffer on the stack. At the moment, this struct > is quite large for aarch64. > > Put the two reginfo buffers into an array, for the benefit > of future dumping. For recv_

Re: [RISU PATCH v4 14/29] Merge reginfo.c into risu.c

2022-07-18 Thread Peter Maydell
On Fri, 8 Jul 2022 at 17:02, Richard Henderson wrote: > > The distinction between the two is artificial. Following > patches will rearrange the functions involved to make it > easier for dumping of the trace file. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [RISU PATCH v4 16/29] Split out recv_register_info

2022-07-18 Thread Peter Maydell
On Fri, 8 Jul 2022 at 17:36, Richard Henderson wrote: > > We will want to share this code when dumping. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [RFC v4 0/9] Add support for zoned device

2022-07-18 Thread Markus Armbruster
Sam Li writes: > Markus Armbruster 于2022年7月12日周二 13:47写道: >> >> Sam Li writes: >> >> > This patch series adds support for zoned device to virtio-blk emulation. >> > Zoned >> > Storage can support sequential writes, which reduces write amplification >> > in SSD, >> > leading to higher write th

Re: [RISU PATCH v4 17/29] Add magic and size to the trace header

2022-07-18 Thread Peter Maydell
On Fri, 8 Jul 2022 at 17:08, Richard Henderson wrote: > > Sanity check that we're not getting out of sync with > the trace stream. This will be especially bad with > the change in size of the sve save data. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 1/6] target/riscv: add check for supported privilege modes conbinations

2022-07-18 Thread Weiwei Li
在 2022/7/18 下午5:02, Andrew Jones 写道: On Tue, Jul 12, 2022 at 02:32:31PM +0800, Weiwei Li wrote: - There are 3 suggested privilege modes conbinations listed in the spec: No need for '-' here. s/modes/mode/ s/conbinations/combinations/ (Same typos in $SUBJECT, also please capitalize 'add' in

Re: [RISU PATCH v4 19/29] aarch64: Assume system support for SVE

2022-07-18 Thread Peter Maydell
On Fri, 8 Jul 2022 at 17:09, Richard Henderson wrote: > > SVE support is no longer new, assume it's present. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [RISU PATCH v4 18/29] Compute reginfo_size based on the reginfo

2022-07-18 Thread Peter Maydell
On Fri, 8 Jul 2022 at 17:35, Richard Henderson wrote: > > This will allow dumping of SVE frames without having > to know the SVE vector length beforehand. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [RISU PATCH v4 20/29] aarch64: Reorg sve reginfo to save space

2022-07-18 Thread Peter Maydell
On Fri, 8 Jul 2022 at 17:38, Richard Henderson wrote: > > Mirror the signal frame by storing all of the registers > as a lump. Use the signal macros to pull out the values. > > Signed-off-by: Richard Henderson > --- > risu_reginfo_aarch64.h | 45 ++- > risu_reginfo_aarch64.c | 171

Re: [RISU PATCH v4 21/29] aarch64: Use arch_init to configure sve

2022-07-18 Thread Peter Maydell
On Fri, 8 Jul 2022 at 17:41, Richard Henderson wrote: > > Adjust some of the aarch64 code to look at the reginfo struct > instead of looking at test_sve, so that we do not need to pass > the --test-sve option in order to dump sve trace files. > > Diagnose EINVAL as either cpu or kernel does not su

[PATCH v2 7/9] target/arm: Add PMSAv8r registers

2022-07-18 Thread Tobias Roehmel
From: Tobias Röhmel Signed-off-by: Tobias Röhmel --- target/arm/cpu.h| 10 +++ target/arm/helper.c | 171 2 files changed, 181 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 86e06116a9..632d0d13c6 100644 --- a/target/arm/c

[PATCH v2 3/9] target/arm: Make RVBAR available for all ARMv8 CPUs

2022-07-18 Thread Tobias Roehmel
From: Tobias Röhmel Signed-off-by: Tobias Röhmel --- target/arm/cpu.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 1b5d535788..9007768418 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -258,6 +258,10 @@ static void a

[PATCH v2 6/9] target/arm: Enable TTBCR_EAE for ARMv8-R AArch32

2022-07-18 Thread Tobias Roehmel
From: Tobias Röhmel ARMv8-R AArch32 CPUs behave as if TTBCR.EAE is always 1 even tough they don't have the TTBCR register. See ARM Architecture Reference Manual Supplement - ARMv8, for the ARMv8-R AArch32 architecture profile Version:A.c section C1.2. Signed-off-by: Tobias Röhmel --- target/ar

[PATCH v2 0/9] Add Cortex-R52

2022-07-18 Thread Tobias Roehmel
v2: PATCH 1: I have left the flag in for now because there there is a lot of use for it in the MPU translation code. The PMSAv8r differs in quite a view ways from the implementation in the Cortex-M. I think using !ARM_FEATURE_M in all of those cases might run into problems down the road when new

[PATCH v2 2/9] target/arm: Don't add all MIDR aliases for Cortex-R

2022-07-18 Thread Tobias Roehmel
From: Tobias Röhmel Cortex-R52 has the MPUIR register which has the same encoding has the MIDR alias with opc2=4. So we only add that alias when we are not realizing a Cortex-R. Signed-off-by: Tobias Röhmel --- target/arm/helper.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions

[PATCH v2 4/9] target/arm: Make stage_2_format for cache attributes optional

2022-07-18 Thread Tobias Roehmel
From: Tobias Röhmel The Cortex-R52 has a 2 stage MPU translation process but doesn't have the FEAT_S2FWB feature. This makes it neccessary to allow for the old cache attribut combination. This is facilitated by changing the control path of combine_cacheattrs instead of failing if the second ca

[PATCH v2 9/9] target/arm: Add ARM Cortex-R52 cpu

2022-07-18 Thread Tobias Roehmel
From: Tobias Röhmel All constants are taken from the ARM Cortex-R52 Processor TRM Revision: r1p3 Signed-off-by: Tobias Röhmel --- target/arm/cpu_tcg.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/target/arm/cpu_tcg.c b/target/arm/cpu_tcg.c ind

[PATCH v2 1/9] target/arm: Add ARM_FEATURE_V8_R

2022-07-18 Thread Tobias Roehmel
From: Tobias Röhmel This flag is necessary to add features for the Cortex-R52. Signed-off-by: Tobias Röhmel --- target/arm/cpu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index df677b2d5d..86e06116a9 100644 --- a/target/arm/cpu.h +++ b/target/arm/c

Re: [PATCH v7 07/13] multifd: Make flags field thread local

2022-07-18 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Use of flags with respect to locking was incensistant. For the > sending side: > - it was set to 0 with mutex held on the multifd channel. > - MULTIFD_FLAG_SYNC was set with mutex held on the migration thread. > - Everything else was done without the

[PATCH v2 5/9] target/arm: Add ARMCacheAttrs to the signature of pmsav8_mpu_lookup

2022-07-18 Thread Tobias Roehmel
From: Tobias Röhmel Add ARMCacheAttrs to the signature of pmsav8_mpu_lookup to prepare for the Cortex-R52 MPU which uses and combines cache attributes of different translation levels. Signed-off-by: Tobias Röhmel --- target/arm/internals.h | 13 +++-- target/arm/m_helper.c | 3 ++-

Re: [RISU PATCH v4 24/29] Add --fulldump and --diffdup options

2022-07-18 Thread Peter Maydell
On Fri, 8 Jul 2022 at 17:51, Richard Henderson wrote: > > These allow the inspection of the trace files. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

[PATCH v2 8/9] target/arm: Add PMSAv8r functionality

2022-07-18 Thread Tobias Roehmel
From: Tobias Röhmel Add PMSAv8r translation that is used by the ARM Cortex-R52. Signed-off-by: Tobias Röhmel --- target/arm/ptw.c | 171 +-- 1 file changed, 150 insertions(+), 21 deletions(-) diff --git a/target/arm/ptw.c b/target/arm/ptw.c index c4

Re: [RISU PATCH v4 27/29] aarch64: Tidy reginfo dumping ahead of ZA state

2022-07-18 Thread Peter Maydell
On Fri, 8 Jul 2022 at 17:14, Richard Henderson wrote: > > A misalignment for sve_vl, plus add a bit more space > on the left for the ZA[n] field name. > > Signed-off-by: Richard Henderson > --- > risu_reginfo_aarch64.c | 29 ++--- > 1 file changed, 18 insertions(+), 11 de

Re: [RISU PATCH v4 28/29] aarch64: Add support for ZA storage

2022-07-18 Thread Peter Maydell
On Fri, 8 Jul 2022 at 18:07, Richard Henderson wrote: > > Require NVL == SVL on startup, to make it easier to manage reginfo. > Most of the time PSTATE.SM would be active with PSTATE.ZA anyway, > for any non-trivial SME testing. > > Extend saved storage only when PSTATE.ZA is active. > Use a caref

Re: [RISU PATCH v4 23/29] Standardize reginfo_dump_mismatch printing

2022-07-18 Thread Peter Maydell
On Fri, 8 Jul 2022 at 17:39, Richard Henderson wrote: > > Hoist the "master vs apprentice" label to apprentice(), since > we will want different labels for dumping. Remove all of the > "mismatch" text from reginfo_dump_mismatch -- just print "vs". > > Signed-off-by: Richard Henderson > diff --g

Re: [RISU PATCH v4 25/29] Remove return value from reginfo_dump

2022-07-18 Thread Peter Maydell
On Fri, 8 Jul 2022 at 18:05, Richard Henderson wrote: > > No uses actually checked the error indication. Even if we wanted > to check ferror on the stream, we should do that generically rather > than per arch. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH] block/rbd: support driver-specific reopen

2022-07-18 Thread Raphael Pour
On 7/1/22 11:41, Hanna Reitz wrote: On 13.04.22 14:26, Raphael Pour wrote: >>   } -    return ret; +    /* + * Remove all keys from the generic layer which + * can't be converted by rbd + * > Does any other driver do this?  Shouldn’t we leave them there so that the generic laye

[PATCH v2] vhost: Get vring base from vq, not svq

2022-07-18 Thread Eugenio Pérez
The SVQ vring used idx usually match with the guest visible one, as long as all the guest buffers (GPA) maps to exactly one buffer within qemu's VA. However, as we can see in virtqueue_map_desc, a single guest buffer could map to many buffers in SVQ vring. Also, its also a mistake to rewind them a

Re: [RISU PATCH v4 00/29] risu cleanups and improvements

2022-07-18 Thread Peter Maydell
On Fri, 8 Jul 2022 at 16:49, Richard Henderson wrote: > > If you can imagine, v3 was back in 2020: > https://lore.kernel.org/qemu-devel/20200522023440.26261-1-richard.hender...@linaro.org/ > > I've refreshed that, not that risu has changed much in that time, > and then also added support for SME t

Re: [PATCH 2/2] iotests/131: Add parallels regression test

2022-07-18 Thread Vladimir Sementsov-Ogievskiy
On 7/14/22 16:28, Hanna Reitz wrote: Test an allocating write to a parallels image that has a backing node. Before HEAD^, doing so used to give me a failed assertion (when the backing node contains only `42` bytes; the results varies with the value chosen, for `0` bytes, for example, all I get is

Re: [PATCH 1/2] block/parallels: Fix buffer-based write call

2022-07-18 Thread Vladimir Sementsov-Ogievskiy
On 7/14/22 16:28, Hanna Reitz wrote: Commit a4072543ccdddbd241d5962d9237b8b41fd006bf has changed the I/O here from working on a local one-element I/O vector to just using the buffer directly (using the bdrv_co_pread()/bdrv_co_pwrite() helper functions introduced shortly before). However, it only

Re: [RISU PATCH v4 29/29] aarch64: Trivial SME test

2022-07-18 Thread Peter Maydell
On Fri, 8 Jul 2022 at 17:59, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > test_sme_aarch64.s | 55 ++ > 1 file changed, 55 insertions(+) > create mode 100644 test_sme_aarch64.s > > diff --git a/test_sme_aarch64.s b/test_sme_aa

Re: [PATCH v8 00/12] s390x: CPU Topology

2022-07-18 Thread Pierre Morel
On 7/15/22 20:28, Janis Schoetterl-Glausch wrote: On 7/15/22 15:47, Pierre Morel wrote: On 7/15/22 11:31, Janis Schoetterl-Glausch wrote: On 7/14/22 22:05, Pierre Morel wrote: On 7/14/22 20:43, Janis Schoetterl-Glausch wrote: On 6/20/22 16:03, Pierre Morel wrote: Hi, This new spin is

Re: [PATCH v7 08/13] multifd: Prepare to send a packet without the mutex held

2022-07-18 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We do the send_prepare() and the fill of the head packet without the > mutex held. It will help a lot for compression and later in the > series for zero pages. > > Notice that we can use p->pages without holding p->mutex because > p->pending_job == 1

Re: [PATCH] x86: cpu: Error out if memory exceeds addressable range

2022-07-18 Thread Igor Mammedov
On Mon, 18 Jul 2022 13:47:34 +0530 Nikunj A Dadhania wrote: > Currently it is possible to start a guest with memory that is beyond > the addressable range of CPU and QEMU does not even warn about it. > The default phys_bits is 40 and can address 1TB. However it allows to > start a guest with grea

Re: [PULL 05/20] meson: Prefix each element of firmware path

2022-07-18 Thread Thomas Huth
On 14/07/2022 11.01, Paolo Bonzini wrote: From: Akihiko Odaki Signed-off-by: Akihiko Odaki Message-Id: <20220624154042.51512-1-akihiko.od...@gmail.com> [Rewrite shell function without using Bash extensions. - Paolo] Signed-off-by: Paolo Bonzini --- configure | 15 +++

Re: [PATCH v8 06/11] i386/pc: factor out cxl range start to helper

2022-07-18 Thread Igor Mammedov
On Fri, 15 Jul 2022 18:16:23 +0100 Joao Martins wrote: > Factor out the calculation of the base address of the memory region. > It will be used later on for the cxl range end counterpart calculation > and as well in pc_memory_init() CXL memory region initialization, thus > avoiding duplication. >

  1   2   3   4   >