Re: [PULL 05/20] meson: Prefix each element of firmware path

[Thomas Huth]

On 14/07/2022 11.01, Paolo Bonzini wrote:
From: Akihiko Odaki <akihiko.od...@gmail.com>
Signed-off-by: Akihiko Odaki <akihiko.od...@gmail.com>
Message-Id: <20220624154042.51512-1-akihiko.od...@gmail.com>
[Rewrite shell function without using Bash extensions. - Paolo]
Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
---
  configure                     | 15 +++++++++++++++
  meson.build                   | 11 +++++++++--
  meson_options.txt             |  2 +-
  scripts/meson-buildoptions.py |  7 +++++--
  scripts/meson-buildoptions.sh |  4 ++--
  softmmu/datadir.c             |  8 +++++---
  6 files changed, 37 insertions(+), 10 deletions(-)

diff --git a/configure b/configure
index e8cc850727..f02635b087 100755
--- a/configure
+++ b/configure
@@ -676,6 +676,21 @@ fi
  
  werror=""
  
+meson_option_build_array() {
+  printf '['
+  (if test "$targetos" == windows; then
+    IFS=\;
+  else
+    IFS=:
+  fi
+  for e in $1; do
+    e=${e/'\'/'\\'}
+    e=${e/\"/'\"'}
+    printf '"""%s""",' "$e"
+  done)
+  printf ']\n'
+}

 Hi!

This seems to break the NetBSD VM builds:

$ make vm-build-netbsd J=4 TARGET_LIST=x86_64-softmmu
  GIT     ui/keycodemapdb meson tests/fp/berkeley-testfloat-3 
tests/fp/berkeley-softfloat-3 dtc slirp roms/SLOF
    VM-BUILD netbsd
../src/configure: 687: Syntax error: Bad substitution

Could you please have a look?

 Thanks,
  Thomas