[PATCH V8 26/39] vfio-pci: refactor for cpr

2022-06-15 Thread Steve Sistare
Refactor vector use into a helper vfio_vector_init. Add vfio_notifier_init and vfio_notifier_cleanup for named notifiers, and pass additional arguments to vfio_remove_kvm_msi_virq. All for use by cpr in a subsequent patch. No functional change. Signed-off-by: Steve Sistare --- hw/vfio/pci.c |

[PATCH V8 34/39] chardev: cpr for simple devices

2022-06-15 Thread Steve Sistare
Set QEMU_CHAR_FEATURE_CPR for devices that trivially support cpr. char-stdio is slightly less trivial. Allow the gdb server by closing it on exec. Signed-off-by: Steve Sistare --- chardev/char-mux.c| 1 + chardev/char-null.c | 1 + chardev/char-serial.c | 1 + chardev/char-stdio.c | 1

[PATCH V8 28/39] vfio-pci: cpr part 2 (msi)

2022-06-15 Thread Steve Sistare
Finish cpr for vfio-pci MSI/MSI-X devices by preserving eventfd's and vector state. Signed-off-by: Steve Sistare --- hw/vfio/pci.c | 122 +- 1 file changed, 121 insertions(+), 1 deletion(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index

[PATCH V8 39/39] tests/avocado: add cpr regression test

2022-06-15 Thread Steve Sistare
Signed-off-by: Steve Sistare --- MAINTAINERS | 1 + tests/avocado/cpr.py | 152 +++ 2 files changed, 153 insertions(+) create mode 100644 tests/avocado/cpr.py diff --git a/MAINTAINERS b/MAINTAINERS index 864aec6..4e6e7ab 100644 --- a/MA

[PATCH V8 01/39] migration: fix populate_vfio_info

2022-06-15 Thread Steve Sistare
Include CONFIG_DEVICES so that populate_vfio_info is instantiated for CONFIG_VFIO. Signed-off-by: Steve Sistare --- migration/target.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/target.c b/migration/target.c index 907ebf0..a0991bc 100644 --- a/migration/target.c +++ b/migratio

[PATCH V8 37/39] cpr: only-cpr-capable option

2022-06-15 Thread Steve Sistare
Add the only-cpr-capable option, which causes qemu to exit with an error if any devices that are not capable of cpr are added. This guarantees that cpr-save will not fail due to a blocker. Signed-off-by: Steve Sistare --- include/migration/cpr.h | 2 +- migration/cpr.c | 13 +++

[PATCH V8 35/39] chardev: cpr for pty

2022-06-15 Thread Steve Sistare
Save and restore pty descriptors across cpr-save and cpr-load. Signed-off-by: Steve Sistare --- chardev/char-pty.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/chardev/char-pty.c b/chardev/char-pty.c index 53f25c6..ff5b00a 100644 --- a/chardev/char-pty.c +

[PATCH V8 38/39] python/machine: add QEMUMachine accessors

2022-06-15 Thread Steve Sistare
Provide full_args() to return all command-line arguments used to start a vm, some of which are not otherwise visible to QEMUMachine clients. This is needed by the cpr test, which must start a vm, then pass all qemu command-line arguments to the cpr-exec monitor call. Provide reopen_qmp_connection

[PATCH V8 05/39] vl: start on wakeup request

2022-06-15 Thread Steve Sistare
If qemu starts and loads a VM in the suspended state, then a later wakeup request will set the state to running, which is not sufficient to initialize the vm, as vm_start was never called during this invocation of qemu. See qemu_system_wakeup_request(). Define the start_on_wakeup_requested() hook

Re: [PATCH v16 2/9] linux-user: Add LoongArch signal support

2022-06-15 Thread Richard Henderson
On 6/15/22 02:57, gaosong wrote: On 2022/6/15 上午12:15, Richard Henderson wrote: +static void *get_ctx(struct target_sctx_info *info) +{ +    return (void *)((char *)info + sizeof(struct target_sctx_info)); +} Return type should be struct target_sctx_info *. I wonder that if we return targe

[PATCH V8 16/39] qapi: strv_from_strList

2022-06-15 Thread Steve Sistare
Signed-off-by: Steve Sistare --- include/qapi/util.h | 6 ++ qapi/qapi-util.c| 14 ++ 2 files changed, 20 insertions(+) diff --git a/include/qapi/util.h b/include/qapi/util.h index 75dddca..51ff64e 100644 --- a/include/qapi/util.h +++ b/include/qapi/util.h @@ -33,6 +33,12 @@

[PATCH V8 07/39] cpr: reboot HMP interfaces

2022-06-15 Thread Steve Sistare
cpr-save Call qmp_cpr_save(). Arguments: filename : save vmstate to filename mode: must be "reboot" cpr-load Call qmp_cpr_load(). Arguments: filename : load vmstate from filename mode: must be "reboot" Signed-off-by: Mark Kanda Signed-off-by: Steve Sistare --- hmp-c

Re: [PATCH] MAINTAINERS: Add softmmu/runstate.c to "Main loop"

2022-06-15 Thread Richard Henderson
On 6/15/22 05:23, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4cf6174f9f..4c921c07db 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2745,6 +2745,7 @@ F: softmmu/cpu-throttle.c F

Re: New "IndustryStandard" fw_cfg?

2022-06-15 Thread Xiaoyao Li
On 6/15/2022 8:46 AM, Xu, Min M wrote: I would like to add more engineers (Confidential Computing Reviewers in EDK2 community and Intel's QEMU engineers) in this mail thread. -Original Message- From: Dionna Amalie Glaze Sent: Wednesday, June 15, 2022 2:09 AM To: qemu-devel@nongnu.org

[PATCH V8 15/39] qapi: QAPI_LIST_LENGTH

2022-06-15 Thread Steve Sistare
Signed-off-by: Steve Sistare --- include/qapi/util.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/qapi/util.h b/include/qapi/util.h index 7d88b09..75dddca 100644 --- a/include/qapi/util.h +++ b/include/qapi/util.h @@ -65,4 +65,17 @@ struct strList *strList_from_strin

Re: [PATCH v4 3/7] tests/9pfs: compare QIDs in fs_walk_none() test

2022-06-15 Thread Greg Kurz
On Tue, 15 Mar 2022 11:08:35 +0100 Christian Schoenebeck wrote: > Extend previously added fs_walk_none() test by comparing the QID > of the root fid with the QID of the cloned fid. They should be > equal. > > Signed-off-by: Christian Schoenebeck > --- LGTM. Reviewed-by: Greg Kurz > tests/q

Re: [PATCH 2/5] tests/qemu-iotests: skip 108 when FUSE is not loaded

2022-06-15 Thread Daniel P . Berrangé
On Wed, Jun 15, 2022 at 09:41:32AM -0400, John Snow wrote: > On Tue, Jun 14, 2022 at 10:30 AM John Snow wrote: > > > > On Tue, Jun 14, 2022 at 4:59 AM Daniel P. Berrangé > > wrote: > > > > > > On Tue, Jun 14, 2022 at 06:46:35AM +0200, Thomas Huth wrote: > > > > On 14/06/2022 03.50, John Snow wro

Re: [PATCH] tests/vm: allow running tests in an unconfigured source tree

2022-06-15 Thread John Snow
On Tue, Jun 14, 2022 at 12:51 PM Paolo Bonzini wrote: > > tests/vm/Makefile.include used to assume that it could run in an unconfigured > source tree, and Cirrus CI relies on that. It was however broken by commit > f4c66f1705 ("tests: use tests/venv to run basevm.py-based scripts", > 2022-06-06)

Re: [PATCH] target/riscv: Update tval for hardware watchpoint

2022-06-15 Thread Richard Henderson
On 6/14/22 21:08, Bin Meng wrote: From: Bin Meng When watchpoint is hit, the breakpoint exception should update tval to point to the faulting virtual address. Signed-off-by: Bin Meng --- target/riscv/cpu.h| 1 + target/riscv/cpu_helper.c | 6 ++ target/riscv/debug.c | 2

Re: [PATCH 2/5] tests/qemu-iotests: skip 108 when FUSE is not loaded

2022-06-15 Thread John Snow
On Wed, Jun 15, 2022 at 11:33 AM Daniel P. Berrangé wrote: > > On Wed, Jun 15, 2022 at 09:41:32AM -0400, John Snow wrote: > > On Tue, Jun 14, 2022 at 10:30 AM John Snow wrote: > > > > > > On Tue, Jun 14, 2022 at 4:59 AM Daniel P. Berrangé > > > wrote: > > > > > > > > On Tue, Jun 14, 2022 at 06:

Re: [PATCH v4 5/7] 9pfs: fix 'Twalk' to only send error if no component walked

2022-06-15 Thread Greg Kurz
On Tue, 15 Mar 2022 11:08:39 +0100 Christian Schoenebeck wrote: > Current implementation of 'Twalk' request handling always sends an 'Rerror' > response if any error occured. The 9p2000 protocol spec says though: > > " > If the first element cannot be walked for any reason, Rerror is returne

[PULL 00/18] Block patches

2022-06-15 Thread Stefan Hajnoczi
The following changes since commit 8e6c70b9d4a1b1f3011805947925cfdb31642f7f: Merge tag 'kraxel-20220614-pull-request' of git://git.kraxel.org/qemu into staging (2022-06-14 06:21:46 -0700) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block-pull-request f

[PULL 01/18] MAINTAINERS: update Vladimir's address and repositories

2022-06-15 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Message-id: 20220526115432.138384-1-vsement...@yandex-team.ru Signed-off-by: Stefan Hajnoczi --- MAINTAINERS | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/MAINTAINERS b

[PULL 06/18] vfio-user: build library

2022-06-15 Thread Stefan Hajnoczi
From: Jagannathan Raman add the libvfio-user library as a submodule. build it as a meson subproject. libvfio-user is distributed with BSD 3-Clause license and json-c with MIT (Expat) license Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewe

[PULL 03/18] qdev: unplug blocker for devices

2022-06-15 Thread Stefan Hajnoczi
From: Jagannathan Raman Add blocker to prevent hot-unplug of devices TYPE_VFIO_USER_SERVER, which is introduced shortly, attaches itself to a PCIDevice on which it depends. If the attached PCIDevice gets removed while the server in use, it could cause it crash. To prevent this, TYPE_VFIO_USER_SE

[PULL 08/18] vfio-user: instantiate vfio-user context

2022-06-15 Thread Stefan Hajnoczi
From: Jagannathan Raman create a context with the vfio-user library to run a PCI device Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi Message-id: a452871ac8c812ff96fc4f0ce6037f4769953fab.1655151679.git.jag.ra...@or

[PULL 04/18] remote/machine: add HotplugHandler for remote machine

2022-06-15 Thread Stefan Hajnoczi
From: Jagannathan Raman Allow hotplugging of PCI(e) devices to remote machine Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi Message-id: d1e6cfa0afb528ad343758f9b1d918be0175c5e5.1655151679.git.jag.ra...@oracle.com S

[PULL 09/18] vfio-user: find and init PCI device

2022-06-15 Thread Stefan Hajnoczi
From: Jagannathan Raman Find the PCI device with specified id. Initialize the device context with the QEMU PCI device Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi Message-id: 7798dbd730099b33fdd00c4c202cfe79e5c5c1

[PULL 05/18] remote/machine: add vfio-user property

2022-06-15 Thread Stefan Hajnoczi
From: Jagannathan Raman Add vfio-user to x-remote machine. It is a boolean, which indicates if the machine supports vfio-user protocol. The machine configures the bus differently vfio-user and multiprocess protocols, so this property informs it on how to configure the bus. This property should b

[PULL 10/18] vfio-user: run vfio-user context

2022-06-15 Thread Stefan Hajnoczi
From: Jagannathan Raman Setup a handler to run vfio-user context. The context is driven by messages to the file descriptor associated with it - get the fd for the context and hook up the handler with it Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Ram

[PULL 02/18] Use io_uring_register_ring_fd() to skip fd operations

2022-06-15 Thread Stefan Hajnoczi
From: Sam Li Linux recently added a new io_uring(7) optimization API that QEMU doesn't take advantage of yet. The liburing library that QEMU uses has added a corresponding new API calling io_uring_register_ring_fd(). When this API is called after creating the ring, the io_uring_submit() library f

[PULL 07/18] vfio-user: define vfio-user-server object

2022-06-15 Thread Stefan Hajnoczi
From: Jagannathan Raman Define vfio-user object which is remote process server for QEMU. Setup object initialization functions and properties necessary to instantiate the object Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan H

[PULL 12/18] vfio-user: IOMMU support for remote device

2022-06-15 Thread Stefan Hajnoczi
From: Jagannathan Raman Assign separate address space for each device in the remote processes. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi Message-id: afe0b0a97582cdad42b5b25636a29c523265a10a.1655151679.git.jag.r

[PULL 14/18] vfio-user: handle PCI BAR accesses

2022-06-15 Thread Stefan Hajnoczi
From: Jagannathan Raman Determine the BARs used by the PCI device and register handlers to manage the access to the same. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi Message-id: 3373e10b5be5f42846f0632d4382466e16

[PULL 11/18] vfio-user: handle PCI config space accesses

2022-06-15 Thread Stefan Hajnoczi
From: Jagannathan Raman Define and register handlers for PCI config space accesses Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi Message-id: be9d2ccf9b1d24e50dcd9c23404dbf284142cec7.1655151679.git.jag.ra...@oracle.

[PULL 17/18] linux-aio: fix unbalanced plugged counter in laio_io_unplug()

2022-06-15 Thread Stefan Hajnoczi
Every laio_io_plug() call has a matching laio_io_unplug() call. There is a plugged counter that tracks the number of levels of plugging and allows for nesting. The plugged counter must reflect the balance between laio_io_plug() and laio_io_unplug() calls accurately. Otherwise I/O stalls occur sinc

[PATCH v6 1/7] datadir: Simplify firmware directory search

2022-06-15 Thread Akihiko Odaki
The old implementation had some code to accept multiple firmware directories, but it is not used. Signed-off-by: Akihiko Odaki --- softmmu/datadir.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/softmmu/datadir.c b/softmmu/datadir.c index 160cac999a6..2a206f2740

[PULL 16/18] vfio-user: handle reset of remote device

2022-06-15 Thread Stefan Hajnoczi
From: Jagannathan Raman Adds handler to reset a remote device Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi Message-id: 112eeadf3bc4c6cdb100bc3f9a6fcfc20b467c1b.1655151679.git.jag.ra...@oracle.com Signed-off-by: St

[PULL 13/18] vfio-user: handle DMA mappings

2022-06-15 Thread Stefan Hajnoczi
From: Jagannathan Raman Define and register callbacks to manage the RAM regions used for device DMA Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi Message-id: faacbcd45c4d02c591f0dbfdc19041fbb3eae7eb.1655151679.git.

[PATCH v6 4/7] cutils: Introduce bundle mechanism

2022-06-15 Thread Akihiko Odaki
Developers often run QEMU without installing. The bundle mechanism allows to look up files which should be present in installation even in such a situation. It is a general mechanism and can find any files located relative to the installation tree. The build tree must have a new directory, qemu-bu

[PATCH v6 3/7] Remove prefixes from path configuration macros

2022-06-15 Thread Akihiko Odaki
The path configuration macros are often supplied to get_relocated_path(), and the function had some logics to remove the prefixes. With this change, the prefixes are removed from those macros and get_relocated_path() is also simplified. Signed-off-by: Akihiko Odaki --- include/qemu/cutils.h |

[PATCH v6 0/7] cutils: Introduce bundle mechanism

2022-06-15 Thread Akihiko Odaki
Developers often run QEMU without installing. The bundle mechanism allows to look up files which should be present in installation even in such a situation. It is a general mechanism and can find any files located relative to the installation tree. The build tree must have a new directory, qemu-bu

[PATCH v6 5/7] datadir: Use bundle mechanism

2022-06-15 Thread Akihiko Odaki
softmmu/datadir.c had its own implementation to find files in the build tree, but now bundle mechanism provides the unified implementation which works for datadir and the other files. Signed-off-by: Akihiko Odaki --- .travis.yml | 2 +- pc-bios/keymaps/meson.build | 2 ++ pc-bi

[PULL 15/18] vfio-user: handle device interrupts

2022-06-15 Thread Stefan Hajnoczi
From: Jagannathan Raman Forward remote device's interrupts to the guest Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Message-id: 9523479eaafe050677f4de2af5dd0df18c27cfd9.1655151679.git.jag.ra...@oracle.com Signed-off-by: Stefan Hajnoczi ---

[PULL 18/18] linux-aio: explain why max batch is checked in laio_io_unplug()

2022-06-15 Thread Stefan Hajnoczi
It may not be obvious why laio_io_unplug() checks max batch. I discussed this with Stefano and have added a comment summarizing the reason. Cc: Stefano Garzarella Cc: Kevin Wolf Signed-off-by: Stefan Hajnoczi Reviewed-by: Stefano Garzarella Message-id: 20220609164712.1539045-3-stefa...@redhat.

[PATCH v6 2/7] qga: Relocate a path emitted in the help text

2022-06-15 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- qga/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/main.c b/qga/main.c index c373fec3ee6..06e507b9979 100644 --- a/qga/main.c +++ b/qga/main.c @@ -270,7 +270,7 @@ QEMU_HELP_BOTTOM "\n" , cmd, QGA_VIRTIO_PATH_DEFAULT, QGA_SERIAL

[PATCH v6 7/7] net: Use bundle mechanism

2022-06-15 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- meson.build | 2 ++ net/tap.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index ab5ab85bf4e..72e42048cbe 100644 --- a/meson.build +++ b/meson.build @@ -3574,6 +3574,8 @@ if have_tools dependenci

Re: [PATCH v7 04/13] migration: Export ram_transferred_ram()

2022-06-15 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.h | 2 ++ > migration/ram.c | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/migration/ram.h b/migration/ram.h > index ded0a3a086..7b

[PATCH v6 6/7] ui/icons: Use bundle mechanism

2022-06-15 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 2 +- ui/gtk.c | 2 +- ui/icons/meson.build | 32 ui/sdl2.c| 4 ++-- 4 files changed, 28 insertions(+), 12 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 84c84e98fc5..2558

Re: [PATCH v4 7/7] tests/9pfs: check fid being unaffected in fs_walk_2nd_nonexistent

2022-06-15 Thread Greg Kurz
On Tue, 15 Mar 2022 11:08:47 +0100 Christian Schoenebeck wrote: > Extend previously added test case by checking that fid was unaffected > by 'Twalk' request (i.e. when 2nd path component of request being > invalid). Do that by subsequently sending a 'Tgetattr' request with > the fid previously us

Re: [PATCH v4 5/7] 9pfs: fix 'Twalk' to only send error if no component walked

2022-06-15 Thread Christian Schoenebeck
On Mittwoch, 15. Juni 2022 17:52:49 CEST Greg Kurz wrote: > On Tue, 15 Mar 2022 11:08:39 +0100 > > Christian Schoenebeck wrote: > > Current implementation of 'Twalk' request handling always sends an > > 'Rerror' > > > > response if any error occured. The 9p2000 protocol spec says though: > > "

Re: [PATCH 2/5] tests/qemu-iotests: skip 108 when FUSE is not loaded

2022-06-15 Thread Daniel P . Berrangé
On Wed, Jun 15, 2022 at 11:48:02AM -0400, John Snow wrote: > On Wed, Jun 15, 2022 at 11:33 AM Daniel P. Berrangé > wrote: > > > > On Wed, Jun 15, 2022 at 09:41:32AM -0400, John Snow wrote: > > > On Tue, Jun 14, 2022 at 10:30 AM John Snow wrote: > > > > > > > > On Tue, Jun 14, 2022 at 4:59 AM Dan

[PATCH] softmmu: Always initialize xlat in address_space_translate_for_iotlb

2022-06-15 Thread Richard Henderson
The bug is an uninitialized memory read, along the translate_fail path, which results in garbage being read from iotlb_to_section, which can lead to a crash in io_readx/io_writex. The bug may be fixed by writing any value with zero in ~TARGET_PAGE_MASK, so that the call to iotlb_to_section using t

misaligned-pointer-use libslirp/src/tcp_input.c

2022-06-15 Thread Patrick Venture
Hey - I wanted to ask if someone else has seen this or has suggestions on how to fix it in libslirp / qemu. libslirp version: 3ad1710a96678fe79066b1469cead4058713a1d9 The blow is line: https://gitlab.freedesktop.org/slirp/libslirp/-/blob/master/src/tcp_input.c#L310 I0614 13:44:44.3040872040

[PATCH V8 04/39] memory: RAM_ANON flag

2022-06-15 Thread Steve Sistare
A memory-backend-ram or a memory-backend-memfd block with the RAM_SHARED flag set is not migrated when migrate_ignore_shared() is true, but this is wrong, because it has no named backing store, and its contents will be lost. Define a new flag RAM_ANON to distinguish this case. Cpr will also test

Re: [PATCH 0/4] Multiple interface support on top of Multi-FD

2022-06-15 Thread Daniel P . Berrangé
On Fri, Jun 10, 2022 at 05:58:31PM +0530, manish.mishra wrote: > > On 09/06/22 9:17 pm, Daniel P. Berrangé wrote: > > On Thu, Jun 09, 2022 at 07:33:01AM +, Het Gala wrote: > > > As of now, the multi-FD feature supports connection over the default > > > network > > > only. This Patchset series

Re: New "IndustryStandard" fw_cfg?

2022-06-15 Thread Tom Lendacky
On 6/15/22 10:19, Xiaoyao Li wrote: On 6/15/2022 8:46 AM, Xu, Min M wrote: I would like to add more engineers (Confidential Computing Reviewers in EDK2 community and Intel's QEMU engineers) in this mail thread. -Original Message- From: Dionna Amalie Glaze Sent: Wednesday, June 15, 20

Re: [PATCH v3 4/4] net: convert to use qemu_find_file to locate bridge helper

2022-06-15 Thread Akihiko Odaki
On 2022/06/15 21:04, Daniel P. Berrangé wrote: On Wed, Jun 15, 2022 at 01:42:58PM +0200, Paolo Bonzini wrote: On 6/15/22 12:52, Daniel P. Berrangé wrote: +case QEMU_FILE_TYPE_HELPER: +rel_install_dir = ""; +rel_build_dir = ""; +default_install_dir = default_helper_di

Re: [PATCH v6 1/7] datadir: Simplify firmware directory search

2022-06-15 Thread Daniel P . Berrangé
On Thu, Jun 16, 2022 at 12:56:28AM +0900, Akihiko Odaki wrote: > The old implementation had some code to accept multiple firmware > directories, but it is not used. It is used by distros. In Fedora builds for example: https://kojipkgs.fedoraproject.org/packages/qemu/7.0.0/1.fc37/data/logs/x86_64/

[python-qemu-qmp MR #7] readme: small fixes commands

2022-06-15 Thread GitLab Bot
Author: Beraldo Leal - https://gitlab.com/beraldoleal Merge Request: https://gitlab.com/qemu-project/python-qemu-qmp/-/merge_requests/7 ... from: beraldoleal/python-qemu-qmp:docs/readme ... into: qemu-project/python-qemu-qmp:main Just some small fixes that will make easier to copy and paste from

RE: [PATCH] virtio/vhost-user: Fix wrong vhost notifier GPtrArray size

2022-06-15 Thread Dong, Eddie
Reviewed-by: Eddie Dong > -Original Message- > From: Qemu-devel bounces+eddie.dong=intel@nongnu.org> On Behalf Of Yajun Wu > Sent: Wednesday, May 25, 2022 8:49 PM > To: qemu-devel@nongnu.org; m...@redhat.com; alex.ben...@linaro.org; > yaj...@nvidia.com > Cc: Parav Pandit > Subject:

[PATCH v7 0/6] cutils: Introduce bundle mechanism

2022-06-15 Thread Akihiko Odaki
Developers often run QEMU without installing. The bundle mechanism allows to look up files which should be present in installation even in such a situation. It is a general mechanism and can find any files located relative to the installation tree. The build tree must have a new directory, qemu-bu

[PATCH v7 2/6] Remove prefixes from path configuration macros

2022-06-15 Thread Akihiko Odaki
The path configuration macros are often supplied to get_relocated_path(), and the function had some logics to remove the prefixes. With this change, the prefixes are removed from those macros and get_relocated_path() is also simplified. This also fixes --firmwarepath configuration option. The old

[PATCH v7 4/6] datadir: Use bundle mechanism

2022-06-15 Thread Akihiko Odaki
softmmu/datadir.c had its own implementation to find files in the build tree, but now bundle mechanism provides the unified implementation which works for datadir and the other files. Signed-off-by: Akihiko Odaki --- .travis.yml | 2 +- pc-bios/keymaps/meson.build | 2 ++ pc-bi

[PATCH v7 3/6] cutils: Introduce bundle mechanism

2022-06-15 Thread Akihiko Odaki
Developers often run QEMU without installing. The bundle mechanism allows to look up files which should be present in installation even in such a situation. It is a general mechanism and can find any files located relative to the installation tree. The build tree must have a new directory, qemu-bu

[PATCH v7 5/6] ui/icons: Use bundle mechanism

2022-06-15 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 2 +- ui/gtk.c | 2 +- ui/icons/meson.build | 32 ui/sdl2.c| 4 ++-- 4 files changed, 28 insertions(+), 12 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 84c84e98fc5..2558

[PATCH v7 1/6] qga: Relocate a path emitted in the help text

2022-06-15 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- qga/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/main.c b/qga/main.c index c373fec3ee6..06e507b9979 100644 --- a/qga/main.c +++ b/qga/main.c @@ -270,7 +270,7 @@ QEMU_HELP_BOTTOM "\n" , cmd, QGA_VIRTIO_PATH_DEFAULT, QGA_SERIAL

[PATCH v7 6/6] net: Use bundle mechanism

2022-06-15 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- meson.build | 2 ++ net/tap.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 8961df266d1..5e0e08801c9 100644 --- a/meson.build +++ b/meson.build @@ -3574,6 +3574,8 @@ if have_tools dependenci

Re: [PATCH v5 2/3] target/riscv: Add stimecmp support

2022-06-15 Thread Atish Kumar Patra
On Wed, Jun 8, 2022 at 12:19 AM Alistair Francis wrote: > > On Mon, Jun 6, 2022 at 2:23 AM Atish Patra wrote: > > > > On Thu, Jun 2, 2022 at 12:02 AM Alistair Francis > > wrote: > > > > > > On Wed, Jun 1, 2022 at 4:16 AM Atish Patra wrote: > > > > > > > > stimecmp allows the supervisor mode to

Re: [PATCH 0/4] Multiple interface support on top of Multi-FD

2022-06-15 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Fri, Jun 10, 2022 at 05:58:31PM +0530, manish.mishra wrote: > > > > On 09/06/22 9:17 pm, Daniel P. Berrangé wrote: > > > On Thu, Jun 09, 2022 at 07:33:01AM +, Het Gala wrote: > > > > As of now, the multi-FD feature supports connection over

Re: [PATCH v6 5/7] datadir: Use bundle mechanism

2022-06-15 Thread Paolo Bonzini
On 6/15/22 17:56, Akihiko Odaki wrote: diff --git a/tests/vm/fedora b/tests/vm/fedora index 92b78d6e2c9..4ccd31bba61 100755 --- a/tests/vm/fedora +++ b/tests/vm/fedora @@ -79,7 +79,7 @@ class FedoraVM(basevm.BaseVM): self.exec_qemu_img("create", "-f", "qcow2", img_tmp, self.size)

Re: New "IndustryStandard" fw_cfg?

2022-06-15 Thread Dionna Amalie Glaze
> > > For Qemu, the main code I see for adding config is here, but I'm not sure > > > what y'all's preferred external configuration method is to get a value > > > from an > > Ideally no external configuration, although I suspect we need something > at least temporarily. Yes, whereas TDX can assum

Re: [PATCH v6 3/7] Remove prefixes from path configuration macros

2022-06-15 Thread Paolo Bonzini
On 6/15/22 17:56, Akihiko Odaki wrote: The path configuration macros are often supplied to get_relocated_path(), and the function had some logics to remove the prefixes. With this change, the prefixes are removed from those macros and get_relocated_path() is also simplified. Signed-off-by: Akih

Re: [PATCH v6 4/7] cutils: Introduce bundle mechanism

2022-06-15 Thread Paolo Bonzini
On 6/15/22 17:56, Akihiko Odaki wrote: +void list_bundle_candidates(const char *path) +{ +const char *dir = qemu_get_exec_dir(); +int i; + +for (i = 0; i < ARRAY_SIZE(bundle_formats); i++) { +printf(bundle_formats[i], dir, path); +putc('\n', stdout); +} This is n

Re: [PATCH v6 0/7] cutils: Introduce bundle mechanism

2022-06-15 Thread Paolo Bonzini
On 6/15/22 17:56, Akihiko Odaki wrote: Developers often run QEMU without installing. The bundle mechanism allows to look up files which should be present in installation even in such a situation. It is a general mechanism and can find any files located relative to the installation tree. The buil

Re: [PATCH v7 0/6] cutils: Introduce bundle mechanism

2022-06-15 Thread Paolo Bonzini
On 6/15/22 19:33, Akihiko Odaki wrote: Developers often run QEMU without installing. The bundle mechanism allows to look up files which should be present in installation even in such a situation. It is a general mechanism and can find any files located relative to the installation tree. The buil

[PATCH 09/11] target/ppc: Move slbfee to decodetree

2022-06-15 Thread Lucas Coutinho
Signed-off-by: Lucas Coutinho --- target/ppc/helper.h | 2 +- target/ppc/insn32.decode | 2 ++ target/ppc/mmu-hash64.c | 2 +- target/ppc/translate.c | 26 --- target/ppc/translate/storage-ctrl-

[PATCH 01/11] target/ppc: receive DisasContext explicitly in GEN_PRIV

2022-06-15 Thread Lucas Coutinho
From: Matheus Ferst GEN_PRIV and related CHK_* macros just assumed that variable named "ctx" would be in scope when they are used, and that it would be a pointer to DisasContext. Change these macros to receive the pointer explicitly. Signed-off-by: Matheus Ferst Signed-off-by: Lucas Coutinho -

[PATCH 06/11] target/ppc: Move slbmte to decodetree

2022-06-15 Thread Lucas Coutinho
Signed-off-by: Lucas Coutinho --- target/ppc/helper.h | 2 +- target/ppc/insn32.decode | 2 ++ target/ppc/mmu-hash64.c | 2 +- target/ppc/translate.c | 14 -- target/ppc/translate/storage-ctrl-i

[PATCH 11/11] target/ppc: Implement slbiag

2022-06-15 Thread Lucas Coutinho
Signed-off-by: Lucas Coutinho --- target/ppc/helper.h | 1 + target/ppc/insn32.decode | 4 +++ target/ppc/mmu-hash64.c | 27 target/ppc/translate/storage-ctrl-impl.c.inc | 14 ++ 4 files changed, 46 i

[PATCH 02/11] target/ppc: add macros to check privilege level

2022-06-15 Thread Lucas Coutinho
From: Matheus Ferst Equivalent to CHK_SV and CHK_HV, but can be used in decodetree methods. Signed-off-by: Matheus Ferst Signed-off-by: Lucas Coutinho --- target/ppc/translate.c | 21 + target/ppc/translate/fixedpoint-impl.c.inc | 7 ++- 2 files ch

[PATCH 07/11] target/ppc: Move slbmfev to decodetree

2022-06-15 Thread Lucas Coutinho
Signed-off-by: Lucas Coutinho --- target/ppc/helper.h | 2 +- target/ppc/insn32.decode | 2 ++ target/ppc/mmu-hash64.c | 2 +- target/ppc/translate.c | 12 target/ppc/translate/storage-ctrl-imp

[PATCH 00/11] target/ppc: Implement slbiag move slb* to decodetree

2022-06-15 Thread Lucas Coutinho
Implement the following PowerISA v3.0 instuction: slbiag: SLB Invalidate All Global X-form Move the following PowerISA v3.0 instuction to decodetree: slbie: SLB Invalidate Entry X-form slbieg: SLB Invalidate Entry Global X-form slbia: SLB Invalidate All X-form slbmte: SLB Move To Entry X-form slbm

[PATCH 03/11] target/ppc: Move slbie to decodetree

2022-06-15 Thread Lucas Coutinho
Signed-off-by: Lucas Coutinho --- target/ppc/helper.h | 2 +- target/ppc/insn32.decode | 7 +++ target/ppc/mmu-hash64.c | 2 +- target/ppc/translate.c | 13 - target/ppc/translate/storage-ct

[PATCH 04/11] target/ppc: Move slbieg to decodetree

2022-06-15 Thread Lucas Coutinho
Signed-off-by: Lucas Coutinho --- target/ppc/helper.h | 2 +- target/ppc/insn32.decode | 1 + target/ppc/mmu-hash64.c | 2 +- target/ppc/translate.c | 13 - target/ppc/translate/storage-ctrl-imp

[PATCH 05/11] target/ppc: Move slbia to decodetree

2022-06-15 Thread Lucas Coutinho
Signed-off-by: Lucas Coutinho --- target/ppc/helper.h | 2 +- target/ppc/insn32.decode | 5 + target/ppc/mmu-hash64.c | 2 +- target/ppc/translate.c | 17 - target/ppc/translate/storage-

[PATCH 08/11] target/ppc: Move slbmfee to decodetree

2022-06-15 Thread Lucas Coutinho
Signed-off-by: Lucas Coutinho --- target/ppc/helper.h | 2 +- target/ppc/insn32.decode | 1 + target/ppc/mmu-hash64.c | 2 +- target/ppc/translate.c | 13 - target/ppc/translate/storage-ctrl-imp

Re: [PATCH v2] docs: add PCIe root bus for VGA compat guideline

2022-06-15 Thread Alex Williamson
On Tue, 14 Jun 2022 10:52:52 +0200 Gerd Hoffmann wrote: > On Mon, Jun 13, 2022 at 03:47:04PM +0200, Laszlo Ersek wrote: > > On 06/12/22 19:32, Kevin Locke wrote: > > > PCI Express devices which use legacy VGA compatibility should be placed > > > on the Root Complex. This simplifies ioport acce

[PATCH 10/11] target/ppc: Move slbsync to decodetree

2022-06-15 Thread Lucas Coutinho
Signed-off-by: Lucas Coutinho --- target/ppc/insn32.decode | 2 ++ target/ppc/translate.c | 17 - target/ppc/translate/storage-ctrl-impl.c.inc | 14 ++ 3 files changed, 16 insertions(+), 17 deletions(-) diff --git a/target/pp

Re: [PATCH V8 04/39] memory: RAM_ANON flag

2022-06-15 Thread David Hildenbrand
On 15.06.22 16:51, Steve Sistare wrote: > A memory-backend-ram or a memory-backend-memfd block with the RAM_SHARED > flag set is not migrated when migrate_ignore_shared() is true, but this > is wrong, because it has no named backing store, and its contents will be > lost. Define a new flag RAM_ANO

[PATCH] target/riscv/pmp: guard against PMP ranges with a negative size

2022-06-15 Thread Nicolas Pitre
For a TOR entry to match, the stard address must be lower than the end address. Normally this is always the case, but correct code might still run into the following scenario: Initial state: pmpaddr3 = 0x2000 pmp3cfg = OFF pmpaddr4 = 0x3000 pmp4cfg = TOR Execution:

Re: [PULL 00/18] Block patches

2022-06-15 Thread Richard Henderson
On 6/15/22 08:51, Stefan Hajnoczi wrote: The following changes since commit 8e6c70b9d4a1b1f3011805947925cfdb31642f7f: Merge tag 'kraxel-20220614-pull-request' of git://git.kraxel.org/qemu into staging (2022-06-14 06:21:46 -0700) are available in the Git repository at: https://gitlab.com

[PATCH v2 0/2] handling guest multiple displays

2022-06-15 Thread Dongwon Kim
This patch seires is for adding some useful features for the guest os with multi-displays. First patch is to make all of guest displays visible when guest os is launched using "detach". Second patch is for providing a method to assign each guest display to specific physical monitor, which would be

[PATCH v2 2/2] ui/gtk: a new array param monitor to specify the target displays

2022-06-15 Thread Dongwon Kim
New integer array parameter, 'monitor' is for specifying the target displays where individual QEMU windows are placed upon launching. The array contains a series of numbers representing the monitor where QEMU windows are placed. Numbers in the array are mapped to QEMU windows like, [1st detached

[PATCH v2 1/2] ui/gtk: detach VCS for additional guest displays

2022-06-15 Thread Dongwon Kim
Detaching any addtional guest displays in case there are multiple displays assigned to the guest OS (e.g. max_outputs=n) so that all of them are visible upon lauching. v2: - check if the type of VC is GD_VC_GFX before qemu_console_is_graphic (Gerd Hoffman) - vc[0] is always primary guest

[PATCH 2/4] slirp: Update SlirpConfig version to 5

2022-06-15 Thread Peter Delevoryas
I think we probably need a new Slirp release (4.8.0) and a switch statement here instead, right? So that we can preserve the behavior for 4.7.0? Signed-off-by: Peter Delevoryas --- net/slirp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/slirp.c b/net/slirp.c index 86

[PATCH 0/4] slirp: Update submodule to include NC-SI features

2022-06-15 Thread Peter Delevoryas
I recently submitted some NC-SI changes ([1], [2]) to libslirp, and I'd like to include them as netdev options in QEMU now. I'm guessing that before we can do that though, there probably needs to be a new libslirp release, right? Right now we're on 4.7.0, with SlirpConfig version 4. I guess I'd li

[PATCH 1/4] slirp: Update submodule to include NC-SI updates

2022-06-15 Thread Peter Delevoryas
There hasn't been a new libslirp release yet, but I don't see any reason in particular why we couldn't update to this commit to support the new NC-SI functionality added in !122 and !125, as long as it doesn't break backwards compatibility with anything. [1] https://gitlab.freedesktop.org/slirp/li

[PATCH 4/4] slirp: Add oob-eth-addr to -netdev options

2022-06-15 Thread Peter Delevoryas
With this change, you can now request the out-of-band MAC address from slirp in fby35-bmc: wget https://github.com/facebook/openbmc/releases/download/openbmc-e2294ff5d31d/fby35.mtd qemu-system-arm -machine fby35-bmc \ -drive file=fby35.mtd,format=raw,if=mtd \ -nographic \

[PATCH 3/4] slirp: Add mfr-id to -netdev options

2022-06-15 Thread Peter Delevoryas
This lets you set the manufacturer's ID for a slirp netdev, which can be queried from the guest through the Get Version ID NC-SI command. For example, by setting the manufacturer's ID to 0x8119: wget https://github.com/facebook/openbmc/releases/download/openbmc-e2294ff5d31d/fby35.mtd qemu

<    1   2   3   >