Re: make -j check failing on master, interesting valgrind errors on qos-test vhost-user-blk-test/basic

2022-05-27 Thread Dario Faggioli
On Thu, 2022-05-26 at 20:18 +0200, Claudio Fontana wrote: > Forget about his aspect, I think it is a separate problem. > > valgind of qos-test when run restricted to those specific paths (-p > /x86_64/pc/i440FX-pcihost/pci-bus-pc/pci-bus/virtio-net-pci/virtio- > net/virtio-net-tests/vhost-user/rec

Re: make -j check failing on master, interesting valgrind errors on qos-test vhost-user-blk-test/basic

2022-05-27 Thread Claudio Fontana
On 5/27/22 9:26 AM, Dario Faggioli wrote: > On Thu, 2022-05-26 at 20:18 +0200, Claudio Fontana wrote: >> Forget about his aspect, I think it is a separate problem. >> >> valgind of qos-test when run restricted to those specific paths (-p >> /x86_64/pc/i440FX-pcihost/pci-bus-pc/pci-bus/virtio-net-pc

Re: [RFC PATCH v4 22/36] i386/tdx: Track RAM entries for TDX VM

2022-05-27 Thread Xiaoyao Li
On 5/26/2022 3:33 PM, Xiaoyao Li wrote: On 5/24/2022 3:37 PM, Gerd Hoffmann wrote: +    if (e->address == address && e->length == length) { +    e->type = TDX_RAM_ADDED; +    } else if (e->address == address) { +    e->address += length; +    e->length -= length

Re: [RFC PATCH v4 22/36] i386/tdx: Track RAM entries for TDX VM

2022-05-27 Thread Xiaoyao Li
On 5/27/2022 2:48 AM, Isaku Yamahata wrote: On Thu, May 26, 2022 at 03:33:10PM +0800, Xiaoyao Li wrote: On 5/24/2022 3:37 PM, Gerd Hoffmann wrote: I think all this can be simplified, by (1) Change the existing entry to cover the accepted ram range. (2) If there is room before the acce

[PATCH 1/1] nbd: trace long NBD operations

2022-05-27 Thread Denis V. Lunev
At the moment there are 2 sources of lengthy operations if configured: * open connection, which could retry inside and * reconnect of already opened connection These operations could be quite lengthy and cumbersome to catch thus it would be quite natural to add trace points for them. This patch is

HELP: I can't get whpx working on ryzen / win11

2022-05-27 Thread 刘辉
CPU: AMD Ryzen 7 5800H Windows Version: Microsoft Windows [Version 10.0.22621.1] QEMU Versions D:\dev\qemu-toby>D:/dev/qemu/qemu-system-x86_64.exe -version QEMU emulator version 7.0.0 (v7.0.0-11902-g1d935f4a02-dirty) Copyright (c) 2003-2022 Fabrice Bellard and the QEMU Project de

Re: [PATCH v3 2/9] replay: notify vCPU when BH is scheduled

2022-05-27 Thread Pavel Dovgalyuk
On 26.05.2022 15:10, Paolo Bonzini wrote: On 5/26/22 11:51, Pavel Dovgalyuk wrote: At least aio_bh_schedule_oneshot_full should have the same effect, so should this be done at a lower level, in aio_bh_enqueue() or even aio_notify()? Not sure about aio_notify. It can operate with different c

Introduce akcipher service for virtio-crypto

2022-05-27 Thread zhenwei pi
v7 - v8: - The changes of QEMU crypto has been reviewed & merged by Daniel, remove this part from this series. Thanks to Daniel! - virtio_crypto.h is updated by e4082063e47e ("linux-headers: Update to v5.18-rc6"), remove from this series. - Minor fixes reviewed by Gonglei. Thanks to Gonglei! v

[PATCH v8 1/1] crypto: Introduce RSA algorithm

2022-05-27 Thread zhenwei pi
There are two parts in this patch: 1, support akcipher service by cryptodev-builtin driver 2, virtio-crypto driver supports akcipher service In principle, we should separate this into two patches, to avoid compiling error, merge them into one. Then virtio-crypto gets request from guest side, and

Re: [PATCH 1/1] nbd: trace long NBD operations

2022-05-27 Thread Vladimir Sementsov-Ogievskiy
On 5/27/22 11:43, Denis V. Lunev wrote: At the moment there are 2 sources of lengthy operations if configured: * open connection, which could retry inside and * reconnect of already opened connection These operations could be quite lengthy and cumbersome to catch thus it would be quite natural to

Re: [PATCH 1/1] nbd: trace long NBD operations

2022-05-27 Thread Vladimir Sementsov-Ogievskiy
On 5/27/22 11:43, Denis V. Lunev wrote: +++ b/nbd/client-connection.c @@ -23,6 +23,7 @@ */ #include "qemu/osdep.h" +#include "trace.h" #include "block/nbd.h" @@ -210,6 +211,7 @@ static void *connect_thread_func(void *opaque) object_unref(OBJECT(conn->sioc));

[libvirt PATCH] tools: add virt-qmp-proxy for proxying QMP clients to libvirt QEMU guests

2022-05-27 Thread Daniel P . Berrangé
Libvirt provides QMP passthrough APIs for the QEMU driver and these are exposed in virsh. It is not especially pleasant, however, using the raw QMP JSON syntax. QEMU has a tool 'qmp-shell' which can speak QMP and exposes a human friendly interactive shell. It is not possible to use this with libvir

Re: [PATCH v3 01/10] block: Add a 'flags' param to bdrv_{pread,pwrite,pwrite_sync}()

2022-05-27 Thread Vladimir Sementsov-Ogievskiy
On 5/19/22 17:48, Alberto Faria wrote: For consistency with other I/O functions, and in preparation to implement them using generated_co_wrapper. Callers were updated using this Coccinelle script: @@ expression child, offset, buf, bytes; @@ - bdrv_pread(child, offset, buf, bytes)

Re: make -j check failing on master, interesting valgrind errors on qos-test vhost-user-blk-test/basic

2022-05-27 Thread Claudio Fontana
On 5/27/22 10:18 AM, Claudio Fontana wrote: > On 5/27/22 9:26 AM, Dario Faggioli wrote: >> On Thu, 2022-05-26 at 20:18 +0200, Claudio Fontana wrote: >>> Forget about his aspect, I think it is a separate problem. >>> >>> valgind of qos-test when run restricted to those specific paths (-p >>> /x86_64

[PATCH] tests/tcg/s390x: Test overflow conditions

2022-05-27 Thread Gautam Agrawal
Add a test to check for overflow conditions in s390x. This patch is based on the following patches : * https://git.qemu.org/?p=qemu.git;a=commitdiff;h=5a2e67a691501 * https://git.qemu.org/?p=qemu.git;a=commitdiff;h=fc6e0d0f2db51 Signed-off-by: Gautam Agrawal --- tests/tcg/s390x/Makefile.target

Re: [libvirt PATCH] tools: add virt-qmp-proxy for proxying QMP clients to libvirt QEMU guests

2022-05-27 Thread Peter Krempa
On Fri, May 27, 2022 at 10:47:58 +0100, Daniel P. Berrangé wrote: > Libvirt provides QMP passthrough APIs for the QEMU driver and these are > exposed in virsh. It is not especially pleasant, however, using the raw > QMP JSON syntax. QEMU has a tool 'qmp-shell' which can speak QMP and > exposes a hu

Re: [libvirt PATCH] tools: add virt-qmp-proxy for proxying QMP clients to libvirt QEMU guests

2022-05-27 Thread Claudio Fontana
On 5/27/22 12:20 PM, Peter Krempa wrote: > On Fri, May 27, 2022 at 10:47:58 +0100, Daniel P. Berrangé wrote: >> Libvirt provides QMP passthrough APIs for the QEMU driver and these are >> exposed in virsh. It is not especially pleasant, however, using the raw >> QMP JSON syntax. QEMU has a tool 'qmp

[PATCH v4 0/9] Record/replay refactoring and stuff

2022-05-27 Thread Pavel Dovgalyuk
The following series includes the following record/replay-related changes: - simplified async event processing - updated record/replay documentation, which was also converted to rst - avocado tests for record/replay of Linux for x86_64 and Aarch64 - some bugfixes v4 changes: - moved vCPU notifica

[PATCH v4 5/9] docs: convert docs/devel/replay page to rst

2022-05-27 Thread Pavel Dovgalyuk
This patch converts prior .txt replay devel documentation to .rst. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Richard Henderson --- docs/devel/index-tcg.rst |1 + docs/devel/replay.rst| 54 ++ docs/devel/replay.txt| 46 ---

Re: make -j check failing on master, interesting valgrind errors on qos-test vhost-user-blk-test/basic

2022-05-27 Thread Dario Faggioli
On Fri, 2022-05-27 at 10:18 +0200, Claudio Fontana wrote: > On 5/27/22 9:26 AM, Dario Faggioli wrote: > > > > > Yes, this kind of matches what I've also seen and reported about in > > <5bcb5ceb44dd830770d66330e27de6a4345fcb69.ca...@suse.com>. If > > enable/run just one of: > > - reconnect > > - fl

[PATCH v4 3/9] replay: rewrite async event handling

2022-05-27 Thread Pavel Dovgalyuk
This patch decouples checkpoints and async events. It was a tricky part of replay implementation. Now it becomes much simpler and easier to maintain. Signed-off-by: Pavel Dovgalyuk Acked-by: Richard Henderson --- accel/tcg/tcg-accel-ops-icount.c |5 +-- docs/replay.txt |

[PATCH v4 2/9] replay: notify vCPU when BH is scheduled

2022-05-27 Thread Pavel Dovgalyuk
vCPU execution should be suspended when new BH is scheduled. This is needed to avoid guest timeouts caused by the long cycles of the execution. In replay mode execution may hang when vCPU sleeps and block event comes to the queue. This patch adds notification which wakes up vCPU or interrupts execu

Re: [PATCH] ppc: fix boot with sam460ex

2022-05-27 Thread BALATON Zoltan
Hello, Some changes to commit message (patch is OK). On Thu, 26 May 2022, Michael S. Tsirkin wrote: Recent changes to pcie_host corrected size of its internal region to match what it expects - only the low 28 bits are ever decoded. Previous code just ignored bit 29 (if size was 1 << 29) in the

[PATCH v4 4/9] replay: simplify async event processing

2022-05-27 Thread Pavel Dovgalyuk
This patch joins replay event id and async event id into single byte in the log. It makes processing a bit faster and log a bit smaller. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Richard Henderson -- v2: minor enum fixes (suggested by Richard Henderson) --- replay/replay-events.c | 36 +

[PATCH v4 1/9] replay: fix event queue flush for qemu shutdown

2022-05-27 Thread Pavel Dovgalyuk
This patch fixes event queue flush in the case of emulator shutdown. replay_finish_events should be called when replay_mode is not cleared. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Richard Henderson --- replay/replay.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/

[PATCH v4 6/9] docs: move replay docs to docs/system/replay.rst

2022-05-27 Thread Pavel Dovgalyuk
This patch adds replay description page, converting prior text from docs/replay.txt. The text was also updated and some sections were moved to devel part of the docs. Signed-off-by: Pavel Dovgalyuk Acked-by: Richard Henderson --- docs/devel/replay.rst | 264 ++- do

[PATCH v4 8/9] tests/avocado: add replay Linux tests for virtio machine

2022-05-27 Thread Pavel Dovgalyuk
This patch adds two tests for replaying Linux boot process on x86_64 virtio platform. Signed-off-by: Pavel Dovgalyuk --- tests/avocado/replay_linux.py | 26 ++ 1 file changed, 26 insertions(+) diff --git a/tests/avocado/replay_linux.py b/tests/avocado/replay_linux.py i

[PATCH v4 7/9] tests/avocado: update replay_linux test

2022-05-27 Thread Pavel Dovgalyuk
This patch updates replay_linux test to make it compatible with new LinuxTest class. Signed-off-by: Pavel Dovgalyuk --- tests/avocado/replay_linux.py | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/tests/avocado/replay_linux.py b/tests/avocado/replay_li

Re: [libvirt PATCH] tools: add virt-qmp-proxy for proxying QMP clients to libvirt QEMU guests

2022-05-27 Thread Peter Krempa
On Fri, May 27, 2022 at 12:35:45 +0200, Claudio Fontana wrote: > On 5/27/22 12:20 PM, Peter Krempa wrote: > > On Fri, May 27, 2022 at 10:47:58 +0100, Daniel P. Berrangé wrote: > >> Libvirt provides QMP passthrough APIs for the QEMU driver and these are > >> exposed in virsh. It is not especially pl

[PATCH v4 9/9] tests/avocado: add replay Linux test for Aarch64 machines

2022-05-27 Thread Pavel Dovgalyuk
This patch adds two tests for replaying Linux boot process on Aarch64 platform. Signed-off-by: Pavel Dovgalyuk --- tests/avocado/replay_linux.py | 41 + 1 file changed, 41 insertions(+) diff --git a/tests/avocado/replay_linux.py b/tests/avocado/replay_l

Re: make -j check failing on master, interesting valgrind errors on qos-test vhost-user-blk-test/basic

2022-05-27 Thread Alex Bennée
Dario Faggioli writes: > [[PGP Signed Part:Undecided]] > On Fri, 2022-05-27 at 10:18 +0200, Claudio Fontana wrote: >> On 5/27/22 9:26 AM, Dario Faggioli wrote: >> > > >> > Yes, this kind of matches what I've also seen and reported about in >> > <5bcb5ceb44dd830770d66330e27de6a4345fcb69.ca...@s

Re: [PATCH] ppc: fix boot with sam460ex

2022-05-27 Thread Michael S. Tsirkin
On Fri, May 27, 2022 at 12:46:57PM +0200, BALATON Zoltan wrote: > Hello, > > Some changes to commit message (patch is OK). Want to write the commit message for me then? > On Thu, 26 May 2022, Michael S. Tsirkin wrote: > > Recent changes to pcie_host corrected size of its internal region to > >

Re: [libvirt PATCH] tools: add virt-qmp-proxy for proxying QMP clients to libvirt QEMU guests

2022-05-27 Thread Daniel P . Berrangé
On Fri, May 27, 2022 at 12:20:39PM +0200, Peter Krempa wrote: > On Fri, May 27, 2022 at 10:47:58 +0100, Daniel P. Berrangé wrote: > > Libvirt provides QMP passthrough APIs for the QEMU driver and these are > > exposed in virsh. It is not especially pleasant, however, using the raw > > QMP JSON synt

Re: [libvirt PATCH] tools: add virt-qmp-proxy for proxying QMP clients to libvirt QEMU guests

2022-05-27 Thread Daniel P . Berrangé
On Fri, May 27, 2022 at 12:35:45PM +0200, Claudio Fontana wrote: > On 5/27/22 12:20 PM, Peter Krempa wrote: > > On Fri, May 27, 2022 at 10:47:58 +0100, Daniel P. Berrangé wrote: > >> Libvirt provides QMP passthrough APIs for the QEMU driver and these are > >> exposed in virsh. It is not especially

Re: [PATCH 1/1] nbd: trace long NBD operations

2022-05-27 Thread Denis V. Lunev
On 27.05.2022 11:33, Vladimir Sementsov-Ogievskiy wrote: On 5/27/22 11:43, Denis V. Lunev wrote: At the moment there are 2 sources of lengthy operations if configured: * open connection, which could retry inside and * reconnect of already opened connection These operations could be quite lengthy

Re: [PATCH 1/1] nbd: trace long NBD operations

2022-05-27 Thread Denis V. Lunev
On 27.05.2022 11:36, Vladimir Sementsov-Ogievskiy wrote: On 5/27/22 11:43, Denis V. Lunev wrote: +++ b/nbd/client-connection.c @@ -23,6 +23,7 @@    */     #include "qemu/osdep.h" +#include "trace.h"     #include "block/nbd.h"   @@ -210,6 +211,7 @@ static void *connect_thread_func(void *opaque)  

Re: [PATCH 1/4] qdev: add DEVICE_RUNTIME_ERROR event

2022-05-27 Thread Roman Kagan
On Wed, May 25, 2022 at 12:54:47PM +0200, Markus Armbruster wrote: > Konstantin Khlebnikov writes: > > > This event represents device runtime errors to give time and > > reason why device is broken. > > Can you give an or more examples of the "device runtime errors" you have > in mind? Initiall

Re: [PATCH 0/5] gitlab: restrict running jobs in forks and upstream master

2022-05-27 Thread Alex Bennée
Daniel P. Berrangé writes: > Currently on upstream most jobs will run in both staging > and master. This is quite wasteful of CI credits. The only > need to run in master is for the jobs related to publishing > the website > > In forks we run jobs on every push. With restricted CI > allowance t

Re: [PATCH] tests/tcg/s390x: Test overflow conditions

2022-05-27 Thread Alex Bennée
Gautam Agrawal writes: > Add a test to check for overflow conditions in s390x. > This patch is based on the following patches : > * https://git.qemu.org/?p=qemu.git;a=commitdiff;h=5a2e67a691501 > * https://git.qemu.org/?p=qemu.git;a=commitdiff;h=fc6e0d0f2db51 > > Signed-off-by: Gautam Agrawal

[PULL 13/15] qga/wixl: simplify some pre-processing

2022-05-27 Thread marcandre . lureau
From: Marc-André Lureau Sadly, wixl doesn't have 'elif'. Signed-off-by: Marc-André Lureau Reviewed-by: Konstantin Kostiuk Message-Id: <20220525144140.591926-14-marcandre.lur...@redhat.com> --- qga/installer/qemu-ga.wxs | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-

Re: [PATCH v2] gitlab-ci: Switch the container of the 'check-patch' & 'check-dco' jobs

2022-05-27 Thread Alex Bennée
Thomas Huth writes: > The 'check-patch' and 'check-dco' jobs only need Python and git for > checking the patches, so it's not really necessary to use a container > here that has all the other build dependencies installed. By using a > lightweight Alpine container, we can improve the runtime her

[PULL 00/15] Misc patches

2022-05-27 Thread marcandre . lureau
From: Marc-André Lureau The following changes since commit 2417cbd5916d043e0c56408221fbe9935d0bc8da: Merge tag 'ak-pull-request' of https://gitlab.com/berrange/qemu into staging (2022-05-26 07:00:04 -0700) are available in the Git repository at: g...@gitlab.com:marcandre.lureau/qemu.git t

[PULL 02/15] util/win32: simplify qemu_get_local_state_dir()

2022-05-27 Thread marcandre . lureau
From: Marc-André Lureau SHGetFolderPath() is a deprecated API: https://docs.microsoft.com/en-us/windows/win32/api/shlobj_core/nf-shlobj_core-shgetfolderpatha It is a wrapper for SHGetKnownFolderPath() and CSIDL_COMMON_PATH is mapped to FOLDERID_ProgramData: https://docs.microsoft.com/en-us/windo

[PULL 05/15] qga: add qga_open_cloexec() helper

2022-05-27 Thread marcandre . lureau
From: Marc-André Lureau QGA calls qemu_open_old() in various places. Calling qemu_open() instead isn't a great alternative, as it has special "/dev/fdset" handling and depends on QEMU internal monitor data structures. Instead, provide a simple helper for QGA needs, with Error* support. The follo

[PULL 07/15] qga: throw an Error in ga_channel_open()

2022-05-27 Thread marcandre . lureau
From: Marc-André Lureau Allow for a single point of error reporting, and further refactoring. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster Message-Id: <20220525144140.591926-8-marcandre.lur...@redhat.com> --- qga/channel-posix.c | 42 +---

[PULL 01/15] include: move qemu_*_exec_dir() to cutils

2022-05-27 Thread marcandre . lureau
From: Marc-André Lureau The function is required by get_relocated_path() (already in cutils), and used by qemu-ga and may be generally useful. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster Message-Id: <20220525144140.591926-2-marcandre.lur...@redhat.com> --- include/qemu/cut

[PULL 03/15] tests: make libqmp buildable for win32

2022-05-27 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth Message-Id: <20220525144140.591926-4-marcandre.lur...@redhat.com> --- tests/qtest/libqmp.h | 2 ++ tests/qtest/libqmp.c | 34 +- 2 files changed, 31 insertions(+), 5 deletions(-)

[PULL 12/15] qga/wixl: require Mingw_bin

2022-05-27 Thread marcandre . lureau
From: Marc-André Lureau No clear reason to make guesses here. Signed-off-by: Marc-André Lureau Reviewed-by: Konstantin Kostiuk Message-Id: <20220525144140.591926-13-marcandre.lur...@redhat.com> --- qga/installer/qemu-ga.wxs | 9 - 1 file changed, 9 deletions(-) diff --git a/qga/insta

[PULL 04/15] qga: flatten safe_open_or_create()

2022-05-27 Thread marcandre . lureau
From: Marc-André Lureau There is a bit too much nesting in the function, this can be simplified a bit to improve readability. This also helps with the following error handling changes. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster Message-Id: <20220525144140.591926-5-marcand

[PULL 08/15] qga: replace qemu_open_old() with qga_open_cloexec()

2022-05-27 Thread marcandre . lureau
From: Marc-André Lureau qemu_open_old() uses qemu_open_internal() which handles special "/dev/fdset/" path for monitor fd sets, set CLOEXEC, and uses Error reporting (and some O_DIRECT special error casing). The monitor fdset handling is unnecessary for qga, use qga_open_cloexec() instead. Sign

[PULL 06/15] qga: use qga_open_cloexec() for safe_open_or_create()

2022-05-27 Thread marcandre . lureau
From: Marc-André Lureau The function takes care of setting CLOEXEC. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster Message-Id: <20220525144140.591926-7-marcandre.lur...@redhat.com> --- qga/commands-posix.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --g

[PULL 11/15] qga/wixl: prefer variables over environment

2022-05-27 Thread marcandre . lureau
From: Marc-André Lureau No need to setup an environment or to check if the variable is undefined manually. Signed-off-by: Marc-André Lureau Reviewed-by: Konstantin Kostiuk Message-Id: <20220525144140.591926-12-marcandre.lur...@redhat.com> --- qga/installer/qemu-ga.wxs | 30 +--

[PULL 09/15] qga: make build_fs_mount_list() return a bool

2022-05-27 Thread marcandre . lureau
From: Marc-André Lureau Change build_fs_mount_list() to return bool, in accordance with the guidance under = Rules = in include/qapi/error.h Signed-off-by: Marc-André Lureau Suggested-by: Markus Armbruster Message-Id: <20220525144140.591926-10-marcandre.lur...@redhat.com> --- qga/commands-pos

[PULL 10/15] test/qga: use G_TEST_DIR to locate os-release test file

2022-05-27 Thread marcandre . lureau
From: Marc-André Lureau This a more accurate way to lookup the test data, and will allow to move the test in a subproject. Signed-off-by: Marc-André Lureau Reviewed-by: Konstantin Kostiuk Message-Id: <20220525144140.591926-11-marcandre.lur...@redhat.com> --- tests/unit/test-qga.c | 11 +--

[PULL 14/15] qga/wixl: replace QEMU_GA_MSI_MINGW_BIN_PATH with glib bindir

2022-05-27 Thread marcandre . lureau
From: Marc-André Lureau Use more conventional variables to set the location of pre-built DLL/bin. Signed-off-by: Marc-André Lureau Reviewed-by: Konstantin Kostiuk Message-Id: <20220525144140.591926-15-marcandre.lur...@redhat.com> --- configure | 9 ++--- meson.build

[PULL 15/15] test/qga: use g_auto wherever sensible

2022-05-27 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Konstantin Kostiuk Message-Id: <20220525144140.591926-16-marcandre.lur...@redhat.com> --- tests/unit/test-qga.c | 121 +++--- 1 file changed, 43 insertions(+), 78 deletions(-) diff --git

Re: [PATCH v3 06/10] block: Make 'bytes' param of bdrv_co_{pread,pwrite,preadv,pwritev}() an int64_t

2022-05-27 Thread Eric Blake
On Thu, May 26, 2022 at 12:05:55PM +0100, Alberto Faria wrote: > On Thu, May 26, 2022 at 10:00 AM Stefan Hajnoczi wrote: > > Maybe let the existing bdrv_check_request32() call in bdrv_co_preadv() in bdrv_co_preadv_part() > > check this? It returns -EIO if bytes is too large. > > I'd be okay wit

Re: [libvirt PATCH] tools: add virt-qmp-proxy for proxying QMP clients to libvirt QEMU guests

2022-05-27 Thread Peter Krempa
On Fri, May 27, 2022 at 10:47:58 +0100, Daniel P. Berrangé wrote: > Libvirt provides QMP passthrough APIs for the QEMU driver and these are > exposed in virsh. It is not especially pleasant, however, using the raw > QMP JSON syntax. QEMU has a tool 'qmp-shell' which can speak QMP and > exposes a hu

Re: [PATCH v3 07/10] block: Implement bdrv_{pread,pwrite,pwrite_zeroes}() using generated_co_wrapper

2022-05-27 Thread Eric Blake
On Thu, May 26, 2022 at 08:23:02PM +0100, Alberto Faria wrote: > On Thu, May 26, 2022 at 9:55 AM Stefan Hajnoczi wrote: > > The bdrv_pread()/bdrv_pwrite() errno for negative bytes changes from > > EINVAL to EIO. Did you audit the code to see if it matters? > > I don't believe I had, but I checked

Re: [PATCH v6 8/8] linux-user: Add PowerPC ISA 3.1 and MMA to hwcap

2022-05-27 Thread Laurent Vivier
Le 24/05/2022 à 16:05, Lucas Mateus Castro(alqotel) a écrit : From: Joel Stanley These are new hwcap bits added for power10. Signed-off-by: Joel Stanley Signed-off-by: Lucas Mateus Castro (alqotel) Reviewed-by: Richard Henderson --- linux-user/elfload.c | 4 1 file changed, 4 insert

Re: [PATCH 0/9] tests, python: prepare to expand usage of test venv

2022-05-27 Thread John Snow
Paolo: I assume this falls under your jurisdiction...ish, unless Cleber (avocado) or Alex (tests more broadly) have any specific inputs. I'm fine with waiting for reviews, but don't know whose bucket this goes to. On Wed, May 25, 2022, 8:09 PM John Snow wrote: > GitLab CI: https://gitlab.com/j

Re: [PATCH v2] gitlab-ci: Switch the container of the 'check-patch' & 'check-dco' jobs

2022-05-27 Thread Alex Bennée
Alex Bennée writes: > Thomas Huth writes: > >> The 'check-patch' and 'check-dco' jobs only need Python and git for >> checking the patches, so it's not really necessary to use a container >> here that has all the other build dependencies installed. By using a >> lightweight Alpine container, w

Re: [PATCH v3 02/10] block: Change bdrv_{pread, pwrite, pwrite_sync}() param order

2022-05-27 Thread Vladimir Sementsov-Ogievskiy
On 5/19/22 17:48, Alberto Faria wrote: Swap 'buf' and 'bytes' around for consistency with bdrv_co_{pread,pwrite}(), and in preparation to implement these functions using generated_co_wrapper. Callers were updated using this Coccinelle script: @@ expression child, offset, buf, bytes, flags;

Re: [PULL 00/34] ppc queue

2022-05-27 Thread Richard Henderson
On 5/26/22 14:37, Daniel Henrique Barboza wrote: The following changes since commit 2417cbd5916d043e0c56408221fbe9935d0bc8da: Merge tag 'ak-pull-request' of https://gitlab.com/berrange/qemu into staging (2022-05-26 07:00:04 -0700) are available in the Git repository at: https://gitlab.c

[PATCH] tests/Makefile.include: Fix 'make check-help' output

2022-05-27 Thread Dario Faggioli
Since commit 3d2f73ef75e ("build: use "meson test" as the test harness"), check-report.tap is no more, and we have check-report.junit.xml. Update the output of 'make check-help', which was still listing 'check-report.tap', accordingly. Fixes: 3d2f73ef75e Signed-off-by: Dario Faggioli --- Cc: Pao

Re: [PATCH v6 6/8] vduse-blk: Implement vduse-blk export

2022-05-27 Thread Kevin Wolf
Am 23.05.2022 um 10:46 hat Xie Yongji geschrieben: > This implements a VDUSE block backends based on > the libvduse library. We can use it to export the BDSs > for both VM and container (host) usage. > > The new command-line syntax is: > > $ qemu-storage-daemon \ > --blockdev file,node-name=d

[PATCH v1 00/33] testing/next (gitlab, junit, lcitool, x-compile)

2022-05-27 Thread Alex Bennée
Hi, After a delay caused with other priorities I've finally managed to catch up with some of my maintainer duties. The result is the current testing/next branch which contains: - some GitLab fixes from Thomas - exposing JUnit to gitlab from Marc-André - more lcitool docker conversions from

[PATCH v1 02/33] .gitlab-ci.d/crossbuilds: Fix the dependency of the cross-i386-tci job

2022-05-27 Thread Alex Bennée
From: Thomas Huth The cross-i386-tci job uses the fedora-i386-cross image, so we should make sure that the corresponding job that builds it (the i386-fedora-cross-container job) has finished before we start the TCI job. Signed-off-by: Thomas Huth Reviewed-by: Richard Henderson Message-Id: <202

[PATCH v1 01/33] .gitlab-ci.d/container-cross: Fix RISC-V container dependencies / stages

2022-05-27 Thread Alex Bennée
From: Thomas Huth The "riscv64-debian-cross-container" job does not depend on any other container job from the first stage, so we can move it to the first stage, too. The "riscv64-debian-test-cross-container" job needs the debian11 container, so we should add a proper "needs:" statement here. S

[PATCH v1 03/33] gitlab-ci: add meson JUnit test result into report

2022-05-27 Thread Alex Bennée
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-Id: <20220525173411.612224-1-marcandre.lur...@redhat.com> Signed-off-by: Alex Bennée --- .gitlab-ci.d/buildtest-template.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitlab-ci.d/buildtest-template.yml b/.gitlab-ci.

[PATCH v1 08/33] tests/docker: update debian-mipsel-cross with lcitool

2022-05-27 Thread Alex Bennée
Use lcitool to update debian-mipsel-cross to a Debian 11 based system. Signed-off-by: Alex Bennée --- .gitlab-ci.d/container-cross.yml | 3 +- tests/docker/Makefile.include | 1 - .../dockerfiles/debian-mipsel-cross.docker| 179 +++--- tests/lcito

[PATCH v1 06/33] tests/docker: update debian-armhf-cross with lcitool

2022-05-27 Thread Alex Bennée
Use lcitool to update debian-armhf-cross to a Debian 11 based system. Signed-off-by: Alex Bennée --- .gitlab-ci.d/container-cross.yml | 3 +- tests/docker/Makefile.include | 1 - .../dockerfiles/debian-armhf-cross.docker | 184 +++--- tests/lcitoo

[PATCH v1 04/33] meson.build: fix summary display of test compilers

2022-05-27 Thread Alex Bennée
The recent refactoring of configure.sh dropped a number of variables we relied on for printing out information. Make it simpler. Fixes: eebf199c09 (tests/tcg: invoke Makefile.target directly from QEMU's makefile) Signed-off-by: Alex Bennée --- meson.build | 8 ++-- 1 file changed, 2 inserti

[PATCH v1 10/33] tests/docker: update debian-ppc64el-cross with lcitool

2022-05-27 Thread Alex Bennée
Use lcitool to update debian-ppc64el-cross to a Debian 11 based system. Signed-off-by: Alex Bennée --- .gitlab-ci.d/container-cross.yml | 3 +- tests/docker/Makefile.include | 1 - .../dockerfiles/debian-ppc64el-cross.docker | 178 +++--- tests/lcit

[PATCH v1 07/33] tests/docker: update debian-armel-cross with lcitool

2022-05-27 Thread Alex Bennée
Use lcitool to update debian-armel-cross to a Debian 11 based system. Signed-off-by: Alex Bennée --- .gitlab-ci.d/container-cross.yml | 3 +- tests/docker/Makefile.include | 1 - .../dockerfiles/debian-armel-cross.docker | 178 -- tests/lcitoo

[PATCH v1 14/33] build: add a more generic way to specify make->ninja dependencies

2022-05-27 Thread Alex Bennée
From: Paolo Bonzini Let any make target specify ninja goals that needs to be built for it (though selecting the goals is _not_ recursive on depending targets) instead of having a custom mechanism only for "make check" and "make bench". Signed-off-by: Paolo Bonzini Message-Id: <20220517092616.12

[PATCH v1 05/33] tests/lcitool: fix up indentation to correct style

2022-05-27 Thread Alex Bennée
3 space indentation snuck into the initial commit. Clean it up before we let it get established. I've also: - removed unused os import - added double lines between functions - added some comments and grouped and sorted the generation stanzas My lint tool is also recommending using f-strings

[PATCH v1 18/33] tests/tcg: merge configure.sh back into main configure script

2022-05-27 Thread Alex Bennée
From: Paolo Bonzini tests/tcg/configure.sh has a complicated story. In the beginning its code ran as part of the creation of config-target.mak files, and that is where it placed the information on the target compiler. However, probing for the buildability of TCG tests required multiple inclusion

Re: [PATCH v1 06/33] tests/docker: update debian-armhf-cross with lcitool

2022-05-27 Thread Daniel P . Berrangé
On Fri, May 27, 2022 at 04:35:36PM +0100, Alex Bennée wrote: > Use lcitool to update debian-armhf-cross to a Debian 11 based system. > > Signed-off-by: Alex Bennée > --- > .gitlab-ci.d/container-cross.yml | 3 +- > tests/docker/Makefile.include | 1 - > .../docke

[PATCH v1 09/33] tests/docker: update debian-mips64el-cross with lcitool

2022-05-27 Thread Alex Bennée
Use lcitool to update debian-mips64el-cross to a Debian 11 based system. Signed-off-by: Alex Bennée --- .gitlab-ci.d/container-cross.yml | 3 +- tests/docker/Makefile.include | 1 - .../dockerfiles/debian-mips64el-cross.docker | 177 +++--- tests/lci

Re: [PATCH v1 05/33] tests/lcitool: fix up indentation to correct style

2022-05-27 Thread Daniel P . Berrangé
On Fri, May 27, 2022 at 04:35:35PM +0100, Alex Bennée wrote: > 3 space indentation snuck into the initial commit. Clean it up before > we let it get established. I've also: > > - removed unused os import > - added double lines between functions > - added some comments and grouped and sorted

[PATCH v1 12/33] configure: do not define or use the CPP variable

2022-05-27 Thread Alex Bennée
From: Paolo Bonzini Just hardcode $(CC) -E, it should be enough. Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson Message-Id: <20220517092616.1272238-2-pbonz...@redhat.com> Signed-off-by: Alex Bennée --- configure | 3 --- pc-bios/optionrom/Makefile | 2 +- 2 file

Re: [PATCH v1 09/33] tests/docker: update debian-mips64el-cross with lcitool

2022-05-27 Thread Daniel P . Berrangé
On Fri, May 27, 2022 at 04:35:39PM +0100, Alex Bennée wrote: > Use lcitool to update debian-mips64el-cross to a Debian 11 based system. > > Signed-off-by: Alex Bennée > --- > .gitlab-ci.d/container-cross.yml | 3 +- > tests/docker/Makefile.include | 1 - > .../do

[PATCH v1 23/33] configure: move symlink configuration earlier

2022-05-27 Thread Alex Bennée
From: Paolo Bonzini Ensure that the pc-bios/optionrom and pc-bios/s390-ccw directory exist at the time when we'll write out the compiler configuration for them. Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini Message-Id: <20220517092616.1272238-13-pbonz...@redhat.com> Signed-off-by

[PATCH v1 17/33] tests/tcg: correct target CPU for sparc32

2022-05-27 Thread Alex Bennée
From: Paolo Bonzini We do not want v8plus for pure sparc32, as the difference with the V8 ABI are only meaningful on 64-bit CPUs suh as ultrasparc; supersparc is the best CPU to use for 32-bit. Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson Message-Id: <20220517092616.1272238-7-pb

[PATCH v1 26/33] configure: enable cross compilation of vof

2022-05-27 Thread Alex Bennée
From: Paolo Bonzini While container-based cross compilers are not supported, this already makes it possible to build vof on any machine that has an installation of GCC and binutils for 32- or 64-bit PowerPC. Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini Message-Id: <2022051709261

Re: [PATCH v1 33/33] docs/devel: clean-up the CI links in the docs

2022-05-27 Thread Daniel P . Berrangé
On Fri, May 27, 2022 at 04:36:03PM +0100, Alex Bennée wrote: > There where some broken links so fix those up with proper references > to the devel docs. I also did a little light copy-editing to reflect > the current state and broke up a paragraph to reduce the "wall of > text" effect. > > Signed-

[PATCH v1 11/33] tests/docker: update debian-amd64 with lcitool

2022-05-27 Thread Alex Bennée
The one minor wrinkle we need to account for is the netmap support still requires building from source. We also include cscope and GNU global as they are used in one of the builds. Signed-off-by: Alex Bennée Cc: Philippe Mathieu-Daudé Cc: Luigi Rizzo Cc: Giuseppe Lettieri Cc: Vincenzo Maffione

[PATCH v1 20/33] configure: handle host compiler in probe_target_compiler

2022-05-27 Thread Alex Bennée
From: Paolo Bonzini In preparation for handling more binaries than just cc, handle the case of "probe_target_compiler $cpu" directly in the function, setting the target_* variables based on the ones that are used to build QEMU. The clang check also needs to be moved after this fallback. Signed-

[PATCH v1 25/33] configure: enable cross-compilation of optionrom

2022-05-27 Thread Alex Bennée
From: Paolo Bonzini While container-based cross compilers are not supported, this already makes it possible to build x86 optionroms on any machine that has an installation of GCC and binutils for 32- or 64-bit x86. Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini Message-Id: <202205

[PATCH v1 29/33] gitlab: convert Cirrus jobs to .base_job_template

2022-05-27 Thread Alex Bennée
From: Daniel P. Berrangé This folds the Cirrus job rules into the base job template, introducing two new variables - QEMU_JOB_CIRRUS - identifies the job as making use of Cirrus CI via cirrus-run - QEMU_JOB_OPTIONAL - identifies the job as one that is not run by default, primarily d

[PATCH v1 24/33] configure: enable cross-compilation of s390-ccw

2022-05-27 Thread Alex Bennée
From: Paolo Bonzini While container-based cross compilers are not supported, this already makes it possible to build s390-ccw on any machine that has s390x GCC and binutils installed. Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini Message-Id: <20220517092616.1272238-14-pbonz...@re

[PATCH v1 28/33] gitlab: introduce a common base job template

2022-05-27 Thread Alex Bennée
From: Daniel P. Berrangé Currently job rules are spread across the various templates and jobs, making it hard to understand exactly what runs in what scenario. This leads to inconsistency in the rules and increased maint burden. The intent is that we introduce a common '.base_job_template' which

[PATCH v1 30/33] gitlab: convert static checks to .base_job_template

2022-05-27 Thread Alex Bennée
From: Daniel P. Berrangé This folds the static checks into using the base job template rules, introducing one new variable - QEMU_JOB_ONLY_FORKS - a job that should never run on an upstream pipeline. The information it reports is only applicable to contributors in a pre-submission scen

[PATCH v1 15/33] build: do a full build before running TCG tests

2022-05-27 Thread Alex Bennée
From: Paolo Bonzini TCG tests need both QEMU and firmware to be built, so do "ninja all" before trying to run them. Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson Message-Id: <20220517092616.1272238-5-pbonz...@redhat.com> Signed-off-by: Alex Bennée --- tests/Makefile.include | 3

[PATCH v1 22/33] configure: include more binutils in tests/tcg makefile

2022-05-27 Thread Alex Bennée
From: Paolo Bonzini Firmware builds require paths to all the binutils; it is not enough to use only cc, or even as/ld as in the case of tests/tcg/tricore. Adjust the cross-compiler configurator to detect also ar, nm, objcopy, ranlib and strip. Reviewed-by: Richard Henderson Signed-off-by: Paolo

[PATCH v1 32/33] gitlab: don't run CI jobs in forks by default

2022-05-27 Thread Alex Bennée
From: Daniel P. Berrangé To preserve CI shared runner credits we don't want to run pipelines on every push. This sets up the config so that pipelines are never created for contributors by default. To override this the QEMU_CI variable can be set to a non-zero value. If set to 1, the pipeline wil

[PATCH v1 27/33] configure: remove unused variables from config-host.mak

2022-05-27 Thread Alex Bennée
From: Paolo Bonzini The only compiler variable that is still needed is $(CC), for contrib/plugins/Makefile. All firmware builds have their own config-host.mak file. Signed-off-by: Paolo Bonzini Message-Id: <20220517092616.1272238-17-pbonz...@redhat.com> Signed-off-by: Alex Bennée --- configu

Re: [PATCH v1 07/33] tests/docker: update debian-armel-cross with lcitool

2022-05-27 Thread Daniel P . Berrangé
On Fri, May 27, 2022 at 04:35:37PM +0100, Alex Bennée wrote: > Use lcitool to update debian-armel-cross to a Debian 11 based system. > > Signed-off-by: Alex Bennée > --- > .gitlab-ci.d/container-cross.yml | 3 +- > tests/docker/Makefile.include | 1 - > .../docke

[PATCH] linux-user: Adjust child_tidptr on set_tid_address() syscall

2022-05-27 Thread Helge Deller
Keep track of the new child tidptr given by a set_tid_address() syscall. Signed-off-by: Helge Deller diff --git a/linux-user/syscall.c b/linux-user/syscall.c index f65045efe6..fdf5c1c03e 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -12202,7 +12202,11 @@ static abi_long do_sysc

  1   2   3   4   >