Re: [PATCH v3 02/10] block: Change bdrv_{pread, pwrite, pwrite_sync}() param order

[Vladimir Sementsov-Ogievskiy]

On 5/19/22 17:48, Alberto Faria wrote:

Swap 'buf' and 'bytes' around for consistency with
bdrv_co_{pread,pwrite}(), and in preparation to implement these
functions using generated_co_wrapper.

Callers were updated using this Coccinelle script:

     @@ expression child, offset, buf, bytes, flags; @@
     - bdrv_pread(child, offset, buf, bytes, flags)
     + bdrv_pread(child, offset, bytes, buf, flags)

     @@ expression child, offset, buf, bytes, flags; @@
     - bdrv_pwrite(child, offset, buf, bytes, flags)
     + bdrv_pwrite(child, offset, bytes, buf, flags)

     @@ expression child, offset, buf, bytes, flags; @@
     - bdrv_pwrite_sync(child, offset, buf, bytes, flags)
     + bdrv_pwrite_sync(child, offset, bytes, buf, flags)

Resulting overly-long lines were then fixed by hand.

Signed-off-by: Alberto Faria<afa...@redhat.com>
Reviewed-by: Paolo Bonzini<pbonz...@redhat.com>

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru>

Checking also, that we covered all occurrences:

git grep '\(bdrv_pread\|bdrv_pwrite\|bdrv_pwrite_sync\)([^)]' | wc -l
174
git show --format= | grep  '^[ 
+].*\(bdrv_pread\|bdrv_pwrite\|bdrv_pwrite_sync\)([^)]' | wc -l
174

(last exclusion of ')' is to ignore things like "bdrv_pwrite()" in comments)

--
Best regards,
Vladimir