Re: [PATCH 0/2] i386: fixup number of logical CPUs when host-cache-info=on

2022-05-25 Thread Igor Mammedov
On Tue, 24 May 2022 14:48:29 -0500 "Moger, Babu" wrote: > On 5/24/22 10:19, Igor Mammedov wrote: > > On Tue, 24 May 2022 11:10:18 -0400 > > Igor Mammedov wrote: > > > > CCing AMD folks as that might be of interest to them > > I am trying to recreate the bug on my AMD system here.. Seeing this

Re: [PATCH] tests: Bump Fedora image version for cross-compilation

2022-05-25 Thread Thomas Huth
On 24/05/2022 20.11, Konstantin Kostiuk wrote: There are 2 reason for the bump: - Fedora 33 is unsupported anymore s/unsupported/not supported/ ? - Some changes in the guest agent required updates of mingw-headers Signed-off-by: Konstantin Kostiuk --- tests/docker/dockerfiles/fedo

Re: [PATCH] hw/nvme: clean up CC register write logic

2022-05-25 Thread Klaus Jensen
On May 19 14:11, Lukasz Maniak wrote: > On Tue, May 17, 2022 at 01:16:05PM +0200, Klaus Jensen wrote: > > From: Klaus Jensen > > > > The SRIOV series exposed an issued with how CC register writes are > > handled and how CSTS is set in response to that. Specifically, after > > applying the SRIOV s

[PATCH v2] hw/nvme: clean up CC register write logic

2022-05-25 Thread Klaus Jensen
From: Klaus Jensen The SRIOV series exposed an issued with how CC register writes are handled and how CSTS is set in response to that. Specifically, after applying the SRIOV series, the controller could end up in a state with CC.EN set to '1' but with CSTS.RDY cleared to '0', causing drivers to e

Re: [RFC PATCH v2 0/8] Removal of AioContext lock, bs->parents and ->children: new rwlock

2022-05-25 Thread Paolo Bonzini
On 5/24/22 12:36, Kevin Wolf wrote: * IO_OR_GS_CODE() functions, when called from coroutine context, expect to be called with the AioContext lock taken (example: bdrv_co_yield_to_drain) Am I right to say this is not inherently part of the definition of IO_OR_GS_CODE(), but just a property that

Re: [PATCH 7/8] qmp: add filtering of statistics by name

2022-05-25 Thread Markus Armbruster
Paolo Bonzini writes: > On 5/24/22 15:08, Markus Armbruster wrote: >>> -typedef void SchemaRetrieveFunc(StatsSchemaList **result, Error **errp); >>> + strList *names, strList *targets, Error >>> **errp); >>> +typedef void SchemaRetrieveFunc(StatsSchemaList **, Error

Re: [PATCH v2 3/4] hw/gpio support GPIO index mode for write operation.

2022-05-25 Thread Cédric Le Goater
On 5/25/22 07:34, Jamin Lin wrote: It did not support GPIO index mode for read operation. Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater Thanks, C. --- hw/gpio/aspeed_gpio.c | 168 ++ include/hw/gpio/aspeed_gpio.h | 14 +++ 2 files

Re: [PATCH v7 04/13] s390x: topology: implementating Store Topology System Information

2022-05-25 Thread Pierre Morel
On 5/24/22 12:59, Thomas Huth wrote: On 20/04/2022 13.57, Pierre Morel wrote: The handling of STSI is enhanced with the interception of the function code 15 for storing CPU topology. Using the objects built during the pluging of CPU, we build the s/pluging/plugging/ SYSIB 15_1_x structur

Re: [PATCH v7 06/13] s390x: topology: Adding books to STSI

2022-05-25 Thread Pierre Morel
On 5/24/22 13:07, Thomas Huth wrote: On 20/04/2022 13.57, Pierre Morel wrote: Let's add STSI support for the container level 3, books, and provide the information back to the guest. Signed-off-by: Pierre Morel --- ... +static char *drawer_bus_get_dev_path(DeviceState *dev) +{ +    S390Top

Re: [PATCH v7 04/13] s390x: topology: implementating Store Topology System Information

2022-05-25 Thread Pierre Morel
On 5/24/22 13:08, Thomas Huth wrote: On 20/04/2022 13.57, Pierre Morel wrote: The handling of STSI is enhanced with the interception of the function code 15 for storing CPU topology. Using the objects built during the pluging of CPU, we build the s/pluging/plugging/ Yes SYSIB 15_1_x s

Re: [PATCH v7 12/13] s390x: CPU topology: CPU topology migration

2022-05-25 Thread Pierre Morel
On 5/24/22 13:32, Thomas Huth wrote: On 20/04/2022 13.57, Pierre Morel wrote: To migrate the Multiple Topology Change report, MTCR, we get it from KVM and save its state in the topology VM State Description during the presave and restore it to KVM on the destination during the postload. The

Re: [PATCH v7 08/13] s390x: topology: Adding drawers to STSI

2022-05-25 Thread Pierre Morel
On 5/24/22 13:10, Thomas Huth wrote: On 20/04/2022 13.57, Pierre Morel wrote: Let's add STSI support for the container level 4, drawers, and provide the information back to the guest. Signed-off-by: Pierre Morel --- ... @@ -470,6 +520,69 @@ static const TypeInfo drawer_info = {  

Re: [PATCH v7 10/13] s390x: kvm: topology: interception of PTF instruction

2022-05-25 Thread Pierre Morel
On 5/24/22 13:27, Thomas Huth wrote: On 20/04/2022 13.57, Pierre Morel wrote: When the host supports the CPU topology facility, the PTF instruction with function code 2 is interpreted by the SIE, provided that the userland hypervizor activates the interpretation by using the KVM_CAP_S390_CPU_

Re: [PATCH 1/4] qdev: add DEVICE_RUNTIME_ERROR event

2022-05-25 Thread Konstantin Khlebnikov
24.05.2022, 22:04, "Vladimir Sementsov-Ogievskiy" :First, cover letter is absent. Konstantin, could you please provide a description what the whole series does?Generic device layer lack of common way to report runtime errors related to the particular device via qmp.It seems useful to add qmp event

Re: [RFC PATCH v2 0/8] Removal of AioContext lock, bs->parents and ->children: new rwlock

2022-05-25 Thread Emanuele Giuseppe Esposito
Am 24/05/2022 um 14:10 schrieb Kevin Wolf: > Am 18.05.2022 um 14:28 hat Emanuele Giuseppe Esposito geschrieben: >> label: // read till the end to see why I wrote this here >> >> I was hoping someone from the "No" party would answer to your question, >> because as you know we reached this same co

Re: [PATCH v7 11/14] tests: Move MigrateCommon upper

2022-05-25 Thread Daniel P . Berrangé
On Tue, May 24, 2022 at 06:11:48PM -0400, Peter Xu wrote: > So that it can be used in postcopy tests too soon. > > Signed-off-by: Peter Xu > --- > tests/qtest/migration-test.c | 144 +-- > 1 file changed, 72 insertions(+), 72 deletions(-) Reviewed-by: Daniel P. B

Re: [PATCH v2 1/1] hw/arm/aspeed: Add fby35 machine type

2022-05-25 Thread Cédric Le Goater
Hello Peter, On 5/4/22 00:59, Peter Delevoryas wrote: Add the 'fby35-bmc' machine type based on the kernel DTS[1] and userspace i2c setup scripts[2]. Undefined values are inherited from the AST2600-EVB. Reference images can be found in Facebook OpenBMC Github Release assets as "fby35.mtd". [3]

[PATCH v2 1/1] tests: Bump Fedora image version for cross-compilation

2022-05-25 Thread Konstantin Kostiuk
There are 2 reason for the bump: - Fedora 33 is not supported anymore - Some changes in the guest agent required updates of mingw-headers Signed-off-by: Konstantin Kostiuk Reviewed-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Reviewed-by: Thomas Huth --- tests/docker/dockerfile

[PATCH v2 0/1] tests: Bump Fedora image version for cross-compilation

2022-05-25 Thread Konstantin Kostiuk
v1 -> v2: Fix spelling in the commit message v1: https://patchew.org/QEMU/2022052418.922031-1-kkost...@redhat.com/ Konstantin Kostiuk (1): tests: Bump Fedora image version for cross-compilation tests/docker/dockerfiles/fedora-win32-cross.docker | 2 +- tests/docker/dockerfiles/fedora-win64

Re: [PATCH 2/2] target/s390x: kvm: Honor storage keys during emulation

2022-05-25 Thread Thomas Huth
On 24/05/2022 13.52, Janis Schoetterl-Glausch wrote: On 5/24/22 13:21, Thomas Huth wrote: On 24/05/2022 13.10, Christian Borntraeger wrote: Am 24.05.22 um 12:43 schrieb Thomas Huth: On 19/05/2022 15.53, Janis Schoetterl-Glausch wrote: On 5/19/22 12:05, Thomas Huth wrote: On 06/05/2022 17.3

[PATCH 3/9] crypto: Introduce akcipher crypto class

2022-05-25 Thread Lei He
From: zhenwei pi Introduce new akcipher crypto class 'QCryptoAkCIpher', which supports basic asymmetric operations: encrypt, decrypt, sign and verify. Suggested by Daniel P. Berrangé, also add autoptr cleanup for the new class. Thanks to Daniel! Co-developed-by: lei he Signed-off-by: lei he S

Re: [PATCH v3 0/2] modules: Improve modinfo.c support

2022-05-25 Thread Dario Faggioli
On Wed, 2022-05-25 at 08:32 +0200, Gerd Hoffmann wrote: > On Tue, May 24, 2022 at 01:49:41PM +0200, Dario Faggioli wrote: > > Hello! Sorry for bringing up an old thread, but I'd have a question > > about this series. > > > > As far as I can see, the patches were fine, and they were Acked, > > but

[PATCH v7 0/9] Introduce akcipher service for virtio-crypto

2022-05-25 Thread Lei He
v6 -> v7: - Fix serval build errors for some specific platforms/configurations. - Use '%zu' instead of '%lu' for size_t parameters. - AkCipher-gcrypt: avoid setting wrong error messages when parsing RSA keys. - AkCipher-benchmark: process constant amount of sign/verify instead of running sign/ve

[PATCH 1/9] virtio-crypto: header update

2022-05-25 Thread Lei He
From: zhenwei pi Update header from linux, support akcipher service. Reviewed-by: Daniel P. Berrangé Reviewed-by: Gonglei Signed-off-by: lei he Signed-off-by: zhenwei pi --- include/standard-headers/linux/virtio_crypto.h | 82 +- 1 file changed, 81 insertions(+), 1 d

[PATCH 2/9] qapi: crypto-akcipher: Introduce akcipher types to qapi

2022-05-25 Thread Lei He
Introduce akcipher types, also include RSA related types. Reviewed-by: Daniel P. Berrangé Signed-off-by: Lei He Signed-off-by: zhenwei pi --- qapi/crypto.json | 64 1 file changed, 64 insertions(+) diff --git a/qapi/crypto.json b/qapi/c

[PATCH 5/9] crypto: Implement RSA algorithm by hogweed

2022-05-25 Thread Lei He
Implement RSA algorithm by hogweed from nettle. Thus QEMU supports a 'real' RSA backend to handle request from guest side. It's important to test RSA offload case without OS & hardware requirement. Signed-off-by: lei he Signed-off-by: zhenwei pi --- crypto/akcipher-nettle.c.inc | 451 ++

[PATCH 4/9] crypto: add ASN.1 DER decoder

2022-05-25 Thread Lei He
Add an ANS.1 DER decoder which is used to parse asymmetric cipher keys Signed-off-by: zhenwei pi Signed-off-by: lei he --- crypto/der.c | 189 crypto/der.h | 81 crypto/meson.build | 1 + tests/unit/meson.bui

[PATCH 8/9] tests/crypto: Add test suite for RSA keys

2022-05-25 Thread Lei He
As Daniel suggested, Add tests suite for rsakey, as a way to prove that we can handle DER errors correctly. Signed-off-by: lei he Reviewed-by: Daniel P. Berrangé --- tests/unit/test-crypto-akcipher.c | 285 +- 1 file changed, 282 insertions(+), 3 deletions(-)

[PATCH 6/9] crypto: Implement RSA algorithm by gcrypt

2022-05-25 Thread Lei He
Added gcryt implementation of RSA algorithm, RSA algorithm implemented by gcrypt has a higher priority than nettle because it supports raw padding. Signed-off-by: lei he --- crypto/akcipher-gcrypt.c.inc | 595 +++ crypto/akcipher.c| 4 +- 2 f

[PATCH 7/9] test/crypto: Add test suite for crypto akcipher

2022-05-25 Thread Lei He
Add unit test and benchmark test for crypto akcipher. Signed-off-by: lei he Signed-off-by: zhenwei pi Reviewed-by: Daniel P. Berrangé --- crypto/akcipher-nettle.c.inc| 14 +- tests/bench/benchmark-crypto-akcipher.c | 137 ++ tests/bench/meson.build | 1 + tes

[PATCH 9/9] crypto: Introduce RSA algorithm

2022-05-25 Thread Lei He
From: zhenwei pi There are two parts in this patch: 1, support akcipher service by cryptodev-builtin driver 2, virtio-crypto driver supports akcipher service In principle, we should separate this into two patches, to avoid compiling error, merge them into one. Then virtio-crypto gets request fr

[PULL v2 1/4] qga: add guest-get-diskstats command for Linux guests

2022-05-25 Thread Konstantin Kostiuk
From: luzhipeng Add a new 'guest-get-diskstats' command for report disk io statistics for Linux guests. This can be useful for getting io flow or handling IO fault, no need to enter guests. Signed-off-by: luzhipeng Message-Id: <20220520021935.676-1-luzhip...@cestc.cn> Reviewed-by: Marc-André Lu

[PULL v2 0/4] qemu-ga patches

2022-05-25 Thread Konstantin Kostiuk
The following changes since commit 0cac736e73723850a99e5142e35d14d8f8efb232: Merge tag 'pull-riscv-to-apply-20220525' of github.com:alistair23/qemu into staging (2022-05-24 15:55:12 -0700) are available in the Git repository at: g...@github.com:kostyanf14/qemu.git tags/qga-win32

[PULL v2 3/4] tests: Bump Fedora image version for cross-compilation

2022-05-25 Thread Konstantin Kostiuk
There are 2 reason for the bump: - Fedora 33 is not supported anymore - Some changes in the guest agent required updates of mingw-headers Signed-off-by: Konstantin Kostiuk Reviewed-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Reviewed-by: Thomas Huth Message-Id: <20220525085953.9

Re: [PATCH v3] block/gluster: correctly set max_pdiscard

2022-05-25 Thread Stefano Garzarella
On Fri, May 20, 2022 at 09:59:22AM +0200, Fabian Ebner wrote: On 64-bit platforms, assigning SIZE_MAX to the int64_t max_pdiscard results in a negative value, and the following assertion would trigger down the line (it's not the same max_pdiscard, but computed from the other one): qemu-system-x86

[PULL v2 4/4] qga-win32: Add support for NVME bus type

2022-05-25 Thread Konstantin Kostiuk
Bus type spaces (Indicates a storage spaces bus) is not supported, so return it as unknown. Signed-off-by: Konstantin Kostiuk Reviewed-by: Marc-André Lureau Message-Id: <20220524154344.869638-2-kkost...@redhat.com> Signed-off-by: Konstantin Kostiuk --- qga/commands-win32.c | 5 + 1 file ch

[PULL v2 2/4] trivial: qga: Log version on start

2022-05-25 Thread Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk Reviewed-by: Marc-André Lureau Message-Id: <20220523191644.823726-2-kkost...@redhat.com> Signed-off-by: Konstantin Kostiuk --- qga/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qga/main.c b/qga/main.c index 3b9546c185..c373fec3ee 100644 --- a/qga

Re: Problem running qos-test when building with gcc12 and LTO

2022-05-25 Thread Dario Faggioli
On Wed, 2022-05-25 at 07:41 +0100, Alex Bennée wrote: > Dario Faggioli writes: > > I'll try to dig further. Any idea/suggestion anyone has, feel free. > > :-) > > Sounds like there are still memory corruption/not initialised issues > that are affected by moving things around. > Right. In fact, I

[PATCH v2 3/3] target/riscv: Deprecate capitalized property names

2022-05-25 Thread Tsukasa OI
This commit adds a deprecation note of capitalized property names of RISC-V CPU to documentation. Signed-off-by: Tsukasa OI --- docs/about/deprecated.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index a92ae0f162..cfc9ad

Re: [RFC PATCH v5 0/3] Sysbus device generic QAPI plug support

2022-05-25 Thread Damien Hedde
On 5/24/22 19:44, Mark Cave-Ayland wrote: On 24/05/2022 14:48, Damien Hedde wrote: Hi all, This series is about enabling to plug sysbus devices with device_add QAPI command. I've put RFC because, there are several options and I would like to know if you think the current version is ok to be

[PATCH v2 0/3] target/riscv: Make CPU property names lowercase (w/ capitalized aliases)

2022-05-25 Thread Tsukasa OI
v1: Hello, This is a refined version of the patch to RISC-V CPU property names. See v1 for background. [Changes: RFC PATCH (v1) -> PATCH v2] - Reorganized all properties for clarity and extensibility (PATCH 1/3, not act

[PATCH v2 2/3] target/riscv: Make CPU property names lowercase

2022-05-25 Thread Tsukasa OI
Many CPU properties for RISC-V are in lowercase except those with "capitalized" (or CamelCase) names: - Counters - Zifencei - Zicsr - Zfh - Zfhmin - Zve32f - Zve64f This commit makes lowercase names primary but keeps capitalized names as aliases (for backward comatibility, but with

[PATCH v2 1/3] target/riscv: Reorganize riscv_cpu_properties

2022-05-25 Thread Tsukasa OI
This commit reorganizes riscv_cpu_properties for clarity. Signed-off-by: Tsukasa OI --- target/riscv/cpu.c | 64 +++--- 1 file changed, 37 insertions(+), 27 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index a91253d4bd..3f21563f2d 100

[PATCH] hw/arm/aspeed: Add i2c devices for AST2600 EVB

2022-05-25 Thread Howard Chiu
Add EEPROM and LM75 temperature sensor according to hardware schematic Signed-off-by: Howard Chiu --- hw/arm/aspeed.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index a74c13ab0f..df74d3e955 100644 --- a/hw/arm/aspeed.c +++ b/

Re: [PATCH v9 08/12] target/riscv: Add sscofpmf extension support

2022-05-25 Thread Frank Chang
On Tue, May 24, 2022 at 7:57 AM Atish Patra wrote: > The Sscofpmf ('Ss' for Privileged arch and Supervisor-level extensions, > and 'cofpmf' for Count OverFlow and Privilege Mode Filtering) > extension allows the perf to handle overflow interrupts and filtering > support. This patch provides a fra

Re: [PATCH v9 09/12] target/riscv: Simplify counter predicate function

2022-05-25 Thread Frank Chang
On Tue, May 24, 2022 at 8:02 AM Atish Patra wrote: > All the hpmcounters and the fixed counters (CY, IR, TM) can be represented > as a unified counter. Thus, the predicate function doesn't need handle each > case separately. > > Simplify the predicate function so that we just handle things differ

Re: [PATCH v3 6/8] hmp: add filtering of statistics by provider

2022-05-25 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > Allow the user to request statistics for a single provider of interest. > Extracted from a patch by Mark Kanda. > > Signed-off-by: Paolo Bonzini > --- > hmp-commands-info.hx | 7 --- > monitor/hmp-cmds.c | 41 +

[PULL 0/8] Linux user for 7.1 patches

2022-05-25 Thread Laurent Vivier
x-user-for-7.1-pull-request for you to fetch changes up to 565a84c1e61acb6e2bce03e5ca88b5ce400231ca: linux-user/host/s390: Treat EX and EXRL as writes (2022-05-23 22:54:02 +0200) Pull request linux-user 20220525 s390x fixes CP

[PULL 2/8] linux-user/syscall.c: fix build without RLIMIT_RTTIME

2022-05-25 Thread Laurent Vivier
From: Fabrice Fontaine RLIMIT_RTTIME is not provided by uclibc-ng or by musl prior to version 1.2.0 and https://github.com/bminor/musl/commit/2507e7f5312e79620f6337935d0a6c9045ccba09 resulting in the following build failure since https://git.qemu.org/?p=qemu.git;a=commit;h=244fd08323088db73590ff2

[PULL 7/8] tests/tcg/s390x: Test unwinding from signal handlers

2022-05-25 Thread Laurent Vivier
From: Ilya Leoshkevich Add a small test to prevent regressions. Signed-off-by: Ilya Leoshkevich Message-Id: <20220503225157.1696774-3-...@linux.ibm.com> Signed-off-by: Laurent Vivier --- tests/tcg/s390x/signals-s390x.c | 69 ++--- 1 file changed, 55 insertions(+),

[PULL 4/8] linux-user: Have do_syscall() use CPUArchState* instead of void*

2022-05-25 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20220509205728.51912-3-philippe.mathieu.da...@gmail.com> Signed-off-by: Laurent Vivier --- linux-user/strace.c | 202 ++-- linux-user/strace.h

[PULL 1/8] linux-user: Clean up arg_start/arg_end confusion

2022-05-25 Thread Laurent Vivier
From: Richard Henderson We had two sets of variables: arg_start/arg_end, and arg_strings/env_strings. In linuxload.c, we set the first pair to the bounds of the argv strings, but in elfload.c, we set the first pair to the bounds of the argv pointers and the second pair to the bounds of the argv

[PULL 8/8] linux-user/host/s390: Treat EX and EXRL as writes

2022-05-25 Thread Laurent Vivier
From: Ilya Leoshkevich clang-built s390x branch-relative-long test fails on clang-built s390x QEMU due to the following sequence of events: - The test zeroes out a code page, clang generates exrl+xc for this. - do_helper_xc() is called. Clang generates exrl+xc there as well. - Since there alre

[PULL 6/8] linux-user/s390x: Fix unwinding from signal handlers

2022-05-25 Thread Laurent Vivier
From: Ilya Leoshkevich Commit 31330e6cecfd ("linux-user/s390x: Implement setup_sigtramp") removed an unused field from rt_sigframe, disturbing offsets of other fields and breaking unwinding from signal handlers (e.g. libgcc's s390_fallback_frame() relies on this struct having a specific layout).

[PULL 5/8] linux-user: Remove pointless CPU{ARCH}State casts

2022-05-25 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20220509205728.51912-4-philippe.mathieu.da...@gmail.com> Signed-off-by: Laurent Vivier --- linux-user/syscall.c| 49 + linux-user/uname.c

[PULL 3/8] linux-user/elfload: Remove pointless non-const CPUArchState cast

2022-05-25 Thread Laurent Vivier
From: Philippe Mathieu-Daudé fill_thread_info() takes a pointer to const. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20220509205728.51912-2-philippe.mathieu.da...@gmail.com> Signed-off-by: Laurent Vivier --- linux-user/elfload.c | 2 +- 1 file changed,

Re: [PATCH 1/4] qdev: add DEVICE_RUNTIME_ERROR event

2022-05-25 Thread Markus Armbruster
I almost missed this series. Please cc: maintainers. scripts/get_maintainer.pl can help you find them, but do use your judgement to maybe trim its output. Konstantin Khlebnikov writes: > This event represents device runtime errors to give time and > reason why device is broken. Can you give an

Re: [PATCH v6 0/8] Support exporting BDSs via VDUSE

2022-05-25 Thread Stefan Hajnoczi
On Mon, May 23, 2022 at 04:46:03PM +0800, Xie Yongji wrote: > Hi all, > > Last few months ago, VDUSE (vDPA Device in Userspace) [1] has > been merged into Linux kernel as a framework that make it > possible to emulate a vDPA device in userspace. This series > aimed at implementing a VDUSE block ba

Re: [RFC PATCH 2/2] arm/virt: Add aspeed-i2c controller and MCTP EP to enable MCTP testing

2022-05-25 Thread Jonathan Cameron via
On Tue, 24 May 2022 13:13:10 -0500 Corey Minyard wrote: > On Tue, May 24, 2022 at 05:50:43PM +0100, Jonathan Cameron wrote: > > On Tue, 24 May 2022 09:36:44 -0700 > > Ben Widawsky wrote: > > > > > On 22-05-20 18:01:28, Jonathan Cameron wrote: > > > > As the only I2C emulation in QEMU that s

Re: Problem running qos-test when building with gcc12 and LTO

2022-05-25 Thread Dario Faggioli
On Wed, 2022-05-25 at 09:40 +, Dario Faggioli wrote: > On Wed, 2022-05-25 at 07:41 +0100, Alex Bennée wrote: > > > > Does it still trigger errors with my latest virtio cleanup series > > (which > > adds more tests to qos-test): > > > >   Subject: [PATCH  v2 00/15] virtio-gpio and various vir

Re: [RFC PATCH v5 0/3] Sysbus device generic QAPI plug support

2022-05-25 Thread Peter Maydell
On Wed, 25 May 2022 at 10:51, Damien Hedde wrote: > On 5/24/22 19:44, Mark Cave-Ayland wrote: > > Sorry for coming late into this series, however one of the things I've > > been thinking about a lot recently is that with the advent of QOM and > > qdev, is there really any distinction between TYPE_

[PATCH v4 2/6] i386: Hyper-V Enlightened MSR bitmap feature

2022-05-25 Thread Vitaly Kuznetsov
The newly introduced enlightenment allow L0 (KVM) and L1 (Hyper-V) hypervisors to collaborate to avoid unnecessary updates to L2 MSR-Bitmap upon vmexits. Signed-off-by: Vitaly Kuznetsov --- docs/hyperv.txt| 9 + target/i386/cpu.c | 2 ++ target/i386/cpu.h

Re: [PATCH v3 0/5] i386: Enable newly introduced KVM Hyper-V enlightenments

2022-05-25 Thread Vitaly Kuznetsov
Vitaly Kuznetsov writes: > Paolo Bonzini writes: > >>> This series enables four new KVM Hyper-V enlightenmtes [...] >>> >>> docs/hyperv.txt| 34 ++ >> >> Queued, thanks. > > Thanks! > It seems these patches didn't make it upstream yet but there's a (small) c

[PATCH v4 1/6] i386: Use hv_build_cpuid_leaf() for HV_CPUID_NESTED_FEATURES

2022-05-25 Thread Vitaly Kuznetsov
Previously, HV_CPUID_NESTED_FEATURES.EAX CPUID leaf was handled differently as it was only used to encode the supported eVMCS version range. In fact, there are also feature (e.g. Enlightened MSR-Bitmap) bits there. In preparation to adding these features, move HV_CPUID_NESTED_FEATURES leaf handling

[PATCH v4 4/6] i386: Hyper-V Support extended GVA ranges for TLB flush hypercalls

2022-05-25 Thread Vitaly Kuznetsov
KVM kind of supported "extended GVA ranges" (up to 4095 additional GFNs per hypercall) since the implementation of Hyper-V PV TLB flush feature (Linux-4.18) as regardless of the request, full TLB flush was always performed. "Extended GVA ranges for TLB flush hypercalls" feature bit wasn't exposed t

[PATCH v4 0/6] i386: Enable newly introduced KVM Hyper-V enlightenments

2022-05-25 Thread Vitaly Kuznetsov
Changes since v3: - Rebase, resolve merge conflict with 73d24074078a ("hyperv: Add support to process syndbg commands") - Include "i386: docs: Convert hyperv.txt to rST" patch which was previously posted separately. Original description: This series enables four new KVM Hyper-V enlightenmtes

[PATCH v4 3/6] i386: Hyper-V XMM fast hypercall input feature

2022-05-25 Thread Vitaly Kuznetsov
Hyper-V specification allows to pass parameters for certain hypercalls using XMM registers ("XMM Fast Hypercall Input"). When the feature is in use, it allows for faster hypercalls processing as KVM can avoid reading guest's memory. KVM supports the feature since v5.14. Rename HV_HYPERCALL_{PARAM

[PATCH v4 5/6] i386: Hyper-V Direct TLB flush hypercall

2022-05-25 Thread Vitaly Kuznetsov
Hyper-V TLFS allows for L0 and L1 hypervisors to collaborate on L2's TLB flush hypercalls handling. With the correct setup, L2's TLB flush hypercalls can be handled by L0 directly, without the need to exit to L1. Signed-off-by: Vitaly Kuznetsov --- docs/hyperv.txt| 11 +++

[PATCH v4 6/6] i386: docs: Convert hyperv.txt to rST

2022-05-25 Thread Vitaly Kuznetsov
rSTify docs/hyperv.txt and link it from docs/system/target-i386.rst. Signed-off-by: Vitaly Kuznetsov --- docs/hyperv.txt | 303 docs/system/i386/hyperv.rst | 288 ++ docs/system/target-i386.rst | 1 + 3 files chan

[PATCH] qsd: document vduse-blk exports

2022-05-25 Thread Stefan Hajnoczi
Document vduse-blk exports in qemu-storage-daemon --help and the qemu-storage-daemon(1) man page. Based-on: <20220523084611.91-1-xieyon...@bytedance.com> Cc: Xie Yongji Signed-off-by: Stefan Hajnoczi --- docs/tools/qemu-storage-daemon.rst | 21 + storage-daemon/qemu-storag

Re: [PATCH v2 2/3] target/riscv: Make CPU property names lowercase

2022-05-25 Thread Víctor Colombo
On 25/05/2022 06:54, Tsukasa OI wrote: Many CPU properties for RISC-V are in lowercase except those with "capitalized" (or CamelCase) names: - Counters - Zifencei - Zicsr - Zfh - Zfhmin - Zve32f - Zve64f This commit makes lowercase names primary but keeps capitalized names as alia

Re: [PATCH 03/20] migration: remove unreachble RDMA code in save_hook impl

2022-05-25 Thread Eric Blake
On Tue, May 24, 2022 at 12:02:18PM +0100, Daniel P. Berrangé wrote: > The QEMUFile 'save_hook' callback has a 'size_t size' parameter. > > The RDMA impl of this has logic that takes different actions > depending on whether the value is zero or non-zero. It has > commented out logic that would have

Re: [PATCH v9 08/12] target/hexagon: import flex/bison to docker files

2022-05-25 Thread Anton Johansson via
On 5/24/22 12:07, Alex Bennée wrote: Anton Johansson via writes: This patch points `tests/lcitool/libvirt-ci` to an upstreamed commit of `libvirt-ci` which includes flex and bison. The `lcitool/refresh` script was then ran to update the the generated docker/cirrus files. Signed-off-by: Ales

Re: [PATCH v6 0/8] Support exporting BDSs via VDUSE

2022-05-25 Thread Stefan Hajnoczi
On Mon, May 23, 2022 at 04:46:03PM +0800, Xie Yongji wrote: > Hi all, > > Last few months ago, VDUSE (vDPA Device in Userspace) [1] has > been merged into Linux kernel as a framework that make it > possible to emulate a vDPA device in userspace. This series > aimed at implementing a VDUSE block ba

[PULL 0/1] Block patches

2022-05-25 Thread Stefan Hajnoczi
The following changes since commit 0cac736e73723850a99e5142e35d14d8f8efb232: Merge tag 'pull-riscv-to-apply-20220525' of github.com:alistair23/qemu into staging (2022-05-24 15:55:12 -0700) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block-pu

Re: [PATCH v6 0/8] Support exporting BDSs via VDUSE

2022-05-25 Thread Yongji Xie
On Wed, May 25, 2022 at 8:48 PM Stefan Hajnoczi wrote: > > On Mon, May 23, 2022 at 04:46:03PM +0800, Xie Yongji wrote: > > Hi all, > > > > Last few months ago, VDUSE (vDPA Device in Userspace) [1] has > > been merged into Linux kernel as a framework that make it > > possible to emulate a vDPA devi

[PULL 1/1] docs: Correct the default thread-pool-size

2022-05-25 Thread Stefan Hajnoczi
From: Liu Yiding Refer to 26ec190964 virtiofsd: Do not use a thread pool by default Signed-off-by: Liu Yiding Acked-by: Vivek Goyal Message-id: 20220413042054.1484640-1-liuyd.f...@fujitsu.com Signed-off-by: Stefan Hajnoczi --- docs/tools/virtiofsd.rst | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH v6 0/8] Support exporting BDSs via VDUSE

2022-05-25 Thread Yongji Xie
On Wed, May 25, 2022 at 7:02 PM Stefan Hajnoczi wrote: > > On Mon, May 23, 2022 at 04:46:03PM +0800, Xie Yongji wrote: > > Hi all, > > > > Last few months ago, VDUSE (vDPA Device in Userspace) [1] has > > been merged into Linux kernel as a framework that make it > > possible to emulate a vDPA devi

[PATCH v2] hw/tpm/tpm_tis_common.c: Assert that locty is in range

2022-05-25 Thread Stefan Berger
From: Peter Maydell In tpm_tis_mmio_read(), tpm_tis_mmio_write() and tpm_tis_dump_state(), we calculate a locality index with tpm_tis_locality_from_addr() and then use it as an index into the s->loc[] array. In all these cases, the array index can't overflow because the MemoryRegion is sized to

Re: [PATCH v2] hw/tpm/tpm_tis_common.c: Assert that locty is in range

2022-05-25 Thread Marc-André Lureau
On Wed, May 25, 2022 at 3:02 PM Stefan Berger wrote: > From: Peter Maydell > > In tpm_tis_mmio_read(), tpm_tis_mmio_write() and > tpm_tis_dump_state(), we calculate a locality index with > tpm_tis_locality_from_addr() and then use it as an index into the > s->loc[] array. In all these cases, th

Re: [PATCH 00/16] Cross compilation of embedded firmware

2022-05-25 Thread Paolo Bonzini
On 5/24/22 17:53, Alex Bennée wrote: Paolo Bonzini writes: This is the next part of the firmware cross compilation story. It only looks at firmware that's strictly part of QEMU (optionrom, s390-ccw, vof), and does not do docker cross compilers yet; but it takes the infrastructure from tests/

Re: [RFC PATCH v5 0/3] Sysbus device generic QAPI plug support

2022-05-25 Thread Damien Hedde
On 5/25/22 13:45, Peter Maydell wrote: On Wed, 25 May 2022 at 10:51, Damien Hedde wrote: On 5/24/22 19:44, Mark Cave-Ayland wrote: Sorry for coming late into this series, however one of the things I've been thinking about a lot recently is that with the advent of QOM and qdev, is there really

Re: [PATCH v4 0/6] i386: Enable newly introduced KVM Hyper-V enlightenments

2022-05-25 Thread Paolo Bonzini
On 5/25/22 13:59, Vitaly Kuznetsov wrote: Changes since v3: - Rebase, resolve merge conflict with 73d24074078a ("hyperv: Add support to process syndbg commands") - Include "i386: docs: Convert hyperv.txt to rST" patch which was previously posted separately. Thank you very much for repost

Re: [RFC PATCH v1 0/8] qapi: add generator for Golang interface

2022-05-25 Thread Andrea Bolognani
On Wed, May 18, 2022 at 02:30:11PM +0200, Markus Armbruster wrote: > Victor Toso writes: > > IMHO, at this moment, qapi-go is targeting communicating with > > QEMU and handling multiple QEMU versions seems reasonable to me. > > It's targeting communicating in *QMP*. QMP is designed to support > c

Re: Problem running qos-test when building with gcc12 and LTO

2022-05-25 Thread Paolo Bonzini
On 5/24/22 22:12, Dario Faggioli wrote: Ok, apparently, v6.2.0 works (with GCC 12 and LTO), while as said v7.0.0 doesn't. Therefore, I run a bisect, and it pointed at: 8dcb404bff6d9147765d7dd3e9c8493372186420 tests/qtest: enable more vhost-user tests by default I've also confirmed that on v7.0

[PATCH RESEND v3 6/8] target/ppc: Implemented remaining vector divide extended

2022-05-25 Thread Lucas Mateus Castro(alqotel)
From: "Lucas Mateus Castro (alqotel)" Implement the following PowerISA v3.1 instructions: vdivesd: Vector Divide Extended Signed Doubleword vdiveud: Vector Divide Extended Unsigned Doubleword vdivesq: Vector Divide Extended Signed Quadword vdiveuq: Vector Divide Extended Unsigned Quadword Signed

[PATCH RESEND v3 2/8] target/ppc: Implemented vector divide quadword

2022-05-25 Thread Lucas Mateus Castro(alqotel)
From: "Lucas Mateus Castro (alqotel)" Implement the following PowerISA v3.1 instructions: vdivsq: Vector Divide Signed Quadword vdivuq: Vector Divide Unsigned Quadword Signed-off-by: Lucas Mateus Castro (alqotel) Reviewed-by: Richard Henderson --- target/ppc/helper.h | 2 ++

[PATCH RESEND v3 1/8] target/ppc: Implemented vector divide instructions

2022-05-25 Thread Lucas Mateus Castro(alqotel)
From: "Lucas Mateus Castro (alqotel)" Implement the following PowerISA v3.1 instructions: vdivsw: Vector Divide Signed Word vdivuw: Vector Divide Unsigned Word vdivsd: Vector Divide Signed Doubleword vdivud: Vector Divide Unsigned Doubleword Signed-off-by: Lucas Mateus Castro (alqotel) --- tar

[PATCH RESEND v3 5/8] host-utils: Implemented signed 256-by-128 division

2022-05-25 Thread Lucas Mateus Castro(alqotel)
From: "Lucas Mateus Castro (alqotel)" Based on already existing QEMU implementation created a signed 256 bit by 128 bit division needed to implement the vector divide extended signed quadword instruction from PowerISA 3.1 Signed-off-by: Lucas Mateus Castro (alqotel) Reviewed-by: Richard Henders

[PATCH RESEND v3 7/8] target/ppc: Implemented vector module word/doubleword

2022-05-25 Thread Lucas Mateus Castro(alqotel)
From: "Lucas Mateus Castro (alqotel)" Implement the following PowerISA v3.1 instructions: vmodsw: Vector Modulo Signed Word vmoduw: Vector Modulo Unsigned Word vmodsd: Vector Modulo Signed Doubleword vmodud: Vector Modulo Unsigned Doubleword Signed-off-by: Lucas Mateus Castro (alqotel) --- tar

[PATCH RESEND v3 3/8] target/ppc: Implemented vector divide extended word

2022-05-25 Thread Lucas Mateus Castro(alqotel)
From: "Lucas Mateus Castro (alqotel)" Implement the following PowerISA v3.1 instructions: vdivesw: Vector Divide Extended Signed Word vdiveuw: Vector Divide Extended Unsigned Word Signed-off-by: Lucas Mateus Castro (alqotel) --- target/ppc/insn32.decode| 3 ++ target/ppc/translate

[PATCH RESEND v3 4/8] host-utils: Implemented unsigned 256-by-128 division

2022-05-25 Thread Lucas Mateus Castro(alqotel)
From: "Lucas Mateus Castro (alqotel)" Based on already existing QEMU implementation, created an unsigned 256 bit by 128 bit division needed to implement the vector divide extended unsigned instruction from PowerISA3.1 Signed-off-by: Lucas Mateus Castro (alqotel) --- This patch had received Revi

[PATCH 2/2] hw/vhost-user-scsi|blk: set `supports_config` flag correctly

2022-05-25 Thread Changpeng Liu
Currently vhost-user-scsi driver doesn't allow to change the configuration space of virtio_scsi, while vhost-user-blk support that, so here we set the flag in vhost-user-blk driver and unset it in vhost-user-scsi. Signed-off-by: Changpeng Liu --- hw/block/vhost-user-blk.c | 1 + hw/scsi/vhost-us

[PATCH 1/2] hw/virtio/vhost-user: don't use uninitialized variable

2022-05-25 Thread Changpeng Liu
Variable `vdev` in `struct vhost_dev` will not be ready until start the device, so let's not use it for the error output here. Fixes: 5653493 ("hw/virtio/vhost-user: don't suppress F_CONFIG when supported") Signed-off-by: Changpeng Liu --- hw/virtio/vhost-user.c | 8 +++- 1 file changed, 3

[PATCH RESEND v3 8/8] target/ppc: Implemented vector module quadword

2022-05-25 Thread Lucas Mateus Castro(alqotel)
From: "Lucas Mateus Castro (alqotel)" Implement the following PowerISA v3.1 instructions: vmodsq: Vector Modulo Signed Quadword vmoduq: Vector Modulo Unsigned Quadword Signed-off-by: Lucas Mateus Castro (alqotel) Reviewed-by: Richard Henderson Resolves: https://gitlab.com/qemu-project/qemu/-/i

Re: [RFC PATCH v1 0/8] qapi: add generator for Golang interface

2022-05-25 Thread Markus Armbruster
Andrea Bolognani writes: > On Wed, May 18, 2022 at 02:30:11PM +0200, Markus Armbruster wrote: >> Victor Toso writes: >> > IMHO, at this moment, qapi-go is targeting communicating with >> > QEMU and handling multiple QEMU versions seems reasonable to me. >> >> It's targeting communicating in *QMP

Re: [PATCH v3 6/8] hmp: add filtering of statistics by provider

2022-05-25 Thread Paolo Bonzini
On 5/25/22 12:35, Dr. David Alan Gilbert wrote: +return filter; +} + +/* "info stats" can only query either one or all the providers. */ +StatsRequest *request = g_new0(StatsRequest, 1); +request->provider = provider; +StatsRequestList *request_list = g_new0(StatsRequ

Re: [PATCH v4 15/15] test/qga: use g_auto wherever sensible

2022-05-25 Thread Marc-André Lureau
On Wed, May 25, 2022 at 4:13 PM Konstantin Kostiuk wrote: > > > > > > On Tue, May 24, 2022 at 1:35 PM wrote: >> >> From: Marc-André Lureau >> >> Signed-off-by: Marc-André Lureau >> --- >> tests/unit/test-qga.c | 121 +++--- >> 1 file changed, 43 insertions(+

[PATCH RESEND] block: add more commands to preconfig mode

2022-05-25 Thread Paolo Bonzini
Of the block device commands, those that are available outside system emulators do not require a fully constructed machine by definition. Allow running them before machine initialization has concluded. Of the ones that are available inside system emulation, allow querying the PR managers, and sett

Re: [PATCH v4 15/15] test/qga: use g_auto wherever sensible

2022-05-25 Thread Konstantin Kostiuk
On Tue, May 24, 2022 at 1:35 PM wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > tests/unit/test-qga.c | 121 +++--- > 1 file changed, 43 insertions(+), 78 deletions(-) > > diff --git a/tests/unit/test-qga.c b/tests/unit/test-qga

  1   2   3   >