Re: [RFC PATCH] vhost_net: should not use max_queue_pairs for non-mq guest

2022-03-25 Thread Si-Wei Liu
On 3/21/2022 8:47 PM, Jason Wang wrote: On Sat, Mar 19, 2022 at 12:14 PM Si-Wei Liu wrote: With MQ enabled vdpa device and non-MQ supporting guest e.g. booting vdpa with mq=on over OVMF of single vqp, it's easy to hit assert failure as the following: ../hw/virtio/vhost-vdpa.c:560: vhost_vdp

[PULL 0/7] (Mostly) x86 fixes for QEMU 7.0.0-rc2

2022-03-25 Thread Paolo Bonzini
The following changes since commit 15ef89d2a1a7b93845a6b09c2ee8e1979f6eb30b: Update version for v7.0.0-rc1 release (2022-03-22 22:58:44 +) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to 9584d3d00a454f47b034146

[PULL 2/7] i386: Set MCG_STATUS_RIPV bit for mce SRAR error

2022-03-25 Thread Paolo Bonzini
From: luofei In the physical machine environment, when a SRAR error occurs, the IA32_MCG_STATUS RIPV bit is set, but qemu does not set this bit. When qemu injects an SRAR error into virtual machine, the virtual machine kernel just call do_machine_check() to kill the current task, but not call mem

[PULL 3/7] KVM: x86: workaround invalid CPUID[0xD, 9] info on some AMD processors

2022-03-25 Thread Paolo Bonzini
Some AMD processors expose the PKRU extended save state even if they do not have the related PKU feature in CPUID. Worse, when they do they report a size of 64, whereas the expected size of the PKRU extended save state is 8, therefore the esa->size == eax assertion does not hold. The state is alr

[PULL 1/7] target/i386/kvm: Free xsave_buf when destroying vCPU

2022-03-25 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Fix vCPU hot-unplug related leak reported by Valgrind: ==132362== 4,096 bytes in 1 blocks are definitely lost in loss record 8,440 of 8,549 ==132362==at 0x4C3B15F: memalign (vg_replace_malloc.c:1265) ==132362==by 0x4C3B288: posix_memalign (vg_replace_m

[PULL 6/7] target/i386: properly reset TSC on reset

2022-03-25 Thread Paolo Bonzini
Some versions of Windows hang on reboot if their TSC value is greater than 2^54. The calibration of the Hyper-V reference time overflows and fails; as a result the processors' clock sources are out of sync. The issue is that the TSC _should_ be reset to 0 on CPU reset and QEMU tries to do that.

[PULL 4/7] configure: remove dead int128 test

2022-03-25 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 18 -- 1 file changed, 18 deletions(-) diff --git a/configure b/configure index 6d9cb23ac5..7c08c18358 100755 --- a/configure +++ b/configure @@ -2463,24 +2463,6 @@ else # "$safe_stack" = "" fi fi -#

[PULL 5/7] target/i386: tcg: high bits SSE cmp operation must be ignored

2022-03-25 Thread Paolo Bonzini
High bits in the immediate operand of SSE comparisons are ignored, they do not result in an undefined opcode exception. This is mentioned explicitly in the Intel documentation. Reported-by: sonicadvan...@gmail.com Closes: https://gitlab.com/qemu-project/qemu/-/issues/184 Signed-off-by: Paolo Bonz

[PULL 7/7] build: disable fcf-protection on -march=486 -m16

2022-03-25 Thread Paolo Bonzini
From: Christian Ehrhardt Some of the roms build with -march=i486 -m16 which is incompatible with -fcf-protection. That in turn is can be set by default, for example in Ubuntu [1]. That causes: cc1: error: ‘-fcf-protection’ is not compatible with this target This won't work on -march=i486 -m16 a

Re: [PATCH v3 1/2] aspeed/hace: Support AST2600 HACE

2022-03-25 Thread Joel Stanley
Hi Steven, I've pointed out some small things like spelling fixes, and made a suggestion to split the change into multiple patches. Aside from that, I need your help to understand what your change is trying to do. On Fri, 25 Mar 2022 at 03:58, Steven Lee wrote: > > The aspeed ast2600 acculumati

Re: [RFC PATCH] vhost_net: should not use max_queue_pairs for non-mq guest

2022-03-25 Thread Jason Wang
On Fri, Mar 25, 2022 at 3:02 PM Si-Wei Liu wrote: > > > > On 3/21/2022 8:47 PM, Jason Wang wrote: > > On Sat, Mar 19, 2022 at 12:14 PM Si-Wei Liu wrote: > >> With MQ enabled vdpa device and non-MQ supporting guest e.g. > >> booting vdpa with mq=on over OVMF of single vqp, it's easy > >> to hit as

Re: hang in migration-test (s390 host)

2022-03-25 Thread Juan Quintela
Laurent Vivier wrote: > Perhaps Juan or Thomas can help too (added to cc) > > Is this a regression? > It looks like a bug in QEMU as it doesn't move from cancelling to cancelled. Hi TCG never stops given. And s390 makes things even more interesting. First of all, it is a pity that glib debug sy

Re: [PATCH 28/32] Move CPU softfloat unions to cpu-float.h

2022-03-25 Thread Juan Quintela
marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The types are no longer used in bswap.h since commit > f930224fffe ("bswap.h: Remove unused float-access functions"), there > isn't much sense in keeping it there and having a dependency on fpu/. > > Signed-off-by: Marc-André Lureau

Re: [PATCH 11/32] Replace qemu_real_host_page variables with inlined functions

2022-03-25 Thread Juan Quintela
marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Replace the global variables with inlined helper functions. getpagesize() is > very > likely annotated with a "const" function attribute (at least with glibc), and > thus > optimization should apply even better. > > This avoids the

Re: [PATCH v2] block/stream: Drain subtree around graph change

2022-03-25 Thread Hanna Reitz
On 24.03.22 19:49, John Snow wrote: On Thu, Mar 24, 2022 at 10:09 AM Hanna Reitz wrote: When the stream block job cuts out the nodes between top and base in stream_prepare(), it does not drain the subtree manually; it fetches the base node, and tries to insert it as the top node's backing node

[PATCH 2/2] target/riscv: optimize helper for vmvr.v

2022-03-25 Thread Weiwei Li
LEN is not used for GEN_VEXT_VMV_WHOLE macro, so vmvr.v can share the same helper Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/helper.h | 5 + target/riscv/insn_trans/trans_rvv.c.inc | 17 +-- target/riscv/vector_helper.c

[PATCH 1/2] target/riscv: optimize condition assign for scale < 0

2022-03-25 Thread Weiwei Li
for some cases, scale is always equal or less than 0, since lmul is not larger than 3 Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/insn_trans/trans_rvv.c.inc | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/target/riscv/insn_trans/trans_rvv.

Re: [PATCH qemu v4 04/14] target/riscv: rvv: Add tail agnostic for vv instructions

2022-03-25 Thread Weiwei Li
在 2022/3/1 下午5:07, ~eopxd 写道: From: eopXD This is the first commit regarding the tail agnostic behavior. Added option 'rvv_ta_all_1s' to enable the behavior, the option is default to false. Signed-off-by: eop Chen Reviewed-by: Frank Chang --- target/riscv/cpu.c | 1

Re: [PATCH 2/2] target/riscv: optimize helper for vmvr.v

2022-03-25 Thread Frank Chang
Reviewed-by: Frank Chang On Fri, Mar 25, 2022 at 5:00 PM Weiwei Li wrote: > LEN is not used for GEN_VEXT_VMV_WHOLE macro, so vmvr.v can share > the same helper > > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang > --- > target/riscv/helper.h | 5 + > target/ris

Re: [PATCH 1/2] target/riscv: optimize condition assign for scale < 0

2022-03-25 Thread Frank Chang
Reviewed-by: Frank Chang On Fri, Mar 25, 2022 at 5:00 PM Weiwei Li wrote: > for some cases, scale is always equal or less than 0, since lmul is not > larger than 3 > > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang > --- > target/riscv/insn_trans/trans_rvv.c.inc | 8 +++- > 1 fi

[PATCH] ui/console: Check console before emitting GL event

2022-03-25 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- ui/console.c | 21 + 1 file changed, 21 insertions(+) diff --git a/ui/console.c b/ui/console.c index da434ce1b2f..1752f2ec889 100644 --- a/ui/console.c +++ b/ui/console.c @@ -1886,6 +1886,9 @@ void dpy_gl_scanout_disable(QemuConsole *con)

Re: [libvirt RFC] virFile: new VIR_FILE_WRAPPER_BIG_PIPE to improve performance

2022-03-25 Thread Claudio Fontana
On 3/21/22 8:55 AM, Andrea Righi wrote: > On Fri, Mar 18, 2022 at 02:34:29PM +0100, Claudio Fontana wrote: > ... >> I have lots of questions here, and I tried to involve Jiri and Andrea Righi >> here, who a long time ago proposed a POSIX_FADV_NOREUSE implementation. >> >> 1) What is the reason ioh

Re: [PATCH-for-7.0 v2] qemu/main-loop: Disable block backend global state assertion on Cocoa

2022-03-25 Thread Peter Maydell
On Tue, 22 Mar 2022 at 09:35, Philippe Mathieu-Daudé wrote: > > What is preferred between #2 and #3? I don't have enough knowledge to > take the decision, which is why I suggested the chicken-hearted "disable > assert" option #1. I don't have a strong opinion, but I do strongly think we need to g

Re: [RFC PATCH 4/6] tests/tcg: add support for ppc64le softmmu tests

2022-03-25 Thread Alex Bennée
Leandro Lupori writes: > On 24/03/2022 17:34, Alex Bennée wrote: >> Leandro Lupori writes: >> >>> Adding a new, "virtual" TCG test target, ppc64le-softmmu, seems to >>> be the cleanest way to support both BE and LE tests for >>> ppc64-softmmu. >>> >>> Signed-off-by: Leandro Lupori >>> --- >>

Re: [PULL for-7.0 0/2] Block patches

2022-03-25 Thread Peter Maydell
On Thu, 24 Mar 2022 at 17:15, Stefan Hajnoczi wrote: > > The following changes since commit 15ef89d2a1a7b93845a6b09c2ee8e1979f6eb30b: > > Update version for v7.0.0-rc1 release (2022-03-22 22:58:44 +) > > are available in the Git repository at: > > https://gitlab.com/stefanha/qemu.git tags/

Re: iotest40 problem

2022-03-25 Thread Li Zhang
Hi, I backport some iotests patches to the tree and change timeout. It doesn't work. Sometimes, iotest41 also reports the errors. [ 1347s] +== [ 1347s] +ERROR: test_top_node_in_wrong_chain (__main__.TestSingleDrive) [ 1347s]

Re: [PATCH qemu v4 06/14] target/riscv: rvv: Add tail agnostic for vx, vvm, vxm instructions

2022-03-25 Thread Weiwei Li
在 2022/3/7 下午3:32, ~eopxd 写道: From: eopXD Signed-off-by: eop Chen Reviewed-by: Frank Chang --- target/riscv/insn_trans/trans_rvv.c.inc | 23 ++ target/riscv/vector_helper.c| 312 +--- 2 files changed, 197 insertions(+), 138 deletions(-) diff --git a/tar

Re: [libvirt RFC] virFile: new VIR_FILE_WRAPPER_BIG_PIPE to improve performance

2022-03-25 Thread Daniel P . Berrangé
On Fri, Mar 18, 2022 at 02:34:29PM +0100, Claudio Fontana wrote: > On 3/17/22 4:03 PM, Dr. David Alan Gilbert wrote: > > * Claudio Fontana (cfont...@suse.de) wrote: > >> On 3/17/22 2:41 PM, Claudio Fontana wrote: > >>> On 3/17/22 11:25 AM, Daniel P. Berrangé wrote: > On Thu, Mar 17, 2022 at 11

Re: [PATCH qemu v4 09/14] target/riscv: rvv: Add tail agnostic for vector integer merge and move instructions

2022-03-25 Thread Weiwei Li
在 2022/3/7 下午5:53, ~eopxd 写道: From: eopXD Signed-off-by: eop Chen Reviewed-by: Frank Chang --- target/riscv/insn_trans/trans_rvv.c.inc | 40 + target/riscv/vector_helper.c| 28 + 2 files changed, 68 insertions(+) diff --git a/target/r

Re: Plugins Not Reporting AArch64 SVE Memory Operations

2022-03-25 Thread Alex Bennée
Aaron Lindsay writes: > Hi folks, > > I see there has been some previous discussion [1] about 1.5 years ago > around the fact that AArch64 SVE instructions do not emit any memory > operations via the plugin interface, as one might expect them to. > > I am interested in being able to more accura

Re: [PATCH qemu v4 11/14] target/riscv: rvv: Add tail agnostic for vector floating-point instructions

2022-03-25 Thread Weiwei Li
在 2022/3/7 下午6:05, ~eopxd 写道: From: eopXD Signed-off-by: eop Chen Reviewed-by: Frank Chang --- target/riscv/insn_trans/trans_rvv.c.inc | 11 + target/riscv/vector_helper.c| 452 ++-- 2 files changed, 267 insertions(+), 196 deletions(-) diff --git a/targ

Re: [PATCH qemu v4 12/14] target/riscv: rvv: Add tail agnostic for vector reduction instructions

2022-03-25 Thread Weiwei Li
在 2022/3/7 下午8:21, ~eopxd 写道: +uint32_t vta = vext_vta(desc);\ uint32_t i; \ TD s1 = *((TD *)vs1 + HD(0));\ \ @@ -4562,6 +4565,9

Re: [PATCH qemu v4 14/14] target/riscv: rvv: Add tail agnostic for vector permutation instructions

2022-03-25 Thread Weiwei Li
在 2022/3/7 下午11:59, ~eopxd 写道: From: eopXD Signed-off-by: eop Chen Reviewed-by: Frank Chang --- target/riscv/insn_trans/trans_rvv.c.inc | 20 target/riscv/vector_helper.c| 68 ++--- 2 files changed, 82 insertions(+), 6 deletions(-) diff --git a/

Re: [libvirt RFC] virFile: new VIR_FILE_WRAPPER_BIG_PIPE to improve performance

2022-03-25 Thread Claudio Fontana
Thanks Daniel, On 3/25/22 11:33 AM, Daniel P. Berrangé wrote: > On Fri, Mar 18, 2022 at 02:34:29PM +0100, Claudio Fontana wrote: >> On 3/17/22 4:03 PM, Dr. David Alan Gilbert wrote: >>> * Claudio Fontana (cfont...@suse.de) wrote: On 3/17/22 2:41 PM, Claudio Fontana wrote: > On 3/17/22 11:

Re: hang in migration-test (s390 host)

2022-03-25 Thread Peter Maydell
On Fri, 25 Mar 2022 at 08:04, Juan Quintela wrote: > Laurent Vivier wrote: > > Perhaps Juan or Thomas can help too (added to cc) > > > > Is this a regression? > > It looks like a bug in QEMU as it doesn't move from cancelling to cancelled. > > Hi > > TCG never stops given. And s390 makes things

Re: [libvirt RFC] virFile: new VIR_FILE_WRAPPER_BIG_PIPE to improve performance

2022-03-25 Thread Daniel P . Berrangé
On Fri, Mar 25, 2022 at 11:56:44AM +0100, Claudio Fontana wrote: > Thanks Daniel, > > On 3/25/22 11:33 AM, Daniel P. Berrangé wrote: > > On Fri, Mar 18, 2022 at 02:34:29PM +0100, Claudio Fontana wrote: > >> On 3/17/22 4:03 PM, Dr. David Alan Gilbert wrote: > >>> * Claudio Fontana (cfont...@suse.de

Re: [libvirt RFC] virFile: new VIR_FILE_WRAPPER_BIG_PIPE to improve performance

2022-03-25 Thread Claudio Fontana
On 3/25/22 12:14 PM, Daniel P. Berrangé wrote: > On Fri, Mar 25, 2022 at 11:56:44AM +0100, Claudio Fontana wrote: >> Thanks Daniel, >> >> On 3/25/22 11:33 AM, Daniel P. Berrangé wrote: >>> On Fri, Mar 18, 2022 at 02:34:29PM +0100, Claudio Fontana wrote: On 3/17/22 4:03 PM, Dr. David Alan Gilbe

[PATCH for-7.0] target/ppc: fix helper_xvmadd* argument order

2022-03-25 Thread matheus . ferst
From: Matheus Ferst When the xsmadd* insns were moved to decodetree, the helper arguments were reordered to better match the PowerISA description. The same macro is used to declare xvmadd* helpers, but the translation macro of these insns was not changed accordingly. Reported-by: Víctor Colombo

Re: [libvirt RFC] virFile: new VIR_FILE_WRAPPER_BIG_PIPE to improve performance

2022-03-25 Thread Daniel P . Berrangé
On Fri, Mar 18, 2022 at 02:34:29PM +0100, Claudio Fontana wrote: > On 3/17/22 4:03 PM, Dr. David Alan Gilbert wrote: > > * Claudio Fontana (cfont...@suse.de) wrote: > >> On 3/17/22 2:41 PM, Claudio Fontana wrote: > >>> On 3/17/22 11:25 AM, Daniel P. Berrangé wrote: > On Thu, Mar 17, 2022 at 11

Re: [PATCH for-7.0] target/ppc: fix helper_xvmadd* argument order

2022-03-25 Thread Daniel Henrique Barboza
On 3/25/22 08:18, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst When the xsmadd* insns were moved to decodetree, the helper arguments were reordered to better match the PowerISA description. The same macro is used to declare xvmadd* helpers, but the translation macro of these insn

Re: [PATCH for-7.0] target/ppc: fix helper_xvmadd* argument order

2022-03-25 Thread Víctor Colombo
On 25/03/2022 08:18, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst When the xsmadd* insns were moved to decodetree, the helper arguments were reordered to better match the PowerISA description. The same macro is used to declare xvmadd* helpers, but the translation macro of these insn

Re: [PATCH 1/7] linux-user/nios2: Fix clone child return

2022-03-25 Thread Peter Maydell
On Sun, 20 Mar 2022 at 16:12, Richard Henderson wrote: > > The child side of clone needs to set the secondary > syscall return value, r7, to indicate syscall success. > > Advance the pc before do_syscall, so that the new thread > does not re-execute the clone syscall. > > Signed-off-by: Richard He

Re: [PATCH 2/7] linux-user/nios2: Drop syscall 0 "workaround"

2022-03-25 Thread Peter Maydell
On Sun, 20 Mar 2022 at 16:09, Richard Henderson wrote: > > There's no documentation for what the problem was. > > Fixes: a0a839b65b6 ("nios2: Add usermode binaries emulation") > Signed-off-by: Richard Henderson > --- > linux-user/nios2/cpu_loop.c | 4 > 1 file changed, 4 deletions(-) > > di

Re: [PATCH 3/7] linux-user/nios2: Adjust error return

2022-03-25 Thread Peter Maydell
On Sun, 20 Mar 2022 at 16:06, Richard Henderson wrote: > > Follow syscall_set_return_value rather than the kernel assembly > in setting the syscall return values. Only negate ret on error. > > Signed-off-by: Richard Henderson > --- > linux-user/nios2/cpu_loop.c | 15 --- > 1 file ch

Re: [PATCH 6/7] linux-user/nios2: Use QEMU_ESIGRETURN from do_rt_sigreturn

2022-03-25 Thread Peter Maydell
On Sun, 20 Mar 2022 at 16:06, Richard Henderson wrote: > > Drop the kernel-specific "pr2" code structure and use > the qemu-specific error return value. > > Signed-off-by: Richard Henderson > --- > linux-user/nios2/signal.c | 10 +++--- > 1 file changed, 3 insertions(+), 7 deletions(-) > > d

Re: [PATCH 4/7] linux-user/nios2: Handle special qemu syscall return values

2022-03-25 Thread Peter Maydell
On Sun, 20 Mar 2022 at 16:06, Richard Henderson wrote: > > Honor QEMU_ESIGRETURN and QEMU_ERESTARTSYS. > > Signed-off-by: Richard Henderson > --- > linux-user/nios2/cpu_loop.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/linux-user/nios2/cpu_loop.c b/linux-user/nios2/cpu_loop

Re: [PATCH 7/7] tests/tcg/nios2: Re-enable linux-user tests

2022-03-25 Thread Peter Maydell
On Sun, 20 Mar 2022 at 16:14, Richard Henderson wrote: > > Now that signal handling has been fixed, re-enable tests. > > Signed-off-by: Richard Henderson > --- > tests/tcg/nios2/Makefile.target | 11 --- > 1 file changed, 11 deletions(-) > delete mode 100644 tests/tcg/nios2/Makefile.tar

Re: [PATCH 5/7] linux-user/nios2: Remove do_sigreturn

2022-03-25 Thread Peter Maydell
On Sun, 20 Mar 2022 at 16:09, Richard Henderson wrote: > > There is no sigreturn syscall, only rt_sigreturn. > This function is unused. > > Signed-off-by: Richard Henderson > --- > linux-user/nios2/signal.c | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/linux-user/nios2/signal.c

Re: [PATCH 01/14] qapi: BlockExportRemoveMode: move comments to TODO

2022-03-25 Thread Markus Armbruster
Victor Toso writes: > @hide and @soft are potential additions which fits the TODO section > perfectly. > > The main motivation is to avoid this whole block of comment entering > the wrong section in the python parser. > > Signed-off-by: Victor Toso > --- > qapi/block-export.json | 10 +-

Re: [PATCH 02/14] qapi: fix example of BLOCK_IMAGE_CORRUPTED event

2022-03-25 Thread Markus Armbruster
John Snow writes: > On Thu, Mar 24, 2022 at 3:15 PM John Snow wrote: >> >> >> >> On Thu, Mar 24, 2022, 1:50 PM Victor Toso wrote: >>> >>> Fatal is not optional. >>> >>> Signed-off-by: Victor Toso >>> --- >>> qapi/block-core.json | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>

Re: [PATCH 04/14] qapi: fix example of BLOCK_JOB_PENDING event

2022-03-25 Thread Markus Armbruster
Victor Toso writes: > * Event's name: BLOCK_JOB_WAITING -> BLOCK_JOB_PENDING > * Argument device -> id > > Signed-off-by: Victor Toso > --- > qapi/block-core.json | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 5b6

Re: [PATCH 06/14] qapi: fix example of MEMORY_DEVICE_SIZE_CHANGE event

2022-03-25 Thread Markus Armbruster
John Snow writes: > On Thu, Mar 24, 2022 at 1:50 PM Victor Toso wrote: >> >> * qom-path is not optional List of one item. Recommend to scratch '* '. Slightly less terse, like "Event data member @qom-path is not optional" wouldn't hurt. >> >> Signed-off-by: Victor Toso >> --- >> qapi/machin

Re: [PATCH 05/14] qapi: fix example of DUMP_COMPLETED event

2022-03-25 Thread Markus Armbruster
John Snow writes: > On Thu, Mar 24, 2022 at 1:50 PM Victor Toso wrote: >> >> * Timestamp is not optional, let's add for completeness. >> * Add '<-' to signalize it is receiving the data >> * While at it, add extra space before "result" and "total" >> >> Signed-off-by: Victor Toso >> --- >> qap

Re: [PATCH] target/arm: Fix sve_ld1_z and sve_st1_z vs MMIO

2022-03-25 Thread Peter Maydell
On Thu, 24 Mar 2022 at 01:09, Richard Henderson wrote: > > Both of these functions missed handling the TLB_MMIO flag > during the conversion to handle MTE. > > Fixes: 10a85e2c8ab6 ("target/arm: Reuse sve_probe_page for gather loads") > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/925 >

Re: [PATCH] kvm/arm64: Fix memory section did not set to kvm

2022-03-25 Thread Peter Maydell
On Fri, 18 Mar 2022 at 14:24, Cong Liu wrote: > > on the arm64 platform, the PAGESIZE is 64k, the default qxl rom > bar size is 8k(QXL_ROM_SZ), in the case memory size less than > one page size, kvm_align_section return zero, the memory section > did not commit kvm. Can you give more details on

Re: [PULL 0/7] (Mostly) x86 fixes for QEMU 7.0.0-rc2

2022-03-25 Thread Peter Maydell
On Fri, 25 Mar 2022 at 07:13, Paolo Bonzini wrote: > > The following changes since commit 15ef89d2a1a7b93845a6b09c2ee8e1979f6eb30b: > > Update version for v7.0.0-rc1 release (2022-03-22 22:58:44 +) > > are available in the Git repository at: > > https://gitlab.com/bonzini/qemu.git tags/for

Re: [PATCH] ui/console: Check console before emitting GL event

2022-03-25 Thread Marc-André Lureau
Hi On Fri, Mar 25, 2022 at 1:53 PM Akihiko Odaki wrote: > Signed-off-by: Akihiko Odaki > Reviewed-by: Marc-André Lureau Akihiko, is this fixing a visible bug? If so, it would be nice you detail it in the commit message and someone should queue it for 7.0 thanks > --- > ui/console.c | 21

Re: [PATCH v3 1/4] hw/arm/virt: Consider SMP configuration in CPU topology

2022-03-25 Thread Igor Mammedov
On Wed, 23 Mar 2022 15:24:35 +0800 Gavin Shan wrote: > Currently, the SMP configuration isn't considered when the CPU > topology is populated. In this case, it's impossible to provide > the default CPU-to-NUMA mapping or association based on the socket > ID of the given CPU. > > This takes accou

Re: [PATCH v3 2/4] hw/arm/virt: Fix CPU's default NUMA node ID

2022-03-25 Thread Igor Mammedov
On Wed, 23 Mar 2022 15:24:36 +0800 Gavin Shan wrote: > When CPU-to-NUMA association isn't explicitly provided by users, > the default on is given by mc->get_default_cpu_node_id(). However, > the CPU topology isn't fully considered in the default association > and this causes CPU topology broken w

Re: [PATCH v2 01/17] iotests: replace calls to log(qemu_io(...)) with qemu_io_log()

2022-03-25 Thread Hanna Reitz
On 24.03.22 19:30, John Snow wrote: This makes these callsites a little simpler, but the real motivation is a forthcoming commit will change the return type of qemu_io(), so removing users of the return value now is helpful. Signed-off-by: John Snow Reviewed-by: Eric Blake --- tests/qemu-iot

Re: [PATCH v8 02/46] hw/cxl/component: Introduce CXL components (8.1.x, 8.2.5)

2022-03-25 Thread Jonathan Cameron via
On Fri, 18 Mar 2022 15:05:51 + Jonathan Cameron wrote: > From: Ben Widawsky > > A CXL 2.0 component is any entity in the CXL topology. All components > have a analogous function in PCIe. Except for the CXL host bridge, all > have a PCIe config space that is accessible via the common PCIe >

Re: [PATCH 3/7] linux-user/nios2: Adjust error return

2022-03-25 Thread Peter Maydell
On Fri, 25 Mar 2022 at 12:12, Peter Maydell wrote: > > On Sun, 20 Mar 2022 at 16:06, Richard Henderson > wrote: > > > > Follow syscall_set_return_value rather than the kernel assembly > > in setting the syscall return values. Only negate ret on error. > > > > Signed-off-by: Richard Henderson >

Re: [PATCH v3 4/4] hw/arm/virt: Unify ACPI processor ID in MADT and SRAT table

2022-03-25 Thread Igor Mammedov
On Wed, 23 Mar 2022 15:24:38 +0800 Gavin Shan wrote: > The value of the following field has been used in ACPI PPTT table > to identify the corresponding processor. This takes the same field > as the ACPI processor ID in MADT and SRAT tables. > > ms->possible_cpus->cpus[i].props.thread_id thre

Re: [PATCH v2 05/17] iotests/040: Fix TestCommitWithFilters test

2022-03-25 Thread Hanna Reitz
On 24.03.22 19:30, John Snow wrote: Without this change, asserting that qemu_io always returns 0 causes this test to fail in a way we happened not to be catching previously: qemu.utils.VerboseProcessError: Command '('/home/jsnow/src/qemu/bin/git/tests/qemu-iotests/../../qemu-io', '--cach

Re: [PATCH v2 14/17] iotests/image-fleecing: switch to qemu_io()

2022-03-25 Thread Hanna Reitz
On 24.03.22 19:30, John Snow wrote: This test expects failure ... but only sometimes. When? Why? It's for reads of a region not defined by a bitmap. Ah, yes, right.  The bitmaps defines what regions are to be backed up, so other regions are not covered by the fleecing scheme, and might be in

Re: [PATCH v2 15/17] iotests: remove qemu_io_pipe_and_status()

2022-03-25 Thread Hanna Reitz
On 24.03.22 19:30, John Snow wrote: I know we just added it, sorry. This is done in favor of qemu_io() which *also* returns the console output and status, but with more robust error handling on failure. Signed-off-by: John Snow --- tests/qemu-iotests/iotests.py | 3 --- 1 file changed, 3 del

Re: Re: [PATCH] kvm/arm64: Fix memory section did not set to kvm

2022-03-25 Thread liucong2
Hi Peter,I found this issue on qmeu 4.2 with host linux 4.19, I want touse qxl on arm64. on arm64, default page size is 64k, and theqxl_rom_size is fixed 8192.but when I read qxl_rom region in guest, guest os stopped andI can see error message "load/store instruction decodeing not implemented" in h

Re: [PATCH v2] block/stream: Drain subtree around graph change

2022-03-25 Thread Eric Blake
On Thu, Mar 24, 2022 at 03:09:07PM +0100, Hanna Reitz wrote: > When the stream block job cuts out the nodes between top and base in > stream_prepare(), it does not drain the subtree manually; it fetches the > base node, and tries to insert it as the top node's backing node with > bdrv_set_backing_h

Re: [PATCH] target/i386: tcg: high bits SSE cmp operation must be ignored

2022-03-25 Thread Richard Henderson
On 3/24/22 02:08, Paolo Bonzini wrote: High bits in the immediate operand of SSE comparisons are ignored, they do not result in an undefined opcode exception. This is mentioned explicitly in the Intel documentation. Reported-by:sonicadvan...@gmail.com Closes:https://gitlab.com/qemu-project/qemu

[PATCH 2/2] Some mmx/sse instructions in 'gen_sse' don't require CRO.TS=0

2022-03-25 Thread Wei Li
Some instructions in 'gen_sse' don't require CRO.TS=0 and the opcode of them are 0F38F[0-F], 0F3AF[0-F]. Signed-off-by: Wei Li --- target/i386/tcg/translate.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/trans

Re: [PATCH] iotests: update test owner contact information

2022-03-25 Thread Eric Blake
On Tue, Mar 22, 2022 at 01:42:12PM -0400, John Snow wrote: > Quite a few of these tests have stale contact information. This patch > updates the stale ones that I happen to be aware of at the moment. I would prefer we just drop the lines. Git history and MAINTAINERS is a better way to track this,

Re: [PATCH 01/10] python/aqmp: add explicit GPLv2 license to legacy.py

2022-03-25 Thread Eric Blake
On Thu, Mar 24, 2022 at 12:07:24PM -0400, John Snow wrote: ... > > Yep, as I mentioned, I don't want to see us abandon copyleft either. > > > > Of course everyone has their own preferred license, so I'm sure > > people who write apps with MIT, will think we should use MIT > > too. Ultimately though

[PULL 0/2] target-arm queue

2022-03-25 Thread Peter Maydell
org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20220325 for you to fetch changes up to c7ca3ad5e756e263daf082c315e311593ccec3d1: hw/intc/arm_gicv3_its: Add missing newlines to process_mapc() logging (2022-03-25 14:4

[PULL 1/2] target/arm: Fix sve_ld1_z and sve_st1_z vs MMIO

2022-03-25 Thread Peter Maydell
From: Richard Henderson Both of these functions missed handling the TLB_MMIO flag during the conversion to handle MTE. Fixes: 10a85e2c8ab6 ("target/arm: Reuse sve_probe_page for gather loads") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/925 Signed-off-by: Richard Henderson Message-i

Re: [PATCH] iotests: Fix status checks

2022-03-25 Thread Eric Blake
On Thu, Mar 24, 2022 at 07:02:21PM +0100, Hanna Reitz wrote: > An iotest's 'paused' condition is fickle; it will be reported as true > whenever the job is drained, for example, or when it is in the process > of completing. > > 030 and 041 contain such checks, we should replace them by checking the

[PULL 2/2] hw/intc/arm_gicv3_its: Add missing newlines to process_mapc() logging

2022-03-25 Thread Peter Maydell
In commit 84d43d2e82da we rearranged the logging of errors in process_mapc(), and inadvertently dropped the trailing newlines from the log messages. Restore them. The same commit also attempted to switch the ICID printing to hex (which is how we print ICIDs elsewhere) but only did half the job, add

Re: [PULL for-7.1 08/36] *: Use fprintf between qemu_log_lock/unlock

2022-03-25 Thread Richard Henderson
On 3/24/22 08:30, Alex Bennée wrote: Richard Henderson writes: On 3/23/22 10:22, Alex Bennée wrote: Richard Henderson writes: Inside qemu_log, we perform qemu_log_lock/unlock, which need not be done if we have already performed the lock beforehand. Always check the result of qemu_log_loc

Re: Re: [PATCH] kvm/arm64: Fix memory section did not set to kvm

2022-03-25 Thread Peter Maydell
On Fri, 25 Mar 2022 at 14:42, wrote: > I found this issue on qmeu 4.2 with host linux 4.19, I want to > use qxl on arm64. on arm64, default page size is 64k, and the > qxl_rom_size is fixed 8192. OK, so the fix to this is "use a newer QEMU". > but when I read qxl_rom region in guest, guest os st

Re: [PATCH v2 05/17] iotests/040: Fix TestCommitWithFilters test

2022-03-25 Thread John Snow
On Fri, Mar 25, 2022, 9:40 AM Hanna Reitz wrote: > On 24.03.22 19:30, John Snow wrote: > > Without this change, asserting that qemu_io always returns 0 causes this > > test to fail in a way we happened not to be catching previously: > > > > qemu.utils.VerboseProcessError: Command > >'('/hom

Re: [PATCH 01/14] qapi: BlockExportRemoveMode: move comments to TODO

2022-03-25 Thread John Snow
On Fri, Mar 25, 2022, 8:33 AM Markus Armbruster wrote: > Victor Toso writes: > > > @hide and @soft are potential additions which fits the TODO section > > perfectly. > > > > The main motivation is to avoid this whole block of comment entering > > the wrong section in the python parser. > > > > S

Re: [RFC PATCH 1/6] target/ppc: Add support for the Processor Attention instruction

2022-03-25 Thread Fabiano Rosas
Leandro Lupori writes: > From: Cédric Le Goater > > Check the HID0 bit to send signal, currently modeled as a checkstop. > The QEMU implementation adds an exit using the GPR[3] value (that's a > hack for tests) > > Signed-off-by: Cédric Le Goater > Signed-off-by: Leandro Lupori > --- > target

Re: [PATCH 1/7] linux-user/nios2: Fix clone child return

2022-03-25 Thread Richard Henderson
On 3/25/22 05:49, Peter Maydell wrote: On Sun, 20 Mar 2022 at 16:12, Richard Henderson wrote: The child side of clone needs to set the secondary syscall return value, r7, to indicate syscall success. Advance the pc before do_syscall, so that the new thread does not re-execute the clone syscal

[PATCH 2/2] softmmu/physmem: fix dirty memory bitmap memleak

2022-03-25 Thread Andrey Ryabinin
The sequence of ram_block_add()/qemu_ram_free()/ram_block_add() function calls leads to leaking some memory. ram_block_add() calls dirty_memory_extend() to allocate bitmap blocks for new memory. These blocks only grow but never shrink. So the qemu_ram_free() restores RAM size back to it's original

[PATCH 1/2] softmmu/physmem: move last_ram_page() call under qemu_mutex_lock_ramlist()

2022-03-25 Thread Andrey Ryabinin
The 'ram_list.blocks' modifications protected by 'ram_list.mutex'. last_ram_page() uses state of 'ram_list.blocks' to identify ram's size. ram_block_add() calls last_ram_page() before the mutex lock making the following race possible: CPU#0 CPU#1

[PATCH v2] ui/console: Check console before emitting GL event

2022-03-25 Thread Akihiko Odaki
Without this change, The GL output of a console overwrites the other consoles and makes them unusable. Signed-off-by: Akihiko Odaki Reviewed-by: Marc-André Lureau --- ui/console.c | 21 + 1 file changed, 21 insertions(+) diff --git a/ui/console.c b/ui/console.c index da434c

Re: [PATCH v2] block/stream: Drain subtree around graph change

2022-03-25 Thread Vladimir Sementsov-Ogievskiy
24.03.2022 17:09, Hanna Reitz wrote: When the stream block job cuts out the nodes between top and base in stream_prepare(), it does not drain the subtree manually; it fetches the base node, and tries to insert it as the top node's backing node with bdrv_set_backing_hd(). bdrv_set_backing_hd() ho

Re: [PATCH 01/10] python/aqmp: add explicit GPLv2 license to legacy.py

2022-03-25 Thread John Snow
On Fri, Mar 25, 2022, 10:55 AM Eric Blake wrote: > On Thu, Mar 24, 2022 at 12:07:24PM -0400, John Snow wrote: > ... > > > Yep, as I mentioned, I don't want to see us abandon copyleft either. > > > > > > Of course everyone has their own preferred license, so I'm sure > > > people who write apps wi

[PATCH] tests/tcg/xtensa: allow testing big-endian cores

2022-03-25 Thread Max Filippov
Don't disable all big-endian tests, instead check whether $(CORE) is supported by the configured $(QEMU) and enable tests if it is. Signed-off-by: Max Filippov --- MAINTAINERS| 1 + tests/tcg/xtensa/Makefile.softmmu-target | 4 ++-- tests/tcg/xtensaeb/Makefile.s

Re: [PATCH RESEND v1 0/2] i386: Make PIT and PIC the property of common x86 base machine type

2022-03-25 Thread Philippe Mathieu-Daudé
On 25/3/22 04:45, Xiaoyao Li wrote: On 3/10/2022 9:07 PM, Michael S. Tsirkin wrote: On Thu, Mar 10, 2022 at 08:28:09PM +0800, Xiaoyao Li wrote: For PIT, it's straightforward to merge microvm::pit and pc_machine::pit_enabled into x86ms::pit For PIC, move microvm::pic to x86ms:pic, which gives P

[PATCH-for-7.0 v3] qemu/main-loop: Disable block backend global state assertion on Cocoa

2022-03-25 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Since commit 0439c5a462 ("block/block-backend.c: assertions for block-backend") QEMU crashes when using Cocoa on Darwin hosts. Example on macOS: $ qemu-system-i386 Assertion failed: (qemu_in_main_thread()), function blk_all_next, file block-backend.c, line 552.

Re: [PATCH v3 1/4] hw/arm/virt: Consider SMP configuration in CPU topology

2022-03-25 Thread Gavin Shan
Hi Igor, On 3/25/22 9:19 PM, Igor Mammedov wrote: On Wed, 23 Mar 2022 15:24:35 +0800 Gavin Shan wrote: Currently, the SMP configuration isn't considered when the CPU topology is populated. In this case, it's impossible to provide the default CPU-to-NUMA mapping or association based on the sock

Re: [PATCH 3/7] linux-user/nios2: Adjust error return

2022-03-25 Thread Richard Henderson
On 3/25/22 07:37, Peter Maydell wrote: This turns out to be because in 2015 kernel commit c3525940cca5 switched powerpc from checking against 515/516 and instead made them check MAX_ERRNO (4095). (If anybody cared about seccomp on sparc hosts they'd probably want to fix the sparc kernel similarl

Re: [PATCH v3 4/4] hw/arm/virt: Unify ACPI processor ID in MADT and SRAT table

2022-03-25 Thread Gavin Shan
Hi Igor, On 3/25/22 10:00 PM, Igor Mammedov wrote: On Wed, 23 Mar 2022 15:24:38 +0800 Gavin Shan wrote: The value of the following field has been used in ACPI PPTT table to identify the corresponding processor. This takes the same field as the ACPI processor ID in MADT and SRAT tables. ms

Re: [PATCH 6/7] linux-user/nios2: Use QEMU_ESIGRETURN from do_rt_sigreturn

2022-03-25 Thread Richard Henderson
On 3/25/22 06:16, Peter Maydell wrote: +return -QEMU_ESIGRETURN; badframe: unlock_user_struct(frame, frame_addr, 0); Don't you also need to return -QEMU_ESIGRETURN in the badframe error-handling case? The other guest architecture implementations of do_sigreturn seem to do that. Y

Re: [PATCH] vdpa: Avoid reset when stop device

2022-03-25 Thread Si-Wei Liu
On 3/25/2022 2:00 AM, Michael Qiu wrote: On 2022/3/25 14:32, Si-Wei Liu wrote: On 3/23/2022 2:20 AM, Jason Wang wrote: Adding Eugenio,  and Ling Shan. On Wed, Mar 23, 2022 at 4:58 PM <08005...@163.com> wrote: From: Michael Qiu Currently, when VM poweroff, it will trigger vdpa device(

[PATCH v7 00/17] vfio-user server in QEMU

2022-03-25 Thread Jagannathan Raman
Hi, This is v7 of the server side changes to enable vfio-user in QEMU. Thank you very much for reviewing the last revision of this series! In this revision, we've dropped the patches concerning migration due to a major changes in the VFIO PCI protocol. We are changing the client, library and ser

[PATCH v7 01/17] tests/avocado: Specify target VM argument to helper routines

2022-03-25 Thread Jagannathan Raman
Specify target VM for exec_command and exec_command_and_wait_for_pattern routines Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Beraldo Leal Reviewed-by: Stefan Hajnoczi --- tests/avocado/avocad

[PATCH v7 02/17] qdev: unplug blocker for devices

2022-03-25 Thread Jagannathan Raman
Add blocker to prevent hot-unplug of devices Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- include/hw/qdev-core.h | 29 + hw/core/qdev.c | 24 softmmu/qdev-monitor.c | 4 3 fi

[PATCH v7 07/17] vfio-user: define vfio-user-server object

2022-03-25 Thread Jagannathan Raman
Define vfio-user object which is remote process server for QEMU. Setup object initialization functions and properties necessary to instantiate the object Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- qapi/qom.json | 20 +++- in

[PATCH v7 04/17] remote/machine: add vfio-user property

2022-03-25 Thread Jagannathan Raman
Add vfio-user to x-remote machine. It is a boolean, which indicates if the machine supports vfio-user protocol. The machine configures the bus differently vfio-user and multiprocess protocols, so this property informs it on how to configure the bus. This property should be short lived. Once vfio-u

  1   2   >