Re: [PATCH] target/i386: Return right size value after dynamic xfeature enabled

2022-03-24 Thread Paolo Bonzini
On 3/24/22 04:18, Yang Zhong wrote: The kvm_arch_get_supported_cpuid() only call KVM_GET_SUPPORTED_CPUID one time, so the cpuid buffer information still keep older value. Once Qemu enable new dynamic xfeature, like XTILEDATA, the cpuid[0D,0].{EBX,ECX} still return older value. This patch can ret

Re: [PATCH 31/32] RFC: Simplify softmmu/main.c

2022-03-24 Thread Paolo Bonzini
On 3/23/22 16:57, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Move qemu_main() declaration to a new header. Simplify main.c since both cocoa & sdl cannot be enabled together. (there might be some small conflict with the RFC patch "cocoa: run qemu_init in the main thread", but th

Re: [PATCH] target/i386: Return right size value after dynamic xfeature enabled

2022-03-24 Thread Yang Zhong
On Thu, Mar 24, 2022 at 08:35:10AM +0100, Paolo Bonzini wrote: > On 3/24/22 04:18, Yang Zhong wrote: > >The kvm_arch_get_supported_cpuid() only call KVM_GET_SUPPORTED_CPUID one > >time, so the cpuid buffer information still keep older value. Once Qemu > >enable new dynamic xfeature, like XTILEDATA,

Re: [RFC PATCH v3 12/36] i386/tdx: Add property sept-ve-disable for tdx-guest object

2022-03-24 Thread Gerd Hoffmann
On Thu, Mar 24, 2022 at 02:52:10PM +0800, Xiaoyao Li wrote: > On 3/22/2022 5:02 PM, Gerd Hoffmann wrote: > > On Thu, Mar 17, 2022 at 09:58:49PM +0800, Xiaoyao Li wrote: > > > Add sept-ve-disable property for tdx-guest object. It's used to > > > configure bit 28 of TD attributes. > > > > What is th

Re: [RFC PATCH v3 17/36] pflash_cfi01/tdx: Introduce ram_mode of pflash for TDVF

2022-03-24 Thread Gerd Hoffmann
Hi, > > > Well, if persistent vars are not supported anyway there is little reason > > > to split the firmware into CODE and VARS files. You can use just use > > > OVMF.fd with a single pflash device. libvirt recently got support for > > > that. > > > > Agreed. > > The purpose of using split

Re: [RFC PATCH v3 12/36] i386/tdx: Add property sept-ve-disable for tdx-guest object

2022-03-24 Thread Xiaoyao Li
On 3/24/2022 3:57 PM, Gerd Hoffmann wrote: On Thu, Mar 24, 2022 at 02:52:10PM +0800, Xiaoyao Li wrote: On 3/22/2022 5:02 PM, Gerd Hoffmann wrote: On Thu, Mar 17, 2022 at 09:58:49PM +0800, Xiaoyao Li wrote: Add sept-ve-disable property for tdx-guest object. It's used to configure bit 28 of TD a

[PATCH] target/i386: tcg: high bits SSE cmp operation must be ignored

2022-03-24 Thread Paolo Bonzini
High bits in the immediate operand of SSE comparisons are ignored, they do not result in an undefined opcode exception. This is mentioned explicitly in the Intel documentation. Reported-by: sonicadvan...@gmail.com Closes: https://gitlab.com/qemu-project/qemu/-/issues/184 Signed-off-by: Paolo Bonz

Re: [RFC PATCH v3 17/36] pflash_cfi01/tdx: Introduce ram_mode of pflash for TDVF

2022-03-24 Thread Xiaoyao Li
On 3/24/2022 3:58 PM, Gerd Hoffmann wrote: Hi, Well, if persistent vars are not supported anyway there is little reason to split the firmware into CODE and VARS files. You can use just use OVMF.fd with a single pflash device. libvirt recently got support for that. Agreed. The purpose o

[PULL 03/10] linux-user: Split out helpers for sigsuspend

2022-03-24 Thread Laurent Vivier
From: Richard Henderson Two new functions: process_sigsuspend_mask and finish_sigsuspend_mask. Move the size check and copy-from-user code. Signed-off-by: Richard Henderson Reviewed-by: Laurent Vivier Message-Id: <20220315084308.433109-3-richard.hender...@linaro.org> Signed-off-by: Laurent Viv

[PULL 02/10] linux-user/alpha: Fix sigsuspend for big-endian hosts

2022-03-24 Thread Laurent Vivier
From: Richard Henderson On alpha, the sigset argument for sigsuspend is in a register. When we drop that into memory that happens in host-endianness, but target_to_host_old_sigset will treat it as target-endianness. Signed-off-by: Richard Henderson Reviewed-by: Laurent Vivier Message-Id: <2022

[PULL 08/10] linux-user/arm: Implement __kernel_memory_barrier

2022-03-24 Thread Laurent Vivier
From: Richard Henderson This fallback syscall was stubbed out. It would only matter for emulating pre-armv6. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220323005839.94327-2-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/arm/cpu_loop

[PULL 10/10] linux-user/arm: Implement __kernel_cmpxchg64 with host atomics

2022-03-24 Thread Laurent Vivier
From: Richard Henderson If CONFIG_ATOMIC64, we can use a host cmpxchg and provide atomicity across processes; otherwise we have no choice but to continue using start/end_exclusive. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220323005839.94327-4-richard.hender...

[PULL 05/10] linux-user: Properly handle sigset arg to epoll_pwait

2022-03-24 Thread Laurent Vivier
From: Richard Henderson Unblocked signals are never delivered, because we didn't record the new mask for process_pending_signals. Handle this with the same mechanism as sigsuspend. Signed-off-by: Richard Henderson Reviewed-by: Laurent Vivier Message-Id: <20220315084308.433109-5-richard.hender.

[PULL 09/10] linux-user/arm: Implement __kernel_cmpxchg with host atomics

2022-03-24 Thread Laurent Vivier
From: Richard Henderson The existing implementation using start/end_exclusive does not provide atomicity across processes. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220323005839.94327-3-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-use

[PULL 00/10] Linux user for 7.0 patches

2022-03-24 Thread Laurent Vivier
r-7.0-pull-request for you to fetch changes up to 330ea9d1d819680ac7501457220b8cd1c29f9d2f: linux-user/arm: Implement __kernel_cmpxchg64 with host atomics (2022-03-23 16:53:17 +0100) linux-user pull request 20220324 Fix MIPS n32

[PULL 06/10] linux-user: Properly handle sigset arg to ppoll

2022-03-24 Thread Laurent Vivier
From: Richard Henderson Unblocked signals are never delivered, because we didn't record the new mask for process_pending_signals. Handle this with the same mechanism as sigsuspend. Signed-off-by: Richard Henderson Reviewed-by: Laurent Vivier Message-Id: <20220315084308.433109-6-richard.hender.

[PULL 01/10] linux-user: Fix syscall parameter handling for MIPS n32

2022-03-24 Thread Laurent Vivier
From: WANG Xuerui The MIPS n32 ABI is basically n64 with the address space (i.e. pointer width) shrinked to 32 bits. Meanwhile the current code treats it as o32-like based on TARGET_ABI_BITS, which causes problems with n32 syscalls utilizing 64-bit offsets, like pread64, affecting most (if not al

[PULL 07/10] linux-user: Fix missing space in error message

2022-03-24 Thread Laurent Vivier
From: Fergus Henderson Signed-off-by: Fergus Henderson Signed-off-by: Patrick Venture Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220310192148.1696486-1-vent...@google.com> Signed-off-by: Laurent Vivier --- linux-user/elfload.c | 2 +- 1 file changed, 1 ins

[PULL 04/10] linux-user: Properly handle sigset arg to pselect

2022-03-24 Thread Laurent Vivier
From: Richard Henderson Unblocked signals are never delivered, because we didn't record the new mask for process_pending_signals. Handle this with the same mechanism as sigsuspend. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/834 Signed-off-by: Richard Henderson Reviewed-by: Laurent

[PATCH 2/2] hw/core: loader: Setting is_linux to true for VxWorks uImage

2022-03-24 Thread Bin Meng
From: Bin Meng VxWorks 7 now uses the same boot interface as the Linux kernel on Arm64, PowerPC and RISC-V architectures, except Arm. Add logic to set is_linux to true for VxWorks uImage for these architectures in load_uboot_image(). Signed-off-by: Bin Meng --- hw/core/loader.c | 15 +

Re: [PATCH] i386/cpu: Remove the deprecated cpu model 'Icelake-Client'

2022-03-24 Thread Igor Mammedov
On Mon, 14 Mar 2022 16:50:59 +0800 Robert Hoo wrote: > Icelake, is the codename for Intel 3rd generation Xeon Scalable server > processors. There isn't ever client variants. This "Icelake-Client" CPU > model was added wrongly and imaginarily. > > It has been deprecated since v5.2, now it's time

Re: [PATCH-for-7.0] target/i386/hvf: Free ressources when vCPU is destroyed

2022-03-24 Thread Igor Mammedov
On Tue, 22 Mar 2022 20:07:45 +0100 Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > Both xsave_buf and hvf_caps are allocated in hvf_arch_init_vcpu(), > free them in hvf_arch_vcpu_destroy(). > > Reported-by: Mark Kanda > Suggested-by: Igor Mammedov > Signed-off-by: Philippe M

RE: [PATCH V2 1/4] intel-iommu: don't warn guest errors when getting rid2pasid entry

2022-03-24 Thread Tian, Kevin
> From: Jason Wang > Sent: Monday, March 21, 2022 1:54 PM > > We use to warn on wrong rid2pasid entry. But this error could be > triggered by the guest and could happens during initialization. So > let's don't warn in this case. > > Signed-off-by: Jason Wang > --- > hw/i386/intel_iommu.c | 6 ++

Re: [RFC PATCH v3 17/36] pflash_cfi01/tdx: Introduce ram_mode of pflash for TDVF

2022-03-24 Thread Gerd Hoffmann
On Tue, Mar 22, 2022 at 01:20:24PM +0100, Gerd Hoffmann wrote: > Hi, > > > At the time I did try a gross hack that (IIRC) disabled the > > rom_reset logic, and munged x86_bios_rom_init so that it would > > force load it straight at the RAM location. > > Sounds reasonable. The whole rom logic e

RE: [PATCH V2 3/4] intel-iommu: convert VTD_PE_GET_FPD_ERR() to be a function

2022-03-24 Thread Tian, Kevin
> From: Jason Wang > Sent: Monday, March 21, 2022 1:54 PM > @@ -1724,6 +1713,19 @@ out: > trace_vtd_pt_enable_fast_path(source_id, success); > } > > +static void vtd_qualify_report_fault(IntelIOMMUState *s, > + int err, bool is_fpd_set, > +

[PATCH 1/2] hw/core: Sync uboot_image.h from U-Boot v2022.01

2022-03-24 Thread Bin Meng
From: Bin Meng Sync uboot_image.h from upstream U-Boot v2022.01 release [1]. [1] https://source.denx.de/u-boot/u-boot/-/blob/v2022.01/include/image.h Signed-off-by: Bin Meng --- hw/core/uboot_image.h | 213 -- 1 file changed, 142 insertions(+), 71 dele

Re: [PATCH-for-7.0] build: disable fcf-protection on -march=486 -m16

2022-03-24 Thread Christian Ehrhardt
On Wed, Mar 23, 2022 at 11:54 AM Philippe Mathieu-Daudé wrote: > > On 23/3/22 10:07, christian.ehrha...@canonical.com wrote: > > From: Christian Ehrhardt > > > > Some of the roms build with -march=i486 -m16 which is incompatible > > with -fcf-protection. That in turn is can be set by default, for

Re: [RFC PATCH v2 2/4] target/riscv: smstateen check for h/senvcfg

2022-03-24 Thread Mayuresh Chitale
On Wed, Mar 23, 2022 at 6:22 PM Weiwei Li wrote: > > > 在 2022/3/23 下午7:13, Mayuresh Chitale 写道: > > Accesses to henvcfg, henvcfgh and senvcfg are allowed > > only if corresponding bit in mstateen0/hstateen0 is > > enabled. Otherwise an illegal instruction trap is > > generated. > > > > Signed-off-

[PATCH] target/i386: introduce CPU property to work around Windows reset bug

2022-03-24 Thread Paolo Bonzini
Some versions of Windows hang on reboot if their TSC value is greater than 2^54. The calibration of the Hyper-V reference time overflows and fails; as a result the processors' clock sources are out of sync. As a workaround, reset the TSC to a small value. Do not do this unconditionally and requir

Re: [RFC PATCH v2 1/4] target/riscv: Add smstateen support

2022-03-24 Thread Mayuresh Chitale
On Wed, Mar 23, 2022 at 6:31 PM Weiwei Li wrote: > > > 在 2022/3/23 下午7:13, Mayuresh Chitale 写道: > > Smstateen extension specifies a mechanism to close > > the potential covert channels that could cause security issues. > > > > This patch adds the CSRs defined in the specification and > > the corre

Re: [RFC PATCH v2 4/4] target/riscv: smstateen check for AIA/IMSIC

2022-03-24 Thread Mayuresh Chitale
On Wed, Mar 23, 2022 at 6:43 PM Weiwei Li wrote: > > > 在 2022/3/23 下午7:13, Mayuresh Chitale 写道: > > If smstateen is implemented then accesses to AIA > > registers CSRS, IMSIC CSRs and other IMSIC registers > > is controlled by setting of corresponding bits in > > mstateen/hstateen registers. Other

Re:Re: Address mapping for vIOMMU

2022-03-24 Thread leohou
At 2022-03-24 12:27:46, "Jason Wang" wrote: >On Thu, Mar 24, 2022 at 12:15 PM leohou wrote: >> >> hi all, >> When I use DPDK in guestOS and configering the VM with vIOMMU, I found >> that sending the gVA to the hardware device , the hardware device can't >> find the real data. >> But sendin

RE: [PATCH V2 4/4] intel-iommu: PASID support

2022-03-24 Thread Tian, Kevin
> From: Jason Wang > Sent: Monday, March 21, 2022 1:54 PM > > This patch introduce ECAP_PASID via "x-pasid-mode". Based on the > existing support for scalable mode, we need to implement the following > missing parts: > > 1) tag VTDAddressSpace with PASID and support IOMMU/DMA translation >wit

Re: [RFC PATCH v3 17/36] pflash_cfi01/tdx: Introduce ram_mode of pflash for TDVF

2022-03-24 Thread Daniel P . Berrangé
On Thu, Mar 24, 2022 at 02:13:53PM +0800, Xiaoyao Li wrote: > On 3/22/2022 5:29 PM, Daniel P. Berrangé wrote: > > On Tue, Mar 22, 2022 at 10:21:41AM +0100, Gerd Hoffmann wrote: > > >Hi, > > > > > > > > If you don't need a pflash device, don't use it: simply map your nvram > > > > > region as r

Re: [PATCH 01/10] python/aqmp: add explicit GPLv2 license to legacy.py

2022-03-24 Thread Daniel P . Berrangé
On Thu, Mar 24, 2022 at 09:00:05AM +, Daniel P. Berrangé wrote: > On Wed, Mar 23, 2022 at 05:47:48PM -0400, John Snow wrote: > > On Mon, Mar 21, 2022 at 5:08 PM John Snow wrote: > > > > > > The legacy.py module is heavily based on the QMP module by Luiz > > > Capitulino (et al) which is licens

Re: [PATCH 01/10] python/aqmp: add explicit GPLv2 license to legacy.py

2022-03-24 Thread Daniel P . Berrangé
On Wed, Mar 23, 2022 at 05:47:48PM -0400, John Snow wrote: > On Mon, Mar 21, 2022 at 5:08 PM John Snow wrote: > > > > The legacy.py module is heavily based on the QMP module by Luiz > > Capitulino (et al) which is licensed as explicit GPLv2-only. The async > > QMP package is currently licensed sim

Re: [PATCH] hw/riscv: virt: Warn the user if -bios is provided when using KVM

2022-03-24 Thread Daniel P . Berrangé
On Wed, Mar 23, 2022 at 06:13:46PM +0100, Ralf Ramsauer wrote: > The -bios option is silently ignored if used in combination with -enable-kvm. > The reason is that the machine starts in S-Mode, and the bios typically runs > in > M-Mode. > > Warn the user that the bios won't be loaded. > > Signed

Re: [PATCH] target/i386: introduce CPU property to work around Windows reset bug

2022-03-24 Thread Daniel P . Berrangé
On Thu, Mar 24, 2022 at 09:23:46AM +0100, Paolo Bonzini wrote: > Some versions of Windows hang on reboot if their TSC value is greater > than 2^54. The calibration of the Hyper-V reference time overflows > and fails; as a result the processors' clock sources are out of sync. > As a workaround, res

Re: [PATCH] target/i386: introduce CPU property to work around Windows reset bug

2022-03-24 Thread Daniel P . Berrangé
On Thu, Mar 24, 2022 at 09:13:12AM +, Daniel P. Berrangé wrote: > On Thu, Mar 24, 2022 at 09:23:46AM +0100, Paolo Bonzini wrote: > > Some versions of Windows hang on reboot if their TSC value is greater > > than 2^54. The calibration of the Hyper-V reference time overflows > > and fails; as a

Re: [PATCH 00/32] Misc cleanups

2022-03-24 Thread Stefan Hajnoczi
On Wed, Mar 23, 2022 at 07:57:11PM +0400, marcandre.lur...@redhat.com wrote: > Various cleanup patches gleaned while working on different things. A good half > of them are realted to cleaning up qemu-common.h. I didn't review the patches in detail but have no concerns in the areas that I maintain:

Re: [RFC PATCH v3 12/36] i386/tdx: Add property sept-ve-disable for tdx-guest object

2022-03-24 Thread Gerd Hoffmann
Hi, > #VE can be triggered in various situations. e.g., CPUID on some leaves, and > RD/WRMSR on some MSRs. #VE on pending page is just one of the sources, Linux > just wants to disable this kind of #VE since it wants to prevent unexpected > #VE during SYSCALL gap. Linux guests can't disable tho

Re: [PATCH] target/i386: introduce CPU property to work around Windows reset bug

2022-03-24 Thread Paolo Bonzini
On 3/24/22 10:15, Daniel P. Berrangé wrote: On Thu, Mar 24, 2022 at 09:13:12AM +, Daniel P. Berrangé wrote: On Thu, Mar 24, 2022 at 09:23:46AM +0100, Paolo Bonzini wrote: Some versions of Windows hang on reboot if their TSC value is greater than 2^54. The calibration of the Hyper-V referen

Re: [PATCH] block/rbd: fix write zeroes with growing images

2022-03-24 Thread Peter Lieven
Am 22.03.22 um 10:38 schrieb Hanna Reitz: On 21.03.22 09:31, Stefano Garzarella wrote: On Sat, Mar 19, 2022 at 04:15:33PM +0100, Peter Lieven wrote: Am 18.03.2022 um 17:47 schrieb Stefano Garzarella : On Fri, Mar 18, 2022 at 04:48:18PM +0100, Peter Lieven wrote: Am 18.03.2022 um 09:25

Re: [PATCH] hw/char/serial: Support serial_mm_init() with wakeup event.

2022-03-24 Thread Dylan Jhong
On Wed, Mar 23, 2022 at 05:37:10PM +0800, Peter Maydell wrote: > On Wed, 23 Mar 2022 at 09:20, Dylan Jhong wrote: > > > > Although the "wakeup" parameter is declared in SerialState, > > but there is no function actually setting it up. > > Support "wakeup" as parameter in serial_mm_init(). > > Thi

[PATCH v1 1/2] aspeed/i2c: Add new register mode for ast2600/1030

2022-03-24 Thread Troy Lee
AST2600/1030 provides a new register mode which is controlled by I2CG0C[2]. If the I2CG0C[2] = 1, then I2C will switch to a new set of register. This commit supports new register mode with packet operation and DMA enabled. Byte/buffer mode is not implemented. Signed-off-by: Troy Lee Signed-off-b

[PATCH v1 2/2] aspeed: Add I2C buses to AST1030 model

2022-03-24 Thread Troy Lee
Instanitate the I2C buses in AST1030 model and create two slave device for ast1030-evb. Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee --- hw/arm/aspeed_ast1030.c | 17 + hw/arm/aspeed_minibmc.c | 13 + 2 files changed, 30 insertions(+)

Re: [PATCH 1/2] gdbstub: Set current_cpu for memory read write

2022-03-24 Thread Alex Bennée
Bin Meng writes: > On Tue, Mar 22, 2022 at 11:56 PM Peter Maydell > wrote: >> >> On Tue, 22 Mar 2022 at 15:43, Bin Meng wrote: >> > >> > When accessing the per-CPU register bank of some devices (e.g.: GIC) >> > from the GDB stub context, a segfault occurs. This is due to current_cpu >> > is

Re: [PATCH] iotests: update test owner contact information

2022-03-24 Thread Stefan Hajnoczi
On Wed, Mar 23, 2022 at 01:10:19PM +0100, Hanna Reitz wrote: > On 23.03.22 09:39, Thomas Huth wrote: > > On 22/03/2022 18.42, John Snow wrote: > > > Quite a few of these tests have stale contact information. This patch > > > updates the stale ones that I happen to be aware of at the moment. > > >

Re: [PATCH] block/rbd: fix write zeroes with growing images

2022-03-24 Thread Stefano Garzarella
On Thu, Mar 24, 2022 at 10:52:04AM +0100, Peter Lieven wrote: Am 22.03.22 um 10:38 schrieb Hanna Reitz: On 21.03.22 09:31, Stefano Garzarella wrote: On Sat, Mar 19, 2022 at 04:15:33PM +0100, Peter Lieven wrote: Am 18.03.2022 um 17:47 schrieb Stefano Garzarella : On Fri, Mar 18, 2022 at 04

Re: [PATCH] block/rbd: fix write zeroes with growing images

2022-03-24 Thread Peter Lieven
Am 24.03.22 um 11:40 schrieb Stefano Garzarella: On Thu, Mar 24, 2022 at 10:52:04AM +0100, Peter Lieven wrote: Am 22.03.22 um 10:38 schrieb Hanna Reitz: On 21.03.22 09:31, Stefano Garzarella wrote: On Sat, Mar 19, 2022 at 04:15:33PM +0100, Peter Lieven wrote: Am 18.03.2022 um 17:47 schrieb

Re: qemu-binfmt-conf.sh: improvements for mips

2022-03-24 Thread Laurent Vivier
Le 24/03/2022 à 00:05, Andreas K. Hüttel a écrit : Re-sending v3 unchanged as requested. The first patch has already been submitted earlier and is unchanged from v2. The second patch extends it and resolves issue 843, "duplicate magic mips patterns". Tested with various self-bootstrapped Gentoo

Re: [PATCH-for-7.0 0/2] misc: Fix misleading hexadecimal format

2022-03-24 Thread Stefan Hajnoczi
On Wed, Mar 23, 2022 at 12:47:16PM +0100, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > Fix 0x%d misleading format reported here: > https://lore.kernel.org/qemu-devel/dab530d9-53d2-3d7d-c9ac-44906ba9b...@linaro.org/ > > Philippe Mathieu-Daudé (2): > block: Fix misleading hex

Re: [PULL for 7.0 0/8] i386, docs, gitlab fixes

2022-03-24 Thread Peter Maydell
On Wed, 23 Mar 2022 at 19:05, Alex Bennée wrote: > > > Peter Maydell writes: > > Is there anything in here that would affect s390 host? The > > s390 job seems to be consistently timing out, eg: > > https://gitlab.com/qemu-project/qemu/-/jobs/2241445160 > > but I have a feeling this is a pre-exist

Re: [PATCH] target/i386: introduce CPU property to work around Windows reset bug

2022-03-24 Thread Daniel P . Berrangé
On Thu, Mar 24, 2022 at 10:42:22AM +0100, Paolo Bonzini wrote: > On 3/24/22 10:15, Daniel P. Berrangé wrote: > > On Thu, Mar 24, 2022 at 09:13:12AM +, Daniel P. Berrangé wrote: > > > On Thu, Mar 24, 2022 at 09:23:46AM +0100, Paolo Bonzini wrote: > > > > Some versions of Windows hang on reboot i

Re: [PATCH] block/rbd: fix write zeroes with growing images

2022-03-24 Thread Hanna Reitz
On 24.03.22 11:42, Peter Lieven wrote: Am 24.03.22 um 11:40 schrieb Stefano Garzarella: On Thu, Mar 24, 2022 at 10:52:04AM +0100, Peter Lieven wrote: Am 22.03.22 um 10:38 schrieb Hanna Reitz: On 21.03.22 09:31, Stefano Garzarella wrote: On Sat, Mar 19, 2022 at 04:15:33PM +0100, Peter Lieven w

Re: [PATCH] iotests: update test owner contact information

2022-03-24 Thread Hanna Reitz
On 24.03.22 11:36, Stefan Hajnoczi wrote: On Wed, Mar 23, 2022 at 01:10:19PM +0100, Hanna Reitz wrote: On 23.03.22 09:39, Thomas Huth wrote: On 22/03/2022 18.42, John Snow wrote: Quite a few of these tests have stale contact information. This patch updates the stale ones that I happen to be aw

hang in migration-test (s390 host)

2022-03-24 Thread Peter Maydell
Here's the hang in the migration-test process. It's in the test_multifd_tcp_cancel() test. Here the status returned by the QEMU process is "cancelling", and we are spinning forever waiting for a "cancelled" state that never arrives. I can keep these stuck tests around for a day or so in case ther

hang in virtio-failover-test (s390 host)

2022-03-24 Thread Peter Maydell
This is a backtrace from virtio-failover-test, which had hung on the s390 gitlab CI runner. Both processes were using CPU, so this is some kind of livelock, not a deadlock. Looking more closely at the virtio-net-failover process, in the function test_migrate_off_abort() we have executed 'migrate_c

Re: [PATCH] target/i386: introduce CPU property to work around Windows reset bug

2022-03-24 Thread Paolo Bonzini
On 3/24/22 12:03, Daniel P. Berrangé wrote: "This only applies to virtual machine hardware version 10 as Windows resets the TSC on all CPUs on virtual machines with older hardware versions (which do not support hypervisor.cpuid.v2)." do you know what they mean when they refer to 'hyp

Re: [PATCH] block/rbd: fix write zeroes with growing images

2022-03-24 Thread Peter Lieven
Am 24.03.22 um 12:06 schrieb Hanna Reitz: On 24.03.22 11:42, Peter Lieven wrote: Am 24.03.22 um 11:40 schrieb Stefano Garzarella: On Thu, Mar 24, 2022 at 10:52:04AM +0100, Peter Lieven wrote: Am 22.03.22 um 10:38 schrieb Hanna Reitz: On 21.03.22 09:31, Stefano Garzarella wrote: On Sat, Mar 1

Re: [PATCH 2/2] hw/core: loader: Setting is_linux to true for VxWorks uImage

2022-03-24 Thread Philippe Mathieu-Daudé
On 24/3/22 09:22, Bin Meng wrote: From: Bin Meng VxWorks 7 now uses the same boot interface as the Linux kernel on Arm64, PowerPC and RISC-V architectures, except Arm. Add logic to set is_linux to true for VxWorks uImage for these architectures in load_uboot_image(). Signed-off-by: Bin Meng -

Re: [PATCH v3 for-7.1] vfio/common: remove spurious tpm-crb-cmd misalignment warning

2022-03-24 Thread Cornelia Huck
On Wed, Mar 23 2022, Eric Auger wrote: > The CRB command buffer currently is a RAM MemoryRegion and given > its base address alignment, it causes an error report on > vfio_listener_region_add(). This region could have been a RAM device > region, easing the detection of such safe situation but thi

Re: [PATCH 1/2] gdbstub: Set current_cpu for memory read write

2022-03-24 Thread Peter Maydell
On Thu, 24 Mar 2022 at 10:33, Alex Bennée wrote: > I think we need to not use cpu_physical_memory_write (which is > explicitly the system address space) but have a function that takes cpu > so it can work out the correct address space to you > address_space_read/write. If null we could probably re

Re: hang in virtio-failover-test (s390 host)

2022-03-24 Thread Laurent Vivier
On 24/03/2022 12:11, Peter Maydell wrote: This is a backtrace from virtio-failover-test, which had hung on the s390 gitlab CI runner. Both processes were using CPU, so this is some kind of livelock, not a deadlock. Looking more closely at the virtio-net-failover process, in the function test_mig

Re: [PATCH v3 for-7.1] vfio/common: remove spurious tpm-crb-cmd misalignment warning

2022-03-24 Thread Stefan Berger
On 3/24/22 07:50, Cornelia Huck wrote: On Wed, Mar 23 2022, Eric Auger wrote: The CRB command buffer currently is a RAM MemoryRegion and given its base address alignment, it causes an error report on vfio_listener_region_add(). This region could have been a RAM device region, easing the det

Re: [PATCH] hw/char/serial: Support serial_mm_init() with wakeup event.

2022-03-24 Thread Peter Maydell
On Thu, 24 Mar 2022 at 10:00, Dylan Jhong wrote: > > On Wed, Mar 23, 2022 at 05:37:10PM +0800, Peter Maydell wrote: > > On Wed, 23 Mar 2022 at 09:20, Dylan Jhong wrote: > > > > > > Although the "wakeup" parameter is declared in SerialState, > > > but there is no function actually setting it up. >

[PATCH] block/stream: Drain subtree around graph change

2022-03-24 Thread Hanna Reitz
When the stream block job cuts out the nodes between top and base in stream_prepare(), it does not drain the subtree manually; it fetches the base node, and tries to insert it as the top node's backing node with bdrv_set_backing_hd(). bdrv_set_backing_hd() however will drain, and so the actual bas

Re: hang in migration-test (s390 host)

2022-03-24 Thread Laurent Vivier
Perhaps Juan or Thomas can help too (added to cc) Is this a regression? It looks like a bug in QEMU as it doesn't move from cancelling to cancelled. Thanks, Laurent On 24/03/2022 12:19, Peter Maydell wrote: Here's the hang in the migration-test process. It's in the test_multifd_tcp_cancel() te

Re: hang in virtio-failover-test (s390 host)

2022-03-24 Thread Peter Maydell
On Thu, 24 Mar 2022 at 11:53, Laurent Vivier wrote: > > On 24/03/2022 12:11, Peter Maydell wrote: > > This is a backtrace from virtio-failover-test, which had hung > > on the s390 gitlab CI runner. Both processes were using CPU, > > so this is some kind of livelock, not a deadlock. > > > > Looking

Re: hang in migration-test (s390 host)

2022-03-24 Thread Peter Maydell
On Thu, 24 Mar 2022 at 12:59, Laurent Vivier wrote: > > Perhaps Juan or Thomas can help too (added to cc) > > Is this a regression? > It looks like a bug in QEMU as it doesn't move from cancelling to cancelled. This test has had intermittent hangs, especially but not exclusively on s390, for a ve

Re: [PATCH 1/2] pcie: Don't try triggering a LSI when not defined

2022-03-24 Thread Daniel Henrique Barboza
On 3/21/22 12:33, Frederic Barrat wrote: This patch skips [de]asserting a LSI interrupt if the device doesn't have any LSI defined. Doing so would trigger an assert in pci_irq_handler(). The PCIE root port implementation in qemu requests a LSI (INTA), but a subclass may want to change that be

Re: [PATCH 2/2] ppc/pnv: Remove LSI on the PCIE host bridge

2022-03-24 Thread Daniel Henrique Barboza
On 3/21/22 12:33, Frederic Barrat wrote: The phb3/phb4/phb5 root ports inherit from the default PCIE root port implementation, which requests a LSI interrupt (#INTA). On real hardware (POWER8/POWER9/POWER10), there is no such LSI. This patch corrects it so that it matches the hardware. As a c

Re: [PATCH 2/2] hw/core: loader: Setting is_linux to true for VxWorks uImage

2022-03-24 Thread Peter Maydell
On Thu, 24 Mar 2022 at 08:38, Bin Meng wrote: > > From: Bin Meng > > VxWorks 7 now uses the same boot interface as the Linux kernel on > Arm64, PowerPC and RISC-V architectures, except Arm. Add logic to > set is_linux to true for VxWorks uImage for these architectures in > load_uboot_image(). > >

Re: [PATCH 1/2] pcie: Don't try triggering a LSI when not defined

2022-03-24 Thread Frederic Barrat
On 24/03/2022 14:07, Daniel Henrique Barboza wrote: On 3/21/22 12:33, Frederic Barrat wrote: This patch skips [de]asserting a LSI interrupt if the device doesn't have any LSI defined. Doing so would trigger an assert in pci_irq_handler(). The PCIE root port implementation in qemu requests

iotest40 problem

2022-03-24 Thread Li Zhang
Hi, When I run the testsuit on our buidling system, it reports a timeout sometimes not always as the following. It couldn't connect qmp socket. Any ideas about this problem? [ 1989s] --- /home/abuild/rpmbuild/BUILD/qemu-6.2.0/tests/qemu-iotests/040.out [ 1989s] +++ 040.out.bad [ 1989s] @@ -

[PATCH v2 1/2] hw/core: Sync uboot_image.h from U-Boot v2022.01

2022-03-24 Thread Bin Meng
From: Bin Meng Sync uboot_image.h from upstream U-Boot v2022.01 release [1]. [1] https://source.denx.de/u-boot/u-boot/-/blob/v2022.01/include/image.h Signed-off-by: Bin Meng --- (no changes since v1) hw/core/uboot_image.h | 213 -- 1 file changed, 142

[PATCH v2 2/2] hw/core: loader: Set is_linux to true for VxWorks uImage

2022-03-24 Thread Bin Meng
From: Bin Meng VxWorks 7 uses the same boot interface as the Linux kernel on Arm (64-bit only), PowerPC and RISC-V architectures. Add logic to set is_linux to true for VxWorks uImage for these architectures in load_uboot_image(). Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé ---

Re: [PATCH v1 2/2] aspeed: Add I2C buses to AST1030 model

2022-03-24 Thread Cédric Le Goater
On 3/24/22 11:04, Troy Lee wrote: Instanitate the I2C buses in AST1030 model and create two slave device for ast1030-evb. Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee Reviewed-by: Cédric Le Goater Thanks, C. --- hw/arm/aspeed_ast1030.c | 17

Re: [PATCH 1/2] pcie: Don't try triggering a LSI when not defined

2022-03-24 Thread Daniel Henrique Barboza
On 3/24/22 10:47, Frederic Barrat wrote: On 24/03/2022 14:07, Daniel Henrique Barboza wrote: On 3/21/22 12:33, Frederic Barrat wrote: This patch skips [de]asserting a LSI interrupt if the device doesn't have any LSI defined. Doing so would trigger an assert in pci_irq_handler(). The PCI

[PATCH v2] block/stream: Drain subtree around graph change

2022-03-24 Thread Hanna Reitz
When the stream block job cuts out the nodes between top and base in stream_prepare(), it does not drain the subtree manually; it fetches the base node, and tries to insert it as the top node's backing node with bdrv_set_backing_hd(). bdrv_set_backing_hd() however will drain, and so the actual bas

Re: [PATCH 01/10] python/aqmp: add explicit GPLv2 license to legacy.py

2022-03-24 Thread Andrea Bolognani
On Thu, Mar 24, 2022 at 09:03:07AM +, Daniel P. Berrangé wrote: > > Overall making it *all* GPLv2+ compat is going to be important if you > > want people to be comfortable using it. If it has a mix of GPLv2+ > > and GPLv2-only code in the source tarball, then the overall combined > > work will

Re: [PULL for-7.1 08/36] *: Use fprintf between qemu_log_lock/unlock

2022-03-24 Thread Alex Bennée
Richard Henderson writes: > On 3/23/22 10:22, Alex Bennée wrote: >> Richard Henderson writes: >> >>> Inside qemu_log, we perform qemu_log_lock/unlock, which need >>> not be done if we have already performed the lock beforehand. >>> >>> Always check the result of qemu_log_lock -- only checking

Re: [RFC PATCH v3 12/36] i386/tdx: Add property sept-ve-disable for tdx-guest object

2022-03-24 Thread Xiaoyao Li
On 3/24/2022 5:37 PM, Gerd Hoffmann wrote: Hi, #VE can be triggered in various situations. e.g., CPUID on some leaves, and RD/WRMSR on some MSRs. #VE on pending page is just one of the sources, Linux just wants to disable this kind of #VE since it wants to prevent unexpected #VE during SYSCA

Re: [PATCH 01/10] python/aqmp: add explicit GPLv2 license to legacy.py

2022-03-24 Thread Daniel P . Berrangé
On Thu, Mar 24, 2022 at 02:29:25PM +, Andrea Bolognani wrote: > On Thu, Mar 24, 2022 at 09:03:07AM +, Daniel P. Berrangé wrote: > > > Overall making it *all* GPLv2+ compat is going to be important if you > > > want people to be comfortable using it. If it has a mix of GPLv2+ > > > and GPLv2

Re: [PATCH 01/10] python/aqmp: add explicit GPLv2 license to legacy.py

2022-03-24 Thread John Snow
On Thu, Mar 24, 2022, 5:03 AM Daniel P. Berrangé wrote: > On Thu, Mar 24, 2022 at 09:00:05AM +, Daniel P. Berrangé wrote: > > On Wed, Mar 23, 2022 at 05:47:48PM -0400, John Snow wrote: > > > On Mon, Mar 21, 2022 at 5:08 PM John Snow wrote: > > > > > > > > The legacy.py module is heavily base

Re: [PATCH 01/10] python/aqmp: add explicit GPLv2 license to legacy.py

2022-03-24 Thread Daniel P . Berrangé
On Thu, Mar 24, 2022 at 11:03:12AM -0400, John Snow wrote: > On Thu, Mar 24, 2022, 5:03 AM Daniel P. Berrangé > wrote: > > > On Thu, Mar 24, 2022 at 09:00:05AM +, Daniel P. Berrangé wrote: > > > I've not fully audited the git history, but what little I've looked > > > at, the relicensing does

Device driver api

2022-03-24 Thread Sam Price
Is there a shared library interface in the works for writing firmware device models without recompiling all of qemu? I was reading through https://sebastienbourdelin.com/2021/06/16/writing-a-custom-device-for-qemu/ but was wondering if there was a shared library approach where I could build my dev

Re: [PATCH v5 00/13] KVM: mm: fd-based approach for supporting KVM guest private memory

2022-03-24 Thread Quentin Perret
Hi Chao, +CC Will and Marc for visibility. On Thursday 10 Mar 2022 at 22:08:58 (+0800), Chao Peng wrote: > This is the v5 of this series which tries to implement the fd-based KVM > guest private memory. The patches are based on latest kvm/queue branch > commit: > > d5089416b7fb KVM: x86: Intro

Re: [PATCH 09/32] include/qapi: add g_autoptr support for qobject types

2022-03-24 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Need wrappers for qobject_unref() calls, which is a macro. > > Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster

Re: [PATCH] iotests: update test owner contact information

2022-03-24 Thread Stefan Hajnoczi
On Thu, Mar 24, 2022 at 12:08:20PM +0100, Hanna Reitz wrote: > On 24.03.22 11:36, Stefan Hajnoczi wrote: > > On Wed, Mar 23, 2022 at 01:10:19PM +0100, Hanna Reitz wrote: > > > On 23.03.22 09:39, Thomas Huth wrote: > > > > On 22/03/2022 18.42, John Snow wrote: > > > > > Quite a few of these tests ha

Re: [PATCH 01/10] python/aqmp: add explicit GPLv2 license to legacy.py

2022-03-24 Thread John Snow
On Thu, Mar 24, 2022 at 11:25 AM Daniel P. Berrangé wrote: > > On Thu, Mar 24, 2022 at 11:03:12AM -0400, John Snow wrote: > > On Thu, Mar 24, 2022, 5:03 AM Daniel P. Berrangé > > wrote: > > > > > On Thu, Mar 24, 2022 at 09:00:05AM +, Daniel P. Berrangé wrote: > > > > I've not fully audited th

Re: [PULL for 7.0 0/8] i386, docs, gitlab fixes

2022-03-24 Thread Peter Maydell
On Wed, 23 Mar 2022 at 11:27, Alex Bennée wrote: > > The following changes since commit 15ef89d2a1a7b93845a6b09c2ee8e1979f6eb30b: > > Update version for v7.0.0-rc1 release (2022-03-22 22:58:44 +) > > are available in the Git repository at: > > https://github.com/stsquad/qemu.git tags/pull-

Re: [PATCH v1 1/2] aspeed/i2c: Add new register mode for ast2600/1030

2022-03-24 Thread Cédric Le Goater
Hello Troy, On 3/24/22 11:04, Troy Lee wrote: AST2600/1030 provides a new register mode which is controlled by I2CG0C[2]. If the I2CG0C[2] = 1, then I2C will switch to a new set of register. This commit supports new register mode with packet operation and DMA enabled. Byte/buffer mode is not im

[PULL for-7.0 0/2] Block patches

2022-03-24 Thread Stefan Hajnoczi
The following changes since commit 15ef89d2a1a7b93845a6b09c2ee8e1979f6eb30b: Update version for v7.0.0-rc1 release (2022-03-22 22:58:44 +) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block-pull-request for you to fetch changes up to 2539eade4f689eda

Re: [PATCH] target/i386: introduce CPU property to work around Windows reset bug

2022-03-24 Thread Paolo Bonzini
On 3/24/22 12:24, Paolo Bonzini wrote: That said, the VMware kbase does paint a slightly different picture.  It implies that starting with hardware version 11 rebooting Windows is done through a hard reset instead of INIT.  I'm not sure how that would be done, but in the meanwhile our fix shoul

[PULL for-7.0 2/2] hw: Fix misleading hexadecimal format

2022-03-24 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé "0x%u" format is very misleading, replace by "0x%x". Found running: $ git grep -E '0x%[0-9]*([lL]*|" ?PRI)[dDuU]' hw/ Inspired-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Message-id: 20220323114718.58714-3-philip

[PULL for-7.0 1/2] block: Fix misleading hexadecimal format

2022-03-24 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé "0x%u" format is very misleading, replace by "0x%x". Found running: $ git grep -E '0x%[0-9]*([lL]*|" ?PRI)[dDuU]' block/ Inspired-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Hanna Reitz Reviewed-by: Daniel P. Berrangé Reviewed-by:

[PATCH v4 0/4] Replace 'qemu_irq_split' with 'TYPE_SPLIT_IRQ'

2022-03-24 Thread Zongyuan Li
This patch set tries to replace 'qemu_irq_split' function with QOM object 'TYPE_SPLIT_IRQ' and totally remove this call. If this patch set is applied, issue: https://gitlab.com/qemu-project/qemu/-/issues/811 can be closed. Changes since v3: 1. Squash Patch 3 & 4 into one, since they would affe

[PATCH v4 1/4] hw/arm/realview: replace 'qemu_split_irq' with 'TYPE_SPLIT_IRQ'

2022-03-24 Thread Zongyuan Li
Signed-off-by: Zongyuan Li --- hw/arm/realview.c | 33 - 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/hw/arm/realview.c b/hw/arm/realview.c index 7b424e94a5..d2dc8a8952 100644 --- a/hw/arm/realview.c +++ b/hw/arm/realview.c @@ -13,9 +13,11 @@ #in

[PATCH v4 4/4] hw/core/irq: remove unused 'qemu_irq_split' function

2022-03-24 Thread Zongyuan Li
Signed-off-by: Zongyuan Li Reviewed-by: Peter Maydell Resolves: https://gitlab.com/qemu-project/qemu/-/issues/811 --- hw/core/irq.c| 15 --- include/hw/irq.h | 5 - 2 files changed, 20 deletions(-) diff --git a/hw/core/irq.c b/hw/core/irq.c index 741219277b..3623f711fe 1006

  1   2   3   >