[PATCH v21 0/9] support dirty restraint on vCPU

2022-03-16 Thread huangy81
From: Hyman Huang(黄勇) v21 - remove the tmpfs declarations in header file and test case should use tmpfs as internal var respectively. v20 - fix the style problems and let QEMU test pass - change the dirty limit case logic: test fail if dirtyrate measurement 200ms timeout v19 - rebase on mas

Re: [PATCH 10/27] Replace config-time define HOST_WORDS_BIGENDIAN

2022-03-16 Thread Marc-André Lureau
On Wed, Mar 16, 2022 at 5:04 PM Philippe Mathieu-Daudé wrote: > > On 16/3/22 10:53, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Replace a config-time define with a compile time condition > > define (compatible with clang and gcc) that must be declared prior to > > its u

Re: [PATCH 09/27] compiler.h: replace QEMU_SENTINEL with G_GNUC_NULL_TERMINATED

2022-03-16 Thread Philippe Mathieu-Daudé
On 16/3/22 10:53, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau One less qemu-specific macro. It also helps to make some headers/units only depend on glib, and thus moved in standalone projects eventually. Signed-off-by: Marc-André Lureau Reviewed-by: Richard Henderson --- inc

[PATCH v21 3/9] migration/dirtyrate: Refactor dirty page rate calculation

2022-03-16 Thread huangy81
From: Hyman Huang(黄勇) abstract out dirty log change logic into function global_dirty_log_change. abstract out dirty page rate calculation logic via dirty-ring into function vcpu_calculate_dirtyrate. abstract out mathematical dirty page rate calculation into do_calculate_dirtyrate, decouple it f

[PATCH v21 5/9] accel/kvm/kvm-all: Introduce kvm_dirty_ring_size function

2022-03-16 Thread huangy81
From: Hyman Huang(黄勇) Introduce kvm_dirty_ring_size util function to help calculate dirty ring ful time. Signed-off-by: Hyman Huang(黄勇) Acked-by: Peter Xu --- accel/kvm/kvm-all.c| 5 + accel/stubs/kvm-stub.c | 6 ++ include/sysemu/kvm.h | 2 ++ 3 files changed, 13 insertions(+)

Re: [PULL 0/8] s390x and misc fixes

2022-03-16 Thread Peter Maydell
On Wed, 16 Mar 2022 at 12:18, Paolo Bonzini wrote: > > On 3/15/22 19:58, Peter Maydell wrote: > > On Tue, 15 Mar 2022 at 11:20, Thomas Huth wrote: > > This results in every "Linking" step on my macos box producing the > > warning: > > > > ld: warning: directory not found for option > > '-Lns/Xcod

[PATCH v21 4/9] softmmu/dirtylimit: Implement vCPU dirtyrate calculation periodically

2022-03-16 Thread huangy81
From: Hyman Huang(黄勇) Introduce the third method GLOBAL_DIRTY_LIMIT of dirty tracking for calculate dirtyrate periodly for dirty page rate limit. Add dirtylimit.c to implement dirtyrate calculation periodly, which will be used for dirty page rate limit. Add dirtylimit.h to export util functions

Re: [PATCH 11/27] osdep: poison HOST_WORDS_BIGENDIAN

2022-03-16 Thread Philippe Mathieu-Daudé
On 16/3/22 10:53, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Signed-off-by: Marc-André Lureau Suggested-by: Richard Henderson --- include/qemu/osdep.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 322103aadbdc..7

[PATCH v21 8/9] migration-test: Export migration-test util funtions

2022-03-16 Thread huangy81
From: Hyman Huang(黄勇) Dirtylimit qtest can reuse the mechanisms that have been implemented by migration-test to start a vm, so export the relevant util functions. Signed-off-by: Hyman Huang(黄勇) --- tests/qtest/migration-helpers.c | 87 ++ tests/qtest/migration-helpers.

[PATCH v21 6/9] softmmu/dirtylimit: Implement virtual CPU throttle

2022-03-16 Thread huangy81
From: Hyman Huang(黄勇) Setup a negative feedback system when vCPU thread handling KVM_EXIT_DIRTY_RING_FULL exit by introducing throttle_us_per_full field in struct CPUState. Sleep throttle_us_per_full microseconds to throttle vCPU if dirtylimit is in service. Signed-off-by: Hyman Huang(黄勇) Revie

[PATCH 1/3] hw/display/cirrus_vga: Clean up indentation in pci_cirrus_vga_realize()

2022-03-16 Thread Thomas Huth
Most of the code in this function had been indented with 5 spaces instead of 4. Since 4 is our preferred style, remove one space in the bad lines here. Signed-off-by: Thomas Huth --- hw/display/cirrus_vga.c | 57 + 1 file changed, 29 insertions(+), 28 dele

Re: [PATCH 07/27] Replace GCC_FMT_ATTR with G_GNUC_PRINTF

2022-03-16 Thread Philippe Mathieu-Daudé
On 16/3/22 10:52, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau One less qemu-specific macro. It also helps to make some headers/units only depend on glib, and thus moved in standalone projects eventually. Signed-off-by: Marc-André Lureau --- audio/audio.h

Re: [PATCH 26/27] tests: replace free_all() usage with g_auto

2022-03-16 Thread Marc-André Lureau
Hi On Wed, Mar 16, 2022 at 5:00 PM Markus Armbruster wrote: > > Marc-André Lureau writes: > > > Hi > > > > On Wed, Mar 16, 2022 at 4:33 PM Markus Armbruster wrote: > >> > >> marcandre.lur...@redhat.com writes: > >> > >> > From: Marc-André Lureau > >> > > >> > Use more idiomatic glib/auto-style

Re: [PATCH 00/27] Misc fixes and cleanups for 7.0?

2022-03-16 Thread Daniel P . Berrangé
On Wed, Mar 16, 2022 at 01:51:56PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Hi, > > Various clean-up and fixes patches that might be worth it for 7.0. > Some of the patches have been posted and reviewed before. FYI, something went wrong with this posting, as it ha

[PATCH 3/3] hw/display/vga: Report a proper error when adding a 2nd ISA VGA

2022-03-16 Thread Thomas Huth
QEMU currently abort()s if the user tries to add a second ISA VGA device, for example: $ ./qemu-system-x86_64 -device isa-vga -device isa-vga RAMBlock "vga.vram" already registered, abort! Aborted (core dumped) $ ./qemu-system-x86_64 -device isa-cirrus-vga -device isa-cirrus-vga RAMBlock "vga.vram

Re: [PATCH 24/27] Remove trailing ; after G_DEFINE_AUTO macro

2022-03-16 Thread Philippe Mathieu-Daudé
On 16/3/22 10:54, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau The macro doesn't need it. Signed-off-by: Marc-André Lureau --- configure| 2 +- nbd/server.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 10/27] Replace config-time define HOST_WORDS_BIGENDIAN

2022-03-16 Thread Philippe Mathieu-Daudé
On 16/3/22 14:04, Philippe Mathieu-Daudé wrote: On 16/3/22 10:53, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Replace a config-time define with a compile time condition define (compatible with clang and gcc) that must be declared prior to its usage. This avoids having a global c

Re: [PATCH v2 2/2] Added parameter to take screenshot with screendump as

2022-03-16 Thread Markus Armbruster
Kshitij Suri writes: > From: "kshitij.suri" > > Currently screendump only supports PPM format, which is un-compressed and not > standard. Added a "format" parameter to qemu monitor screendump capabilites > to support PNG image capture using libpng. The param was added in QAPI schema > of screend

Re: [PATCH 00/27] Misc fixes and cleanups for 7.0?

2022-03-16 Thread Marc-André Lureau
Hi On Wed, Mar 16, 2022 at 5:09 PM Daniel P. Berrangé wrote: > > On Wed, Mar 16, 2022 at 01:51:56PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Hi, > > > > Various clean-up and fixes patches that might be worth it for 7.0. > > Some of the patches have been poste

Re: [PATCH 16/27] util: remove the net/net.h dependency

2022-03-16 Thread Philippe Mathieu-Daudé
On 16/3/22 10:54, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Move qemu_ether_ntoa() which is only needed in net/. Signed-off-by: Marc-André Lureau Reviewed-by: Richard Henderson Reviewed-by: Peter Maydell --- include/qemu-common.h | 1 - net/announce.c| 13 ++

Re: [PATCH 1/3] hw/display/cirrus_vga: Clean up indentation in pci_cirrus_vga_realize()

2022-03-16 Thread Philippe Mathieu-Daudé
On 16/3/22 14:24, Thomas Huth wrote: Most of the code in this function had been indented with 5 spaces instead of 4. Since 4 is our preferred style, remove one space in the bad lines here. Signed-off-by: Thomas Huth --- hw/display/cirrus_vga.c | 57 +

Re: Call for GSoC and Outreachy project ideas for summer 2022

2022-03-16 Thread Stefan Hajnoczi
On Mon, 14 Feb 2022 at 13:58, Stefan Hajnoczi wrote: > > On Wed, 9 Feb 2022 at 14:50, Alexander Graf wrote: > > On 28.01.22 16:47, Stefan Hajnoczi wrote: > > > Dear QEMU, KVM, and rust-vmm communities, > > > QEMU will apply for Google Summer of Code 2022 > > > (https://summerofcode.withgoogle.com

Re: [PATCH 13/27] Move HOST_LONG_BITS to compiler.h

2022-03-16 Thread Philippe Mathieu-Daudé
On 16/3/22 10:53, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau This will help to make common code independent. Signed-off-by: Marc-André Lureau Reviewed-by: Richard Henderson --- include/qemu/compiler.h | 3 +++ include/qemu/osdep.h| 3 --- 2 files changed, 3 insertions

Re: [PATCH 07/27] Replace GCC_FMT_ATTR with G_GNUC_PRINTF

2022-03-16 Thread Thomas Huth
On 16/03/2022 14.16, Philippe Mathieu-Daudé wrote: On 16/3/22 10:52, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau One less qemu-specific macro. It also helps to make some headers/units only depend on glib, and thus moved in standalone projects eventually. Signed-off-by: Marc-And

Re: Call for GSoC and Outreachy project ideas for summer 2022

2022-03-16 Thread Alexander Graf
Hey Stefan! On 16.03.22 14:16, Stefan Hajnoczi wrote: On Mon, 14 Feb 2022 at 13:58, Stefan Hajnoczi wrote: On Wed, 9 Feb 2022 at 14:50, Alexander Graf wrote: On 28.01.22 16:47, Stefan Hajnoczi wrote: Dear QEMU, KVM, and rust-vmm communities, QEMU will apply for Google Summer of Code 2022 (h

Re: [PATCH 08/27] compiler.h: replace QEMU_WARN_UNUSED_RESULT with G_GNUC_WARN_UNUSED_RESULT

2022-03-16 Thread Philippe Mathieu-Daudé
On 16/3/22 10:52, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau One less qemu-specific macro. It also helps to make some headers/units only depend on glib, and thus moved in standalone projects eventually. Signed-off-by: Marc-André Lureau Reviewed-by: Richard Henderson --- inc

Re: [PATCH 00/27] Misc fixes and cleanups for 7.0?

2022-03-16 Thread Philippe Mathieu-Daudé
On 16/3/22 10:51, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Hi, Various clean-up and fixes patches that might be worth it for 7.0. Some of the patches have been posted and reviewed before. Marc-André Lureau (27): m68k/nios2-semi: fix gettimeofday() result check meson: r

[PATCH 2/3] hw/display: Allow vga_common_init() to return errors

2022-03-16 Thread Thomas Huth
The vga_common_init() function currently cannot report errors to its caller. But in the following patch, we'd need this possibility, so let's change it to take an "Error **" as parameter for this. Signed-off-by: Thomas Huth --- hw/display/ati.c| 7 ++- hw/display/cirrus_vga.c

Re: [PATCH v2 3/6] libvduse: Add VDUSE (vDPA Device in Userspace) library

2022-03-16 Thread Stefan Hajnoczi
On Tue, Mar 15, 2022 at 07:38:12PM +0800, Yongji Xie wrote: > On Tue, Mar 15, 2022 at 5:48 PM Stefan Hajnoczi wrote: > > > > On Tue, Feb 15, 2022 at 06:59:40PM +0800, Xie Yongji wrote: > > > VDUSE [1] is a linux framework that makes it possible to implement > > > software-emulated vDPA devices in

[PATCH v2] tests/migration: Introduce dirty-ring-size option into guestperf

2022-03-16 Thread huangy81
From: Hyman Huang(黄勇) Guestperf tool does not enable diry ring feature when test migration by default. To support dirty ring migration performance test, introduce dirty-ring-size option into guestperf tools, which ranges in [1024, 65536]. To set dirty ring size with 4096 during migration test:

[PATCH 0/3] Fix crash when adding a second ISA VGA device

2022-03-16 Thread Thomas Huth
QEMU currently abort()s if the user tries to add a second ISA VGA device, for example: $ ./qemu-system-x86_64 -device isa-vga -device isa-vga RAMBlock "vga.vram" already registered, abort! Aborted (core dumped) $ ./qemu-system-x86_64 -device isa-cirrus-vga -device isa-cirrus-vga RAMBlock "vga.vram

[PATCH v2] Introduce dirty ring live migration test for guestperf

2022-03-16 Thread huangy81
From: Hyman Huang(黄勇) v2: - rebase on master - fix style problems and make qemu test passes Ping Please review. Thanks, Regards Yong v1: - original version sent by accident, send the right patch Dirtylimit implementation has been reviewed in the past few months, if things go well, it will be

Re: [PATCH v2 4/6] vduse-blk: implements vduse-blk export

2022-03-16 Thread Yongji Xie
On Wed, Mar 16, 2022 at 8:16 PM Stefan Hajnoczi wrote: > > On Tue, Mar 15, 2022 at 07:52:03PM +0800, Yongji Xie wrote: > > On Tue, Mar 15, 2022 at 7:08 PM Stefan Hajnoczi wrote: > > > > > > On Tue, Feb 15, 2022 at 06:59:41PM +0800, Xie Yongji wrote: > > > > This implements a VDUSE block backends

Re: [PATCH 2/3] hw/display: Allow vga_common_init() to return errors

2022-03-16 Thread Thomas Huth
On 16/03/2022 14.32, Philippe Mathieu-Daudé wrote: On 16/3/22 14:24, Thomas Huth wrote: The vga_common_init() function currently cannot report errors to its caller. But in the following patch, we'd need this possibility, so let's change it to take an "Error **" as parameter for this. Signed-off

Re: [PATCH 07/27] Replace GCC_FMT_ATTR with G_GNUC_PRINTF

2022-03-16 Thread Daniel P . Berrangé
On Wed, Mar 16, 2022 at 01:52:48PM +0400, marcandre.lur...@redhat.com wrote: > diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h > index 3baa5e3790f7..f2bd050e3b9a 100644 > --- a/include/qemu/compiler.h > +++ b/include/qemu/compiler.h > @@ -79,19 +79,12 @@ > #define QEMU_BUILD_BUG_ON_

Re: [PATCH 0/3] coroutine: use QEMU_DEFINE_STATIC_CO_TLS()

2022-03-16 Thread Stefan Hajnoczi
On Mon, Mar 07, 2022 at 03:38:50PM +, Stefan Hajnoczi wrote: > The coroutine implementation uses __thread variables internally. Compiler > optimizations may cache Thread-Local Storage values across > qemu_coroutine_yield(), leading to stale values being used after the coroutine > is re-entered

[PATCH-for-7.0 v2] qga/vss-win32: fix compilation with clang++

2022-03-16 Thread Helge Konetzka
This fixes: qga/vss-win32/install.cpp:49:24: error: cannot initialize a variable of type 'char *' with an rvalue of type 'const char *' char *msg = NULL, *nul = strchr(text, '('); ^ ~ Signed-off-by: Helge Konetzka Reviewed-by: Marc-André Lureau Re

Re: [PATCH 07/27] Replace GCC_FMT_ATTR with G_GNUC_PRINTF

2022-03-16 Thread Marc-André Lureau
Hi On Wed, Mar 16, 2022 at 5:30 PM Daniel P. Berrangé wrote: > > On Wed, Mar 16, 2022 at 01:52:48PM +0400, marcandre.lur...@redhat.com wrote: > > diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h > > index 3baa5e3790f7..f2bd050e3b9a 100644 > > --- a/include/qemu/compiler.h > > +++ b/

Re: [PATCH v20 2/7] net/vmnet: add vmnet backends to qapi/net

2022-03-16 Thread Markus Armbruster
Vladislav Yaroshchuk writes: > Create separate netdevs for each vmnet operating mode: > - vmnet-host > - vmnet-shared > - vmnet-bridged > > Signed-off-by: Vladislav Yaroshchuk Any QAPI schema changes since v15? I'm asking because I acked v8, v13, and v15, but each time you neglected to carry m

Re: [PATCH] docs/tcg-plugins: document QEMU_PLUGIN behaviour

2022-03-16 Thread Mahmoud Abumandour
On Wed, Mar 16, 2022 at 2:40 PM Christoph Muellner wrote: > QEMU plugins can be loaded via command line arguments or via > the QEMU_PLUGIN environment variable. Currently, only the first method > is documented. Let's document QEMU_PLUGIN. > > Signed-off-by: Christoph Muellner > --- > docs/devel

Re: [PATCH 2/3] hw/display: Allow vga_common_init() to return errors

2022-03-16 Thread Philippe Mathieu-Daudé
On 16/3/22 14:24, Thomas Huth wrote: The vga_common_init() function currently cannot report errors to its caller. But in the following patch, we'd need this possibility, so let's change it to take an "Error **" as parameter for this. Signed-off-by: Thomas Huth --- hw/display/ati.c

Re: [PATCH 05/12] compiler.h: drop __printf__ macro MinGW/glib workaround

2022-03-16 Thread Daniel P . Berrangé
On Thu, Feb 24, 2022 at 08:14:47PM +, Peter Maydell wrote: > On Thu, 24 Feb 2022 at 19:50, Marc-André Lureau > wrote: > > On Thu, Feb 24, 2022 at 11:23 PM Peter Maydell > > wrote: > >> You're probably building with a newer glib, and possibly also > >> a newer mingw. > >> > >> I've cc'd Stefa

Re: [PATCH v2 3/6] libvduse: Add VDUSE (vDPA Device in Userspace) library

2022-03-16 Thread Yongji Xie
On Wed, Mar 16, 2022 at 9:28 PM Stefan Hajnoczi wrote: > > On Tue, Mar 15, 2022 at 07:38:12PM +0800, Yongji Xie wrote: > > On Tue, Mar 15, 2022 at 5:48 PM Stefan Hajnoczi wrote: > > > > > > On Tue, Feb 15, 2022 at 06:59:40PM +0800, Xie Yongji wrote: > > > > VDUSE [1] is a linux framework that mak

[PATCH v3 1/3] Introduce event-loop-base abstract class

2022-03-16 Thread Nicolas Saenz Julienne
Introduce the 'event-loop-base' abstract class, it'll hold the properties common to all event loops and provide the necessary hooks for their creation and maintenance. Then have iothread inherit from it. EventLoopBaseClass is defined as user creatable and provides a hook for its children to attach

[PATCH v3 2/3] util/main-loop: Introduce the main loop into QOM

2022-03-16 Thread Nicolas Saenz Julienne
'event-loop-base' provides basic property handling for all 'AioContext' based event loops. So let's define a new 'MainLoopClass' that inherits from it. This will permit tweaking the main loop's properties through qapi as well as through the command line using the '-object' keyword[1]. Only one inst

[PATCH v2] docs/tcg-plugins: document QEMU_PLUGIN behaviour

2022-03-16 Thread Christoph Muellner
QEMU plugins can be loaded via command line arguments or via the QEMU_PLUGIN environment variable. Currently, only the first method is documented. Let's document QEMU_PLUGIN. As drive-by cleanup, this patch fixes the path to the plugins in the same section of the documentation. Signed-off-by: Chr

Re: [PATCH] docs/tcg-plugins: document QEMU_PLUGIN behaviour

2022-03-16 Thread Christoph Müllner
On Wed, Mar 16, 2022 at 2:44 PM Mahmoud Abumandour wrote: > > > On Wed, Mar 16, 2022 at 2:40 PM Christoph Muellner > wrote: > >> QEMU plugins can be loaded via command line arguments or via >> the QEMU_PLUGIN environment variable. Currently, only the first method >> is documented. Let's document

[PATCH v3 0/3] util/thread-pool: Expose minimun and maximum size

2022-03-16 Thread Nicolas Saenz Julienne
As discussed on the previous RFC[1] the thread-pool's dynamic thread management doesn't play well with real-time and latency sensitive systems. This series introduces a set of controls that'll permit achieving more deterministic behaviours, for example by fixing the pool's size. We first introduce

Re: [PATCH 2/3] hw/display: Allow vga_common_init() to return errors

2022-03-16 Thread Markus Armbruster
Thomas Huth writes: > On 16/03/2022 14.32, Philippe Mathieu-Daudé wrote: >> On 16/3/22 14:24, Thomas Huth wrote: >>> The vga_common_init() function currently cannot report errors to its >>> caller. But in the following patch, we'd need this possibility, so >>> let's change it to take an "Error **

[PATCH v3 3/3] util/event-loop-base: Introduce options to set the thread pool size

2022-03-16 Thread Nicolas Saenz Julienne
The thread pool regulates itself: when idle, it kills threads until empty, when in demand, it creates new threads until full. This behaviour doesn't play well with latency sensitive workloads where the price of creating a new thread is too high. For example, when paired with qemu's '-mlock', or usi

Re: [RFC PATCH] python: add qmp-send program to send raw qmp commands to qemu

2022-03-16 Thread Damien Hedde
On 3/16/22 11:24, Daniel P. Berrangé wrote: On Wed, Mar 16, 2022 at 10:54:55AM +0100, Damien Hedde wrote: It takes an input file containing raw qmp commands (concatenated json dicts) and send all commands one by one to a qmp server. When one command fails, it exits. As a convenience, it can

Re: [PULL 0/8] s390x and misc fixes

2022-03-16 Thread Paolo Bonzini
On 3/16/22 14:19, Peter Maydell wrote: I'm not sure why we're passing this explicitly to the linker anyway, though. According to the commit message the idea is to add libc++ automatically when you have C++ sources, libgfortran when you have Fortran sources etc. independent of the language tha

Re: [PATCH] softmmu/physmem: Use qemu_madvise

2022-03-16 Thread Andrew Deason
On Wed, 16 Mar 2022 10:41:41 +0100 David Hildenbrand wrote: > On 16.03.22 10:37, Dr. David Alan Gilbert wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > >> On Wed, 16 Mar 2022 at 07:53, David Hildenbrand wrote: > >>> > >>> On 16.03.22 05:04, Andrew Deason wrote: > We have a th

Re: [PATCH v3 2/3] util/main-loop: Introduce the main loop into QOM

2022-03-16 Thread Markus Armbruster
Nicolas Saenz Julienne writes: > 'event-loop-base' provides basic property handling for all 'AioContext' > based event loops. So let's define a new 'MainLoopClass' that inherits > from it. This will permit tweaking the main loop's properties through > qapi as well as through the command line usin

Re: [PATCH 1/4] target/i386: Fix sanity check on max APIC ID / X2APIC enablement

2022-03-16 Thread David Woodhouse
On Wed, 2022-03-16 at 12:28 +0100, Igor Mammedov wrote: > Generally Daniel is right, as long as it's something that what real hardware > supports. (usually it's job if upper layers which know what guest OS is used, > and can tweak config based on that knowledge). > > But it's virt only extension a

Re: [PATCH 02/27] meson: remove bsd_oses

2022-03-16 Thread Marc-André Lureau
Hi On Wed, Mar 16, 2022 at 6:40 PM Paolo Bonzini wrote: > > On 3/16/22 10:52, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > It is unused. > > It's fine to remove it now, but I'll bring it back in 7.1. :) You decide. Whatever, but if noone ack it, let's leave it then. t

Re: [PULL 21/50] block/block-backend.c: assertions for block-backend

2022-03-16 Thread Emanuele Giuseppe Esposito
Am 16/03/2022 um 13:53 schrieb Philippe Mathieu-Daudé: > On 16/3/22 13:44, Philippe Mathieu-Daudé wrote: >> Hi, >> >> On 4/3/22 17:46, Kevin Wolf wrote: >>> From: Emanuele Giuseppe Esposito >>> >>> All the global state (GS) API functions will check that >>> qemu_in_main_thread() returns true. I

Re: [PATCH v2] block-qdict: Fix -Werror=maybe-uninitialized build failure

2022-03-16 Thread Markus Armbruster
Murilo Opsfelder Araújo writes: > Hi, Philippe. > > On Monday, March 14, 2022 10:47:11 AM -03 Philippe Mathieu-Daudé wrote: >> On 11/3/22 23:16, Murilo Opsfelder Araujo wrote: >> > Building QEMU on Fedora 37 (Rawhide Prerelease) ppc64le failed with the >> > following error: >> > >> > $ ../co

Re: [PATCH 02/27] meson: remove bsd_oses

2022-03-16 Thread Paolo Bonzini
On 3/16/22 10:52, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau It is unused. It's fine to remove it now, but I'll bring it back in 7.1. :) You decide. Paolo Signed-off-by: Marc-André Lureau --- meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/meson.build b/

Re: [PATCH 05/12] compiler.h: drop __printf__ macro MinGW/glib workaround

2022-03-16 Thread Peter Maydell
On Wed, 16 Mar 2022 at 13:44, Daniel P. Berrangé wrote: > > On Thu, Feb 24, 2022 at 08:14:47PM +, Peter Maydell wrote: > > On Thu, 24 Feb 2022 at 19:50, Marc-André Lureau > > wrote: > > > On Thu, Feb 24, 2022 at 11:23 PM Peter Maydell > > > wrote: > > >> You're probably building with a newe

Re: [PATCH 05/12] compiler.h: drop __printf__ macro MinGW/glib workaround

2022-03-16 Thread Daniel P . Berrangé
On Wed, Mar 16, 2022 at 02:41:41PM +, Peter Maydell wrote: > On Wed, 16 Mar 2022 at 13:44, Daniel P. Berrangé wrote: > > > > On Thu, Feb 24, 2022 at 08:14:47PM +, Peter Maydell wrote: > > > On Thu, 24 Feb 2022 at 19:50, Marc-André Lureau > > > wrote: > > > > On Thu, Feb 24, 2022 at 11:23

Fwd: Fwd: [PATCH 14/27] scripts/modinfo-collect: remove unused/dead code

2022-03-16 Thread Marc-André Lureau
-- Forwarded message - From: Hoffmann, Gerd Date: Wed, Mar 16, 2022 at 6:54 PM Subject: Re: Fwd: [PATCH 14/27] scripts/modinfo-collect: remove unused/dead code To: Marc-André Lureau On Wed, Mar 16, 2022 at 06:33:03PM +0400, Marc-André Lureau wrote: > Hi Gerd, can you ack? > > (g

[PATCH for-7.1] hw: Add compat machines for 7.1

2022-03-16 Thread Cornelia Huck
Add 7.1 machine types for arm/i440fx/m68k/q35/s390x/spapr. Signed-off-by: Cornelia Huck --- hw/arm/virt.c | 9 - hw/core/machine.c | 3 +++ hw/i386/pc.c | 3 +++ hw/i386/pc_piix.c | 14 +- hw/i386/pc_q35.c | 13 +++

Re: [PATCH] docs/tcg-plugins: document QEMU_PLUGIN behaviour

2022-03-16 Thread Alex Bennée
Christoph Muellner writes: > QEMU plugins can be loaded via command line arguments or via > the QEMU_PLUGIN environment variable. Currently, only the first method > is documented. Let's document QEMU_PLUGIN. > > Signed-off-by: Christoph Muellner > --- > docs/devel/tcg-plugins.rst | 4 >

[ppc/pnv9] clarification on QEMU's dtb

2022-03-16 Thread Amol
Hello, Below is a part of the dtb file as generated by qemu's powernv9 emulation: / { compatible = "qemu,powernv9\0ibm,powernv"; model = "IBM PowerNV (emulated by qemu)"; pciex@600c3c000 { compatible = "ibm,power9-pciex\0ibm,ioda3-phb";

Re: [PATCH v2] target/riscv: write back unmodified value for csrrc/csrrs with rs1 is not x0 but holding zero

2022-03-16 Thread Weiwei Li
在 2022/3/16 下午9:07, Bin Meng 写道: On Fri, Mar 11, 2022 at 5:46 PM Weiwei Li wrote: For csrrs and csrrc, if rs1 specifies a register other than x0, holding a zero value, the instruction will still attempt to write the unmodified value back to the csr and will cause side effects v2: * change to

Re: [PULL 21/50] block/block-backend.c: assertions for block-backend

2022-03-16 Thread Philippe Mathieu-Daudé
On 16/3/22 15:46, Emanuele Giuseppe Esposito wrote: Am 16/03/2022 um 13:53 schrieb Philippe Mathieu-Daudé: On 16/3/22 13:44, Philippe Mathieu-Daudé wrote: Hi, On 4/3/22 17:46, Kevin Wolf wrote: From: Emanuele Giuseppe Esposito All the global state (GS) API functions will check that qemu_in_

Re: [ppc/pnv9] clarification on QEMU's dtb

2022-03-16 Thread Amol
Apologies for the formatting. After a few tests with qemu I found that the dtb written by qemu doesn't contain the nodes in question. When the VM is run, the dtb is updated by the runtime firmware, skiboot, which adds those nodes. But the safe dtb at [2] earlier also must have had skiboot modifyin

Re: [PATCH v2 3/6] libvduse: Add VDUSE (vDPA Device in Userspace) library

2022-03-16 Thread Stefan Hajnoczi
On Wed, Mar 16, 2022 at 09:49:19PM +0800, Yongji Xie wrote: > On Wed, Mar 16, 2022 at 9:28 PM Stefan Hajnoczi wrote: > > > > On Tue, Mar 15, 2022 at 07:38:12PM +0800, Yongji Xie wrote: > > > On Tue, Mar 15, 2022 at 5:48 PM Stefan Hajnoczi > > > wrote: > > > > > > > > On Tue, Feb 15, 2022 at 06:5

Re: [PULL 15/22] x86: Grant AMX permission for guest

2022-03-16 Thread Peter Krempa
On Tue, Mar 08, 2022 at 12:34:38 +0100, Paolo Bonzini wrote: > From: Yang Zhong > > Kernel allocates 4K xstate buffer by default. For XSAVE features > which require large state component (e.g. AMX), Linux kernel > dynamically expands the xstate buffer only after the process has > acquired the nec

Re: [PULL 21/50] block/block-backend.c: assertions for block-backend

2022-03-16 Thread Kevin Wolf
Am 16.03.2022 um 16:25 hat Philippe Mathieu-Daudé geschrieben: > On 16/3/22 15:46, Emanuele Giuseppe Esposito wrote: > > Am 16/03/2022 um 13:53 schrieb Philippe Mathieu-Daudé: > > > On 16/3/22 13:44, Philippe Mathieu-Daudé wrote: > > > > Hi, > > > > > > > > On 4/3/22 17:46, Kevin Wolf wrote: > > >

Re: [PULL 15/22] x86: Grant AMX permission for guest

2022-03-16 Thread Daniel P . Berrangé
On Wed, Mar 16, 2022 at 04:57:39PM +0100, Peter Krempa wrote: > On Tue, Mar 08, 2022 at 12:34:38 +0100, Paolo Bonzini wrote: > > From: Yang Zhong > > > > Kernel allocates 4K xstate buffer by default. For XSAVE features > > which require large state component (e.g. AMX), Linux kernel > > dynamical

[RFC PATCH] docs: remove qemu_logo.pdf

2022-03-16 Thread Alex Bennée
As far as I can tell nothing in the source tree uses this file. The original comment mentions texi2pdf and I think that was all culled when we switched to our rst documentation pipeline. Reverts: c051a4c202 ("docs: add qemu logo to pdf") Cc: Marc-André Lureau Signed-off-by: Alex Bennée --- docs

Re: [RFC uncompiled PATCH] cocoa: run qemu_init in the main thread

2022-03-16 Thread Philippe Mathieu-Daudé
On 7/3/22 16:10, Paolo Bonzini wrote: Simplify the initialization dance by running qemu_init() in the main thread before the Cocoa event loop starts. The cocoa_display_init() code that is post-applicationDidFinishLaunching: moves to the application delegate itself, and the secondary thread only

[RFC PATCH-for-7.0 v2] cocoa: run qemu_init in the main thread

2022-03-16 Thread Philippe Mathieu-Daudé
From: Paolo Bonzini Simplify the initialization dance by running qemu_init() in the main thread before the Cocoa event loop starts. The cocoa_display_init() code that is post-applicationDidFinishLaunching: moves to the application delegate itself, and the secondary thread only runs the rest of q

Re: [PATCH experiment 00/16] C++20 coroutine backend

2022-03-16 Thread Kevin Wolf
Am 16.03.2022 um 13:40 hat Stefan Hajnoczi geschrieben: > On Wed, Mar 16, 2022 at 12:08:33AM +0100, Paolo Bonzini wrote: > > On 3/15/22 16:55, Daniel P. Berrangé wrote: > > > Expecting maintainers to enforce a subset during code review feels > > > like it would be a tedious burden, that will inevit

Re: [RFC PATCH-for-7.0 v2] cocoa: run qemu_init in the main thread

2022-03-16 Thread Akihiko Odaki
On 2022/03/17 1:03, Philippe Mathieu-Daudé wrote: From: Paolo Bonzini Simplify the initialization dance by running qemu_init() in the main thread before the Cocoa event loop starts. The cocoa_display_init() code that is post-applicationDidFinishLaunching: moves to the application delegate itse

Re: [PATCH v20 2/7] net/vmnet: add vmnet backends to qapi/net

2022-03-16 Thread Vladislav Yaroshchuk
On Wed, Mar 16, 2022 at 4:58 PM Markus Armbruster wrote: > Vladislav Yaroshchuk writes: > > > Create separate netdevs for each vmnet operating mode: > > - vmnet-host > > - vmnet-shared > > - vmnet-bridged > > > > Signed-off-by: Vladislav Yaroshchuk > > Any QAPI schema changes since v15? I'm as

Re: XIVE VFIO kernel resample failure in INTx mode under heavy load

2022-03-16 Thread Cédric Le Goater
Hello, I've been struggling for some time with what is looking like a potential bug in QEMU/KVM on the POWER9 platform. It appears that in XIVE mode, when the in-kernel IRQ chip is enabled, an external device that rapidly asserts IRQs via the legacy INTx level mechanism will only receive one i

Re: [RFC PATCH] docs: remove qemu_logo.pdf

2022-03-16 Thread Marc-André Lureau
Hi On Wed, Mar 16, 2022 at 8:10 PM Alex Bennée wrote: > > As far as I can tell nothing in the source tree uses this file. The > original comment mentions texi2pdf and I think that was all culled > when we switched to our rst documentation pipeline. > Indeed, no longer needed as we don't generate

Re: [PATCH 00/27] Misc fixes and cleanups for 7.0?

2022-03-16 Thread Stefan Hajnoczi
On Wed, Mar 16, 2022 at 05:13:49PM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Mar 16, 2022 at 5:09 PM Daniel P. Berrangé > wrote: > > > > On Wed, Mar 16, 2022 at 01:51:56PM +0400, marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau > > > > > > Hi, > > > > > > Various clean-up

Re: [PATCH experiment 00/16] C++20 coroutine backend

2022-03-16 Thread Stefan Hajnoczi
On Wed, Mar 16, 2022 at 01:06:02PM +, Daniel P. Berrangé wrote: > On Wed, Mar 16, 2022 at 12:32:48PM +, Stefan Hajnoczi wrote: > > On Tue, Mar 15, 2022 at 06:29:50PM +0100, Paolo Bonzini wrote: > > > On 3/15/22 15:24, Peter Maydell wrote: > > > > On Tue, 15 Mar 2022 at 14:09, Stefan Hajnocz

[PATCH v3 0/6] hw/arm: zynqmp: Add CRF and APU control to support PSCI

2022-03-16 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" This adds the necessary modeling to support some of our firmware tests at EL3 implementing PSCI (TBM). These are the test-cases that were previously relying on QEMU's builtin PSCI emulation. Cheers, Edgar ChangeLog: v2 -> v3: * Make RVBAR_ELx register reflect updated

[PATCH v3 1/6] hw/arm/xlnx-zynqmp: Add an unimplemented SERDES area

2022-03-16 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add an unimplemented SERDES (Serializer/Deserializer) area. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Francisco Iglesias Signed-off-by: Edgar E. Iglesias --- include/hw/arm/xlnx-zynqmp.h | 2 +- hw/arm/xlnx-zynqmp.c | 5 + 2 files changed, 6 inser

[PATCH v3 5/6] hw/misc: Add a model of the Xilinx ZynqMP APU Control

2022-03-16 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add a model of the Xilinx ZynqMP APU Control. Reviewed-by: Luc Michel Signed-off-by: Edgar E. Iglesias --- include/hw/misc/xlnx-zynqmp-apu-ctrl.h | 93 + hw/misc/xlnx-zynqmp-apu-ctrl.c | 253 + hw/misc/meson.build

[PATCH v3 2/6] target/arm: Make rvbar settable after realize

2022-03-16 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Make the rvbar property settable after realize. This is done in preparation to model the ZynqMP's runtime configurable rvbar. Signed-off-by: Edgar E. Iglesias --- target/arm/cpu.h| 3 ++- target/arm/cpu.c| 12 +++- target/arm/helper.c | 10 +++---

[PATCH v3 3/6] hw/misc: Add a model of the Xilinx ZynqMP CRF

2022-03-16 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add a model of the Xilinx ZynqMP CRF. At the moment this is mostly a stub model. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Signed-off-by: Edgar E. Iglesias --- include/hw/misc/xlnx-zynqmp-crf.h | 211 hw/misc/xlnx-zynqmp

[PATCH v3 4/6] hw/arm/xlnx-zynqmp: Connect the ZynqMP CRF

2022-03-16 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Connect the ZynqMP CRF - Clock Reset FPD device. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Francisco Iglesias Reviewed-by: Luc Michel Signed-off-by: Edgar E. Iglesias --- include/hw/arm/xlnx-zynqmp.h | 2 ++ hw/arm/xlnx-zynqmp.c | 16 +++

Re: [PATCH v7 00/46] CXl 2.0 emulation Support

2022-03-16 Thread Jonathan Cameron via
On Thu, 10 Mar 2022 16:02:22 +0800 Peter Xu wrote: > On Wed, Mar 09, 2022 at 11:28:27AM +, Jonathan Cameron wrote: > > Hi Peter, > > Hi, Jonathan, > > > > > > > > > https://lore.kernel.org/qemu-devel/20220306174137.5707-35-jonathan.came...@huawei.com/ > > > > > > Having mr->ops set b

[PATCH v3 6/6] hw/arm/xlnx-zynqmp: Connect the ZynqMP APU Control

2022-03-16 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Connect the ZynqMP APU Control device. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Francisco Iglesias Reviewed-by: Luc Michel Signed-off-by: Edgar E. Iglesias --- include/hw/arm/xlnx-zynqmp.h | 4 +++- hw/arm/xlnx-zynqmp.c | 25 +++

Re: [RFC PATCH-for-7.0 v2] cocoa: run qemu_init in the main thread

2022-03-16 Thread Akihiko Odaki
On 2022/03/17 1:03, Philippe Mathieu-Daudé wrote: From: Paolo Bonzini Simplify the initialization dance by running qemu_init() in the main thread before the Cocoa event loop starts. The cocoa_display_init() code that is post-applicationDidFinishLaunching: moves to the application delegate itse

Re: [PATCH 2/3] hw/display: Allow vga_common_init() to return errors

2022-03-16 Thread Thomas Huth
On 16/03/2022 15.16, Markus Armbruster wrote: Thomas Huth writes: On 16/03/2022 14.32, Philippe Mathieu-Daudé wrote: On 16/3/22 14:24, Thomas Huth wrote: The vga_common_init() function currently cannot report errors to its caller. But in the following patch, we'd need this possibility, so le

Re: [PATCH v7 00/46] CXl 2.0 emulation Support

2022-03-16 Thread Mark Cave-Ayland
On 16/03/2022 16:50, Jonathan Cameron via wrote: On Thu, 10 Mar 2022 16:02:22 +0800 Peter Xu wrote: On Wed, Mar 09, 2022 at 11:28:27AM +, Jonathan Cameron wrote: Hi Peter, Hi, Jonathan, https://lore.kernel.org/qemu-devel/20220306174137.5707-35-jonathan.came...@huawei.com/ Havin

Re: [PULL 15/22] x86: Grant AMX permission for guest

2022-03-16 Thread Paolo Bonzini
On 3/16/22 17:05, Daniel P. Berrangé wrote: On Wed, Mar 16, 2022 at 04:57:39PM +0100, Peter Krempa wrote: On Tue, Mar 08, 2022 at 12:34:38 +0100, Paolo Bonzini wrote: From: Yang Zhong Kernel allocates 4K xstate buffer by default. For XSAVE features which require large state component (e.g. AM

Re: [RFC PATCH-for-7.0 v2] cocoa: run qemu_init in the main thread

2022-03-16 Thread Paolo Bonzini
On 3/16/22 17:22, Akihiko Odaki wrote: I was thinking that it may be better to let softmmu/main.c do the details if it involves the internals of qemu_main() like qemu_main_loop(). More concretely, softmmu/main.c would provide a function to register a function pointer to take over the main thre

Re: [RFC PATCH] docs/devel: start documenting writing VirtIO devices

2022-03-16 Thread Alex Bennée
Cornelia Huck writes: > On Wed, Mar 09 2022, Alex Bennée wrote: > >> While writing my own VirtIO devices I've gotten confused with how >> things are structured and what sort of shared infrastructure there is. >> If we can document how everything is supposed to work we can then >> maybe start c

Re: [PULL 15/22] x86: Grant AMX permission for guest

2022-03-16 Thread David Edmondson
On Wednesday, 2022-03-16 at 16:05:01 GMT, Daniel P. Berrangé wrote: > On Wed, Mar 16, 2022 at 04:57:39PM +0100, Peter Krempa wrote: >> On Tue, Mar 08, 2022 at 12:34:38 +0100, Paolo Bonzini wrote: >> > From: Yang Zhong >> > >> > Kernel allocates 4K xstate buffer by default. For XSAVE features >>

Re: [PULL 15/22] x86: Grant AMX permission for guest

2022-03-16 Thread Daniel P . Berrangé
On Wed, Mar 16, 2022 at 05:48:04PM +, David Edmondson wrote: > On Wednesday, 2022-03-16 at 16:05:01 GMT, Daniel P. Berrangé wrote: > > > On Wed, Mar 16, 2022 at 04:57:39PM +0100, Peter Krempa wrote: > >> On Tue, Mar 08, 2022 at 12:34:38 +0100, Paolo Bonzini wrote: > >> > From: Yang Zhong > >>

Re: [PATCH v7 00/46] CXl 2.0 emulation Support

2022-03-16 Thread Jonathan Cameron via
On Wed, 16 Mar 2022 17:16:55 + Mark Cave-Ayland wrote: > On 16/03/2022 16:50, Jonathan Cameron via wrote: > > > On Thu, 10 Mar 2022 16:02:22 +0800 > > Peter Xu wrote: > > > >> On Wed, Mar 09, 2022 at 11:28:27AM +, Jonathan Cameron wrote: > >>> Hi Peter, > >> > >> Hi, Jonathan, >

[PATCH v6] target/riscv: Add isa extenstion strings to the device tree

2022-03-16 Thread Atish Patra
The Linux kernel parses the ISA extensions from "riscv,isa" DT property. It used to parse only the single letter base extensions until now. A generic ISA extension parsing framework was proposed[1] recently that can parse multi-letter ISA extensions as well. Generate the extended ISA string by app

<    1   2   3   >