Re: [PATCH] target/riscv: write back unmodified value for csrrc/csrrs with rs1 is not x0 but holding zero

在 2022/3/11 下午3:54, Alistair Francis 写道: On Fri, Mar 11, 2022 at 2:58 PM Weiwei Li wrote: 在 2022/3/11 上午10:58, Alistair Francis 写道: On Wed, Mar 2, 2022 at 11:50 PM Weiwei Li wrote: For csrrs and csrrc, if rs1 specifies a register other than x0, holding a zero value, the inst

Re: [PATCH v5 03/13] mm/shmem: Support memfile_notifier

On Fri, Mar 11, 2022 at 10:08:22AM +1100, Dave Chinner wrote: > On Thu, Mar 10, 2022 at 10:09:01PM +0800, Chao Peng wrote: > > From: "Kirill A. Shutemov" > > > > It maintains a memfile_notifier list in shmem_inode_info structure and > > implements memfile_pfn_ops callbacks defined by memfile_noti

Re: MAINTAINERS: macOS host support (was: MAINTAINERS: take edk2)

On Donnerstag, 10. März 2022 12:40:06 CET Philippe Mathieu-Daudé wrote: > +Stefan for overall project resources. > > On 10/3/22 12:07, Daniel P. Berrangé wrote: > > On Thu, Mar 10, 2022 at 12:00:35PM +0100, Christian Schoenebeck wrote: > >> On Mittwoch, 9. März 2022 12:44:16 CET Daniel P. Berrangé

Re: MAINTAINERS: macOS host support (was: MAINTAINERS: take edk2)

On Fri, Mar 11, 2022 at 10:13:24AM +0100, Christian Schoenebeck wrote: > On Donnerstag, 10. März 2022 12:40:06 CET Philippe Mathieu-Daudé wrote: > > +Stefan for overall project resources. > > > > On 10/3/22 12:07, Daniel P. Berrangé wrote: > > > On Thu, Mar 10, 2022 at 12:00:35PM +0100, Christian

Re: [PATCH experiment 00/35] stackless coroutine backend

On Thu, Mar 10, 2022 at 09:14:07PM +0100, Paolo Bonzini wrote: > On 3/10/22 18:42, Stefan Hajnoczi wrote: > > There are a lot of details to decide on in the translator tool and > > runtime to optimize the code. I think the way the stack frames are > > organized in this patch series is probably for

Re: [PATCH] block-qdict: Fix -Werror=maybe-uninitialized build failure

Murilo Opsfelder Araujo writes: > Building QEMU on Fedora 37 (Rawhide Prerelease) ppc64le failed with the > following error: > > $ ../configure --prefix=/usr/local/qemu-disabletcg > --target-list=ppc-softmmu,ppc64-softmmu --disable-tcg --disable-linux-user > ... > $ make -j$(nproc) >

Re: [PATCH V7 10/29] machine: memfd-alloc option

On Thu, 10 Mar 2022 13:18:35 -0500 Steven Sistare wrote: > On 3/10/2022 12:28 PM, Steven Sistare wrote: > > On 3/10/2022 11:00 AM, Igor Mammedov wrote: > >> On Thu, 10 Mar 2022 10:36:08 -0500 > >> Steven Sistare wrote: > >> > >>> On 3/8/2022 2:20 AM, Igor Mammedov wrote: > On Tue, 8 M

[PATCH v2] target/riscv: write back unmodified value for csrrc/csrrs with rs1 is not x0 but holding zero

For csrrs and csrrc, if rs1 specifies a register other than x0, holding a zero value, the instruction will still attempt to write the unmodified value back to the csr and will cause side effects v2: * change to explictly pass "bool write_op" argument in riscv_csrrw*, do write permission check an

Re: [PATCH V7 10/29] machine: memfd-alloc option

On 22.12.21 20:05, Steve Sistare wrote: > Allocate anonymous memory using memfd_create if the memfd-alloc machine > option is set. Hi, late to the party (thanks Igor for CCing) ... in which case it's no longer anonymous memory (because it's now MAP_SHARED). So you're converting all private memor

Re: [PATCH v3] i386/cpu: Remove the deprecated cpu model 'Icelake-Client'

On Tue, 08 Feb 2022 16:38:27 +0800 Robert Hoo wrote: > Hi, > > Can we remove the deprecated 'Icelake-Client' CPU model now? if so, I > can rebase patch to latest and resend. Please rebase and resend. PS: Also looking at deprecation commit 3e6a015cbd0f, it doesn't have any reason behind depreca

Re: [PATCH v2 01/11] tests/acpi: allow virt memory hotplug changes

On Fri, 11 Mar 2022 06:37:49 +0100 Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > Reviewed-by: Alex Bennée Reviewed-by: Igor Mammedov > --- > tests/qtest/bios-tables-test-allowed-diff.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/qtest/bios-tables-test-allowed-dif

Re: [PATCH v2 07/11] tests/acpi: update expected data files

On Fri, 11 Mar 2022 06:37:55 +0100 Gerd Hoffmann wrote: > The switch to edk2 RELEASE builds changes the memory layout a bit, > resulting in a acpi table change. > > DefinitionBlock ("", "SSDT", 1, "BOCHS ", "NVDIMM", 0x0001) > { > Scope (\_SB) > { > Device (NVDR) >

Re: [PATCH v2 08/11] tests/acpi: disallow virt memory hotplug changes

On Fri, 11 Mar 2022 06:37:56 +0100 Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov > --- > tests/qtest/bios-tables-test-allowed-diff.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h > b/tests/qtest/bios-tab

Re: [PATCH v2 03/18] tests: support QTEST_TRACE env variable

Daniel P. Berrangé wrote: > When debugging failing qtests it is useful to be able to turn on trace > output to stderr. The QTEST_TRACE env variable contents get injected > as a '-trace ' command line arg > > Reviewed-by: Peter Xu > Reviewed-by: Thomas Huth > Signed-off-by: Daniel P. Berrangé R

Re: [PATCH v2 04/18] tests: print newline after QMP response in qtest logs

Daniel P. Berrangé wrote: > The QMP commands have a trailing newline, but the response does not. > This makes the qtest logs hard to follow as the next QMP command > appears in the same line as the previous QMP response. > > Reviewed-by: Thomas Huth > Signed-off-by: Daniel P. Berrangé Reviewed-

Re: [PATCH v2 06/18 for-7.0] migration: fix use of TLS PSK credentials with a UNIX socket

Daniel P. Berrangé wrote: > The migration TLS code has a check mandating that a hostname be > available when starting a TLS session. This is expected when using > x509 credentials, but is bogus for PSK and anonymous credentials > as neither involve hostname validation. > > The TLS crdentials objec

Re: [PATCH V7 10/29] machine: memfd-alloc option

On Mon, Mar 07, 2022 at 09:41:44AM -0500, Steven Sistare wrote: > On 3/4/2022 5:41 AM, Igor Mammedov wrote: > > On Thu, 3 Mar 2022 12:21:15 -0500 > > "Michael S. Tsirkin" wrote: > > > >> On Wed, Dec 22, 2021 at 11:05:15AM -0800, Steve Sistare wrote: > >>> Allocate anonymous memory using memfd_cre

Re: [PATCH v2 2/4] Introduce event-loop-base abstract class

On Thu, 2022-03-10 at 10:25 +, Stefan Hajnoczi wrote: > On Thu, Mar 03, 2022 at 03:58:20PM +0100, Nicolas Saenz Julienne wrote: > > @@ -2935,13 +2947,6 @@ qemu_syms = custom_target('qemu.syms', output: > > 'qemu.syms', > > capture: true, > >

Re: [PATCH V7 10/29] machine: memfd-alloc option

On 03.03.22 18:21, Michael S. Tsirkin wrote: > On Wed, Dec 22, 2021 at 11:05:15AM -0800, Steve Sistare wrote: >> Allocate anonymous memory using memfd_create if the memfd-alloc machine >> option is set. >> >> Signed-off-by: Steve Sistare >> --- >> hw/core/machine.c | 19 +++ >>

Re: [PATCH 6/6] tests/9pfs: guard recent 'Twalk' behaviour fix

On Mittwoch, 9. März 2022 19:21:18 CET Christian Schoenebeck wrote: > Previous 9p patch fixed 'Twalk' request handling, which was previously not > behaving as specified by the 9p2000 protocol spec. This patch adds a new > test case which guards the new 'Twalk' behaviour in question. > > More speci

Re: [PATCH v2 4/4] util/event-loop-base: Introduce options to set the thread pool size

On Thu, 2022-03-10 at 10:45 +, Stefan Hajnoczi wrote: > On Thu, Mar 03, 2022 at 04:13:07PM +0100, Nicolas Saenz Julienne wrote: > > @@ -537,10 +546,19 @@ > > # 0 means that the engine will use its default > > # (default:0, since 6.1) > > # > > +# @thread-pool-

Re: [PATCH 1/6] tests/9pfs: walk to non-existent dir

On Wed, 9 Mar 2022 13:18:50 +0100 Christian Schoenebeck wrote: > Expect ENOENT Rlerror response when trying to walk to a > non-existent directory. > > Signed-off-by: Christian Schoenebeck > --- Reviewed-by: Greg Kurz > tests/qtest/virtio-9p-test.c | 30 ++ > 1 fi

Re: [PATCH 2/6] tests/9pfs: Twalk with nwname=0

On Thu, 10 Mar 2022 09:57:25 +0100 Christian Schoenebeck wrote: > On Mittwoch, 9. März 2022 14:24:24 CET Christian Schoenebeck wrote: > > Send Twalk request with nwname=0. In this case no QIDs should > > be returned by 9p server; this is equivalent to walking to dot. > > > > Signed-off-by: Chris

Re: [PATCH experiment 00/35] stackless coroutine backend

On 3/11/22 10:27, Stefan Hajnoczi wrote: Not quite voluntarily, but I noticed I had to add one 0 to make them run for a decent amount of time. So yeah, it's much faster than siglongjmp. That's a nice first indication that performance will be good. I guess that deep coroutine_fn stacks could be

Re: [PATCH experiment 00/35] stackless coroutine backend

On Fri, Mar 11, 2022 at 01:04:33PM +0100, Paolo Bonzini wrote: > On 3/11/22 10:27, Stefan Hajnoczi wrote: > > > Not quite voluntarily, but I noticed I had to add one 0 to make them run > > > for > > > a decent amount of time. So yeah, it's much faster than siglongjmp. > > That's a nice first indi

Re: [PATCH v2 07/11] tests/acpi: update expected data files

On Fri, Mar 11, 2022 at 11:09 AM Gerd Hoffmann wrote: > > The switch to edk2 RELEASE builds changes the memory layout a bit, > resulting in a acpi table change. I would actually also refer to the actual change (submodule update etc) that results in this change. Otherwise its hard to track/bosect

Re: [PATCH v5 13/15] hw/nvme: Add support for the Virtualization Management command

On Wed, Mar 09, 2022 at 01:41:27PM +0100, Łukasz Gieryk wrote: > On Tue, Mar 01, 2022 at 02:07:08PM +0100, Klaus Jensen wrote: > > On Feb 17 18:45, Lukasz Maniak wrote: > > > From: Łukasz Gieryk > > > > > > With the new command one can: > > > - assign flexible resources (queues, interrupts) to p

Re: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG.

Kshitij Suri writes: > Currently screendump only supports PPM format, which is un-compressed and not > standard. Added a "format" parameter to qemu monitor screendump capabilites > to support PNG image capture using libpng. The param was added in QAPI schema > of screendump present in ui.json alo

Re: [PATCH v5 0/5] user creatable pnv-phb4 devices

Hello, In 3/11/22 03:18, Daniel Henrique Barboza wrote: On 3/10/22 15:49, Thomas Huth wrote: On 11/01/2022 14.10, Daniel Henrique Barboza wrote: Hi, This version implements Cedric's review suggestions from v4. No drastic design changes were made. Changes from v4: - patches 1,3,5: unchanged

Re: [PATCH 1/2] ui/cocoa: add option to disable left-command forwarding to guest

Philippe Mathieu-Daudé writes: > On 18/2/22 19:55, Peter Maydell wrote: >> On Sun, 2 Jan 2022 at 17:42, Carwyn Ellis wrote: >>> >>> When switching between guest and host on a Mac using command-tab the >>> command key is sent to the guest which can trigger functionality in the >>> guest OS. Speci

Re: [PATCH v4 1/3] qmp: Support for querying stats

Mark Kanda writes: > Introduce QMP support for querying stats. Provide a framework for adding new > stats and support for the following commands: > > - query-stats > Returns a list of all stats per target type (only VM and vCPU to start), with > additional options for specifying stat names, vCPU

[PATCH] tests/avocado: starts PhoneServer upfront

Race conditions can happen with the current code, because the port that was available might not be anymore by the time the server is started. By setting the port to 0, PhoneServer it will use the OS default behavior to get a free port, then we save this information so we can later configure the gu

Re: [PATCH v4 1/3] qmp: Support for querying stats

On Fri, Mar 11, 2022 at 02:06:46PM +0100, Markus Armbruster wrote: > Mark Kanda writes: > > > Introduce QMP support for querying stats. Provide a framework for adding new > > stats and support for the following commands: > > > > - query-stats > > Returns a list of all stats per target type (only

Re: [PATCH] tests/avocado: starts PhoneServer upfront

On Fri, Mar 11, 2022 at 10:09:19AM -0300, Beraldo Leal wrote: > Race conditions can happen with the current code, because the port that > was available might not be anymore by the time the server is started. > > By setting the port to 0, PhoneServer it will use the OS default > behavior to get a f

Re: [PATCH v5 0/5] user creatable pnv-phb4 devices

On 3/11/22 09:45, Cédric Le Goater wrote: Hello, In 3/11/22 03:18, Daniel Henrique Barboza wrote: On 3/10/22 15:49, Thomas Huth wrote: On 11/01/2022 14.10, Daniel Henrique Barboza wrote: Hi, This version implements Cedric's review suggestions from v4. No drastic design changes were made

Re: [PATCH 2/6] tests/9pfs: Twalk with nwname=0

On Freitag, 11. März 2022 12:41:32 CET Greg Kurz wrote: > On Thu, 10 Mar 2022 09:57:25 +0100 > > Christian Schoenebeck wrote: > > On Mittwoch, 9. März 2022 14:24:24 CET Christian Schoenebeck wrote: > > > Send Twalk request with nwname=0. In this case no QIDs should > > > be returned by 9p server;

[RFC PATCH] mailmap/gitdm: more fixes for bad tags and authors

I was running some historical tags for the last 10 years and got the following warnings: git log --use-mailmap --numstat --since "June 2010" | ~/src/gitdm.git/gitdm -n -l 5 alar...@ddci.com is an author name, probably not what you want bad utf-8 ('utf-8' codec can't decode byte 0xe4 in posi

Re: [PATCH] tcg/arm: Don't emit UNPREDICTABLE LDRD with Rm == Rt or Rt+1

Richard Henderson writes: > The LDRD (register) instruction is UNPREDICTABLE if the Rm register > is the same as either Rt or Rt+1 (the two registers being loaded to). > We weren't making sure we avoided this, with the result that on some > host CPUs like the Cortex-A7 we would get a SIGILL bec

Re: [PATCH] tests/avocado: starts PhoneServer upfront

Beraldo Leal writes: > Race conditions can happen with the current code, because the port that > was available might not be anymore by the time the server is started. > > By setting the port to 0, PhoneServer it will use the OS default > behavior to get a free port, then we save this informatio

[PATCH] x86: q35: require split irqchip for large CPU count

if VM is started with: -enable-kvm -smp 256 without specifying 'split' irqchip, VM might eventually boot but no more than 255 CPUs will be operational and following error messages in guest could be observed: ... smpboot: native_cpu_up: bad cpu 256 ... It's a regression introduced by [

Re: [RFC PATCH 1/2] spapr: Report correct GTSE support via ov5

Daniel Henrique Barboza writes: > On 3/8/22 22:23, Fabiano Rosas wrote: >> QEMU reports MMU support to the guest via the ibm,architecture-vec-5 >> property of the /chosen node. Byte number 26 specifies Radix Table >> Expansions, currently only GTSE (Guest Translation Shootdown >> Enable). This fe

Re: [PATCH] x86: q35: require split irqchip for large CPU count

On Fri, 2022-03-11 at 09:39 -0500, Igor Mammedov wrote: > if VM is started with: > >-enable-kvm -smp 256 > > without specifying 'split' irqchip, VM might eventually boot > but no more than 255 CPUs will be operational and following > error messages in guest could be observed: >... >sm

Re: [PATCH] block: Fix BB.root changing across bdrv_next()

On 01.03.22 18:39, Hanna Reitz wrote: bdrv_next() has no guarantee that its caller has stopped all block graph operations; for example, bdrv_flush_all() does not. The latter can actually provoke such operations, because its bdrv_flush() call, which runs a coroutine (bdrv_co_flush()), may run thi

Re: [PATCH] tests/avocado: starts PhoneServer upfront

On Fri, Mar 11, 2022 at 09:28:24AM -0500, Cleber Rosa wrote: > > Beraldo Leal writes: > > > Race conditions can happen with the current code, because the port that > > was available might not be anymore by the time the server is started. > > > > By setting the port to 0, PhoneServer it will use

Re: [PATCH v2 01/11] tests/acpi: allow virt memory hotplug changes

On Fri, Mar 11, 2022 at 06:37:49AM +0100, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > Reviewed-by: Alex Bennée Reviewed-by: Michael S. Tsirkin > --- > tests/qtest/bios-tables-test-allowed-diff.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/qtest/bios-tables-test-a

Re: [RFC PATCH] docs/devel: try and impose some organisation

On Wed, Mar 09, 2022 at 01:53:55PM +, Alex Bennée wrote: > We have a growing set of developer docs but the index is currently in > order of when stuff was added. Try and make things a bit easier to > find my adding sub indexes and organising into themes. > > Signed-off-by: Alex Bennée > --- >

Re: [PATCH v2 07/11] tests/acpi: update expected data files

On Fri, Mar 11, 2022 at 06:37:55AM +0100, Gerd Hoffmann wrote: > The switch to edk2 RELEASE builds changes the memory layout a bit, > resulting in a acpi table change. > > DefinitionBlock ("", "SSDT", 1, "BOCHS ", "NVDIMM", 0x0001) > { > Scope (\_SB) > { > Device (NVDR) >

Re: [PATCH v2 1/7] target/s390x: vxeh2: vector convert short/32b

On 07.03.22 03:03, David Miller wrote: > Signed-off-by: David Miller > --- > target/s390x/helper.h | 4 +++ > target/s390x/tcg/translate_vx.c.inc | 44 ++--- > target/s390x/tcg/vec_fpu_helper.c | 31 > 3 files changed, 75 insertions(+)

Re: [PATCH 3/6] tests/9pfs: compare QIDs in fs_walk_none() test

On Thu, 10 Mar 2022 10:04:50 +0100 Christian Schoenebeck wrote: > On Mittwoch, 9. März 2022 15:49:04 CET Christian Schoenebeck wrote: > > Extend previously added fs_walk_none() test by comparing the QID > > of the root fid with the QID of the cloned fid. They should be > > equal. > > Ha, I unde

Re: [PATCH v2 04/11] edk2: .git can be a file

On Fri, Mar 11, 2022 at 06:37:52AM +0100, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > roms/Makefile.edk2 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualiz

Re: [PATCH 4/6] 9pfs: refactor 'name_idx' -> 'nvalid' in v9fs_walk()

On Thu, 10 Mar 2022 10:07:04 +0100 Christian Schoenebeck wrote: > On Mittwoch, 9. März 2022 18:12:17 CET Christian Schoenebeck wrote: > > The local variable 'name_idx' is used in two loops in function v9fs_walk(). > > Let the first loop use its own variable 'nvalid' instead, which we will use > >

Re: [PATCH V7 19/29] vfio-pci: cpr part 1 (fd and dma)

On 3/10/2022 5:30 PM, Alex Williamson wrote: > On Thu, 10 Mar 2022 14:55:50 -0500 > Steven Sistare wrote: > >> On 3/10/2022 1:35 PM, Alex Williamson wrote: >>> On Thu, 10 Mar 2022 10:00:29 -0500 >>> Steven Sistare wrote: >>> On 3/7/2022 5:16 PM, Alex Williamson wrote: > On Wed, 22

Re: [PATCH] tests/avocado: starts PhoneServer upfront

Beraldo Leal writes: > On Fri, Mar 11, 2022 at 09:28:24AM -0500, Cleber Rosa wrote: >> >> Beraldo Leal writes: >> >> > Race conditions can happen with the current code, because the port that >> > was available might not be anymore by the time the server is started. >> > >> > By setting the p

Re: [PATCH 5/6] 9pfs: fix 'Twalk' to only send error if no component walked

On Thu, 10 Mar 2022 10:13:33 +0100 Christian Schoenebeck wrote: > On Mittwoch, 9. März 2022 18:57:39 CET Christian Schoenebeck wrote: > > Current implementation of 'Twalk' request handling always sends an 'Rerror' > > response if any error occured. The 9p2000 protocol spec sais though: > > > >

Re: [PATCH 6/6] tests/9pfs: guard recent 'Twalk' behaviour fix

On Wed, 9 Mar 2022 19:21:18 +0100 Christian Schoenebeck wrote: > Previous 9p patch fixed 'Twalk' request handling, which was previously not > behaving as specified by the 9p2000 protocol spec. This patch adds a new test > case which guards the new 'Twalk' behaviour in question. > > More specific

Re: [PATCH 3/6] tests/9pfs: compare QIDs in fs_walk_none() test

On Freitag, 11. März 2022 17:11:24 CET Greg Kurz wrote: > On Thu, 10 Mar 2022 10:04:50 +0100 > > Christian Schoenebeck wrote: > > On Mittwoch, 9. März 2022 15:49:04 CET Christian Schoenebeck wrote: > > > Extend previously added fs_walk_none() test by comparing the QID > > > of the root fid with t

Re: [PATCH 5/6] 9pfs: fix 'Twalk' to only send error if no component walked

On Freitag, 11. März 2022 17:35:41 CET Greg Kurz wrote: > On Thu, 10 Mar 2022 10:13:33 +0100 > > Christian Schoenebeck wrote: > > On Mittwoch, 9. März 2022 18:57:39 CET Christian Schoenebeck wrote: > > > Current implementation of 'Twalk' request handling always sends an > > > 'Rerror' > > > > >

Re: [PATCH V7 12/29] vl: helper to request re-exec

On 3/9/2022 9:16 AM, Marc-André Lureau wrote: > On Wed, Dec 22, 2021 at 11:52 PM Steve Sistare > wrote: > > Add a qemu_system_exec_request() hook that causes the main loop to exit > and > re-exec qemu using the specified arguments. > > Signed-off-by

Re: [PATCH] tests/avocado: starts PhoneServer upfront

On Fri, Mar 11, 2022 at 11:18:38AM -0500, Cleber Rosa wrote: > > Beraldo Leal writes: > > > On Fri, Mar 11, 2022 at 09:28:24AM -0500, Cleber Rosa wrote: > >> > >> Beraldo Leal writes: > >> > >> > Race conditions can happen with the current code, because the port that > >> > was available migh

Re: [PATCH V7 11/29] qapi: list utility functions

On 3/9/2022 9:11 AM, Marc-André Lureau wrote: > Hi > > On Wed, Dec 22, 2021 at 11:42 PM Steve Sistare > wrote: > > Generalize strList_from_comma_list() to take any delimiter character, > rename > as strList_from_string(), and move it to qapi/util.c.  Al

Re: [PATCH 3/6] tests/9pfs: compare QIDs in fs_walk_none() test

On Fri, 11 Mar 2022 17:39:56 +0100 Christian Schoenebeck wrote: > On Freitag, 11. März 2022 17:11:24 CET Greg Kurz wrote: > > On Thu, 10 Mar 2022 10:04:50 +0100 > > > > Christian Schoenebeck wrote: > > > On Mittwoch, 9. März 2022 15:49:04 CET Christian Schoenebeck wrote: > > > > Extend previous

Re: [PATCH 5/6] 9pfs: fix 'Twalk' to only send error if no component walked

On Fri, 11 Mar 2022 17:44:54 +0100 Christian Schoenebeck wrote: > On Freitag, 11. März 2022 17:35:41 CET Greg Kurz wrote: > > On Thu, 10 Mar 2022 10:13:33 +0100 > > > > Christian Schoenebeck wrote: > > > On Mittwoch, 9. März 2022 18:57:39 CET Christian Schoenebeck wrote: > > > > Current impleme

[PATCH v2] tests/avocado: starts PhoneServer upfront

Race conditions can happen with the current code, because the port that was available might not be anymore by the time the server is started. By setting the port to 0, PhoneServer it will use the OS default behavior to get a free port, then we save this information so we can later configure the gu

Re: [PATCH 6/9] tests/avocado/virtiofs_submounts.py: shared_dir may not exist

On Fri, Feb 25, 2022 at 04:01:53PM -0500, Cleber Rosa wrote: > If the test is skipped because of their conditionals, the shared_dir > attribute may not exist. > > Check for its existence in the tearDown() method to avoid and > AttributeError. > > Signed-off-by: Cleber Rosa > --- > tests/avocado

Re: [PATCH 3/6] tests/9pfs: compare QIDs in fs_walk_none() test

On Freitag, 11. März 2022 18:02:36 CET Greg Kurz wrote: > On Fri, 11 Mar 2022 17:39:56 +0100 > > Christian Schoenebeck wrote: > > On Freitag, 11. März 2022 17:11:24 CET Greg Kurz wrote: > > > On Thu, 10 Mar 2022 10:04:50 +0100 > > > > > > Christian Schoenebeck wrote: > > > > On Mittwoch, 9. Mär

Re: [PATCH 5/6] 9pfs: fix 'Twalk' to only send error if no component walked

On Freitag, 11. März 2022 18:08:38 CET Greg Kurz wrote: > On Fri, 11 Mar 2022 17:44:54 +0100 > > Christian Schoenebeck wrote: > > On Freitag, 11. März 2022 17:35:41 CET Greg Kurz wrote: > > > On Thu, 10 Mar 2022 10:13:33 +0100 > > > > > > Christian Schoenebeck wrote: > > > > On Mittwoch, 9. Mär

Re: [PATCH] tcg/arm: Don't emit UNPREDICTABLE LDRD with Rm == Rt or Rt+1

On 3/11/22 06:02, Alex Bennée wrote: A wider question. Is this something that can be handled the constraints done by the register allocator? I assume that avoid direct aliasing if needed? No. We do have "allocate a non-overlapping register"; we don't have "allocate an aligned register pair",

Re: 'make check-acceptance' failing on s390 tests?

On 18/02/2022 16.04, Peter Maydell wrote: Hi; is anybody else seeing 'make check-acceptance' fail on some of the s390 tests? (009/183) tests/avocado/boot_linux.py:BootLinuxS390X.test_s390_ccw_virtio_tcg: INTERRUPTED: Test interrupted by SIGTERM\nRunner error occurred: Timeout reached\nOriginal

XIVE VFIO kernel resample failure in INTx mode under heavy load

All, I've been struggling for some time with what is looking like a potential bug in QEMU/KVM on the POWER9 platform. It appears that in XIVE mode, when the in-kernel IRQ chip is enabled, an external device that rapidly asserts IRQs via the legacy INTx level mechanism will only receive one int

Re: [PATCH v2 1/9] dump: Use ERRP_GUARD()

On 3/10/22 03:08, Janosch Frank wrote: Let's move to the new way of handling errors before changing the dump code. This patch has mostly been generated by the coccinelle script scripts/coccinelle/errp-guard.cocci. Signed-off-by: Janosch Frank --- dump/dump.c | 144 ++---

[PATCH 0/3] Fix BRASL and BRCL with large negative offsets

Hi, I noticed that sometimes jumping backwards leads to crashes or hangs. The problem is a missing cast. Patches 1 and 2 fix the problem, patch 3 adds a test. Best regards, Ilya Ilya Leoshkevich (3): s390x/tcg: Fix BRASL with a large negative offset s390x/tcg: Fix BRCL with a large negative

[PATCH 2/3] s390x/tcg: Fix BRCL with a large negative offset

When RI2 is 0x8000, qemu enters an infinite loop instead of jumping backwards. Fix by adding a missing cast, like in in2_ri2(). Fixes: 7233f2ed1717 ("target-s390: Convert BRANCH ON CONDITION") Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/translate.c | 2 +- 1 file changed, 1 insertio

[PATCH 3/3] tests/tcg/s390x: Test BRASL and BRCL with large negative offsets

Add a small test in order to prevent regressions. Signed-off-by: Ilya Leoshkevich --- tests/tcg/s390x/Makefile.target| 1 + tests/tcg/s390x/branch-relative-long.c | 29 ++ 2 files changed, 30 insertions(+) create mode 100644 tests/tcg/s390x/branch-relative-long.

[PATCH 1/3] s390x/tcg: Fix BRASL with a large negative offset

When RI2 is 0x8000, qemu enters an infinite loop instead of jumping backwards. Fix by adding a missing cast, like in in2_ri2(). Fixes: 8ac33cdb8bfb ("Convert BRANCH AND SAVE") Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

Re: XIVE VFIO kernel resample failure in INTx mode under heavy load

Correction -- the desynchronization appears to be on the DisINTx line. Host: Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr+ Stepping- SERR+ FastB2B- DisINTx+ Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=slow >TAbort- SERR- TAbort- SERR- From: "Timothy Pea

Re: [PATCH 1/3] s390x/tcg: Fix BRASL with a large negative offset

On 11.03.22 19:49, Ilya Leoshkevich wrote: > When RI2 is 0x8000, qemu enters an infinite loop instead of jumping > backwards. Fix by adding a missing cast, like in in2_ri2(). > > Fixes: 8ac33cdb8bfb ("Convert BRANCH AND SAVE") > Signed-off-by: Ilya Leoshkevich > --- > target/s390x/tcg/transl

Re: [PATCH 2/3] s390x/tcg: Fix BRCL with a large negative offset

On 11.03.22 19:49, Ilya Leoshkevich wrote: > When RI2 is 0x8000, qemu enters an infinite loop instead of jumping > backwards. Fix by adding a missing cast, like in in2_ri2(). > > Fixes: 7233f2ed1717 ("target-s390: Convert BRANCH ON CONDITION") > Signed-off-by: Ilya Leoshkevich > --- > target

Re: [PATCH 3/3] tests/tcg/s390x: Test BRASL and BRCL with large negative offsets

On 11.03.22 19:49, Ilya Leoshkevich wrote: > Add a small test in order to prevent regressions. > > Signed-off-by: Ilya Leoshkevich > --- > tests/tcg/s390x/Makefile.target| 1 + > tests/tcg/s390x/branch-relative-long.c | 29 ++ > 2 files changed, 30 insertions(+)

Re: [PATCH 3/3] tests/tcg/s390x: Test BRASL and BRCL with large negative offsets

On Fri, 2022-03-11 at 19:57 +0100, David Hildenbrand wrote: > On 11.03.22 19:49, Ilya Leoshkevich wrote: > > Add a small test in order to prevent regressions. > > > > Signed-off-by: Ilya Leoshkevich > > --- > >  tests/tcg/s390x/Makefile.target    |  1 + > >  tests/tcg/s390x/branch-relative-lo

Re: [PATCH v2 2/9] dump: Remove the sh_info variable

On 3/10/22 03:08, Janosch Frank wrote: There's no need to have phdr_num and sh_info at the same time. We can make phdr_num 32 bit and set PN_XNUM when we write the header if phdr_num >= PN_XNUM. Signed-off-by: Janosch Frank --- dump/dump.c | 34 ++ in

Re: [PATCH v2 3/9] dump: Introduce shdr_num to decrease complexity

On 3/10/22 03:08, Janosch Frank wrote: Let's move from a boolean to a int variable which will later enable us to store the number of sections that are in the dump file. Signed-off-by: Janosch Frank --- dump/dump.c | 24 include/sysemu/dump.h | 2 +- 2 file

Re: [PATCH v2 4/9] dump: Remove the section if when calculating the memory offset

On 3/10/22 03:08, Janosch Frank wrote: When s->shdr_num is 0 we'll add 0 bytes of section headers which is equivalent to not adding section headers but with the multiplication we can remove a if/else. Signed-off-by: Janosch Frank --- dump/dump.c | 24 1 file changed,

Re: [PATCH v2 5/9] dump: Add more offset variables

On 3/10/22 03:08, Janosch Frank wrote: Offset calculations are easy enough to get wrong. Let's add a few variables to make moving around elf headers and data sections easier. Signed-off-by: Janosch Frank Reviewed-by: Marc-André Lureau --- dump/dump.c | 35 +++-

Re: [PATCH v2 6/9] dump: Introduce dump_is_64bit() helper function

On 3/10/22 03:08, Janosch Frank wrote: Checking d_class in dump_info leads to lengthy conditionals so let's shorten things a bit by introducing a helper function. Signed-off-by: Janosch Frank --- dump/dump.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) Reviewe

Re: [PATCH v2 7/9] dump: Consolidate phdr note writes

On 3/10/22 03:08, Janosch Frank wrote: There's no need to have two write functions. Let's rather have two functions that set the data for elf 32/64 and then write it in a common function. Signed-off-by: Janosch Frank --- dump/dump.c | 94 +++--

Re: [PATCH v2 8/9] dump: Cleanup dump_begin write functions

On 3/10/22 03:08, Janosch Frank wrote: There's no need to have a gigantic if in there let's move the elf 32/64 bit logic into the section, segment or note code. Signed-off-by: Janosch Frank --- dump/dump.c | 42 +++--- 1 file changed, 11 insertions(+), 31 d

Re: [PATCH v2 9/9] dump: Consolidate elf note function

On 3/10/22 03:08, Janosch Frank wrote: +static void write_elf_notes(DumpState *s, Error **errp) +{ +ERRP_GUARD(); + +if (dump_is_64bit(s)) { +write_elf64_notes(fd_write_vmcore, s, errp); +} else { +write_elf32_notes(fd_write_vmcore, s, errp); +} +if (*errp) { +

Re: [PATCH 1/5] dump: Allocate header

On 3/10/22 03:16, Janosch Frank wrote: Allocating the header lets us write it at a later time and hence also allows us to change section and segment table offsets until we finally write it. Signed-off-by: Janosch Frank --- dump/dump.c | 115 ++

Re: [PATCH 3/5] dump: Reorder struct DumpState

On 3/10/22 03:16, Janosch Frank wrote: Let's move ELF related members into one block and guest memory related ones into another to improve readability. Signed-off-by: Janosch Frank --- include/sysemu/dump.h | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) Reviewed-b

Re: [PATCH 2/5] dump: Split write of section headers and data and add a prepare step

On 3/10/22 03:16, Janosch Frank wrote: -static void write_elf_section(DumpState *s, int type, Error **errp) +static size_t write_elf_section_hdr_zero(DumpState *s, void *buff) { -Elf32_Shdr shdr32; -Elf64_Shdr shdr64; -int shdr_size; -void *shdr; -int ret; +Elf32_Shdr *s

Re: [PATCH 3/3] tests/tcg/s390x: Test BRASL and BRCL with large negative offsets

On 3/11/22 10:49, Ilya Leoshkevich wrote: +size_t length = 0x10006; +unsigned char *buf; +int i; + +buf = mmap(NULL, length, PROT_READ | PROT_WRITE | PROT_EXEC, + MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); +assert(buf != MAP_FAILED); I'm thinking exit success her

Re: [PATCH V7 11/29] qapi: list utility functions

Hi On Fri, Mar 11, 2022 at 8:46 PM Steven Sistare wrote: > On 3/9/2022 9:11 AM, Marc-André Lureau wrote: > > Hi > > > > On Wed, Dec 22, 2021 at 11:42 PM Steve Sistare < > steven.sist...@oracle.com > wrote: > > > > Generalize strList_from_comma_list() to take

[PATCH v2] block-qdict: Fix -Werror=maybe-uninitialized build failure

Building QEMU on Fedora 37 (Rawhide Prerelease) ppc64le failed with the following error: $ ../configure --prefix=/usr/local/qemu-disabletcg --target-list=ppc-softmmu,ppc64-softmmu --disable-tcg --disable-linux-user ... $ make -j$(nproc) ... FAILED: libqemuutil.a.p/qobject_bloc

Re: [PATCH] block-qdict: Fix -Werror=maybe-uninitialized build failure

Hi, Markus. On 3/11/22 06:33, Markus Armbruster wrote: Murilo Opsfelder Araujo writes: Building QEMU on Fedora 37 (Rawhide Prerelease) ppc64le failed with the following error: $ ../configure --prefix=/usr/local/qemu-disabletcg --target-list=ppc-softmmu,ppc64-softmmu --disable-tcg --dis