[PATCH v3 4/8] x86: Add XFD faulting bit for state components

2022-02-28 Thread Yang Zhong
From: Jing Liu Intel introduces XFD faulting mechanism for extended XSAVE features to dynamically enable the features in runtime. If CPUID (EAX=0Dh, ECX=n, n>1).ECX[2] is set as 1, it indicates support for XFD faulting of this state component. Signed-off-by: Jing Liu Signed-off-by: Yang Zhong

[PATCH v3 3/8] x86: Grant AMX permission for guest

2022-02-28 Thread Yang Zhong
Kernel allocates 4K xstate buffer by default. For XSAVE features which require large state component (e.g. AMX), Linux kernel dynamically expands the xstate buffer only after the process has acquired the necessary permissions. Those are called dynamically- enabled XSAVE features (or dynamic xfeatur

[PATCH v3 0/8] AMX support in Qemu

2022-02-28 Thread Yang Zhong
Intel introduces Advanced Matrix Extensions (AMX) [1] feature that consists of configurable two-dimensional "TILE" registers and new accelerator instructions that operate on them. TMUL (Tile matrix MULtiply) is the first accelerator instruction set to use the new registers. Since AMX KVM patches h

[PATCH v3 1/8] x86: Fix the 64-byte boundary enumeration for extended state

2022-02-28 Thread Yang Zhong
From: Jing Liu The extended state subleaves (EAX=0Dh, ECX=n, n>1).ECX[1] indicate whether the extended state component locates on the next 64-byte boundary following the preceding state component when the compacted format of an XSAVE area is used. Right now, they are all zero because no supporte

[PATCH v3 2/8] x86: Add AMX XTILECFG and XTILEDATA components

2022-02-28 Thread Yang Zhong
From: Jing Liu The AMX TILECFG register and the TMMx tile data registers are saved/restored via XSAVE, respectively in state component 17 (64 bytes) and state component 18 (8192 bytes). Add AMX feature bits to x86_ext_save_areas array to set up AMX components. Add structs that define the layout

[PATCH v3 6/8] x86: Add support for KVM_CAP_XSAVE2 and AMX state migration

2022-02-28 Thread Yang Zhong
From: Jing Liu When dynamic xfeatures (e.g. AMX) are used by the guest, the xsave area would be larger than 4KB. KVM_GET_XSAVE2 and KVM_SET_XSAVE under KVM_CAP_XSAVE2 works with a xsave buffer larger than 4KB. Always use the new ioctls under KVM_CAP_XSAVE2 when KVM supports it. Signed-off-by: Ji

[PATCH v3 5/8] x86: Add AMX CPUIDs enumeration

2022-02-28 Thread Yang Zhong
From: Jing Liu Add AMX primary feature bits XFD and AMX_TILE to enumerate the CPU's AMX capability. Meanwhile, add AMX TILE and TMUL CPUID leaf and subleaves which exist when AMX TILE is present to provide the maximum capability of TILE and TMUL. Signed-off-by: Jing Liu Signed-off-by: Yang Zhon

[PATCH v3 8/8] linux-header: Sync the linux headers

2022-02-28 Thread Yang Zhong
This patch will be dropped once Qemu sync linux 5.17 header. Making all linux-headers changes here are only for maintainers to easily remove those changes once those patches are queued. Signed-off-by: Yang Zhong --- linux-headers/asm-x86/kvm.h | 3 +++ linux-headers/linux/kvm.h | 1 + 2 files

[PATCH v3 7/8] x86: Support XFD and AMX xsave data migration

2022-02-28 Thread Yang Zhong
From: Zeng Guang XFD(eXtended Feature Disable) allows to enable a feature on xsave state while preventing specific user threads from using the feature. Support save and restore XFD MSRs if CPUID.D.1.EAX[4] enumerate to be valid. Likewise migrate the MSRs and related xsave state necessarily. Sig

Re: [PATCH v6 0/6] support subsets of Float-Point in Integer Registers extensions

2022-02-28 Thread Alistair Francis
On Fri, Feb 11, 2022 at 2:49 PM Weiwei Li wrote: > > This patchset implements RISC-V Float-Point in Integer Registers > extensions(Version 1.0), which includes Zfinx, Zdinx, Zhinx and Zhinxmin > extension. > > Specification: > https://github.com/riscv/riscv-zfinx/blob/main/zfinx-1.0.0.pdf > > Th

Re: [PATCH v2 2/2] riscv: opentitan: Connect opentitan SPI Host

2022-02-28 Thread Alistair Francis
On Mon, Feb 28, 2022 at 1:41 PM Alistair Francis wrote: > > From: Wilfred Mallawa > > Conenct spi host[1/0] to opentitan. > > Signed-off-by: Wilfred Mallawa > --- > hw/riscv/opentitan.c | 36 > include/hw/riscv/opentitan.h | 12 +++- > 2 file

Re: [PATCH v2 04/18] tests/docker: update debian-arm64-cross with lci-tool

2022-02-28 Thread Thomas Huth
On 25/02/2022 18.20, Alex Bennée wrote: Using lci-tool update debian-arm64-cross to a Debian 11 based system. As a result we can drop debian-arm64-test-cross just for building tests. Good idea! One comment below... [...] diff --git a/tests/docker/dockerfiles/debian-arm64-cross.docker b/test

Re: [PATCH] tests/tcg/s390x: Build tests with debian11

2022-02-28 Thread Thomas Huth
On 16/02/2022 15.54, Alex Bennée wrote: David Hildenbrand writes: We need a newer compiler to build upcoming tests that test for z15 features with -march=z15. So let's do it similar to arm64 and powerpc, using an environment based on debian11 to build tests only. Cc: Thomas Huth Cc: Corneli

Re: [PATCH v3 3/4] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table

2022-02-28 Thread Ani Sinha
On Mon, Feb 28, 2022 at 12:26 PM Ani Sinha wrote: > > > > > > >ObjectClass type->name here :) > > > > > > I see. What about object_resolve_path_type()? It takes a typename > > > parameter. It even tells you if the match is ambiguous if you care. > > > > Yes this is a good suggestion and it will l

Re: [PATCH] tests/tcg/s390x: Build tests with debian11

2022-02-28 Thread David Hildenbrand
On 28.02.22 09:45, Thomas Huth wrote: > On 16/02/2022 15.54, Alex Bennée wrote: >> >> David Hildenbrand writes: >> >>> We need a newer compiler to build upcoming tests that test for z15 >>> features with -march=z15. So let's do it similar to arm64 and powerpc, >>> using an environment based on deb

Re: [PATCH 2/4] pcie: update slot power status only is power control is enabled

2022-02-28 Thread Igor Mammedov
On Mon, 28 Feb 2022 08:39:57 +0100 Gerd Hoffmann wrote: > Hi, > > > This where I wasn't comfortable with idea of calling random PCIe code > > chunks and thought about chaining callbacks so that > > pcie_cap_slot_[pre_]plug_cb() would do necessary PCIe steps > > and acpi_pcihp_device_[pre_]plu

Re: [PATCH] hw/arm/virt: Validate memory size on the first NUMA node

2022-02-28 Thread Igor Mammedov
On Mon, 28 Feb 2022 15:52:03 +0800 Gavin Shan wrote: > When the memory size on the first NUMA node is less than 128MB, the > guest hangs inside EDK2 as the following logs show. > > /home/gavin/sandbox/qemu.main/build/qemu-system-aarch64 \ > -accel kvm -machine virt,gic-version=host

Re: [PATCH 6/8] char: move qemu_openpty_raw from util/ to char/

2022-02-28 Thread Daniel P . Berrangé
On Mon, Feb 28, 2022 at 11:53:23AM +0400, Marc-André Lureau wrote: > Hi Paolo > > On Sat, Feb 26, 2022 at 11:38 AM Paolo Bonzini wrote: > > > On 2/24/22 18:04, Marc-André Lureau wrote: > > > Paolo, > > > > > > This patch is ok, but in some (new?) circumstances it fails with freebsd > > > and rev

Re: [PATCH v2 1/2] hw/ssi: Add Ibex SPI device model

2022-02-28 Thread Alistair Francis
On Mon, Feb 28, 2022 at 1:41 PM Alistair Francis wrote: > > From: Wilfred Mallawa > > Adds the SPI_HOST device model for ibex. The device specification is as per > [1]. The model has been tested on opentitan with spi_host unit tests > written for TockOS. > > [1] https://docs.opentitan.org/hw/ip/s

答复: [PATCH] i386: Set MCG_STATUS_RIPV bit for mce SRAR error

2022-02-28 Thread 罗飞
ping https://patchew.org/QEMU/20220120084634.131450-1-luo...@unicloud.com/ 发件人: 罗飞 发送时间: 2022年1月20日 16:46 收件人: qemu-devel 抄送: Paolo Bonzini; Marcelo Tosatti; k...@vger.kernel.org; 罗飞 主题: [PATCH] i386: Set MCG_STATUS_RIPV bit for mce SRAR error In the physic

Re: [PATCH v2 04/18] tests/docker: update debian-arm64-cross with lci-tool

2022-02-28 Thread Daniel P . Berrangé
On Mon, Feb 28, 2022 at 09:39:29AM +0100, Thomas Huth wrote: > On 25/02/2022 18.20, Alex Bennée wrote: > > Using lci-tool update debian-arm64-cross to a Debian 11 based system. > > As a result we can drop debian-arm64-test-cross just for building > > tests. > > Good idea! > > One comment below...

Re: [PATCH v2 04/18] tests/docker: update debian-arm64-cross with lci-tool

2022-02-28 Thread Daniel P . Berrangé
$SUBJECT =~ s/lci-tool/lcitool/ On Fri, Feb 25, 2022 at 05:20:07PM +, Alex Bennée wrote: > Using lci-tool update debian-arm64-cross to a Debian 11 based system. Likewise > As a result we can drop debian-arm64-test-cross just for building > tests. > > Signed-off-by: Alex Bennée > Reviewed-

[PATCH v3] qapi, target/i386/sev: Add cpu0-id to query-sev-capabilities

2022-02-28 Thread Dov Murik
Add a new field 'cpu0-id' to the response of query-sev-capabilities QMP command. The value of the field is the base64-encoded unique ID of CPU0 (socket 0), which can be used to retrieve the signed CEK of the CPU from AMD's Key Distribution Service (KDS). Signed-off-by: Dov Murik --- v3: - dyna

Re: [PATCH v3] qapi, target/i386/sev: Add cpu0-id to query-sev-capabilities

2022-02-28 Thread Daniel P . Berrangé
On Mon, Feb 28, 2022 at 09:30:14AM +, Dov Murik wrote: > Add a new field 'cpu0-id' to the response of query-sev-capabilities QMP > command. The value of the field is the base64-encoded unique ID of CPU0 > (socket 0), which can be used to retrieve the signed CEK of the CPU from > AMD's Key Dist

Re: [PATCH v3] qapi, target/i386/sev: Add cpu0-id to query-sev-capabilities

2022-02-28 Thread Dov Murik
On 28/02/2022 11:31, Daniel P. Berrangé wrote: > On Mon, Feb 28, 2022 at 09:30:14AM +, Dov Murik wrote: >> Add a new field 'cpu0-id' to the response of query-sev-capabilities QMP >> command. The value of the field is the base64-encoded unique ID of CPU0 >> (socket 0), which can be used to r

Re: [PATCH 1/9] Avocado GitLab CI jobs: don't reset TARGETS and simplify commands

2022-02-28 Thread Daniel P . Berrangé
On Fri, Feb 25, 2022 at 04:01:48PM -0500, Cleber Rosa wrote: > The Avocado tests rely on the TARGETS variable, which is computed > based on the built targets. The current set of commands on the > inherited scripts section will reset those, leaving TARGETS empty and > consequently the AVOCADO_CMDLI

[PATCH] vhost-vsock: detach the virqueue element in case of error

2022-02-28 Thread Stefano Garzarella
In vhost_vsock_common_send_transport_reset(), if an element popped from the virtqueue is invalid, we should call virtqueue_detach_element() to detach it from the virtqueue before freeing its memory. Fixes: fc0b9b0e1c ("vhost-vsock: add virtio sockets device") Cc: qemu-sta...@nongnu.org Reported-by

Re: [PATCH v15 2/8] net/vmnet: add vmnet backends to qapi/net

2022-02-28 Thread Markus Armbruster
Vladislav Yaroshchuk writes: > Create separate netdevs for each vmnet operating mode: > - vmnet-host > - vmnet-shared > - vmnet-bridged > > Signed-off-by: Vladislav Yaroshchuk I acked v8 and v13 of the QAPI schema part. You should add Acked-by and Reviewed-by you receive in later revisions, un

Re: [PATCH v7 3/4] tests/tcg/s390x: Tests for Miscellaneous-Instruction-Extensions Facility 3

2022-02-28 Thread Thomas Huth
On 24/02/2022 00.43, Richard Henderson wrote: On 2/23/22 12:31, David Miller wrote: +#define F_EPI "stg %%r0, %[res] " : [res] "+m" (res) : : "r0", "r2", "r3" + +#define F_PRO    asm ( \ +    "llihf %%r0,801\n" \ +    "lg %%r2, %[a]\n"  \ +    "lg %%r3, %[b] "   \ +    : : [a] "m" (a),   \ +

Re: [PATCH] hw/i386/pc: when adding reserved E820 entries do not allocate dynamic entries

2022-02-28 Thread Ani Sinha
On Thu, Feb 24, 2022 at 6:51 PM Igor Mammedov wrote: > > On Thu, 24 Feb 2022 18:14:35 +0530 > Ani Sinha wrote: > > > On Thu, Feb 24, 2022 at 2:33 PM Igor Mammedov wrote: > > > > > > On Wed, 23 Feb 2022 17:30:34 +0530 > > > Ani Sinha wrote: > > > > > > > On Wed, Feb 23, 2022 at 2:34 PM Igor Mamm

Re: [PATCH 3/3] whpx: Added support for breakpoints and stepping

2022-02-28 Thread Alex Bennée
"Ivan Shcherbakov" writes: > Hi Alex and Peter, > > It would be great to hear your feedback on handling the WHPX stepping > via an added argument to vm_prepare_start(). It is only called from 2 > places, so the changes will be minimal. I this works for you, I will > gladly send an updated patch

Re: [PATCH v7 3/4] tests/tcg/s390x: Tests for Miscellaneous-Instruction-Extensions Facility 3

2022-02-28 Thread David Hildenbrand
On 28.02.22 11:14, Thomas Huth wrote: > On 24/02/2022 00.43, Richard Henderson wrote: >> On 2/23/22 12:31, David Miller wrote: >>> +#define F_EPI "stg %%r0, %[res] " : [res] "+m" (res) : : "r0", "r2", "r3" >>> + >>> +#define F_PRO    asm ( \ >>> +    "llihf %%r0,801\n" \ >>> +    "lg %%r2, %[a]\n" 

Re: [PATCH] hw/arm/virt: Fix CPU's default NUMA node ID

2022-02-28 Thread Igor Mammedov
On Mon, 28 Feb 2022 12:26:53 +0800 Gavin Shan wrote: > Hi Igor, > > On 2/25/22 6:03 PM, Igor Mammedov wrote: > > On Fri, 25 Feb 2022 16:41:43 +0800 > > Gavin Shan wrote: > >> On 2/17/22 10:14 AM, Gavin Shan wrote: > >>> On 1/26/22 5:14 PM, Igor Mammedov wrote: > On Wed, 26 Jan 2022 1

Re: [PATCH v15 2/8] net/vmnet: add vmnet backends to qapi/net

2022-02-28 Thread Vladislav Yaroshchuk
On Mon, Feb 28, 2022 at 1:07 PM Markus Armbruster wrote: > Vladislav Yaroshchuk writes: > > > Create separate netdevs for each vmnet operating mode: > > - vmnet-host > > - vmnet-shared > > - vmnet-bridged > > > > Signed-off-by: Vladislav Yaroshchuk > > I acked v8 and v13 of the QAPI schema part

Re: Timer delays in VM

2022-02-28 Thread Peter Maydell
. On Mon, 28 Feb 2022 at 07:04, Eugene Huang wrote: > I am running qemu on an arm64 CentOS host. Inside a ubuntu VM, a process runs > a timer created using timer_t: > > ev.sigev_notify_function = m_callback; > > … > > timer_create(CLOCK_MONOTONIC, &ev, &m_timer_t); > > > > This timer sometimes h

Re: [PATCH 6/8] char: move qemu_openpty_raw from util/ to char/

2022-02-28 Thread Peter Maydell
On Mon, 28 Feb 2022 at 09:13, Daniel P. Berrangé wrote: > We only support the current major release, and thue previous major > release for 2 years overlap. If we consider 11.x releases as major, > then 11.3 went out of scope from QEMU's POV in Aug 2020, and thus > we don't need to care about this

Re: [PATCH 6/8] char: move qemu_openpty_raw from util/ to char/

2022-02-28 Thread Daniel P . Berrangé
On Mon, Feb 28, 2022 at 11:07:19AM +, Peter Maydell wrote: > On Mon, 28 Feb 2022 at 09:13, Daniel P. Berrangé wrote: > > We only support the current major release, and thue previous major > > release for 2 years overlap. If we consider 11.x releases as major, > > then 11.3 went out of scope fr

[PULL 0/9] QAPI patches patches for 2022-02-28

2022-02-28 Thread Markus Armbruster
The following changes since commit fa435db8ce1dff3b15e3f59a12f55f7b3a347b08: Merge remote-tracking branch 'remotes/jsnow-gitlab/tags/python-pull-request' into staging (2022-02-24 12:48:14 +) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2022-02-

[PULL 7/9] hw/rtc: Compile pl031 once-only

2022-02-28 Thread Markus Armbruster
From: Peter Maydell Now that the RTC_CHANGE event is no longer target-specific, we can move the pl031 back to a compile-once source file rather than a compile-per-target one. Signed-off-by: Peter Maydell Message-Id: <20220221192123.749970-4-peter.mayd...@linaro.org> Reviewed-by: Philippe Mathie

[PULL 9/9] qapi: Belatedly adjust limitations documentation

2022-02-28 Thread Markus Armbruster
Commit 57df0dff1a "qapi: Extend -compat to set policy for unstable interfaces" (v6.2.0) took care of covering experimental features, but neglected to adjust a comment suggesting to cover it. Adjust it now. Fixes: 57df0dff1a1f4c846aa74a082bfd595a8a990015 Signed-off-by: Markus Armbruster Message-I

[PULL 3/9] qapi: Fix stale reference to scripts/qapi.py in a comment

2022-02-28 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-Id: <20220218145551.892787-3-arm...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé --- qapi/qapi-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/qapi-util.c b/qapi/qapi-util.c index fda7044539..63596e11c5 100644 --- a/qapi

[PULL 6/9] qapi: Document some missing details of RTC_CHANGE event

2022-02-28 Thread Markus Armbruster
From: Peter Maydell The RTC_CHANGE event's documentation is missing some details: * the offset argument is in units of seconds * it isn't guaranteed that the RTC will implement the event Signed-off-by: Peter Maydell Message-Id: <20220221192123.749970-3-peter.mayd...@linaro.org> Reviewed-by: P

[PULL 1/9] scripts/qapi: minor delinting

2022-02-28 Thread Markus Armbruster
From: John Snow Get isort and pylint tools passing again. Signed-off-by: John Snow Message-Id: <20220211183650.2946895-1-js...@redhat.com> Reviewed-by: Markus Armbruster [Comment explaining good-names-rgxs tweaked] Signed-off-by: Markus Armbruster --- scripts/qapi/commands.py | 2 +- script

[PULL 4/9] qapi/migration: Fix examples document wrong field name for arguments

2022-02-28 Thread Markus Armbruster
From: Fabian Holler The examples for the snapshot-* and calc-dirty-rate commands document that arguments for the commands are passed in a 'data' field. This is wrong, passing them in a "data" field results in the error: {"error": {"class": "GenericError", "desc": "QMP input member 'data'

[PULL 8/9] rtc: Have event RTC_CHANGE identify the RTC by QOM path

2022-02-28 Thread Markus Armbruster
Event RTC_CHANGE is "emitted when the guest changes the RTC time" (and the RTC supports the event). What if there's more than one RTC? Which one changed? New @qom-path identifies it. Signed-off-by: Markus Armbruster Message-Id: <87a6ejnm80@pond.sub.org> Reviewed-by: Philippe Mathieu-Daudé

[PULL 5/9] qapi: Move RTC_CHANGE back out of target schema

2022-02-28 Thread Markus Armbruster
From: Peter Maydell This commit effectively reverts commit 183e4281a30962, which moved the RTC_CHANGE event to the target schema. That change was an attempt to make the event target-specific to improve introspection, but the event isn't really target-specific: it's machine or device specific. P

[PULL 2/9] keyval: Fix grammar comment to cover downstream prefix

2022-02-28 Thread Markus Armbruster
According to the grammar, a key __com.redhat_foo would be parsed as two key fragments __com and redhat_foo. It's actually parsed as a single fragment. Fix the grammar. Signed-off-by: Markus Armbruster Message-Id: <20220218145551.892787-2-arm...@redhat.com> --- util/keyval.c | 4 +++- 1 file ch

[PATCH v5 01/16] block/block-copy: move copy_bitmap initialization to block_copy_state_new()

2022-02-28 Thread Vladimir Sementsov-Ogievskiy
We are going to complicate bitmap initialization in the further commit. And in future, backup job will be able to work without filter (when source is immutable), so we'll need same bitmap initialization in copy-before-write filter and in backup job. So, it's reasonable to do it in block-copy. Note

[PATCH v5 00/16] Make image fleecing more usable

2022-02-28 Thread Vladimir Sementsov-Ogievskiy
v5: Drop immutable_source backup parameter: it's not necessary with new scheme. Other changes: 03,06,07,08,10,13 : add Hanna's r-bs 04: add (Since 7.0) 11: s/filter/block driver/, also add note about snapshot size 12: fix text and s/bs/child->bs/kk update iotest 257 output 14: use qemu_io_wrap

[PATCH v5 16/16] iotests/image-fleecing: test push backup with fleecing

2022-02-28 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/tests/image-fleecing | 120 ++-- tests/qemu-iotests/tests/image-fleecing.out | 63 ++ 2 files changed, 151 insertions(+), 32 deletions(-) diff --git a/tests/qemu-iotests/tests/image-fleecing b/tests/

[PATCH v5 06/16] block: intoduce reqlist

2022-02-28 Thread Vladimir Sementsov-Ogievskiy
Split intersecting-requests functionality out of block-copy to be reused in copy-before-write filter. Note: while being here, fix tiny typo in MAINTAINERS. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz --- include/block/reqlist.h | 67 +++ block/bloc

[PATCH v5 05/16] block/block-copy: add block_copy_reset()

2022-02-28 Thread Vladimir Sementsov-Ogievskiy
Split block_copy_reset() out of block_copy_reset_unallocated() to be used separately later. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz --- include/block/block-copy.h | 1 + block/block-copy.c | 21 + 2 files changed, 14 insertions(+), 8 del

[PATCH v5 04/16] block/copy-before-write: add bitmap open parameter

2022-02-28 Thread Vladimir Sementsov-Ogievskiy
This brings "incremental" mode to copy-before-write filter: user can specify bitmap so that filter will copy only "dirty" areas. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 10 +++- block/copy-before-write.c | 51 ++- 2 file

[PATCH] tests/avocado: Cancel BootLinux tests in case there is no free port

2022-02-28 Thread Thomas Huth
The BootLinux tests are currently failing with an ugly python stack trace on my RHEL8 system since they cannot get a free port (likely due to the firewall settings on my system). Let's properly check the return value of find_free_port() instead and cancel the test gracefully if it cannot get a free

[PATCH v5 02/16] block/dirty-bitmap: bdrv_merge_dirty_bitmap(): add return value

2022-02-28 Thread Vladimir Sementsov-Ogievskiy
That simplifies handling failure in existing code and in further new usage of bdrv_merge_dirty_bitmap(). Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz --- include/block/dirty-bitmap.h| 2 +- block/dirty-bitmap.c| 9 +++-- block/monitor/bitmap-qmp-cmds.

[PATCH v5 08/16] block/dirty-bitmap: introduce bdrv_dirty_bitmap_status()

2022-02-28 Thread Vladimir Sementsov-Ogievskiy
Add a convenient function similar with bdrv_block_status() to get status of dirty bitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz --- include/block/dirty-bitmap.h | 2 ++ include/qemu/hbitmap.h | 12 block/dirty-bitmap.c | 6 ++ util

[PATCH v5 09/16] block/reqlist: add reqlist_wait_all()

2022-02-28 Thread Vladimir Sementsov-Ogievskiy
Add function to wait for all intersecting requests. To be used in the further commit. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Nikita Lapshin Reviewed-by: Hanna Reitz --- include/block/reqlist.h | 8 block/reqlist.c | 8 2 files changed, 16 insertions(

[PATCH v5 10/16] block/io: introduce block driver snapshot-access API

2022-02-28 Thread Vladimir Sementsov-Ogievskiy
Add new block driver handlers and corresponding generic wrappers. It will be used to allow copy-before-write filter to provide reach fleecing interface in further commit. In future this approach may be used to allow reading qcow2 internal snapshots, for example to export them through NBD. Signed-

[PATCH v5 07/16] block/reqlist: reqlist_find_conflict(): use ranges_overlap()

2022-02-28 Thread Vladimir Sementsov-Ogievskiy
Let's reuse convenient helper. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz --- block/reqlist.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/reqlist.c b/block/reqlist.c index 5e320ba649..09fecbd48c 100644 --- a/block/reqlist.c +++ b/block/r

[PATCH v5 12/16] block: copy-before-write: realize snapshot-access API

2022-02-28 Thread Vladimir Sementsov-Ogievskiy
Current scheme of image fleecing looks like this: [guest][NBD export] | | |root | root v v [copy-before-write] -> [temp.qcow2] | target | |file

[PATCH v5 11/16] block: introduce snapshot-access block driver

2022-02-28 Thread Vladimir Sementsov-Ogievskiy
The new block driver simply utilizes snapshot-access API of underlying block node. In further patches we want to use it like this: [guest] [NBD export] || | root | root v file v [copy-before-write]<

[PATCH v5 03/16] block/block-copy: block_copy_state_new(): add bitmap parameter

2022-02-28 Thread Vladimir Sementsov-Ogievskiy
This will be used in the following commit to bring "incremental" mode to copy-before-write filter. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz --- include/block/block-copy.h | 1 + block/block-copy.c | 14 +- block/copy-before-write.c | 2 +- 3 fi

[PATCH v5 14/16] iotests.py: add qemu_io_pipe_and_status()

2022-02-28 Thread Vladimir Sementsov-Ogievskiy
Add helper that returns both status and output, to be used in the following commit Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 6ba65eb1ff..

[PATCH v5 13/16] iotests/image-fleecing: add test-case for fleecing format node

2022-02-28 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz --- tests/qemu-iotests/tests/image-fleecing | 64 - tests/qemu-iotests/tests/image-fleecing.out | 76 - 2 files changed, 120 insertions(+), 20 deletions(-) diff --git a/tests/qemu-iotest

[PATCH 1/2] meson: move int128 checks from configure

2022-02-28 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- configure | 47 --- meson.build | 39 +++ 2 files changed, 39 insertions(+), 47 deletions(-) diff --git a/configure b/configure index c56ed53ee365..663

[PATCH v5 15/16] iotests/image-fleecing: add test case with bitmap

2022-02-28 Thread Vladimir Sementsov-Ogievskiy
Note that reads zero areas (not dirty in the bitmap) fails, that's correct. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/tests/image-fleecing | 32 ++-- tests/qemu-iotests/tests/image-fleecing.out | 84 + 2 files changed, 108 insertions(+), 8 del

Re: [PATCH v15 3/8] net/vmnet: implement shared mode (vmnet-shared)

2022-02-28 Thread Vladislav Yaroshchuk
On Sat, Feb 26, 2022 at 3:27 PM Akihiko Odaki wrote: > On Sat, Feb 26, 2022 at 8:33 PM Vladislav Yaroshchuk > wrote: > > > > > > > > On Sat, Feb 26, 2022 at 12:16 PM Akihiko Odaki > wrote: > >> > >> On 2022/02/26 17:37, Vladislav Yaroshchuk wrote: > >> > > >> > Hi Akihiko, > >> > > >> > On Fri,

[PATCH 2/2] meson: fix CONFIG_ATOMIC128 check

2022-02-28 Thread marcandre . lureau
From: Marc-André Lureau testfile.c: In function 'main': testfile.c:5:11: error: incorrect number of arguments to function '__atomic_load' 5 | y = __atomic_load(&x, 0); | ^ testfile.c:6:7: error: argument 2 of '__atomic_store' must be a pointer type 6 |

Re: [PATCH 7/9] Avocado tests: improve documentation on tag filtering

2022-02-28 Thread Thomas Huth
On 25/02/2022 22.01, Cleber Rosa wrote: It's possible to filter based on a combination of criteria. This adds examples to the documentation. Signed-off-by: Cleber Rosa --- docs/devel/testing.rst | 22 ++ 1 file changed, 22 insertions(+) diff --git a/docs/devel/testing.r

Re: [PATCH] target/arm: Report KVM's actual PSCI version to guest in dtb

2022-02-28 Thread Andrew Jones
On Thu, Feb 24, 2022 at 01:46:54PM +, Peter Maydell wrote: > When we're using KVM, the PSCI implementation is provided by the > kernel, but QEMU has to tell the guest about it via the device tree. > Currently we look at the KVM_CAP_ARM_PSCI_0_2 capability to determine > if the kernel is providi

Re: [PATCH] qom: assert integer does not overflow

2022-02-28 Thread Michael S. Tsirkin
On Fri, Feb 25, 2022 at 02:35:36PM +, Daniel P. Berrangé wrote: > On Fri, Feb 25, 2022 at 09:10:44AM -0500, Michael S. Tsirkin wrote: > > QOM reference counting is not designed with an infinite amount of > > references in mind, trying to take a reference in a loop will overflow > > the integer.

Re: [PATCH 2/9] Avocado tests: use logging namespace that is preserved in test logs

2022-02-28 Thread Alex Bennée
Cleber Rosa writes: > Since Avocado 92.0[1], there's no universal preservation of logged > content via Python's "logging" APIs into the test log files. This > changes were motivated by the fact that doing so is intrusive as it > touches on Python's root logger. > > Test writers are now expecte

Re: [PATCH 2/2] meson: fix CONFIG_ATOMIC128 check

2022-02-28 Thread Philippe Mathieu-Daudé
On 28/2/22 13:07, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau testfile.c: In function 'main': testfile.c:5:11: error: incorrect number of arguments to function '__atomic_load' 5 | y = __atomic_load(&x, 0); | ^ testfile.c:6:7: error: argume

Re: [PATCH v2 1/2] Replacing CONFIG_VNC_PNG with CONFIG_PNG

2022-02-28 Thread Philippe Mathieu-Daudé
On 28/2/22 06:22, Kshitij Suri wrote: Libpng is only detected if VNC is enabled currently. This patch adds a generalised png option in the meson build which is aimed to replace use of CONFIG_VNC_PNG with CONFIG_PNG. Signed-off-by: Kshitij Suri --- meson.build| 10 +- meson_op

Re: [PATCH] softmmu/vl: Remove redundant local variable

2022-02-28 Thread Philippe Mathieu-Daudé
On 28/2/22 04:27, Zhenzhong Duan wrote: While there is already a local variable opts in main function scope, no need to define another one with same name in smaller scope. No functional changes. Signed-off-by: Zhenzhong Duan --- softmmu/vl.c | 4 +--- 1 file changed, 1 insertion(+), 3 delet

Re: [PATCH v9 11/11] 9p: darwin: meson: Allow VirtFS on Darwin

2022-02-28 Thread Christian Schoenebeck
On Sonntag, 27. Februar 2022 23:35:22 CET Will Cohen wrote: > From: Keno Fischer > > To allow VirtFS on darwin, we need to check that pthread_fchdir_np is > available, which has only been available since macOS 10.12. > > Additionally, virtfs_proxy_helper is disabled on Darwin. This patch > serie

Re: [PATCH v9 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-28 Thread Christian Schoenebeck
On Sonntag, 27. Februar 2022 23:35:20 CET Will Cohen wrote: > From: Keno Fischer > > Darwin does not support mknodat. However, to avoid race conditions > with later setting the permissions, we must avoid using mknod on > the full path instead. We could try to fchdir, but that would cause > proble

[PATCH] x86: cleanup unused compat_apic_id_mode

2022-02-28 Thread Igor Mammedov
commit f862ddbb1a4 (hw/i386: Remove the deprecated pc-1.x machine types) removed the last user of broken APIC ID compat knob, but compat_apic_id_mode itself was forgotten. Clean it up and simplify x86_cpu_apic_id_from_index() Signed-off-by: Igor Mammedov --- include/hw/i386/x86.h | 2 -- hw/i

Re: [PATCH 2/2] meson: fix CONFIG_ATOMIC128 check

2022-02-28 Thread Peter Maydell
On Mon, 28 Feb 2022 at 12:19, wrote: > > From: Marc-André Lureau > > testfile.c: In function 'main': > testfile.c:5:11: error: incorrect number of arguments to function > '__atomic_load' > 5 | y = __atomic_load(&x, 0); > | ^ > testfile.c:6:7: error: argument

[PULL 4/6] s390x/tcg: Implement Miscellaneous-Instruction-Extensions Facility 3 for the s390x

2022-02-28 Thread Thomas Huth
From: David Miller implements: AND WITH COMPLEMENT (NCRK, NCGRK) NAND (NNRK, NNGRK) NOT EXCLUSIVE OR (NXRK, NXGRK) NOR (NORK, NOGRK) OR WITH COMPLEMENT(OCRK, OCGRK) SELECT(SELR, SELGR) SELECT HIGH (SELFHR) MOVE RIGHT TO LEFT

[PULL 5/6] s390x/cpumodel: Bump up QEMU model to a stripped-down IBM z15 GA1

2022-02-28 Thread Thomas Huth
From: David Miller TCG implements everything we need to run basic z15 OS+software Signed-off-by: David Miller Message-Id: <20220223223117.0-3-dmiller...@gmail.com> Reviewed-by: David Hildenbrand Signed-off-by: Thomas Huth --- hw/s390x/s390-virtio-ccw.c | 3 +++ target/s390x/cpu_models.c

[PULL 1/6] s390x: sck: load into a temporary not into in1

2022-02-28 Thread Thomas Huth
From: Nico Boehr We previously loaded into in1, but in1 is not filled during disassembly and hence always zero. This leads to an assertion failure: qemu-system-s390x: /home/nrb/qemu/include/tcg/tcg.h:654: temp_idx: Assertion `n >= 0 && n < tcg_ctx->nb_temps' failed.` Instead, use in2_la2_m6

[PULL 6/6] tests/tcg/s390x: Tests for Miscellaneous-Instruction-Extensions Facility 3

2022-02-28 Thread Thomas Huth
From: David Miller tests/tcg/s390x/mie3-compl.c: [N]*K instructions tests/tcg/s390x/mie3-mvcrl.c: MVCRL instruction tests/tcg/s390x/mie3-sel.c: SELECT instruction Signed-off-by: David Miller Message-Id: <20220223223117.0-4-dmiller...@gmail.com> [thuth: Squash mnemonic -> .insn patch, white

Re: [PATCH v9 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-28 Thread Thomas Huth
On 28/02/2022 14.20, Christian Schoenebeck wrote: On Sonntag, 27. Februar 2022 23:35:20 CET Will Cohen wrote: From: Keno Fischer Darwin does not support mknodat. However, to avoid race conditions with later setting the permissions, we must avoid using mknod on the full path instead. We could t

Re: [PATCH 2/2] meson: fix CONFIG_ATOMIC128 check

2022-02-28 Thread Marc-André Lureau
Hi On Mon, Feb 28, 2022 at 5:24 PM Peter Maydell wrote: > > On Mon, 28 Feb 2022 at 12:19, wrote: > > > > From: Marc-André Lureau > > > > testfile.c: In function 'main': > > testfile.c:5:11: error: incorrect number of arguments to function > > '__atomic_load' > > 5 | y = __atomic_load

Re: [PATCH] x86: cleanup unused compat_apic_id_mode

2022-02-28 Thread Thomas Huth
On 28/02/2022 14.16, Igor Mammedov wrote: commit f862ddbb1a4 (hw/i386: Remove the deprecated pc-1.x machine types) removed the last user of broken APIC ID compat knob, but compat_apic_id_mode itself was forgotten. Clean it up and simplify x86_cpu_apic_id_from_index() Signed-off-by: Igor Mamme

Re: [PATCH 2/2] meson: fix CONFIG_ATOMIC128 check

2022-02-28 Thread Peter Maydell
On Mon, 28 Feb 2022 at 13:28, Marc-André Lureau wrote: > > Hi > > On Mon, Feb 28, 2022 at 5:24 PM Peter Maydell > wrote: > > > > On Mon, 28 Feb 2022 at 12:19, wrote: > > > > > > From: Marc-André Lureau > > > > > > testfile.c: In function 'main': > > > testfile.c:5:11: error: incorrect number o

[PULL 0/6] s390x patches

2022-02-28 Thread Thomas Huth
Hi! The following changes since commit fa435db8ce1dff3b15e3f59a12f55f7b3a347b08: Merge remote-tracking branch 'remotes/jsnow-gitlab/tags/python-pull-request' into staging (2022-02-24 12:48:14 +) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-reques

Re: [PATCH v9 11/11] 9p: darwin: meson: Allow VirtFS on Darwin

2022-02-28 Thread Will Cohen
On Mon, Feb 28, 2022 at 8:11 AM Christian Schoenebeck < qemu_...@crudebyte.com> wrote: > On Sonntag, 27. Februar 2022 23:35:22 CET Will Cohen wrote: > > From: Keno Fischer > > > > To allow VirtFS on darwin, we need to check that pthread_fchdir_np is > > available, which has only been available si

Re: [PATCH] x86: cleanup unused compat_apic_id_mode

2022-02-28 Thread Philippe Mathieu-Daudé
On 28/2/22 14:16, Igor Mammedov wrote: commit f862ddbb1a4 (hw/i386: Remove the deprecated pc-1.x machine types) removed the last user of broken APIC ID compat knob, but compat_apic_id_mode itself was forgotten. Clean it up and simplify x86_cpu_apic_id_from_index() Signed-off-by: Igor Mammedov

Re: [PATCH] qom: assert integer does not overflow

2022-02-28 Thread Michael S. Tsirkin
On Mon, Feb 28, 2022 at 07:16:56AM -0500, Michael S. Tsirkin wrote: > On Fri, Feb 25, 2022 at 02:35:36PM +, Daniel P. Berrangé wrote: > > On Fri, Feb 25, 2022 at 09:10:44AM -0500, Michael S. Tsirkin wrote: > > > QOM reference counting is not designed with an infinite amount of > > > references

[PULL 2/6] tests/avocado/machine_s390_ccw_virtio: Adapt test to new default resolution

2022-02-28 Thread Thomas Huth
QEMU's default screen resolution recently changed to 1280x800, so the resolution in the screen shot header changed of course, too. Fixes: de72c4b7cd ("edid: set default resolution to 1280x800 (WXGA)") Reported-by: Peter Maydell Message-Id: <20220221101933.307525-1-th...@redhat.com> Reviewed-by: P

Re: [PATCH v9 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-28 Thread Christian Schoenebeck
On Montag, 28. Februar 2022 14:36:30 CET Thomas Huth wrote: > On 28/02/2022 14.20, Christian Schoenebeck wrote: > > On Sonntag, 27. Februar 2022 23:35:20 CET Will Cohen wrote: > >> From: Keno Fischer > >> > >> Darwin does not support mknodat. However, to avoid race conditions > >> with later sett

[PULL 3/6] travis.yml: Update the s390x jobs to Ubuntu Focal

2022-02-28 Thread Thomas Huth
QEMU will soon drop the support for Ubuntu 18.04, so let's update the Travis jobs that were still using this version to 20.04 instead. While we're at it, also remove an obsolete comment about Ubuntu Xenial being the default for our Travis jobs. Reviewed-by: Richard Henderson Message-Id: <2022022

Re: [PATCH v9 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-28 Thread Will Cohen
On Mon, Feb 28, 2022 at 8:20 AM Christian Schoenebeck < qemu_...@crudebyte.com> wrote: > On Sonntag, 27. Februar 2022 23:35:20 CET Will Cohen wrote: > > From: Keno Fischer > > > > Darwin does not support mknodat. However, to avoid race conditions > > with later setting the permissions, we must av

Re: [PATCH v9 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-28 Thread Greg Kurz
On Mon, 28 Feb 2022 08:37:10 -0500 Will Cohen wrote: > On Mon, Feb 28, 2022 at 8:20 AM Christian Schoenebeck < > qemu_...@crudebyte.com> wrote: > > > On Sonntag, 27. Februar 2022 23:35:20 CET Will Cohen wrote: > > > From: Keno Fischer > > > > > > Darwin does not support mknodat. However, to avo

Re: [PATCH v9 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-28 Thread Peter Maydell
On Mon, 28 Feb 2022 at 13:58, Christian Schoenebeck wrote: > > On Montag, 28. Februar 2022 14:36:30 CET Thomas Huth wrote: > > For lines less than 90 characters, it's just a warning, and I think it's ok > > in such cases to keep it longer than 80 characters, if the result of > > breaking it up wou

Re: [PATCH] ppc/pnv: fix default PHB4 QOM hierarchy

2022-02-28 Thread Daniel Henrique Barboza
On 2/26/22 10:49, Cédric Le Goater wrote: On 2/18/22 21:28, Daniel Henrique Barboza wrote: Commit 3f4c369ea63e ("ppc/pnv: make PECs create and realize PHB4s") changed phb4_pec code to create the default PHB4 objects in pnv_pec_default_phb_realize(). In this process the stacks[] PEC array was

[PATCH qemu 6/7] hvf: add a lock for memory related functions

2022-02-28 Thread ~ubzeme
From: Yan-Jie Wang We follow how KVM accel does in its memory listener (kvm-all.c) and add a lock for the memory related functions. Signed-off-by: Yan-Jie Wang --- accel/hvf/hvf-mem.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/accel/hvf/hvf-mem.c b/accel/hvf/hvf-me

[PATCH qemu 2/7] hvf: simplify data structures and codes of memory related functions

2022-02-28 Thread ~ubzeme
From: Yan-Jie Wang * Remove mac_slot and use hvf_slot only. The function of the two structures are similar. * Refactor function hvf_set_phys_mem(): - Remove unnecessary checks because any modified memory sections will be removed first (region_del called first) before being added. Theref

  1   2   3   >