[Bug 1749393] Re: sbrk() not working under qemu-user with a PIE-compiled binary?

FYI the release of this is slowed down by the slow verification of bug https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1929926 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1749393 Title: sbrk(

Re: [PATCH 10/12] s390x/pci: use I/O Address Translation assist when interpreting

On 12/7/21 22:04, Matthew Rosato wrote: Allow the underlying kvm host to handle the Refresh PCI Translation instruction intercepts. Signed-off-by: Matthew Rosato --- hw/s390x/s390-pci-bus.c | 6 ++-- hw/s390x/s390-pci-inst.c | 51 ++-- hw/s39

Re: [PATCH 12/12] s390x/pci: let intercept devices have separate PCI groups

On 12/7/21 22:04, Matthew Rosato wrote: Let's use the reserved pool of simulated PCI groups to allow intercept devices to have separate groups from interpreted devices as some group values may be different. If we run out of simulated PCI groups, subsequent intercept devices just get the defaul

Re: [PATCH v2 1/9] hw/intc: sifive_plic: Add a reset function

On 12/16/21 05:54, Alistair Francis wrote: > From: Alistair Francis > > Signed-off-by: Alistair Francis > --- > hw/intc/sifive_plic.c | 18 ++ > 1 file changed, 18 insertions(+) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 8/9] hw/riscv: virt: Allow support for 32 cores

On 12/16/21 06:58, Anup Patel wrote: > On Thu, Dec 16, 2021 at 10:27 AM Alistair Francis > wrote: >> >> From: Alistair Francis >> >> Linux supports up to 32 cores for both 32-bit and 64-bit RISC-V, so >> let's set that as the maximum for the virt board. >> >> Resolves: https://gitlab.com/qemu-pro

Re: [PATCH v2 2/2] hw/arm: Add Cortex-A5 to virt device

On 12/16/21 07:48, Byron Lathi wrote: > Add the Cortex-A5 to the list of supported CPUs by the virt platform. > > Signed-off-by: Byron Lathi > --- > docs/system/arm/virt.rst | 1 + > hw/arm/virt.c| 1 + > 2 files changed, 2 insertions(+) Reviewed-by: Philippe Mathieu-Daudé

[PATCH] gitlab-ci: Speed up the msys2-64bit job by using --without-default-devices

The new msys2-64bit job is often running for more than 50 minutes - and if the CI is currently loaded, it times out after 60 minutes. The job has been declared with a bigger timeout, but seems like this is getting ignored on the shared Gitlab-CI Windows runners, so we're currently seeing a lot of f

Re: [PATCH v5 4/8] tests/unit/test-smp-parse: Add 'smp-generic-invalid' machine type

On 12/16/21 04:20, wangyanan (Y) wrote: > Hi Philippe, > > On 2021/12/16 0:48, Philippe Mathieu-Daudé wrote: >> Avoid modifying the MachineClass internals by adding the >> 'smp-generic-invalid' machine, which inherits from TYPE_MACHINE. >> >> Reviewed-by: Richard Henderson >> Signed-off-by: Phili

[PATCH] ui: fix gtk clipboard clear assertion

From: Marc-André Lureau When closing the QEMU Gtk display window, it can occasionaly warn: qemu-system-x86_64: Gtk: gtk_clipboard_set_with_data: assertion 'targets != NULL' failed #3 0x74f02f22 in gtk_clipboard_set_with_data (clipboard=, targets=, n_targets=, get_func=, clear_func=, us

[PATCH 0/2] hw/net: Move MV88W8618 network device out of hw/arm/ directory

This series simply extract the MV88W8618 device from the ARM machine in hw/arm/ and move it to hw/net/. I was expecting for this to get merged before posting a generic network code rework series, then figured I never posted it >_< Philippe Mathieu-Daudé (2): hw/arm/musicpal: Fix coding style of

[PATCH 1/2] hw/arm/musicpal: Fix coding style of code related to MV88W8618 device

We are going to move this code, so fix its style first to avoid: ERROR: spaces required around that '/' (ctx:VxV) Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/musicpal.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.

Re: [PATCH v2 4/4] intel_iommu: Fix irqchip / X2APIC configuration checks

Hi, David, On Thu, Dec 09, 2021 at 10:08:40PM +, David Woodhouse wrote: > We don't need to check kvm_enable_x2apic(). It's perfectly OK to support > interrupt remapping even if we can't address CPUs above 254. Kind of > pointless, but still functional. We only checks kvm_enable_x2apic() if ei

[PATCH 2/2] hw/net: Move MV88W8618 network device out of hw/arm/ directory

The Marvell 88W8618 network device is hidden in the Musicpal machine. Move it into a new unit file under the hw/net/ directory. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/net/mv88w8618_eth.h | 16 ++ hw/arm/musicpal.c | 380 +- hw/net/mv88w8618

[PATCH 02/10] configure: make $targetos lowercase, use windows instead of MINGW32

targetos is already mostly the same as Meson host_machine.system(), just in CamelCase. Adjust Windows, which is different, and switch to lowercase to match Meson. Signed-off-by: Paolo Bonzini --- configure | 58 --- 1 file changed, 25 insertio

Re: [PATCH v2 2/4] intel_iommu: Support IR-only mode without DMA translation

On Thu, Dec 09, 2021 at 10:08:38PM +, David Woodhouse wrote: > From: David Woodhouse > > By setting none of the SAGAW bits we can indicate to a guest that DMA > translation isn't supported. Tested by booting Windows 10, as well as > Linux guests with the fix at https://git.kernel.org/torvalds

[PATCH 01/10] configure: simplify creation of plugin symbol list

--dynamic-list is present on all supported ELF (not Windows or Darwin) platforms, since it dates back to 2006; -exported_symbols_list is likewise present on all supported versions of macOS. Do not bother doing a functional test in configure. Since stuff is being moved to meson, move the creation

[PATCH 00/10] configure cleanups, mostly wrt $cpu and $targetos

The bulk is in patches 2 to 9; they unify the names of architectures between configure and meson, and remove the ARCH symbol from configure. It is only used during QEMU build, so it can be derived from host_machine.cpu_family(), instead of having to pass it in config-host.mak. Paolo Bonzini (10):

[PATCH 09/10] configure, meson: move ARCH to meson.build

$ARCH and the HOST_* symbols are only used by the QEMU build; configure uses $cpu instead. Remove it from config-host.mak. Signed-off-by: Paolo Bonzini --- configure | 21 - meson.build | 26 +- 2 files changed, 21 insertions(+), 26 deletions(-) di

[PATCH 03/10] configure: move target detection before CPU detection

This makes more sense, since target detection can affect CPU detection on Solaris. Signed-off-by: Paolo Bonzini --- configure | 115 ++ 1 file changed, 55 insertions(+), 60 deletions(-) diff --git a/configure b/configure index 63438c1900..1576

[PATCH 10/10] configure: remove unnecessary symlinks

Make pc-bios/meson.build use the files in the source tree as inputs to bzip2. Signed-off-by: Paolo Bonzini --- configure | 1 - pc-bios/meson.build | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index 2cecbd4c66..7751cc31b8 100755 --- a/conf

[PATCH 07/10] configure: unify x86_64 and x32

The only difference between the two, as far as either configure or Meson are concerned, is in the multilib flags passed to the compiler. For QEMU, this fixes the handling of TYPE_OLDDEVT in include/exec/user/thunk.h and enables testing of dirty ring buffer, because both are using HOST_X86_64. For

[PATCH 04/10] configure: do not set bsd_user/linux_user early

Similar to other optional features, leave the variables empty and compute the actual value later. Use the existence of include or source directories to detect whether an OS or CPU supports respectively bsd-user and linux-user. For now, BSD user-mode emulation is buildable even on TCI-only archite

[PATCH 05/10] configure: unify two case statements on $cpu

Signed-off-by: Paolo Bonzini --- configure | 67 ++- 1 file changed, 32 insertions(+), 35 deletions(-) diff --git a/configure b/configure index a774086891..65df8d02d9 100755 --- a/configure +++ b/configure @@ -635,32 +635,47 @@ else fi ARCH

[PATCH 08/10] meson: rename "arch" variable

Avoid confusion between the ARCH variable of configure/config-host.mak and the same-named variable of meson.build. Signed-off-by: Paolo Bonzini --- meson.build | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/meson.build b/meson.build index 903d4f3b10..677ab1b57d

[PATCH 06/10] configure: unify ppc64 and ppc64le

The only difference between the two, as far as either configure or Meson are concerned, is the default endianness of the compiler. For tests/tcg, specify the endianness explicitly on the command line; for configure, do the same so that it is possible to have --cpu=ppc64le on a bigendian system or

Re: [PATCH 2/2] hw/net: Move MV88W8618 network device out of hw/arm/ directory

On 12/16/21 09:45, Philippe Mathieu-Daudé wrote: > The Marvell 88W8618 network device is hidden in the Musicpal > machine. Move it into a new unit file under the hw/net/ directory. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/net/mv88w8618_eth.h | 16 ++ > hw/arm/musicpal.c

Re: [PATCH 06/10] configure: unify ppc64 and ppc64le

On 12/16/21 09:51, Paolo Bonzini wrote: > The only difference between the two, as far as either configure or > Meson are concerned, is the default endianness of the compiler. > > For tests/tcg, specify the endianness explicitly on the command line; > for configure, do the same so that it is possib

Re: [PATCH 07/10] configure: unify x86_64 and x32

On 12/16/21 09:51, Paolo Bonzini wrote: > The only difference between the two, as far as either configure or > Meson are concerned, is in the multilib flags passed to the compiler. > > For QEMU, this fixes the handling of TYPE_OLDDEVT in > include/exec/user/thunk.h and enables testing of dirty rin

Re: [RFC] vhost-vdpa-net: add vhost-vdpa-net host device support

On Thu, Dec 16, 2021 at 11:01:40AM +0800, Jason Wang wrote: > On Wed, Dec 15, 2021 at 6:07 PM Stefan Hajnoczi wrote: > > > > On Wed, Dec 15, 2021 at 11:18:05AM +0800, Jason Wang wrote: > > > On Tue, Dec 14, 2021 at 9:11 PM Stefan Hajnoczi > > > wrote: > > > > > > > > On Tue, Dec 14, 2021 at 10:2

Re: [PATCH] gitlab-ci: Speed up the msys2-64bit job by using --without-default-devices

On 12/16/21 09:22, Thomas Huth wrote: > The new msys2-64bit job is often running for more than 50 minutes - and > if the CI is currently loaded, it times out after 60 minutes. The job > has been declared with a bigger timeout, but seems like this is getting > ignored on the shared Gitlab-CI Windows

Re: [PATCH 08/10] meson: rename "arch" variable

On 12/16/21 09:51, Paolo Bonzini wrote: > Avoid confusion between the ARCH variable of configure/config-host.mak > and the same-named variable of meson.build. > > Signed-off-by: Paolo Bonzini > --- > meson.build | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) Reviewed-by: P

[PATCH 3/5] migration: ram_release_pages() always receive 1 page as argument

Remove the pages argument. And s/pages/page/ Signed-off-by: Juan Quintela --- migration/ram.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 7223b0d8ca..8d29d64b35 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -1204,13

[PATCH 5/5] migration: Move ram_release_pages() call to save_zero_page_to_file()

We always need to call it when we find a zero page, so put it in a single place. Signed-off-by: Juan Quintela --- migration/ram.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 0911811ed9..b0b888 100644 ---

[PATCH 0/5] migration: misc cleanups

Hi This series do several cleanups: - Dave found that I was using "%d" for unsigned, fix all uses. - We pass last_stage left and right, but we only use it in two places Just move it to RAMState. - do_compress_page() used a goto when not needed. - ram_release_pages() was always used with one page

[PATCH 2/5] migration: We only need last_stage in two places

And we are passing it all around. Just add a field to RAMState that passes it. Signed-off-by: Juan Quintela --- migration/ram.c | 41 ++--- 1 file changed, 18 insertions(+), 23 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 57efa67f20..722

Re: [PATCH v10 3/3] cpus-common: implement dirty page limit on virtual CPU

在 2021/12/16 14:22, Peter Xu 写道: On Wed, Dec 15, 2021 at 02:41:32PM +0100, Markus Armbruster wrote: Peter Xu writes: On Wed, Dec 15, 2021 at 03:56:55PM +0800, Hyman Huang wrote: +{ 'command': 'vcpu-dirty-limit', + 'data': { 'enable': 'bool', +'*cpu-index': 'uint64', +

[PATCH 1/5] migration: All this fields are unsigned

So printing it as %d is wrong. Notice that for the channel id, that is an uint8_t, but I changed it anyways for consistency. Signed-off-by: Juan Quintela --- migration/multifd-zlib.c | 20 ++-- migration/multifd-zstd.c | 24 migration/multifd.c | 16

[PATCH 4/5] migration: simplify do_compress_ram_page

The goto is not needed at all. Signed-off-by: Juan Quintela --- migration/ram.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 8d29d64b35..0911811ed9 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -1341,12 +1341,11 @

Re: [RFC PATCH 0/6] Introduce GPIO transmitter and connect to NPCM7xx

+Marc-André (chardev) & Dave On 12/16/21 02:54, Joe Komlodi wrote: > Hi all, > > This series introduces a GPIO transmitter, which allows the transmission > of GPIO controller pin state over chardev, and attaches it to the NPCM7xx > GPIO controller. > > The GPIO transmitter takes in a GPIO contro

Re: [PATCH 1/5] migration: All this fields are unsigned

On 12/16/21 10:13, Juan Quintela wrote: > So printing it as %d is wrong. Notice that for the channel id, that > is an uint8_t, but I changed it anyways for consistency. > > Signed-off-by: Juan Quintela > --- > migration/multifd-zlib.c | 20 ++-- > migration/multifd-zstd.c | 24 +

Re: [PATCH 3/5] migration: ram_release_pages() always receive 1 page as argument

On 12/16/21 10:13, Juan Quintela wrote: > Remove the pages argument. And s/pages/page/ > > Signed-off-by: Juan Quintela > --- > migration/ram.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > -static void ram_release_pages(const char *rbname, uint64_t offset, int pages) > +sta

Re: [PATCH 2/5] migration: We only need last_stage in two places

On 12/16/21 10:13, Juan Quintela wrote: > And we are passing it all around. Just add a field to RAMState that > passes it. Splitting half of the description in the subject makes it hard to read. Better to repeat the subject as first description line. Matter of taste. > Signed-off-by: Juan Quinte

Re: [PATCH v4 04/14] vfio-user: define vfio-user-server object

On Wed, Dec 15, 2021 at 10:35:28AM -0500, Jagannathan Raman wrote: > diff --git a/qapi/qom.json b/qapi/qom.json > index ccd1167808..6001a9b8f0 100644 > --- a/qapi/qom.json > +++ b/qapi/qom.json > @@ -703,6 +703,20 @@ > { 'struct': 'RemoteObjectProperties', >'data': { 'fd': 'str', 'devid': 'str

Re: [PATCH] e1000: fix tx re-entrancy problem

Hi Jon, On 10/21/21 18:10, Jon Maloy wrote: > The fact that the MMIO handler is not re-entrant causes an infinite > loop under certain conditions: > > Guest write to TDT -> Loopback -> RX (DMA to TDT) -> TX > > We now eliminate the effect of this problem locally in e1000, by adding > a boolean

Re: [PATCH v2 01/25] python/aqmp: add __del__ method to legacy interface

15.12.2021 22:39, John Snow wrote: asyncio can complain *very* loudly if you forget to back out of things gracefully before the garbage collector starts destroying objects that contain live references to asyncio Tasks. The usual fix is just to remember to call aqmp.disconnect(), but for the sake

[PULL 1/8] s390: kvm: adjust diag318 resets to retain data

From: Collin Walling The CPNC portion of the diag318 data is erroneously reset during an initial CPU reset caused by SIGP. Let's go ahead and relocate the diag318_info field within the CPUS390XState struct such that it is only zeroed during a clear reset. This way, the CPNC will be retained for e

[PULL 3/8] s390x/pci: use a reserved ID for the default PCI group

From: Matthew Rosato The current default PCI group being used can technically collide with a real group ID passed from a hostdev. Let's instead use a group ID that comes from a special pool (0xF0-0xFF) that is architected to be reserved for simulated devices. Fixes: 28dc86a072 ("s390x/pci: use

[PULL 2/8] MAINTAINERS: update email address of Christian Borntraeger

From: Christian Borntraeger My borntrae...@de.ibm.com email is just a forwarder to the linux.ibm.com address. Let us remove the extra hop to avoid a potential source of errors. While at it, add the relevant email addresses to mailmap. Signed-off-by: Christian Borntraeger Message-Id: <202111261

[PULL 0/8] s390x patches (and one gitlab-CI fix)

Hi! The following changes since commit e630bc7ec9dda656a452ed28cac4d1e9ed605d71: Merge tag 'pull-block-2021-12-15' of git://repo.or.cz/qemu/armbru into staging (2021-12-15 12:14:44 -0800) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/s390x-2021-12-16 for

[PULL 8/8] gitlab-ci: Speed up the msys2-64bit job by using --without-default-devices

The new msys2-64bit job is often running for more than 50 minutes - and if the CI is currently loaded, it times out after 60 minutes. The job has been declared with a bigger timeout, but seems like this is getting ignored on the shared Gitlab-CI Windows runners, so we're currently seeing a lot of f

[PULL 4/8] s390x/pci: don't use hard-coded dma range in reg_ioat

From: Matthew Rosato Instead use the values from clp info, they will either be the hard-coded values or what came from the host driver via vfio. Fixes: 9670ee752727 ("s390x/pci: use a PCI Function structure") Signed-off-by: Matthew Rosato Reviewed-by: Eric Farman Reviewed-by: Pierre Morel Mes

[PULL 6/8] s390x/pci: add supported DT information to clp response

From: Matthew Rosato The DTSM is a mask that specifies which I/O Address Translation designation types are supported. Today QEMU only supports DT=1. Signed-off-by: Matthew Rosato Reviewed-by: Eric Farman Reviewed-by: Pierre Morel Message-Id: <20211203142706.427279-5-mjros...@linux.ibm.com> S

[PULL 7/8] hw: Add compat machines for 7.0

From: Cornelia Huck Add 7.0 machine types for arm/i440fx/q35/s390x/spapr. Signed-off-by: Cornelia Huck Message-Id: <20211208170241.110551-1-coh...@redhat.com> Acked-by: Cédric Le Goater Reviewed-by: Juan Quintela Signed-off-by: Thomas Huth --- hw/arm/virt.c | 9 - hw/c

[PULL 5/8] s390x/pci: use the passthrough measurement update interval

From: Matthew Rosato We may have gotten a measurement update interval from the underlying host via vfio -- Use it to set the interval via which we update the function measurement block. Fixes: 28dc86a072 ("s390x/pci: use a PCI Group structure") Signed-off-by: Matthew Rosato Reviewed-by: Eric Fa

Re: [PATCH v4 0/3] hw/block/fdc: Fix CVE-2021-20196

On 12/10/21 14:42, Kevin Wolf wrote: > Am 24.11.2021 um 17:15 hat Philippe Mathieu-Daudé geschrieben: >> Since v3: >> - Preliminary extract blk_create_empty_drive() >> - qtest checks qtest_check_clang_sanitizer() enabled >> - qtest uses null-co:// driver instead of file >> >> Philippe Mathieu-Daudé

Re: [PATCH v4 05/14] vfio-user: instantiate vfio-user context

On Wed, Dec 15, 2021 at 10:35:29AM -0500, Jagannathan Raman wrote: > +static void vfu_object_init_ctx(VfuObject *o, Error **errp) > +{ > +ERRP_GUARD(); > + > +if (o->vfu_ctx || !o->socket || !o->device || > +!phase_check(PHASE_MACHINE_READY)) { > +return; > +} > + >

Re: [PULL 31/33] tests/acpi: add test case for VIOT

On Wed, Dec 15, 2021 at 04:59:10PM -0800, Richard Henderson wrote: > On 12/15/21 2:40 AM, Peter Maydell wrote: > > From: Jean-Philippe Brucker > > > > Add two test cases for VIOT, one on the q35 machine and the other on > > virt. To test complex topologies the q35 test has two PCIe buses that > >

Re: [PATCH v4 04/14] vfio-user: define vfio-user-server object

On Wed, Dec 15, 2021 at 10:35:28AM -0500, Jagannathan Raman wrote: > +static void vfu_object_set_socket(Object *obj, Visitor *v, const char *name, > + void *opaque, Error **errp) > +{ > +VfuObject *o = VFU_OBJECT(obj); > + > +qapi_free_SocketAddress(o->socke

Re: [PATCH] block/file-posix: Simplify the XFS_IOC_DIOINFO handling

Am 15.12.2021 um 13:58 hat Thomas Huth geschrieben: > The handling for the XFS_IOC_DIOINFO ioctl is currently quite excessive: > This is not a "real" feature like the other features that we provide with > the "--enable-xxx" and "--disable-xxx" switches for the configure script, > since this does no

Re: [PATCH v2 04/25] python/aqmp: add SocketAddrT to package root

15.12.2021 22:39, John Snow wrote: It's a commonly needed definition, it can be re-exported by the root. Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

[PATCH] thunk: do not use HOST_* defines

Just use sizeof, avoiding the need to write down all the ABIs twice. Cc: Laurent Vivier Signed-off-by: Paolo Bonzini --- include/exec/user/thunk.h | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/include/exec/user/thunk.h b/include/exec/user/thunk.h index 300a84

Re: [PATCH v2 02/25] python/aqmp: handle asyncio.TimeoutError on execute()

15.12.2021 22:39, John Snow wrote: This exception can be injected into any await statement. If we are canceled via timeout, we want to clear the pending execution record on our way out. Hmm, but there are more await statements in the file, shouldn't we care about them too ? Signed-off-by: J

Re: [PATCH v2 05/25] python/aqmp: rename AQMPError to QMPError

15.12.2021 22:39, John Snow wrote: This is in preparation for renaming qemu.aqmp to qemu.qmp. I should have done this from this from the very beginning, but it's a convenient time to make sure this churn is taken care of. Signed-off-by: John Snow Honestly, I don't want to check how it interse

Re: [PATCH v2 13/25] scripts/cpu-x86-uarch-abi: fix CLI parsing

On Wed, Dec 15, 2021 at 02:39:27PM -0500, John Snow wrote: > Signed-off-by: John Snow > --- > scripts/cpu-x86-uarch-abi.py | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/p

Re: [PATCH v2 06/25] python/qemu-ga-client: update instructions to newer CLI syntax

I had to search a bit through the history to check this ) The commit ccd3b3b8112b670f "qemu-option: warn for short-form boolean options" may be noted here. And may be subject changed to "don't use deprecated syntax in comment" or something like this. server=on is not a *new* syntax I think. 1

Re: [PATCH v2 14/25] scripts/cpu-x86-uarch-abi: switch to AQMP

On Wed, Dec 15, 2021 at 02:39:28PM -0500, John Snow wrote: > Signed-off-by: John Snow > --- > scripts/cpu-x86-uarch-abi.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com

Re: [PATCH v2 03/25] python/aqmp: copy type definitions from qmp

15.12.2021 22:39, John Snow wrote: Copy the remaining type definitions from QMP into the qemu.aqmp.legacy module. Now, most users don't need to import anything else but qemu.aqmp.legacy. Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v2 06/25] python/qemu-ga-client: update instructions to newer CLI syntax

On Wed, Dec 15, 2021 at 02:39:20PM -0500, John Snow wrote: > Signed-off-by: John Snow > --- > python/qemu/qmp/qemu_ga_client.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com

Re: [PATCH v2 03/25] python/aqmp: copy type definitions from qmp

On Wed, Dec 15, 2021 at 02:39:17PM -0500, John Snow wrote: > Copy the remaining type definitions from QMP into the qemu.aqmp.legacy > module. Now, most users don't need to import anything else but > qemu.aqmp.legacy. I'm probably missing the historical discussion but it feels very wierd to be sayi

Re: [PATCH v10 3/3] cpus-common: implement dirty page limit on virtual CPU

Hyman Huang writes: [...] > So the final format of qmp we conclude are: > > case 1: setup vcpu 0 dirty page limit 100MB/s > set-vcpu-dirty-limit cpu-index=0 dirty-rate=100 > > case 2: setup all vcpu dirty page limit 100MB/s > set-vcpu-dirty-limit dirty-rate=100 > > case 3: cancel vcpu 0 dirty pa

Re: Redesign of QEMU startup & initial configuration

Paolo Bonzini writes: > On 12/14/21 12:48, Markus Armbruster wrote: >> Let's start with where we (hopefully) agree: > > More or less I do agree with this, except for a couple points below > where I think we disagree. > >> * We need a single, cohesive, low-level interface suitable for >> managem

Re: [PATCH] hw/acpi: Set memory regions to native endian as a work around

ping On Mon, Nov 08, 2021 at 08:33:01AM -0500, Michael S. Tsirkin wrote: > On Mon, Nov 08, 2021 at 02:05:42PM +0100, BALATON Zoltan wrote: > > When using ACPI on big endian machine (such as ppc/pegasos2 which has > > a VT8231 south bridge with ACPI) writes to ACPI registers come out > > byte swapp

Re: [PATCH v2 07/25] python/qmp: switch qemu-ga-client to AQMP

15.12.2021 22:39, John Snow wrote: Signed-off-by: John Snow Not simple to check, how much new behavior is equal to the old one.. And impossible to check, is everything updated that should be ) --- python/qemu/qmp/qemu_ga_client.py | 22 +++--- 1 file changed, 11 insertio

Re: [RFC PATCH 0/6] Removal of Aiocontext lock and usage of subtree drains in aborted transactions

Am 15.12.2021 um 13:34 hat Hanna Reitz geschrieben: > On 14.12.21 19:10, Emanuele Giuseppe Esposito wrote: > > > > > > On 13/12/2021 15:52, Stefan Hajnoczi wrote: > > > Off-topic: I don't understand the difference between the effects of > > > bdrv_drained_begin() and bdrv_subtree_drained_begin().

Re: [PATCH] docs: Add measurement calculation details to amd-memory-encryption.txt

On 14/12/2021 20:39, Daniel P. Berrangé wrote: > On Tue, Dec 14, 2021 at 01:59:10PM +, Dov Murik wrote: >> Add a section explaining how the Guest Owner should calculate the >> expected guest launch measurement for SEV and SEV-ES. >> >> Also update the name and link to the SEV API Spec docume

Re: [PATCH v4 06/14] vfio-user: find and init PCI device

On Wed, Dec 15, 2021 at 10:35:30AM -0500, Jagannathan Raman wrote: > @@ -150,6 +157,38 @@ static void vfu_object_init_ctx(VfuObject *o, Error > **errp) > +o->pci_dev = PCI_DEVICE(dev); ... > @@ -190,6 +229,8 @@ static void vfu_object_finalize(Object *obj) > > o->device = NULL; > > +

Re: [RFC qemu.qmp PATCH 00/24] Python: Fork qemu.qmp Python lib into independent repo

On Wed, Dec 15, 2021 at 04:06:10PM -0500, John Snow wrote: > Hi, this series is part of an effort to publish the qemu.qmp package on > PyPI. It is the second of three series to complete this work: > > (1) Switch the new Async QMP library in to python/qemu/qmp > --> (2) Fork python/qemu/qmp out

Re: [PATCH v2 08/25] python/qmp: switch qom tools to AQMP

15.12.2021 22:39, John Snow wrote: Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [RFC qemu.qmp PATCH 03/24] Update maintainer metadata

On Wed, Dec 15, 2021 at 04:06:13PM -0500, John Snow wrote: > I'm the primary author of this particular component; update the metadata > accordingly. > > Signed-off-by: John Snow > --- > setup.cfg | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/setup.cfg b/setup.cfg >

Re: [PATCH v2 09/25] python/qmp: switch qmp-shell to AQMP

15.12.2021 22:39, John Snow wrote: We have a replacement for async QMP, but it doesn't have feature parity yet. For now, then, port the old tool onto the new backend. Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v2 10/25] python: move qmp utilities to python/qemu/utils

15.12.2021 22:39, John Snow wrote: In order to upload a QMP package to PyPI, I want to remove any scripts that I am not 100% confident I want to support upstream, beyond our castle walls. Move most of our QMP utilities into the utils package so we can split them out from the PyPI upload. Signed

[PATCH v7] isa-applesmc: provide OSK forwarding on Apple hosts

On Apple hosts we can read AppleSMC OSK key directly from host's SMC and forward this value to QEMU Guest. New 'hostosk' property is added: `-device isa-applesmc,hostosk=on` The property is set to 'on' by default for machine version > 6.2 Apple licence allows use and run up to two additional co

Re: [RFC qemu.qmp PATCH 17/24] Makefile: add build and publish targets

On Wed, Dec 15, 2021 at 04:06:27PM -0500, John Snow wrote: > Signed-off-by: John Snow > --- > Makefile | 32 > 1 file changed, 32 insertions(+) > > diff --git a/Makefile b/Makefile > index 97d737a..81bfca8 100644 > --- a/Makefile > +++ b/Makefile > @@ -110,3 +110

Re: [PATCH v2 11/25] python: move qmp-shell under the AQMP package

15.12.2021 22:39, John Snow wrote: Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v2 00/25] Python: delete synchronous qemu.qmp package

On Wed, Dec 15, 2021 at 02:39:14PM -0500, John Snow wrote: > GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-qmp-legacy-switch > CI: https://gitlab.com/jsnow/qemu/-/pipelines/430491195 > > Hi, this series is part of an effort to publish the qemu.qmp package on > PyPI. It is the first of thr

Re: [PATCH v2 12/25] python/machine: permanently switch to AQMP

15.12.2021 22:39, John Snow wrote: Remove the QEMU_PYTHON_LEGACY_QMP environment variable, making the switch permanent. Update Exceptions and import paths as necessary. Signed-off-by: John Snow --- python/qemu/machine/machine.py | 18 +++--- python/qemu/machine/qtest.py | 2 +-

Re: [PATCH v11 08/10] ACPI ERST: qtest for ERST

On Wed, Dec 15, 2021 at 9:08 PM Eric DeVolder wrote: > > This change provides a qtest that locates and then does a simple > interrogation of the ERST feature within the guest. Other than couple of minor comments, > > Signed-off-by: Eric DeVolder Reviewed-by: Ani Sinha > --- > tests/qtest/er

Re: [PATCH v2 13/25] scripts/cpu-x86-uarch-abi: fix CLI parsing

15.12.2021 22:39, John Snow wrote: Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v2 14/25] scripts/cpu-x86-uarch-abi: switch to AQMP

15.12.2021 22:39, John Snow wrote: Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v2 15/25] scripts/render-block-graph: switch to AQMP

15.12.2021 22:39, John Snow wrote: Creating an instance of qemu.aqmp.ExecuteError is too involved here, so just drop the specificity down to a generic AQMPError. s/AQMPError/QMPError/ ? Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy --- scripts/render_block_grap

Re: [PATCH v2 16/25] scripts/bench-block-job: switch to AQMP

15.12.2021 22:39, John Snow wrote: For this commit, we only need to remove accommodations for the synchronous QMP library. Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v2 17/25] iotests/mirror-top-perms: switch to AQMP

15.12.2021 22:39, John Snow wrote: Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy --- Note: I still need to adjust the logging. The problem now is that the logging messages include the PID of the test process, so they need to be filtered out. I'll investigate that for

Re: [PATCH v2 18/25] iotests: switch to AQMP

15.12.2021 22:39, John Snow wrote: Simply import the type defition from the new location. Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.

Re: [PATCH v2 19/25] python: temporarily silence pylint duplicate-code warnings

15.12.2021 22:39, John Snow wrote: The next several commits copy some code from qemu.qmp to qemu.aqmp, then delete qemu.qmp. In the interim, to prevent test failures, the duplicate code detection needs to be silenced to prevent bisect problems with CI testing. Signed-off-by: John Snow Reviewe

Re: [PATCH v2 20/25] python/aqmp: take QMPBadPortError and parse_address from qemu.qmp

15.12.2021 22:39, John Snow wrote: Shift these definitions over from the qmp package to the async qmp package. Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v2 21/25] python/aqmp: fully separate from qmp.QEMUMonitorProtocol

15.12.2021 22:39, John Snow wrote: After this patch, qemu.aqmp.legacy.QEMUMonitorProtocol no longer inherits from qemu.qmp.QEMUMonitorProtocol. To do this, several inherited methods need to be explicitly re-defined. Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best

Re: [PATCH v4 07/14] vfio-user: run vfio-user context

On Wed, Dec 15, 2021 at 10:35:31AM -0500, Jagannathan Raman wrote: > @@ -114,6 +118,62 @@ static void vfu_object_set_device(Object *obj, const > char *str, Error **errp) > vfu_object_init_ctx(o, errp); > } > > +static void vfu_object_ctx_run(void *opaque) > +{ > +VfuObject *o = opaque;

Re: [PATCH v2 22/25] python/aqmp: copy qmp docstrings to qemu.aqmp.legacy

15.12.2021 22:39, John Snow wrote: Copy the docstrings out of qemu.qmp, adjusting them as necessary to more accurately reflect the current state of this class. Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PULL 31/33] tests/acpi: add test case for VIOT

On Thu, 16 Dec 2021 at 09:58, Jean-Philippe Brucker wrote: > > On Wed, Dec 15, 2021 at 04:59:10PM -0800, Richard Henderson wrote: > > On 12/15/21 2:40 AM, Peter Maydell wrote: > > > From: Jean-Philippe Brucker > > > > > > Add two test cases for VIOT, one on the q35 machine and the other on > > >

Re: [PATCH v2 23/25] python: remove the old QMP package

15.12.2021 22:39, John Snow wrote: Thank you for your service! Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

  1   2   3   4   >