Re: [PATCH 2/3] target/ppc: Remove 603e exception model

2021-12-09 Thread Cédric Le Goater
On 12/8/21 13:30, Fabiano Rosas wrote: The 603e uses the same exception code as 603 so we don't need a dedicated entry for it. This is only a removal of redundant code, no functional change. Signed-off-by: Fabiano Rosas QEMU really only supports the 604. I think we could drop the previous 60

Re: [PATCH v5 3/6] QIOChannelSocket: Implement io_writev_zerocopy & io_flush_zerocopy for CONFIG_LINUX

2021-12-09 Thread Leonardo Bras Soares Passos
Hello Daniel, On Fri, Dec 3, 2021 at 6:18 AM Daniel P. Berrangé wrote: > > On Fri, Dec 03, 2021 at 02:42:19AM -0300, Leonardo Bras Soares Passos wrote: > > Hello Daniel, > > > > On Tue, Nov 23, 2021 at 6:56 AM Daniel P. Berrangé > > wrote: > > > > > > On Tue, Nov 23, 2021 at 01:46:44AM -0300, L

Re: [PATCH v5 3/6] QIOChannelSocket: Implement io_writev_zerocopy & io_flush_zerocopy for CONFIG_LINUX

2021-12-09 Thread Leonardo Bras Soares Passos
On Thu, Dec 9, 2021 at 5:38 AM Leonardo Bras Soares Passos wrote: > > Hello Daniel, > > On Fri, Dec 3, 2021 at 6:18 AM Daniel P. Berrangé wrote: > > > > On Fri, Dec 03, 2021 at 02:42:19AM -0300, Leonardo Bras Soares Passos wrote: > > > Hello Daniel, > > > > > > On Tue, Nov 23, 2021 at 6:56 AM Dan

Re: [PATCH v5 6/6] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-12-09 Thread Leonardo Bras Soares Passos
Hello Juan, On Tue, Nov 16, 2021 at 1:08 PM Juan Quintela wrote: > > Leonardo Bras wrote: > > Implement zerocopy on nocomp_send_write(), by making use of QIOChannel > > zerocopy interface. > > > > Change multifd_send_sync_main() so it can distinguish each iteration sync > > from > > the setup a

Re: [PATCH 7/7] migration: Finer grained tracepoints for POSTCOPY_LISTEN

2021-12-09 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Wed, Dec 08, 2021 at 07:46:20PM +, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > The enablement of postcopy listening has a few steps, add a few > > > tracepoints to > > > be there ready for some basic measurements for

Re: [PATCH] target/ppc: powerpc_excp: Guard ALIGNMENT interrupt with CONFIG_TCG

2021-12-09 Thread Philippe Mathieu-Daudé
On 12/9/21 00:06, Fabiano Rosas wrote: > We cannot have TCG code in powerpc_excp because the function is called > from kvm-only code via ppc_cpu_do_interrupt: > > ../target/ppc/excp_helper.c:463:29: error: implicit declaration of > function ‘cpu_ldl_code’ [-Werror=implicit-function-declaration]

Re: [RFC] vhost-vdpa-net: add vhost-vdpa-net host device support

2021-12-09 Thread Stefan Hajnoczi
On Wed, Dec 08, 2021 at 01:20:10PM +0800, Longpeng(Mike) wrote: > From: Longpeng > > Hi guys, > > This patch introduces vhost-vdpa-net device, which is inspired > by vhost-user-blk and the proposal of vhost-vdpa-blk device [1]. > > I've tested this patch on Huawei's offload card: > ./x86_64-sof

[PATCH v1 0/1] virtio-block: switch to blk_get_max_hw_transfer

2021-12-09 Thread Or Ozeri
Since moving to qemu 6.1.0 we've been seeing disk failures inside a qemu guest VM. This happened when using if=virtio on a host /dev/nbdX device. Binary searching on qemu commit history, I found these errors start on this commit: Commit 18473467 file-posix: try BLKSECTGET on block devices too, d

Re: [PATCH v9 10/10] ACPI ERST: step 6 of bios-tables-test.c

2021-12-09 Thread Ani Sinha
On Fri, Dec 3, 2021 at 12:39 AM Eric DeVolder wrote: > > Following the guidelines in tests/qtest/bios-tables-test.c, this > is step 6. > > Below is the disassembly of tests/data/acpi/pc/ERST.acpierst. > > /* > * Intel ACPI Component Architecture > * AML/ASL+ Disassembler version 20180508 (64-

[PATCH v1 1/1] virtio-block: switch to blk_get_max_hw_transfer

2021-12-09 Thread Or Ozeri
The blk_get_max_hw_transfer API was recently added in 6.1.0. It allows querying an underlying block device its max transfer capability. This commit changes virtio-blk to use this. Signed-off-by: Or Ozeri --- hw/block/virtio-blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] sev: check which processor the ASK/ARK chain should match

2021-12-09 Thread Daniel P . Berrangé
On Tue, Nov 16, 2021 at 04:38:59PM -0500, Tyler Fanelli wrote: > The AMD ASK/ARK certificate chain differs between AMD SEV > processor generations. SEV capabilities should provide > which ASK/ARK certificate should be used based on the host > processor. > > Signed-off-by: Tyler Fanelli > --- > q

[PATCH v6 1/6] QIOChannel: Add io_writev_zero_copy & io_flush_zero_copy callbacks

2021-12-09 Thread Leonardo Bras
Adds io_writev_zero_copy and io_flush_zero_copy as optional callback to QIOChannelClass, allowing the implementation of zero copy writes by subclasses. How to use them: - Write data using qio_channel_writev_zero_copy(), - Wait write completion with qio_channel_flush_zero_copy(). Notes: As some z

[PATCH v6 0/6] MSG_ZEROCOPY + multifd

2021-12-09 Thread Leonardo Bras
This patch series intends to enable MSG_ZEROCOPY in QIOChannel, and make use of it for multifd migration performance improvement, by reducing cpu usage. Patch #1 creates new callbacks for QIOChannel, allowing the implementation of zero copy writing. Patch #2 reworks qio_channel_socket_writev() so

[PATCH v6 2/6] QIOChannelSocket: Add flags parameter for writing

2021-12-09 Thread Leonardo Bras
Change qio_channel_socket_writev() in order to accept flags, so its possible to selectively make use of sendmsg() flags. qio_channel_socket_writev() contents were moved to a helper function qio_channel_socket_writev_flags() which accepts an extra argument for flags. (This argument is passed direct

[PATCH v6 3/6] QIOChannelSocket: Implement io_writev_zero_copy & io_flush_zero_copy for CONFIG_LINUX

2021-12-09 Thread Leonardo Bras
For CONFIG_LINUX, implement the new optional callbacks io_write_zero_copy and io_flush_zero_copy on QIOChannelSocket, but enables it only when MSG_ZEROCOPY feature is available in the host kernel, which is checked on qio_channel_socket_connect_sync() qio_channel_socket_flush_zero_copy() was implem

[PATCH v6 4/6] migration: Add zero-copy parameter for QMP/HMP for Linux

2021-12-09 Thread Leonardo Bras
Add property that allows zero-copy migration of memory pages, and also includes a helper function migrate_use_zero_copy() to check if it's enabled. No code is introduced to actually do the migration, but it allow future implementations to enable/disable this feature. On non-Linux builds this para

[PATCH v6 5/6] migration: Add migrate_use_tls() helper

2021-12-09 Thread Leonardo Bras
A lot of places check parameters.tls_creds in order to evaluate if TLS is in use, and sometimes call migrate_get_current() just for that test. Add new helper function migrate_use_tls() in order to simplify testing for TLS usage. Signed-off-by: Leonardo Bras Reviewed-by: Juan Quintela --- migra

[PATCH v6 6/6] multifd: Implement zero copy write in multifd migration (multifd-zero-copy)

2021-12-09 Thread Leonardo Bras
Implement zero copy on nocomp_send_write(), by making use of QIOChannel zero copy interface. Change multifd_send_sync_main() so it can distinguish each iteration sync from the setup and the completion, so a flush_zero_copy() can be called after each iteration in order to make sure all dirty pages

Re: [PATCH v5 6/6] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-12-09 Thread Leonardo Bras Soares Passos
On Thu, Dec 9, 2021 at 5:51 AM Leonardo Bras Soares Passos wrote: > > Hello Juan, > > On Tue, Nov 16, 2021 at 1:08 PM Juan Quintela wrote: > > > > Leonardo Bras wrote: > > > Implement zerocopy on nocomp_send_write(), by making use of QIOChannel > > > zerocopy interface. > > > > > > Change multif

Re: [PATCH v3 0/6] aio-posix: split poll check from ready handler

2021-12-09 Thread Stefano Garzarella
On Tue, Dec 07, 2021 at 01:23:30PM +, Stefan Hajnoczi wrote: v3: - Fixed FUSE export aio_set_fd_handler() call that I missed and double-checked for any other missing call sites using Coccinelle [Rich] v2: - Cleaned up unused return values in nvme and virtio-blk [Stefano] - Documented try_pol

Re: [PATCH v8 0/4] tests/qtest: add some tests for virtio-net failover

2021-12-09 Thread Thomas Huth
On 08/12/2021 14.03, Laurent Vivier wrote: This series adds a qtest entry to test virtio-net failover feature. We check following error cases: - check missing id on device with failover_pair_id triggers an error - check a primary device plugged on a bus that doesn't support hotplug triggers

[PATCH for-7.0] gitlab-ci: Add cirrus-ci based tests for NetBSD and OpenBSD

2021-12-09 Thread Thomas Huth
Cirrus-CI provides KVM in their Linux containers, so we can also run our VM-based NetBSD and OpenBSD build jobs there. Since the VM installation might take a while, we only run the "help" target on the first invocation to avoid timeouts, and then only check the build during the next run, once the b

Re: [PATCH v2 1/1] multifd: Shut down the QIO channels to avoid blocking the send threads when they are terminated.

2021-12-09 Thread Juan Quintela
Li Zhang wrote: > When doing live migration with multifd channels 8, 16 or larger number, > the guest hangs in the presence of the network errors such as missing TCP > ACKs. > > At sender's side: > The main thread is blocked on qemu_thread_join, migration_fd_cleanup > is called because one thread

Re: [PATCH v4 14/22] target/riscv: Implement AIA xiselect and xireg CSRs

2021-12-09 Thread Anup Patel
On Thu, Nov 4, 2021 at 10:26 AM Alistair Francis wrote: > > On Tue, Oct 26, 2021 at 6:08 PM Anup Patel wrote: > > > > The AIA specification defines [m|s|vs]iselect and [m|s|vs]ireg CSRs > > which allow indirect access to interrupt priority arrays and per-HART > > IMSIC registers. This patch imple

LTP test perf_event_open02.c: possible rounding issue on aarch64 KVM

2021-12-09 Thread Petr Vorel
Hi, I have problem with LTP test perf_event_open02.c [1] on QEMU using KVM on openSUSE aarch64 kernel 5.15.5-1-default (not much different from stable kernel from kernel.org): # /opt/ltp/testcases/bin/perf_event_open02 ... perf_event_open02.c:104: TINFO: bench_work estimated loops = 8083 in 500 m

Re: [RFC PATCH v2 0/5] virtio: early detect 'modern' virtio

2021-12-09 Thread Halil Pasic
On Wed, 8 Dec 2021 13:56:19 -0500 "Michael S. Tsirkin" wrote: > On Fri, Nov 12, 2021 at 03:57:44PM +0100, Halil Pasic wrote: > > This is an early RFC for a transport specific early detecton of > > modern virtio, which is most relevant for transitional devices on big > > endian platforms, when dri

[PATCH v5 02/12] s390x: SCLP: reporting the maximum nested topology entries

2021-12-09 Thread Pierre Morel
The maximum nested topology entries is used by the guest to know how many nested topology are available on the machine. Currently, reporting SCLP reports 0, which is the equivalent of reporting the default value of 2. Let's use the default SCLP value of 2 and increase this value in the future patc

[PATCH v5 00/12] s390x: CPU Topology

2021-12-09 Thread Pierre Morel
Hi, The goal of this series is to implement CPU topology for S390, it improves the preceeding series with the implementation of books and drawers, of non uniform CPU topology and with documentation. To use these patches, you will need the Linux series version 5. You find it there: https://lkml.or

[PATCH v5 05/12] s390x: CPU topology: CPU topology migration

2021-12-09 Thread Pierre Morel
Both source and target must have the same configuration regarding the activation of Perform Topology Function and Store Topology System Information. Signed-off-by: Pierre Morel --- target/s390x/cpu.h | 2 ++ target/s390x/cpu_features_def.h.inc | 1 + target/s390x/cpu_models.c

[PATCH v5 03/12] s390x: topology: CPU topology objects and structures

2021-12-09 Thread Pierre Morel
We use new objects to have a dynamic administration of the CPU topology. The highest level object in this implementation is the s390 book and in this first implementation of CPU topology for S390 we have a single book. The book is built as a SYSBUS bridge during the CPU initialization. Other object

[PATCH v5 04/12] s390x: topology: implementating Store Topology System Information

2021-12-09 Thread Pierre Morel
The handling of STSI is enhanced with the interception of the function code 15 for storing CPU topology. Using the objects built during the pluging of CPU, we build the SYSIB 15_1_x structures. With this patch the maximum MNEST level is 2, this is also the only level allowed and only SYSIB 15_1_2

[PATCH v5 08/12] s390: topology: Adding books to STSI

2021-12-09 Thread Pierre Morel
Let's add STSI support for the container level 3, books, and provide the information back to the guest. Signed-off-by: Pierre Morel --- hw/s390x/cpu-topology.c | 147 +--- include/hw/s390x/cpu-topology.h | 20 - include/hw/s390x/sclp.h | 2 +- t

[PATCH v5 01/12] s390x: cpu topology: update linux headers

2021-12-09 Thread Pierre Morel
This patch is only here to facilitate the review and the testing. It should be updated from the Linux sources when available. The current Linux patch can be found at: https://lkml.org/lkml/2021/11/22/361 Signed-off-by: Pierre Morel --- linux-headers/linux/kvm.h | 2 ++ 1 file changed, 2 inserti

[PATCH v5 10/12] s390: topology: Adding drawers to STSI

2021-12-09 Thread Pierre Morel
Let's add STSI support for the container level 4, drawers, and provide the information back to the guest. Signed-off-by: Pierre Morel --- hw/s390x/cpu-topology.c | 137 +--- include/hw/s390x/cpu-topology.h | 19 - include/hw/s390x/sclp.h | 2 +-

[PATCH v5 07/12] s390: topology: Adding books to CPU topology

2021-12-09 Thread Pierre Morel
S390 CPU topology may have up to 5 topology containers. The first container above the cores is level 2, the sockets. We introduce here the books, book is the level containing sockets. Let's add books, level3, containers to the CPU topology. Signed-off-by: Pierre Morel --- hw/core/machine-smp.c

[PATCH v5 06/12] s390x: kvm: topology: interception of PTF instruction

2021-12-09 Thread Pierre Morel
When the host supports the CPU topology facility, the PTF instruction with function code 2 is interpreted by the SIE, provided that the userland hypervizor activates the interpretation by using the KVM_CAP_S390_CPU_TOPOLOGY KVM extension. The PTF instructions with function code 0 and 1 are interce

[PATCH v5 09/12] s390: topology: Adding drawers to CPU topology

2021-12-09 Thread Pierre Morel
S390 CPU topology may have up to 5 topology containers. The first container above the cores is level 2, the sockets, and the level 3, containing sockets are the books. We introduce here the drawers, drawers is the level containing books. Let's add drawers, level4, containers to the CPU topology.

[PATCH v5 12/12] s390: Topology: documentation

2021-12-09 Thread Pierre Morel
The use of the S390x CPU topology is explain in a new documentation file. Signed-off-by: Pierre Morel --- docs/system/s390x/numa-cpu-topology.rst | 273 1 file changed, 273 insertions(+) create mode 100644 docs/system/s390x/numa-cpu-topology.rst diff --git a/docs/syste

Re: [PATCH] virtio-blk: Fix clean up of host notifiers for single MR transaction.

2021-12-09 Thread Ani Sinha
On Thu, Dec 2, 2021 at 10:34 PM Mark Mielke wrote: > > Sorry... I missed copy maintainers and qemu-stable. This should be > considered a regression. > > -- Forwarded message - > From: Mark Mielke > Date: Thu, Dec 2, 2021 at 11:26 AM > Subject: [PATCH] virtio-blk: Fix clean up of h

[PATCH v5 11/12] s390x: topology: implementing numa for the s390x topology

2021-12-09 Thread Pierre Morel
S390x CPU Topology allows a non uniform repartition of the CPU inside the topology containers, sockets, books and drawers. We use numa to place the CPU inside the right topology container and report the non uniform topology to the guest. Note that s390x needs CPU0 to belong to the topology and co

[RFC] block-backend: prevent dangling BDS pointer in blk_drain()

2021-12-09 Thread Stefan Hajnoczi
The BlockBackend root child can change during bdrv_drained_begin() when aio_poll() is invoked. In fact the BlockDriverState can reach refcnt 0 and blk_drain() is left with a dangling BDS pointer. One example is scsi_device_purge_requests(), which calls blk_drain() to wait for in-flight requests to

Re: RFC: x86 memory map, where to put CXL ranges?

2021-12-09 Thread Alex Bennée
Jonathan Cameron writes: > Hi All, > > For CXL emulation we require a couple of types of memory range that > are then provided to the OS via the CEDT ACPI table. > > 1) CXL Host Bridge Structures point to CXL Host Bridge Component Registers. > Small regions for each CXL Host bridge that are map

Re: [RFC PATCH v2 32/44] tdx: add kvm_tdx_enabled() accessor for later use

2021-12-09 Thread Xiaoyao Li
On 7/23/2021 1:53 AM, Connor Kuehl wrote: On 7/7/21 7:55 PM, isaku.yamah...@gmail.com wrote: From: Isaku Yamahata Signed-off-by: Isaku Yamahata ---   include/sysemu/tdx.h  | 1 +   target/i386/kvm/kvm.c | 5 +   2 files changed, 6 insertions(+) diff --git a/include/sysemu/tdx.h b/include/s

Re: [PATCH 0/3] iotests: multiprocessing!!

2021-12-09 Thread Hanna Reitz
On 03.12.21 13:22, Vladimir Sementsov-Ogievskiy wrote: Hi all! Finally, I can not stand it any longer. So, I'm happy to present multiprocessing support for iotests test runner. Thanks, looks great! Applied to my block-next branch: https://gitlab.com/hreitz/qemu/-/commits/block-next Hanna

Re: [PATCH] target/ppc: powerpc_excp: Guard ALIGNMENT interrupt with CONFIG_TCG

2021-12-09 Thread Cédric Le Goater
On 12/9/21 00:06, Fabiano Rosas wrote: We cannot have TCG code in powerpc_excp because the function is called from kvm-only code via ppc_cpu_do_interrupt: ../target/ppc/excp_helper.c:463:29: error: implicit declaration of function ‘cpu_ldl_code’ [-Werror=implicit-function-declaration] Fortu

Re: LTP test perf_event_open02.c: possible rounding issue on aarch64 KVM

2021-12-09 Thread James Clark
On 09/12/2021 12:20, Petr Vorel wrote: > Hi, > > I have problem with LTP test perf_event_open02.c [1] on QEMU using KVM on > openSUSE aarch64 kernel 5.15.5-1-default (not much different from stable > kernel > from kernel.org): > > # /opt/ltp/testcases/bin/perf_event_open02 > ... > perf_event_o

[PATCH v2] Move the libssh setup from configure to meson.build

2021-12-09 Thread Thomas Huth
It's easier to do this in meson.build now. Signed-off-by: Thomas Huth --- v2: Added the missing "config_host_data.set('CONFIG_LIBSSH', libssh.found())" configure | 27 --- meson.build | 13 + meson_options.txt

Re: [PATCH v2] Move the libssh setup from configure to meson.build

2021-12-09 Thread Richard W.M. Jones
On Thu, Dec 09, 2021 at 03:48:01PM +0100, Thomas Huth wrote: > It's easier to do this in meson.build now. > > Signed-off-by: Thomas Huth > --- > v2: Added the missing "config_host_data.set('CONFIG_LIBSSH', libssh.found())" > > configure | 27 --- > m

[PATCH 2/8] MAINTAINERS: Add virtio-video section

2021-12-09 Thread Peter Griffin
Add myself as maintainer of the virtio-video files added in this series. Signed-off-by: Peter Griffin --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7543eb4d59..43c53aded8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2012,6 +2012,14

[PATCH 1/8] vhost-user-video: Add a README.md with cheat sheet of commands

2021-12-09 Thread Peter Griffin
Signed-off-by: Peter Griffin --- tools/vhost-user-video/README.md | 98 1 file changed, 98 insertions(+) create mode 100644 tools/vhost-user-video/README.md diff --git a/tools/vhost-user-video/README.md b/tools/vhost-user-video/README.md new file mode 100644 ind

[PATCH 0/8] virtio: Add vhost-user based Video decode

2021-12-09 Thread Peter Griffin
This series adds support for virtio-video decoder devices in Qemu and also provides a vhost-user-video vmm implementation. The vhost-user-video vmm currently parses virtio-vido v3 protocol (as that is what the Linux frontend driver implements). It then converts that to a v4l2 mem2mem stateful deco

[PATCH 5/8] standard-headers: Add virtio_video.h

2021-12-09 Thread Peter Griffin
Signed-off-by: Peter Griffin --- include/standard-headers/linux/virtio_video.h | 483 ++ 1 file changed, 483 insertions(+) create mode 100644 include/standard-headers/linux/virtio_video.h diff --git a/include/standard-headers/linux/virtio_video.h b/include/standard-headers/linu

[PATCH 4/8] vhost-user-video: add meson subdir build logic

2021-12-09 Thread Peter Griffin
Signed-off-by: Peter Griffin --- tools/meson.build | 9 + 1 file changed, 9 insertions(+) diff --git a/tools/meson.build b/tools/meson.build index 3e5a0abfa2..3314b5efc5 100644 --- a/tools/meson.build +++ b/tools/meson.build @@ -24,3 +24,12 @@ endif if have_virtiofsd subdir('virtiofs

[PATCH 7/8] hw/display: add vhost-user-video-pci

2021-12-09 Thread Peter Griffin
Add boiler plate code for vhost-user-video-pci. Example -device vhost-user-video-pci,chardev=video,id=video -chardev socket,path=video.sock,id=video Signed-off-by: Peter Griffin --- hw/display/vhost-user-video-pci.c | 82 +++ 1 file changed, 82 insertions(+) create

[PATCH 8/8] tools/vhost-user-video: Add initial vhost-user-video vmm

2021-12-09 Thread Peter Griffin
This vmm translates from virtio-video v3 protocol and writes to a v4l2 mem2mem stateful decoder/encoder device [1]. v3 was chosen as that is what the virtio-video Linux frontend driver implements. This allows for testing with the v4l2 vicodec test codec [2] module in the Linux kernel, and is inten

[PATCH 6/8] virtio_video: Add Fast Walsh-Hadamard Transform format

2021-12-09 Thread Peter Griffin
Linux vicodec (Virtual Codec) test driver in Linux implements FWHT. FWHT was designed to be fast and simple and to have characteristics of other video codecs and therefore face similar issues [1]. https://en.wikipedia.org/wiki/Fast_Walsh%E2%80%93Hadamard_transform Signed-off-by: Peter Griffin --

[PATCH 3/8] vhost-user-video: boiler plate code for vhost-user-video device

2021-12-09 Thread Peter Griffin
Signed-off-by: Peter Griffin --- hw/display/Kconfig | 5 + hw/display/meson.build | 3 + hw/display/vhost-user-video.c| 386 +++ include/hw/virtio/vhost-user-video.h | 41 +++ 4 files changed, 435 insertions(+) create mode 1006

Re: [PATCH v4 0/5] s390x: CPU Topology

2021-12-09 Thread Pierre Morel
Hi, This series is updated by a v5 series with documentation and numa extensions. Some changes have been made in some of the patches contained in this series too. Regards, Pierre On 11/17/21 17:48, Pierre Morel wrote: Hi, This series is a first part of the implementation of CPU topology fo

Re: [PATCH] target/ppc: powerpc_excp: Guard ALIGNMENT interrupt with CONFIG_TCG

2021-12-09 Thread Fabiano Rosas
Cédric Le Goater writes: > On 12/9/21 00:06, Fabiano Rosas wrote: >> We cannot have TCG code in powerpc_excp because the function is called >> from kvm-only code via ppc_cpu_do_interrupt: >> >> ../target/ppc/excp_helper.c:463:29: error: implicit declaration of >> function ‘cpu_ldl_code’ [-We

Re: [PATCH v2] Move the libssh setup from configure to meson.build

2021-12-09 Thread Thomas Huth
On 09/12/2021 15.55, Richard W.M. Jones wrote: On Thu, Dec 09, 2021 at 03:48:01PM +0100, Thomas Huth wrote: It's easier to do this in meson.build now. Signed-off-by: Thomas Huth --- v2: Added the missing "config_host_data.set('CONFIG_LIBSSH', libssh.found())" configure

Re: [PATCH] target/ppc: powerpc_excp: Guard ALIGNMENT interrupt with CONFIG_TCG

2021-12-09 Thread Cédric Le Goater
Richard, On 12/9/21 16:05, Fabiano Rosas wrote: Cédric Le Goater writes: On 12/9/21 00:06, Fabiano Rosas wrote: We cannot have TCG code in powerpc_excp because the function is called from kvm-only code via ppc_cpu_do_interrupt: ../target/ppc/excp_helper.c:463:29: error: implicit declarat

[PULL 1/1] block/nvme: fix infinite loop in nvme_free_req_queue_cb()

2021-12-09 Thread Stefan Hajnoczi
When the request free list is exhausted the coroutine waits on q->free_req_queue for the next free request. Whenever a request is completed a BH is scheduled to invoke nvme_free_req_queue_cb() and wake up waiting coroutines. 1. nvme_get_free_req() waits for a free request: while (q->free_req_

[PULL 0/1] Block patches

2021-12-09 Thread Stefan Hajnoczi
The following changes since commit a3607def89f9cd68c1b994e1030527df33aa91d0: Update version for v6.2.0-rc4 release (2021-12-07 17:51:38 -0800) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block-pull-request for you to fetch changes up to cf4fbc3030c974ff

Re: [PATCH] target/ppc: powerpc_excp: Guard ALIGNMENT interrupt with CONFIG_TCG

2021-12-09 Thread Fabiano Rosas
Philippe Mathieu-Daudé writes: > On 12/9/21 00:06, Fabiano Rosas wrote: >> We cannot have TCG code in powerpc_excp because the function is called >> from kvm-only code via ppc_cpu_do_interrupt: >> >> ../target/ppc/excp_helper.c:463:29: error: implicit declaration of >> function ‘cpu_ldl_code’

[PATCH] vvfat: Fix size of temporary qcow file

2021-12-09 Thread Kevin Wolf
The size of the qcow size was calculated so that only the FAT partition would fit on it, but not the whole disk. However, offsets relative to the whole disk are used to access it, so increase its size to be large enough for that. Signed-off-by: Kevin Wolf --- block/vvfat.c | 7 +++ 1 file ch

[PATCH] vvfat: Fix vvfat_write() for writes before the root directory

2021-12-09 Thread Kevin Wolf
The calculation in sector2cluster() is done relative to the offset of the root directory. Any writes to blocks before the start of the root directory (in particular, writes to the FAT) result in negative values, which are not handled correctly in vvfat_write(). This changes sector2cluster() to ret

Re: [PATCH v2] Move the libssh setup from configure to meson.build

2021-12-09 Thread Richard W.M. Jones
On Thu, Dec 09, 2021 at 04:08:24PM +0100, Thomas Huth wrote: > On 09/12/2021 15.55, Richard W.M. Jones wrote: > >On Thu, Dec 09, 2021 at 03:48:01PM +0100, Thomas Huth wrote: > >>It's easier to do this in meson.build now. > >> > >>Signed-off-by: Thomas Huth > >>--- > >> v2: Added the missing "conf

Re: [RFC] block-backend: prevent dangling BDS pointer in blk_drain()

2021-12-09 Thread Hanna Reitz
On 09.12.21 15:23, Stefan Hajnoczi wrote: The BlockBackend root child can change during bdrv_drained_begin() when aio_poll() is invoked. In fact the BlockDriverState can reach refcnt 0 and blk_drain() is left with a dangling BDS pointer. One example is scsi_device_purge_requests(), which calls b

Re: [PULL 0/1] Block patches

2021-12-09 Thread Peter Maydell
On Thu, 9 Dec 2021 at 15:21, Stefan Hajnoczi wrote: > > The following changes since commit a3607def89f9cd68c1b994e1030527df33aa91d0: > > Update version for v6.2.0-rc4 release (2021-12-07 17:51:38 -0800) > > are available in the Git repository at: > > https://gitlab.com/stefanha/qemu.git tags/b

Re: RFC: x86 memory map, where to put CXL ranges?

2021-12-09 Thread Jonathan Cameron via
On Thu, 09 Dec 2021 14:19:59 + Alex Bennée wrote: > Jonathan Cameron writes: > > > Hi All, > > > > For CXL emulation we require a couple of types of memory range that > > are then provided to the OS via the CEDT ACPI table. > > > > 1) CXL Host Bridge Structures point to CXL Host Bridge Comp

Re: [RFC] vhost-vdpa-net: add vhost-vdpa-net host device support

2021-12-09 Thread Stefano Garzarella
On Thu, Dec 09, 2021 at 09:16:58AM +, Stefan Hajnoczi wrote: On Wed, Dec 08, 2021 at 01:20:10PM +0800, Longpeng(Mike) wrote: From: Longpeng Hi guys, This patch introduces vhost-vdpa-net device, which is inspired by vhost-user-blk and the proposal of vhost-vdpa-blk device [1]. I've tested

Re: [PULL 04/13] target/rx: TCG helpers

2021-12-09 Thread Peter Maydell
On Tue, 17 Mar 2020 at 16:43, Philippe Mathieu-Daudé wrote: > > From: Yoshinori Sato > > Reviewed-by: Richard Henderson > Tested-by: Philippe Mathieu-Daudé > Signed-off-by: Yoshinori Sato > Signed-off-by: Richard Henderson > [PMD: Removed tlb_fill, extracted from patch of Yoshinori Sato > 'C

Re: [RFC] block-backend: prevent dangling BDS pointer in blk_drain()

2021-12-09 Thread Vladimir Sementsov-Ogievskiy
09.12.2021 18:45, Hanna Reitz wrote: On 09.12.21 15:23, Stefan Hajnoczi wrote: The BlockBackend root child can change during bdrv_drained_begin() when aio_poll() is invoked. In fact the BlockDriverState can reach refcnt 0 and blk_drain() is left with a dangling BDS pointer. One example is scsi_

Re: QEMU 6.2.0 and rhbz#1999878

2021-12-09 Thread Eduardo Lima
Thanks all, I saw the patch has been merged and is part of rc4. I'm removing it from the fedora package. On Fri, Dec 3, 2021 at 9:09 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 12/3/21 2:00 PM, Richard Henderson wrote: > >> Oh I see, it was indeed replaced by Richard Henderso

Re: [RFC] block-backend: prevent dangling BDS pointer in blk_drain()

2021-12-09 Thread Stefan Hajnoczi
On Thu, Dec 09, 2021 at 04:45:13PM +0100, Hanna Reitz wrote: > On 09.12.21 15:23, Stefan Hajnoczi wrote: > > The BlockBackend root child can change during bdrv_drained_begin() when > > aio_poll() is invoked. In fact the BlockDriverState can reach refcnt 0 > > and blk_drain() is left with a dangling

Re: [PATCH] mirror: Avoid assertion failed in mirror_run

2021-12-09 Thread Vladimir Sementsov-Ogievskiy
08.12.2021 12:52, wang.y...@zte.com.cn wrote: [CC-ing qemu-block, Vladimir, Kevin, and John – when sending patches, please look into the MAINTAINERS file or use the scripts/get_maintainer.pl script to find out who to CC on them. It’s very to overlook patches on qemu-devel :/] On 07.12.21 11:56,

Re: [PULL 0/1] Block patches

2021-12-09 Thread Stefan Hajnoczi
On Thu, Dec 09, 2021 at 03:46:29PM +, Peter Maydell wrote: > On Thu, 9 Dec 2021 at 15:21, Stefan Hajnoczi wrote: > > > > The following changes since commit a3607def89f9cd68c1b994e1030527df33aa91d0: > > > > Update version for v6.2.0-rc4 release (2021-12-07 17:51:38 -0800) > > > > are availabl

Re: [RFC] block-backend: prevent dangling BDS pointer in blk_drain()

2021-12-09 Thread Vladimir Sementsov-Ogievskiy
09.12.2021 19:32, Stefan Hajnoczi wrote: On Thu, Dec 09, 2021 at 04:45:13PM +0100, Hanna Reitz wrote: On 09.12.21 15:23, Stefan Hajnoczi wrote: The BlockBackend root child can change during bdrv_drained_begin() when aio_poll() is invoked. In fact the BlockDriverState can reach refcnt 0 and blk_

Re: [PULL 0/1] Block patches

2021-12-09 Thread Richard Henderson
On 12/9/21 8:34 AM, Stefan Hajnoczi wrote: I'm not running the release cycle this time around, but: it's already rc4, pull requests by this point need a clear justification in the cover letter for why they're really release critical. It's late, this isn't a show-stopper (block/nvme.c is not wid

Re: [PATCH] target/ppc: powerpc_excp: Guard ALIGNMENT interrupt with CONFIG_TCG

2021-12-09 Thread Fabiano Rosas
Cédric Le Goater writes: > Richard, > > On 12/9/21 16:05, Fabiano Rosas wrote: >> Cédric Le Goater writes: >> >>> On 12/9/21 00:06, Fabiano Rosas wrote: We cannot have TCG code in powerpc_excp because the function is called from kvm-only code via ppc_cpu_do_interrupt: ../

[PATCH] scripts: Explain the difference between linux-headers and standard-headers

2021-12-09 Thread Thomas Huth
If you don't know it, it's hard to figure out the difference between the linux-headers folder and the include/standard-headers folder. So let's add a short explanation to clarify the difference. Signed-off-by: Thomas Huth --- scripts/update-linux-headers.sh | 7 +++ 1 file changed, 7 inserti

[PATCH v2] Revert "target/ppc: Move SPR_DSISR setting to powerpc_excp"

2021-12-09 Thread Fabiano Rosas
This reverts commit 336e91f85332dda0ede4c1d15b87a19a0fb898a2. It breaks the --disable-tcg build: ../target/ppc/excp_helper.c:463:29: error: implicit declaration of function ‘cpu_ldl_code’ [-Werror=implicit-function-declaration] We should not have TCG code in powerpc_excp because some kvm-only

Re: [PATCH] scripts: Explain the difference between linux-headers and standard-headers

2021-12-09 Thread Peter Maydell
On Thu, 9 Dec 2021 at 17:34, Thomas Huth wrote: > > If you don't know it, it's hard to figure out the difference between > the linux-headers folder and the include/standard-headers folder. > So let's add a short explanation to clarify the difference. > > Signed-off-by: Thomas Huth > --- > script

Re: [PATCH v9 05/10] ACPI ERST: support for ACPI ERST feature

2021-12-09 Thread Eric DeVolder
Ani, inline responses below. eric On 12/9/21 00:29, Ani Sinha wrote: On Fri, Dec 3, 2021 at 12:39 AM Eric DeVolder wrote: This implements a PCI device for ACPI ERST. This implements the non-NVRAM "mode" of operation for ERST as it is supported by Linux and Windows. Few more comments on this

Re: [RFC PATCH v2 0/5] virtio: early detect 'modern' virtio

2021-12-09 Thread Michael S. Tsirkin
On Thu, Dec 09, 2021 at 02:29:25PM +0100, Halil Pasic wrote: > On Wed, 8 Dec 2021 13:56:19 -0500 > "Michael S. Tsirkin" wrote: > > > On Fri, Nov 12, 2021 at 03:57:44PM +0100, Halil Pasic wrote: > > > This is an early RFC for a transport specific early detecton of > > > modern virtio, which is mos

Re: [PATCH v9 10/10] ACPI ERST: step 6 of bios-tables-test.c

2021-12-09 Thread Eric DeVolder
Ani, thanks! eric On 12/9/21 03:29, Ani Sinha wrote: On Fri, Dec 3, 2021 at 12:39 AM Eric DeVolder wrote: Following the guidelines in tests/qtest/bios-tables-test.c, this is step 6. Below is the disassembly of tests/data/acpi/pc/ERST.acpierst. [...] Note that the contents of tests/data/q3

Re: [PATCH v9 05/10] ACPI ERST: support for ACPI ERST feature

2021-12-09 Thread Eric DeVolder
On 12/9/21 00:31, Ani Sinha wrote: On Wed, Dec 8, 2021 at 10:08 PM Eric DeVolder wrote: On 12/6/21 02:14, Ani Sinha wrote: On Fri, Dec 3, 2021 at 12:39 AM Eric DeVolder wrote: This implements a PCI device for ACPI ERST. This implements the non-NVRAM "mode" of operation for ERST as it i

[PATCH v10 00/10] acpi: Error Record Serialization Table, ERST, support for QEMU

2021-12-09 Thread Eric DeVolder
This patchset introduces support for the ACPI Error Record Serialization Table, ERST. For background and implementation information, please see docs/specs/acpi_erst.rst, which is patch 2/10. Suggested-by: Konrad Wilk Signed-off-by: Eric DeVolder --- v10: 9dec2021 - Addressed additional feedba

[PATCH v10 01/10] ACPI ERST: bios-tables-test.c steps 1 and 2

2021-12-09 Thread Eric DeVolder
Following the guidelines in tests/qtest/bios-tables-test.c, this change adds empty placeholder files per step 1 for the new ERST table, and excludes resulting changed files in bios-tables-test-allowed-diff.h per step 2. Signed-off-by: Eric DeVolder Acked-by: Igor Mammedov --- tests/data/acpi/mi

[PATCH v10 05/10] ACPI ERST: support for ACPI ERST feature

2021-12-09 Thread Eric DeVolder
This implements a PCI device for ACPI ERST. This implements the non-NVRAM "mode" of operation for ERST as it is supported by Linux and Windows. Signed-off-by: Eric DeVolder --- hw/acpi/Kconfig | 6 + hw/acpi/erst.c | 846 +++ hw/acpi/m

[PATCH v10 03/10] ACPI ERST: PCI device_id for ERST

2021-12-09 Thread Eric DeVolder
This change reserves the PCI device_id for the new ACPI ERST device. Signed-off-by: Eric DeVolder Acked-by: Igor Mammedov Acked-by: Ani Sinha --- include/hw/pci/pci.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index e7cdf2d..d3734b9 100644 -

[PATCH v10 08/10] ACPI ERST: qtest for ERST

2021-12-09 Thread Eric DeVolder
This change provides a qtest that locates and then does a simple interrogation of the ERST feature within the guest. Signed-off-by: Eric DeVolder --- tests/qtest/erst-test.c | 167 tests/qtest/meson.build | 2 + 2 files changed, 169 insertions(+

[PATCH v10 04/10] ACPI ERST: header file for ERST

2021-12-09 Thread Eric DeVolder
This change introduces the public defintions for ACPI ERST. Signed-off-by: Eric DeVolder Reviewed-by: Ani Sinha --- include/hw/acpi/erst.h | 19 +++ 1 file changed, 19 insertions(+) create mode 100644 include/hw/acpi/erst.h diff --git a/include/hw/acpi/erst.h b/include/hw/acpi

[PATCH v10 09/10] ACPI ERST: bios-tables-test testcase

2021-12-09 Thread Eric DeVolder
This change implements the test suite checks for the ERST table. Signed-off-by: Eric DeVolder Reviewed-by: Ani Sinha --- tests/qtest/bios-tables-test.c | 56 ++ 1 file changed, 56 insertions(+) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bi

[PATCH v10 02/10] ACPI ERST: specification for ERST support

2021-12-09 Thread Eric DeVolder
Information on the implementation of the ACPI ERST support. Signed-off-by: Eric DeVolder Acked-by: Ani Sinha --- docs/specs/acpi_erst.rst | 200 +++ 1 file changed, 200 insertions(+) create mode 100644 docs/specs/acpi_erst.rst diff --git a/docs/spec

[PATCH v10 06/10] ACPI ERST: build the ACPI ERST table

2021-12-09 Thread Eric DeVolder
This builds the ACPI ERST table to inform OSPM how to communicate with the acpi-erst device. Signed-off-by: Eric DeVolder --- hw/acpi/erst.c | 241 + 1 file changed, 241 insertions(+) diff --git a/hw/acpi/erst.c b/hw/acpi/erst.c index 81f5

[PATCH v10 10/10] ACPI ERST: step 6 of bios-tables-test.c

2021-12-09 Thread Eric DeVolder
Following the guidelines in tests/qtest/bios-tables-test.c, this is step 6. Below is the disassembly of tests/data/acpi/pc/ERST.acpierst. /* * Intel ACPI Component Architecture * AML/ASL+ Disassembler version 20180508 (64-bit version) * Copyright (c) 2000 - 2018 Intel Corporation * * D

[PATCH v10 07/10] ACPI ERST: create ACPI ERST table for pc/x86 machines

2021-12-09 Thread Eric DeVolder
This change exposes ACPI ERST support for x86 guests. Signed-off-by: Eric DeVolder Reviewed-by: Ani Sinha --- hw/i386/acpi-build.c | 15 +++ hw/i386/acpi-microvm.c | 15 +++ include/hw/acpi/erst.h | 5 + 3 files changed, 35 insertions(+) diff --git a/hw/i386/acpi

Re: [PATCH] scripts: Explain the difference between linux-headers and standard-headers

2021-12-09 Thread Thomas Huth
On 09/12/2021 18.44, Peter Maydell wrote: On Thu, 9 Dec 2021 at 17:34, Thomas Huth wrote: If you don't know it, it's hard to figure out the difference between the linux-headers folder and the include/standard-headers folder. So let's add a short explanation to clarify the difference. Signed-o

Re: [PATCH] audio: Add sndio backend

2021-12-09 Thread Volker Rümelin
Hi Brad, I tested the sndio backend on my Linux system and I found a bug in the sndio backend. The problem is that the function audio_run() can call the function sndio_enable_out() to disable audio playback. In the sndio_poll_event() function, audio_run() is called, which removes the poll ha

  1   2   >