Re: [PATCH v4 3/3] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

On Wed, Oct 27, 2021 at 03:47:18AM -0300, Leonardo Bras Soares Passos wrote: > On Wed, Oct 13, 2021 at 3:24 AM Peter Xu wrote: > > > > On Sat, Oct 09, 2021 at 04:56:13AM -0300, Leonardo Bras wrote: > > > diff --git a/qapi/migration.json b/qapi/migration.json > > > index 88f07baedd..c4890cbb54 1006

Re: [PATCH] hw/net: store timers for e1000 in vmstate

On 27.10.2021 07:05, Jason Wang wrote: On Tue, Oct 26, 2021 at 6:36 PM Pavel Dovgalyuk wrote: Setting timers randomly when vmstate is loaded breaks execution determinism. Therefore this patch allows saving mit and autoneg timers for e1000. It makes execution deterministic and allows snapshotti

Re: [PATCH v2 0/3] memory: memory_region_is_mapped() cleanups

On 27.10.21 05:53, Peter Xu wrote: > On Tue, Oct 26, 2021 at 06:06:46PM +0200, David Hildenbrand wrote: >> This is the follow-up of [1]. >> >> Playing with memory_region_is_mapped(), I realized that memory regions >> mapped via an alias behave a little bit "differently", as they don't have >> their

Re: [PATCH V4 1/3] net/filter: Remove vnet_hdr from filter-mirror and filter-redirector

Jason Wang writes: > On Wed, Oct 27, 2021 at 2:40 PM Zhang, Chen wrote: [...] >> > >> I wonder if we break management layer. If yes, maybe it's better to >> > >> keep the vnet_hdr_support here. >> > > >> > > Yes and no, With this series of patches, filters have ability to >> > > automatical

Re: [PATCH v7 0/4] VNC-related HMP/QMP fixes

On Tue, Oct 26, 2021 at 01:32:29PM +0200, Markus Armbruster wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> I'm done reviewing. David, care to have another look at the HMP part? > > > > Yep, looking good to me - is that going via qmp, hmp, or v

Re: [PATCH v3 1/3] smbios: Rename SMBIOS_ENTRY_POINT_* enums

On Tue, Oct 26, 2021 at 11:10:58AM -0400, Eduardo Habkost wrote: > Rename the enums to match the naming style used by QAPI, and to > use "32" and "64" instead of "20" and "31". This will allow us > to more easily move the enum to the QAPI schema later. > > About the naming choice: "SMBIOS 2.1 ent

[PATCH] qtest: fix 'expression is always false' build failure in qtest_has_accel()

If KVM is disabled or not present, qtest library build may fail with: libqtest.c: In function 'qtest_has_accel': comparison of unsigned expression < 0 is always false [-Werror=type-limits] for (i = 0; i < ARRAY_SIZE(targets); i++) { due to empty 'targets' array. Fix it by c

Re: [PATCH v4 6/8] iotests/300: avoid abnormal shutdown race condition

On 26.10.21 19:07, John Snow wrote: On Mon, Oct 25, 2021 at 9:20 AM Hanna Reitz wrote: On 13.10.21 23:57, John Snow wrote: > Wait for the destination VM to close itself instead of racing to shut it > down first, which produces different error log messages from AQMP > depen

Re: [PATCH] failover: specify an alternate MAC address

On Tue, Oct 26, 2021 at 05:03:05PM +0200, Laurent Vivier wrote: > If the guest driver doesn't support the STANDBY feature, by default > we keep the virtio-net device and don't hotplug the VFIO device, > but in some cases, user can prefer to use the VFIO device rather > than the virtio-net one. We c

Re: [PATCH v2 0/3] memory: memory_region_is_mapped() cleanups

On Wed, Oct 27, 2021 at 09:12:08AM +0200, David Hildenbrand wrote: > On 27.10.21 05:53, Peter Xu wrote: > > On Tue, Oct 26, 2021 at 06:06:46PM +0200, David Hildenbrand wrote: > >> This is the follow-up of [1]. > >> > >> Playing with memory_region_is_mapped(), I realized that memory regions > >> map

Re: [PATCH] MAINTAINERS: Split HPPA TCG vs HPPA machines/hardware

Le 27/10/2021 à 06:15, Philippe Mathieu-Daudé a écrit : Cc'ing qemu-trivial@ (patch reviewed) On 10/4/21 10:38, Philippe Mathieu-Daudé wrote: Hardware emulated models don't belong to the TCG MAINTAINERS section. Move them to the 'HP-PARISC Machines' section. Signed-off-by: Philippe Mathieu-Dau

Re: [PATCH 8/8] x86-iommu: Fail early if vIOMMU specified after vfio-pci

On Tue, Oct 26, 2021 at 05:11:39PM +0200, Igor Mammedov wrote: > On Fri, 22 Oct 2021 10:14:29 +0800 > Peter Xu wrote: > > > Hi, Alex, > > > > On Thu, Oct 21, 2021 at 04:30:39PM -0600, Alex Williamson wrote: > > > On Thu, 21 Oct 2021 18:42:59 +0800 > > > Peter Xu wrote: > > > > > > > Scan the

Re: [PATCH] qtest: fix 'expression is always false' build failure in qtest_has_accel()

On Wed, Oct 27, 2021 at 03:45:42AM -0400, Igor Mammedov wrote: > If KVM is disabled or not present, qtest library build > may fail with: >libqtest.c: In function 'qtest_has_accel': > comparison of unsigned expression < 0 is always false > [-Werror=type-limits] > for (i = 0;

Re: [PATCH v2 1/4] qemu-img: implement compare --stat

On 26.10.21 11:18, Vladimir Sementsov-Ogievskiy wrote: 26.10.2021 11:47, Hanna Reitz wrote: On 26.10.21 09:53, Vladimir Sementsov-Ogievskiy wrote: 25.10.2021 19:40, Hanna Reitz wrote: On 21.10.21 12:12, Vladimir Sementsov-Ogievskiy wrote: With new option qemu-img compare will not stop at firs

Re: [PATCH] target/m68k: Optimize shift_mem() using extract() TCG opcode

On 10/3/21 17:30, Richard Henderson wrote: > On 10/3/21 10:24 AM, Philippe Mathieu-Daudé wrote: >> When running the scripts/coccinelle/tcg_gen_extract.cocci >> Coccinelle semantic patch on target/m68k/, we get: >> >> [DBG] candidate at target/m68k/translate.c:3668 >> >> Manually inspect and re

Re: Deprecate the ppc405 boards in QEMU? (was: [PATCH v3 4/7] MAINTAINERS: Orphan obscure ppc platforms)

I am raising this because the nanoMIPS support is in deprecated state since more than 2 releases, but it is still in-tree and I try to keep it functional. However, since no toolchain reached mainstream GCC/LLVM it is not easy to maintain. By keeping it in that state we give some time to other comm

Re: [PATCH 1/1] gitlab-ci: Only push docker images to registry from /master branch

On Wed, Oct 27, 2021 at 08:01:07AM +0200, Thomas Huth wrote: > On 26/10/2021 16.55, Philippe Mathieu-Daudé wrote: > > Users expect images pulled from registry.gitlab.com/qemu-project/qemu/ > > to be stable. QEMU repository workflow pushes merge candidates to > > the /staging branch, and on success

Re: [PATCH 0/3] hw/input/lasips2: QOM'ify the Lasi PS/2

Le 27/10/2021 à 07:11, Philippe Mathieu-Daudé a écrit : Cc'ing qemu-trivial@ (fully reviewed). On 9/20/21 08:40, Philippe Mathieu-Daudé wrote: Slowly nuking non-QOM devices: Lasi PS/2's turn. Philippe Mathieu-Daudé (3): hw/input/lasips2: Fix typos in function names hw/input/lasips2: Move

Re: [PATCH v7 0/4] VNC-related HMP/QMP fixes

* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> I'm done reviewing. David, care to have another look at the HMP part? > > > > Yep, looking good to me - is that going via qmp, hmp, or vnc ? > > Either is

Re: [PATCH-for-6.0.1 0/2] gitlab-ci: Only push docker images to mainstream registry from /master

On Wed, Oct 27, 2021 at 07:26:54AM +0200, Philippe Mathieu-Daudé wrote: > Hi Michael, > > 2 more patches to avoid gitlab-ci mayhem when you push the > stable tags. See this cover for more info: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg846861.html Please don't push this to stable -

Re: [PATCH 1/1] gitlab-ci: Only push docker images to registry from /master branch

Hi Thomas, On 10/27/21 08:01, Thomas Huth wrote: > On 26/10/2021 16.55, Philippe Mathieu-Daudé wrote: >> Users expect images pulled from registry.gitlab.com/qemu-project/qemu/ >> to be stable. QEMU repository workflow pushes merge candidates to >> the /staging branch, and on success the same commi

[PATCH] Fix tcg_out_vec_op argument type

Newly defined tcg_out_vec_op (34ef767609 tcg/s390x: Add host vector framework) for s390x uses pointer argument definition. This fails on gcc 11 as original declaration uses array argument: In file included from ../tcg/tcg.c:430: /builddir/build/BUILD/qemu-6.1.50/tcg/s390x/tcg-target.c.inc:2702:42:

[PATCH v3 2/2] vfio/common: Add a trace point when a MMIO RAM section cannot be mapped

The MSI-X structures of some devices and other non-MSI-X structures may be in the same BAR. They may share one host page, especially in the case of large page granularity, such as 64K. For example, MSIX-Table size of 82599 NIC is 0x30 and the offset in Bar 3(size 64KB) is 0x0. vfio_listener_region

[PATCH v3 1/2] vfio/pci: Add support for mmapping sub-page MMIO BARs after live migration

We can expand MemoryRegions of sub-page MMIO BARs in vfio_pci_write_config() to improve IO performance for some devices. However, the MemoryRegions of destination VM are not expanded any more after live migration. Because their addresses have been updated in vmstate_load_state() (vfio_pci_load_conf

[PATCH v3 0/2] vfio: Some fixes about vfio-pci MMIO BARs mapping

This series include patches as below: Patch 1: - Added support for mmapping sub-page MMIO BAR after live migration to improve IO performance for some devices Patch 2: - Added a trace point to informe users when a MMIO RAM section cannot be mapped History: v2 -> v3: - Modify commit message [Er

Re: [PATCH v2 1/3] file-posix: add `aio-max-batch` option

On Tue, Oct 26, 2021 at 06:23:44PM +0200, Stefano Garzarella wrote: > Commit d7ddd0a161 ("linux-aio: limit the batch size using > `aio-max-batch` parameter") added a way to limit the batch size > of Linux AIO backend for the entire AIO context. > > The same AIO context can be shared by multiple de

Re: [PATCH v2 1/3] file-posix: add `aio-max-batch` option

On Wed, Oct 27, 2021 at 06:28:51AM +0200, Markus Armbruster wrote: Stefano Garzarella writes: Commit d7ddd0a161 ("linux-aio: limit the batch size using `aio-max-batch` parameter") added a way to limit the batch size of Linux AIO backend for the entire AIO context. The same AIO context can be

Re: [PATCH] target/avr: Optimize various functions using extract opcode

hi Philippe how was it tested? On Wed, Oct 27, 2021 at 7:42 AM Philippe Mathieu-Daudé wrote: > Hi Richard, > > On 10/3/21 17:24, Richard Henderson wrote: > > On 10/3/21 10:21 AM, Philippe Mathieu-Daudé wrote: > >> When running the scripts/coccinelle/tcg_gen_extract.cocci > >> Coccinelle semanti

Re: [PATCH 3/6] hw/sh4: Change debug printfs to traces

On Tue, 26 Oct 2021, Richard Henderson wrote: On 10/26/21 6:32 PM, BALATON Zoltan wrote: +trace_sh_serial("write", size, offs, val); switch (offs) { case 0x00: /* SMR */ s->smr = val & ((s->feat & SH_SERIAL_FEAT_SCIF) ? 0x7b : 0xff); @@ -302,10 +298,7 @@ static uint64_t

[PATCH v2] failover: specify an alternate MAC address

If the guest driver doesn't support the STANDBY feature, by default we keep the virtio-net device and don't hotplug the VFIO device, but in some cases, user can prefer to use the VFIO device rather than the virtio-net one. We can't unplug the virtio-net device (because on migration it is expected o

Re: [PATCH] Fix tcg_out_vec_op argument type

On 10/27/21 10:56, Miroslav Rezanina wrote: > Newly defined tcg_out_vec_op (34ef767609 tcg/s390x: Add host vector framework) > for s390x uses pointer argument definition. > This fails on gcc 11 as original declaration uses array argument: > > In file included from ../tcg/tcg.c:430: > /builddir/bui

Re: [PATCH-for-6.0.1 0/2] gitlab-ci: Only push docker images to mainstream registry from /master

+Richard/Peter On 10/27/21 10:49, Daniel P. Berrangé wrote: > On Wed, Oct 27, 2021 at 07:26:54AM +0200, Philippe Mathieu-Daudé wrote: >> Hi Michael, >> >> 2 more patches to avoid gitlab-ci mayhem when you push the >> stable tags. See this cover for more info: >> https://www.mail-archive.com/qemu-d

Re: [PATCH v2] failover: specify an alternate MAC address

On 10/27/21 11:59, Laurent Vivier wrote: > If the guest driver doesn't support the STANDBY feature, by default > we keep the virtio-net device and don't hotplug the VFIO device, > but in some cases, user can prefer to use the VFIO device rather > than the virtio-net one. We can't unplug the virtio-

Re: MMIO/PIO dispatch file descriptors (ioregionfd) design discussion

On Tue, Oct 26, 2021 at 08:01:39PM +0100, John Levon wrote: > On Mon, Oct 25, 2021 at 08:21:22AM -0700, Elena wrote: > > > > I'm curious what approach you want to propose for QEMU integration. A > > > while back I thought about the QEMU API. It's possible to implement it > > > along the lines of t

Re: [PATCH-for-6.0.1 0/2] gitlab-ci: Only push docker images to mainstream registry from /master

On Wed, Oct 27, 2021 at 12:09:39PM +0200, Philippe Mathieu-Daudé wrote: > +Richard/Peter > > On 10/27/21 10:49, Daniel P. Berrangé wrote: > > On Wed, Oct 27, 2021 at 07:26:54AM +0200, Philippe Mathieu-Daudé wrote: > >> Hi Michael, > >> > >> 2 more patches to avoid gitlab-ci mayhem when you push th

Re: [PATCH v4 0/8] qapi: Add support for aliases

Am 26.10.2021 um 23:23 hat John Snow geschrieben: > On Fri, Sep 17, 2021 at 12:13 PM Kevin Wolf wrote: > > > This series introduces alias definitions for QAPI object types (structs > > and unions). > > > > This allows using the same QAPI type and visitor even when the syntax > > has some variatio

Re: [RFC 0/2] tls: add macros for coroutine-safe TLS variables

Am 26.10.2021 um 19:10 hat Richard Henderson geschrieben: > On 10/26/21 9:34 AM, Stefan Hajnoczi wrote: > > On Tue, Oct 26, 2021 at 08:10:16AM -0700, Richard Henderson wrote: > > > On 10/26/21 6:22 AM, Stefan Hajnoczi wrote: > > > > If "safe" TLS variables are opt-in then we'll likely have obscure

Re: [PATCH 04/33] tests/tcg/mips: Run MSA opcodes tests on user-mode emulation

On 10/23/21 23:47, Philippe Mathieu-Daudé wrote: > The following commits added various user-mode tests > for various MSA instructions: > > - 0fdd986a6c8 ("Add tests for MSA integer add instructions") > - 1be82d89011 ("Add tests for MSA integer average instructions") > - 1d336c87a3c ("Add tests

Re: Deprecate the ppc405 boards in QEMU? (was: [PATCH v3 4/7] MAINTAINERS: Orphan obscure ppc platforms)

Hi Cédric, Le 27/10/2021 à 10:40, Cédric Le Goater a écrit : I am raising this because the nanoMIPS support is in deprecated state since more than 2 releases, but it is still in-tree and I try to keep it functional. However, since no toolchain reached mainstream GCC/LLVM it is not easy to mainta

Re: Deprecate the ppc405 boards in QEMU? (was: [PATCH v3 4/7] MAINTAINERS: Orphan obscure ppc platforms)

On 10/27/21 12:42, Christophe Leroy wrote: > Le 27/10/2021 à 10:40, Cédric Le Goater a écrit : > I am raising this because the nanoMIPS support is in deprecated state > since more than 2 releases, but it is still in-tree and I try to keep > it functional. However, since no toolchain rea

Re: [PATCH] e1000e: Added ICR clearing by corresponding IMS bit.

Hi, Let's make things clear. At first, I've decided to fix the issue in the linux e1000e driver. ( https://lists.osuosl.org/pipermail/intel-wired-lan/Week-of-Mon-20200413/019497.html ) Original driver developers suggest to fix the issue on qemu and assures that driver works correctly on real hw. I'

Re: [PATCH v5 2/8] python/machine: Handle QMP errors on close more meticulously

Am 26.10.2021 um 19:56 hat John Snow geschrieben: > To use the AQMP backend, Machine just needs to be a little more diligent > about what happens when closing a QMP connection. The operation is no > longer a freebie in the async world; it may return errors encountered in > the async bottom half on

Re: [PATCH 1/1] gitlab-ci: Only push docker images to registry from /master branch

Hi, > This scenario a tricky problem, and I'm not seeing an easy answer to it > so far. Only exclude stable branches? take care, Gerd

[PATCH v8 1/8] virtio: drop name parameter for virtio_init()

This patch drops the name parameter for the virtio_init function. The pair between the numeric device ID and the string device ID (name) of a virtio device already exists, but not in a way that lets us map between them. This patch will let us do this and removes the need for the name parameter in

[PATCH v8 7/8] qmp: add QMP command x-debug-virtio-queue-element

From: Laurent Vivier This new command shows the information of a VirtQueue element. Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 9 +++ hw/virtio/virtio.c | 154 qapi/virtio.json| 204 +

[PATCH v8 0/8] hmp,qmp: Add commands to introspect virtio devices

This series introduces new QMP/HMP commands to dump the status of a virtio device at different levels. [Jonah: Rebasing previous patchset from Oct. 5 (v7). Original patches are from Laurent Vivier from May 2020. Rebase from v7 to v8 includes an additional assert to make sure we're not returnin

[PATCH v8 2/8] virtio: add vhost support for virtio devices

This patch adds a get_vhost() callback function for VirtIODevices that returns the device's corresponding vhost_dev structure if the vhost device is running. This patch also adds a vhost_started flag for VirtIODevices. Previously, a VirtIODevice wouldn't be able to tell if its corresponding vhost

[PATCH v8 6/8] qmp: add QMP commands for virtio/vhost queue-status

From: Laurent Vivier These new commands show the internal status of a VirtIODevice's VirtQueue and a vhost device's vhost_virtqueue (if active). Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 14 +++ hw/virtio/virtio.c | 103 +++ qapi/virtio.json| 268 +

Re: [PATCH 1/1] gitlab-ci: Only push docker images to registry from /master branch

On Wed, Oct 27, 2021 at 01:35:25PM +0200, Gerd Hoffmann wrote: > Hi, > > > This scenario a tricky problem, and I'm not seeing an easy answer to it > > so far. > > Only exclude stable branches? The stable branches issue is just one of the bugs - the bigger bug is that we're publishing container

[PATCH v8 3/8] qmp: add QMP command x-debug-query-virtio

From: Laurent Vivier This new command lists all the instances of VirtIODevice with their QOM paths and virtio type/name. Signed-off-by: Jonah Palmer --- hw/virtio/meson.build | 2 ++ hw/virtio/virtio-stub.c| 14 ++ hw/virtio/virtio.c | 27 +++ include/

Re: [PATCH 0/1] gitlab-ci: Only push docker images to mainstream registry from /master

On Tue, Oct 26, 2021 at 04:55:08PM +0200, Philippe Mathieu-Daudé wrote: > Hi, > > I guess I got very unlucky because I happened to pull the docker > images from the mainstream registry in a very short time frame > where they jumped back in time... Then I kept using them to run > my tests during 1

Re: [PATCH v3] i386: docs: Briefly describe KVM PV features

Igor Mammedov writes: > On Mon, 4 Oct 2021 16:04:45 +0200 > Vitaly Kuznetsov wrote: > Thanks for the review! As I can see, the patch already made it to 'master': commit 7f7c8d0ce3630849a4df3d627b11de354fcb3bb0 Author: Vitaly Kuznetsov Date: Mon Oct 4 16:04:45 2021 +0200 i386: docs: Br

Re: [PATCH v8 0/8] hmp, qmp: Add commands to introspect virtio devices

On Wed, Oct 27, 2021 at 07:41:41AM -0400, Jonah Palmer wrote: > This series introduces new QMP/HMP commands to dump the status of a > virtio device at different levels. > > [Jonah: Rebasing previous patchset from Oct. 5 (v7). Original patches > are from Laurent Vivier from May 2020. > > Rebase

[PATCH v8 4/8] qmp: add QMP command x-debug-virtio-status

From: Laurent Vivier This new command shows the status of a VirtIODevice, including its corresponding vhost device status (if active). Next patch will improve output by decoding feature bits, including vhost device's feature bits (backend, protocol, acked, and features). Also will decode status

Re: [PATCH v8 5/8] qmp: decode feature & status bits in virtio-status

On 27.10.21 13:41, Jonah Palmer wrote: > From: Laurent Vivier > > Display feature names instead of bitmaps for host, guest, and > backend for VirtIODevice. > > Display status names instead of bitmaps for VirtIODevice. > > Display feature names instead of bitmaps for backend, protocol, > acked,

[PATCH v8 5/8] qmp: decode feature & status bits in virtio-status

From: Laurent Vivier Display feature names instead of bitmaps for host, guest, and backend for VirtIODevice. Display status names instead of bitmaps for VirtIODevice. Display feature names instead of bitmaps for backend, protocol, acked, and features (hdev->features) for vhost devices. Decode

[PATCH v8 8/8] hmp: add virtio commands

From: Laurent Vivier This patch implements the HMP versions of the virtio QMP commands. Signed-off-by: Jonah Palmer --- docs/system/monitor.rst | 2 + hmp-commands-virtio.hx | 250 ++ hmp-commands.hx | 10 ++ hw/virtio/virtio.c | 355 +++

Re: [PATCH v2 2/3] memory: Make memory_region_is_mapped() succeed when mapped via an alias

On 26.10.21 19:00, Philippe Mathieu-Daudé wrote: > On 10/26/21 18:06, David Hildenbrand wrote: >> memory_region_is_mapped() currently does not return "true" when a memory >> region is mapped via an alias. >> >> Assuming we have: >> alias (A0) -> alias (A1) -> region (R0) >> Mapping A0 would cur

Re: [PATCH v8 5/8] qmp: decode feature & status bits in virtio-status

On 27/10/2021 13:59, David Hildenbrand wrote: On 27.10.21 13:41, Jonah Palmer wrote: From: Laurent Vivier Display feature names instead of bitmaps for host, guest, and backend for VirtIODevice. Display status names instead of bitmaps for VirtIODevice. Display feature names instead of bitmaps

Re: [PATCH 16/33] target/ppc: Implement Vector Insert Word from GPR using Immediate insns

On 26/10/2021 15:45, Paul A. Clarke wrote: On Tue, Oct 26, 2021 at 09:58:15AM -0700, Richard Henderson wrote: On 10/26/21 7:33 AM, Matheus K. Ferst wrote: It says that "if UIM is greater than N, the result is undefined." My first read was also that the outcome is "boundedly undefined," but I gu

Re: [PATCH V6 00/27] Live Update

Soon. I'll aim for next week. Thanks for your continued interest! - Steve On 10/27/2021 2:16 AM, Zheng Chuan wrote: > Hi, Steve. > Any updates for this series?

Re: [PATCH 0/1] gitlab-ci: Only push docker images to mainstream registry from /master

Hi, > Notably the latter is more restrictive that git branch names. We could > assume users always have "sensible" branch names that are less than > 128 chars and only alpha-num characters plus dash/underscore. This > would be fine for my personal branch naming, but I wonder if anyone > uses wie

Re: [PATCH 0/2] Fix mtfsf, mtfsfi and mtfsb1 bug

CC'ing the reporter On 20/10/2021 09:57, Lucas Mateus Castro (alqotel) wrote: From: "Lucas Mateus Castro (alqotel)" The instructions mtfsf, mtfsfi and mtfsb, when called, fail to set the FI bit (bit 46 in the FPSCR) and can set to 1 the reserved bit 52 of the FPSCR, as reported in https://gitl

Re: [RFC 0/2] tls: add macros for coroutine-safe TLS variables

On Tue, Oct 26, 2021 at 10:10:44AM -0700, Richard Henderson wrote: > On 10/26/21 9:34 AM, Stefan Hajnoczi wrote: > > On Tue, Oct 26, 2021 at 08:10:16AM -0700, Richard Henderson wrote: > > > On 10/26/21 6:22 AM, Stefan Hajnoczi wrote: > > > > If "safe" TLS variables are opt-in then we'll likely have

Re: [PATCH 0/1] gitlab-ci: Only push docker images to mainstream registry from /master

On Wed, Oct 27, 2021 at 02:26:58PM +0200, Gerd Hoffmann wrote: > Hi, > > > Notably the latter is more restrictive that git branch names. We could > > assume users always have "sensible" branch names that are less than > > 128 chars and only alpha-num characters plus dash/underscore. This > > wou

[PATCH v1 06/12] memory-device: Generalize memory_device_used_region_size()

Let's generalize traversal of all plugged memory devices to collect information in the context of memory_device_check_addable() to prepare for future changes. Signed-off-by: David Hildenbrand --- hw/mem/memory-device.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-)

[PATCH v1 11/12] virtio-mem: Set the RamDiscardManager for the RAM memory region earlier

Let's set the RamDiscardManager earlier, logically before we expose the RAM memory region to the system. This is a preparation for further changes and is logically cleaner: before we expose the RAM memory region to migration code, make sure we have the RamDiscardManager setup. Signed-off-by: David

[PATCH v1 05/12] memory-device: Move memory_device_check_addable() directly into memory_device_pre_plug()

Move it out of memory_device_get_free_addr(), which is cleaner and prepares for future changes. Signed-off-by: David Hildenbrand --- hw/mem/memory-device.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c index 7f

Re: MMIO/PIO dispatch file descriptors (ioregionfd) design discussion

On Wed, Oct 27, 2021 at 11:15:35AM +0100, Stefan Hajnoczi wrote: > > > I like this approach as well. > > > As you have mentioned, the device emulation code with first approach > > > does have to how to handle the region accesses. The second approach will > > > make things more transparent. Let me

[PATCH v1 07/12] memory-device: Support memory devices that dynamically consume multiple memslots

We want to support memory devices that have a container as device memory region, and (dynamically) map individual chunks into that container resulting in multiple memslots getting consumed by such a device. So we want to support memory devices that require a) multiple memslots and b) dynamically ma

[PATCH v1 08/12] vhost: Respect reserved memslots for memory devices when realizing a vhost device

Make sure that the current reservations can be fulfilled, otherwise we might run out of memslots later when memory devices start actually using the reserved memslots and crash. Signed-off-by: David Hildenbrand --- hw/virtio/vhost.c | 13 + 1 file changed, 9 insertions(+), 4 deletions

[PATCH v1 12/12] virtio-mem: Expose device memory via multiple memslots

We want to expose virtio-mem device memory via multiple memslots to the guest on demand, essentially reducing the total size of KVM slots significantly (and thereby metadata in KVM and in QEMU for KVM memory slots) especially when exposing initially only a small amount of memory via a virtio-mem de

[PATCH v1 00/12] virtio-mem: Expose device memory via multiple memslots

This is the follow-up of [1], dropping auto-detection and vhost-user changes from the initial RFC. Based-on: 20211011175346.15499-1-da...@redhat.com A virtio-mem device is represented by a single large RAM memory region backed by a single large mmap. Right now, we map that complete memory region

[PATCH v1 09/12] memory: Drop mapping check from memory_region_get_ram_discard_manager()

It's sufficient to check whether a memory region is RAM, the region doesn't necessarily have to be mapped into another memory region. For example, RAM memory regions mapped via an alias will never make "memory_region_is_mapped()" succeed. Signed-off-by: David Hildenbrand --- softmmu/memory.c | 2

[PATCH v1 01/12] kvm: Return number of free memslots

Let's return the number of free slots instead of only checking if there is a free slot. Required to support memory devices that consume multiple memslots. Signed-off-by: David Hildenbrand --- accel/kvm/kvm-all.c| 24 +++- accel/stubs/kvm-stub.c | 4 ++-- hw/mem/memory-de

Re: [PATCH 00/16] fdt: Make OF_BOARD a boolean option

On Fri, Oct 15, 2021 at 12:03:44PM -0600, Simon Glass wrote: > Hi all, > > On Thu, 14 Oct 2021 at 09:28, Tom Rini wrote: > > > > On Thu, Oct 14, 2021 at 09:17:52AM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Thu, 14 Oct 2021 at 08:56, Tom Rini wrote: > > > > > > > > On Wed, Oct 13, 20

[PATCH v1 10/12] virtio-mem: Fix typo in virito_mem_intersect_memory_section() function name

It's "virtio", not "virito". Signed-off-by: David Hildenbrand --- hw/virtio/virtio-mem.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/virtio/virtio-mem.c b/hw/virtio/virtio-mem.c index d5a578142b..0f5eae4a7e 100644 --- a/hw/virtio/virtio-mem.c +++ b/hw/virt

[PATCH v1 04/12] vhost: Don't merge unmergeable memory sections

Memory sections that are marked unmergeable should not be merged, to allow for atomic removal later. Signed-off-by: David Hildenbrand --- hw/virtio/vhost.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 2707972870..49a1074097 1

Re: [PATCH v2 1/3] file-posix: add `aio-max-batch` option

Am 27.10.2021 um 11:23 hat Stefano Garzarella geschrieben: > On Wed, Oct 27, 2021 at 06:28:51AM +0200, Markus Armbruster wrote: > > Stefano Garzarella writes: > > > > > Commit d7ddd0a161 ("linux-aio: limit the batch size using > > > `aio-max-batch` parameter") added a way to limit the batch size

Re: [PATCH v5 6/8] iotests/300: avoid abnormal shutdown race condition

Am 26.10.2021 um 19:56 hat John Snow geschrieben: > Wait for the destination VM to close itself instead of racing to shut it > down first, which produces different error log messages from AQMP > depending on precisely when we tried to shut it down. > > (For example: We may try to issue 'quit' imme

[PATCH v1 03/12] memory: Allow for marking memory region aliases unmergeable

Let's allow for marking memory region aliases unmergeable, to teach flatview code (and memory listeners like vhost-user) to not merge adjacent aliases to the same memory region into a larger memory section; instead, we want separate alias to stay separate such that we can atomically map/unmap alias

Re: [PATCH 00/16] fdt: Make OF_BOARD a boolean option

On Tue, Oct 26, 2021 at 09:46:38AM +0300, Ilias Apalodimas wrote: > Hi Simon, > > A bit late to the party, sorry! > > [...] > > > > > > > I really want to see what the binary case looks like since we could then > > > kill off rpi_{3,3_b,4}_defconfig and I would need to see if we could > > > then

[PATCH v1 02/12] vhost: Return number of free memslots

Let's return the number of free slots instead of only checking if there is a free slot. Required to support memory devices that consume multiple memslots. Signed-off-by: David Hildenbrand --- hw/mem/memory-device.c| 2 +- hw/virtio/vhost-stub.c| 2 +- hw/virtio/vhost.c | 4 ++--

[PATCH 3/3] watchdog: remove select_watchdog_action

Instead of invoking select_watchdog_action from both HMP and command line, go directly from HMP to QMP and use QemuOpts as the intermediary for the command line. This makes -watchdog-action explicitly a shortcut for "-action watchdog", so that "-watchdog-action" and "-action watchdog" override eac

Re: [PATCH 00/16] fdt: Make OF_BOARD a boolean option

Hi, On Wed, 27 Oct 2021 at 14:48, Tom Rini wrote: > On Fri, Oct 15, 2021 at 12:03:44PM -0600, Simon Glass wrote: > > Hi all, > > > > On Thu, 14 Oct 2021 at 09:28, Tom Rini wrote: > > > > > > On Thu, Oct 14, 2021 at 09:17:52AM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Thu, 14

Re: [PATCH 0/1] gitlab-ci: Only push docker images to mainstream registry from /master

On 10/27/21 14:34, Daniel P. Berrangé wrote: > On Wed, Oct 27, 2021 at 02:26:58PM +0200, Gerd Hoffmann wrote: >>> Notably the latter is more restrictive that git branch names. We could >>> assume users always have "sensible" branch names that are less than >>> 128 chars and only alpha-num character

[PULL 5/8] fsdev/p9array.h: check scalar type in P9ARRAY_NEW()

Make sure at compile time that the scalar type of the array requested to be created via P9ARRAY_NEW() matches the scalar type of the passed auto reference variable (unique pointer). Suggested-by: Richard Henderson Signed-off-by: Christian Schoenebeck Message-Id: --- fsdev/p9array.h | 6 ++

[PATCH v2] vhost-vdpa: Set discarding of RAM broken when initializing the backend

Similar to VFIO, vDPA will go ahead an map+pin all guest memory. Memory that used to be discarded will get re-populated and if we discard+re-access memory after mapping+pinning, the pages mapped into the vDPA IOMMU will go out of sync with the actual pages mapped into the user space page tables. S

[PATCH 0/3] Deprecate -watchdog, cleanup -watchdog-action

-watchdog is a simple wrapper around -device, but it includes quite a bit of code to register and list available watchdog devices. Add a category for watchdogs so that they are listed as such in '-device help', and deprecate it. For -watchdog-action, make it 100% a shortcut for "-action watchdog",

RE: [PATCH v4 36/51] tcg/optimize: Split out fold_xi_to_x

From: Richard Henderson > Pull the "op r, a, i => mov r, a" optimization into a function, and use them > in the > outer-most logical operations. > > Signed-off-by: Richard Henderson > --- > tcg/optimize.c | 61 +- > 1 file changed, 26 insertions(

[PATCH 2/3] vl: deprecate -watchdog

-watchdog is the same as -device except that it is case insensitive (and it allows only watchdog devices of course). Now that "-device help" can list as such the available watchdog devices, we can deprecate it. Note that even though -watchdog tries to be case insensitive, it fails at that: "-watc

[PATCH 1/3] watchdog: add information from -watchdog help to -device help

List all watchdog devices in a separate category, and populate their descriptions. Signed-off-by: Paolo Bonzini --- hw/watchdog/sbsa_gwdt.c| 3 ++- hw/watchdog/wdt_aspeed.c | 3 ++- hw/watchdog/wdt_diag288.c | 3 ++- hw/watchdog/wdt_i6300esb.c | 3 ++- hw/watchdog/wdt_ib700.c| 3 ++-

Re: [PATCH v1 02/12] vhost: Return number of free memslots

On 10/27/21 14:45, David Hildenbrand wrote: > Let's return the number of free slots instead of only checking if there > is a free slot. Required to support memory devices that consume multiple > memslots. > > Signed-off-by: David Hildenbrand > --- > hw/mem/memory-device.c| 2 +- > hw/virtio/

[PULL 0/8] 9p queue 2021-10-27

gs/pull-9p-20211027 for you to fetch changes up to 7e985780aaab93d2c5be9b62d8d386568dfb071e: 9pfs: use P9Array in v9fs_walk() (2021-10-27 14:45:22 +0200) 9pfs: performance fix and cleanup * First patch fixes suboptimal I/O performanc

Re: [PATCH 00/16] fdt: Make OF_BOARD a boolean option

On 10/27/21 15:15, François Ozog wrote: Hi, On Wed, 27 Oct 2021 at 14:48, Tom Rini > wrote: On Fri, Oct 15, 2021 at 12:03:44PM -0600, Simon Glass wrote: > Hi all, > > On Thu, 14 Oct 2021 at 09:28, Tom Rini mailto:tr...@konsulko.com>> wrote: >

[PULL 2/8] 9pfs: deduplicate iounit code

Remove redundant code that translates host fileystem's block size into 9p client (guest side) block size. Signed-off-by: Christian Schoenebeck Reviewed-by: Greg Kurz Message-Id: <129bb71d5119e61d335f1e3107e472e4beea223a.1632758315.git.qemu_...@crudebyte.com> --- hw/9pfs/9p.c | 41 +

[PULL 3/8] 9pfs: simplify blksize_to_iounit()

Use QEMU_ALIGN_DOWN() macro to reduce code and to make it more human readable. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Christian Schoenebeck Reviewed-by: Greg Kurz Reviewed-by: Philippe Mathieu-Daudé Message-Id: --- hw/9pfs/9p.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletio

[PULL 1/8] 9pfs: fix wrong I/O block size in Rgetattr

When client sent a 9p Tgetattr request then the wrong I/O block size value was returned by 9p server; instead of host file system's I/O block size it should rather return an I/O block size according to 9p session's 'msize' value, because the value returned to client should be an "optimum" block siz

[PULL 4/8] 9pfs: introduce P9Array

Implements deep auto free of arrays while retaining common C-style squared bracket access. Main purpose of this API is to get rid of error prone individual array deallocation pathes in user code, i.e. turning something like this: void doSomething(size_t n) { Foo *foos = malloc(n * sizeof(F

Re: [PATCH 00/16] fdt: Make OF_BOARD a boolean option

Hi trying to reply to all at the same time! On Wed, Oct 27, 2021 at 09:38:40AM -0400, Tom Rini wrote: > On Wed, Oct 27, 2021 at 03:30:18PM +0200, François Ozog wrote: > > Hi Tom, > > > > On Wed, 27 Oct 2021 at 14:59, Tom Rini wrote: > > > > > On Tue, Oct 26, 2021 at 09:46:38AM +0300, Ilias Apal

  1   2   3   4   5   >