On Wed, Oct 27, 2021 at 08:01:07AM +0200, Thomas Huth wrote: > On 26/10/2021 16.55, Philippe Mathieu-Daudé wrote: > > Users expect images pulled from registry.gitlab.com/qemu-project/qemu/ > > to be stable. QEMU repository workflow pushes merge candidates to > > the /staging branch, and on success the same commit is pushed as > > /master. If /staging fails, we do not want to push the built images > > to the registry. Therefore limit the 'docker push' command to the > > /master branch on the mainstream CI. The fork behavior is unchanged. > > Hmmm, what if I have a patch series that updates one of the containers and > then also contains a new test that depends on the updated container? Won't > that fail in the staging branch now and make me look bad?
Yep, if a patch series contains a dockerfile change we *must* run the container build no matter what, so tis patch doesn't fly. This scenario a tricky problem, and I'm not seeing an easy answer to it so far. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
