Re: [PATCH 1/2] numa: Set default distance map if needed

2021-10-12 Thread Gavin Shan
Hi Igor, On 10/12/21 8:40 PM, Igor Mammedov wrote: On Wed, 6 Oct 2021 18:22:08 +0800 Gavin Shan wrote: The following option is used to specify the distance map. It's possible the option isn't provided by user. In this case, the distance map isn't populated and exposed to platform. On the oth

Re: [PATCH v2 1/6] net/vmnet: dependencies setup, initial preparations

2021-10-12 Thread Vladislav Yaroshchuk
Thank you, Eric! Now fixing all the QAPI issues. пн, 11 окт. 2021 г. в 21:45, Eric Blake : > On Tue, Aug 31, 2021 at 10:27:15PM +0300, Vladislav Yaroshchuk wrote: > > Add 'vmnet' customizable option and 'vmnet.framework' probe into > > configure; > > > > Create separate netdev per each vmnet op

[PATCH v4 29/30] Hexagon HVX (tests/tcg/hexagon) scatter_gather test

2021-10-12 Thread Taylor Simpson
Signed-off-by: Taylor Simpson --- tests/tcg/hexagon/scatter_gather.c | 1011 tests/tcg/hexagon/Makefile.target |2 + 2 files changed, 1013 insertions(+) create mode 100644 tests/tcg/hexagon/scatter_gather.c diff --git a/tests/tcg/hexagon/scatter_gather.

[PATCH v4 26/30] Hexagon HVX (target/hexagon) import instruction encodings

2021-10-12 Thread Taylor Simpson
Signed-off-by: Taylor Simpson --- target/hexagon/decode.c | 4 + target/hexagon/imported/allextenc.def| 20 + target/hexagon/imported/encode.def | 1 + target/hexagon/imported/mmvec/encode_ext.def | 794 +++ 4 files changed, 819

Re: [PATCH 1/2] numa: Set default distance map if needed

2021-10-12 Thread Andrew Jones
On Tue, Oct 12, 2021 at 11:40:16AM +0200, Igor Mammedov wrote: > On Wed, 6 Oct 2021 18:22:08 +0800 > Gavin Shan wrote: > > > The following option is used to specify the distance map. It's > > possible the option isn't provided by user. In this case, the > > distance map isn't populated and expos

Re: [PATCH v2 2/5] qapi: Add feature flags to enum members

2021-10-12 Thread Kevin Wolf
Am 09.10.2021 um 14:09 hat Markus Armbruster geschrieben: > This is quite similar to commit 84ab008687 "qapi: Add feature flags to > struct members", only for enums instead of structs. > > Special feature flag 'deprecated' is silently ignored there. This is > okay only because it will be implemen

Re: [PATCH RFC v2 5/5] block: Deprecate transaction type drive-backup

2021-10-12 Thread Kevin Wolf
Am 11.10.2021 um 20:58 hat Eric Blake geschrieben: > On Sat, Oct 09, 2021 at 02:09:44PM +0200, Markus Armbruster wrote: > > Several moons ago, Vladimir posted > > > > Subject: [PATCH v2 3/3] qapi: deprecate drive-backup > > Date: Wed, 5 May 2021 16:58:03 +0300 > > Message-Id: <2021050

[PATCH v3 2/6] net/vmnet: create common netdev state structure

2021-10-12 Thread Vladislav Yaroshchuk
Signed-off-by: Vladislav Yaroshchuk --- net/meson.build | 8 +++- net/vmnet-bridged.m | 25 + net/vmnet-common.m | 20 net/vmnet-host.c| 24 net/vmnet-shared.c | 25 + net/vmnet.c

[PATCH v3 0/6] Add vmnet.framework based network backend

2021-10-12 Thread Vladislav Yaroshchuk
macOS provides networking API for VMs called vmnet.framework. I tried to add it as a network backend. All three modes are supported: -shared: allows the guest to communicate with other guests in shared mode and also with external network (Internet) via NAT -host: allows the guest to communi

Re: [PATCH 5/6] numa: Enable numa for libvirt interface

2021-10-12 Thread Paolo Bonzini
On 11/10/21 13:15, Yang Zhong wrote: Libvirt need get the detailed host SGX EPC capabilities to support numa function. Libvirt can decide how to allocate host EPC sections to guest numa from host numa info. (QEMU) query-sgx-capabilities {"return": {"sgx": true, "sgx2": true, "sgx1": true, "secti

[PATCH v3 6/6] net/vmnet: update qemu-options.hx

2021-10-12 Thread Vladislav Yaroshchuk
Signed-off-by: Vladislav Yaroshchuk --- qemu-options.hx | 17 + 1 file changed, 17 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index 5f375bbfa6..2aaa7a0782 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2677,6 +2677,17 @@ DEF("netdev", HAS_ARG, QEMU_OPTIO

[PATCH v3 1/6] net/vmnet: dependencies setup, initial preparations

2021-10-12 Thread Vladislav Yaroshchuk
Add 'vmnet' customizable option and 'vmnet.framework' probe into configure; Create separate netdev per each vmnet operating mode because they use quite different settings. Especially since macOS 11.0 (vmnet.framework API gets lots of updates) Create source files for network client driver, update m

Re: [PATCH v3 14/25] include/systemu/blockdev.h: global state API

2021-10-12 Thread Paolo Bonzini
On 12/10/21 10:48, Emanuele Giuseppe Esposito wrote: +/* Common functions that are neither I/O nor Global State */ + +DriveInfo *blk_legacy_dinfo(BlockBackend *blk); +int drive_get_max_devs(BlockInterfaceType type); + blk_legacy_dinfo should count as global state (blk->legacy_dinfo is protecte

Re: [PATCH 4/6] monitor: numa support for 'info sgx' command

2021-10-12 Thread Paolo Bonzini
On 11/10/21 13:15, Yang Zhong wrote: This patch can enable numa support for 'info sgx' command in the monitor, which can show detailed SGX EPC sections info. (qemu) info sgx SGX support: enabled SGX1 support: enabled SGX2 support: enabled FLC support: enabled SECTION #0: size=67108864

[PATCH v3 3/6] net/vmnet: implement shared mode (vmnet-shared)

2021-10-12 Thread Vladislav Yaroshchuk
Still not implemented: - port forwarding - ipv6 prefix setting Signed-off-by: Vladislav Yaroshchuk --- net/vmnet-common.m | 275 + net/vmnet-shared.c | 73 +++- net/vmnet_int.h| 23 3 files changed, 369 insertions(+), 2 deletions(-)

Re: [PATCH] qapi: Improve input_type_enum()'s error message

2021-10-12 Thread Kevin Wolf
Am 11.10.2021 um 15:15 hat Markus Armbruster geschrieben: > The error message claims the parameter is invalid: > > $ qemu-system-x86_64 -object qom-type=nonexistent > qemu-system-x86_64: -object qom-type=nonexistent: Invalid parameter > 'nonexistent' > > What's wrong is actually the *val

Re: [PATCH] contrib/plugins: add a drcov plugin

2021-10-12 Thread Alex Bennée
Arkadiy writes: > From: NDNF > > This patch adds the ability to generate files in drcov format. > Primary goal this script is to have coverage > logfiles thatwork in Lighthouse. > Problems: > - The path to the executable file is not specified. I don't see a problem in introducing a plugin

Re: [PATCH v3 01/12] configure, meson: override C compiler for cmake

2021-10-12 Thread Paolo Bonzini
On 11/10/21 07:31, Jagannathan Raman wrote: The compiler path that cmake gets from meson is corrupted. It results in the following error: | -- The C compiler identification is unknown | CMake Error at CMakeLists.txt:35 (project): | The CMAKE_C_COMPILER: | /opt/rh/devtoolset-9/root/bin/cc;-m64;-mc

Re: [PATCH 3/6] numa: Add SGXEPCSection list for multiple sections

2021-10-12 Thread Paolo Bonzini
On 11/10/21 19:03, Eric Blake wrote: +# @sections: The EPC sections info for guest # # Since: 6.2 Given this has not yet been in a stable release, we can make this change... ## @@ -356,7 +371,7 @@ 'sgx1': 'bool', 'sgx2': 'bool', 'flc': 'bool', -

[PATCH v2 05/24] configure: add command line options for audio drivers

2021-10-12 Thread Paolo Bonzini
Handle the choice of audio drivers the same as all other dependencies. Cc: Gerd Hoffman Cc: Volker Rümelin Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau Message-Id: <20211007130630.632028-6-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure | 39 +++

Re: [PATCH v3 13/25] include/sysemu/blockdev.h: move drive_add and inline drive_def

2021-10-12 Thread Paolo Bonzini
On 12/10/21 10:48, Emanuele Giuseppe Esposito wrote: +if (type != IF_DEFAULT) { +qemu_opt_set(opts, "if", if_name[type], &error_abort); +} To avoid exporting if_name, this can be replaced by a string argument directly. But in any case this is okay for this series: Reviewed-b

Re: [PATCH v3 08/25] block: introduce assert_bdrv_graph_writable

2021-10-12 Thread Paolo Bonzini
On 12/10/21 10:48, Emanuele Giuseppe Esposito wrote: We want to be sure that the functions that write the child and parent list of a bs are under BQL and drain. BQL prevents from concurrent writings from the GS API, while drains protect from I/O. TODO: drains are missing in some functions using

[PATCH v2 02/24] audio: remove CONFIG_AUDIO_WIN_INT

2021-10-12 Thread Paolo Bonzini
Ever since winwaveaudio was removed in 2015, CONFIG_AUDIO_WIN_INT is only set if dsound is in use, so use CONFIG_AUDIO_DSOUND directly. Cc: Gerd Hoffman Cc: Volker Rümelin Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau Message-Id: <20211007130630.632028-3-pbonz...@redhat.com> Sign

[PATCH v2 21/24] configure: remove deprecated --{enable, disable}-git-update

2021-10-12 Thread Paolo Bonzini
The options were deprecated in 6.0. That said, we do not really have a formal deprecation cycle for build-time changes, since they do not affect users. Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau Message-Id: <20211007130829.632254-16-pbonz...@redhat.com> Signed-off-by: Paolo Bon

[PATCH v3 5/6] net/vmnet: implement bridged mode (vmnet-bridged)

2021-10-12 Thread Vladislav Yaroshchuk
Signed-off-by: Vladislav Yaroshchuk --- net/vmnet-bridged.m | 102 +++- 1 file changed, 100 insertions(+), 2 deletions(-) diff --git a/net/vmnet-bridged.m b/net/vmnet-bridged.m index 4e42a90391..9097181841 100644 --- a/net/vmnet-bridged.m +++ b/net/vmnet-b

[PATCH v3 4/6] net/vmnet: implement host mode (vmnet-host)

2021-10-12 Thread Vladislav Yaroshchuk
Still not implemented: - port forwarding Signed-off-by: Vladislav Yaroshchuk --- net/vmnet-host.c | 75 ++-- 1 file changed, 72 insertions(+), 3 deletions(-) diff --git a/net/vmnet-host.c b/net/vmnet-host.c index 4a5ef99dc7..fe7211d61b 100644 --- a/ne

[PATCH v2 07/24] configure, meson: move fuzzing configuration to Meson

2021-10-12 Thread Paolo Bonzini
Cc: Alexander Oleinik Signed-off-by: Paolo Bonzini Reviewed-by: Alexander Bulekov Tested-by: Alexander Bulekov Message-Id: <20211007130829.632254-2-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure| 71 +++- meson.build

[PATCH v2 04/24] meson: define symbols for all available audio drivers

2021-10-12 Thread Paolo Bonzini
All drivers are now built by default if the corresponding libraries are available, similar to how all other modules behave; --audio-drv-list only governs the default choice of the audio driver. Adjust the CONFIG_AUDIO_* preprocessor symbols so that they are based on library availability rather tha

Re: [PATCH 3/6] numa: Add SGXEPCSection list for multiple sections

2021-10-12 Thread Paolo Bonzini
On 11/10/21 13:15, Yang Zhong wrote: The SGXEPCSection list added into SGXInfo to show the multiple SGX EPC sections detailed info, not the total size like before. Signed-off-by: Yang Zhong --- qapi/misc-target.json | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-)

[PATCH v2 15/24] configure, meson: move libaio check to meson.build

2021-10-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini Message-Id: <20211007130829.632254-10-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- block/meson.build | 2 +- configure | 31 --- meson.build | 10 -- meson_options.txt | 2 ++ stubs/meson.build | 4 +++- 5

[PATCH v2 06/24] kconfig: split CONFIG_SPARSE_MEM from fuzzing

2021-10-12 Thread Paolo Bonzini
Pass CONFIG_FUZZ via host_kconfig, and use it to select the sparse-mem device. Cc: Alexander Oleinik Signed-off-by: Paolo Bonzini Reviewed-by: Alexander Bulekov Reviewed-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Tested-by: Alexander Bulekov Message-Id: <20211007130829.632254-

Re: [PATCH 0/2] target/i386/sev: Replace malloc with local variables

2021-10-12 Thread Paolo Bonzini
On 11/10/21 19:30, Dov Murik wrote: In two places in sev.c we use malloc+free to manage memory for small constant struct variables. Modify this to use local variables. This small series can be applied on top of master or on top of Phil's Housekeeping SEV series [1]. [1] https://lore.kernel.or

[PATCH v2 16/24] configure, meson: move vde detection to meson

2021-10-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau Message-Id: <20211007130829.632254-11-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure | 35 --- meson.build | 26 +++--- meson_options.txt | 2 ++ net/m

[PATCH v2 08/24] trace: simple: pass trace_file unmodified to config-host.h

2021-10-12 Thread Paolo Bonzini
Add the suffix directly in trace/simple.c, so that quoting is done properly by Meson. Cc: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau Message-Id: <20211007130829.632254-3-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure | 2 -- meson.build

[PATCH v2 17/24] configure, meson: move netmap detection to meson

2021-10-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini Message-Id: <20211007130829.632254-12-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure | 40 meson.build | 19 ++- meson_options.txt | 2 ++ net/meson.build | 4 +++- 4 files ch

[PATCH v2 12/24] configure, meson: remove CONFIG_GCOV from config-host.mak

2021-10-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau Message-Id: <20211007130829.632254-7-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure | 3 --- meson.build | 1 + 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/configure b/configure index 35e25bb960..49

Re: [PATCH 1/2] numa: Set default distance map if needed

2021-10-12 Thread Andrew Jones
On Tue, Oct 12, 2021 at 09:31:55PM +1100, Gavin Shan wrote: > Hi Igor, > > On 10/12/21 8:40 PM, Igor Mammedov wrote: > > On Wed, 6 Oct 2021 18:22:08 +0800 > > Gavin Shan wrote: > > > > > The following option is used to specify the distance map. It's > > > possible the option isn't provided by u

[PATCH v2 00/24] configure->meson queue for 6.2

2021-10-12 Thread Paolo Bonzini
Here is my queue of test conversions to meson for 6.2. This includes especially: - patches 1-5: converting audio driver detection; also adds --enable-* options for all audio drivers, so that they are more similar to other drivers - patches 6-7: converting fuzzing configuration - patches 8-9

[PATCH v2 13/24] configure, meson: move remaining HAVE_* compiler tests to Meson

2021-10-12 Thread Paolo Bonzini
Remove some special cases by moving them to Meson. Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau Message-Id: <20211007130829.632254-8-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure | 37 - meson.build | 22 +++

[PATCH v2 01/24] configure: remove --oss-lib

2021-10-12 Thread Paolo Bonzini
OSS is a kernel API, so the option should not be needed. The library is used on NetBSD, where OSS is emulated, so keep the variable. Cc: Gerd Hoffman Cc: Volker Rümelin Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau Reviewed-by: Thomas Huth Message-Id: <20211007130630.632028-2-p

[PATCH v2 18/24] configure, meson: move Spice configure handling to meson

2021-10-12 Thread Paolo Bonzini
From: Marc-André Lureau Add meson feature options for Spice and Spice protocol, and move detection logic out of configure. Signed-off-by: Marc-André Lureau Message-Id: <20211007102453.978041-1-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini Message-Id: <20211007130829.632254-13-pbonz

[PATCH v2 20/24] configure, meson: move more compiler checks to Meson

2021-10-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau Message-Id: <20211007130829.632254-15-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure| 91 meson.build | 44 +++ util/meson.build | 4 ++

[PATCH v2 03/24] configure, meson: move audio driver detection to Meson

2021-10-12 Thread Paolo Bonzini
This brings a change that makes audio drivers more similar to all other modules. All drivers are built by default, while --audio-drv-list only governs the default choice of the audio driver. Meson options are added to disable the drivers, and the next patches will fix the help messages and comman

[PATCH v2 22/24] configure: accept "internal" for --enable-capstone/slirp/fdt

2021-10-12 Thread Paolo Bonzini
Options such as "--enable-capstone=git" do not make much sense when building from a tarball. Accept "internal" for consistency with the meson options. Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau Message-Id: <20211007130829.632254-17-pbonz...@redhat.com> Signed-off-by: Paolo Bonz

[PATCH v2 10/24] configure, meson: move CONFIG_HOST_DSOSUF to Meson

2021-10-12 Thread Paolo Bonzini
This is just a constant string, there is no need to pass it in config-host.mak. Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20211007130829.632254-5-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure | 6 -- m

[PATCH v2 23/24] configure: prepare for auto-generated option parsing

2021-10-12 Thread Paolo Bonzini
Prepare the configure script and Makefile for automatically generated help and parsing. Because we need to run the script to generate the full help, we cannot rely on the user supplying the path to a Python interpreter with --python; therefore, the introspection output is parsed into shell functio

Re: [RFC PATCH] block/vpc: Support probing of fixed-size VHD images

2021-10-12 Thread Thomas Huth
On 19/05/2021 12.56, Kevin Wolf wrote: [...] We have a bug in vpc_open(), though: It sets the local variable disk_type correctly, but other functions use s->footer.type instead and we never check that it actually matches the disk type we think we're opening. So I think we need to add this check

Re: [PATCH 1/2] numa: Set default distance map if needed

2021-10-12 Thread Igor Mammedov
On Tue, 12 Oct 2021 21:31:55 +1100 Gavin Shan wrote: > Hi Igor, > > On 10/12/21 8:40 PM, Igor Mammedov wrote: > > On Wed, 6 Oct 2021 18:22:08 +0800 > > Gavin Shan wrote: > > > >> The following option is used to specify the distance map. It's > >> possible the option isn't provided by user.

[PATCH v2 09/24] trace: move configuration from configure to Meson

2021-10-12 Thread Paolo Bonzini
Cc: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau Message-Id: <20211007130829.632254-4-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure | 91 + docs/meson.build| 2 +- meson.build |

Re: [PATCH v2 02/24] audio: remove CONFIG_AUDIO_WIN_INT

2021-10-12 Thread Thomas Huth
On 12/10/2021 13.12, Paolo Bonzini wrote: Ever since winwaveaudio was removed in 2015, CONFIG_AUDIO_WIN_INT is only set if dsound is in use, so use CONFIG_AUDIO_DSOUND directly. Cc: Gerd Hoffman Cc: Volker Rümelin Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau Message-Id: <20211

[PATCH v2 11/24] configure, meson: get HOST_WORDS_BIGENDIAN via the machine object

2021-10-12 Thread Paolo Bonzini
No need to pass it in config-host.mak. Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20211007130829.632254-6-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure | 4 meson.build | 3 ++- 2 files changed, 2 inser

[PATCH v2 14/24] configure, meson: move pthread_setname_np checks to Meson

2021-10-12 Thread Paolo Bonzini
This makes the pthreads check dead in configure, so remove it as well. Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau Message-Id: <20211007130829.632254-9-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure| 78

Re: [PATCH] qapi: Improve input_type_enum()'s error message

2021-10-12 Thread Markus Armbruster
Kevin Wolf writes: > Am 11.10.2021 um 15:15 hat Markus Armbruster geschrieben: >> The error message claims the parameter is invalid: >> >> $ qemu-system-x86_64 -object qom-type=nonexistent >> qemu-system-x86_64: -object qom-type=nonexistent: Invalid parameter >> 'nonexistent' >> >> Wha

[PATCH v2 19/24] configure: remove obsolete Solaris ar check

2021-10-12 Thread Paolo Bonzini
Meson already has its own logic to find the "ar" binary, so remove the Solaris specific check. Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau Reviewed-by: Thomas Huth Message-Id: <20211007130829.632254-14-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure | 15 --

Re: [RFC PATCH] target/s390x: don't double ld_code() when reading instructions

2021-10-12 Thread Richard Henderson
On 10/12/21 2:31 AM, Alex Bennée wrote: For the 4 byte instruction case we started doing an ld_code2 and then reloaded the data with ld_code4 once it was identified as a 4 byte op. This is confusing for the plugin hooks which are expecting to see simple sequential loading so end up reporting a ma

[PATCH v2 24/24] configure: automatically parse command line for meson -D options

2021-10-12 Thread Paolo Bonzini
Right now meson_options.txt lists about 90 options. Each option needs code in configure to parse it and pass the option down to Meson as a -D command-line argument; in addition the default must be duplicated between configure and meson_options.txt. This series tries to remove the code duplication

Re: [PATCH 0/5] trace: inroduce qmp: trace namespace

2021-10-12 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Hi all! > > We have handle_qmp_command and qmp_command_repond trace points to trace > qmp commands. They are very useful to debug problems involving > management tools like libvirt. > > But tracing all qmp commands is too much. > > Here I suggest a kind of t

Re: [PATCH 1/2] numa: Set default distance map if needed

2021-10-12 Thread Igor Mammedov
On Tue, 12 Oct 2021 12:37:54 +0200 Andrew Jones wrote: > On Tue, Oct 12, 2021 at 11:40:16AM +0200, Igor Mammedov wrote: > > On Wed, 6 Oct 2021 18:22:08 +0800 > > Gavin Shan wrote: > > > > > The following option is used to specify the distance map. It's > > > possible the option isn't provide

Re: [RFC PATCH] target/s390x: don't double ld_code() when reading instructions

2021-10-12 Thread Richard Henderson
On 10/12/21 2:31 AM, Alex Bennée wrote: -case 6: -insn = (insn << 48) | (ld_code4(env, s, pc + 2) << 16); + case 6: + insn = deposit64(insn, 16, 32, ld_code4(env, s, pc + 2)); break; Looks like some of indentation error? Otherwise, Reviewed-

Re: [PATCH v2 11/24] configure, meson: get HOST_WORDS_BIGENDIAN via the machine object

2021-10-12 Thread Thomas Huth
On 12/10/2021 13.12, Paolo Bonzini wrote: No need to pass it in config-host.mak. Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20211007130829.632254-6-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure | 4

Re: [PATCH 1/2] numa: Set default distance map if needed

2021-10-12 Thread Igor Mammedov
On Tue, 12 Oct 2021 13:48:02 +0200 Andrew Jones wrote: > On Tue, Oct 12, 2021 at 09:31:55PM +1100, Gavin Shan wrote: > > Hi Igor, > > > > On 10/12/21 8:40 PM, Igor Mammedov wrote: > > > On Wed, 6 Oct 2021 18:22:08 +0800 > > > Gavin Shan wrote: > > > > > > > The following option is used to

Re: [PATCH v2 0/5] qapi: Add feature flags to enum members

2021-10-12 Thread Peter Krempa
On Sat, Oct 09, 2021 at 14:09:39 +0200, Markus Armbruster wrote: I've tested this with my libvirt patches which make use of the new way enum members are returned as well as code which validates whether libvirt uses deprecated values and everything works as expected, thus Series: Tested-by: Peter

Re: [PATCH 1/2] numa: Set default distance map if needed

2021-10-12 Thread Andrew Jones
On Tue, Oct 12, 2021 at 02:34:30PM +0200, Igor Mammedov wrote: > On Tue, 12 Oct 2021 13:48:02 +0200 > Andrew Jones wrote: > > > On Tue, Oct 12, 2021 at 09:31:55PM +1100, Gavin Shan wrote: > > > Hi Igor, > > > > > > On 10/12/21 8:40 PM, Igor Mammedov wrote: > > > > On Wed, 6 Oct 2021 18:22:08

[PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

2021-10-12 Thread Jean-Louis Dupond
hw_compat modes only take into account their base name. But if a device is created with (non)-transitional, then the compat values are not used, causing migrating issues. This commit adds their (non)-transitional entries with the same settings as the base entry. Fixes https://bugzilla.redhat.com/

[PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

2021-10-12 Thread Jean-Louis Dupond
hw_compat modes only take into account their base name. But if a device is created with (non)-transitional, then the compat values are not used, causing migrating issues. This commit adds their (non)-transitional entries with the same settings as the base entry. Fixes https://bugzilla.redhat.com/

Re: [RFC PATCH v4 05/20] vhost: Add x-vhost-enable-shadow-vq qmp

2021-10-12 Thread Eugenio Perez Martin
On Tue, Oct 12, 2021 at 7:18 AM Markus Armbruster wrote: > > Eugenio Pérez writes: > > > Command to enable shadow virtqueue. > > > > Signed-off-by: Eugenio Pérez > > --- > > qapi/net.json | 23 +++ > > hw/virtio/vhost-vdpa.c | 8 > > 2 files changed, 31 in

Re: [PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

2021-10-12 Thread Jean-Louis Dupond
Forgot to CC maintainers. On 12/10/2021 10:24, Jean-Louis Dupond wrote: hw_compat modes only take into account their base name. But if a device is created with (non)-transitional, then the compat values are not used, causing migrating issues. This commit adds their (non)-transitional entries wi

Re: [PATCH 1/2] numa: Set default distance map if needed

2021-10-12 Thread Andrew Jones
On Tue, Oct 12, 2021 at 02:27:54PM +0200, Igor Mammedov wrote: > On Tue, 12 Oct 2021 12:37:54 +0200 > Andrew Jones wrote: > > > On Tue, Oct 12, 2021 at 11:40:16AM +0200, Igor Mammedov wrote: > > > On Wed, 6 Oct 2021 18:22:08 +0800 > > > Gavin Shan wrote: > > > > > > > The following option is

Re: [PULL 00/18] aspeed queue

2021-10-12 Thread Richard Henderson
https://github.com/legoater/qemu/ tags/pull-aspeed-20211012 for you to fetch changes up to e2804a1ec97ceede14b69a2a6e9a8b5dfa0b15c2: aspeed/smc: Dump address offset in trace events (2021-10-12 08:20:08 +0200) Aspeed patches : *

Re: [RFC PATCH v4 08/20] vhost: Route guest->host notification through shadow virtqueue

2021-10-12 Thread Eugenio Perez Martin
On Tue, Oct 12, 2021 at 7:20 AM Markus Armbruster wrote: > > Eugenio Pérez writes: > > > Shadow virtqueue notifications forwarding is disabled when vhost_dev > > stops, so code flow follows usual cleanup. > > > > Also, host notifiers must be disabled at SVQ start, and they will not > > start if S

Re: [PATCH v2 13/24] configure, meson: move remaining HAVE_* compiler tests to Meson

2021-10-12 Thread Thomas Huth
On 12/10/2021 13.12, Paolo Bonzini wrote: Remove some special cases by moving them to Meson. Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau Message-Id: <20211007130829.632254-8-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- ... @@ -1609,7 +1626,8 @@ config_host_data.set(

Re: [PATCH v2 14/24] configure, meson: move pthread_setname_np checks to Meson

2021-10-12 Thread Thomas Huth
On 12/10/2021 13.12, Paolo Bonzini wrote: This makes the pthreads check dead in configure, so remove it as well. Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau Message-Id: <20211007130829.632254-9-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure|

Re: [RFC PATCH v4 15/20] vhost: Shadow virtqueue buffers forwarding

2021-10-12 Thread Eugenio Perez Martin
On Tue, Oct 12, 2021 at 7:21 AM Markus Armbruster wrote: > > Eugenio Pérez writes: > > > Initial version of shadow virtqueue that actually forward buffers. There > > are no iommu support at the moment, and that will be addressed in future > > patches of this series. Since all vhost-vdpa devices u

Re: [RFC PATCH v4 05/20] vhost: Add x-vhost-enable-shadow-vq qmp

2021-10-12 Thread Markus Armbruster
Eugenio Perez Martin writes: > On Tue, Oct 12, 2021 at 7:18 AM Markus Armbruster wrote: >> >> Eugenio Pérez writes: >> >> > Command to enable shadow virtqueue. >> > >> > Signed-off-by: Eugenio Pérez >> > --- >> > qapi/net.json | 23 +++ >> > hw/virtio/vhost-vdpa.c

Re: [RFC PATCH v4 15/20] vhost: Shadow virtqueue buffers forwarding

2021-10-12 Thread Markus Armbruster
Eugenio Perez Martin writes: > On Tue, Oct 12, 2021 at 7:21 AM Markus Armbruster wrote: >> >> Eugenio Pérez writes: >> >> > Initial version of shadow virtqueue that actually forward buffers. There >> > are no iommu support at the moment, and that will be addressed in future >> > patches of this

Re: [PATCH 2/2] tests/unit: Add an unit test for smp parsing

2021-10-12 Thread Andrew Jones
On Sun, Oct 10, 2021 at 06:39:54PM +0800, Yanan Wang wrote: > Now that we have a generic parser smp_parse(), let's add an unit > test for the code. All possible valid/invalid SMP configurations > that the user can specify are covered. > > Signed-off-by: Yanan Wang > --- > MAINTAINERS

Re: [PATCH 1/2] numa: Set default distance map if needed

2021-10-12 Thread Igor Mammedov
On Tue, 12 Oct 2021 15:13:08 +0200 Andrew Jones wrote: > On Tue, Oct 12, 2021 at 02:27:54PM +0200, Igor Mammedov wrote: > > On Tue, 12 Oct 2021 12:37:54 +0200 > > Andrew Jones wrote: > > > > > On Tue, Oct 12, 2021 at 11:40:16AM +0200, Igor Mammedov wrote: > > > > On Wed, 6 Oct 2021 18:22:0

Re: [PATCH v3 6/6] tests/qapi-schema: Test cases for aliases

2021-10-12 Thread Kevin Wolf
Am 08.10.2021 um 12:17 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > Am 07.10.2021 um 13:06 hat Markus Armbruster geschrieben: > >> What's the smallest set of aliases sufficient to make your -chardev > >> QAPIfication work? > > > > How do you define "make the QAPIfication work"? > >

[PATCH v3 0/3] vdpa: Check iova range on memory regions ops

2021-10-12 Thread Eugenio Pérez
At this moment vdpa will not send memory regions bigger than 1<<63. However, actual iova range could be way more restrictive than that. Since we can obtain the range through vdpa ioctl call, just save it from the beginning of the operation and check against it. Changes from v2: * Fallback to a de

[PATCH v3 2/3] vdpa: Add vhost_vdpa_section_end

2021-10-12 Thread Eugenio Pérez
Abstract this operation, that will be reused when validating the region against the iova range that the device supports. Signed-off-by: Eugenio Pérez Acked-by: Jason Wang --- hw/virtio/vhost-vdpa.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/hw/vi

[PATCH v3 3/3] vdpa: Check for iova range at mappings changes

2021-10-12 Thread Eugenio Pérez
Check vdpa device range before updating memory regions so we don't add any outside of it, and report the invalid change if any. Signed-off-by: Eugenio Pérez --- include/hw/virtio/vhost-vdpa.h | 2 ++ hw/virtio/vhost-vdpa.c | 62 +- hw/virtio/trace-events

[PATCH v3 1/3] vdpa: Skip protected ram IOMMU mappings

2021-10-12 Thread Eugenio Pérez
Following the logic of commit 56918a126ae ("memory: Add RAM_PROTECTED flag to skip IOMMU mappings") with VFIO, skip memory sections inaccessible via normal mechanisms, including DMA. Signed-off-by: Eugenio Pérez Acked-by: Jason Wang --- hw/virtio/vhost-vdpa.c | 1 + 1 file changed, 1 insertion(

Re: [PATCH v2 15/24] configure, meson: move libaio check to meson.build

2021-10-12 Thread Thomas Huth
On 12/10/2021 13.12, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini Message-Id: <20211007130829.632254-10-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini Remove one S-o-b? --- block/meson.build | 2 +- configure | 31 --- meson.build | 10

Re: [PATCH 1/1] s390x:clp: implementing CLP immediate commands

2021-10-12 Thread Pierre Morel
On 10/12/21 09:27, Thomas Huth wrote: On 17/09/2021 14.06, Pierre Morel wrote: CLP immediate commands allow to query the Logical Processor available on the machine and to check for a specific one. Let's add these commands. Signed-off-by: Pierre Morel ---   hw/s390x/s390-pci-inst.c

Re: [PATCH 1/2] hw/core/machine: Split out smp_parse as an inline API

2021-10-12 Thread Markus Armbruster
"wangyanan (Y)" writes: > Hi Markus, > > On 2021/10/11 13:26, Markus Armbruster wrote: >> Yanan Wang writes: >> >>> Functionally smp_parse() is only called once and in one place >>> i.e. machine_set_smp, the possible second place where it'll be >>> called should be some unit tests if any. >>> >>

Re: [PATCH v3 6/6] tests/qapi-schema: Test cases for aliases

2021-10-12 Thread Kevin Wolf
Am 11.10.2021 um 09:44 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > [...] > > > What I had in mind was using the schema to generate the necessary code, > > using the generic keyval parser everywhere, and just providing a hook > > where the QDict could be modified after the keyval

Re: [PATCH v2 16/24] configure, meson: move vde detection to meson

2021-10-12 Thread Thomas Huth
On 12/10/2021 13.12, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau Message-Id: <20211007130829.632254-11-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure | 35 --- meson.build | 26 ++

[PATCH 0/3] s390x: reduce my maintainership duties

2021-10-12 Thread Cornelia Huck
I currently don't have enough resources to work on s390x as much anymore, so I need to reduce my workload. For many topics, we should be well-covered already, so I'll drop out from those. Don't worry (or rejoice?), though; I don't plan to disappear. Cornelia Huck (3): vfio-ccw: step down as mai

[PATCH 1/3] vfio-ccw: step down as maintainer

2021-10-12 Thread Cornelia Huck
I currently don't have time to act as vfio-ccw maintainer anymore, so remove myself there. Signed-off-by: Cornelia Huck --- MAINTAINERS | 2 -- 1 file changed, 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 50435b8d2f50..14d131294156 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1

[PATCH 3/3] s390x virtio-ccw machine: step down as maintainer

2021-10-12 Thread Cornelia Huck
I currently don't have time to work on the s390x virtio-ccw machine anymore, so let's step down. (I will, however, continue as a maintainer for the virtio-ccw *transport*.) Signed-off-by: Cornelia Huck --- MAINTAINERS | 2 -- 1 file changed, 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS

[PATCH 2/3] s390x/kvm: step down as maintainer

2021-10-12 Thread Cornelia Huck
I'm no longer involved with KVM/s390 on the kernel side, and I don't have enough resources to work on the s390 KVM cpus support, so I'll step down. Signed-off-by: Cornelia Huck --- MAINTAINERS | 2 -- 1 file changed, 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 14d131294156..234f

Re: [PATCH v2 17/24] configure, meson: move netmap detection to meson

2021-10-12 Thread Thomas Huth
On 12/10/2021 13.12, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini Message-Id: <20211007130829.632254-12-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure | 40 meson.build | 19 ++- meson_options.txt |

Re: [RFC PATCH] target/s390x: don't double ld_code() when reading instructions

2021-10-12 Thread Alex Bennée
Richard Henderson writes: > On 10/12/21 2:31 AM, Alex Bennée wrote: >> For the 4 byte instruction case we started doing an ld_code2 and then >> reloaded the data with ld_code4 once it was identified as a 4 byte op. >> This is confusing for the plugin hooks which are expecting to see >> simple s

Re: [PATCH v2 21/24] configure: remove deprecated --{enable, disable}-git-update

2021-10-12 Thread Thomas Huth
On 12/10/2021 13.12, Paolo Bonzini wrote: The options were deprecated in 6.0. That said, we do not really have a formal deprecation cycle for build-time changes, since they do not affect users. Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau Message-Id: <20211007130829.632254-16-p

Re: [PATCH] hw/elf_ops.h: switch to ssize_t for elf loader return type

2021-10-12 Thread Luc Michel
On 21:28 Wed 06 Oct , Luc Michel wrote: > Until now, int was used as the return type for all the ELF > loader related functions. The returned value is the sum of all loaded > program headers "MemSize" fields. > > Because of the overflow check in elf_ops.h, trying to load an ELF bigger > than I

[PATCH] MAINTAINERS: update location of microvm docs

2021-10-12 Thread Alex Bennée
Fixes: e8eee8d3d9 ("docs: Move microvm.rst into the system manual") Signed-off-by: Alex Bennée --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 50435b8d2f..aa8188f87a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1609,7 +1609,7

[PATCH V5] block/rbd: implement bdrv_co_block_status

2021-10-12 Thread Peter Lieven
the qemu rbd driver currently lacks support for bdrv_co_block_status. This results mainly in incorrect progress during block operations (e.g. qemu-img convert with an rbd image as source). This patch utilizes the rbd_diff_iterate2 call from librbd to detect allocated and unallocated (all zero area

Re: [PATCH v2 11/17] python/machine: remove has_quit argument

2021-10-12 Thread Hanna Reitz
On 23.09.21 02:49, John Snow wrote: If we spy on the QMP commands instead, we don't need callers to remember to pass it. Seems like a fair trade-off. The one slightly weird bit is overloading this instance variable for wait(), where we use it to mean "don't issue the qmp 'quit' command". This me

Re: [RFC PATCH] target/s390x: don't double ld_code() when reading instructions

2021-10-12 Thread Richard Henderson
On 10/12/21 7:52 AM, Alex Bennée wrote: I think the plugin stuff could be more clever, knowing where the read occurs within the sequence. Otherwise, we should simplify the interface so that it is not possible to make this mistake. It's plugin_insn_append which is doing the tracking here so we

Re: [PULL v2 00/13] some testing and plugin updates

2021-10-12 Thread Richard Henderson
On 10/12/21 2:36 AM, Alex Bennée wrote: The following changes since commit c09124dcb8401a0d635b4a52b295e9b3fc12392a: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2021-10-11 08:15:32 -0700) are available in the Git repository at: https://github.co

<    1   2   3   4   >