On 19/05/2021 12.56, Kevin Wolf wrote:
[...]
We have a bug in vpc_open(), though: It sets the local variable
disk_type correctly, but other functions use s->footer.type instead and
we never check that it actually matches the disk type we think we're
opening.
So I think we need to add this check (and we need to add it even if we
don't change probing), and then the change to vpc_probe() is probably
okay.
Right, that looks like a potential problem. I now finally sent a patch here:
https://patchew.org/QEMU/20211012082702.792259-1-th...@redhat.com/
Thomas