[PATCH 4/5] target/xtensa: list cores in a text file

2021-10-04 Thread Paolo Bonzini
Avoid that leftover files affect the build; instead, use the same mechanism that was in place before the Meson transition of updating a file from import_core.sh. Starting with Meson 0.57, the file can be easily read from the filesystem module, so do that instead of using run_command. Signed-off-b

Re: [PATCH v2 1/5] hw/arm/virt: Key enablement of highmem PCIe on highmem_ecam

2021-10-04 Thread Andrew Jones
On Sun, Oct 03, 2021 at 05:46:01PM +0100, Marc Zyngier wrote: > Currently, the highmem PCIe region is oddly keyed on the highmem > attribute instead of highmem_ecam. Move the enablement of this PCIe > region over to highmem_ecam. > > Signed-off-by: Marc Zyngier > --- > hw/arm/virt-acpi-build.c |

Re: [PATCH v2 2/5] hw/arm/virt: Add a control for the the highmem redistributors

2021-10-04 Thread Andrew Jones
On Sun, Oct 03, 2021 at 05:46:02PM +0100, Marc Zyngier wrote: > Just like we can control the enablement of the highmem PCIe region > using highmem_ecam, let's add a control for the highmem GICv3 > redistributor region. > > Similarily to highmem_ecam, these redistributors are disabled when > highme

Re: [PATCH 5/5] meson: show library versions in the summary

2021-10-04 Thread Philippe Mathieu-Daudé
On 10/4/21 11:49, Paolo Bonzini wrote: > Meson 0.57 allows passing external programs and dependency objects > to summary(). Use this to show library versions and paths in the > summary. > > Signed-off-by: Paolo Bonzini > --- > meson.build | 112 +-

Re: [PATCH 12/15] iotests: Disable AQMP logging under non-debug modes

2021-10-04 Thread Hanna Reitz
On 18.09.21 04:14, John Snow wrote: On Fri, Sep 17, 2021 at 8:58 PM John Snow > wrote: On Fri, Sep 17, 2021 at 10:30 AM Hanna Reitz mailto:hre...@redhat.com>> wrote: On 17.09.21 07:40, John Snow wrote: > Disable the aqmp logger, which likes to (

Re: [PATCH v2 5/5] hw/arm/virt: Disable highmem devices that don't fit in the PA range

2021-10-04 Thread Andrew Jones
On Sun, Oct 03, 2021 at 05:46:05PM +0100, Marc Zyngier wrote: > Make sure both the highmem PCIe and GICv3 regions are disabled when > they don't fully fit in the PA range. > > Signed-off-by: Marc Zyngier > --- > hw/arm/virt.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/arm/vi

Re: [PATCH v2 3/5] hw/arm/virt: Honor highmem setting when computing the memory map

2021-10-04 Thread Andrew Jones
On Sun, Oct 03, 2021 at 05:46:03PM +0100, Marc Zyngier wrote: > Even when the VM is configured with highmem=off, the highest_gpa > field includes devices that are above the 4GiB limit. > Similarily, nothing seem to check that the memory is within > the limit set by the highmem=off option. > > This

Re: [PATCH] hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts

2021-10-04 Thread BALATON Zoltan
On Sun, 3 Oct 2021, BALATON Zoltan wrote: This device is part of a sperio/ISA bridge chip and IRQs from it are routed to an ISA interrupt set by the Interrupt Line PCI config register. Change uhci_update_irq() to allow this and use it from vt82c686-uhci-pci. Signed-off-by: BALATON Zoltan --- Ma

Re: [PATCH v2 2/5] hw/arm/virt: Add a control for the the highmem redistributors

2021-10-04 Thread Andrew Jones
On Mon, Oct 04, 2021 at 11:44:08AM +0200, Andrew Jones wrote: > On Sun, Oct 03, 2021 at 05:46:02PM +0100, Marc Zyngier wrote: ... > > > > -return MACHINE(vms)->smp.cpus > redist0_capacity ? 2 : 1; > > +return (MACHINE(vms)->smp.cpus > redist0_capacity && > > +vms->highmem_redi

Re: [PATCH 0/1] vmx: Fix mapping

2021-10-04 Thread Richard W.M. Jones
It turns out that changing the qemu implementation is painful, particularly if we wish to maintain backwards compatibility of the command line and live migration. Instead I opted to document comprehensively what all the different hypervisors do: https://github.com/libguestfs/virt-v2v/blob/mast

Re: [PATCH v2 4/5] hw/arm/virt: Use the PA range to compute the memory map

2021-10-04 Thread Andrew Jones
On Sun, Oct 03, 2021 at 05:46:04PM +0100, Marc Zyngier wrote: ... > @@ -1662,9 +1665,17 @@ static void virt_set_memmap(VirtMachineState *vms) > vms->memmap[i].size = size; > base += size; > } > -vms->highest_gpa = (vms->highmem ? > -base : > -

Re: [PULL 03/20] nubus-device: expose separate super slot memory region

2021-10-04 Thread BALATON Zoltan
On Mon, 4 Oct 2021, Laurent Vivier wrote: Le 02/10/2021 à 12:33, Peter Maydell a écrit : On Wed, 29 Sept 2021 at 10:49, Laurent Vivier wrote: From: Mark Cave-Ayland According to "Designing Cards and Drivers for the Macintosh Family" each physical nubus slot can access 2 separate address ra

Re: [RFC PATCH 0/4] Misc OHCI patches

2021-10-04 Thread BALATON Zoltan
On Mon, 4 Oct 2021, Howard Spoelstra wrote: Hi all, One more observation: When running Mac OS guests with -mac99,via=pmu, the guest is presented with a usb-mouse and usb-kbd, while -mac99 provides cuda mouse/kbd. If I run with via=pmu, the mouse/kbd will not work when passing through the usb h

Re: [PATCH v2 4/5] hw/arm/virt: Use the PA range to compute the memory map

2021-10-04 Thread Andrew Jones
On Sun, Oct 03, 2021 at 05:46:04PM +0100, Marc Zyngier wrote: > The highmem attribute is nothing but another way to express the > PA range of a VM. To support HW that has a smaller PA range then > what QEMU assumes, pass this PA range to the virt_set_memmap() > function, allowing it to correctly ex

Re: [PATCH 06/12] macfb: implement mode sense to allow display type to be detected

2021-10-04 Thread BALATON Zoltan
On Mon, 4 Oct 2021, Laurent Vivier wrote: Le 02/10/2021 à 13:00, Mark Cave-Ayland a écrit : The MacOS toolbox ROM uses the monitor sense to detect the display type and then offer a fixed set of resolutions and colour depths accordingly. Implement the monitor sense using information found in Appl

Re: virtio 4M limit

2021-10-04 Thread Christian Schoenebeck
On Sonntag, 3. Oktober 2021 22:27:03 CEST Michael S. Tsirkin wrote: > On Sun, Oct 03, 2021 at 08:14:55PM +0200, Christian Schoenebeck wrote: > > On Freitag, 1. Oktober 2021 13:21:23 CEST Christian Schoenebeck wrote: > > > Hi Michael, > > > > > > while testing the following kernel patches I realize

Re: [PATCH 06/12] macfb: implement mode sense to allow display type to be detected

2021-10-04 Thread Laurent Vivier
Le 04/10/2021 à 12:32, BALATON Zoltan a écrit : > On Mon, 4 Oct 2021, Laurent Vivier wrote: >> Le 02/10/2021 à 13:00, Mark Cave-Ayland a écrit : >>> The MacOS toolbox ROM uses the monitor sense to detect the display type and >>> then >>> offer a fixed set of resolutions and colour depths according

Re: [PATCH v3 1/3] tests/acpi/bios-tables-test: add and allow changes to a new q35 DSDT table blob

2021-10-04 Thread Ani Sinha
ping ... On Mon, Sep 20, 2021 at 12:31 PM Ani Sinha wrote: > > We are adding a new unit test to cover the acpi hotplug support in q35 for > multi-function bridges. This test uses a new table DSDT.multi-bridge. > We need to allow changes in DSDT acpi table for addition of this new > unit test. > >

Re: [PATCH v3 3/3] tests/acpi/bios-tables-test: update DSDT blob for multifunction bridge test

2021-10-04 Thread Ani Sinha
ping On Mon, Sep 20, 2021 at 12:31 PM Ani Sinha wrote: > > We added a new unit test for testing acpi hotplug on multifunction bridges in > q35 machines. Here, we update the DSDT table gloden master blob for this unit > test. > > Following is the ASL diff between the original DSDT table and the mo

Re: [PATCH v3 0/3] tests/acpi/pcihp: add unit tests for hotplug on multifunction bridges for q35

2021-10-04 Thread Ani Sinha
ping On Thu, Sep 23, 2021 at 12:44 PM Ani Sinha wrote: > > ping ... > > On Mon, 20 Sep 2021, Ani Sinha wrote: > > > This patchset adds a unit test to exercize acpi hotplug support for > > multifunction > > bridges on q35 machines. This support was added with the commit: > > > > d7346e614f4ec ("a

Re: [PATCH 1/1] hw: aspeed_gpio: Fix GPIO array indexing

2021-10-04 Thread Cédric Le Goater
On 10/4/21 11:07, Cédric Le Goater wrote: On 9/28/21 05:43, p...@fb.com wrote: From: Peter Delevoryas The gpio array is declared as a dense array:    qemu_irq gpios[ASPEED_GPIO_NR_PINS]; (AST2500 has 228, AST2400 has 216, AST2600 has 208) However, this array is used like a matrix of GPIO se

Re: [PATCH v2 1/5] hw/arm/virt: Key enablement of highmem PCIe on highmem_ecam

2021-10-04 Thread Eric Auger
Hi Marc, On 10/3/21 6:46 PM, Marc Zyngier wrote: > Currently, the highmem PCIe region is oddly keyed on the highmem > attribute instead of highmem_ecam. Move the enablement of this PCIe > region over to highmem_ecam. > > Signed-off-by: Marc Zyngier > --- > hw/arm/virt-acpi-build.c | 10 -

[PATCH v4 2/7] util/oslib-posix: Support MADV_POPULATE_WRITE for os_mem_prealloc()

2021-10-04 Thread David Hildenbrand
Let's sense support and use it for preallocation. MADV_POPULATE_WRITE does not require a SIGBUS handler, doesn't actually touch page content, and avoids context switches; it is, therefore, faster and easier to handle than our current approach. While MADV_POPULATE_WRITE is, in general, faster than

[PATCH v4 1/7] util/oslib-posix: Let touch_all_pages() return an error

2021-10-04 Thread David Hildenbrand
Let's prepare touch_all_pages() for returning differing errors. Return an error from the thread and report the last processed error. Translate SIGBUS to -EFAULT, as a SIGBUS can mean all different kind of things (memory error, read error, out of memory). When allocating memory fails via the curren

[PATCH v4 6/7] util/oslib-posix: Support concurrent os_mem_prealloc() invocation

2021-10-04 Thread David Hildenbrand
Add a mutex to protect the SIGBUS case, as we cannot mess concurrently with the sigbus handler and we have to manage the global variable sigbus_memset_context. The MADV_POPULATE_WRITE path can run concurrently. Note that page_mutex and page_cond are shared between concurrent invocations, which sho

[PATCH v4 3/7] util/oslib-posix: Introduce and use MemsetContext for touch_all_pages()

2021-10-04 Thread David Hildenbrand
Let's minimize the number of global variables to prepare for os_mem_prealloc() getting called concurrently and make the code a bit easier to read. The only consumer that really needs a global variable is the sigbus handler, which will require protection via a mutex in the future either way as we c

[PATCH v4 7/7] util/oslib-posix: Forward SIGBUS to MCE handler under Linux

2021-10-04 Thread David Hildenbrand
Temporarily modifying the SIGBUS handler is really nasty, as we might be unlucky and receive an MCE SIGBUS while having our handler registered. Unfortunately, there is no way around messing with SIGBUS when MADV_POPULATE_WRITE is not applicable or not around. Let's forward SIGBUS that don't belong

[PATCH v4 4/7] util/oslib-posix: Don't create too many threads with small memory or little pages

2021-10-04 Thread David Hildenbrand
Let's limit the number of threads to something sane, especially that - We don't have more threads than the number of pages we have - We don't have threads that initialize small (< 64 MiB) memory Reviewed-by: Pankaj Gupta Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Daniel P. Berrangé Signed

[PATCH v4 5/7] util/oslib-posix: Avoid creating a single thread with MADV_POPULATE_WRITE

2021-10-04 Thread David Hildenbrand
Let's simplify the case when we only want a single thread and don't have to mess with signal handlers. Reviewed-by: Pankaj Gupta Reviewed-by: Daniel P. Berrangé Signed-off-by: David Hildenbrand --- util/oslib-posix.c | 8 1 file changed, 8 insertions(+) diff --git a/util/oslib-posix.

[PATCH v4 0/7] util/oslib-posix: Support MADV_POPULATE_WRITE for os_mem_prealloc()

2021-10-04 Thread David Hildenbrand
#1 is a preparation for improved error reporting, #2 adds support for MADV_POPULATE_WRITE, #3 cleans up the code to avoid global variables and prepare for concurrency, #4 and #5 optimize thread handling, #6 makes os_mem_prealloc() safe to be called from multiple threads concurrently and #7 makes th

Re: [PATCH v3 03/19] docs/devel: document expectations for QAPI data modelling for QMP

2021-10-04 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > Traditionally we have required that newly added QMP commands will model > any returned data using fine grained QAPI types. This is good for > commands that are intended to be consumed by machines, where clear data > representation is very importan

Re: [PATCH v2 3/5] hw/arm/virt: Honor highmem setting when computing the memory map

2021-10-04 Thread Eric Auger
Hi Marc, On 10/3/21 6:46 PM, Marc Zyngier wrote: > Even when the VM is configured with highmem=off, the highest_gpa > field includes devices that are above the 4GiB limit. > Similarily, nothing seem to check that the memory is within > the limit set by the highmem=off option. > > This leads to fai

Re: [PATCH v3 03/19] docs/devel: document expectations for QAPI data modelling for QMP

2021-10-04 Thread Daniel P . Berrangé
On Mon, Oct 04, 2021 at 01:13:00PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > Traditionally we have required that newly added QMP commands will model > > any returned data using fine grained QAPI types. This is good for > > commands that are intende

Re: [PATCH 09/11] qdev: Avoid QemuOpts in QMP device_add

2021-10-04 Thread Damien Hedde
On 10/1/21 16:42, Peter Krempa wrote: On Fri, Sep 24, 2021 at 11:04:25 +0200, Kevin Wolf wrote: Directly call qdev_device_add_from_qdict() for QMP device_add instead of first going through QemuOpts and converting back to QDict. Note that this changes the behaviour of device_add, though in wa

Re: [RFC PATCH 1/1] virtio: write back features before verify

2021-10-04 Thread Cornelia Huck
[cc:qemu-devel] On Sat, Oct 02 2021, "Michael S. Tsirkin" wrote: > On Fri, Oct 01, 2021 at 09:21:25AM +0200, Halil Pasic wrote: >> On Thu, 30 Sep 2021 07:12:21 -0400 >> "Michael S. Tsirkin" wrote: >> >> > On Thu, Sep 30, 2021 at 03:20:49AM +0200, Halil Pasic wrote: >> > > This patch fixes a

Re: [PATCH v3 07/19] qapi: introduce x-query-roms QMP command

2021-10-04 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > This is a counterpart to the HMP "info roms" command. It is being > added with an "x-" prefix because this QMP command is intended as an > adhoc debugging tool and will thus not be modelled in QAPI as fully > structured data, nor will it have long

Re: [RFC PATCH 1/1] virtio: write back features before verify

2021-10-04 Thread Michael S. Tsirkin
On Mon, Oct 04, 2021 at 02:19:55PM +0200, Cornelia Huck wrote: > > [cc:qemu-devel] > > On Sat, Oct 02 2021, "Michael S. Tsirkin" wrote: > > > On Fri, Oct 01, 2021 at 09:21:25AM +0200, Halil Pasic wrote: > >> On Thu, 30 Sep 2021 07:12:21 -0400 > >> "Michael S. Tsirkin" wrote: > >> > >> > On Th

Re: [PATCH 01/13] virtio_fs.h: Add notification queue feature bit

2021-10-04 Thread Stefan Hajnoczi
On Thu, Sep 30, 2021 at 11:30:25AM -0400, Vivek Goyal wrote: > This change will ultimately come from kernel as kernel header file update > when kernel patches get merged. > > Signed-off-by: Vivek Goyal > --- > include/standard-headers/linux/virtio_fs.h | 3 +++ > 1 file changed, 3 insertions(+)

Re: [PATCH 03/13] virtiofsd: Remove unused virtio_fs_config definition

2021-10-04 Thread Stefan Hajnoczi
On Thu, Sep 30, 2021 at 11:30:27AM -0400, Vivek Goyal wrote: > "struct virtio_fs_config" definition seems to be unused in fuse_virtio.c. > Remove it. > > Signed-off-by: Vivek Goyal > --- > tools/virtiofsd/fuse_virtio.c | 6 -- > 1 file changed, 6 deletions(-) In fact, this struct is defined

Re: [PATCH 02/13] virtiofsd: fuse.h header file changes for lock notification

2021-10-04 Thread Stefan Hajnoczi
On Thu, Sep 30, 2021 at 11:30:26AM -0400, Vivek Goyal wrote: > This change comes from fuse.h kernel header file udpate. Hence keeping > it in a separate patch. QEMU syncs include/standard-headers/linux/ from linux.git. Please indicate the status of this fuse.h change: - Is it already in a Linux re

Re: [PATCH 04/13] virtiofsd: Add a helper to send element on virtqueue

2021-10-04 Thread Stefan Hajnoczi
On Thu, Sep 30, 2021 at 11:30:28AM -0400, Vivek Goyal wrote: > We have open coded logic to take locks and push element on virtqueue at > three places. Add a helper and use it everywhere. Code is easier to read and > less number of lines of code. > > Signed-off-by: Vivek Goyal > --- > tools/virti

Re: [PATCH 05/13] virtiofsd: Add a helper to stop all queues

2021-10-04 Thread Stefan Hajnoczi
On Thu, Sep 30, 2021 at 11:30:29AM -0400, Vivek Goyal wrote: > Use a helper to stop all the queues. Later in the patch series I am > planning to use this helper at one more place later in the patch series. > > Signed-off-by: Vivek Goyal > --- > tools/virtiofsd/fuse_virtio.c | 22 +---

[PATCH v1 4/7] hw/arm/bcm2835_peripherals: Map various BCM2711 blocks

2021-10-04 Thread Alex Bennée
From: Philippe Mathieu-Daudé The BCM2711 provides more peripherals. Add them as 'unimplemented' so we can track when/how firmware and kernel access them. Based on various sources: * U-boot: https://github.com/raspberrypi/firmware/tree/next/boot - arch/arm/dts/bcm283x.dtsi - arch/arm/dts/bc

[PATCH v1 1/7] hw/misc/bcm2835_property: Add FIXME comment for uninitialized memory

2021-10-04 Thread Alex Bennée
From: Philippe Mathieu-Daudé We are returning unintialized memory, this is probably unsafe. Reported-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- hw/misc/bcm2835_property.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/misc/bcm2835_propert

[PATCH v1 7/7] hw/arm/raspi: Add the Raspberry Pi 4B board

2021-10-04 Thread Alex Bennée
From: Philippe Mathieu-Daudé The Raspberry Pi 4 uses a BCM2711 SoC (based on a BCM2838). Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- vAJB: - use 8gb version --- hw/arm/raspi.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hw/arm/raspi.c b/hw/ar

[PATCH v1 2/7] hw/misc/bcm2835_property: Handle the 'domain state' property

2021-10-04 Thread Alex Bennée
From: Philippe Mathieu-Daudé The kernel is happy with this change, so we don't need to do anything more sophisticated. Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- hw/misc/bcm2835_property.c | 8 1 file changed, 8 insertions(+) dif

[PATCH v1 0/7] enabling RasperryPi 4 emulation - WIP state

2021-10-04 Thread Alex Bennée
Hi Phillipe, I needed to test some Xen things on a model I could debug so I took the liberty of re-basing you patches from a 2 years ago. Most of the changes involve dropping patches since merged and dealing with the resultant merging fallout. The fix I posted on Friday for the calculation of the

[PATCH v1 6/7] hw/arm/bcm2838: Map the PCIe memory space

2021-10-04 Thread Alex Bennée
From: Philippe Mathieu-Daudé The BCM2711 has a BCM54213 Gigabit Ethernet block mapped in the PCIe range. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- FIXME: create the bcm54213-geth in raspi.c? vAJB: - fix for move of gic_base to bc --- hw/arm/bcm2836.c | 10 +++

[PATCH v1 5/7] hw/arm/bcm2836: Add the BCM2711 which uses a GICv2

2021-10-04 Thread Alex Bennée
From: Philippe Mathieu-Daudé The BCM2711 is improvement of the BCM2837: - Cortex-A72 instead of the A53 - peripheral block and local soc controller are mapped differently, - GICv2 - PCIe block - exhanced MMU to address over 4GiB of SDRAM See https://www.raspberrypi.org/forums/viewtopic.php?t=244

Re: [PATCH 06/13] vhost-user-fs: Use helpers to create/cleanup virtqueue

2021-10-04 Thread Stefan Hajnoczi
On Thu, Sep 30, 2021 at 11:30:30AM -0400, Vivek Goyal wrote: > Add helpers to create/cleanup virtuqueues and use those helpers. I will s/virtuqueues/virtqueues/ > need to reconfigure queues in later patches and using helpers will allow > reusing the code. > > Signed-off-by: Vivek Goyal > --- >

[PATCH v1 3/7] hw/arm: fix the position of vcram for raspi

2021-10-04 Thread Alex Bennée
The previous calculation fell over when I tried to create a 8gb Pi 4 because the values were only 32 bit. However the quirk of the Pi hardware is the vcram can only appear in the first 1gb of address space. This also limits where the initial kernel and DTB can be loaded (notice the DTS for the 8gb

[PATCH v3] i386: docs: Briefly describe KVM PV features

2021-10-04 Thread Vitaly Kuznetsov
KVM PV features don't seem to be documented anywhere, in particular, the fact that some of the features are enabled by default and some are not can only be figured out from the code. Signed-off-by: Vitaly Kuznetsov --- Changes since "[PATCH v2 0/8] i386: Assorted KVM PV and Hyper-V feature impro

Re: [PATCH v3 6/6] tests/qapi-schema: Test cases for aliases

2021-10-04 Thread Kevin Wolf
Am 02.10.2021 um 15:33 hat Markus Armbruster geschrieben: > I apologize for this wall of text. It's a desparate attempt to cut > through the complexity and my confusion, and make sense of the actual > problems we're trying to solve. > > So, what problems exactly are we trying to solve? I'll star

Re: [PATCH 02/13] virtiofsd: fuse.h header file changes for lock notification

2021-10-04 Thread Vivek Goyal
On Mon, Oct 04, 2021 at 02:16:18PM +0100, Stefan Hajnoczi wrote: > On Thu, Sep 30, 2021 at 11:30:26AM -0400, Vivek Goyal wrote: > > This change comes from fuse.h kernel header file udpate. Hence keeping > > it in a separate patch. > > QEMU syncs include/standard-headers/linux/ from linux.git. Plea

Re: [PATCH 09/11] qdev: Avoid QemuOpts in QMP device_add

2021-10-04 Thread Kevin Wolf
Am 04.10.2021 um 14:18 hat Damien Hedde geschrieben: > > > On 10/1/21 16:42, Peter Krempa wrote: > > On Fri, Sep 24, 2021 at 11:04:25 +0200, Kevin Wolf wrote: > > > Directly call qdev_device_add_from_qdict() for QMP device_add instead of > > > first going through QemuOpts and converting back to Q

Re: [PATCH 08/13] virtiofsd: Create a notification queue

2021-10-04 Thread Stefan Hajnoczi
On Thu, Sep 30, 2021 at 11:30:32AM -0400, Vivek Goyal wrote: > Add a notification queue which will be used to send async notifications > for file lock availability. > > Signed-off-by: Vivek Goyal > Signed-off-by: Ioannis Angelakopoulos > --- > hw/virtio/vhost-user-fs-pci.c | 4 +- > hw/vir

Re: [RFC PATCH 1/1] virtio: write back features before verify

2021-10-04 Thread Cornelia Huck
On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote: > On Mon, Oct 04, 2021 at 02:19:55PM +0200, Cornelia Huck wrote: >> >> [cc:qemu-devel] >> >> On Sat, Oct 02 2021, "Michael S. Tsirkin" wrote: >> >> > On Fri, Oct 01, 2021 at 09:21:25AM +0200, Halil Pasic wrote: >> >> On Thu, 30 Sep 2021 07:12:2

Re: [PATCH 09/13] virtiofsd: Specify size of notification buffer using config space

2021-10-04 Thread Stefan Hajnoczi
On Thu, Sep 30, 2021 at 11:30:33AM -0400, Vivek Goyal wrote: > Daemon specifies size of notification buffer needed and that should be > done using config space. > > Only ->notify_buf_size value of config space comes from daemon. Rest of > it is filled by qemu device emulation code. > > Signed-off

Re: [PATCH 07/12] macfb: add qdev property to specify display type

2021-10-04 Thread Laurent Vivier
On 04/10/2021 11:24, Laurent Vivier wrote: Le 02/10/2021 à 13:00, Mark Cave-Ayland a écrit : Since the available resolutions and colour depths are determined by the attached display type, add a qdev property to allow the display type to be specified. The main resolutions of interest are high re

Re: [PATCH 08/12] macfb: add common monitor modes supported by the MacOS toolbox ROM

2021-10-04 Thread Laurent Vivier
On 02/10/2021 13:00, Mark Cave-Ayland wrote: The monitor modes table is found by experimenting with the Monitors Control Panel in MacOS and analysing the reads/writes. From this it can be found that the mode is controlled by writes to the DAFB_MODE_CTRL1 and DAFB_MODE_CTRL2 registers. Implement

Re: [PATCH 10/12] macfb: fix 24-bit RGB pixel encoding

2021-10-04 Thread Laurent Vivier
On 02/10/2021 13:00, Mark Cave-Ayland wrote: According to Apple Technical Note HW26: "Macintosh Quadra Built-In Video" the in-built framebuffer encodes each 24-bit pixel into 4 bytes. Adjust the 24-bit RGB pixel encoding accordingly which agrees with the encoding expected by MacOS when changing i

Re: [PATCH 09/12] macfb: fix up 1-bit pixel encoding

2021-10-04 Thread Laurent Vivier
On 02/10/2021 13:00, Mark Cave-Ayland wrote: The MacOS driver expects the RGB values for the pixel to be in entries 0 and 1 of the colour palette. Signed-off-by: Mark Cave-Ayland --- hw/display/macfb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/display/macfb.c

Re: [PATCH 0/1] vmx: Fix mapping

2021-10-04 Thread Laszlo Ersek
On 10/04/21 11:59, Richard W.M. Jones wrote: > It turns out that changing the qemu implementation is painful, > particularly if we wish to maintain backwards compatibility of the > command line and live migration. > > Instead I opted to document comprehensively what all the > different hypervisors

Re: [PATCH 10/13] virtiofsd: Custom threadpool for remote blocking posix locks requests

2021-10-04 Thread Stefan Hajnoczi
On Thu, Sep 30, 2021 at 11:30:34AM -0400, Vivek Goyal wrote: > Add a new custom threadpool using posix threads that specifically > service locking requests. > > In the case of a fcntl(SETLKW) request, if the guest is waiting > for a lock or locks and issues a hard-reboot through SYSRQ then virtiof

Re: [PATCH 11/13] virtiofsd: Shutdown notification queue in the end

2021-10-04 Thread Stefan Hajnoczi
On Thu, Sep 30, 2021 at 11:30:35AM -0400, Vivek Goyal wrote: > So far we did not have the notion of cross queue traffic. That is, we > get request on a queue and send back response on same queue. So if a > request be being processed and at the same time a stop queue request > comes in, we wait for

Re: [PATCH 0/1] vmx: Fix mapping

2021-10-04 Thread Richard W.M. Jones
On Mon, Oct 04, 2021 at 04:50:51PM +0200, Laszlo Ersek wrote: > On 10/04/21 11:59, Richard W.M. Jones wrote: > > It turns out that changing the qemu implementation is painful, > > particularly if we wish to maintain backwards compatibility of the > > command line and live migration. > > > > Instead

Re: [PATCH 12/13] virtiofsd: Implement blocking posix locks

2021-10-04 Thread Stefan Hajnoczi
On Thu, Sep 30, 2021 at 11:30:36AM -0400, Vivek Goyal wrote: > As of now we don't support fcntl(F_SETLKW) and if we see one, we return > -EOPNOTSUPP. > > Change that by accepting these requests and returning a reply > immediately asking caller to wait. Once lock is available, send a > notification

[PATCH v0 0/2] virtio-blk and vhost-user-blk cross-device migration

2021-10-04 Thread Denis Plotnikov
It might be useful for the cases when a slow block layer should be replaced with a more performant one on running VM without stopping, i.e. with very low downtime comparable with the one on migration. It's possible to achive that for two reasons: 1.The VMStates of "virtio-blk" and "vhost-user-blk

[PATCH v0 2/2] vhost-user-blk-pci: add new pci device type to support vhost-user-virtio-blk

2021-10-04 Thread Denis Plotnikov
To allow the recently added vhost-user-virtio-blk work via virtio-pci. This patch refactors the vhost-user-blk-pci object model to reuse the existing code. Signed-off-by: Denis Plotnikov --- hw/virtio/vhost-user-blk-pci.c | 43 +++--- 1 file changed, 40 insertions(+)

Re: [RFC PATCH 1/1] virtio: write back features before verify

2021-10-04 Thread Michael S. Tsirkin
On Mon, Oct 04, 2021 at 04:33:21PM +0200, Cornelia Huck wrote: > On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote: > > > On Mon, Oct 04, 2021 at 02:19:55PM +0200, Cornelia Huck wrote: > >> > >> [cc:qemu-devel] > >> > >> On Sat, Oct 02 2021, "Michael S. Tsirkin" wrote: > >> > >> > On Fri, Oct 0

[PATCH v0 1/2] vhost-user-blk: add a new vhost-user-virtio-blk type

2021-10-04 Thread Denis Plotnikov
The main reason of adding a new type is to make cross-device live migration between "virtio-blk" and "vhost-user-blk" devices possible in both directions. It might be useful for the cases when a slow block layer should be replaced with a more performant one on running VM without stopping, i.e. wit

Re: [PATCH v0 0/2] virtio-blk and vhost-user-blk cross-device migration

2021-10-04 Thread Michael S. Tsirkin
On Mon, Oct 04, 2021 at 06:07:29PM +0300, Denis Plotnikov wrote: > It might be useful for the cases when a slow block layer should be replaced > with a more performant one on running VM without stopping, i.e. with very low > downtime comparable with the one on migration. > > It's possible to achiv

Re: [PATCH v0 1/2] vhost-user-blk: add a new vhost-user-virtio-blk type

2021-10-04 Thread Michael S. Tsirkin
On Mon, Oct 04, 2021 at 06:07:30PM +0300, Denis Plotnikov wrote: > Adding the new vhost-user-blk type instead of modifying the existing one > is convenent. It ease to differ the new virtio-blk-compatible vhost-user-blk > device from the existing non-compatible one using qemu machinery without any >

[RFC PATCH] .github: move repo lockdown to the v2 configuration

2021-10-04 Thread Alex Bennée
I was getting prompted by GitHub for new permissions but it turns out per https://github.com/dessant/repo-lockdown/issues/6: Repo Lockdown has been rewritten for GitHub Actions, offering new features and better control over your automation presets. The legacy GitHub App has been deprecated,

[PATCH 1/4] aspeed/wdt: Add trace events

2021-10-04 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/watchdog/wdt_aspeed.c | 5 + hw/watchdog/trace-events | 4 2 files changed, 9 insertions(+) diff --git a/hw/watchdog/wdt_aspeed.c b/hw/watchdog/wdt_aspeed.c index 69c37af9a6e9..146ffcd71301 100644 --- a/hw/watchdog/wdt_aspeed.c +++ b/hw/watchdog/wd

Re: [PATCH v1 5/7] hw/arm/bcm2836: Add the BCM2711 which uses a GICv2

2021-10-04 Thread Alex Bennée
Alex Bennée writes: > From: Philippe Mathieu-Daudé > > The BCM2711 is improvement of the BCM2837: > - Cortex-A72 instead of the A53 > - peripheral block and local soc controller are mapped differently, > - GICv2 > - PCIe block > - exhanced MMU to address over 4GiB of SDRAM > > --- > vAJB: >

[PATCH 2/4] aspeed/smc: Dump address offset in trace events

2021-10-04 Thread Cédric Le Goater
The register index is currently printed and this is confusing. Signed-off-by: Cédric Le Goater --- hw/ssi/aspeed_smc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c index 7129341c129e..8a988c167604 100644 --- a/hw/ssi/aspeed_s

Re: [RFC PATCH 1/1] virtio: write back features before verify

2021-10-04 Thread Cornelia Huck
On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote: > On Mon, Oct 04, 2021 at 04:33:21PM +0200, Cornelia Huck wrote: >> On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote: >> >> > On Mon, Oct 04, 2021 at 02:19:55PM +0200, Cornelia Huck wrote: >> >> >> >> [cc:qemu-devel] >> >> >> >> On Sat, Oct 02 2

[PATCH 3/4] aspeed/wdt: Add an alias for the MMIO region

2021-10-04 Thread Cédric Le Goater
Initialize the region in the instance_init handler because we will want to link this region in the FMC object before the WDT object is realized. Cc: Peter Delevoryas Signed-off-by: Cédric Le Goater --- include/hw/watchdog/wdt_aspeed.h | 1 + hw/watchdog/wdt_aspeed.c | 15 --

Re: [RFC PATCH v2 00/16] Initial support for machine creation via QMP

2021-10-04 Thread Damien Hedde
Hi, This is both a ping and a small update. It would be great to have some feedback about patches 1 and 3. Right now the device part of this series conflicts with Kevin 's work about replacing the QemuOpts by a QemuDict in device_add: https://lists.gnu.org/archive/html/qemu-devel/2021-09/msg

[PATCH 4/4] aspeed/smc: Improve support for the alternate boot function

2021-10-04 Thread Cédric Le Goater
Map the WDT2 registers in the AST2600 FMC memory region by creating a local address space on top of WDT2 memory region. The model only implements the enable bit of the control register. The reload register uses a 0.1s unit instead of a 1us. Values are converted on the fly when doing the accesses.

Re: [PATCH v3 07/19] qapi: introduce x-query-roms QMP command

2021-10-04 Thread Daniel P . Berrangé
On Mon, Oct 04, 2021 at 01:32:14PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > This is a counterpart to the HMP "info roms" command. It is being > > added with an "x-" prefix because this QMP command is intended as an > > adhoc debugging tool and wil

[PATCH 0/4] aspeed/smc: Improve support for the alternate boot function

2021-10-04 Thread Cédric Le Goater
Hello, The Aspeed SoCs have a dual boot function for firmware fail-over recovery. The system auto-reboots from the second flash if the main flash does not boot successfully within a certain amount of time. This function is called alternate boot (ABR) in the FMC controllers. On the AST2600, the AB

Re: [PATCH v3 01/19] docs/devel: rename file for writing monitor commands

2021-10-04 Thread Eric Blake
On Thu, Sep 30, 2021 at 02:23:31PM +0100, Daniel P. Berrangé wrote: > The file already covers writing HMP commands, in addition to > the QMP commands, so it deserves a more general name. > > Signed-off-by: Daniel P. Berrangé > --- > docs/devel/index.rst| 2

Re: [RFC PATCH] .github: move repo lockdown to the v2 configuration

2021-10-04 Thread Willian Rampazzo
On Mon, Oct 4, 2021 at 12:45 PM Alex Bennée wrote: > > I was getting prompted by GitHub for new permissions but it turns out > per https://github.com/dessant/repo-lockdown/issues/6: > > Repo Lockdown has been rewritten for GitHub Actions, offering new > features and better control over your au

Re: [RFC] hw/arm/virt-acpi-build: Add IORT RMR regions to handle MSI nested binding

2021-10-04 Thread Eric Auger
Hi, On 9/28/21 7:44 PM, Eric Auger wrote: > To handle SMMUv3 nested stage support it is practical to > expose the guest with reserved memory regions (RMRs) > covering the IOVAs used by the host kernel to map > physical MSI doorbells. > > Those IOVAs belong to [0x800, 0x810] matching > MSI_

Re: [PATCH 11/12] macfb: add vertical blank interrupt

2021-10-04 Thread Laurent Vivier
Le 02/10/2021 à 13:00, Mark Cave-Ayland a écrit : > The MacOS driver expects a 60.15Hz vertical blank interrupt to be generated by > the framebuffer which in turn schedules the mouse driver via the Vertical > Retrace > Manager. > > Signed-off-by: Mark Cave-Ayland > --- > hw/display/macfb.c

Re: [PULL 00/12] jobs: mirror: Handle errors after READY cancel

2021-10-04 Thread Hanna Reitz
On 24.09.21 00:01, Vladimir Sementsov-Ogievskiy wrote: 22.09.2021 22:19, Vladimir Sementsov-Ogievskiy wrote: 22.09.2021 19:05, Richard Henderson wrote: On 9/21/21 3:20 AM, Vladimir Sementsov-Ogievskiy wrote: The following changes since commit 326ff8dd09556fc2e257196c49f35009700794ac:    Merg

Re: [PATCH v4 0/2] x86/sev: Measured Linux SEV guest with kernel/initrd/cmdline

2021-10-04 Thread Dov Murik
On 04/10/2021 11:03, Paolo Bonzini wrote: > Queued, thanks. However, it would be nice to have a documentation of > all our SEV firmware interfaces somewhere in docs/specs/. Thanks Paolo. I'll try to arrange a skeleton for such document. So far I think we have the following interfaces: 1. SEV

RE: [PATCH v3 0/9] hw/nvram: hw/arm: Introduce Xilinx eFUSE and BBRAM

2021-10-04 Thread Tong Ho
Hi Peter, I will follow up with patches to fix the memory leaks. Where can I get a copy of the Coverity reports that have the 10 issues you indicated? Thanks, Tong -Original Message- From: Peter Maydell Sent: Saturday, October 2, 2021 3:28 AM To: Tong Ho Cc: qemu-arm ; QEMU Develope

Re: [PULL 00/12] jobs: mirror: Handle errors after READY cancel

2021-10-04 Thread Vladimir Sementsov-Ogievskiy
10/4/21 19:47, Hanna Reitz wrote: On 24.09.21 00:01, Vladimir Sementsov-Ogievskiy wrote: 22.09.2021 22:19, Vladimir Sementsov-Ogievskiy wrote: 22.09.2021 19:05, Richard Henderson wrote: On 9/21/21 3:20 AM, Vladimir Sementsov-Ogievskiy wrote: The following changes since commit 326ff8dd09556fc2

Re: [PATCH v3 04/19] docs/devel: add example of command returning unstructured text

2021-10-04 Thread Eric Blake
On Thu, Sep 30, 2021 at 02:23:34PM +0100, Daniel P. Berrangé wrote: > This illustrates how to add a QMP command returning unstructured text, > following the guidelines added in the previous patch. The example uses > a simplified version of 'info roms'. > > Signed-off-by: Daniel P. Berrangé > ---

Re: [PATCH 12/15] iotests: Disable AQMP logging under non-debug modes

2021-10-04 Thread John Snow
On Mon, Oct 4, 2021 at 6:12 AM Hanna Reitz wrote: > On 18.09.21 04:14, John Snow wrote: > > > > > > On Fri, Sep 17, 2021 at 8:58 PM John Snow > > wrote: > > > > > > > > On Fri, Sep 17, 2021 at 10:30 AM Hanna Reitz > > wrote: > > > >

Re: [PATCH v3 05/19] docs/devel: document expectations for HMP commands in the future

2021-10-04 Thread Eric Blake
On Thu, Sep 30, 2021 at 02:23:35PM +0100, Daniel P. Berrangé wrote: > We no longer wish to have commands implemented in HMP only. All commands > should start with a QMP implementation and the HMP merely be a shim > around this. To reduce the burden of implementing QMP commands where > there is low

Re: [PATCH 01/12] macfb: handle errors that occur during realize

2021-10-04 Thread Mark Cave-Ayland
On 02/10/2021 12:36, BALATON Zoltan wrote: On Sat, 2 Oct 2021, Mark Cave-Ayland wrote: Make sure any errors that occur within the macfb realize chain are detected and handled correctly to prevent crashes and to ensure that error messages are reported back to the user. Signed-off-by: Mark Cave-

Re: [PATCH 01/12] macfb: handle errors that occur during realize

2021-10-04 Thread Mark Cave-Ayland
On 02/10/2021 14:47, Philippe Mathieu-Daudé wrote: On 10/2/21 12:59, Mark Cave-Ayland wrote: Make sure any errors that occur within the macfb realize chain are detected and handled correctly to prevent crashes and to ensure that error messages are reported back to the user. Signed-off-by: Mark

Re: [PULL 21/30] target/arm: use official org.gnu.gdb.aarch64.sve layout for registers

2021-10-04 Thread Luis Machado
Hi, On 9/21/21 10:55 AM, Peter Maydell wrote: On Tue, 19 Jan 2021 at 15:57, Alex Bennée wrote: Claudio Fontana writes: On 1/19/21 3:50 PM, Alex Bennée wrote: Claudio Fontana writes: qemu-system-aarch64: -gdb unix:path=/tmp/tmp9ru5tgk8qemu-gdbstub/gdbstub.socket,server: info: QEMU wa

Re: [PATCH 07/12] macfb: add qdev property to specify display type

2021-10-04 Thread Mark Cave-Ayland
On 02/10/2021 15:04, Philippe Mathieu-Daudé wrote: On 10/2/21 13:00, Mark Cave-Ayland wrote: Since the available resolutions and colour depths are determined by the attached display type, add a qdev property to allow the display type to be specified. The main resolutions of interest are high r

Re: [PATCH 03/12] macfb: fix overflow of color_palette array

2021-10-04 Thread Mark Cave-Ayland
On 04/10/2021 09:53, Laurent Vivier wrote: Le 02/10/2021 à 12:59, Mark Cave-Ayland a écrit : The palette_current index counter has a maximum size of 256 * 3 to cover a full color palette of 256 RGB entries. Linux assumes that the palette_current index wraps back around to zero after writing 256

Re: [PATCH 11/12] macfb: add vertical blank interrupt

2021-10-04 Thread Mark Cave-Ayland
On 04/10/2021 17:32, Laurent Vivier wrote: Le 02/10/2021 à 13:00, Mark Cave-Ayland a écrit : The MacOS driver expects a 60.15Hz vertical blank interrupt to be generated by the framebuffer which in turn schedules the mouse driver via the Vertical Retrace Manager. Signed-off-by: Mark Cave-Aylan

<    1   2   3   >