On 02/10/2021 12:36, BALATON Zoltan wrote:

On Sat, 2 Oct 2021, Mark Cave-Ayland wrote:
Make sure any errors that occur within the macfb realize chain are detected
and handled correctly to prevent crashes and to ensure that error messages are
reported back to the user.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk>
---
hw/display/macfb.c | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/hw/display/macfb.c b/hw/display/macfb.c
index 76808b69cc..2b747a8de8 100644
--- a/hw/display/macfb.c
+++ b/hw/display/macfb.c

There's one more in macfb_common_realize() after:

memory_region_init_ram_nomigrate(&s->mem_vram, OBJECT(s), "macfb-vram", MACFB_VRAM_SIZE, errp);

otherwise

Reviewed-by: BALATON Zoltan <bala...@eik.bme.hu>

Ah yes, IIRC from the last patchset the outcome of the discussion with Markus was that these functions should use &error_abort. I'll make the same change here for v2.


ATB,

Mark.

Reply via email to