All targets now define TARGET_ARCH_HAS_SIGTRAMP_PAGE.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
linux-user/elfload.c | 4
1 file changed, 4 deletions(-)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index 459a26ef1d..2404d482ba 100644
--- a/linux-
Let's detect block-size automatically if not specified by user:
If both files define cluster-size, use minimum to be more precise.
If both files don't specify cluster-size, use default of 64K
If only one file specify cluster-size, just use it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
Hi all!
Recently we faced the following task:
Customer comes and say: incremental backup images are too fat. Does you
incremental backup works correct?
What to answer? We should check something. At least check that
incremental images doesn't store same data twice. And we don't have a
tool for it
Give the plugins access to the qemu_plugin_insn_symbol helper.
Note that this symbols is today already used by cache.c, which can not
be loaded without it.
Signed-off-by: Philipp Tomsich
---
plugins/qemu-plugins.symbols | 1 +
1 file changed, 1 insertion(+)
diff --git a/plugins/qemu-plugins.s
On 9/27/21 18:55, John Snow wrote:
Hiya,
I'd like to propose that at least the three of us arrange a time to have
a meeting where we discuss our plans and ideas for QAPI going forward,
including rust, python, and golang extensions to the QAPI generator,
what we hope to accomplish with thos
Test new feature qemu-img compare --stat.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
.../qemu-iotests/tests/qemu-img-compare-stat | 88 +++
.../tests/qemu-img-compare-stat.out | 106 ++
2 files changed, 194 insertions(+)
create mode 100755 tests/qemu
Hi Michael,
On Mon, Sep 27, 2021 at 12:49 PM Michael S. Tsirkin wrote:
> On Mon, Sep 27, 2021 at 10:33:42AM +0100, Daniel P. Berrangé wrote:
> > On Tue, Aug 03, 2021 at 04:52:03PM -0400, Michael S. Tsirkin wrote:
> > > From: Marcel Apfelbaum
> > >
> > > Q35 has now ACPI hotplug enabled by defau
On Wed, Sep 29, 2021 at 08:08:40PM +0800, Cindy Lu wrote:
> On Wed, Sep 29, 2021 at 6:07 PM Michael Tokarev wrote:
> >
> > 29.09.2021 09:52, Cindy Lu wrote:
> > > For vdpa device, if the host support VIRTIO_NET_F_MAC
> > > we need to read the mac address from hardware, so need
> > > to check this
On 9/29/21 15:03, Richard Henderson wrote:
> The correct thing to do has been present but commented
> out since the initial commit of the sh4 translator.
>
> Fixes: fdf9b3e831e
> Signed-off-by: Richard Henderson
> ---
> target/sh4/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(
On 9/29/21 15:05, Richard Henderson wrote:
> With signal trampolines safely off the stack for all
> guests besides hppa, we can re-enable this test.
>
> It does show up a problem with sh4 (unrelated?),
> so leave that test disabled for now.
>
> Signed-off-by: Richard Henderson
> ---
> tests/tcg
From: Farzon Lotfi
---
block/bochs.c | 10 +-
block/file-posix.c| 8 +-
block/file-win32.c| 20 +--
block/parallels.c | 10 +-
block/qcow.c | 10 +-
hw/block/fdc.c| 4 +-
hw/block/nand.c | 212 +++---
I am starting to believe that the error is due to the fact that no
EGLContext is active on the current thread (the one running the Vulkan
application).
Trying to call eglMakeCurrent within this thread gives me an
EGL_BAD_ACCESS error as the EGLContext associated to the GL texture
belongs to a
On Wed, 29 Sep 2021, 08:42 Paolo Bonzini, wrote:
> On 29/09/21 10:59, Peter Maydell wrote:
> > This seems to break the gitlab cross-i386-system build,
> > which now fails to link qemu-nbd because it is trying
> > to link the x86-64 libselinux.so into a 32-bit binary:
> >
> > https://gitlab.com/qe
From: Mingwang Li
If default main_mem is used to be registered as the system memory,
other memory cannot be initialized. Therefore, the system memory
should be initialized to the machine->ram, which consists of the
default main_mem and other possible memory required by applications,
such as share
Hi Daniel,
On Wed, Sep 29, 2021 at 12:05 PM Daniel P. Berrangé
wrote:
> On Mon, Sep 27, 2021 at 05:49:15AM -0400, Michael S. Tsirkin wrote:
> > On Mon, Sep 27, 2021 at 10:33:42AM +0100, Daniel P. Berrangé wrote:
> > > On Tue, Aug 03, 2021 at 04:52:03PM -0400, Michael S. Tsirkin wrote:
> > > > Fr
On Wed, 29 Sept 2021 at 14:14, Richard Henderson
wrote:
>
> Mirror what the kernel does in arch/arm/kernel/signal.h,
> using the old sigframe struct in the rt sigframe struct.
>
> Update the trampoline code to match the kernel: this uses
> sp-relative accesses rather than pc-relative.
>
> Copy the
ping?
On 9/20/21 08:40, Philippe Mathieu-Daudé wrote:
> Slowly nuking non-QOM devices: Lasi PS/2's turn.
>
> Philippe Mathieu-Daudé (3):
> hw/input/lasips2: Fix typos in function names
> hw/input/lasips2: Move LASIPS2State declaration to
> 'hw/input/lasips2.h'
> hw/input/lasips2: QOM'if
On 9/29/21 15:35, Philipp Tomsich wrote:
> Give the plugins access to the qemu_plugin_insn_symbol helper.
> Note that this symbols is today already used by cache.c, which can not
> be loaded without it.
>
> Signed-off-by: Philipp Tomsich
>
> ---
>
> plugins/qemu-plugins.symbols | 1 +
> 1 file
Hi,
> > generally maybe we should just add an ACPI-hotplug capability and
> > teach seabios about it?
>
> I suppose it is possible.
I doubt this solves the problem. As I understand it linux will happily
assign io address space for pcie hotplug root ports but not for acpi
hotplug root ports.
On 9/16/21 00:05, Paolo Bonzini wrote:
> On 02/09/21 17:22, Philippe Mathieu-Daudé wrote:
>> Instead of including a sysemu-specific header in "cpu.h"
>> (which is shared with user-mode emulations), include it
>> locally when required.
>>
>> Signed-off-by: Philippe Mathieu-Daudé
>> ---
>
> Acked-b
On 9/20/21 08:40, Philippe Mathieu-Daudé wrote:
Artist is another device, this one is the Lasi PS/2.
Rename the functions accordingly.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Damien Hedde
---
hw/input/lasips2.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
On 9/20/21 08:40, Philippe Mathieu-Daudé wrote:
We want to use the OBJECT_DECLARE_SIMPLE_TYPE() macro to QOM'ify
this device in the next commit. To make its review simpler, as a
first step move the LASIPS2State and LASIPS2Port declarations to
'hw/input/lasips2.h'
Signed-off-by: Philippe Mathi
On 9/20/21 08:40, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Damien Hedde
---
include/hw/input/lasips2.h | 17 +
hw/hppa/lasi.c | 10 +-
hw/input/lasips2.c | 38 --
On Tue, Sep 28, 2021 at 08:11:33PM +0800, Yanan Wang wrote:
> In qemu-option.hx, there is "-smp [[cpus=]n][,maxcpus=cpus]..." in the
> DEF part, and "-smp [[cpus=]n][,maxcpus=maxcpus]..." in the RST part.
> Obviously the later is right, let's fix the previous one.
>
> Signed-off-by: Yanan Wang
>
On Tue, Sep 28, 2021 at 08:11:34PM +0800, Yanan Wang wrote:
> There is one numa config example in qemu-options.hx currently
> using "-smp 2" and assuming that there will be 2 sockets and
> 2 cpus totally. However now the actual calculation logic of
> missing sockets and cores is not immutable and i
As the guest OS is paused, we will never receive the unplug event
from the kernel and the migration cannot continue.
The first patch is optional, it provides the error message to display
to migration_cancel() rather than to have to call migrate_set_error()
from the caller.
Laurent Vivier (2):
m
This avoids to call migrate_get_current() in the caller function
whereas migration_cancel() already needs the pointer to the current
migration state.
Signed-off-by: Laurent Vivier
---
migration/migration.h | 2 +-
migration/migration.c | 9 ++---
migration/ram.c | 3 +--
3 files change
As the guest OS is paused, we will never receive the unplug event
from the kernel and the migration cannot continue.
Signed-off-by: Laurent Vivier
---
hw/net/virtio-net.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index
On Wed, 29 Sep 2021 10:22:39 +0100
Daniel P. Berrangé wrote:
> On Wed, Sep 29, 2021 at 11:05:31AM +0200, Igor Mammedov wrote:
> > On Tue, 28 Sep 2021 00:47:01 +0800
> > Nan Wang wrote:
> >
> > > On 2021/9/27 11:16, David Hildenbrand wrote:
> > > > On 27.09.21 15:19, Nan Wang wrote:
> >
Paolo Bonzini writes:
> On 29/09/21 04:58, Yanan Wang wrote:
>> Hi,
>> This is a new version (v12) with minor update suggested by Daniel
>> and Philippe. Two new commits (#1 and #16) are added. Thanks!
>
> Queued, thanks!
Could you amend PATCH 16 to drop ERRP_GUARD() in machine_set_smp()?
Le 28/09/2021 à 14:11, Yanan Wang a écrit :
> There is one numa config example in qemu-options.hx currently
> using "-smp 2" and assuming that there will be 2 sockets and
> 2 cpus totally. However now the actual calculation logic of
> missing sockets and cores is not immutable and is considered
> l
Le 28/09/2021 à 14:11, Yanan Wang a écrit :
> In qemu-option.hx, there is "-smp [[cpus=]n][,maxcpus=cpus]..." in the
> DEF part, and "-smp [[cpus=]n][,maxcpus=maxcpus]..." in the RST part.
> Obviously the later is right, let's fix the previous one.
>
> Signed-off-by: Yanan Wang
> Reviewed-by: Dam
On 29/09/21 16:46, Markus Armbruster wrote:
Paolo Bonzini writes:
On 29/09/21 04:58, Yanan Wang wrote:
Hi,
This is a new version (v12) with minor update suggested by Daniel
and Philippe. Two new commits (#1 and #16) are added. Thanks!
Queued, thanks!
Could you amend PATCH 16 to drop ERRP_
Le 29/09/2021 à 16:08, Philippe Mathieu-Daudé a écrit :
> On 9/16/21 00:05, Paolo Bonzini wrote:
>> On 02/09/21 17:22, Philippe Mathieu-Daudé wrote:
>>> Instead of including a sysemu-specific header in "cpu.h"
>>> (which is shared with user-mode emulations), include it
>>> locally when required.
>>
On 29/09/21 15:58, Richard Henderson wrote:
> /usr/bin/ld: /usr/lib64/libselinux.so: error adding symbols: file in
> wrong format
> collect2: error: ld returned 1 exit status
Missing libselinux-devel.i686 in
tests/docker/dockerfiles/fedora-i386-cross.docker, I think?
But
Le 29/09/2021 à 15:03, Richard Henderson a écrit :
> The correct thing to do has been present but commented
> out since the initial commit of the sh4 translator.
>
> Fixes: fdf9b3e831e
> Signed-off-by: Richard Henderson
> ---
> target/sh4/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 d
Le 26/09/2021 à 22:19, Philippe Mathieu-Daudé a écrit :
> QEMU doesn't distinct network devices per link layer (Ethernet,
> Wi-Fi, CAN, ...). Categorize PCI Wireless cards as Network
> devices.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/remote/proxy.c | 1 +
> 1 file changed, 1 inserti
Hi Peter,
On Wed, 29 Sept 2021 at 03:10, Peter Maydell wrote:
>
> On Wed, 29 Sept 2021 at 04:01, Simon Glass wrote:
> > On Tue, 28 Sept 2021 at 03:21, Peter Maydell
> > wrote:
> > > So what *is* this patch doing? The subject says "Allow additions to
> > > the generated device tree", and the pa
ELF kernel allows us debugging much easier with DWARF symbols.
Signed-off-by: Jiaxun Yang
Reviewed-by: Philippe Mathieu-Daudé
--
v2: Use g_autofree
---
hw/mips/boston.c | 36
1 file changed, 32 insertions(+), 4 deletions(-)
diff --git a/hw/mips/boston.c b/h
Generate FDT on our own if no dtb argument supplied.
Avoid introducing unused device in FDT with user supplied dtb.
Signed-off-by: Jiaxun Yang
--
v2: Address f4bug cmments (Thanks!)
---
hw/mips/boston.c | 234 +--
1 file changed, 226 insertions(+), 8 d
Jiaxun Yang (3):
hw/mips/boston: Massage memory map information
hw/mips/boston: Allow loading elf kernel and dtb
hw/mips/boston: Add FDT generator
hw/mips/boston.c | 349 +++
1 file changed, 321 insertions(+), 28 deletions(-)
--
2.30.2
Use memmap array to uinfy address of memory map.
That would allow us reuse address information for FDT generation.
Signed-off-by: Jiaxun Yang
Reviewed-by: Philippe Mathieu-Daudé
--
v2: Fix minor style issue, fix uart map size
---
hw/mips/boston.c | 95 ---
Le 29/09/2021 à 17:00, Laurent Vivier a écrit :
> Le 29/09/2021 à 16:08, Philippe Mathieu-Daudé a écrit :
>> On 9/16/21 00:05, Paolo Bonzini wrote:
>>> On 02/09/21 17:22, Philippe Mathieu-Daudé wrote:
Instead of including a sysemu-specific header in "cpu.h"
(which is shared with user-mode
Flags that choose the target architecture, such as -m32 on x86, affect
all invocations of the compiler driver, for example including options
such as --print-search-dirs. To ensure that they are treated as such,
place them in the cross file in the [binaries] section instead of
including them in QEM
On 02/09/21 11:35, Vitaly Kuznetsov wrote:
KVM PV features don't seem to be documented anywhere, in particular, the
fact that some of the features are enabled by default and some are not can
only be figured out from the code.
Signed-off-by: Vitaly Kuznetsov
---
docs/kvm-pv.txt | 92 ++
Le 07/08/2021 à 13:09, Philippe Mathieu-Daudé a écrit :
> We are going to modify this function, fix its style first.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> disas/nios2.c | 53 +--
> 1 file changed, 26 insertions(+), 27 deletions(-)
>
>
Le 07/08/2021 à 13:09, Philippe Mathieu-Daudé a écrit :
> Since commit 12b6e9b27d4 ("disas: Clean up CPUDebug initialization")
> the disassemble_info->bfd_endian enum is set for all targets in
> target_disas(). We can directly call print_insn_nios2() and simplify.
>
> Signed-off-by: Philippe Mathi
On 02/09/21 11:35, Vitaly Kuznetsov wrote:
This is a continuation of "[PATCH 0/3] i386/kvm: Paravirtualized features usage
enforcement" series, thus v2.
This series implements several unrelated features but as there are code
dependencies between them I'm sending it as one series.
PATCH1 adds em
On Wed, 29 Sep 2021, Jiaxun Yang wrote:
Use memmap array to uinfy address of memory map.
That would allow us reuse address information for FDT generation.
Signed-off-by: Jiaxun Yang
Reviewed-by: Philippe Mathieu-Daudé
--
v2: Fix minor style issue, fix uart map size
---
hw/mips/boston.c | 95 ++
On Wed, 29 Sep 2021, Jiaxun Yang wrote:
ELF kernel allows us debugging much easier with DWARF symbols.
Signed-off-by: Jiaxun Yang
Reviewed-by: Philippe Mathieu-Daudé
--
v2: Use g_autofree
---
hw/mips/boston.c | 36
1 file changed, 32 insertions(+), 4 dele
On Wed, Sep 29, 2021 at 4:37 PM Vladimir Sementsov-Ogievskiy
wrote:
>
> Allow compare only top images of backing chains. That's useful for
> comparing two increments from the same chain of incremental backups.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> docs/tools/qemu-img.rst | 8 +
On 9/29/21 17:16, Laurent Vivier wrote:
> Le 29/09/2021 à 17:00, Laurent Vivier a écrit :
>> Le 29/09/2021 à 16:08, Philippe Mathieu-Daudé a écrit :
>>> On 9/16/21 00:05, Paolo Bonzini wrote:
On 02/09/21 17:22, Philippe Mathieu-Daudé wrote:
> Instead of including a sysemu-specific header i
Le 29/09/2021 à 18:06, Philippe Mathieu-Daudé a écrit :
> On 9/29/21 17:16, Laurent Vivier wrote:
>> Le 29/09/2021 à 17:00, Laurent Vivier a écrit :
>>> Le 29/09/2021 à 16:08, Philippe Mathieu-Daudé a écrit :
On 9/16/21 00:05, Paolo Bonzini wrote:
> On 02/09/21 17:22, Philippe Mathieu-Daud
Some fixes for virtio-mem-pci, to properly handle MEMORY_DEVICE_SIZE_CHANGE
events, especially not dropping events of some devices when rate-limiting.
v2 -> v3:
- Split up into two patches
- "const char * qom_path" -> "char *qom_path"
- Fix existing memory leak and avoid a new memory leak when cre
Apparently, we don't have to duplicate the string.
Fixes: 722a3c783ef4 ("virtio-pci: Send qapi events when the virtio-mem size
changes")
Cc: qemu-sta...@nongnu.org
Signed-off-by: David Hildenbrand
---
hw/virtio/virtio-mem-pci.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff -
Instead of including a sysemu-specific header in "cpu.h"
(which is shared with user-mode emulations), include it
locally when required.
Acked-by: Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/cpu.h| 4
hw/i386/kvmvapic.c | 1 +
hw
We want to rate-limit MEMORY_DEVICE_SIZE_CHANGE events per device,
otherwise we can lose some events for devices. We can now use the
qom-path to reliably map an event to a device and make rate-limiting
device-aware.
This was noticed by starting a VM with two virtio-mem devices that each
have a req
29.09.2021 19:00, Nir Soffer wrote:
On Wed, Sep 29, 2021 at 4:37 PM Vladimir Sementsov-Ogievskiy
wrote:
Allow compare only top images of backing chains. That's useful for
comparing two increments from the same chain of incremental backups.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
do
On 9/29/21 18:25, Philippe Mathieu-Daudé wrote:
> Instead of including a sysemu-specific header in "cpu.h"
> (which is shared with user-mode emulations), include it
> locally when required.
>
> Acked-by: Paolo Bonzini
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> target/i386/cpu.h
As we might not always have a device id, it is impossible to always
match MEMORY_DEVICE_SIZE_CHANGE events to an actual device. Let's
include the qom-path in the event, which allows for reliable mapping of
events to devices.
Fixes: 722a3c783ef4 ("virtio-pci: Send qapi events when the virtio-mem si
Instead of including a sysemu-specific header in "cpu.h"
(which is shared with user-mode emulations), include it
locally when required.
Acked-by: Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/cpu.h| 4
hw/i386/kvmvapic.c | 1 +
hw
On 9/29/21 18:23, Laurent Vivier wrote:
> Le 29/09/2021 à 18:06, Philippe Mathieu-Daudé a écrit :
>> On 9/29/21 17:16, Laurent Vivier wrote:
>>> Le 29/09/2021 à 17:00, Laurent Vivier a écrit :
Le 29/09/2021 à 16:08, Philippe Mathieu-Daudé a écrit :
> On 9/16/21 00:05, Paolo Bonzini wrote:
在 2021/9/29 16:32, BALATON Zoltan 写道:
On Wed, 29 Sep 2021, Jiaxun Yang wrote:
Use memmap array to uinfy address of memory map.
That would allow us reuse address information for FDT generation.
Signed-off-by: Jiaxun Yang
Reviewed-by: Philippe Mathieu-Daudé
--
v2: Fix minor style issue, fix
在 2021/9/29 16:36, BALATON Zoltan 写道:
On Wed, 29 Sep 2021, Jiaxun Yang wrote:
ELF kernel allows us debugging much easier with DWARF symbols.
Signed-off-by: Jiaxun Yang
Reviewed-by: Philippe Mathieu-Daudé
--
v2: Use g_autofree
---
hw/mips/boston.c | 36 ---
On Wed, Sep 29, 2021 at 7:28 PM Vladimir Sementsov-Ogievskiy
wrote:
>
> 29.09.2021 19:00, Nir Soffer wrote:
> > On Wed, Sep 29, 2021 at 4:37 PM Vladimir Sementsov-Ogievskiy
> > wrote:
> >>
> >> Allow compare only top images of backing chains. That's useful for
> >> comparing two increments from t
Le 29/09/2021 à 18:31, Philippe Mathieu-Daudé a écrit :
> Instead of including a sysemu-specific header in "cpu.h"
> (which is shared with user-mode emulations), include it
> locally when required.
>
> Acked-by: Paolo Bonzini
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> target/i386/cpu.h
On Mon, Sep 27, 2021 at 09:35:22AM +0100, Daniel P. Berrangé wrote:
> On Sun, Sep 26, 2021 at 07:23:56PM +0200, Philippe Mathieu-Daudé wrote:
> > Hi,
> >
> > FYI the OpenSUSE job is failing since few days, i.e.:
> > https://gitlab.com/qemu-project/qemu/-/jobs/1622345026
> >
> > Retrieving repos
Hi Richard,
On 9/27/21 07:07, Richard Henderson wrote:
On 9/26/21 3:15 AM, Philippe Mathieu-Daudé wrote:
On 9/25/21 19:30, WANG Xuerui wrote:
Signed-off-by: WANG Xuerui
Reviewed-by: Richard Henderson
---
tcg/loongarch64/tcg-target.c.inc | 27 +++
1 file changed, 27
On Wed, Sep 29, 2021 at 11:18:39AM +0200, Eric Auger wrote:
> > I've been postponing the boot-bypass patch since it requires a
> > specification change to be done right, but it's next on my list.
> The boot-bypass feature seems a critical feature to overcome the current
> v3 limitation. Are there b
On 9/27/21 01:07, Richard Henderson wrote:
> On 9/26/21 3:15 AM, Philippe Mathieu-Daudé wrote:
>> On 9/25/21 19:30, WANG Xuerui wrote:
>>> Signed-off-by: WANG Xuerui
>>> Reviewed-by: Richard Henderson
>>> ---
>>> tcg/loongarch64/tcg-target.c.inc | 27 +++
>>> 1 file cha
On 9/25/21 19:30, WANG Xuerui wrote:
> Signed-off-by: WANG Xuerui
> Reviewed-by: Richard Henderson
> ---
> tcg/loongarch64/tcg-target-con-set.h | 17 +
> tcg/loongarch64/tcg-target.c.inc | 15 +++
> 2 files changed, 32 insertions(+)
> create mode 100644 tcg/loong
On 9/29/21 18:51, Laurent Vivier wrote:
> Le 29/09/2021 à 18:31, Philippe Mathieu-Daudé a écrit :
>> Instead of including a sysemu-specific header in "cpu.h"
>> (which is shared with user-mode emulations), include it
>> locally when required.
>>
>> Acked-by: Paolo Bonzini
>> Signed-off-by: Philipp
On 9/25/21 19:30, WANG Xuerui wrote:
> Signed-off-by: WANG Xuerui
> Reviewed-by: Richard Henderson
> ---
> tcg/loongarch64/tcg-target-con-set.h | 1 +
> tcg/loongarch64/tcg-target.c.inc | 21 +
> tcg/loongarch64/tcg-target.h | 8
> 3 files changed, 26 i
On 9/29/21 17:18, Paolo Bonzini wrote:
> Flags that choose the target architecture, such as -m32 on x86, affect
> all invocations of the compiler driver, for example including options
> such as --print-search-dirs. To ensure that they are treated as such,
> place them in the cross file in the [bin
On Dienstag, 28. September 2021 18:41:17 CEST Daniel P. Berrangé wrote:
> On Tue, Sep 28, 2021 at 06:23:23PM +0200, Christian Schoenebeck wrote:
> > On Dienstag, 28. September 2021 15:04:36 CEST Daniel P. Berrangé wrote:
> > > On Sun, Aug 22, 2021 at 03:16:46PM +0200, Christian Schoenebeck wrote:
[
On Wed, Sep 29, 2021 at 07:32:39PM +0200, Christian Schoenebeck wrote:
> On Dienstag, 28. September 2021 18:41:17 CEST Daniel P. Berrangé wrote:
> > On Tue, Sep 28, 2021 at 06:23:23PM +0200, Christian Schoenebeck wrote:
> > > On Dienstag, 28. September 2021 15:04:36 CEST Daniel P. Berrangé wrote:
>
On Wed, Sep 29, 2021 at 05:03:08PM +0200, Paolo Bonzini wrote:
> On 29/09/21 15:58, Richard Henderson wrote:
> >
> > > /usr/bin/ld: /usr/lib64/libselinux.so: error adding symbols: file in
> > > wrong format
> > > collect2: error: ld returned 1 exit status
> >
> > Missing libsel
Hello Peter,
On Tue, Sep 28, 2021 at 7:51 PM Peter Xu wrote:
>
> On Wed, Sep 22, 2021 at 07:24:20PM -0300, Leonardo Bras wrote:
> > This patch series intends to enable MSG_ZEROCOPY in QIOChannel, and make
> > use of it for multifd migration performance improvement.
> >
> > Patch #1 creates new ca
Hello Daniel, thank you for reviewing!
On Fri, Sep 24, 2021 at 2:16 PM Daniel P. Berrangé wrote:
>
> On Wed, Sep 22, 2021 at 07:24:21PM -0300, Leonardo Bras wrote:
> > Adds io_async_writev and io_async_flush as optional callback to
> > QIOChannelClass,
> > allowing the implementation of asynchro
Hello Peter, thanks for reviewing!
On Tue, Sep 28, 2021 at 6:52 PM Peter Xu wrote:
>
> On Fri, Sep 24, 2021 at 06:16:04PM +0100, Daniel P. Berrangé wrote:
> > > +ssize_t qio_channel_async_writev(QIOChannel *ioc,
> > > + const struct iovec *iov,
> > > +
On Wed, Sep 29, 2021 at 01:29:21PM -0500, Eric Blake wrote:
> On Wed, Sep 29, 2021 at 05:03:08PM +0200, Paolo Bonzini wrote:
> > On 29/09/21 15:58, Richard Henderson wrote:
> > >
> > > > /usr/bin/ld: /usr/lib64/libselinux.so: error adding symbols: file
> > > in
> > > > wrong format
> >
On Wed, Sep 29, 2021 at 03:34:01PM -0300, Leonardo Bras Soares Passos wrote:
> You mean like I did in pre-V1, enabling ZEROCOPY for multifd it in QMP?
> Or is this something else?
I mean any way to still be able to turn zerocopy off? E.g. when the user has no
privilege on mlock. Thanks,
--
Pete
Hello Daniel,
On Fri, Sep 24, 2021 at 2:38 PM Daniel P. Berrangé wrote:
[...]
> > @@ -154,6 +171,19 @@ int qio_channel_socket_connect_sync(QIOChannelSocket
> > *ioc,
> > return -1;
> > }
> >
> > +#ifdef CONFIG_LINUX
> > +if (addr->type != SOCKET_ADDRESS_TYPE_INET) {
> > +
On Tue, Sep 28, 2021 at 7:45 PM Peter Xu wrote:
>
> On Wed, Sep 22, 2021 at 07:24:22PM -0300, Leonardo Bras wrote:
> > +static void qio_channel_socket_async_flush(QIOChannel *ioc,
> > + Error **errp)
> > +{
> > +QIOChannelSocket *sioc = QIO_CHANNEL_SOC
On Fri, Sep 24, 2021 at 2:44 PM Daniel P. Berrangé wrote:
>
> On Wed, Sep 22, 2021 at 07:24:23PM -0300, Leonardo Bras wrote:
> > Change multifd nocomp version to use asynchronous write for RAM pages, and
> > benefit of MSG_ZEROCOPY when it's available.
> >
> > The asynchronous flush happens on cle
Hello darkness my old friend; This is part five (b), and focuses on
QAPIDoc in parser.py.
GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-qapi-cleanup-pt5b
CI: https://gitlab.com/jsnow/qemu/-/pipelines/379678153
Note: intentional trailing whitespace in a QAPI schema test causes
a wa
Pylint 2.11.x adds this warning. We're not yet ready to pursue that
conversion, so silence it for now.
Signed-off-by: John Snow
---
scripts/qapi/pylintrc | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc
index c5275d5f59b..5b7dbc58ad8 100644
--- a/
On Wed, Sep 29, 2021 at 09:09:59AM -0600, Simon Glass wrote:
> Hi Peter,
>
> On Wed, 29 Sept 2021 at 03:10, Peter Maydell wrote:
> >
> > On Wed, 29 Sept 2021 at 04:01, Simon Glass wrote:
> > > On Tue, 28 Sept 2021 at 03:21, Peter Maydell
> > > wrote:
> > > > So what *is* this patch doing? The
Pylint informs us we're not using these arguments. Oops, it's
right. Correct the error message and remove the remaining unused
parameter.
Fix test output now that the error message is improved.
Fixes: e151941d1b
Signed-off-by: John Snow
---
scripts/qapi/parser.py| 16 +--
True, we do not check the validity of this symbol -- but we don't check
the validity of definition names during parse, either -- that happens
later, during the expr check. I don't want to introduce a dependency on
expr.py:check_name_str here and introduce a cycle.
Instead, rest assured that a docu
New pylint warning. I could silence it, but this is the only occurrence
in the entire tree, including everything in iotests/ and python/. Easier
to just change this one instance.
(The warning is emitted in cases where you are fetching the values
anyway, so you may as well just take advantage of th
Annotations do not change runtime behavior.
This commit consists of only annotations.
Signed-off-by: John Snow
---
scripts/qapi/parser.py | 67 --
1 file changed, 39 insertions(+), 28 deletions(-)
diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.
Several QGA definitions omit a blank line after the symbol
declaration. This works OK currently, but it's the only place where we
do this. Adjust it for consistency.
Future commits may wind up enforcing this formatting.
Signed-off-by: John Snow
---
This isn't strictly necessary and I don't act
The "if self._section" clause in end_section is mysterious: In which
circumstances might we end a section when we don't have one?
QAPIDoc always expects there to be a "current section", only except
after a call to end_comment(). This actually *shouldn't* ever be 'None',
so let's remove that logic
Eh. Not worth the fuss today. There are bigger fish to fry.
Signed-off-by: John Snow
---
scripts/qapi/parser.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py
index 8a846079207..7511eedaa35 100644
--- a/scripts/qapi/parser.py
+++ b/scripts/
Here's the weird bit. QAPIDoc generally expects -- virtually everywhere
-- that it will always have a current section. The sole exception to
this is in the case that end_comment() is called, which leaves us with
*no* section. However, in this case, we also don't expect to actually
ever mutate the c
Leading and trailing whitespace are now discarded, addressing the FIXME
comment. A new error is raised to detect this accidental case.
Parsing for args sections is left alone here; the 'name' variable is
moved into the only block where it is used.
Signed-off-by: John Snow
---
Tangentially rela
Signed-off-by: John Snow
---
This can be merged with the previous commit, if desired.
Signed-off-by: John Snow
---
scripts/qapi/pylintrc | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc
index 5b7dbc58ad8..b259531a726 100644
--
Signed-off-by: John Snow
---
As always, this can be merged with the previous commit.
Signed-off-by: John Snow
---
scripts/qapi/mypy.ini | 5 -
1 file changed, 5 deletions(-)
diff --git a/scripts/qapi/mypy.ini b/scripts/qapi/mypy.ini
index 54ca4483d6d..66253564297 100644
--- a/scripts/qap
There is a cycle that exists in the QAPI generator: [schema -> expr ->
parser -> schema]. It exists because the QAPIDoc class needs the names
of types defined by the schema module, but the schema module needs to
import both expr.py/parser.py to do its actual parsing.
Ultimately, the layering viola
101 - 200 of 291 matches
Mail list logo
