Le 28/09/2021 à 14:11, Yanan Wang a écrit : > There is one numa config example in qemu-options.hx currently > using "-smp 2" and assuming that there will be 2 sockets and > 2 cpus totally. However now the actual calculation logic of > missing sockets and cores is not immutable and is considered > liable to change. Although we will get maxcpus=2 finally based > on current parser, it's always stable to specify it explicitly. > > So "-smp 2,sockets=2,maxcpus=2" will be optimal when we expect > multiple sockets and 2 cpus totally. > > Signed-off-by: Yanan Wang <wangyana...@huawei.com> > Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com> > --- > qemu-options.hx | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index dcd9595650..ff8917c5e1 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -395,7 +395,7 @@ SRST > -m 2G \ > -object memory-backend-ram,size=1G,id=m0 \ > -object memory-backend-ram,size=1G,id=m1 \ > - -smp 2 \ > + -smp 2,sockets=2,maxcpus=2 \ > -numa node,nodeid=0,memdev=m0 \ > -numa node,nodeid=1,memdev=m1,initiator=0 \ > -numa cpu,node-id=0,socket-id=0 \ >
Applied to my trivial-patches branch. Thanks, Laurent
