[PATCH 06/10] aspeed/smc: Remove the 'size' attribute from AspeedSMCFlash

2021-09-07 Thread Cédric Le Goater
It's only useful to compute the initial size of the boot_rom region. Use memory_region_size() instead. Signed-off-by: Cédric Le Goater --- include/hw/ssi/aspeed_smc.h | 1 - hw/arm/aspeed.c | 7 --- hw/ssi/aspeed_smc.c | 5 ++--- 3 files changed, 6 insertions(+), 7 deleti

[PATCH 10/10] aspeed/smc: Introduce an addr_width() class handler

2021-09-07 Thread Cédric Le Goater
The AST2400 SPI controller has a transitional HW interface and it stores the address width currently in use in a different register than all the other SMC controllers. It needs special handling when working in 4B mode. Make it clear through a class handler. This also removes another use of the seg

[PATCH 02/10] aspeed/smc: Introduce aspeed_smc_error() helper

2021-09-07 Thread Cédric Le Goater
It unifies the errors reported by the Aspeed SMC model and also removes some use of ctrl->name which will help us for the next patches. Signed-off-by: Cédric Le Goater --- hw/ssi/aspeed_smc.c | 97 + 1 file changed, 45 insertions(+), 52 deletions(-) d

[PATCH 03/10] aspeed/smc: Stop using the model name for the memory regions

2021-09-07 Thread Cédric Le Goater
There is no real reason to use this name. It's simply nice to have in the monitor output but it's a burden for the following patch which removes the AspeedSMCController structure describing the controller. Signed-off-by: Cédric Le Goater --- hw/ssi/aspeed_smc.c | 25 ++--- 1

Re: [PATCH v2 0/3] hw/arm/virt_acpi_build: Generate DBG2 table

2021-09-07 Thread Igor Mammedov
On Mon, 6 Sep 2021 14:31:36 +0200 Eric Auger wrote: > This series generates the ACPI DBG2 table along with machvirt. > It applies on top of Igor's > [PATCH v2 00/35] acpi: refactor error prone build_header() and > packed structures usage in ACPI tables FYI: I'm preparing to post v3 today, with

[PATCH 08/10] aspeed/smc: QOMify AspeedSMCFlash

2021-09-07 Thread Cédric Le Goater
AspeedSMCFlash is a little object representing the AHB memory window through which the contents of a flash device can be accessed with MMIOs. Signed-off-by: Cédric Le Goater --- include/hw/ssi/aspeed_smc.h | 13 +-- hw/ssi/aspeed_smc.c | 78 + 2 fi

[PATCH 04/10] aspeed/smc: Drop AspeedSMCController structure

2021-09-07 Thread Cédric Le Goater
The characteristics of the Aspeed controllers are described in a AspeedSMCController structure which is redundant with the AspeedSMCClass. Move all attributes under the class and adapt the code to use class attributes instead. This is a large change but it is functionally equivalent. Signed-off-b

Re: [PATCH v5 1/4] spapr: move NUMA associativity init to machine reset

2021-09-07 Thread Greg Kurz
On Tue, 7 Sep 2021 10:37:27 +1000 David Gibson wrote: > On Mon, Sep 06, 2021 at 09:25:24PM -0300, Daniel Henrique Barboza wrote: > > At this moment we only support one form of NUMA affinity, FORM1. This > > allows us to init the internal structures during machine_init(), and > > given that NUMA d

[PATCH 07/10] aspeed/smc: Rename AspeedSMCFlash 'id' to 'cs'

2021-09-07 Thread Cédric Le Goater
'cs' is a more appropriate name to index SPI flash devices. Signed-off-by: Cédric Le Goater --- include/hw/ssi/aspeed_smc.h | 2 +- hw/ssi/aspeed_smc.c | 30 +++--- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/include/hw/ssi/aspeed_smc.h b/inc

[PULL v3 00/36] (Mostly) x86 changes for 2021-09-06

2021-09-07 Thread Paolo Bonzini
The following changes since commit 935efca6c246c108253b0e4e51cc87648fc7ca10: Merge remote-tracking branch 'remotes/thuth-gitlab/tags/pull-request-2021-09-06' into staging (2021-09-06 12:38:07 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstre

[PULL v3 04/36] target/i386: Moved int_ctl into CPUX86State structure

2021-09-07 Thread Paolo Bonzini
From: Lara Lazier Moved int_ctl into the CPUX86State structure. It removes some unnecessary stores and loads, and prepares for tracking the vIRQ state even when it is masked due to vGIF. Signed-off-by: Lara Lazier Signed-off-by: Paolo Bonzini --- target/i386/cpu.c| 2 +-

Re: [PATCH 07/10] aspeed/smc: Rename AspeedSMCFlash 'id' to 'cs'

2021-09-07 Thread Philippe Mathieu-Daudé
On 9/7/21 8:58 AM, Cédric Le Goater wrote: > 'cs' is a more appropriate name to index SPI flash devices. > > Signed-off-by: Cédric Le Goater > --- > include/hw/ssi/aspeed_smc.h | 2 +- > hw/ssi/aspeed_smc.c | 30 +++--- > 2 files changed, 16 insertions(+), 16 del

Re: [PATCH 06/10] aspeed/smc: Remove the 'size' attribute from AspeedSMCFlash

2021-09-07 Thread Philippe Mathieu-Daudé
On 9/7/21 8:58 AM, Cédric Le Goater wrote: > It's only useful to compute the initial size of the boot_rom region. "AspeedSMCFlash::size is only used to compute the initial size of the boot_rom region. Not very useful, so directly call memory_region_size() instead."? > Use memory_region_size() i

Re: [PATCH 00/10] aspeed/smc: Cleanups and QOMification

2021-09-07 Thread Joel Stanley
Hi Cédric, On Tue, 7 Sept 2021 at 06:58, Cédric Le Goater wrote: > This series adds a simple support for the 2nd watchdog registers which > were moved under the AST2600 FMC controller to deactivate the > alternate boot function. Then come cleanups of the AspeedSMC model > mostly removing a useles

Re: [PATCH 08/10] aspeed/smc: QOMify AspeedSMCFlash

2021-09-07 Thread Philippe Mathieu-Daudé
On 9/7/21 8:58 AM, Cédric Le Goater wrote: > AspeedSMCFlash is a little object representing the AHB memory window > through which the contents of a flash device can be accessed with > MMIOs. > > Signed-off-by: Cédric Le Goater > --- > include/hw/ssi/aspeed_smc.h | 13 +-- > hw/ssi/aspeed_smc

Re: [PATCH 04/10] aspeed/smc: Drop AspeedSMCController structure

2021-09-07 Thread Philippe Mathieu-Daudé
On 9/7/21 8:58 AM, Cédric Le Goater wrote: > The characteristics of the Aspeed controllers are described in a > AspeedSMCController structure which is redundant with the > AspeedSMCClass. Move all attributes under the class and adapt the code > to use class attributes instead. > > This is a large

[PATCH] aspeed/i2c: QOMify AspeedI2CBus

2021-09-07 Thread Cédric Le Goater
The AST2600 SoC realize routine needs to be adapted when connecting the I2C bus IRQs because the bus IRQs have moved to the AspeedI2CBus SysBus device, one level below the Aspeed I2C controller SysBus device. Signed-off-by: Cédric Le Goater --- include/hw/i2c/aspeed_i2c.h | 8 ++- hw/arm/aspee

Re: [PATCH v2 3/5] s390x: topology: CPU topology objects and structures

2021-09-07 Thread Thomas Huth
On 22/07/2021 19.42, Pierre Morel wrote: We use new objects to have a dynamic administration of the CPU topology. The highier level object is the S390 book. In a first implementation s/highier/higher/ ... or highest ? we will have only a single S390 book. The book is built as a SYSBUS bridge

Re: [PATCH 06/10] aspeed/smc: Remove the 'size' attribute from AspeedSMCFlash

2021-09-07 Thread Cédric Le Goater
On 9/7/21 9:20 AM, Philippe Mathieu-Daudé wrote: > On 9/7/21 8:58 AM, Cédric Le Goater wrote: >> It's only useful to compute the initial size of the boot_rom region. > > "AspeedSMCFlash::size is only used to compute the initial size > of the boot_rom region. Not very useful, so directly call > m

Re: [PATCH] aspeed/i2c: QOMify AspeedI2CBus

2021-09-07 Thread Philippe Mathieu-Daudé
On 9/7/21 9:30 AM, Cédric Le Goater wrote: > The AST2600 SoC realize routine needs to be adapted when connecting > the I2C bus IRQs because the bus IRQs have moved to the AspeedI2CBus > SysBus device, one level below the Aspeed I2C controller SysBus > device. When did they move? > Signed-off-by:

Re: [PATCH v3 00/13] s390x: skey related fixes, cleanups, and memory device preparations

2021-09-07 Thread Thomas Huth
On 03/09/2021 17.55, David Hildenbrand wrote: This series fixes multiple TCG issues related to storage key instructions, fixes some TCG issues related to LOAD REAL ADDRESS and skeys, implements lazy skey enablement under TCG, and prepares the whole skey infrastructure for dealing with addresses b

Re: [PATCH v2 4/5] s390x: topology: Topology list entries and SYSIB 15.x.x

2021-09-07 Thread Thomas Huth
On 22/07/2021 19.42, Pierre Morel wrote: We define the CPU type Topology List Entry and the Container type Topology List Entry to implement SYSIB 15.1.x This patch will be squatched with the next patch. s/squatched/squashed/ ... anyway, why did you sent it separately? Thomas

Re: [PATCH v5 3/4] spapr_numa.c: base FORM2 NUMA affinity support

2021-09-07 Thread Greg Kurz
On Mon, 6 Sep 2021 21:25:26 -0300 Daniel Henrique Barboza wrote: > The main feature of FORM2 affinity support is the separation of NUMA > distances from ibm,associativity information. This allows for a more > flexible and straightforward NUMA distance assignment without relying on > complex asso

Re: [PATCH v2 4/5] s390x: topology: Topology list entries and SYSIB 15.x.x

2021-09-07 Thread Thomas Huth
On 22/07/2021 19.42, Pierre Morel wrote: We define the CPU type Topology List Entry and the Container type Topology List Entry to implement SYSIB 15.1.x This patch will be squatched with the next patch. Signed-off-by: Pierre Morel --- target/s390x/cpu.h | 44 +

Re: [PATCH v2 5/5] s390x: topology: implementating Store Topology System Information

2021-09-07 Thread Thomas Huth
On 22/07/2021 19.42, Pierre Morel wrote: The handling of STSI is enhenced with the interception of the s/enhenced/enhanced/ function code 15 for storing CPU topology. Using the objects built during the pluging of CPU, we build the SYSIB 15_1_x structures. With this patch the maximum MNEST l

Re: [RFC PATCH 0/2] riscv: Adding custom CSR related Kconfig options

2021-09-07 Thread Ruinland ChuanTzu Tsai
Hi Alistair, Thanks for the comment. On Mon, Sep 06, 2021 at 05:55:25PM +1000, Alistair Francis wrote: > On Mon, Sep 6, 2021 at 5:37 PM Ruinland ChuanTzu Tsai > wrote: > > > > Hi Alistair, > > > > So glad to hear from you. > > > > On Mon, Sep 06, 2021 at 05:05:16PM +1000, Alistair Francis wrote:

Re: [PATCH] aspeed/i2c: QOMify AspeedI2CBus

2021-09-07 Thread Cédric Le Goater
On 9/7/21 9:40 AM, Philippe Mathieu-Daudé wrote: > On 9/7/21 9:30 AM, Cédric Le Goater wrote: >> The AST2600 SoC realize routine needs to be adapted when connecting >> the I2C bus IRQs because the bus IRQs have moved to the AspeedI2CBus >> SysBus device, one level below the Aspeed I2C controller Sy

Re: [PATCH] gluster: Align block-status tail

2021-09-07 Thread Hanna Reitz
On 05.08.21 16:36, Max Reitz wrote: gluster's block-status implementation is basically a copy of that in block/file-posix.c, there is only one thing missing, and that is aligning trailing data extents to the request alignment (as added by commit 9c3db310ff0). Note that 9c3db310ff0 mentions that

[PULL 01/11] block/nvme: Use safer trace format string

2021-09-07 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Fix when building with -Wshorten-64-to-32: warning: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Wshorten-64-to-32] Reviewed-by: Klaus Jensen Signed-off-by: Philippe Mathieu-Daudé Message-id: 20210902070025.197072-2-phi...@redhat.com

[PULL 09/11] util/vfio-helpers: Simplify qemu_vfio_dma_map() returning directly

2021-09-07 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé To simplify qemu_vfio_dma_map(): - reduce 'ret' (returned value) scope by returning errno directly, - remove the goto 'out' label. Reviewed-by: Klaus Jensen Signed-off-by: Philippe Mathieu-Daudé Message-id: 20210902070025.197072-10-phi...@redhat.com Signed-off-by:

[PULL 00/11] Block patches

2021-09-07 Thread Stefan Hajnoczi
The following changes since commit 88afdc92b644120e0182c8567e1b1d236e471b12: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2021-09-05 15:48:42 +0100) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block-pull-request for you to

[PULL 03/11] util/vfio-helpers: Replace qemu_mutex_lock() calls with QEMU_LOCK_GUARD

2021-09-07 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Simplify qemu_vfio_dma_[un]map() handlers by replacing a pair of qemu_mutex_lock/qemu_mutex_unlock calls by the WITH_QEMU_LOCK_GUARD macro. Reviewed-by: Klaus Jensen Signed-off-by: Philippe Mathieu-Daudé Message-id: 20210902070025.197072-4-phi...@redhat.com Signed-

[PULL 02/11] util/vfio-helpers: Let qemu_vfio_verify_mappings() use error_report()

2021-09-07 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Instead of displaying the error on stderr, use error_report() which also report to the monitor. Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Reviewed-by: Klaus Jensen Signed-off-by: Philippe Mathieu-Daudé Message-id: 20210902070025.197072-3-phi...@redhat.c

[PULL 06/11] util/vfio-helpers: Pass Error handle to qemu_vfio_dma_map()

2021-09-07 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Currently qemu_vfio_dma_map() displays errors on stderr. When using management interface, this information is simply lost. Pass qemu_vfio_dma_map() an Error** handle so it can propagate the error to callers. Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Revie

[PULL 04/11] util/vfio-helpers: Remove unreachable code in qemu_vfio_dma_map()

2021-09-07 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé qemu_vfio_add_mapping() returns a pointer to an indexed entry in pre-allocated QEMUVFIOState::mappings[], thus can not be NULL. Remove the pointless check. Reviewed-by: Klaus Jensen Signed-off-by: Philippe Mathieu-Daudé Message-id: 20210902070025.197072-5-phi...@re

[PULL 08/11] util/vfio-helpers: Use error_setg in qemu_vfio_find_[fixed/temp]_iova

2021-09-07 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Both qemu_vfio_find_fixed_iova() and qemu_vfio_find_temp_iova() return an errno which is unused (or overwritten). Have them propagate eventual errors to callers, returning a boolean (which is what the Error API recommends, see commit e3fe3988d78 "error: Document Error

[PULL 05/11] block/nvme: Have nvme_create_queue_pair() report errors consistently

2021-09-07 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé nvme_create_queue_pair() does not return a boolean value (indicating eventual error) but a pointer, and is inconsistent in how it fills the error handler. To fulfill callers expectations, always set an error message on failure. Reported-by: Auger Eric Reviewed-by: K

[PULL 07/11] util/vfio-helpers: Extract qemu_vfio_water_mark_reached()

2021-09-07 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Extract qemu_vfio_water_mark_reached() for readability, and have it provide an error hint it its Error* handle. Suggested-by: Klaus Jensen Reviewed-by: Klaus Jensen Signed-off-by: Philippe Mathieu-Daudé Message-id: 20210902070025.197072-8-phi...@redhat.com Signed-

[PULL 10/11] util/vfio-helpers: Let qemu_vfio_do_mapping() propagate Error

2021-09-07 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Pass qemu_vfio_do_mapping() an Error* argument so it can propagate any error to callers. Replace error_report() which only report to the monitor by the more generic error_setg_errno(). Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Reviewed-by: Klaus Jensen S

Re: [PATCH v2 1/1] hw/arm/aspeed: Initialize AST2600 UART clock selection registers

2021-09-07 Thread Joel Stanley
On Mon, 6 Sept 2021 at 13:40, wrote: > > From: Peter Delevoryas > > UART5 is typically used as the default debug UART on the AST2600, but > UART1 is also designed to be a debug UART. All the AST2600 UART's have > semi-configurable clock rates through registers in the System Control > Unit (SCU),

[PULL 11/11] block/nvme: Only report VFIO error on failed retry

2021-09-07 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé We expect the first qemu_vfio_dma_map() to fail (indicating DMA mappings exhaustion, see commit 15a730e7a3a). Do not report the first failure as error, since we are going to flush the mappings and retry. This removes spurious error message displayed on the monitor:

Re: [PATCH v2 2/6] qapi/parser: Allow empty QAPIDoc Sections

2021-09-07 Thread Markus Armbruster
John Snow writes: > It simplifies the typing to say that _section is always a > QAPIDoc.Section(). If you say so > To accommodate this change, we must allow for this object to evaluate to > False for functions like _end_section which behave differently based on > whether or not a Section ha

Re: [PATCH 05/10] aspeed/smc: Remove the 'flash' attribute from AspeedSMCFlash

2021-09-07 Thread Philippe Mathieu-Daudé
On 9/7/21 8:58 AM, Cédric Le Goater wrote: > There is no use for it. Hmmm this is not the correct justification. This devices sits on a bus, so its state will be released when the bus is released. There is no need to release it manually, so we can remove the reference. > Signed-off-by: Cédric Le

Re: [PATCH v2 2/5] s390x: kvm: topology: interception of PTF instruction

2021-09-07 Thread Pierre Morel
On 9/6/21 7:21 PM, Thomas Huth wrote: On 22/07/2021 19.42, Pierre Morel wrote: Interception of the PTF instruction depending on the new KVM_CAP_S390_CPU_TOPOLOGY KVM extension. Signed-off-by: Pierre Morel ---   hw/s390x/s390-virtio-ccw.c | 45 ++   include

Re: [PATCH v4] hw/arm/aspeed: Add Fuji machine type

2021-09-07 Thread Joel Stanley
On Mon, 6 Sept 2021 at 13:31, wrote: > > From: Peter Delevoryas > > This adds a new machine type "fuji-bmc" based on the following device tree: > > https://github.com/torvalds/linux/blob/40cb6373b46/arch/arm/boot/dts/aspeed-bmc-facebook-fuji.dts > > Most of the i2c devices are not there, they're

RE: [PATCH v5 4/4] hw/arm/virt: Add PL330 DMA controller and connect with SMMU v3

2021-09-07 Thread Li, Chunming
Hi, > -Original Message- > From: Li, Chunming > Sent: Thursday, September 02, 2021 4:23 PM > To: 'eric.au...@redhat.com'; chunming; peter.mayd...@linaro.org > Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; Wen, Jianxian; Liu, > Renwei > Subject: RE: [PATCH v5 4/4] hw/arm/virt: Add PL330 D

[PATCH V3 03/10] vhost-vdpa: prepare for the multiqueue support

2021-09-07 Thread Jason Wang
Unlike vhost-kernel, vhost-vdpa adapts a single device multiqueue model. So we need to simply use virtqueue index as the vhost virtqueue index. This is a must for multiqueue to work for vhost-vdpa. Signed-off-by: Jason Wang --- hw/virtio/vhost-vdpa.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH V3 04/10] vhost-vdpa: let net_vhost_vdpa_init() returns NetClientState *

2021-09-07 Thread Jason Wang
This patch switches to let net_vhost_vdpa_init() to return NetClientState *. This is used for the callers to allocate multiqueue NetClientState for multiqueue support. Signed-off-by: Jason Wang --- net/vhost-vdpa.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff

[PATCH V3 01/10] vhost-vdpa: open device fd in net_init_vhost_vdpa()

2021-09-07 Thread Jason Wang
This patch switches to open device fd in net_init_vhost_vpda(). This is used to prepare for the multiqueue support. Reviewed-by: Stefano Garzarella Signed-off-by: Jason Wang --- net/vhost-vdpa.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/net/vho

[PATCH V3 08/10] vhost: record the last virtqueue index for the virtio device

2021-09-07 Thread Jason Wang
This patch introduces a new field in the vhost_dev structure to record the last virtqueue index for the virtio device. This will be useful for the vhost backends with 1:N model to start or stop the device after all the vhost_dev structures were started or stopped. Signed-off-by: Jason Wang --- h

[PATCH V3 00/10] vhost-vDPA multiqueue

2021-09-07 Thread Jason Wang
Hi All: This patch implements the multiqueue support for vhost-vDPA. The most important requirement si the control virtqueue support. The virtio-net and vhost-net core are tweak to support control virtqueue as if what data queue pairs are done: a dedicated vhost_net device which is coupled with th

[PATCH V3 05/10] net: introduce control client

2021-09-07 Thread Jason Wang
This patch introduces a boolean for the device has control queue which can accepts control command via network queue. The first user would be the control virtqueue support for vhost. Signed-off-by: Jason Wang --- include/net/net.h | 5 + net/net.c | 24 +--- 2 f

[PATCH V3 07/10] virtio-net: use "queue_pairs" instead of "queues" when possible

2021-09-07 Thread Jason Wang
Most of the time, "queues" really means queue pairs. So this patch switch to use "queue_pairs" to avoid confusion. Signed-off-by: Jason Wang --- hw/net/vhost_net.c | 6 +- hw/net/virtio-net.c| 150 - include/hw/virtio/virtio-net.h | 4 +

[PATCH V3 02/10] vhost-vdpa: classify one time request

2021-09-07 Thread Jason Wang
Vhost-vdpa uses one device multiqueue queue (pairs) model. So we need to classify the one time request (e.g SET_OWNER) and make sure those request were only called once per device. This is used for multiqueue support. Signed-off-by: Jason Wang --- hw/virtio/vhost-vdpa.c | 52 +++

[PATCH V3 09/10] virtio-net: vhost control virtqueue support

2021-09-07 Thread Jason Wang
This patch implements the control virtqueue support for vhost. This requires virtio-net to figure out the datapath queue pairs and control virtqueue via is_datapath and pass the number of those two types of virtqueues to vhost_net_start()/vhost_net_stop(). Signed-off-by: Jason Wang --- hw/net/vh

[PATCH V3 06/10] vhost-net: control virtqueue support

2021-09-07 Thread Jason Wang
We assume there's no cvq in the past, this is not true when we need control virtqueue support for vhost-user backends. So this patch implements the control virtqueue support for vhost-net. As datapath, the control virtqueue is also required to be coupled with the NetClientState. The vhost_net_start

[PATCH V3 10/10] vhost-vdpa: multiqueue support

2021-09-07 Thread Jason Wang
This patch implements the multiqueue support for vhost-vdpa. This is done simply by reading the number of queue pairs from the config space and initialize the datapath and control path net client. Signed-off-by: Jason Wang --- hw/virtio/vhost-vdpa.c | 2 +- net/vhost-vdpa.c | 105 +++

[PATCH] s390x/cpumodel: Add more feature to gen16 default model

2021-09-07 Thread Christian Borntraeger
Add the new gen16 features to the default model and fence them for machine version 6.1 and earlier. Signed-off-by: Christian Borntraeger --- hw/s390x/s390-virtio-ccw.c | 5 + target/s390x/gen-features.c | 8 +++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/hw/s390x/s3

Re: [PATCH v6 0/5] hw/arm/virt: Introduce cpu topology support

2021-09-07 Thread wangyanan (Y)
On 2021/9/7 0:15, Andrew Jones wrote: On Fri, Sep 03, 2021 at 03:38:13PM +0800, wangyanan (Y) wrote: On 2021/9/3 15:25, Peter Maydell wrote: On Fri, 3 Sept 2021 at 08:05, wangyanan (Y) wrote: On 2021/9/2 23:56, Peter Maydell wrote: On Tue, 24 Aug 2021 at 13:20, Yanan Wang wrote: This new

Re: [PATCH v2 3/5] s390x: topology: CPU topology objects and structures

2021-09-07 Thread Pierre Morel
On 9/7/21 9:32 AM, Thomas Huth wrote: On 22/07/2021 19.42, Pierre Morel wrote: We use new objects to have a dynamic administration of the CPU topology. The highier level object is the S390 book. In a first implementation s/highier/higher/ ... or highest ? thx I chose highest And I modify

Re: [PATCH] s390x/cpumodel: Add more feature to gen16 default model

2021-09-07 Thread Christian Borntraeger
On 07.09.21 11:11, Christian Borntraeger wrote: Add the new gen16 features to the default model and fence them for machine version 6.1 and earlier. Signed-off-by: Christian Borntraeger --- hw/s390x/s390-virtio-ccw.c | 5 + target/s390x/gen-features.c | 8 +++- 2 files changed, 1

Re: [PATCH v3 0/6] block-status cache for data regions

2021-09-07 Thread Hanna Reitz
On 12.08.21 10:41, Hanna Reitz wrote: Hi, See the cover letter from v1 for the general idea: https://lists.nongnu.org/archive/html/qemu-block/2021-06/msg00843.html Cover letter from v2, introducing RCU locking: https://lists.nongnu.org/archive/html/qemu-block/2021-06/msg01060.html v3: - Patch

Re: [PULL] qemu-socket unix socket bugfix 2021-09-06

2021-09-07 Thread Peter Maydell
On Mon, 6 Sept 2021 at 20:06, Michael Tokarev wrote: > > 06.09.2021 21:41, Peter Maydell wrote: > .. > > Hi. gpg says the key you signed this with has expired: > > > > gpg: Signature made Mon 06 Sep 2021 16:19:32 BST > > gpg:using RSA key 7B73BAD68BE7A2C289314B22701B4F6B1A693E59 >

Re: [PATCH v2 4/5] s390x: topology: Topology list entries and SYSIB 15.x.x

2021-09-07 Thread Pierre Morel
On 9/7/21 9:46 AM, Thomas Huth wrote: On 22/07/2021 19.42, Pierre Morel wrote: We define the CPU type Topology List Entry and the Container type Topology List Entry to implement SYSIB 15.1.x This patch will be squatched with the next patch. s/squatched/squashed/ ... anyway, why did you se

Re: [PATCH 05/10] aspeed/smc: Remove the 'flash' attribute from AspeedSMCFlash

2021-09-07 Thread Cédric Le Goater
On 9/7/21 10:36 AM, Philippe Mathieu-Daudé wrote: > On 9/7/21 8:58 AM, Cédric Le Goater wrote: >> There is no use for it. > > Hmmm this is not the correct justification. > > This devices sits on a bus, so its state will be released when > the bus is released. There is no need to release it manual

Re: [PATCH 0/2] iotests: Fix pylint warnings

2021-09-07 Thread Hanna Reitz
On 24.08.21 17:35, Hanna Reitz wrote: Hi, I’ve updated my pylint to 2.10.2 and was greeted with some new warnings. Some are fixed by John’s “Run iotest linters during Python CI” series (https://lists.nongnu.org/archive/html/qemu-block/2021-07/msg00611.html), but some are not (namely unspecified-

Re: [PATCH v2 4/5] s390x: topology: Topology list entries and SYSIB 15.x.x

2021-09-07 Thread Pierre Morel
On 9/7/21 9:54 AM, Thomas Huth wrote: On 22/07/2021 19.42, Pierre Morel wrote: We define the CPU type Topology List Entry and the Container type Topology List Entry to implement SYSIB 15.1.x This patch will be squatched with the next patch. Signed-off-by: Pierre Morel ---   target/s390x/cp

Re: [PULL 06/35] hw/acpi: refactor acpi hp modules so that targets can just use what they need

2021-09-07 Thread Ani Sinha
On Tue, Sep 7, 2021 at 12:04 PM Ani Sinha wrote: > > > > On Tue, Sep 7, 2021 at 11:44 AM Philippe Mathieu-Daudé > wrote: >> >> On 9/7/21 7:55 AM, Ani Sinha wrote: >> > On Mon, Sep 6, 2021 at 4:19 PM Ani Sinha wrote: >> >> >> >> On Mon, Sep 6, 2021 at 3:54 PM Philippe Mathieu-Daudé >> >> wrote

Re: [PATCH v4 0/5] iotests/297: Cover tests/

2021-09-07 Thread Hanna Reitz
On 02.09.21 11:40, Hanna Reitz wrote: v1: https://lists.nongnu.org/archive/html/qemu-block/2021-03/msg01471.html v2: https://lists.nongnu.org/archive/html/qemu-block/2021-05/msg00492.html v3: https://lists.nongnu.org/archive/html/qemu-block/2021-05/msg00569.html Hi, Sorry for the long delay, h

Re: [PATCH] s390x/cpumodel: Add more feature to gen16 default model

2021-09-07 Thread David Hildenbrand
On 07.09.21 11:22, Christian Borntraeger wrote: On 07.09.21 11:11, Christian Borntraeger wrote: Add the new gen16 features to the default model and fence them for machine version 6.1 and earlier. Signed-off-by: Christian Borntraeger --- hw/s390x/s390-virtio-ccw.c | 5 + target/s390

Re: [PATCH v2 5/5] s390x: topology: implementating Store Topology System Information

2021-09-07 Thread Pierre Morel
On 9/7/21 10:00 AM, Thomas Huth wrote: On 22/07/2021 19.42, Pierre Morel wrote: The handling of STSI is enhenced with the interception of the s/enhenced/enhanced/ yes, thanks function code 15 for storing CPU topology. ... +static void insert_stsi_15_1_x(S390CPU *cpu, int sel2, __u6

Re: [PATCH v4 4/5] mirror-top-perms: Fix AbnormalShutdown path

2021-09-07 Thread Hanna Reitz
On 02.09.21 12:15, Philippe Mathieu-Daudé wrote: On 9/2/21 11:58 AM, Vladimir Sementsov-Ogievskiy wrote: 02.09.2021 12:40, Hanna Reitz wrote: The AbnormalShutdown exception class is not in qemu.machine, but in qemu.machine.machine.  (qemu.machine.AbnormalShutdown was enough for Python to find i

Re: [PATCH] qemu-img: Allow target be aligned to sector size

2021-09-07 Thread Hanna Reitz
Ping – any thoughts on this? Hanna On 19.08.21 12:12, Hanna Reitz wrote: We cannot write to images opened with O_DIRECT unless we allow them to be resized so they are aligned to the sector size: Since 9c60a5d1978, bdrv_node_refresh_perm() ensures that for nodes whose length is not aligned to th

Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled

2021-09-07 Thread Peter Maydell
On Fri, 4 Jun 2021 at 16:06, Swetha Joshi wrote: > > Can y oh I let me know once it goes in mainline? Thanks! Sorry for having forgotten about this -- I was just clearing out some of my old email backlog and found your email again. You probably discovered this long ago, but this patchset to remov

Re: [PATCH v4 00/33] Qemu SGX virtualization

2021-09-07 Thread Yang Zhong
On Mon, Sep 06, 2021 at 03:13:08PM +0200, Paolo Bonzini wrote: > Hi, > > the monitor patches did not pass the test-hmp qtest, and also they > should be in target/i386/monitor.c (see other commands that were > implemented there for SEV). However, I've sent a pull request with > the rest. > Pa

Re: [PATCH v5 3/4] spapr_numa.c: base FORM2 NUMA affinity support

2021-09-07 Thread Daniel Henrique Barboza
On 9/6/21 10:02 PM, David Gibson wrote: On Mon, Sep 06, 2021 at 09:25:26PM -0300, Daniel Henrique Barboza wrote: The main feature of FORM2 affinity support is the separation of NUMA distances from ibm,associativity information. This allows for a more flexible and straightforward NUMA distance

[PATCH v2] s390x/cpumodel: Add more feature to gen16 default model

2021-09-07 Thread Christian Borntraeger
Add the new gen16 features to the default model and fence them for machine version 6.1 and earlier. Signed-off-by: Christian Borntraeger --- hw/s390x/s390-virtio-ccw.c | 5 + target/s390x/gen-features.c | 8 +++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/hw/s390x/s3

Re: [PATCH v2] s390x/cpumodel: Add more feature to gen16 default model

2021-09-07 Thread David Hildenbrand
On 07.09.21 12:10, Christian Borntraeger wrote: Add the new gen16 features to the default model and fence them for machine version 6.1 and earlier. Signed-off-by: Christian Borntraeger --- hw/s390x/s390-virtio-ccw.c | 5 + target/s390x/gen-features.c | 8 +++- 2 files changed, 12 i

Re: [PATCH v4] virtio/vsock: add two more queues for datagram types

2021-09-07 Thread Stefano Garzarella
On Sun, Sep 05, 2021 at 11:08:34AM -0700, Jiang Wang . wrote: On Mon, Aug 9, 2021 at 3:58 AM Stefano Garzarella wrote: On Thu, Aug 05, 2021 at 12:07:02PM -0700, Jiang Wang . wrote: >On Wed, Aug 4, 2021 at 1:13 AM Stefano Garzarella wrote: >> On Tue, Aug 03, 2021 at 11:41:32PM +, Jiang Wang

Re: [RFC PATCH 0/2] riscv: Adding custom CSR related Kconfig options

2021-09-07 Thread Rahul Pathak
Hi Alistair, One clarification: The unification of architectures is also going to allow multi-arch CPUs (RV32/RV64) in a single machine instance? Or it's just limited to only one in the runtime. Rahul On Tue, Sep 7, 2021 at 1:37 PM Ruinland ChuanTzu Tsai < ruinl...@andestech.com> wrote: > Hi Al

Re: [PATCH v2 3/3] hw/arm/virt_acpi_build: Generate DBG2 table

2021-09-07 Thread Igor Mammedov
On Mon, 6 Sep 2021 14:31:39 +0200 Eric Auger wrote: > ARM SBBR specification mandates DBG2 table (Debug Port Table 2). ^^ revision here, and possibly a pointer [chapter] to concrete place in spec where it's said. > this latter allows to descri

Re: [PATCH v2 1/3] tests/acpi: Add void table for virt/DBG2 bios-tables-test

2021-09-07 Thread Igor Mammedov
On Mon, 6 Sep 2021 14:31:37 +0200 Eric Auger wrote: > Add placeholders for DBG2 reference table for > virt tests and ignore this later for the time being. s/ignore.*/ignore till reference blob is added / > > Signed-off-by: Eric Auger Acked-by: Igor Mammedov > --- > tests/data/acpi/virt/D

Re: [PATCH 05/10] aspeed/smc: Remove the 'flash' attribute from AspeedSMCFlash

2021-09-07 Thread Philippe Mathieu-Daudé
On 9/7/21 11:40 AM, Cédric Le Goater wrote: > On 9/7/21 10:36 AM, Philippe Mathieu-Daudé wrote: >> On 9/7/21 8:58 AM, Cédric Le Goater wrote: >>> There is no use for it. >> >> Hmmm this is not the correct justification. >> >> This devices sits on a bus, so its state will be released when >> the bus

Re: [PATCH v4 4/5] mirror-top-perms: Fix AbnormalShutdown path

2021-09-07 Thread Philippe Mathieu-Daudé
On 9/7/21 11:57 AM, Hanna Reitz wrote: > On 02.09.21 12:15, Philippe Mathieu-Daudé wrote: >> On 9/2/21 11:58 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 02.09.2021 12:40, Hanna Reitz wrote: The AbnormalShutdown exception class is not in qemu.machine, but in qemu.machine.machine.  (qemu.ma

Re: [PATCH 4/5] ebpf_rss_helper: Added helper for eBPF RSS.

2021-09-07 Thread Yuri Benditovich
On Wed, Sep 1, 2021 at 9:42 AM Jason Wang wrote: > > > 在 2021/8/31 上午1:07, Yuri Benditovich 写道: > > On Fri, Aug 20, 2021 at 6:41 AM Jason Wang wrote: > >> > >> 在 2021/7/13 下午11:37, Andrew Melnychenko 写道: > >>> Helper program. Loads eBPF RSS program and maps and passes them through > >>> unix soc

Re: [PATCH v2 3/6] qapi/parser: add type hint annotations (QAPIDoc)

2021-09-07 Thread Markus Armbruster
John Snow writes: > Annotations do not change runtime behavior. > > This commit adds mostly annotations, but uses a TYPE_CHECKING runtime > check to conditionally import dependencies, which only triggers during > runs of mypy. Please add a reference to https://mypy.readthedocs.io/en/latest/runti

[PATCH] ebpf: only include in system emulators

2021-09-07 Thread Paolo Bonzini
eBPF files are being included in system emulators, which is useless and also breaks compilation because ebpf/trace-events is only processed if a system emulator is included in the build. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/566 Signed-off-by: Paolo Bonzini --- ebpf/meson.build

Re: [PATCH v3 0/6] hw/arm: xilinx_zynq: Fix upstream U-Boot boot failure

2021-09-07 Thread Peter Maydell
On Thu, 2 Sept 2021 at 06:40, Edgar E. Iglesias wrote: > > On Wed, Sep 01, 2021 at 08:45:15PM +0800, Bin Meng wrote: > > As of today, when booting upstream U-Boot for Xilinx Zynq, the UART > > does not receive anything. Debugging shows that the UART input clock > > frequency is zero which prevents

Re: [RFC][PATCH v1 00/10] Enable encrypted guest memory access in QEMU

2021-09-07 Thread Ashish Kalra
Hello Yuan, On Thu, Sep 02, 2021 at 11:23:50PM +, Yao, Yuan wrote: > >-Original Message- > >From: Ashish Kalra > >Sent: Thursday, September 02, 2021 22:05 > >To: yuan@linux.intel.com > >Cc: thomas.lenda...@amd.com; arm...@redhat.com; ashish.ka...@amd.com; > >brijesh.si...@amd.com

Re: [PATCH v2 0/6] qapi: static typing conversion, pt5b

2021-09-07 Thread Markus Armbruster
John Snow writes: > This is part five (b), and focuses on QAPIDoc in parser.py. > > gitlab: https://gitlab.com/jsnow/qemu/-/commits/python-qapi-cleanup-pt5b > > Requirements: > - Python 3.6+ > - mypy >= 0.770 > - pylint >= 2.6.0 (2.7.0+ when using Python 3.9+) > > Every commit should pass with: >

Re: [PATCH] ebpf: only include in system emulators

2021-09-07 Thread Philippe Mathieu-Daudé
On 9/7/21 12:45 PM, Paolo Bonzini wrote: > eBPF files are being included in system emulators, which is useless and > also breaks compilation because ebpf/trace-events is only processed > if a system emulator is included in the build. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/566

Re: [PATCH v5 4/4] hw/arm/virt: Add PL330 DMA controller and connect with SMMU v3

2021-09-07 Thread Peter Maydell
On Thu, 2 Sept 2021 at 09:23, Li, Chunming wrote: > Eric Auger wrote: >> On 9/2/21 8:46 AM, Li, Chunming wrote: >>> Eric Auger wrote: Then I think you need to bring a proper motivation behind adding the PL330 in machvirt besides a testing purpose. After this series you would get a

Re: [PATCH] ebpf: only include in system emulators

2021-09-07 Thread Peter Maydell
On Tue, 7 Sept 2021 at 11:47, Paolo Bonzini wrote: > > eBPF files are being included in system emulators, which is useless and do you mean "in user-mode emulators" here ? > also breaks compilation because ebpf/trace-events is only processed > if a system emulator is included in the build. > > R

Re: [PATCH v1 2/3] io: Add zerocopy and errqueue

2021-09-07 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Thu, Sep 02, 2021 at 07:19:58AM -0300, Leonardo Bras Soares Passos wrote: > > On Thu, Sep 2, 2021 at 6:50 AM Daniel P. Berrangé > > wrote: > > > > > > On Thu, Sep 02, 2021 at 06:34:01AM -0300, Leonardo Bras Soares Passos > > > wrote: > > > >

[PATCH] linux-user: Correct host errno for IP[V6]_RECVERR socket options

2021-09-07 Thread Philippe Mathieu-Daudé
Target errno should be converted to host errno in IP_RECVERR and IPV6_RECVERR socket options. Fixes: ee1ac3a1822 ("linux-user: Add sockopts for IPv6") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/602 Reported-by: Conrad Meyer Signed-off-by: Philippe Mathieu-Daudé --- linux-user/sysca

Re: [PATCH v1 3/3] migration: multifd: Enable zerocopy

2021-09-07 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Wed, Sep 01, 2021 at 11:35:33AM -0400, Peter Xu wrote: > > On Wed, Sep 01, 2021 at 09:53:07AM +0100, Daniel P. Berrangé wrote: > > > On Tue, Aug 31, 2021 at 04:29:09PM -0400, Peter Xu wrote: > > > > On Tue, Aug 31, 2021 at 02:16:42PM +0100, Dan

[PATCH] fuzz: fix unbound variable in build.sh

2021-09-07 Thread Alexander Bulekov
/src/build.sh: line 76: GITLAB_CI: unbound variable Fix that. Signed-off-by: Alexander Bulekov --- This change is in preparation to revert: 7602748c ("qemu: manually build glib (#5919)") on OSS-Fuzz. Reverting as-is produces an unbound variable complaint when we try to build the fuzzers in the O

Re: [PATCH v1 3/3] migration: multifd: Enable zerocopy

2021-09-07 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Thu, Sep 02, 2021 at 05:52:15AM -0300, Leonardo Bras Soares Passos wrote: > > On Thu, Sep 2, 2021 at 5:21 AM Daniel P. Berrangé > > wrote: > > > > > > On Thu, Sep 02, 2021 at 04:22:55AM -0300, Leonardo Bras Soares Passos > > > wrote: > > > >

Re: [PATCH] linux-user: Correct host errno for IP[V6]_RECVERR socket options

2021-09-07 Thread Philippe Mathieu-Daudé
On 9/7/21 1:13 PM, Philippe Mathieu-Daudé wrote: > Target errno should be converted to host errno in IP_RECVERR > and IPV6_RECVERR socket options. I meant "Host errno must be converted to target errno ..." > Fixes: ee1ac3a1822 ("linux-user: Add sockopts for IPv6") > Resolves: https://gitlab.com/q

Application of QEMUTimer in short timing.

2021-09-07 Thread Duo jia
In the controller, QEMUTimer will be used in the implementation of timer simulation. I wrote an auto-loading timer with a period of 1ms and the clock source used is QEMU_CLOCK_VIRTUAL. But it doesn't seem to be very accurate, because the actual time after I accumulated it to 500 times took about 7

  1   2   3   4   5   >