John Snow <js...@redhat.com> writes: > This is part five (b), and focuses on QAPIDoc in parser.py. > > gitlab: https://gitlab.com/jsnow/qemu/-/commits/python-qapi-cleanup-pt5b > > Requirements: > - Python 3.6+ > - mypy >= 0.770 > - pylint >= 2.6.0 (2.7.0+ when using Python 3.9+) > > Every commit should pass with: > - `isort -c qapi/` > - `flake8 qapi/` > - `pylint --rcfile=qapi/pylintrc qapi/` > - `mypy --config-file=qapi/mypy.ini qapi/`
Review complete. Let's discuss my findings, decide what needs to be addressed now, then see whether I can do it myself or need you to respin.
