Re: [PATCH RFC 0/3] mirror: rework soft-cancelling READY mirror

2021-07-28 Thread Max Reitz
On 27.07.21 18:47, Vladimir Sementsov-Ogievskiy wrote: Hi all! That's an alternative to (part of) Max's "[PATCH for-6.1? v2 0/7] mirror: Handle errors after READY cancel" and shows' my idea of handling soft-cancelling READY mirror case directly in qmp_block_job_cancel. And cleanup all other job

[PATCH] format code

2021-07-28 Thread ruoguang
From: qwe624758472 <624758...@qq.com> --- block/dmg-bz2.c | 3 +-- block/dmg-lzfse.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/block/dmg-bz2.c b/block/dmg-bz2.c index 37f7ee04be..2022eafc81 100644 --- a/block/dmg-bz2.c +++ b/block/dmg-bz2.c @@ -52,8 +52,7 @@ static

Re: [PATCH] target/arm: kvm: use RCU_READ_LOCK_GUARD() in kvm_arch_fixup_msi_route()

2021-07-28 Thread Paolo Bonzini
On 28/07/21 01:52, Hamza Mahfooz wrote: As per commit 5626f8c6d468 ("rcu: Add automatically released rcu_read_lock variants"), RCU_READ_LOCK_GUARD() should be used instead of rcu_read_{un}lock(). Signed-off-by: Hamza Mahfooz --- Reviewed-by: Paolo Bonzini target/arm/kvm.c | 17 --

Re: [PATCH 3/3] docs: Move user-facing barrier docs into system manual

2021-07-28 Thread Paolo Bonzini
On 27/07/21 22:41, Peter Maydell wrote: +where VM-1 is the name the display configured int the Barrier server in the Barrier server +on the host providing the mouse and the keyboard events. + +by default is ``localhost``, + is ``24800``, and are set to ``0``, + and

Re: [PATCH 0/3] docs: Convert barrier.txt to rST

2021-07-28 Thread Paolo Bonzini
On 27/07/21 22:41, Peter Maydell wrote: This patchset converts docs/barrier.txt to rST, putting it in the appropriate places: * the protocol info lives in interop/ * the "how to use this" info lives in system/ * TODO remarks live in the .c file :-) thanks -- PMM Peter Maydell (3): docs

[PATCH] gitlab-ci.d/buildtest: Mark the aarch64 and ppc64-s390x CFI jobs as manual

2021-07-28 Thread Thomas Huth
These two jobs are currently failing very often - the linker seems to get killed due to out-of-memory problems. Since apparently nobody has currently an idea how to fix that nicely, let's mark the jobs as manual for the time being until someone comes up with a proper fix. Signed-off-by: Thomas Hut

Re: [PATCH 01/20] Hexagon HVX (target/hexagon) README

2021-07-28 Thread Rob Landley
On 7/26/21 8:59 AM, Taylor Simpson wrote: >> Anyway, I still hope somebody else has already done most of this in a git >> tree somewhere. :) > > We're working on system mode support for Hexagon, and we plan to upstream it > when it is ready. Yay! Thanks. While you're at it, why is llvm's cmake c

Re: [PATCH] qga-win: Add support of Windows Server 2022 in get-osinfo command

2021-07-28 Thread Konstantin Kostiuk
ping On Wed, Jul 14, 2021 at 10:25 AM Konstantin Kostiuk wrote: > > ping > > > On Sun, Jul 11, 2021 at 8:18 PM Konstantin Kostiuk > wrote: > >> ping >> >> On Sun, Jul 4, 2021 at 8:51 AM Konstantin Kostiuk >> wrote: >> >>> ping >>> >>> On Mon, Jun 21, 2021 at 3:50 PM Kostiantyn Kostiuk < >>> ko

Re: [PATCH 1/3] qga-win: Increase VSS freeze timeout to 60 secs instead of 10

2021-07-28 Thread Konstantin Kostiuk
ping On Wed, Jul 14, 2021 at 9:17 AM Konstantin Kostiuk wrote: > Hi Michael, > > qga-vss.dll has many dependencies. Please check that all DLLs are present > in the same directory. > > Also, I have a similar problem in my setup. In my case, libgcc_s_seh-1.dll > was renamed in MinGW which I used.

Re: [PATCH v2] qga-win: Free GMatchInfo properly

2021-07-28 Thread Konstantin Kostiuk
ping On Wed, Jul 14, 2021 at 10:26 AM Konstantin Kostiuk wrote: > CC Michael Roth > > On Thu, Jun 10, 2021 at 7:14 PM Daniel P. Berrangé > wrote: > >> On Thu, Jun 10, 2021 at 07:08:36PM +0300, Konstantin Kostiuk wrote: >> > On Thu, Jun 10, 2021 at 7:02 PM Daniel P. Berrangé > > >> > wrote: >> >

Re: [PATCH] gitlab-ci.d/buildtest: Mark the aarch64 and ppc64-s390x CFI jobs as manual

2021-07-28 Thread Daniel P . Berrangé
On Wed, Jul 28, 2021 at 09:51:41AM +0200, Thomas Huth wrote: > These two jobs are currently failing very often - the linker seems to > get killed due to out-of-memory problems. Since apparently nobody has > currently an idea how to fix that nicely, let's mark the jobs as manual > for the time being

Re: [PATCH] target/i386: Added consistency checks for event injection

2021-07-28 Thread Paolo Bonzini
On 25/07/21 11:08, Lara Lazier wrote: VMRUN exits with SVM_EXIT_ERR if either: * The event injected has a reserved type. * When the event injected is of type 3 (exception), and the vector that has been specified does not correspond to an exception. This does not fix the entire exc_inj test

Re: [PATCH] target/i386: Added V_INTR_PRIO check to virtual interrupts

2021-07-28 Thread Paolo Bonzini
On 21/07/21 17:26, Lara Lazier wrote: +static inline bool ctl_has_irq(uint32_t int_ctl) +{ +uint32_t int_prio; +uint32_t tpr; + +int_prio = (int_ctl & V_INTR_PRIO_MASK) >> V_INTR_MASKING_SHIFT; Oops, I missed that this should be V_INTR_PRIO_SHIFT. Can you send the correction pleas

Re: [PATCH RFC 04/19] vfio-user: Define type vfio_user_pci_dev_info

2021-07-28 Thread Stefan Hajnoczi
On Sun, Jul 18, 2021 at 11:27:43PM -0700, Elena Ufimtseva wrote: > From: John G Johnson > > New class for vfio-user with its class and instance > constructors and destructors. > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson > Signed-off-by: Jagannathan Raman > --- > hw/vfi

[PATCH v2] target/i386: Added V_INTR_PRIO check to virtual interrupts

2021-07-28 Thread Lara Lazier
v1->v2: Fixed Mask The APM2 states that The processor takes a virtual INTR interrupt if V_IRQ and V_INTR_PRIO indicate that there is a virtual interrupt pending whose priority is greater than the value in V_TPR. Signed-off-by: Lara Lazier --- target/i386/tcg/sysemu/svm_helper.c | 11 ++-

[PATCH] block/io_uring: resubmit when result is -EAGAIN

2021-07-28 Thread Fabian Ebner
Quoting from [0]: Some setups, like SCSI, can throw spurious -EAGAIN off the softirq completion path. Normally we expect this to happen inline as part of submission, but apparently SCSI has a weird corner case where it can happen as part of normal completions. Host kernels without patch [0] c

[PULL 0/1] Libslirp update

2021-07-28 Thread marcandre . lureau
From: Marc-André Lureau The following changes since commit a2376507f615495b1d16685449ce0ea78c2caf9d: Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' into staging (2021-07-24 11:04:57 +0100) are available in the Git repository at: g...@github.com:elmarco/qemu.git ta

[PULL 1/1] Update libslirp to v4.6.1

2021-07-28 Thread marcandre . lureau
From: Marc-André Lureau Switch from stable-4.2 branch to upstream v4.6.1 release + fixes. ## [Unreleased] ### Fixed - Haiku fixes. !98 !99 - Fix a minor DHCP regression introduced in 4.6.0. !97 ## [4.6.1] - 2021-06-18 ### Fixed - Fix DHCP regression introduced in 4.6.0. !95 ## [4.6.0] -

[Bug 1908626] Re: Atomic test-and-set instruction does not work on qemu-user

2021-07-28 Thread taos
** Changed in: qemu Status: Expired => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1908626 Title: Atomic test-and-set instruction does not work on qemu-user Status in QEMU: New Bug

Re: [PATCH v2 3/6] util/oslib-posix: Don't create too many threads with small memory or little pages

2021-07-28 Thread Pankaj Gupta
> Let's limit the number of threads to something sane, especially that > - We don't have more threads than the number of pages we have > - We don't have threads that initialize small (< 64 MiB) memory > > Signed-off-by: David Hildenbrand > --- > util/oslib-posix.c | 12 ++-- > 1 file chan

Re: [PATCH v2 4/6] util/oslib-posix: Avoid creating a single thread with MADV_POPULATE_WRITE

2021-07-28 Thread Pankaj Gupta
> Let's simplify the case when we only want a single thread and don't have > to mess with signal handlers. > > Signed-off-by: David Hildenbrand > --- > util/oslib-posix.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/util/oslib-posix.c b/util/oslib-posix.c > index a1d309d495..1

Re: [PATCH PING] tests/tcg/linux-test: Fix random hangs in test_socket

2021-07-28 Thread Ilya Leoshkevich
On Tue, 2021-06-01 at 16:20 +0200, Ilya Leoshkevich wrote: > test_socket hangs randomly in connect(), especially when run without > qemu. Apparently the reason is that linux started treating backlog > value of 0 literally instead of rounding it up since v4.4 (commit > ef547f2ac16b). > > So set it

[PATCH v2] target/i386: Added VGIF feature

2021-07-28 Thread Lara Lazier
VGIF allows STGI and CLGI to execute in guest mode and control virtual interrupts in guest mode. When the VGIF feature is enabled then: * executing STGI in the guest sets bit 9 of the VMCB offset 60h. * executing CLGI in the guest clears bit 9 of the VMCB offset 60h. Signed-off-by: Lara Lazier

Re: [PATCH 2/3] ui/input-barrier: Move TODOs from barrier.txt to a comment

2021-07-28 Thread Philippe Mathieu-Daudé
On 7/27/21 10:41 PM, Peter Maydell wrote: > docs/barrier.txt has a couple of TODO notes about things to be > implemented in this device; move them into a comment in the > source code. > > Signed-off-by: Peter Maydell > --- > docs/barrier.txt | 4 > ui/input-barrier.c | 5 + > 2 files

Re: [PATCH] qga-win: Add support of Windows Server 2022 in get-osinfo command

2021-07-28 Thread Philippe Mathieu-Daudé
On 7/28/21 9:53 AM, Konstantin Kostiuk wrote: > ping Seems merged: commit c141814d4f495bd9efdabb1229ce0a5b5a239bf3 Author: Kostiantyn Kostiuk Date: Mon Jun 21 15:50:17 2021 +0300 qga-win: Add support of Windows Server 2022 in get-osinfo command Signed-off-by: Kostiantyn Kostiuk

Re: [PATCH-for-6.1 v2] qga-win: Free GMatchInfo properly

2021-07-28 Thread Philippe Mathieu-Daudé
Still candidate for 6.1. On 7/28/21 9:54 AM, Konstantin Kostiuk wrote: > ping > > On Wed, Jul 14, 2021 at 10:26 AM Konstantin Kostiuk > mailto:konstan...@daynix.com>> wrote: > > CC Michael Roth > > On Thu, Jun 10, 2021 at 7:14 PM Daniel P. Berrangé > mailto:berra...@redhat.com>> wro

Re: [PATCH] gitlab-ci.d/buildtest: Mark the aarch64 and ppc64-s390x CFI jobs as manual

2021-07-28 Thread Philippe Mathieu-Daudé
On 7/28/21 9:51 AM, Thomas Huth wrote: > These two jobs are currently failing very often - the linker seems to > get killed due to out-of-memory problems. Since apparently nobody has > currently an idea how to fix that nicely, let's mark the jobs as manual > for the time being until someone comes u

Re: [PATCH] block/io_uring: resubmit when result is -EAGAIN

2021-07-28 Thread Philippe Mathieu-Daudé
Cc'ing the maintainers for you. See https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer $ ./scripts/get_maintainer.pl -f block/io_uring.c Aarushi Mehta (maintainer:Linux io_uring) Julia Suvorova (maintainer:Linux io_uring) Stefan Hajnoczi (maintainer:Linux io_uring) Kevin W

Re: [PATCH v2 7/9] cpus: Introduce qemu_mutex_unlock_iothread_prepare()

2021-07-28 Thread David Hildenbrand
On 27.07.21 18:08, Peter Xu wrote: On Tue, Jul 27, 2021 at 02:59:26PM +0200, David Hildenbrand wrote: On 23.07.21 21:34, Peter Xu wrote: The prepare function before unlocking BQL. There're only three places that can release the BQL: unlock(), cond_wait() or cond_timedwait(). Signed-off-by: Pe

Re: [PATCH v2 4/9] memory: Don't do topology update in memory finalize()

2021-07-28 Thread David Hildenbrand
On 27.07.21 18:02, Peter Xu wrote: On Tue, Jul 27, 2021 at 03:21:31PM +0200, David Hildenbrand wrote: On 23.07.21 21:34, Peter Xu wrote: Topology update could be wrongly triggered in memory region finalize() if there's bug somewhere else. It'll be a very confusing stack when it happens (e.g.,

Re: [PATCH] docs: Move bootindex.txt into system section and rstify

2021-07-28 Thread Markus Armbruster
Peter Maydell writes: > Move bootindex.txt into the system section of the manual and turn it > into rST format. To make the document make more sense in the context > of the system manual, expand the title and introductory paragraphs to > give more context. > > Signed-off-by: Peter Maydell Revi

[PATCH v12] qapi: introduce 'query-x86-cpuid' QMP command.

2021-07-28 Thread Valeriy Vdovin
Introducing new QMP command 'query-x86-cpuid'. This command can be used to get virtualized cpu model info generated by QEMU during VM initialization in the form of cpuid representation. Diving into more details about virtual CPU generation: QEMU first parses '-cpu' command line option. From there

Re: [PATCH] block/io_uring: resubmit when result is -EAGAIN

2021-07-28 Thread Stefano Garzarella
On Wed, Jul 28, 2021 at 02:09:40PM +0200, Philippe Mathieu-Daudé wrote: Cc'ing the maintainers for you. See https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer $ ./scripts/get_maintainer.pl -f block/io_uring.c Aarushi Mehta (maintainer:Linux io_uring) Julia Suvorova (maint

Re: [PATCH v3] hw/acpi: add an assertion check for non-null return from acpi_get_i386_pci_host

2021-07-28 Thread Michael S. Tsirkin
On Mon, Jul 26, 2021 at 10:27:43PM +0530, Ani Sinha wrote: > All existing code using acpi_get_i386_pci_host() checks for a non-null > return value from this function call. Instead of returning early when the > value > returned is NULL, assert instead. Since there are only two possible host buses >

Re: aarch64 efi boot failures with qemu 6.0+

2021-07-28 Thread Michael S. Tsirkin
On Tue, Jul 27, 2021 at 12:36:03PM +0200, Igor Mammedov wrote: > On Tue, 27 Jul 2021 05:01:23 -0400 > "Michael S. Tsirkin" wrote: > > > On Mon, Jul 26, 2021 at 10:12:38PM -0700, Guenter Roeck wrote: > > > On 7/26/21 9:45 PM, Michael S. Tsirkin wrote: > > > > On Mon, Jul 26, 2021 at 06:00:57PM +

[PATCH] MAINTAINERS: add Stefano Garzarella as io_uring reviewer

2021-07-28 Thread Stefano Garzarella
I've been working with io_uring for a while so I'd like to help with reviews. Signed-off-by: Stefano Garzarella --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 42ac45c3e5..1776d0950b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3257,6 +3257,7

Re: [PATCH 3/7] virtio: Add shared memory capability

2021-07-28 Thread Dr. David Alan Gilbert
* Antonio Caggiano (antonio.caggi...@collabora.com) wrote: > From: "Dr. David Alan Gilbert" > > Define a new capability type 'VIRTIO_PCI_CAP_SHARED_MEMORY_CFG'. > They allow defining shared memory regions with sizes and offsets > of 2^32 and more. > Multiple instances of the capability are allowe

Re: [PATCH-for-6.2 v12] qapi: introduce 'query-x86-cpuid' QMP command.

2021-07-28 Thread Philippe Mathieu-Daudé
On 7/28/21 2:54 PM, Valeriy Vdovin wrote: > Introducing new QMP command 'query-x86-cpuid'. This command can be used to > get virtualized cpu model info generated by QEMU during VM initialization in > the form of cpuid representation. > > Diving into more details about virtual CPU generation: QEMU

Re: aarch64 efi boot failures with qemu 6.0+

2021-07-28 Thread Ard Biesheuvel
On Wed, 28 Jul 2021 at 15:11, Michael S. Tsirkin wrote: > > On Tue, Jul 27, 2021 at 12:36:03PM +0200, Igor Mammedov wrote: > > On Tue, 27 Jul 2021 05:01:23 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Jul 26, 2021 at 10:12:38PM -0700, Guenter Roeck wrote: > > > > On 7/26/21 9:45 PM, Mi

Re: [PATCH] MAINTAINERS: add Stefano Garzarella as io_uring reviewer

2021-07-28 Thread Stefan Hajnoczi
On Wed, Jul 28, 2021 at 03:15:15PM +0200, Stefano Garzarella wrote: > I've been working with io_uring for a while so I'd like to help > with reviews. > > Signed-off-by: Stefano Garzarella > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) Thanks, applied to my block tree: https://gitla

[PATCH v2 1/8] virtio-gpu: CONTEXT_INIT feature

2021-07-28 Thread Antonio Caggiano
Create virgl renderer context with flags using context_id when valid. Signed-off-by: Antonio Caggiano --- hw/display/virtio-gpu-base.c| 2 ++ hw/display/virtio-gpu-virgl.c | 10 -- include/hw/virtio/virtio-gpu-bswap.h| 2 +- include/standard-header

[PATCH v2 2/8] virtio-gpu: hostmem [wip]

2021-07-28 Thread Antonio Caggiano
From: Gerd Hoffmann --- hw/display/virtio-gpu-base.c| 4 +++ hw/display/virtio-gpu-pci.c | 14 + hw/display/virtio-gpu.c | 1 + hw/display/virtio-vga.c | 32 +++-- include/hw/virtio/virtio-gpu.h

[PATCH v2 6/8] virtio-gpu: Support Venus capset

2021-07-28 Thread Antonio Caggiano
Signed-off-by: Antonio Caggiano --- hw/display/virtio-gpu-virgl.c | 21 + include/standard-headers/linux/virtio_gpu.h | 2 ++ 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c index 38e5

[PATCH v2 0/8] virtio-gpu: Support Venus Vulkan driver

2021-07-28 Thread Antonio Caggiano
This series of patches enables support for the Venus VirtIO-GPU Vulkan driver by adding some features required by the driver: - CONTEXT_INIT - HOSTMEM - RESOURCE_UUID - BLOB_RESOURCES In addition to these features, Venus capset support was required together with the implementation for Virgl blob

[PATCH v2 7/8] virtio-gpu: Initialize Venus

2021-07-28 Thread Antonio Caggiano
Enable VirGL unstable APIs and request Venus when initializing VirGL. Signed-off-by: Antonio Caggiano --- hw/display/virtio-gpu-virgl.c | 2 +- meson.build | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu

[PATCH v2 3/8] virtio: Add shared memory capability

2021-07-28 Thread Antonio Caggiano
From: "Dr. David Alan Gilbert" Define a new capability type 'VIRTIO_PCI_CAP_SHARED_MEMORY_CFG' and the data structure 'virtio_pci_shm_cap' to go with it. They allow defining shared memory regions with sizes and offsets of 2^32 and more. Multiple instances of the capability are allowed and disting

[PATCH v2 4/8] virtio-gpu: Shared memory capability

2021-07-28 Thread Antonio Caggiano
Use VIRTIO_GPU_SHM_ID_HOST_VISIBLE as id for virtio-gpu. Also, remove struct virtio_pci_shm_cap as virtio_pci_cap64 can be used instead. Signed-off-by: Antonio Caggiano --- hw/display/virtio-gpu-pci.c | 2 +- hw/display/virtio-vga.c | 2 +- hw/virtio/virtio-pc

[PATCH v2 5/8] virtio-gpu: Resource UUID

2021-07-28 Thread Antonio Caggiano
Enable resource UUID feature and implement command resource assign UUID. For the moment, use the resource ID as UUID. Signed-off-by: Antonio Caggiano --- hw/display/trace-events| 1 + hw/display/virtio-gpu-base.c | 2 ++ hw/display/virtio-gpu-virgl.c | 3 +++ hw/display/virtio-gpu.

[PATCH v2 8/8] virtio-gpu: Handle resource blob commands

2021-07-28 Thread Antonio Caggiano
Support BLOB resources creation by calling virgl_renderer_resource_create_blob. Signed-off-by: Antonio Caggiano --- hw/display/virtio-gpu-virgl.c| 148 +++ hw/display/virtio-gpu.c | 9 +- include/hw/virtio/virtio-gpu-bswap.h | 18 include/hw/v

Re: [PATCH v2 4/9] memory: Don't do topology update in memory finalize()

2021-07-28 Thread Peter Xu
On Wed, Jul 28, 2021 at 02:13:17PM +0200, David Hildenbrand wrote: > On 27.07.21 18:02, Peter Xu wrote: > > On Tue, Jul 27, 2021 at 03:21:31PM +0200, David Hildenbrand wrote: > > > On 23.07.21 21:34, Peter Xu wrote: > > > > Topology update could be wrongly triggered in memory region finalize() > >

Re: [PATCH v2 4/9] memory: Don't do topology update in memory finalize()

2021-07-28 Thread David Hildenbrand
On 28.07.21 15:56, Peter Xu wrote: On Wed, Jul 28, 2021 at 02:13:17PM +0200, David Hildenbrand wrote: On 27.07.21 18:02, Peter Xu wrote: On Tue, Jul 27, 2021 at 03:21:31PM +0200, David Hildenbrand wrote: On 23.07.21 21:34, Peter Xu wrote: Topology update could be wrongly triggered in memory r

Re: aarch64 efi boot failures with qemu 6.0+

2021-07-28 Thread Guenter Roeck
On 7/28/21 6:25 AM, Ard Biesheuvel wrote: On Wed, 28 Jul 2021 at 15:11, Michael S. Tsirkin wrote: On Tue, Jul 27, 2021 at 12:36:03PM +0200, Igor Mammedov wrote: On Tue, 27 Jul 2021 05:01:23 -0400 "Michael S. Tsirkin" wrote: On Mon, Jul 26, 2021 at 10:12:38PM -0700, Guenter Roeck wrote: On

Re: [PATCH v3] hw/acpi: add an assertion check for non-null return from acpi_get_i386_pci_host

2021-07-28 Thread Ani Sinha
On Wed, 28 Jul 2021, Michael S. Tsirkin wrote: > On Mon, Jul 26, 2021 at 10:27:43PM +0530, Ani Sinha wrote: > > All existing code using acpi_get_i386_pci_host() checks for a non-null > > return value from this function call. Instead of returning early when the > > value > > returned is NULL, a

Re: [PATCH] block/io_uring: resubmit when result is -EAGAIN

2021-07-28 Thread Stefan Hajnoczi
On Wed, Jul 28, 2021 at 12:35:18PM +0200, Fabian Ebner wrote: > Quoting from [0]: > > Some setups, like SCSI, can throw spurious -EAGAIN off the softirq > completion path. Normally we expect this to happen inline as part > of submission, but apparently SCSI has a weird corner case where it > c

Re: [PATCH] gitlab-ci.d/buildtest: Mark the aarch64 and ppc64-s390x CFI jobs as manual

2021-07-28 Thread Willian Rampazzo
On Wed, Jul 28, 2021 at 4:51 AM Thomas Huth wrote: > > These two jobs are currently failing very often - the linker seems to > get killed due to out-of-memory problems. Since apparently nobody has > currently an idea how to fix that nicely, let's mark the jobs as manual > for the time being until

[PATCH 2/4] docs: Fold usb2.txt USB controller information into usb.rst

2021-07-28 Thread Peter Maydell
Fold the information in docs/usb2.txt about the different kinds of supported USB controller into the main rST manual. Signed-off-by: Peter Maydell --- docs/system/devices/usb.rst | 86 + docs/usb2.txt | 82 --- 2 f

[PATCH 3/4] docs: Fold usb2.txt physical port addressing info into usb.rst

2021-07-28 Thread Peter Maydell
Fold the usb2.txt documentation about specifying which physical port a USB device should use into usb.rst. Signed-off-by: Peter Maydell --- docs/system/devices/usb.rst | 33 + docs/usb2.txt | 32 2 files changed, 33 i

[PATCH 0/4] docs: Move usb2.txt, usb-storage.txt into rST manual

2021-07-28 Thread Peter Maydell
We already have a section of the rST manual describing USB emulation support; this patchset moves the information from the text files docs/usb2.txt and docs/usb-storage.txt into the rST manual. The changes here include reformatting into rST and a little bit of wordsmithing in places. I also added

[PATCH 1/4] docs: Incorporate information in usb-storage.txt into rST manual

2021-07-28 Thread Peter Maydell
We already have a section on USB in the rST manual; fold the information in docs/usb-storage.txt into it. We add 'format=raw' to the various -drive options in the code examples, because QEMU will print warnings these days if you omit it. Signed-off-by: Peter Maydell --- docs/system/devices/usb.

[PATCH 4/4] docs: Fold usb2.txt passthrough information into usb.rst

2021-07-28 Thread Peter Maydell
Fold the usb2.txt information on device passthrough into usb.rst; since this is the last part of the .txt file we can delete it now. Signed-off-by: Peter Maydell --- docs/system/devices/usb.rst | 49 +++ docs/usb2.txt | 58 ---

Re: [PULL 0/1] Miscellaneous patches for 2021-07-27

2021-07-28 Thread Peter Maydell
On Tue, 27 Jul 2021 at 16:22, Markus Armbruster wrote: > > The following changes since commit ca4b5ef371d6602b73bc5eec08e3199b05caf146: > > Merge remote-tracking branch > 'remotes/dgilbert-gitlab/tags/pull-migration-20210726a' into staging > (2021-07-27 10:55:50 +0100) > > are available in the

[PATCH v13] qapi: introduce 'query-x86-cpuid' QMP command.

2021-07-28 Thread Valeriy Vdovin
Introducing new QMP command 'query-x86-cpuid'. This command can be used to get virtualized cpu model info generated by QEMU during VM initialization in the form of cpuid representation. Diving into more details about virtual CPU generation: QEMU first parses '-cpu' command line option. From there

Re: [PATCH v5 02/10] ACPI ERST: specification for ERST support

2021-07-28 Thread Eric DeVolder
On 7/27/21 6:45 AM, Igor Mammedov wrote: On Mon, 26 Jul 2021 14:52:15 -0500 Eric DeVolder wrote: On 7/26/21 5:06 AM, Igor Mammedov wrote: On Wed, 21 Jul 2021 10:42:33 -0500 Eric DeVolder wrote: On 7/19/21 10:02 AM, Igor Mammedov wrote: On Wed, 30 Jun 2021 19:26:39 + Eric DeVolde

Re: [PATCH v5 06/10] ACPI ERST: build the ACPI ERST table

2021-07-28 Thread Eric DeVolder
On 7/27/21 7:01 AM, Igor Mammedov wrote: On Mon, 26 Jul 2021 15:02:55 -0500 Eric DeVolder wrote: [...] +build_serialization_instruction_entry(table_data, action, +ACPI_ERST_INST_WRITE_REGISTER_VALUE, 0, 32, +s->bar0 + ERST_CSR_ACTION, action, MASK

Re: [PATCH v5 00/10] acpi: Error Record Serialization Table, ERST, support for QEMU

2021-07-28 Thread Eric DeVolder
On 7/27/21 7:55 AM, Igor Mammedov wrote: PS: If I haven't said it already, use checkpatch script before posting patches. I do run checkpatch. On occasion I allow a warning about a line too long. And there is the MAINTAINERs message due to the new files. Is there something else that I'm miss

Re: [PULL 0/1] Libslirp update

2021-07-28 Thread Peter Maydell
On Wed, 28 Jul 2021 at 11:51, wrote: > > From: Marc-André Lureau > > The following changes since commit a2376507f615495b1d16685449ce0ea78c2caf9d: > > Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' > into staging (2021-07-24 11:04:57 +0100) > > are available in the Git

[Bug 1908626] Re: Atomic test-and-set instruction does not work on qemu-user

2021-07-28 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/509 ** Changed in: qemu Status: New => Expired ** Bug watch

Re: [PULL 0/1] Libslirp update

2021-07-28 Thread Marc-André Lureau
Hi On Wed, Jul 28, 2021 at 7:23 PM Peter Maydell wrote: > On Wed, 28 Jul 2021 at 11:51, wrote: > > > > From: Marc-André Lureau > > > > The following changes since commit > a2376507f615495b1d16685449ce0ea78c2caf9d: > > > > Merge remote-tracking branch > 'remotes/bonzini-gitlab/tags/for-upstre

Re: [PATCH v4 00/33] Qemu SGX virtualization

2021-07-28 Thread Paolo Bonzini
On 19/07/21 13:21, Yang Zhong wrote: Since Sean Christopherson has left Intel and i am responsible for Qemu SGX upstream work. His @intel.com address will be bouncing and his new email( sea...@google.com) is also in CC lists. This series is Qemu SGX virtualization implementation rebased on lates

Re: [PATCH 6/7] virtio-gpu: Initialize Venus

2021-07-28 Thread Paolo Bonzini
On 27/07/21 19:05, Antonio Caggiano wrote: diff --git a/meson.build b/meson.build index f2e148eaf9..31b65050b7 100644 --- a/meson.build +++ b/meson.build @@ -483,6 +483,7 @@ if not get_option('virglrenderer').auto() or have_system method: 'pkg-config',

Re: [PATCH RFC server 04/11] vfio-user: find and init PCI device

2021-07-28 Thread Jag Raman
> On Jul 26, 2021, at 11:05 AM, John Levon wrote: > > On Mon, Jul 19, 2021 at 04:00:06PM -0400, Jagannathan Raman wrote: > >> +vfu_pci_set_id(o->vfu_ctx, >> + pci_get_word(o->pci_dev->config + PCI_VENDOR_ID), >> + pci_get_word(o->pci_dev->config + PCI_DE

[PATCH] gitlab-ci.d/custom-runners: Improve rules for the staging branch

2021-07-28 Thread Thomas Huth
If maintainers are currently pushing to a branch called "staging" in their repository, they are ending up with some stuck jobs - unless they have a s390x CI runner machine available. That's ugly, we should make sure that the related jobs are really only started if such a runner is available. So let

Re: [PATCH v2 0/6] migration/ram: Optimize for virtio-mem via RamDiscardManager

2021-07-28 Thread David Hildenbrand
On 27.07.21 19:10, Peter Xu wrote: On Tue, Jul 27, 2021 at 11:25:09AM +0200, David Hildenbrand wrote: For 2) I see 3 options: a) Sync everything, fixup the dirty bitmap, never clear the dirty log of discarded parts. It's fairly simple and straight forward, as I can simply reuse the existing hel

[Bug 1908626] Re: Atomic test-and-set instruction does not work on qemu-user

2021-07-28 Thread Thomas Huth
Hi taos! Could you please check whether this has been fixed already in QEMU v6.1.0-rc1 ? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1908626 Title: Atomic test-and-set instruction does not work o

Re: [PATCH RFC 03/19] vfio-user: define VFIO Proxy and communication functions

2021-07-28 Thread John Johnson
> On Jul 27, 2021, at 9:34 AM, Stefan Hajnoczi wrote: > > On Sun, Jul 18, 2021 at 11:27:42PM -0700, Elena Ufimtseva wrote: >> From: John G Johnson >> >> Add user.c and user.h files for vfio-user with the basic >> send and receive functions. >> >> Signed-off-by: John G Johnson >> Signed-off-

[PATCH-for-6.1 0/3] hw/sd/sdcard: Fix assertion accessing out-of-range addresses with CMD30

2021-07-28 Thread Philippe Mathieu-Daudé
Fix an assertion reported by OSS-Fuzz, add corresponding qtest. The change simple enough for the next rc. Philippe Mathieu-Daudé (3): hw/sd/sdcard: Document out-of-range addresses for SEND_WRITE_PROT hw/sd/sdcard: Fix assertion accessing out-of-range addresses with CMD30 hw/sd/sdcard: R

[PATCH-for-6.1 1/3] hw/sd/sdcard: Document out-of-range addresses for SEND_WRITE_PROT

2021-07-28 Thread Philippe Mathieu-Daudé
Per the 'Physical Layer Simplified Specification Version 3.01', Table 4-22: 'Block Oriented Write Protection Commands' SEND_WRITE_PROT (CMD30) If the card provides write protection features, this command asks the card to send the status of the write protection bits [1]. [1] 32 write prot

[PATCH-for-6.1 2/3] hw/sd/sdcard: Fix assertion accessing out-of-range addresses with CMD30

2021-07-28 Thread Philippe Mathieu-Daudé
OSS-Fuzz found sending illegal addresses when querying the write protection bits triggers the assertion added in commit 84816fb63e5 ("hw/sd/sdcard: Assert if accessing an illegal group"): qemu-fuzz-i386-target-generic-fuzz-sdhci-v3: ../hw/sd/sd.c:824: uint32_t sd_wpbits(SDState *, uint64_t):

[PATCH-for-6.2 3/3] hw/sd/sdcard: Rename Write Protect Group variables

2021-07-28 Thread Philippe Mathieu-Daudé
'wp_groups' holds a bitmap, rename it as 'wp_group_bmap'. 'wpgrps_size' is the bitmap size (in bits), rename it as 'wp_group_bits'. Patch created mechanically using: $ sed -i -e s/wp_groups/wp_group_bmap/ \ -e s/wpgrps_size/wp_group_bits/ hw/sd/sd.c Signed-off-by: Philippe Mathieu-D

Re: [PATCH] gitlab-ci.d/custom-runners: Improve rules for the staging branch

2021-07-28 Thread Philippe Mathieu-Daudé
On 7/28/21 7:38 PM, Thomas Huth wrote: > If maintainers are currently pushing to a branch called "staging" > in their repository, they are ending up with some stuck jobs - unless > they have a s390x CI runner machine available. That's ugly, we should > make sure that the related jobs are really onl

[PATCH v3 1/8] cpus: Export queue work related fields to cpu.h

2021-07-28 Thread Peter Xu
This patch has no functional change, but prepares for moving the function do_run_on_cpu() into softmmu/cpus.c. It does: 1. Move qemu_work_item into hw/core/cpu.h. 2. Export queue_work_on_cpu()/qemu_work_cond. All of them will be used by softmmu/cpus.c later. Reviewed-by: David Hildenbrand

[PATCH v3 3/8] memory: Introduce memory_region_transaction_depth_{inc|dec}()

2021-07-28 Thread Peter Xu
memory_region_transaction_{begin|commit}() could be too big when finalizing a memory region. E.g., we should never attempt to update address space topology during the finalize() of a memory region. Provide helpers for further use. Signed-off-by: Peter Xu --- softmmu/memory.c | 14 -

[PATCH v3 2/8] cpus: Move do_run_on_cpu into softmmu/cpus.c

2021-07-28 Thread Peter Xu
It's only used by softmmu binaries not linux-user ones. Make it static and drop the definition in the header too. Since at it, initialize variable "wi" with less loc. Reviewed-by: David Hildenbrand Signed-off-by: Peter Xu --- cpus-common.c | 25 - include/hw/co

[PATCH v3 6/8] cpus: Remove the mutex parameter from do_run_on_cpu()

2021-07-28 Thread Peter Xu
We must use the BQL for do_run_on_cpu() without much choice, it means the parameter is useless. Remove it. Meanwhile use the newly introduced qemu_cond_wait_iothread() in do_run_on_cpu(). Reviewed-by: David Hildenbrand Signed-off-by: Peter Xu --- softmmu/cpus.c | 7 +++ 1 file changed, 3

[PATCH v3 4/8] memory: Don't do topology update in memory finalize()

2021-07-28 Thread Peter Xu
Topology update could be wrongly triggered in memory region finalize() if there's bug somewhere else. It'll be a very confusing stack when it happens (e.g., sending KVM ioctl within the RCU thread, and we'll observe it only until it fails!). Instead of that, we use the push()/pop() helper to avoi

[PATCH v3 5/8] cpus: Use qemu_cond_wait_iothread() where proper

2021-07-28 Thread Peter Xu
The helper is introduced but we've still got plenty of places that are directly referencing the qemu_global_mutex itself. Spread the usage. Reviewed-by: David Hildenbrand Signed-off-by: Peter Xu --- softmmu/cpus.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/softmm

[PATCH v3 0/8] memory: Sanity checks memory transaction when releasing BQL

2021-07-28 Thread Peter Xu
This is v3 of the series. And, I think this is 6.2 material. v2 changelog: - Init qemu_work_item directly in do_run_on_cpu() [David] - Rename memory_region_transaction_{push|pop} to *_depth_{inc|dec} [David] - Changing wording of s/helpless/useless/ [David] - Squashed v2 patch 7 into patch 8 [Davi

[PATCH v3 7/8] memory: Assert on no ongoing memory transaction before release BQL

2021-07-28 Thread Peter Xu
Firstly, add a "prepare" function before unlocking BQL. There're only three places that can release the BQL: unlock(), cond_wait() or cond_timedwait(). Make sure we don't have any more ongoing memory transaction when releasing the BQL. This will trigger an abort if we misuse the QEMU memory mode

[PATCH v3 8/8] memory: Delay the transaction pop() until commit completed

2021-07-28 Thread Peter Xu
This should be functionally the same as before, but this allows the memory_region_transaction_depth to be non-zero during commit, which can help us to do sanity check on misuses. Since at it, fix an indentation issue on the bracket. Signed-off-by: Peter Xu --- softmmu/memory.c | 12 +---

Re: [PATCH v3 2/8] cpus: Move do_run_on_cpu into softmmu/cpus.c

2021-07-28 Thread Philippe Mathieu-Daudé
On 7/28/21 8:31 PM, Peter Xu wrote: > It's only used by softmmu binaries not linux-user ones. Make it static and > drop the definition in the header too. > > Since at it, initialize variable "wi" with less loc. > > Reviewed-by: David Hildenbrand > Signed-off-by: Peter Xu > --- > cpus-common.c

[PATCH] MAINTAINERS: Added myself as a reviewer for the NVMe Block Driver

2021-07-28 Thread Philippe Mathieu-Daudé
I'm interested in following the activity around the NVMe bdrv. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 42ac45c3e50..4a42e9eceaf 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3178,6 +3178,7 @@ F: bl

Re: [PATCH v3 6/8] cpus: Remove the mutex parameter from do_run_on_cpu()

2021-07-28 Thread Philippe Mathieu-Daudé
On 7/28/21 8:31 PM, Peter Xu wrote: > We must use the BQL for do_run_on_cpu() without much choice, it means the > parameter is useless. Remove it. Meanwhile use the newly introduced > qemu_cond_wait_iothread() in do_run_on_cpu(). > > Reviewed-by: David Hildenbrand > Signed-off-by: Peter Xu > -

Re: [PATCH v3 5/8] cpus: Use qemu_cond_wait_iothread() where proper

2021-07-28 Thread Philippe Mathieu-Daudé
On 7/28/21 8:31 PM, Peter Xu wrote: > The helper is introduced but we've still got plenty of places that are > directly > referencing the qemu_global_mutex itself. Spread the usage. > > Reviewed-by: David Hildenbrand > Signed-off-by: Peter Xu > --- > softmmu/cpus.c | 6 +++--- > 1 file change

Re: [PATCH v2 7/8] virtio-gpu: Initialize Venus

2021-07-28 Thread Philippe Mathieu-Daudé
On 7/28/21 3:46 PM, Antonio Caggiano wrote: > Enable VirGL unstable APIs and request Venus when initializing VirGL. > > Signed-off-by: Antonio Caggiano > --- > hw/display/virtio-gpu-virgl.c | 2 +- > meson.build | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > diff -

Re: [PATCH v3 1/8] cpus: Export queue work related fields to cpu.h

2021-07-28 Thread Philippe Mathieu-Daudé
On 7/28/21 8:31 PM, Peter Xu wrote: > This patch has no functional change, but prepares for moving the function > do_run_on_cpu() into softmmu/cpus.c. It does: > > 1. Move qemu_work_item into hw/core/cpu.h. > 2. Export queue_work_on_cpu()/qemu_work_cond. > > All of them will be used by softm

Re: [PATCH v2 2/8] virtio-gpu: hostmem [wip]

2021-07-28 Thread Philippe Mathieu-Daudé
On 7/28/21 3:46 PM, Antonio Caggiano wrote: > From: Gerd Hoffmann > > --- > hw/display/virtio-gpu-base.c| 4 +++ > hw/display/virtio-gpu-pci.c | 14 + > hw/display/virtio-gpu.c | 1 + > hw/display/virtio-vga.c | 32

Re: About two-dimensional page translation (e.g., Intel EPT) and shadow page table in Linux QEMU/KVM

2021-07-28 Thread harry harry
Sean, sorry for the late reply. Thanks for your careful explanations. > For emulation of any instruction/flow that starts with a guest virtual > address. > On Intel CPUs, that includes quite literally any "full" instruction emulation, > since KVM needs to translate CS:RIP to a guest physical addr

Re: [PATCH] gitlab-ci.d/custom-runners: Improve rules for the staging branch

2021-07-28 Thread Willian Rampazzo
On Wed, Jul 28, 2021 at 2:39 PM Thomas Huth wrote: > > If maintainers are currently pushing to a branch called "staging" > in their repository, they are ending up with some stuck jobs - unless > they have a s390x CI runner machine available. That's ugly, we should > make sure that the related jobs

Re: [PATCH v2 2/2] tests: migration-test: Add dirty ring test

2021-07-28 Thread Richard Henderson
On 6/15/21 7:55 AM, Peter Xu wrote: Add dirty ring test if kernel supports it. Add the dirty ring parameter on source should be mostly enough, but let's change the dest too to make them match always. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- tests/qtest/migration-test.

Re: [PATCH v2 0/6] migration/ram: Optimize for virtio-mem via RamDiscardManager

2021-07-28 Thread Peter Xu
On Wed, Jul 28, 2021 at 07:39:39PM +0200, David Hildenbrand wrote: > > Meanwhile, I still have no idea how much overhead the "loop" part could > > bring. > > For a large virtio-mem region with frequent plugged/unplugged mem > > interacted, > > it seems possible to take a while to me.. I have no

  1   2   >