We must use the BQL for do_run_on_cpu() without much choice, it means the parameter is useless. Remove it. Meanwhile use the newly introduced qemu_cond_wait_iothread() in do_run_on_cpu().
Reviewed-by: David Hildenbrand <da...@redhat.com> Signed-off-by: Peter Xu <pet...@redhat.com> --- softmmu/cpus.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/softmmu/cpus.c b/softmmu/cpus.c index e714dfbf2b..9154cd7e78 100644 --- a/softmmu/cpus.c +++ b/softmmu/cpus.c @@ -383,8 +383,7 @@ void qemu_init_cpu_loop(void) } static void -do_run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu_data data, - QemuMutex *mutex) +do_run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu_data data) { struct qemu_work_item wi = { .func = func, @@ -400,14 +399,14 @@ do_run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu_data data, while (!qatomic_mb_read(&wi.done)) { CPUState *self_cpu = current_cpu; - qemu_cond_wait(&qemu_work_cond, mutex); + qemu_cond_wait_iothread(&qemu_work_cond); current_cpu = self_cpu; } } void run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu_data data) { - do_run_on_cpu(cpu, func, data, &qemu_global_mutex); + do_run_on_cpu(cpu, func, data); } static void qemu_cpu_stop(CPUState *cpu, bool exit) -- 2.31.1