[PATCH] docs/nvdimm: Update nvdimm option value in machine example

2021-07-26 Thread Pankaj Gupta
Update nvdimm option value in example command from "-machine pc,nvdimm" to "-machine pc,nvdimm=on" as former complains with the below error: "qemu-system-x86_64: -machine pc,nvdimm: Expected '=' after parameter 'nvdimm'" Signed-off-by: Pankaj Gupta --- docs/nvdimm.txt | 2 +- 1 file changed, 1

Re: [PATCH for-6.1? 4/6] job: Add job_cancel_requested()

2021-07-26 Thread Max Reitz
On 22.07.21 19:58, Vladimir Sementsov-Ogievskiy wrote: 22.07.2021 15:26, Max Reitz wrote: Most callers of job_is_cancelled() actually want to know whether the job is on its way to immediate termination.  For example, we refuse to pause jobs that are cancelled; but this only makes sense for jobs

Re: [PATCH for-6.1? 1/6] mirror: Keep s->synced on error

2021-07-26 Thread Max Reitz
On 22.07.21 18:25, Vladimir Sementsov-Ogievskiy wrote: 22.07.2021 15:26, Max Reitz wrote: An error does not take us out of the READY phase, which is what s->synced signifies.  It does of course mean that source and target are no longer in sync, but that is what s->actively_sync is for -- s->sync

Re: [PATCH 01/20] Hexagon HVX (target/hexagon) README

2021-07-26 Thread Rob Landley
On 7/19/21 11:19 AM, Sid Manning wrote:>> -Original Message- >> From: Brian Cain >> Sent: Monday, July 19, 2021 8:40 AM >> To: Rob Landley ; Taylor Simpson >> ; qemu-devel@nongnu.org; Sid Manning >> >> Cc: a...@rev.ng; peter.mayd...@linaro.org; richard.hender...@linaro.org; >> phi...@redh

Re: [PATCH resend v2 5/5] softmmu/memory_mapping: optimize for RamDiscardManager sections

2021-07-26 Thread David Hildenbrand
On 24.07.21 00:33, Peter Xu wrote: On Fri, Jul 23, 2021 at 08:56:54PM +0200, David Hildenbrand wrote: As I've asked this question previously elsewhere, it's more or less also related to the design decision of having virtio-mem being able to sparsely plugged in such a small granularity rather th

Re: [PATCH] hw/intc/arm_gic: Fix set/clear pending of PPI/SPI

2021-07-26 Thread Sebastian Huber
Hello Luc, thanks for having a look at the patch. On 25/07/2021 10:08, Luc Michel wrote: Hi Sebastian, On 11:49 Fri 09 Jul , Sebastian Huber wrote: According to the GICv3 specification register GICD_ISPENDR0 is Banked for each You're referring to GICv3 but actually modifying GICv2 model.

Re: [PATCH resend v2 1/5] tpm: mark correct memory region range dirty when clearing RAM

2021-07-26 Thread David Hildenbrand
On 24.07.21 00:35, Peter Xu wrote: On Fri, Jul 23, 2021 at 09:15:43PM +0200, David Hildenbrand wrote: On 23.07.21 16:52, Peter Xu wrote: On Tue, Jul 20, 2021 at 03:03:00PM +0200, David Hildenbrand wrote: @@ -30,11 +30,13 @@ void tpm_ppi_reset(TPMPPI *tpmppi) guest_phys_blocks_init(&

Re: virtio-gpu: Mapping blob resources

2021-07-26 Thread Gerd Hoffmann
On Fri, Jul 23, 2021 at 05:07:52PM +0200, Antonio Caggiano wrote: > Awesome, thanks! > > I already cherry-picked that commit. :D > > I am experimenting with memory regions now. So, I created a ram subregion, > did I use the right type for the task? Yes, ram is correct. > I added it to the gpu h

[PATCH v2] This is a test mail

2021-07-26 Thread Shuuichirou Ishii
This is a test mail to check the behavior of my mail because it is not listed in the ML of qemu-devel. I may send several test mails. I apologize and thank you for your patience. Shuuichirou Ishii (1): Test mail v2. This is a test mail to check the behavior of my mail because it is not

Re: [PATCH v2 0/1] ui/gtk: prevent QEMU lock up

2021-07-26 Thread Gerd Hoffmann
Hi, > Since commit 8eb13bbbac ("ui/gtk: vte: fix sending multiple > characeters") it's very easy to lock up QEMU with the GTK ui. > If you configure a guest with a serial device and the guest > doesn't listen on this device, QEMU will lock up after > entering two characters in the serial console

Re: [PATCH 01/20] Hexagon HVX (target/hexagon) README

2021-07-26 Thread Rob Landley
On 7/26/21 2:57 AM, Rob Landley wrote: > Anyway... it doesn't look like qemu-system-hexagon (softmmu) its currently in > vanilla qemu? Is there a public fork that has this somewhere? I did a little wild flailing to get ./configure to give me a qemu-system-hexagon option (patch attached), I.E. just

Re: [PULL for 6.1-rc1 00/28] doc, metadata, plugin and testing updates

2021-07-26 Thread Daniel P . Berrangé
On Sat, Jul 24, 2021 at 11:04:03AM +0100, Peter Maydell wrote: > On Fri, 23 Jul 2021 at 18:44, Philippe Mathieu-Daudé > wrote: > > > > On 7/23/21 7:03 PM, Alex Bennée wrote: > > > I realised I'm on holiday next week so I thought I'd better send this now. > > > > > > The following changes since co

Re: Prefetches in buffer_zero_*

2021-07-26 Thread Dr. David Alan Gilbert
* Joe Mario (jma...@redhat.com) wrote: > On Thu, Jul 22, 2021 at 3:14 PM Dr. David Alan Gilbert > wrote: > > > * Richard Henderson (richard.hender...@linaro.org) wrote: > > > On 7/22/21 12:02 AM, Dr. David Alan Gilbert wrote: > > > > Hi Richard, > > > >I think you were the last person to fidd

Re: [PATCH-for-6.1 v3] block/nvme: Fix VFIO_MAP_DMA failed: No space left on device

2021-07-26 Thread Stefan Hajnoczi
On Fri, Jul 23, 2021 at 09:58:43PM +0200, Philippe Mathieu-Daudé wrote: > When the NVMe block driver was introduced (see commit bdd6a90a9e5, > January 2018), Linux VFIO_IOMMU_MAP_DMA ioctl was only returning > -ENOMEM in case of error. The driver was correctly handling the > error path to recycle i

Re: [PATCH v2 03/22] target/loongarch: Add core definition

2021-07-26 Thread Song Gao
Hi, Richard. On 07/23/2021 06:43 AM, Richard Henderson wrote: > On 7/20/21 11:52 PM, Song Gao wrote: >> This patch add target state header, target definitions >> and initialization routines. >> >> Signed-off-by: Song Gao >> --- >>   target/loongarch/cpu-param.h |  21 >>   target/loongarch/

[PULL for-6.1 0/1] Block patches

2021-07-26 Thread Stefan Hajnoczi
The following changes since commit a2376507f615495b1d16685449ce0ea78c2caf9d: Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' into staging (2021-07-24 11:04:57 +0100) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block-pull-request

[PULL for-6.1 1/1] block/nvme: Fix VFIO_MAP_DMA failed: No space left on device

2021-07-26 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé When the NVMe block driver was introduced (see commit bdd6a90a9e5, January 2018), Linux VFIO_IOMMU_MAP_DMA ioctl was only returning -ENOMEM in case of error. The driver was correctly handling the error path to recycle its volatile IOVA mappings. To fix CVE-2019-3882,

RE: [PATCH v2] This is a test mail

2021-07-26 Thread ishii.shuuic...@fujitsu.com
Test reply. > -Original Message- > From: Shuuichirou Ishii > Sent: Monday, July 26, 2021 5:21 PM > To: qemu-...@nongnu.org; qemu-devel@nongnu.org > Cc: Ishii, Shuuichirou/石井 周一郎 > Subject: [PATCH v2] This is a test mail > > This is a test mail to check the behavior of my mail because i

Re: aarch64 efi boot failures with qemu 6.0+

2021-07-26 Thread Philippe Mathieu-Daudé
On 7/26/21 12:56 AM, Guenter Roeck wrote: > On 7/25/21 3:14 PM, Michael S. Tsirkin wrote: >> On Sat, Jul 24, 2021 at 11:52:34AM -0700, Guenter Roeck wrote: >>> Hi all, >>> >>> starting with qemu v6.0, some of my aarch64 efi boot tests no longer >>> work. Analysis shows that PCI devices with IO port

Re: [PATCH v6 0/6] hmp, qmp: Add some commands to introspect virtio devices

2021-07-26 Thread Jonah Palmer
On 7/22/21 5:16 AM, Jason Wang wrote: 在 2021/7/21 下午4:53, Jonah Palmer 写道: Hi Jason. My apologies for the delayed response, several work-related things came up recently, but they're slowing down now so I'm turning my attention these patches to get taken care of. A few questions and comme

Re: [PATCH for-6.1 1/2] accel/tcg: Don't use CF_COUNT_MASK as the max value of icount_decr.u16.low

2021-07-26 Thread Philippe Mathieu-Daudé
On 7/25/21 7:44 PM, Peter Maydell wrote: > In cpu_loop_exec_tb() we were bounding the number of insns we might > try to execute in a TB using CF_COUNT_MASK. This is incorrect, > because we can validly put up to 0x into icount_decr.u16.low. In > particular, since commit 78ff82bb1b67c0d7 reduce

RE: [PATCH v2] This is a test mail

2021-07-26 Thread ishii.shuuic...@fujitsu.com
Test reply 2. > -Original Message- > From: Shuuichirou Ishii > Sent: Monday, July 26, 2021 5:21 PM > To: qemu-...@nongnu.org; qemu-devel@nongnu.org > Subject: [PATCH v2] This is a test mail > > This is a test mail to check the behavior of my mail because it is not listed > in the > ML

Re: [PATCH v2 04/22] target/loongarch: Add interrupt handling support

2021-07-26 Thread Song Gao
Hi, Richard. On 07/23/2021 06:47 AM, Richard Henderson wrote: > On 7/20/21 11:53 PM, Song Gao wrote: >> +bool loongarch_cpu_exec_interrupt(CPUState *cs, int interrupt_request) >> +{ >> +    if (interrupt_request & CPU_INTERRUPT_HARD) { >> +    LoongArchCPU *cpu = LOONGARCH_CPU(cs); >> +   

Re: [PATCH v2 05/22] target/loongarch: Add memory management support

2021-07-26 Thread Song Gao
Hi, Richard. On 07/23/2021 06:48 AM, Richard Henderson wrote: > On 7/20/21 11:53 PM, Song Gao wrote: >> This patch introduces one memory-management-related functions >> - loongarch_cpu_tlb_fill() >> >> Signed-off-by: Song Gao >> --- >>   target/loongarch/cpu.c    |   1 + >>   target/loongarch

Re: [PATCH v6 4/6] qmp: add QMP command x-debug-virtio-queue-status

2021-07-26 Thread Jonah Palmer
On 7/22/21 5:22 AM, Jason Wang wrote: 在 2021/7/21 下午4:59, Jonah Palmer 写道: On 7/13/21 10:37 PM, Jason Wang wrote: 在 2021/7/12 下午6:35, Jonah Palmer 写道: From: Laurent Vivier This new command shows internal status of a VirtQueue. (vrings and indexes). Signed-off-by: Laurent Vivier Signed

Re: [PATCH v6 6/6] hmp: add virtio commands

2021-07-26 Thread Jonah Palmer
On 7/22/21 5:18 AM, Jason Wang wrote: 在 2021/7/21 下午5:11, Jonah Palmer 写道: On 7/13/21 10:40 PM, Jason Wang wrote: 在 2021/7/12 下午6:35, Jonah Palmer 写道: +void hmp_virtio_queue_status(Monitor *mon, const QDict *qdict) +{ +    Error *err = NULL; +    const char *path = qdict_get_try_str(qdic

Re: [PATCH v2 06/22] target/loongarch: Add main translation routines

2021-07-26 Thread Song Gao
Hi, Richard. On 07/23/2021 07:50 AM, Richard Henderson wrote: > On 7/20/21 11:53 PM, Song Gao wrote: >> +/* General purpose registers moves. */ >> +void gen_load_gpr(TCGv t, int reg) >> +{ >> +    if (reg == 0) { >> +    tcg_gen_movi_tl(t, 0); >> +    } else { >> +    tcg_gen_mov_tl(t, cpu

ping Re: [PATCH] Fix CPUID_Fn8000001E_EBX for AMD

2021-07-26 Thread Jade Cheng
ping. On Wed, Jun 30, 2021, 16:26 wrote: According to AMD64 Arch Programmer's Manual Appendix D, bits 7:0 in Fn8000_001E_EBX should be physical core(s) per logical processor, not per die. Signed-off-by: Jade Cheng --- target/i386/cpu.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) d

Re: [PATCH v2] This is a test mail

2021-07-26 Thread Peter Maydell
On Mon, 26 Jul 2021 at 09:21, Shuuichirou Ishii wrote: > > This is a test mail to check the behavior of my mail > because it is not listed in the ML of qemu-devel. > I may send several test mails. > > I apologize and thank you for your patience. These ones seem to have reached both qemu-devel and

Re: [PATCH v5 02/10] ACPI ERST: specification for ERST support

2021-07-26 Thread Igor Mammedov
On Wed, 21 Jul 2021 10:42:33 -0500 Eric DeVolder wrote: > On 7/19/21 10:02 AM, Igor Mammedov wrote: > > On Wed, 30 Jun 2021 19:26:39 + > > Eric DeVolder wrote: > > > >> Oops, at the end of the 4th paragraph, I meant to state that "Linux does > >> not support the NVRAM mode." > >> rather

Re: [PATCH] qemu-options.hx: Fix formatting of -machine memory-backend option

2021-07-26 Thread Peter Maydell
On Mon, 19 Jul 2021 at 14:07, Igor Mammedov wrote: > > On Mon, 19 Jul 2021 11:52:57 +0100 > Peter Maydell wrote: > > > The documentation of the -machine memory-backend has some minor > > formatting errors: > > * Misindentation of the initial line meant that the whole option > >section is inc

Re: [PATCH v5 05/10] ACPI ERST: support for ACPI ERST feature

2021-07-26 Thread Igor Mammedov
On Wed, 21 Jul 2021 12:36:20 -0500 Eric DeVolder wrote: > On 7/20/21 7:17 AM, Igor Mammedov wrote: > > On Wed, 30 Jun 2021 15:07:16 -0400 > > Eric DeVolder wrote: > >> + > >> +static const TypeInfo erst_type_info = { > >> +.name = TYPE_ACPI_ERST, > >> +.parent= TYPE_PC

Status of stable release effort ?

2021-07-26 Thread Daniel P . Berrangé
We are currently in the final lead up to shipping the 6.1.0 release AFAICT from git tags, the latest stable release was 5.0.1 in Sep 2020 https://gitlab.com/qemu-project/qemu/-/tags There have been many patches sent to qemu-stable each month e.g. https://lists.nongnu.org/archive/html/qemu-

Re: [PATCH for-6.1? v2 1/9] nbd/server: Mark variable unused in nbd_negotiate_meta_queries

2021-07-26 Thread Vladimir Sementsov-Ogievskiy
25.07.2021 15:24, Richard Henderson wrote: From clang-13: nbd/server.c:976:22: error: variable 'bitmaps' set but not used \ [-Werror,-Wunused-but-set-variable] which is incorrect; see //bugs.llvm.org/show_bug.cgi?id=3888. Cc:qemu-bl...@nongnu.org Cc: Eric Blake Cc: Vladimir Sementsov-Ogie

Re: [PATCH] docs: Update path that mentions deprecated.rst

2021-07-26 Thread Peter Maydell
On Fri, 23 Jul 2021 at 10:02, Peter Maydell wrote: > > On Fri, 23 Jul 2021 at 07:59, Mao Zhongyi > wrote: > > > > Missed in commit f3478392 "docs: Move deprecation, build > > and license info out of system/" > > > > Signed-off-by: Mao Zhongyi > > --- > > MAINTAINERS | 2 +- > > configure

[PATCH v3] mips/tlb_helper: Add support for 'info tlb' cmd

2021-07-26 Thread Arkadiy
From: NDNF This adds hmp 'info tlb' command support for the mips platform. 1k pages are not supported. Signed-off-by: Ivanov Arkady --- v3: dump all cores, fixed output --- hmp-commands-info.hx | 3 ++- target/mips/cpu.h| 3 +++ target/mips/meson.build | 1 + target/mips/monito

Re: [PATCH for-6.1? 1/6] mirror: Keep s->synced on error

2021-07-26 Thread Vladimir Sementsov-Ogievskiy
22.07.2021 15:26, Max Reitz wrote: An error does not take us out of the READY phase, which is what s->synced signifies. It does of course mean that source and target are no longer in sync, but that is what s->actively_sync is for -- s->synced never meant that source and target are in sync, only

Re: [PATCH v5 05/10] ACPI ERST: support for ACPI ERST feature

2021-07-26 Thread Igor Mammedov
On Wed, 21 Jul 2021 11:07:40 -0500 Eric DeVolder wrote: > On 7/20/21 7:17 AM, Igor Mammedov wrote: > > On Wed, 30 Jun 2021 15:07:16 -0400 > > Eric DeVolder wrote: > > > >> This change implements the support for the ACPI ERST feature. > > Drop this > Done > > > > >> > >> This implement

Re: [PATCH v2 1/3] target/arm: Correctly bound length in sve_zcr_get_valid_len

2021-07-26 Thread Peter Maydell
On Fri, 23 Jul 2021 at 21:36, Richard Henderson wrote: > > Currently, our only caller is sve_zcr_len_for_el, which has > already masked the length extracted from ZCR_ELx, so the > masking done here is a nop. But we will shortly have uses > from other locations, where the length will be unmasked.

Re: [PATCH v2 2/3] target/arm: Export aarch64_sve_zcr_get_valid_len

2021-07-26 Thread Peter Maydell
On Fri, 23 Jul 2021 at 21:36, Richard Henderson wrote: > > Rename from sve_zcr_get_valid_len and make accessible > from outside of helper.c. > > Signed-off-by: Richard Henderson > --- > target/arm/internals.h | 10 ++ Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v5 06/10] ACPI ERST: build the ACPI ERST table

2021-07-26 Thread Igor Mammedov
On Wed, 21 Jul 2021 11:12:41 -0500 Eric DeVolder wrote: > On 7/20/21 8:16 AM, Igor Mammedov wrote: > > On Wed, 30 Jun 2021 15:07:17 -0400 > > Eric DeVolder wrote: > > > >> This code is called from the machine code (if ACPI supported) > >> to generate the ACPI ERST table. > > should be along

[PULL 1/6] ui/gtk: Fix relative mouse with multiple monitors

2021-07-26 Thread Gerd Hoffmann
From: Dennis Wölfing To handle relative mouse input the event handler needs to move the mouse away from the screen edges. Failing to do so results in the mouse getting stuck at invisible walls. However the current implementation for this is broken on hosts with multiple monitors. With multiple m

[PULL 5/6] ui: update keycodemapdb submodule commit

2021-07-26 Thread Gerd Hoffmann
From: Akihiko Odaki The change of ui/keycodemapdb effective on QEMU is only commit d21009b1c9f94b740ea66be8e48a1d8ad8124023, which adds mappings for key codes added in commit d7696ff884e35c6dacf83a7cbe3355e3b0a90125. d21009b1c9f94b740ea66be8e48a1d8ad8124023 Add QEMU QKeyCode "lang1" and "lang2"

[PULL 3/6] ui/egl-headless: Remove a check for CONFIG_OPENGL

2021-07-26 Thread Gerd Hoffmann
From: Akihiko Odaki ui/egl-headless is only built when CONFIG_OPENGL is defined because it depends on CONFIG_OPENGL without condition. Remove a redundant conditonal in ui/egl-headless.c Signed-off-by: Akihiko Odaki Reviewed-by: Marc-André Lureau Message-Id: <20210714055646.85952-1-akihiko.od..

[PULL 0/6] Fixes 20210726 patches

2021-07-26 Thread Gerd Hoffmann
The following changes since commit a2376507f615495b1d16685449ce0ea78c2caf9d: Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' into staging (2021-07-24 11:04:57 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/fixes-20210726-pu

[PULL 6/6] ui/gtk: add a keyboard fifo to the VTE consoles

2021-07-26 Thread Gerd Hoffmann
From: Volker Rümelin Since commit 8eb13bbbac ("ui/gtk: vte: fix sending multiple characeters") it's very easy to lock up QEMU with the GTK ui. If you configure a guest with a serial device and the guest doesn't listen on this device, QEMU will lock up after entering two characters in the serial c

[PULL 2/6] ui/spice: Use HAVE_SPICE_GL for OpenGL checks

2021-07-26 Thread Gerd Hoffmann
From: Akihiko Odaki Some code in ui/spice used CONFIG_OPENGL for OpenGL conditionals, but SPICE also depends on CONFIG_GBM and SPICE server whose version is 0.13.1 or later for OpenGL. Always use HAVE_SPICE_GL, which defines the precise condition. Signed-off-by: Akihiko Odaki Reviewed-by: Marc-

[PULL 4/6] ui/cocoa: Fix the type of main's argv

2021-07-26 Thread Gerd Hoffmann
From: Akihiko Odaki Signed-off-by: Akihiko Odaki Reviewed-by: Peter Maydell Message-Id: <20210708165619.29299-1-akihiko.od...@gmail.com> Signed-off-by: Gerd Hoffmann --- ui/cocoa.m | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 9f72844b07

Re: [PATCH v2 3/3] target/arm: Add sve-default-vector-length cpu property

2021-07-26 Thread Peter Maydell
On Fri, 23 Jul 2021 at 21:36, Richard Henderson wrote: > > Mirror the behavour of /proc/sys/abi/sve_default_vector_length > under the real linux kernel. We have no way of passing along > a real default across exec like the kernel can, but this is a > decent way of adjusting the startup vector len

Re: [PATCH v5 07/10] ACPI ERST: trace support

2021-07-26 Thread Igor Mammedov
On Wed, 21 Jul 2021 11:14:37 -0500 Eric DeVolder wrote: > On 7/20/21 8:15 AM, Igor Mammedov wrote: > > On Wed, 30 Jun 2021 15:07:18 -0400 > > Eric DeVolder wrote: > > > >> Provide the definitions needed to support tracing in ACPI ERST. > > trace points should be introduced in patches that u

Re: [PATCH] tests/qtest/migration-test.c: use 127.0.0.1 instead of 0

2021-07-26 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > From: "Dr. David Alan Gilbert" > > OpenBSD doesn't like :0 as an address, switch to using 127.0.0.1 > in baddest; it's really testing the :0 port number that isn't allowed > on anything. > > (The test doesn't currently run anyway beca

Re: [PATCH v5 08/10] ACPI ERST: create ACPI ERST table for pc/x86 machines.

2021-07-26 Thread Igor Mammedov
On Wed, 21 Jul 2021 11:16:42 -0500 Eric DeVolder wrote: > On 7/20/21 8:19 AM, Igor Mammedov wrote: > > On Wed, 30 Jun 2021 15:07:19 -0400 > > Eric DeVolder wrote: > > > >> This change exposes ACPI ERST support for x86 guests. > >> > >> Signed-off-by: Eric DeVolder > > looks good to me, may

Re: Prefetches in buffer_zero_*

2021-07-26 Thread Philippe Mathieu-Daudé
+Lukáš On 7/26/21 10:47 AM, Dr. David Alan Gilbert wrote: > * Joe Mario (jma...@redhat.com) wrote: >> On Thu, Jul 22, 2021 at 3:14 PM Dr. David Alan Gilbert >> wrote: >> >>> * Richard Henderson (richard.hender...@linaro.org) wrote: On 7/22/21 12:02 AM, Dr. David Alan Gilbert wrote: > Hi

Re: [PATCH v5 09/10] ACPI ERST: qtest for ERST

2021-07-26 Thread Igor Mammedov
On Wed, 21 Jul 2021 11:18:44 -0500 Eric DeVolder wrote: > On 7/20/21 8:38 AM, Igor Mammedov wrote: > > On Wed, 30 Jun 2021 15:07:20 -0400 > > Eric DeVolder wrote: > > > >> This change provides a qtest that locates and then does a simple > >> interrogation of the ERST feature within the guest.

Re: [PATCH v3 0/5] migrations: Fix potential rare race of migration-test after yank

2021-07-26 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > v3: > - Use WITH_QEMU_LOCK_GUARD() for patch 2 [Eric] > (potentially I can also replace other existing uses of qemu_file_lock into >WITH_QEMU_LOCK_GUARD, but I decided to took Dave's r-b first and leave that >for later) > - Added r-bs for Dave on pa

Re: [PATCH v2 07/22] target/loongarch: Add fixed point arithmetic instruction translation

2021-07-26 Thread Song Gao
Hi, Richard. On 07/23/2021 08:46 AM, Richard Henderson wrote: > On 7/20/21 11:53 PM, Song Gao wrote: >> +/* Fixed point arithmetic operation instruction translation */ >> +static bool trans_add_w(DisasContext *ctx, arg_add_w *a) >> +{ >> +    TCGv Rd = cpu_gpr[a->rd]; >> +    TCGv Rj = cpu_gpr[a->

Re: [PATCH v2 08/22] target/loongarch: Add fixed point shift instruction translation

2021-07-26 Thread Song Gao
Hi, Richard. On 07/23/2021 08:51 AM, Richard Henderson wrote: > On 7/20/21 11:53 PM, Song Gao wrote: >> +/* Fixed point shift operation instruction translation */ >> +static bool trans_sll_w(DisasContext *ctx, arg_sll_w *a) >> +{ >> +    TCGv t0, t1; >> +    TCGv Rd = cpu_gpr[a->rd]; >> + >> +   

Re: [PATCH] hw/acpi: some cosmetic improvements to existing code

2021-07-26 Thread Igor Mammedov
On Wed, 21 Jul 2021 19:46:10 +0530 Ani Sinha wrote: > All existing code using acpi_get_i386_pci_host() checks for a non-null > return from this function call. This change brings the same check to > acpi_pcihp_disable_root_bus() function. Also adds a comment describing > why we unconditionally pas

Re: Prefetches in buffer_zero_*

2021-07-26 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > +Lukáš > > On 7/26/21 10:47 AM, Dr. David Alan Gilbert wrote: > > * Joe Mario (jma...@redhat.com) wrote: > >> On Thu, Jul 22, 2021 at 3:14 PM Dr. David Alan Gilbert > >> > >> wrote: > >> > >>> * Richard Henderson (richard.hender...@linaro.org

Re: [PATCH v2 09/22] target/loongarch: Add fixed point bit instruction translation

2021-07-26 Thread Song Gao
Hi, Richard. On 07/23/2021 09:29 AM, Richard Henderson wrote: > On 7/20/21 11:53 PM, Song Gao wrote: >> This patch implement fixed point bit instruction translation. >> >> This includes: >> - EXT.W.{B/H} >> - CL{O/Z}.{W/D}, CT{O/Z}.{W/D} >> - BYTEPICK.{W/D} >> - REVB.{2H/4H/2W/D} >> - REVH.{2W/D}

Re: [PATCH v2 10/22] target/loongarch: Add fixed point load/store instruction translation

2021-07-26 Thread Song Gao
Hi, Richard. On 07/23/2021 09:45 AM, Richard Henderson wrote: >> +/* Fixed point load/store instruction translation */ >> +static bool trans_ld_b(DisasContext *ctx, arg_ld_b *a) >> +{ >> +    TCGv t0; >> +    TCGv Rd = cpu_gpr[a->rd]; >> +    int mem_idx = ctx->mem_idx; >> + >> +    if (a->rd == 0

Re: [PATCH v2 11/22] target/loongarch: Add fixed point atomic instruction translation

2021-07-26 Thread Song Gao
Hi, Richard. On 07/23/2021 09:49 AM, Richard Henderson wrote: > On 7/20/21 11:53 PM, Song Gao wrote: >> +#define TRANS_AM_W(name, op)  \ >> +static bool trans_ ## name(DisasContext *ctx, arg_ ## name * a)   \ >> +{

[PATCH] raw-format: drop WRITE and RESIZE child perms when possible

2021-07-26 Thread Stefan Hajnoczi
The following command-line fails due to a permissions conflict: $ qemu-storage-daemon \ --blockdev driver=nvme,node-name=nvme0,device=:08:00.0,namespace=1 \ --blockdev driver=raw,node-name=l1-1,file=nvme0,offset=0,size=1073741824 \ --blockdev driver=raw,node-name=l1-2,file

Re: [PULL for 6.1-rc1 00/28] doc, metadata, plugin and testing updates

2021-07-26 Thread Peter Maydell
On Mon, 26 Jul 2021 at 09:45, Daniel P. Berrangé wrote: > > On Sat, Jul 24, 2021 at 11:04:03AM +0100, Peter Maydell wrote: > > On Fri, 23 Jul 2021 at 18:44, Philippe Mathieu-Daudé > > wrote: > > > > > > On 7/23/21 7:03 PM, Alex Bennée wrote: > > > > I realised I'm on holiday next week so I thoug

Re: [PATCH v2 0/3] target/arm: Add sve-default-vector-length cpu property

2021-07-26 Thread Peter Maydell
On Fri, 23 Jul 2021 at 21:34, Richard Henderson wrote: > > This is intended to resolve #482. > > Changes for v2: > * Split out length bounding fix to new patch. > * Use byte units for sve-default-vector-length. > * Support undocumented -1 "maximum". > * Add documentation. I'm going to app

[PULL 1/7] tests/qtest/migration-test.c: use 127.0.0.1 instead of 0

2021-07-26 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" OpenBSD doesn't like :0 as an address, switch to using 127.0.0.1 in baddest; it's really testing the :0 port number that isn't allowed on anything. (The test doesn't currently run anyway because of the userfault problem that Peter noticed, but this gets us closer t

[PULL 0/7] migration queue

2021-07-26 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The following changes since commit a2376507f615495b1d16685449ce0ea78c2caf9d: Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' into staging (2021-07-24 11:04:57 +0100) are available in the Git repository at: https://gitlab.com/dagrh/qem

[PULL 7/7] migration: clear the memory region dirty bitmap when skipping free pages

2021-07-26 Thread Dr. David Alan Gilbert (git)
From: Wei Wang When skipping free pages to send, their corresponding dirty bits in the memory region dirty bitmap need to be cleared. Otherwise the skipped pages will be sent in the next round after the migration thread syncs dirty bits from the memory region dirty bitmap. Cc: David Hildenbrand

[PULL 3/7] migration: Make from_dst_file accesses thread-safe

2021-07-26 Thread Dr. David Alan Gilbert (git)
From: Peter Xu Accessing from_dst_file is potentially racy in current code base like below: if (s->from_dst_file) do_something(s->from_dst_file); Because from_dst_file can be reset right after the check in another thread (rp_thread). One example is migrate_fd_cancel(). Use the same qemu

[PULL 2/7] migration: Fix missing join() of rp_thread

2021-07-26 Thread Dr. David Alan Gilbert (git)
From: Peter Xu It's possible that the migration thread skip the join() of the rp_thread in below race and crash on src right at finishing migration: migration_thread rp_thread - migration_completion()

[PULL 6/7] migration: Move the yank unregister of channel_close out

2021-07-26 Thread Dr. David Alan Gilbert (git)
From: Peter Xu It's efficient, but hackish to call yank unregister calls in channel_close(), especially it'll be hard to debug when qemu crashed with some yank function leaked. Remove that hack, but instead explicitly unregister yank functions at the places where needed, they are: (on src)

[PULL 4/7] migration: Introduce migration_ioc_[un]register_yank()

2021-07-26 Thread Dr. David Alan Gilbert (git)
From: Peter Xu There're plenty of places in migration/* that checks against either socket or tls typed ioc for yank operations. Provide two helpers to hide all these information. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu Message-Id: <20210722175841.938739-4-pet...@redhat.com

[PULL 5/7] migration: Teach QEMUFile to be QIOChannel-aware

2021-07-26 Thread Dr. David Alan Gilbert (git)
From: Peter Xu migration uses QIOChannel typed qemufiles. In follow up patches, we'll need the capability to identify this fact, so that we can get the backing QIOChannel from a QEMUFile. We can also define types for QEMUFile but so far since we only need to be able to identify QIOChannel, intr

[PATCH v2] hw/acpi: some cosmetic improvements to existing code

2021-07-26 Thread Ani Sinha
All existing code using acpi_get_i386_pci_host() checks for a non-null return from this function call. This change brings the same check to acpi_pcihp_disable_root_bus() function. Fixes: c0e427d6eb5fef ("hw/acpi/ich9: Enable ACPI PCI hot-plug") Signed-off-by: Ani Sinha --- hw/acpi/pcihp.c | 5 +

Re: [PATCH] hw/acpi: some cosmetic improvements to existing code

2021-07-26 Thread Ani Sinha
On Mon, 26 Jul 2021, Igor Mammedov wrote: > On Wed, 21 Jul 2021 19:46:10 +0530 > Ani Sinha wrote: > > > All existing code using acpi_get_i386_pci_host() checks for a non-null > > return from this function call. This change brings the same check to > > acpi_pcihp_disable_root_bus() function. Al

Re: [PATCH v2 12/22] target/loongarch: Add fixed point extra instruction translation

2021-07-26 Thread Song Gao
Hi, Richard. On 07/23/2021 01:12 PM, Richard Henderson wrote: > On 7/20/21 11:53 PM, Song Gao wrote: >> +target_ulong helper_cpucfg(CPULoongArchState *env, target_ulong rj) >> +{ >> +    target_ulong r = 0; >> + >> +    switch (rj) { >> +    case 0: >> +    r = env->CSR_MCSR0 & 0x; >

Re: [PATCH] hw/intc/arm_gic: Fix set/clear pending of PPI/SPI

2021-07-26 Thread Peter Maydell
On Mon, 26 Jul 2021 at 09:06, Sebastian Huber wrote: > Ok, I will remove this part from the patch in v2. I probably didn't > fully understand how the Qemu GICv2 emulation works. What I wanted to > address is this behaviour (see GICv2 manual) when someone changes the > GICD_ITARGETSR (n > 1): > > "

Re: [question] Shall we flush ITS tables into guest RAM when shutdown the VM?

2021-07-26 Thread Kunkun Jiang
Hi Eric, On 2021/7/6 21:52, Eric Auger wrote: Hi, On 7/6/21 10:18 AM, Kunkun Jiang wrote: Hi Eric, On 2021/6/30 17:16, Eric Auger wrote: On 6/30/21 3:38 AM, Kunkun Jiang wrote: On 2021/6/30 4:14, Eric Auger wrote: Hi Kunkun, On 6/29/21 11:33 AM, Kunkun Jiang wrote: Hi all, Accroding to

Re: [question] Shall we flush ITS tables into guest RAM when shutdown the VM?

2021-07-26 Thread Kunkun Jiang
On 2021/7/6 22:27, Eric Auger wrote: Hi Dave, On 7/6/21 4:19 PM, Dr. David Alan Gilbert wrote: * Eric Auger (eric.au...@redhat.com) wrote: Hi, On 7/6/21 10:18 AM, Kunkun Jiang wrote: Hi Eric, On 2021/6/30 17:16, Eric Auger wrote: On 6/30/21 3:38 AM, Kunkun Jiang wrote: On 2021/6/30 4:14,

Re: [PATCH] hw/acpi: some cosmetic improvements to existing code

2021-07-26 Thread Igor Mammedov
On Mon, 26 Jul 2021 18:26:28 +0530 (IST) Ani Sinha wrote: > On Mon, 26 Jul 2021, Igor Mammedov wrote: > > > On Wed, 21 Jul 2021 19:46:10 +0530 > > Ani Sinha wrote: > > > > > All existing code using acpi_get_i386_pci_host() checks for a non-null > > > return from this function call. This chang

Re: [PATCH] hw/acpi: some cosmetic improvements to existing code

2021-07-26 Thread Ani Sinha
On Mon, 26 Jul 2021, Igor Mammedov wrote: > On Wed, 21 Jul 2021 19:46:10 +0530 > Ani Sinha wrote: > > > All existing code using acpi_get_i386_pci_host() checks for a non-null > > return from this function call. This change brings the same check to > > acpi_pcihp_disable_root_bus() function. Al

Re: [PATCH] hw/acpi: some cosmetic improvements to existing code

2021-07-26 Thread Ani Sinha
> > > > diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c > > > > index f4d706e47d..856c6e1b47 100644 > > > > --- a/hw/acpi/pcihp.c > > > > +++ b/hw/acpi/pcihp.c > > > > @@ -136,6 +136,11 @@ static void acpi_pcihp_disable_root_bus(void) > > > > return; > > > > } > > > > > > > > +i

Re: [PATCH] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

2021-07-26 Thread Igor Mammedov
On Thu, 22 Jul 2021 12:00:09 +0300 Marcel Apfelbaum wrote: > Q35 has now ACPI hotplug enabled by default for PCI(e) devices. > As opposed to native PCIe hotplug, some guests will not assign could be 'some guests' be more specific, preferably with a way to reproduce issue. > IO range to pcie-roo

RE: [PATCH 01/20] Hexagon HVX (target/hexagon) README

2021-07-26 Thread Taylor Simpson
We're working on system mode support for Hexagon, and we plan to upstream it when it is ready. Thanks, Taylor > -Original Message- > From: Rob Landley > Sent: Monday, July 26, 2021 3:55 AM > To: Sid Manning ; Brian Cain ; > Taylor Simpson ; qemu-devel@nongnu.org; linux- > hexa...@vger

Adding a GPU simulator to QEMU

2021-07-26 Thread qyang51 qyang51
Hi, I am writing to consult you on how to add a GPU simulator to QEMU. Currently, I am using qemu-system-riscv64 with "machine -virt" and plan to add a GPU to this SoC. Would you mind give me some suggestions? Thank you very much! Yours sincerely, Qiaowen Yang

Re: [PATCH resend v2 1/5] tpm: mark correct memory region range dirty when clearing RAM

2021-07-26 Thread Peter Xu
On Mon, Jul 26, 2021 at 10:08:59AM +0200, David Hildenbrand wrote: > diff --git a/hw/tpm/tpm_ppi.c b/hw/tpm/tpm_ppi.c > index 362edcc5c9..fab49524d7 100644 > --- a/hw/tpm/tpm_ppi.c > +++ b/hw/tpm/tpm_ppi.c > @@ -30,11 +30,14 @@ void tpm_ppi_reset(TPMPPI *tpmppi) > guest_phys_blocks_init(&g

Re: [PATCH v2] nbd/server: Add --selinux-label option

2021-07-26 Thread Eric Blake
On Fri, Jul 23, 2021 at 11:47:51AM +0100, Daniel P. Berrangé wrote: > On Fri, Jul 23, 2021 at 11:33:03AM +0100, Richard W.M. Jones wrote: > > Under SELinux, Unix domain sockets have two labels. One is on the > > disk and can be set with commands such as chcon(1). There is a > > different label st

[PATCH for-6.1 00/10] docs: Format literals correctly in rST

2021-07-26 Thread Peter Maydell
In rST markup, single backticks `like this` represent "interpreted text", which can be handled as a bunch of different things if tagged with a specific "role": https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#interpreted-text (the most common one for us is "reference to a URL, whi

[PATCH for-6.1 02/10] docs/devel/build-system.rst: Correct typo in example code

2021-07-26 Thread Peter Maydell
One of the example meson.build fragments incorrectly quotes some symbols as 'CONFIG_FOO`; the correct syntax here is 'CONFIG_FOO'. (This isn't a rST formatting mistake because the example is displayed literally; it's just the wrong kind of quote.) Signed-off-by: Peter Maydell --- docs/devel/buil

[PATCH for-6.1 01/10] docs/devel/build-system.rst: Format literals correctly

2021-07-26 Thread Peter Maydell
In rST markup, single backticks `like this` represent "interpreted text", which can be handled as a bunch of different things if tagged with a specific "role": https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#interpreted-text (the most common one for us is "reference to a URL, whi

[PATCH for-6.1 04/10] docs/devel/migration.rst: Format literals correctly

2021-07-26 Thread Peter Maydell
In rST markup, single backticks `like this` represent "interpreted text", which can be handled as a bunch of different things if tagged with a specific "role": https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#interpreted-text (the most common one for us is "reference to a URL, whi

[PATCH for-6.1 06/10] docs/system/s390x/protvirt.rst: Format literals correctly

2021-07-26 Thread Peter Maydell
In rST markup, single backticks `like this` represent "interpreted text", which can be handled as a bunch of different things if tagged with a specific "role": https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#interpreted-text (the most common one for us is "reference to a URL, whi

[PATCH for-6.1 03/10] docs/devel/ebpf_rss.rst: Format literals correctly

2021-07-26 Thread Peter Maydell
In rST markup, single backticks `like this` represent "interpreted text", which can be handled as a bunch of different things if tagged with a specific "role": https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#interpreted-text (the most common one for us is "reference to a URL, whi

[PATCH for-6.1 08/10] docs: Format literals correctly

2021-07-26 Thread Peter Maydell
In rST markup, single backticks `like this` represent "interpreted text", which can be handled as a bunch of different things if tagged with a specific "role": https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#interpreted-text (the most common one for us is "reference to a URL, whi

[PATCH for-6.1 07/10] docs/system/arm/cpu-features.rst: Format literals correctly

2021-07-26 Thread Peter Maydell
In rST markup, single backticks `like this` represent "interpreted text", which can be handled as a bunch of different things if tagged with a specific "role": https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#interpreted-text (the most common one for us is "reference to a URL, whi

[PATCH for-6.1 09/10] docs/about/removed-features: Fix markup error

2021-07-26 Thread Peter Maydell
The section describing the removed feature "-usbdevice ccid" had a typo so the markup started with single backtick and ended with double backtick; fix it. Signed-off-by: Peter Maydell --- docs/about/removed-features.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/abo

[PATCH for-6.1 05/10] docs/devel: Format literals correctly

2021-07-26 Thread Peter Maydell
In rST markup, single backticks `like this` represent "interpreted text", which can be handled as a bunch of different things if tagged with a specific "role": https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#interpreted-text (the most common one for us is "reference to a URL, whi

[PATCH for-6.1 10/10] docs/tools/virtiofsd.rst: Delete stray backtick

2021-07-26 Thread Peter Maydell
The documentation of the posix_acl option has a stray backtick at the end of the text (which is rendered literally into the HTML). Delete it. Signed-off-by: Peter Maydell --- docs/tools/virtiofsd.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/tools/virtiofsd.rst b/d

Re: [PATCH for-6.1 06/10] docs/system/s390x/protvirt.rst: Format literals correctly

2021-07-26 Thread Cornelia Huck
On Mon, Jul 26 2021, Peter Maydell wrote: > In rST markup, single backticks `like this` represent "interpreted > text", which can be handled as a bunch of different things if tagged > with a specific "role": > https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#interpreted-text > (

Re: virtio-gpu: Mapping blob resources

2021-07-26 Thread Antonio Caggiano
On 26/07/21 10:19, Gerd Hoffmann wrote: On Fri, Jul 23, 2021 at 05:07:52PM +0200, Antonio Caggiano wrote: I added it to the gpu hostmem at the offset specified by the map command. I enabled the subregion, and then I used subregion->addr for the vkMapMemory call. Hmm, no. I'd suggest to first

  1   2   3   >