[PATCH v1 03/21] docs: add a section on the generalities of vhost-user

2021-07-14 Thread Alex Bennée
While we do mention some of this stuff in the various daemons and manuals the subtleties of the socket and memory sharing are sometimes missed. This document attempts to give some background on vhost-user daemons in general terms. Signed-off-by: Alex Bennée Cc: Stefan Hajnoczi --- v2 - drop r

[PATCH v1 01/21] gitignore: Update with some filetypes

2021-07-14 Thread Alex Bennée
From: Viresh Kumar Update .gitignore to ignore .swp and .patch files. Signed-off-by: Viresh Kumar Reviewed-by: Alex Bennée Message-Id: <79262dbe1f7888eb02e1911501eebafa6f2f6400.1616583806.git.viresh.ku...@linaro.org> Signed-off-by: Alex Bennée --- .gitignore | 2 ++ 1 file changed, 2 insert

[PATCH v1 13/21] contrib/gitdm: un-ironically add a mapping for LWN

2021-07-14 Thread Alex Bennée
I think this mainly comes from kernel-doc stuff imported into the QEMU tree. Signed-off-by: Alex Bennée Cc: Jonathan Corbet --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map index 27b8fbdf8a..5ac8288716 100644 --

[PATCH v1 20/21] contrib/gitdm: add a new interns group-map for GSoC/Outreachy work

2021-07-14 Thread Alex Bennée
It makes sense to put our various interns in a group so we can see the overall impact of GSoC and Outreachy on the project. Signed-off-by: Alex Bennée Cc: Ahmed Karaman Cc: Mahmoud Mandour Cc: César Belley --- contrib/gitdm/group-map-interns | 13 + gitdm.config

[PATCH v1 08/21] contrib/gitdm: add a group mapping for robot scanners

2021-07-14 Thread Alex Bennée
This mostly affects Reported-by: tags Signed-off-by: Alex Bennée --- contrib/gitdm/group-map-robots | 7 +++ gitdm.config | 3 +++ 2 files changed, 10 insertions(+) create mode 100644 contrib/gitdm/group-map-robots diff --git a/contrib/gitdm/group-map-robots b/contrib/git

[PATCH v1 06/21] .mailmap: fix up some broken commit authors

2021-07-14 Thread Alex Bennée
Fixes: 49a6f3bffb ("target/arm: Correct the encoding of MDCCSR_EL0 and DBGDSCRint") Fixes: 5a07192a04 ("target/i386: Fix handling of k_gs_base register in 32-bit mode in gdbstub") Signed-off-by: Alex Bennée Cc: Nick Hudson Cc: Marek Dolata --- .mailmap | 4 1 file changed, 4 insertions(+

Re: [PATCH] tests/acceptance: Add tests for the Pegasos2 machine

2021-07-14 Thread Philippe Mathieu-Daudé
Hi Cleber, On 7/13/21 3:43 AM, Cleber Rosa wrote: > From: Philippe Mathieu-Daudé > > Add a pair of tests for the Pegasos2 machine following the steps from: > https://lists.nongnu.org/archive/html/qemu-devel/2021-01/msg01553.html > > $ AVOCADO_ALLOW_UNTRUSTED_CODE=1 avocado --show=app,console,

[PATCH v1 10/21] contrib/gitdm: add domain-map/group-map mappings for Samsung

2021-07-14 Thread Alex Bennée
Minwoo is listed as a Samsung employee working on nvme so I'm assuming the QEMU contributions are work based. Signed-off-by: Alex Bennée Cc: Klaus Jensen Cc: Gollu Appalanaidu Cc: Minwoo Im --- contrib/gitdm/domain-map| 1 + contrib/gitdm/group-map-samsung | 5 + gitdm.config

[PATCH v1 13/21] contrib/gitdm: un-ironically add a mapping for LWN

2021-07-14 Thread Alex Bennée
I think this mainly comes from kernel-doc stuff imported into the QEMU tree. Signed-off-by: Alex Bennée Cc: Jonathan Corbet --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map index 27b8fbdf8a..5ac8288716 100644 --

[PATCH v1 07/21] contrib/gitdm: add domain-map for MontaVista

2021-07-14 Thread Alex Bennée
Signed-off-by: Alex Bennée Cc: Corey Minyard --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map index 0074da618f..efbbb15643 100644 --- a/contrib/gitdm/domain-map +++ b/contrib/gitdm/domain-map @@ -18,6 +18,7 @@ ig

[PATCH v1 05/21] contrib/gitdm: add some new aliases to fix up commits

2021-07-14 Thread Alex Bennée
Signed-off-by: Alex Bennée Cc: Yuval Shaia --- contrib/gitdm/aliases | 3 +++ 1 file changed, 3 insertions(+) diff --git a/contrib/gitdm/aliases b/contrib/gitdm/aliases index c1e744312f..c6ed215e68 100644 --- a/contrib/gitdm/aliases +++ b/contrib/gitdm/aliases @@ -31,6 +31,9 @@ pbrook@c046a42c-

Re: [PULL 0/4] OVMF patches for 2021-07-12

2021-07-14 Thread Philippe Mathieu-Daudé
On 7/13/21 1:16 PM, Daniel P. Berrangé wrote: > On Tue, Jul 13, 2021 at 11:25:21AM +0100, Peter Maydell wrote: >> On Mon, 12 Jul 2021 at 16:02, Philippe Mathieu-Daudé >> wrote: >>> >>> The following changes since commit bd38ae26cea0d1d6a97f930248df149204c210a2: >>> >>> Merge remote-tracking bra

[PATCH v1 17/21] contrib/gitdm: add domain-map for NVIDIA

2021-07-14 Thread Alex Bennée
Signed-off-by: Alex Bennée Cc: Kirti Wankhede Cc: Yishai Hadas --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map index 0b0cd9feee..329ff09029 100644 --- a/contrib/gitdm/domain-map +++ b/contrib/gitdm/domain-map @

[PATCH v1 11/21] contrib/gitdm: add domain-map for Eldorado

2021-07-14 Thread Alex Bennée
Signed-off-by: Alex Bennée Cc: Bruno Larsen (billionai) Cc: Luis Pires --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map index beeb24341e..41875c9e75 100644 --- a/contrib/gitdm/domain-map +++ b/contrib/gitdm/doma

[PATCH v1 11/21] contrib/gitdm: add domain-map for Eldorado

2021-07-14 Thread Alex Bennée
Signed-off-by: Alex Bennée Cc: Bruno Larsen (billionai) Cc: Luis Pires --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map index beeb24341e..41875c9e75 100644 --- a/contrib/gitdm/domain-map +++ b/contrib/gitdm/doma

Re: [PATCH v3 1/3] msix/hmp: add hmp interface to dump MSI-X info

2021-07-14 Thread Markus Armbruster
Dongli Zhang writes: > Hi Markus, > > On 7/13/21 10:46 PM, Markus Armbruster wrote: >> Dongli Zhang writes: >> >>> This patch is to add the HMP interface to dump MSI-X table and PBA, in >>> order to help diagnose the loss of IRQ issue in VM (e.g., if an MSI-X >>> vector is erroneously masked pe

[PATCH v1 12/21] contrib/gitdm: add domain-map/group-map for Wind River

2021-07-14 Thread Alex Bennée
I've created a group-map as well as some windriver contributions have come via non-corporate email. Let me know if you want the contributions split. Signed-off-by: Alex Bennée Cc: Bin Meng Cc: Ruimei Yan Cc: Xuzhou Cheng --- contrib/gitdm/domain-map | 1 + contrib/gitdm/group-map-win

Re: [RFC PATCH 0/6] Add AMD Secure Nested Paging (SEV-SNP) support

2021-07-14 Thread Dr. David Alan Gilbert
* Brijesh Singh (brijesh.si...@amd.com) wrote: > > > On 7/13/21 3:05 AM, Dov Murik wrote:> > > Particularly confusing is the `policy` attribute which is only relevant > > for SEV / SEV-ES, while there's a new `snp.policy` attribute for SNP... > > Maybe the irrelevant attributes should not be adde

[PATCH v1 17/21] contrib/gitdm: add domain-map for NVIDIA

2021-07-14 Thread Alex Bennée
Signed-off-by: Alex Bennée Cc: Kirti Wankhede Cc: Yishai Hadas --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map index 0b0cd9feee..329ff09029 100644 --- a/contrib/gitdm/domain-map +++ b/contrib/gitdm/domain-map @

[PATCH v1 16/21] contrib/gitdm: add domain-map for Syrmia

2021-07-14 Thread Alex Bennée
We have multiple engineers contributing from this domain. Signed-off-by: Alex Bennée Cc: Filip Bozuta Cc: Aleksandar Rikalo --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map index bada5384dd..0b0cd9feee 100644 -

[PATCH v1 14/21] contrib/gitdm: add domain-map for Crudebyte

2021-07-14 Thread Alex Bennée
Let me know if you want to be moved to individual contributor or you want to keep with the work domain mapping. Signed-off-by: Alex Bennée Cc: Christian Schoenebeck --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-m

[PATCH v1 18/21] contrib/gitdm: add group-map for Netflix

2021-07-14 Thread Alex Bennée
Warner confirmed he works for Netflix on IRC. Signed-off-by: Alex Bennée Cc: Warner Losh --- contrib/gitdm/group-map-netflix | 5 + gitdm.config| 1 + 2 files changed, 6 insertions(+) create mode 100644 contrib/gitdm/group-map-netflix diff --git a/contrib/gitdm/group-m

[PATCH v1 18/21] contrib/gitdm: add group-map for Netflix

2021-07-14 Thread Alex Bennée
Warner confirmed he works for Netflix on IRC. Signed-off-by: Alex Bennée Cc: Warner Losh --- contrib/gitdm/group-map-netflix | 5 + gitdm.config| 1 + 2 files changed, 6 insertions(+) create mode 100644 contrib/gitdm/group-map-netflix diff --git a/contrib/gitdm/group-m

[PATCH v1 09/21] gitdm.config: sort the corporate GroupMap entries

2021-07-14 Thread Alex Bennée
Lets try and keep them that way. Signed-off-by: Alex Bennée --- gitdm.config | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gitdm.config b/gitdm.config index 7378238c20..a3542d2fc7 100644 --- a/gitdm.config +++ b/gitdm.config @@ -28,15 +28,15 @@ EmailMap contrib/gitdm/

[PATCH v1 15/21] contrib/gitdm: add domain-map for ZTE

2021-07-14 Thread Alex Bennée
Signed-off-by: Alex Bennée Cc: Yi Wang Cc: Yun Liu --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map index e42861cd11..bada5384dd 100644 --- a/contrib/gitdm/domain-map +++ b/contrib/gitdm/domain-map @@ -40,3 +40,

[PATCH v1 14/21] contrib/gitdm: add domain-map for Crudebyte

2021-07-14 Thread Alex Bennée
Let me know if you want to be moved to individual contributor or you want to keep with the work domain mapping. Signed-off-by: Alex Bennée Cc: Christian Schoenebeck --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-m

Re: [PATCH v1 12/21] contrib/gitdm: add domain-map/group-map for Wind River

2021-07-14 Thread Bin Meng
Hi Alex, On Wed, Jul 14, 2021 at 5:59 PM Alex Bennée wrote: > > I've created a group-map as well as some windriver contributions have > come via non-corporate email. Let me know if you want the > contributions split. > > Signed-off-by: Alex Bennée > Cc: Bin Meng > Cc: Ruimei Yan > Cc: Xuzhou C

[PATCH v1 16/21] contrib/gitdm: add domain-map for Syrmia

2021-07-14 Thread Alex Bennée
We have multiple engineers contributing from this domain. Signed-off-by: Alex Bennée Cc: Filip Bozuta Cc: Aleksandar Rikalo --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map index bada5384dd..0b0cd9feee 100644 -

[PATCH v1 21/21] contrib/gitdm: add more individual contributor entries.

2021-07-14 Thread Alex Bennée
Again this is guess work based on public websites. - Chetan lists himself as a freelancer on twitter. - Akihiko lists themselves as an individual developer on GitHub - Jiaxun's website looks like a personal one [AJB: Won't merge without confirmation from appropriate people.] Signed-off-by: Al

Re: [PATCH v1 10/21] contrib/gitdm: add domain-map/group-map mappings for Samsung

2021-07-14 Thread Klaus Jensen
On Jul 14 10:37, Alex Bennée wrote: > Minwoo is listed as a Samsung employee working on nvme so I'm assuming > the QEMU contributions are work based. > Minwoos contributions are individual/hobby-based, otherwise we sign-off with @samsung.com (and use a From: line if submitting from a different ad

Re: [PATCH v3 1/3] tests/qtest/vhost-user-test: use share=on with memfd

2021-07-14 Thread Pankaj Gupta
> Add share=on for consistency and to prevent future bugs in the test. > > Note that share=on is the default for memory-backend-memfd so existing > tests work. > > Reviewed-by: Marc-André Lureau > Acked-by: Thomas Huth > Signed-off-by: Stefan Hajnoczi > --- > tests/qtest/vhost-user-test.c | 2 +

Re: [PATCH v3 2/3] memory: add memory_region_is_mapped_shared()

2021-07-14 Thread Pankaj Gupta
> Add a function to query whether a memory region is mmap(MAP_SHARED). > This will be used to check that vhost-user memory regions can be shared > with the device backend process in the next patch. > > An inline function in "exec/memory.h" would have been nice but RAMBlock > fields are only accessi

[PATCH for 6.1] tcg/plugins: remove some stale entries from the symbol list

2021-07-14 Thread Alex Bennée
The OSX linker is a lot fussier about these missing symbols. Signed-off-by: Alex Bennée --- plugins/qemu-plugins.symbols | 3 --- 1 file changed, 3 deletions(-) diff --git a/plugins/qemu-plugins.symbols b/plugins/qemu-plugins.symbols index 4bdb381f48..40b4ff3821 100644 --- a/plugins/qemu-plugin

[PATCH-for-6.1] gitlab-ci: Extract EDK2 job rules to reusable section

2021-07-14 Thread Philippe Mathieu-Daudé
All jobs depending on 'docker-edk2' job must use at most all the rules that triggers it. The simplest way to ensure that is to always use the same rules. Extract all the rules to a reusable section, and include this section (with the 'extends' keyword) in both 'docker-edk2' and 'build-edk2' jobs.

[PATCH for 6.1] meson.build: relax the libdl test to one for the function dlopen

2021-07-14 Thread Alex Bennée
For the *BSD family dlopen is already part of libc so it's not a hard dependency to have a libdl.so library. Signed-off-by: Alex Bennée --- meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index c6dd70c400..e5de144233 100644 --- a/meso

Re: [PATCH v1 1/1] vfio: Make migration support non experimental by default.

2021-07-14 Thread Kirti Wankhede
On 7/10/2021 1:14 PM, Claudio Fontana wrote: On 3/8/21 5:09 PM, Tarun Gupta wrote: VFIO migration support in QEMU is experimental as of now, which was done to provide soak time and resolve concerns regarding bit-stream. But, with the patches discussed in https://nam11.safelinks.protection.out

Re: [PATCH v1] migration: clear the memory region dirty bitmap when skipping free pages

2021-07-14 Thread Michael S. Tsirkin
On Wed, Jul 14, 2021 at 03:51:04AM -0400, Wei Wang wrote: > When skipping free pages, their corresponding dirty bits in the memory > region dirty bitmap need to be cleared. Otherwise the skipped pages will > be sent in the next round after the migration thread syncs dirty bits > from the memory reg

Re: [PATCH v1] migration: clear the memory region dirty bitmap when skipping free pages

2021-07-14 Thread David Hildenbrand
On 14.07.21 12:27, Michael S. Tsirkin wrote: On Wed, Jul 14, 2021 at 03:51:04AM -0400, Wei Wang wrote: When skipping free pages, their corresponding dirty bits in the memory region dirty bitmap need to be cleared. Otherwise the skipped pages will be sent in the next round after the migration thr

Re: [PATCH v2 00/35] acpi: refactor error prone build_header() and packed structures usage in ACPI tables

2021-07-14 Thread Michael S. Tsirkin
On Wed, Jul 14, 2021 at 10:53:59AM +0200, Igor Mammedov wrote: > On Tue, 13 Jul 2021 11:45:46 -0400 > "Michael S. Tsirkin" wrote: > > > On Thu, Jul 08, 2021 at 11:45:42AM -0400, Igor Mammedov wrote: > > > v2: > > > - drop test related patches, they will be sent as a separate series > > > - fi

Re: Host folder sharing via USB issue

2021-07-14 Thread Vladimir Sementsov-Ogievskiy
14.07.2021 00:04, Programmingkid wrote: Hi I have noticed that host folder sharing via USB has recently stopped working. After doing some git bisecting I found this as the patch that seems to be the issue: 25f78d9e2de528473d52acfcf7acdfb64e3453d4 is the first bad commit commit 25f78d9e2de52847

Re: [PATCH] tests/acceptance: Add tests for the Pegasos2 machine

2021-07-14 Thread BALATON Zoltan
On Wed, 14 Jul 2021, Philippe Mathieu-Daudé wrote: Hi Cleber, On 7/13/21 3:43 AM, Cleber Rosa wrote: From: Philippe Mathieu-Daudé Add a pair of tests for the Pegasos2 machine following the steps from: https://lists.nongnu.org/archive/html/qemu-devel/2021-01/msg01553.html $ AVOCADO_ALLOW_UN

Re: [PATCH] tests/acceptance: Add tests for the Pegasos2 machine

2021-07-14 Thread BALATON Zoltan
On Wed, 14 Jul 2021, Philippe Mathieu-Daudé wrote: Hi Cleber, On 7/13/21 3:43 AM, Cleber Rosa wrote: From: Philippe Mathieu-Daudé Add a pair of tests for the Pegasos2 machine following the steps from: https://lists.nongnu.org/archive/html/qemu-devel/2021-01/msg01553.html $ AVOCADO_ALLOW_UN

Re: [PATCH v1 14/21] contrib/gitdm: add domain-map for Crudebyte

2021-07-14 Thread Christian Schoenebeck
On Mittwoch, 14. Juli 2021 11:36:31 CEST Alex Bennée wrote: > Let me know if you want to be moved to individual contributor or you > want to keep with the work domain mapping. > > Signed-off-by: Alex Bennée > Cc: Christian Schoenebeck > --- > contrib/gitdm/domain-map | 1 + > 1 file changed, 1

Re: [PATCH] configure / meson: Move the GBM handling to meson.build

2021-07-14 Thread Paolo Bonzini
On 13/07/21 13:15, Thomas Huth wrote: +if virgl.found() or 'CONFIG_OPENGL' in config_host + gbm = dependency('gbm', method: 'pkg-config', kwargs: static_kwargs) +endif gnutls = not_found Tweaked to add "required: false". Paolo

Re: Host folder sharing via USB issue

2021-07-14 Thread BALATON Zoltan
On Wed, 14 Jul 2021, Vladimir Sementsov-Ogievskiy wrote: 14.07.2021 00:04, Programmingkid wrote: Hi I have noticed that host folder sharing via USB has recently stopped working. After doing some git bisecting I found this as the patch that seems to be the issue: 25f78d9e2de528473d52acfcf7acdf

Re: [PULL 0/6] migration queue

2021-07-14 Thread Peter Maydell
On Tue, 13 Jul 2021 at 16:25, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > The following changes since commit 708f50199b59476ec4b45ebcdf171550086d6292: > > Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2021-07-09-v2' > into staging (2021-07-13 14:32:20

Re: [PATCH for 6.1] meson.build: relax the libdl test to one for the function dlopen

2021-07-14 Thread Paolo Bonzini
> - libdl = cc.find_library('dl', required: true) > + libdl = cc.find_library('dl', required: false) > + if not cc.has_function('dlopen', dependencies: libdl) > +error('dlopen not found') > + endif Reviewed-by: Paolo Bonzini

[PATCH v1 0/3] util/oslib-posix: Support MADV_POPULATE_WRITE for os_mem_prealloc()

2021-07-14 Thread David Hildenbrand
#1 adds support for MADV_POPULATE_WRITE, #2 cleans up the code to avoid global variables and prepare for concurrency and #3 makes os_mem_prealloc() safe to be called from multiple threads concurrently. Details regarding MADV_POPULATE_WRITE can be found in introducing upstream Linux commit 4ca9b385

[PATCH v1 2/3] util/oslib-posix: Introduce and use MemsetContext for touch_all_pages()

2021-07-14 Thread David Hildenbrand
Let's minimize the number of global variables to prepare for os_mem_prealloc() getting called concurrently and make the code a bit easier to read. The only consumer that really needs a global variable is the sigbus handler, which will require protection via a mutex in the future either way as we c

[PATCH v1 3/3] util/oslib-posix: Support concurrent os_mem_prealloc() invocation

2021-07-14 Thread David Hildenbrand
Add a mutext to protect the SIGBUS case, as we cannot mess concurrently with the sigbus handler and we have to manage the global variable sigbus_memset_context. The MADV_POPULATE_WRITE path can run concurrently. Note that page_mutex and page_cond are shared between concurrent invocations, which sh

[PATCH v1 1/3] util/oslib-posix: Support MADV_POPULATE_WRITE for os_mem_prealloc()

2021-07-14 Thread David Hildenbrand
Let's sense support and use it for preallocation. MADV_POPULATE_WRITE does not require a SIGBUS handler, doesn't actually touch page content, and avoids context switches; it is, therefore, faster and easier to handle than our current approach. This resolves the TODO in do_touch_pages(). Signed-of

Re: [PATCH v3 2/4] target/ppc: divided mmu_helper.c in 2 files

2021-07-14 Thread Lucas Mateus Martins Araujo e Castro
On 08/07/2021 15:09, Richard Henderson wrote: On 7/8/21 9:49 AM, Lucas Mateus Castro (alqotel) wrote: +++ b/target/ppc/cpu.h @@ -1327,6 +1327,26 @@ void store_40x_dbcr0(CPUPPCState *env, uint32_t val);   void store_40x_sler(CPUPPCState *env, uint32_t val);   void store_booke_tcr(CPUPPCState

Re: [PATCH v1 21/21] contrib/gitdm: add more individual contributor entries.

2021-07-14 Thread Akihiko Odaki
I am Akihiko Odaki and an individual developer. Regards, Akihiko Odaki On Wed, Jul 14, 2021 at 7:06 PM Alex Bennée wrote: > > Again this is guess work based on public websites. > > - Chetan lists himself as a freelancer on twitter. > - Akihiko lists themselves as an individual developer on Gi

Re: [PATCH v3 5/5] tests/qtest/nvme-test: add mmio read test

2021-07-14 Thread Gollu Appalanaidu
On Wed, Jul 14, 2021 at 08:01:25AM +0200, Klaus Jensen wrote: From: Klaus Jensen Add a regression test for mmio read on big-endian hosts. Signed-off-by: Klaus Jensen --- tests/qtest/nvme-test.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/tests/qtest/nvme-tes

Re: [PATCH v3 1/5] hw/nvme: split pmrmsc register into upper and lower

2021-07-14 Thread Gollu Appalanaidu
On Wed, Jul 14, 2021 at 08:01:21AM +0200, Klaus Jensen wrote: From: Klaus Jensen The specification uses a set of 32 bit PMRMSCL and PMRMSCU registers to make up the 64 bit logical PMRMSC register. Make it so. Signed-off-by: Klaus Jensen --- include/block/nvme.h | 31 -

Re: [PATCH v3 2/5] hw/nvme: use symbolic names for registers

2021-07-14 Thread Gollu Appalanaidu
On Wed, Jul 14, 2021 at 08:01:22AM +0200, Klaus Jensen wrote: From: Klaus Jensen Add the NvmeBarRegs enum and use these instead of explicit register offsets. Signed-off-by: Klaus Jensen --- include/block/nvme.h | 29 - hw/nvme/ctrl.c | 44 +

Re: [PATCH-for-6.1] gitlab-ci: Extract EDK2 job rules to reusable section

2021-07-14 Thread Daniel P . Berrangé
On Wed, Jul 14, 2021 at 12:10:03PM +0200, Philippe Mathieu-Daudé wrote: > All jobs depending on 'docker-edk2' job must use at most all > the rules that triggers it. The simplest way to ensure that > is to always use the same rules. Extract all the rules to a > reusable section, and include this sec

Re: [PATCH 1/2] Hexagon (target/hexagon) do probe_write in HELPER(commit_store)

2021-07-14 Thread Richard Henderson
On 7/13/21 12:46 PM, Taylor Simpson wrote: void HELPER(commit_store)(CPUHexagonState *env, int slot_num) { -switch (env->mem_log_stores[slot_num].width) { +uint8_t width = env->mem_log_stores[slot_num].width; +target_ulong va = env->mem_log_stores[slot_num].va; + +#ifdef CONFIG_US

Re: [PATCH 2/2] linux-test (tests/tcg/multiarch/linux-test.c) add check

2021-07-14 Thread Richard Henderson
On 7/13/21 12:46 PM, Taylor Simpson wrote: Add a check that the SIGSEGV handler is called Signed-off-by: Taylor Simpson --- tests/tcg/multiarch/linux-test.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/tcg/multiarch/linux-test.c b/tests/tcg/multiarch/linux-test.c index c8

Re: [PULL 00/11] x86 queue, 2021-07-13

2021-07-14 Thread Peter Maydell
On Tue, 13 Jul 2021 at 17:19, Eduardo Habkost wrote: > > Sorry for submitting this so late. I had to deal with build > issues caused by other patches (now removed from the queue). > > The following changes since commit eca73713358f7abb18f15c026ff4267b51746992: > > Merge remote-tracking branch '

[Bug 1906536] Re: Unable to set SVE VL to 1024 bits or above since 7b6a2198

2021-07-14 Thread Peter Maydell
Whoops, this shouldn't have got expired. ** Changed in: qemu Status: Expired => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1906536 Title: Unable to set SVE VL to 1024 bits or above

Re: [PATCH 0/3] Fix active mirror dead-lock

2021-07-14 Thread Kevin Wolf
Am 02.07.2021 um 23:16 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all! > > We've faced a dead-lock in active mirror in our Rhev-8.4 based Qemu > build. And it's reproducible on master too. Thanks, applied to the block branch. Kevin

[PULL v2 00/26] Crypto and more patches

2021-07-14 Thread Daniel P . Berrangé
The following changes since commit 4aa2454d94cca99d86aa32e71bd7c8159df91c59: Merge remote-tracking branch 'remotes/ehabkost-gl/tags/x86-next-pull-request' into staging (2021-07-14 12:00:56 +0100) are available in the Git repository at: https://gitlab.com/berrange/qemu tags/crypto-and-more-p

[PULL 02/26] crypto: remove obsolete crypto test condition

2021-07-14 Thread Daniel P . Berrangé
Since we now require gcrypt >= 1.8.0, there is no need to exclude the pbkdf test case. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé --- tests/unit/test-crypto-pbkdf.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tests/unit/test-crypto-pbkdf.c b/tests/unit

[PULL 01/26] crypto: remove conditional around 3DES crypto test cases

2021-07-14 Thread Daniel P . Berrangé
The main method checks whether the cipher choice is supported at runtime, so there is no need for compile time conditions. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé --- tests/unit/test-crypto-cipher.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/unit/test-crypto-ci

[PULL 07/26] crypto: drop custom XTS support in gcrypt driver

2021-07-14 Thread Daniel P . Berrangé
The XTS cipher mode was introduced in gcrypt 1.8.0, which matches QEMU's current minimum version. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé --- crypto/cipher-gcrypt.c.inc | 127 - meson.build| 14 +--- 2 files changed, 1 inser

[PULL 05/26] crypto: fix gcrypt min version 1.8 regression

2021-07-14 Thread Daniel P . Berrangé
The min gcrypt was bumped: commit b33a84632a3759c00320fd80923aa963c11207fc Author: Daniel P. Berrangé Date: Fri May 14 13:04:08 2021 +0100 crypto: bump min gcrypt to 1.8.0, dropping RHEL-7 support but this was accidentally lost in conflict resolution for commit 5761251138cb69c310

[PULL 03/26] crypto: skip essiv ivgen tests if AES+ECB isn't available

2021-07-14 Thread Daniel P . Berrangé
Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé --- tests/unit/test-crypto-ivgen.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/tests/unit/test-crypto-ivgen.c b/tests/unit/test-crypto-ivgen.c index f581e6aba7..29630ed348 100644 --- a/tests/unit/tes

[PULL 08/26] crypto: add crypto tests for single block DES-ECB and DES-CBC

2021-07-14 Thread Daniel P . Berrangé
The GNUTLS crypto provider doesn't support DES-ECB, only DES-CBC. We can use the latter to simulate the former, if we encrypt only 1 block (8 bytes) of data at a time, using an all-zeros IV. This is a very inefficient way to use the QCryptoCipher APIs, but since the VNC authentication challenge is

Re: [PATCH v1 21/21] contrib/gitdm: add more individual contributor entries.

2021-07-14 Thread Chetan
Hello, I'm also an individual contributor. Regards, cp On Wed, Jul 14, 2021 at 5:05 PM Akihiko Odaki wrote: > I am Akihiko Odaki and an individual developer. > > Regards, > Akihiko Odaki > > On Wed, Jul 14, 2021 at 7:06 PM Alex Bennée > wrote: > > > > Again this is guess work based on publi

[PULL 10/26] crypto: delete built-in XTS cipher mode support

2021-07-14 Thread Daniel P . Berrangé
The built-in AES+XTS implementation is used for the LUKS encryption When building system emulators it is reasonable to expect that an external crypto library is being used instead. The performance of the builtin XTS implementation is terrible as it has no CPU acceleration support. It is thus not wo

[PULL 12/26] crypto: flip priority of backends to prefer gcrypt

2021-07-14 Thread Daniel P . Berrangé
Originally we preferred to use nettle over gcrypt because gnutls already links to nettle and thus it minimizes the dependencies. In retrospect this was the wrong criteria to optimize for. Currently shipping versions of gcrypt have cipher impls that are massively faster than those in nettle and thi

[PULL 11/26] crypto: replace 'des-rfb' cipher with 'des'

2021-07-14 Thread Daniel P . Berrangé
Currently the crypto layer exposes support for a 'des-rfb' algorithm which is just normal single-DES, with the bits in each key byte reversed. This special key munging is required by the RFB protocol password authentication mechanism. Since the crypto layer is generic shared code, it makes more se

[PULL 04/26] crypto: use &error_fatal in crypto tests

2021-07-14 Thread Daniel P . Berrangé
Using error_fatal provides better diagnostics when tests failed, than using asserts, because we see the text of the error message. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé --- tests/unit/test-crypto-hash.c | 13 +++-- tests/unit/test-crypto-hmac.c | 28 -

[PULL 17/26] crypto: add gnutls pbkdf provider

2021-07-14 Thread Daniel P . Berrangé
This adds support for using gnutls as a provider of the crypto pbkdf APIs. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé --- crypto/meson.build| 2 +- crypto/pbkdf-gnutls.c | 90 +++ 2 files changed, 91 insertions(+), 1 deletion(-) creat

[PULL 13/26] crypto: introduce build system for gnutls crypto backend

2021-07-14 Thread Daniel P . Berrangé
This introduces the build logic needed to decide whether we can use gnutls as a crypto driver backend. The actual implementations will be introduced in following patches. We only wish to use gnutls if it has version 3.6.14 or newer, because that is what finally brings HW accelerated AES-XTS mode fo

[PULL 14/26] crypto: add gnutls cipher provider

2021-07-14 Thread Daniel P . Berrangé
Add an implementation of the QEMU cipher APIs to the gnutls crypto backend. XTS support is only available for gnutls version >= 3.6.8. Since ECB mode is not exposed by gnutls APIs, we can't use the private XTS code for compatibility. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé ---

[PULL 06/26] crypto: drop gcrypt thread initialization code

2021-07-14 Thread Daniel P . Berrangé
This is only required on gcrypt < 1.6.0, and is thus obsolete since commit b33a84632a3759c00320fd80923aa963c11207fc Author: Daniel P. Berrangé Date: Fri May 14 13:04:08 2021 +0100 crypto: bump min gcrypt to 1.8.0, dropping RHEL-7 support Reviewed-by: Eric Blake Signed-off-by: Danie

[PULL 18/26] crypto: prefer gnutls as the crypto backend if new enough

2021-07-14 Thread Daniel P . Berrangé
If we have gnutls >= 3.6.13, then it has enough functionality and performance that we can use it as the preferred crypto backend. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé --- meson.build | 59 +++-- 1 file changed, 35 insertions(+

[PULL 15/26] crypto: add gnutls hash provider

2021-07-14 Thread Daniel P . Berrangé
This adds support for using gnutls as a provider of the crypto hash APIs. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé --- crypto/hash-gnutls.c | 104 +++ crypto/meson.build | 2 + 2 files changed, 106 insertions(+) create mode 100644 cr

[PULL 09/26] crypto: delete built-in DES implementation

2021-07-14 Thread Daniel P . Berrangé
The built-in DES implementation is used for the VNC server password authentication scheme. When building system emulators it is reasonable to expect that an external crypto library is being used. It is thus not worth keeping a home grown DES implementation in tree. Reviewed-by: Eric Blake Signed-

[PULL 21/26] seccomp: don't block getters for resource control syscalls

2021-07-14 Thread Daniel P . Berrangé
Recent GLibC calls sched_getaffinity in code paths related to malloc and when QEMU blocks access, it sends it off into a bad codepath resulting in stack exhaustion[1]. The GLibC bug is being fixed[2], but none the less, GLibC has valid reasons to want to use sched_getaffinity. It is not unreasonab

[PULL 19/26] net/rocker: use GDateTime for formatting timestamp in debug messages

2021-07-14 Thread Daniel P . Berrangé
The GDateTime APIs provided by GLib avoid portability pitfalls, such as some platforms where 'struct timeval.tv_sec' field is still 'long' instead of 'time_t'. When combined with automatic cleanup, GDateTime often results in simpler code too. Reviewed-by: Juan Quintela Signed-off-by: Daniel P. Be

[PULL 20/26] io: use GDateTime for formatting timestamp for websock headers

2021-07-14 Thread Daniel P . Berrangé
The GDateTime APIs provided by GLib avoid portability pitfalls, such as some platforms where 'struct timeval.tv_sec' field is still 'long' instead of 'time_t'. When combined with automatic cleanup, GDateTime often results in simpler code too. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Dan

[PULL 16/26] crypto: add gnutls hmac provider

2021-07-14 Thread Daniel P . Berrangé
This adds support for using gnutls as a provider of the crypto hmac APIs. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé --- crypto/hmac-gnutls.c | 139 +++ 1 file changed, 139 insertions(+) create mode 100644 crypto/hmac-gnutls.c diff --git

[PULL 24/26] qemu-options: re-arrange CPU topology options

2021-07-14 Thread Daniel P . Berrangé
The list of CPU topology options are presented in a fairly arbitrary order currently. Re-arrange them so that they're ordered from largest to smallest unit Reviewed-by: Pankaj Gupta Reviewed-by: Andrew Jones Reviewed-by: Yanan Wang Signed-off-by: Daniel P. Berrangé --- qemu-options.hx | 12 ++

[PULL 26/26] qemu-options: rewrite help for -smp options

2021-07-14 Thread Daniel P . Berrangé
The -smp option help is peculiarly specific about mentioning the CPU upper limits, but these are wrong. The "PC" target has varying max CPU counts depending on the machine type picked. Notes about guest OS limits are inappropriate for QEMU docs. There are way too many machine types for it to be pra

[PULL 22/26] tests/migration: fix unix socket migration

2021-07-14 Thread Daniel P . Berrangé
From: Hyman The test aborts and error message as the following be throwed: "No such file or directory: '/var/tmp/qemu-migrate-{pid}.migrate", when the unix socket migration test nearly done. The reason is qemu removes the unix socket file after migration before guestperf.py script do it. So pre-c

[PULL 25/26] qemu-options: tweak to show that CPU count is optional

2021-07-14 Thread Daniel P . Berrangé
The initial CPU count number is not required, if any of the topology options are given, since it can be computed. Reviewed-by: Pankaj Gupta Reviewed-by: Andrew Jones Reviewed-by: Yanan Wang Signed-off-by: Daniel P. Berrangé --- qemu-options.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 dele

[PULL 23/26] docs: fix typo s/Intel/AMD/ in CPU model notes

2021-07-14 Thread Daniel P . Berrangé
Reviewed-by: Pankaj Gupta Reviewed-by: Andrew Jones Reviewed-by: Yanan Wang Signed-off-by: Daniel P. Berrangé --- docs/system/cpu-models-x86.rst.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system/cpu-models-x86.rst.inc b/docs/system/cpu-models-x86.rst.inc inde

Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP

2021-07-14 Thread Brijesh Singh
On 7/13/21 8:46 AM, Markus Armbruster wrote: > Brijesh Singh writes: > >> To launch the SEV-SNP guest, a user can specify up to 8 parameters. >> Passing all parameters through command line can be difficult. To simplify >> the launch parameter passing, introduce a .ini-like config file that can b

Re: [RFC PATCH 0/6] Add AMD Secure Nested Paging (SEV-SNP) support

2021-07-14 Thread Brijesh Singh
On 7/14/21 4:52 AM, Dr. David Alan Gilbert wrote: > * Brijesh Singh (brijesh.si...@amd.com) wrote: >> >> On 7/13/21 3:05 AM, Dov Murik wrote:> >>> Particularly confusing is the `policy` attribute which is only relevant >>> for SEV / SEV-ES, while there's a new `snp.policy` attribute for SNP... >>

Re: License advice for Async QMP

2021-07-14 Thread Markus Armbruster
John Snow writes: > Hi, > > I'm deep into writing a new Async QMP library for QEMU, one that I intend > to ship outside of our castle walls and host on PyPI. > > I need to choose a license for it. I slapped GPLv2 on it in keeping with > the license on the original library by Luiz Capitulino (And

[Bug 1906536] Re: Unable to set SVE VL to 1024 bits or above since 7b6a2198

2021-07-14 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/482 ** Changed in: qemu Status: New => Expired ** Bug watch

Re: [PATCH] tests/acceptance: Add tests for the Pegasos2 machine

2021-07-14 Thread Stefan Hajnoczi
On Wed, Jul 14, 2021 at 11:37:54AM +0200, Philippe Mathieu-Daudé wrote: > On 7/13/21 3:43 AM, Cleber Rosa wrote: > > +@skipUnless(os.getenv('AVOCADO_ALLOW_UNTRUSTED_CODE'), 'untrusted code') > > +class PPCPegasos2(Test): > > +"""These tests require a Pegasos2 ROM. You need to perform a one > >

Re: License advice for Async QMP

2021-07-14 Thread Daniel P . Berrangé
On Wed, Jul 14, 2021 at 04:35:17PM +0200, Markus Armbruster wrote: > John Snow writes: > > > Hi, > > > > I'm deep into writing a new Async QMP library for QEMU, one that I intend > > to ship outside of our castle walls and host on PyPI. > > > > I need to choose a license for it. I slapped GPLv2 o

Re: [PATCH v1 18/21] contrib/gitdm: add group-map for Netflix

2021-07-14 Thread Warner Losh
On Wed, Jul 14, 2021 at 3:43 AM Alex Bennée wrote: > Warner confirmed he works for Netflix on IRC. > > Signed-off-by: Alex Bennée > Cc: Warner Losh > --- > contrib/gitdm/group-map-netflix | 5 + > gitdm.config| 1 + > 2 files changed, 6 insertions(+) > create mode 1006

Re: [PATCH v3 0/9] tests: Add test cases for TPM 1.2 ACPI tables

2021-07-14 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > +Markus > > On 7/12/21 5:47 PM, Stefan Berger wrote: >> >> On 7/12/21 11:29 AM, Philippe Mathieu-Daudé wrote: >>> Hi Stefan, >>> >>> On 7/12/21 5:09 PM, Stefan Berger wrote: This series of patches adds test case for TPM 1.2 ACPI tables.    Stefan >

Re: [PATCH v3 RESEND 1/2] qmp: Support chardev-change

2021-07-14 Thread Li Zhang
Ping On Fri, Jul 9, 2021 at 6:11 PM Li Zhang wrote: > > For some scenarios, we'd like to hot-add a monitor device. But QEMU > doesn't support that, yet. It does support hot-swapping character > backends with QMP command chardev-change. This lets us pre-add a > monitor with a null character bac

Re: [PATCH] configure: Drop obsolete check for the alloc_size attribute

2021-07-14 Thread Paolo Bonzini
On 14/07/21 09:28, Thomas Huth wrote: We recently bumped our requirement for Clang to at least version 6.0. And according to: https://releases.llvm.org/6.0.0/tools/clang/docs/AttributeReference.html Clang v6.0 supports the alloc_size attribute. Thus we can drop this check in the configure scr

  1   2   3   4   >