[PATCH] MAINTAINERS: remove Laszlo Ersek's entries

2021-07-08 Thread Laszlo Ersek
I've relinquished my edk2 roles with the following commit message [1] [2] [3]: > Maintainers.txt: remove Laszlo Ersek's entries > > I'm relinquishing all my roles listed in "Maintainers.txt", for personal > reasons. > > My email address remains functional. > > To my understanding, my employer is

Re: [PATCH v1 2/2] virtio-balloon: disallow postcopy with VIRTIO_BALLOON_F_FREE_PAGE_HINT

2021-07-08 Thread David Hildenbrand
On 08.07.21 00:40, Peter Xu wrote: On Wed, Jul 07, 2021 at 02:22:32PM -0700, Alexander Duyck wrote: On Wed, Jul 7, 2021 at 1:08 PM Peter Xu wrote: On Wed, Jul 07, 2021 at 08:57:29PM +0200, David Hildenbrand wrote: On 07.07.21 20:02, Peter Xu wrote: On Wed, Jul 07, 2021 at 04:06:55PM +0200,

[PATCH] remote/memory: Replace share parameter with ram_flags

2021-07-08 Thread Yang Zhong
The commit(d5015b80) missed the ram_flags to memory_region_init_ram_from_fd() in the hw/remote/memory.c. Signed-off-by: Yang Zhong --- hw/remote/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/remote/memory.c b/hw/remote/memory.c index 472ed2a272..6e21ab1a45 10064

Re: [PATCH v1 2/2] virtio-balloon: disallow postcopy with VIRTIO_BALLOON_F_FREE_PAGE_HINT

2021-07-08 Thread David Hildenbrand
On 07.07.21 23:22, Alexander Duyck wrote: On Wed, Jul 7, 2021 at 1:08 PM Peter Xu wrote: On Wed, Jul 07, 2021 at 08:57:29PM +0200, David Hildenbrand wrote: On 07.07.21 20:02, Peter Xu wrote: On Wed, Jul 07, 2021 at 04:06:55PM +0200, David Hildenbrand wrote: As it never worked properly, let'

Re: [PATCH v0] vhost: make SET_VRING_ADDR, SET_[PROTOCOL_]FEATEURES send replies

2021-07-08 Thread Denis Plotnikov
On 07.07.2021 21:44, Michael S. Tsirkin wrote: On Wed, Jul 07, 2021 at 05:58:50PM +0300, Denis Plotnikov wrote: On 07.07.2021 17:39, Michael S. Tsirkin wrote: On Wed, Jul 07, 2021 at 03:19:20PM +0300, Denis Plotnikov wrote: On 07.07.2021 13:10, Michael S. Tsirkin wrote: On Fri, Jun 25, 2021

Re: [PATCH] remote/memory: Replace share parameter with ram_flags

2021-07-08 Thread David Hildenbrand
On 08.07.21 09:12, Yang Zhong wrote: The commit(d5015b80) missed the ram_flags to memory_region_init_ram_from_fd() in the hw/remote/memory.c. Yes, seems like that call was added just after I crafted my patches: Fixes: d5015b801340 ("softmmu/memory: Pass ram_flags to qemu_ram_alloc_from_fd()")

Re: [RFC PATCH 8/8] target/i386: Move X86XSaveArea into TCG

2021-07-08 Thread David Edmondson
On Wednesday, 2021-07-07 at 11:10:21 +01, David Edmondson wrote: > On Tuesday, 2021-07-06 at 18:09:42 -07, Richard Henderson wrote: > >> On 7/5/21 3:46 AM, David Edmondson wrote: >>> Given that TCG is now the only consumer of X86XSaveArea, move the >>> structure definition and associated offset de

Re: [PATCH] remote/memory: Replace share parameter with ram_flags

2021-07-08 Thread Yang Zhong
On Thu, Jul 08, 2021 at 09:26:17AM +0200, David Hildenbrand wrote: > On 08.07.21 09:12, Yang Zhong wrote: > >The commit(d5015b80) missed the ram_flags to memory_region_init_ram_from_fd() > >in the hw/remote/memory.c. > > Yes, seems like that call was added just after I crafted my patches: > > Fix

Re: [PATCH v3 3/2] qemu-img: Reword 'qemu-img map --output=json' docs

2021-07-08 Thread Vladimir Sementsov-Ogievskiy
07.07.2021 21:41, Eric Blake wrote: Reword the paragraphs to list the JSON key first, rather than in the middle of prose. Suggested-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH] MAINTAINERS: remove Laszlo Ersek's entries

2021-07-08 Thread Philippe Mathieu-Daudé
On 7/8/21 9:14 AM, Laszlo Ersek wrote: > I've relinquished my edk2 roles with the following commit message [1] [2] > [3]: > >> Maintainers.txt: remove Laszlo Ersek's entries >> >> I'm relinquishing all my roles listed in "Maintainers.txt", for personal >> reasons. Thank you Laszlo for your contri

Re: [PATCH v8 2/3] target/i386: Split out do_fninit

2021-07-08 Thread Philippe Mathieu-Daudé
On 7/8/21 12:24 AM, Richard Henderson wrote: > Do not call helper_fninit directly from helper_xrstor. > Do call the new helper from do_fsave. > > Signed-off-by: Richard Henderson > --- > target/i386/tcg/fpu_helper.c | 22 -- > 1 file changed, 8 insertions(+), 14 deletions(-)

Re: [PATCH v1 2/2] virtio-balloon: disallow postcopy with VIRTIO_BALLOON_F_FREE_PAGE_HINT

2021-07-08 Thread David Hildenbrand
On 07.07.21 21:57, Michael S. Tsirkin wrote: On Wed, Jul 07, 2021 at 09:47:31PM +0200, David Hildenbrand wrote: On 07.07.21 21:19, Michael S. Tsirkin wrote: On Wed, Jul 07, 2021 at 09:14:00PM +0200, David Hildenbrand wrote: On 07.07.21 21:05, Michael S. Tsirkin wrote: On Wed, Jul 07, 2021 at

[PATCH v1] vhost: make SET_VRING_ADDR, SET_FEATURES send replies

2021-07-08 Thread Denis Plotnikov
On vhost-user-blk migration, qemu normally sends a number of commands to enable logging if VHOST_USER_PROTOCOL_F_LOG_SHMFD is negotiated. Qemu sends VHOST_USER_SET_FEATURES to enable buffers logging and VHOST_USER_SET_VRING_ADDR per each started ring to enable "used ring" data logging. The issue is

Re: [PATCH 05/12] linux-user: Extract target errno to 'target_errno_defs.h'

2021-07-08 Thread Philippe Mathieu-Daudé
On 7/7/21 3:53 AM, Richard Henderson wrote: > On 7/4/21 11:37 AM, Philippe Mathieu-Daudé wrote: >> We want to access the target errno indepently of the rest >> of the linux-user code. Extract it to a new target-specific >> header: 'target_errno_defs.h'. >> >> Signed-off-by: Philippe Mathieu-Daudé

Re: [PATCH 1/4] dp8393x: don't force 32-bit register access

2021-07-08 Thread Mark Cave-Ayland
On 08/07/2021 01:52, Finn Thain wrote: On Wed, 7 Jul 2021, Mark Cave-Ayland wrote: However this conflicts with what you mention above that the SONIC is hard-coded into little-endian mode, in which case we would still need to keep it. If you want to fully implement BMODE in QEMU then you'll

Re: [PATCH v5 1/4] avocado_qemu: Fix KNOWN_DISTROS map into the LinuxDistro class

2021-07-08 Thread Eric Auger
Hi Wainer, William, Cleber, On 7/8/21 3:17 AM, Cleber Rosa wrote: > > On 7/6/21 9:17 AM, Eric Auger wrote: >> From: Willian Rampazzo >> >> As the KNOWN_DISTROS grows, more loosely methods will be created in >> the avocado_qemu/__init__.py file. >> >> Let's refactor the code so that KNOWN_DISTROS

Re: Picture missing in About dialog on cocoa ui

2021-07-08 Thread Peter Maydell
On Thu, 8 Jul 2021 at 06:38, Akihiko Odaki wrote: > > Hi, > > My installation correctly shows the picture. Please make sure you > install it and run the installed binary (not the binary located in the > build directory). The new code should work reliably once you install > it while the old code ma

Re: [PATCH] docs: Add '-device intel-iommu' entry

2021-07-08 Thread Eric Auger
Hi Peter, On 7/7/21 5:35 PM, Peter Xu wrote: > On Wed, Jul 07, 2021 at 11:29:47AM +0200, Eric Auger wrote: >> Hi Peter, > > Hi, Eric, > >> >> On 6/11/21 8:55 PM, Peter Xu wrote: >>> The parameters of intel-iommu device are non-trivial to understand. Add an >>> entry for it so that people can ref

Re: [PATCH] ui/cocoa: Do not perform unsafe cast of argv

2021-07-08 Thread Peter Maydell
On Thu, 8 Jul 2021 at 06:46, Akihiko Odaki wrote: > > Signed-off-by: Akihiko Odaki > --- > ui/cocoa.m | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ui/cocoa.m b/ui/cocoa.m > index 9f72844b079..68a6302184a 100644 > --- a/ui/cocoa.m > +++ b/ui/cocoa.m > @@ -1888,12 +

Re: [PATCH] vl: fix leak of qdict_crumple return value

2021-07-08 Thread Markus Armbruster
Paolo Bonzini writes: > Coverity reports that qemu_parse_config_group is returning without > unrefing the "crumpled" dictionary in case its top level item is a > list. But actually the contract with qemu_record_config_group is > the same as for qemu_parse_config_group itself: if those function >

Re: [PATCH REBASED v5 1/2] spapr: nvdimm: Implement H_SCM_FLUSH hcall

2021-07-08 Thread David Gibson
On Wed, Jul 07, 2021 at 09:57:21PM -0500, Shivaprasad G Bhat wrote: > The patch adds support for the SCM flush hcall for the nvdimm devices. > To be available for exploitation by guest through the next patch. > > The hcall expects the semantics such that the flush to return > with one of H_LONG_BU

Re: [PATCH 04/53] tests: acpi: q35: test for x2APIC entries in SRAT

2021-07-08 Thread Igor Mammedov
On Fri, 2 Jul 2021 10:45:37 -0400 "Michael S. Tsirkin" wrote: > On Fri, Jun 25, 2021 at 05:17:28AM -0400, Igor Mammedov wrote: > > Set -smp 1,maxcpus=288 to test for ACPI code that > > deal with CPUs with large APIC ID (>255). > > > > PS: > > Test requires KVM and in-kernel irqchip support, > >

Re: [PATCH v1 2/2] docs: add a section on the generalities of vhost-user

2021-07-08 Thread Stefan Hajnoczi
On Wed, Jul 07, 2021 at 07:45:49PM +0100, Alex Bennée wrote: > While we do mention some of this stuff in the various daemons and > manuals the subtleties of the socket and memory sharing are sometimes > missed. This document attempts to give some background on vhost-user > daemons in general terms.

Re: [PATCH] qemu-config: never call the callback after an error, fix leak

2021-07-08 Thread Markus Armbruster
Paolo Bonzini writes: > Ensure that the callback to qemu_config_foreach is never called upon > an error, by moving the invocation before the "out" label and ensuring > all error cases jump to the label. The qobject_unref however needs > to be done in all cases (which Coverity is already complain

Re: [PATCH v5 2/3] fuzz: add an instrumentation filter

2021-07-08 Thread Darren Kenny
Hi Alex, Sorry, missed this one, apologies for the delay in responding. On Tuesday, 2021-06-29 at 23:41:23 -04, Alexander Bulekov wrote: > By default, -fsanitize=fuzzer instruments all code with coverage > information. However, this means that libfuzzer will track coverage over > hundreds of sour

Re: [PATCH 03/11] hw/gpio/pl061: Clean up read/write offset handling logic

2021-07-08 Thread Peter Maydell
On Wed, 7 Jul 2021 at 02:25, Richard Henderson wrote: > > On 7/2/21 4:45 AM, Peter Maydell wrote: > > On Fri, 2 Jul 2021 at 12:02, Philippe Mathieu-Daudé wrote: > >> On 7/2/21 12:40 PM, Peter Maydell wrote: > >>> static const VMStateDescription vmstate_pl061 = { > >>> @@ -151,16 +150,9 @@ stati

Re: [PATCH] vl: fix leak of qdict_crumple return value

2021-07-08 Thread Paolo Bonzini
On 08/07/21 11:05, Markus Armbruster wrote: Fixes: c0d4aa82f895af67cbf7772324e05605e22b4162 Good point, will add. Paolo

Re: [PATCH] vl: fix leak of qdict_crumple return value

2021-07-08 Thread Paolo Bonzini
On 08/07/21 11:05, Markus Armbruster wrote: Minimally invasive fix, but the result is a bit awkward. Possibly neater: if (qobject_type(crumpled) == QTYPE_QLIST) { error_setg(errp, "Lists cannot be at top level of a configuration section"); } e

Re: [PATCH v2] target/arm: Correct the encoding of MDCCSR_EL0 and DBGDSCRint

2021-07-08 Thread Peter Maydell
On Tue, 6 Jul 2021 at 14:45, wrote: > > Signed-off-by: Nick Hudson > --- > target/arm/helper.c | 16 +--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/target/arm/helper.c b/target/arm/helper.c > index a66c1f0b9e..910ace4274 100644 > --- a/target/arm/helper.c >

Re: [PULL 00/15] Machine queue, 2021-07-07

2021-07-08 Thread Peter Maydell
On Wed, 7 Jul 2021 at 20:32, Eduardo Habkost wrote: > > The following changes since commit 9aef0954195cc592e86846dbbe7f3c2c5603690a: > > Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' > into staging (2021-07-06 11:24:58 +0100) > > are available in the Git repository at:

[PATCH v2 0/2] virtio-balloon: don't start free page hinting if postcopy is possible

2021-07-08 Thread David Hildenbrand
This is the follow up on [1]: [PATCH v1 0/2] virtio-balloon: disallow postcopy with VIRTIO_BALLOON_F_FREE_PAGE_HINT Working on getting migration for virtio-mem completely right [2] I realized that virtio-balloon with VIRTIO_BALLOON_F_FREE_PAGE_HINT paired with postcopy might be shaky. Actually

[PATCH v2 1/2] virtio-balloon: don't start free page hinting if postcopy is possible

2021-07-08 Thread David Hildenbrand
Postcopy never worked properly with 'free-page-hint=on', as there are at least two issues: 1) With postcopy, the guest will never receive a VIRTIO_BALLOON_CMD_ID_DONE and consequently won't release free pages back to the OS once migration finishes. The issue is that for postcopy, we won'

Re: [trivial PATCH 1/1] hw/intc: Improve formatting of MEMTX_ERROR guest error message

2021-07-08 Thread Peter Maydell
On Tue, 6 Jul 2021 at 22:14, Rebecca Cran wrote: > > Add a space in the message printed when gicr_read*/gicr_write* returns > MEMTX_ERROR in arm_gicv3_redist.c. > > Signed-off-by: Rebecca Cran > --- > hw/intc/arm_gicv3_redist.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied

[PATCH v2 2/2] virtio-balloon: free page hinting cleanups

2021-07-08 Thread David Hildenbrand
Let's compress the code a bit to improve readability. We can drop the vm_running check in virtio_balloon_free_page_start() as it's already properly checked in the single caller. Cc: Wei Wang Cc: Michael S. Tsirkin Cc: Philippe Mathieu-Daudé Cc: Alexander Duyck Cc: Juan Quintela Cc: "Dr. David

Re: [PATCH] Fix libpmem configuration option

2021-07-08 Thread Li , Zhijian/李 智坚
i have to apply below extra changes From a8d027d3dfe70fb33363ad5934e163999fc29eec Mon Sep 17 00:00:00 2001 From: Li Zhijian Date: Thu, 8 Jul 2021 17:52:40 +0800 Subject: [PATCH] fix libpmem configuration Signed-off-by: Li Zhijian --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deleti

Re: [PATCH] block/rbd: fix type of task->complete

2021-07-08 Thread Kevin Wolf
Am 07.07.2021 um 23:51 hat Connor Kuehl geschrieben: > On 7/7/21 11:04 AM, Peter Lieven wrote: > > task->complete is a bool not an integer. > > > > Signed-off-by: Peter Lieven > > --- > > block/rbd.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/block/rbd.c b/bl

[PULL 0/8] Linux user for 6.1 patches

2021-07-08 Thread Laurent Vivier
er-for-6.1-pull-request for you to fetch changes up to c632ea1dd90313bc360b9de9d5014c2167f4d038: linux-user/syscall: Remove hardcoded tabs (code style) (2021-07-07 21:34:21 +0200) linux-user pull request 20210708 Code and style c

[PULL 2/8] linux-user: fill ppid field in /proc/self/stat

2021-07-08 Thread Laurent Vivier
From: Andreas Schwab Signed-off-by: Andreas Schwab Reviewed-by: Laurent Vivier Message-Id: Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 64bbf331b282..3bc06d178e83 100644 --- a/l

[PULL 8/8] linux-user/syscall: Remove hardcoded tabs (code style)

2021-07-08 Thread Laurent Vivier
From: Philippe Mathieu-Daudé We are going to move this code, fix its style first. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210704183755.655002-12-f4...@amsat.org> Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 188 +-- 1 file chang

[PULL 3/8] linux-user: Fix style problems in linuxload.c

2021-07-08 Thread Laurent Vivier
From: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210706234932.356913-3-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/linuxload.c | 42 -- 1 file changed, 20 insertio

[PULL 1/8] linux-user/elfload: Implement ELF_HWCAP for RISC-V

2021-07-08 Thread Laurent Vivier
From: Kito Cheng Set I, M, A, F, D and C bit for hwcap if misa is set. Signed-off-by: Kito Cheng Reviewed-by: Richard Henderson Message-Id: <20210706035015.122899-1-kito.ch...@sifive.com> Signed-off-by: Laurent Vivier --- linux-user/elfload.c | 13 + 1 file changed, 13 insertions

[PULL 4/8] linux-user/alpha: Handle TARGET_EWOULDBLOCK as TARGET_EAGAIN

2021-07-08 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Linux kernel defines EWOULDBLOCK as EAGAIN (since before v2.6.12-rc2). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20210704183755.655002-2-f4...@amsat.org> Signed-off-by: Laurent Vivier --- linux-user/alpha/target_syscall.h |

[PULL 5/8] linux-user/hppa: Handle TARGET_EWOULDBLOCK as TARGET_EAGAIN

2021-07-08 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Linux kernel defines EWOULDBLOCK as EAGAIN (since before v2.6.12-rc2). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20210704183755.655002-3-f4...@amsat.org> Signed-off-by: Laurent Vivier --- linux-user/hppa/target_syscall.h |

[PULL 7/8] linux-user/alpha: Remove hardcoded tabs (code style)

2021-07-08 Thread Laurent Vivier
From: Philippe Mathieu-Daudé We are going to move this code, fix its style first. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20210704183755.655002-7-f4...@amsat.org> Signed-off-by: Laurent Vivier --- linux-user/alpha/target_syscall.h | 196 +

[PULL 6/8] linux-user/mips: Handle TARGET_EWOULDBLOCK as TARGET_EAGAIN

2021-07-08 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Linux kernel defines EWOULDBLOCK as EAGAIN (since before v2.6.12-rc2). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20210704183755.655002-4-f4...@amsat.org> Signed-off-by: Laurent Vivier --- linux-user/mips/target_syscall.h

Re: [PATCH qemu v23] spapr: Fix implementation of Open Firmware client interface

2021-07-08 Thread BALATON Zoltan
On Thu, 8 Jul 2021, Alexey Kardashevskiy wrote: This addresses the comments from v22. The functional changes are (the VOF ones need retesting with Pegasos2): (VOF) setprop will start failing if the machine class callback did not handle it; I'll try this later but I think I've seen guests usin

Re: [PATCH qemu v23] spapr: Fix implementation of Open Firmware client interface

2021-07-08 Thread Alexey Kardashevskiy
On 08/07/2021 20:18, BALATON Zoltan wrote: On Thu, 8 Jul 2021, Alexey Kardashevskiy wrote: This addresses the comments from v22. The functional changes are (the VOF ones need retesting with Pegasos2): (VOF) setprop will start failing if the machine class callback did not handle it; I'll t

Re: [RFC PATCH 0/6] job: replace AioContext lock with job_mutex

2021-07-08 Thread Stefan Hajnoczi
On Wed, Jul 07, 2021 at 06:58:07PM +0200, Emanuele Giuseppe Esposito wrote: > This is a continuation on the work to reduce (and possibly get rid of) the > usage of AioContext lock, by introducing smaller granularity locks to keep > the thread safety. > > This series aims to: > 1) remove the aioc

Re: [PATCH qemu v23] spapr: Fix implementation of Open Firmware client interface

2021-07-08 Thread BALATON Zoltan
On Thu, 8 Jul 2021, Alexey Kardashevskiy wrote: On 08/07/2021 20:18, BALATON Zoltan wrote: On Thu, 8 Jul 2021, Alexey Kardashevskiy wrote: This addresses the comments from v22. The functional changes are (the VOF ones need retesting with Pegasos2): (VOF) setprop will start failing if the mach

Re: [PATCH] block/rbd: fix type of task->complete

2021-07-08 Thread Ilya Dryomov
On Wed, Jul 7, 2021 at 8:05 PM Peter Lieven wrote: > > task->complete is a bool not an integer. > > Signed-off-by: Peter Lieven > --- > block/rbd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/rbd.c b/block/rbd.c > index 01a7b94d62..dcf82b15b8 100644 > --- a/blo

Re: [PATCH] MAINTAINERS: update block/rbd.c maintainer

2021-07-08 Thread Ilya Dryomov
On Wed, Jul 7, 2021 at 8:05 PM Peter Lieven wrote: > > adding myself as a designated reviewer. > > Signed-off-by: Peter Lieven > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 516db737d1..cfda57e825 100644 > --- a/MAINTAINERS > +++ b/

Re: [RFC PATCH 2/6] job: _locked functions and public job_lock/unlock for next patch

2021-07-08 Thread Stefan Hajnoczi
On Wed, Jul 07, 2021 at 06:58:09PM +0200, Emanuele Giuseppe Esposito wrote: > diff --git a/job.c b/job.c > index 872bbebb01..96fb8e9730 100644 > --- a/job.c > +++ b/job.c > @@ -32,6 +32,10 @@ > #include "trace/trace-root.h" > #include "qapi/qapi-events-job.h" > > +/* job_mutex protexts the jobs

Re: [RFC PATCH 3/6] job: minor changes to simplify locking

2021-07-08 Thread Stefan Hajnoczi
On Wed, Jul 07, 2021 at 06:58:10PM +0200, Emanuele Giuseppe Esposito wrote: > @@ -406,15 +410,18 @@ void *job_create(const char *job_id, const JobDriver > *driver, JobTxn *txn, > error_setg(errp, "Invalid job ID '%s'", job_id); > return NULL; > } > -if (j

Re: [PATCH v2 00/36] linux-user: Signal trampolines and vdsos

2021-07-08 Thread Philippe Mathieu-Daudé
On 7/7/21 1:48 AM, Richard Henderson wrote: > Supercedes: <20210619034329.532318-1-richard.hender...@linaro.org> > ("[PATCH 00/12] linux-user: Load a vdso for x86_64 and hppa") > > Supercedes: <20210618192951.125651-1-richard.hender...@linaro.org> > ("[PATCH v2 00/23] linux-user: Move signal tramp

Re: [RFC PATCH 4/6] job.h: categorize job fields

2021-07-08 Thread Stefan Hajnoczi
On Wed, Jul 07, 2021 at 06:58:11PM +0200, Emanuele Giuseppe Esposito wrote: > -/** AioContext to run the job coroutine in */ > +/** > + * AioContext to run the job coroutine in. > + * Atomic. > + */ > AioContext *aio_context; This isn't accessed using atomic operations, so

Re: [PATCH qemu v23] spapr: Fix implementation of Open Firmware client interface

2021-07-08 Thread Alexey Kardashevskiy
On 08/07/2021 20:39, BALATON Zoltan wrote: On Thu, 8 Jul 2021, Alexey Kardashevskiy wrote: On 08/07/2021 20:18, BALATON Zoltan wrote: On Thu, 8 Jul 2021, Alexey Kardashevskiy wrote: This addresses the comments from v22. The functional changes are (the VOF ones need retesting with Pegasos2)

Re: Esoteric QMP specification questions of dubious importance

2021-07-08 Thread Markus Armbruster
John Snow writes: > I'm writing a "fake" QMP server for the purposes of creating unit tests for > the python QMP library. In doing so, I am left with some esoteric questions: > > > (1) qemu-spec.txt, section 2.4.2, "error": > > The format of an "error response" is: > >> { "error": { "class": json

Re: [RFC PATCH 0/6] job: replace AioContext lock with job_mutex

2021-07-08 Thread Paolo Bonzini
On 08/07/21 12:36, Stefan Hajnoczi wrote: What is very clear from this patch is that it is strictly related to the brdv_* and lower level calls, because they also internally check or even use the aiocontext lock. Therefore, in order to make it work, I temporarly added some aiocontext_acquire/rele

Re: [PATCH] qemu-config: never call the callback after an error, fix leak

2021-07-08 Thread Paolo Bonzini
On 08/07/21 11:24, Markus Armbruster wrote: Looks like the patch fixes two separate issues: 1. Memory leak on ferror() Fixes: f7544edcd32e602af1aae86714dc7c32350d5d7c 2. Callback can run on error. Fixes: 37701411397c7b7d709ae92abd347cc593940ee5 I*think* this happens when the cb()

[PATCH v6 2/6] block: Add bdrv_reopen_queue_free()

2021-07-08 Thread Kevin Wolf
From: Alberto Garcia Move the code to free a BlockReopenQueue to a separate function. It will be used in a subsequent patch. [ kwolf: Also free explicit_options and options, and explicitly qobject_ref() the value when it continues to be used. This makes future memory leaks less likely. ] Si

[PATCH v6 1/6] qcow2: Fix dangling pointer after reopen for 'file'

2021-07-08 Thread Kevin Wolf
Without an external data file, s->data_file is a second pointer with the same value as bs->file. When changing bs->file to a different BdrvChild and freeing the old BdrvChild, s->data_file must also be updated, otherwise it points to freed memory and causes crashes. This problem was caught by iote

[PATCH v6 0/6] Make blockdev-reopen stable

2021-07-08 Thread Kevin Wolf
This series picks up the remaining patches from Berto's series "[PATCH v4 0/6] Allow changing bs->file on reopen", which are not merged into master yet. Apart from renaming 'x-blockdev-reopen' into 'blockdev-reopen', the remaining functional change in this series is taking a list of nodes to reope

[PATCH v6 3/6] block: Acquire AioContexts during bdrv_reopen_multiple()

2021-07-08 Thread Kevin Wolf
As the BlockReopenQueue can contain nodes in multiple AioContexts, only one of which may be locked when AIO_WAIT_WHILE() can be called, we can't let the caller lock the right contexts. Instead, individually lock the AioContext of a single node when iterating the queue. Reintroduce bdrv_reopen() as

[PATCH v6 5/6] iotests: Test reopening multiple devices at the same time

2021-07-08 Thread Kevin Wolf
From: Alberto Garcia This test swaps the images used by two active block devices. This is now possible thanks to the new ability to run x-blockdev-reopen on multiple devices at the same time. Signed-off-by: Alberto Garcia Signed-off-by: Kevin Wolf Reviewed-by: Vladimir Sementsov-Ogievskiy --

[PATCH v6 4/6] block: Support multiple reopening with x-blockdev-reopen

2021-07-08 Thread Kevin Wolf
From: Alberto Garcia [ kwolf: Fixed AioContext locking ] Signed-off-by: Alberto Garcia Signed-off-by: Kevin Wolf Reviewed-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 18 +++-- blockdev.c| 81 ++- tes

[PATCH] meson: fix missing preprocessor symbols

2021-07-08 Thread Paolo Bonzini
While most libraries do not need a CONFIG_* symbol because the "when:" clauses are enough, some do. Add them back or stop using them if possible. In the case of libpmem, the statement to add the CONFIG_* symbol was still in configure, but could not be triggered because it checked for "no" instead

[PATCH v6 6/6] block: Make blockdev-reopen stable API

2021-07-08 Thread Kevin Wolf
From: Alberto Garcia This patch drops the 'x-' prefix from x-blockdev-reopen. Signed-off-by: Alberto Garcia Signed-off-by: Kevin Wolf Reviewed-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json| 6 +++--- blockdev.c

[PATCH v2] remote/memory: Replace share parameter with ram_flags

2021-07-08 Thread Yang Zhong
Fixes: d5015b801340 ("softmmu/memory: Pass ram_flags to qemu_ram_alloc_from_fd()") Signed-off-by: Yang Zhong Reviewed-by: David Hildenbrand --- hw/remote/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/remote/memory.c b/hw/remote/memory.c index 472ed2a272..6e21ab

Re: [PATCH 04/53] tests: acpi: q35: test for x2APIC entries in SRAT

2021-07-08 Thread Michael S. Tsirkin
On Thu, Jul 08, 2021 at 11:18:33AM +0200, Igor Mammedov wrote: > On Fri, 2 Jul 2021 10:45:37 -0400 > "Michael S. Tsirkin" wrote: > > > On Fri, Jun 25, 2021 at 05:17:28AM -0400, Igor Mammedov wrote: > > > Set -smp 1,maxcpus=288 to test for ACPI code that > > > deal with CPUs with large APIC ID (>2

Re: [PATCH V5 01/25] qemu_ram_volatile

2021-07-08 Thread Marc-André Lureau
Hi On Wed, Jul 7, 2021 at 9:35 PM Steve Sistare wrote: > Add a function that returns true if any ram_list block represents > volatile memory. > > Signed-off-by: Steve Sistare > --- > include/exec/memory.h | 8 > softmmu/memory.c | 30 ++ > 2 files cha

Re: [PATCH v1] vhost: make SET_VRING_ADDR, SET_FEATURES send replies

2021-07-08 Thread Michael S. Tsirkin
On Thu, Jul 08, 2021 at 11:28:40AM +0300, Denis Plotnikov wrote: > On vhost-user-blk migration, qemu normally sends a number of commands > to enable logging if VHOST_USER_PROTOCOL_F_LOG_SHMFD is negotiated. > Qemu sends VHOST_USER_SET_FEATURES to enable buffers logging and > VHOST_USER_SET_VRING_AD

Re: [PATCH] MAINTAINERS: update block/rbd.c maintainer

2021-07-08 Thread Kevin Wolf
Am 08.07.2021 um 12:44 hat Ilya Dryomov geschrieben: > On Wed, Jul 7, 2021 at 8:05 PM Peter Lieven wrote: > > > > adding myself as a designated reviewer. > > > > Signed-off-by: Peter Lieven > > --- > > MAINTAINERS | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/MAINTAINERS b/MAINT

Re: [PATCH v2 05/28] target/arm: Use gen_jmp for ISB and SB

2021-07-08 Thread Peter Maydell
On Wed, 30 Jun 2021 at 19:47, Richard Henderson wrote: > > Using gen_goto_tb directly misses the single-step check. > > Cc: qemu-...@nongnu.org > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/ar

Re: [PATCH v2 06/28] target/arm: Use translator_use_goto_tb for aarch64

2021-07-08 Thread Peter Maydell
On Wed, 30 Jun 2021 at 19:37, Richard Henderson wrote: > > We have not needed to end a TB for I/O since ba3e7926691 > ("icount: clean up cpu_can_io at the entry to the block"), > and gdbstub singlestep is handled by the generic function. > > Drop the unused 'n' argument to use_goto_tb. > > Cc: qem

Re: [RFC PATCH 0/6] job: replace AioContext lock with job_mutex

2021-07-08 Thread Kevin Wolf
Am 08.07.2021 um 13:32 hat Paolo Bonzini geschrieben: > On 08/07/21 12:36, Stefan Hajnoczi wrote: > > > What is very clear from this patch is that it > > > is strictly related to the brdv_* and lower level calls, because > > > they also internally check or even use the aiocontext lock. > > > Theref

Re: [PATCH v2 07/28] target/arm: Use translator_use_goto_tb for aarch32

2021-07-08 Thread Peter Maydell
On Wed, 30 Jun 2021 at 19:36, Richard Henderson wrote: > > Just use translator_use_goto_tb directly at the one call site, > rather than maintaining a local wrapper. > > Cc: qemu-...@nongnu.org > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 12 +--- > 1 file changed,

Re: [PATCH v2 24/28] target/sh4: Use translator_use_goto_tb

2021-07-08 Thread Peter Maydell
On Wed, 30 Jun 2021 at 19:56, Richard Henderson wrote: > > Cc: Yoshinori Sato > Signed-off-by: Richard Henderson > --- > target/sh4/translate.c | 11 +++ Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 21/28] target/rx: Use translator_use_goto_tb

2021-07-08 Thread Peter Maydell
On Wed, 30 Jun 2021 at 19:50, Richard Henderson wrote: > > Just use translator_use_goto_tb directly at the one call site, > rather than maintaining a local wrapper. > > Cc: Yoshinori Sato > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v5 0/6] block/rbd: migrate to coroutines and add write zeroes support

2021-07-08 Thread Kevin Wolf
Am 07.07.2021 um 20:13 hat Peter Lieven geschrieben: > Am 06.07.2021 um 17:25 schrieb Kevin Wolf : > > Am 06.07.2021 um 16:55 hat Peter Lieven geschrieben: > >> I will have a decent look after my vacation. > > > > Sounds good, thanks. Enjoy your vacation! > > As I had to fire up my laptop to look

Re: [PATCH v2 17/28] target/nios2: Use translator_use_goto_tb

2021-07-08 Thread Peter Maydell
On Wed, 30 Jun 2021 at 19:43, Richard Henderson wrote: > > Just use translator_use_goto_tb directly at the one call site, > rather than maintaining a local wrapper. > > Cc: Chris Wulff > Cc: Marek Vasut > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 14/28] target/microblaze: Use translator_use_goto_tb

2021-07-08 Thread Peter Maydell
On Wed, 30 Jun 2021 at 19:54, Richard Henderson wrote: > > Just use translator_use_goto_tb directly at the one call site, > rather than maintaining a local wrapper. > > Cc: Edgar E. Iglesias > Signed-off-by: Richard Henderson > --- > target/microblaze/translate.c | 11 +-- > 1 file chan

Re: [PATCH v2 13/28] target/m68k: Use translator_use_goto_tb

2021-07-08 Thread Peter Maydell
On Wed, 30 Jun 2021 at 19:44, Richard Henderson wrote: > > Just use translator_use_goto_tb directly at the one call site, > rather than maintaining a local wrapper. > > Acked-by: Laurent Vivier > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 15/28] target/mips: Use translator_use_goto_tb

2021-07-08 Thread Peter Maydell
On Wed, 30 Jun 2021 at 19:48, Richard Henderson wrote: > > Just use translator_use_goto_tb directly at the one call site, > rather than maintaining a local wrapper. > > Cc: Philippe Mathieu-Daudé > Signed-off-by: Richard Henderson > --- > target/mips/tcg/translate.c | 17 ++--- Revi

Re: [PATCH V5 02/25] cpr: reboot mode

2021-07-08 Thread Marc-André Lureau
Hi On Wed, Jul 7, 2021 at 9:45 PM Steve Sistare wrote: > Provide the cprsave and cprload functions for live update. These save and > restore VM state, with minimal guest pause time, so that qemu may be > updated > to a new version in between. > > cprsave stops the VM and saves vmstate to an ord

Re: [PATCH] blockdev: fix drive-backup transaction endless drained section

2021-07-08 Thread Kevin Wolf
Am 07.07.2021 um 15:35 hat Vladimir Sementsov-Ogievskiy geschrieben: > Forgotten thing :( > > Kevin, could you please queue it in your block branch? For me not to > bother Peter with one-patch pull request. No problem, I've queued it now. Kevin

Re: [PATCH v2 10/28] target/cris: Use translator_use_goto_tb

2021-07-08 Thread Peter Maydell
On Wed, 30 Jun 2021 at 19:43, Richard Henderson wrote: > > The test for singlestepping is done in translator_use_goto_tb, > so we may elide it from cris_tr_tb_stop. > > Cc: Edgar E. Iglesias > Signed-off-by: Richard Henderson > --- > target/cris/translate.c | 5 ++--- > 1 file changed, 2 insert

Re: [PATCH v2 12/28] target/i386: Use translator_use_goto_tb

2021-07-08 Thread Peter Maydell
On Wed, 30 Jun 2021 at 19:39, Richard Henderson wrote: > > Just use translator_use_goto_tb directly at the one call site, > rather than maintaining a local wrapper. > > Cc: Paolo Bonzini > Cc: Eduardo Habkost > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 04/28] target/alpha: Use translator_use_goto_tb

2021-07-08 Thread Peter Maydell
On Wed, 30 Jun 2021 at 19:35, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/alpha/translate.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 11/28] target/hppa: Use translator_use_goto_tb

2021-07-08 Thread Peter Maydell
On Wed, 30 Jun 2021 at 19:40, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/hppa/translate.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2] remote/memory: Replace share parameter with ram_flags

2021-07-08 Thread Philippe Mathieu-Daudé
On 7/8/21 1:51 PM, Yang Zhong wrote: > Fixes: d5015b801340 ("softmmu/memory: Pass ram_flags to > qemu_ram_alloc_from_fd()") Oops. Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Yang Zhong > Reviewed-by: David Hildenbrand > --- > hw/remote/memory.c | 2 +- > 1 file changed, 1 insertion(

Re: [PATCH v2 08/28] target/avr: Use translator_use_goto_tb

2021-07-08 Thread Peter Maydell
On Wed, 30 Jun 2021 at 19:35, Richard Henderson wrote: > > Single stepping is not the only reason not to use goto_tb. > If goto_tb is disallowed, and single-stepping is not enabled, > then use tcg_gen_lookup_and_goto_tb to indirectly chain. > > Cc: Michael Rolnik > Signed-off-by: Richard Henderso

Re: [PATCH v2 02/28] target/alpha: Remove use_exit_tb

2021-07-08 Thread Peter Maydell
On Wed, 30 Jun 2021 at 19:39, Richard Henderson wrote: > > We have not needed to end a TB for I/O since ba3e7926691 > ("icount: clean up cpu_can_io at the entry to the block"). > We do not need to use exit_tb for singlestep, which only > means generate one insn per TB. > > Which leaves only single

Re: [PATCH v2 03/28] target/alpha: Remove in_superpage

2021-07-08 Thread Peter Maydell
On Wed, 30 Jun 2021 at 19:43, Richard Henderson wrote: > > The number of links across (normal) pages using this is low, > and it will shortly violate the contract for breakpoints. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

[PATCH v5 2/9] hw/pxb: Add a bypass iommu property

2021-07-08 Thread Wang Xingang
From: Xingang Wang Add a bypass_iommu property for pci_expander_bridge, the property is used to indicate whether pxb root bus will bypass iommu. By default the bypass_iommu is disabled, and it can be enabled with: qemu -device pxb-pcie,bus_nr=0x10,addr=0x1,bypass_iommu=true Signed-off-by: Xingan

[PATCH v5 9/9] docs: Add documentation for iommu bypass

2021-07-08 Thread Wang Xingang
From: Xingang Wang Signed-off-by: Xingang Wang --- docs/bypass-iommu.txt | 89 +++ 1 file changed, 89 insertions(+) create mode 100644 docs/bypass-iommu.txt diff --git a/docs/bypass-iommu.txt b/docs/bypass-iommu.txt new file mode 100644 index 00

[PATCH v5 7/9] hw/i386/acpi-build: Add DMAR support to bypass iommu

2021-07-08 Thread Wang Xingang
From: Xingang Wang In DMAR table, the drhd is set to cover all PCI devices when intel_iommu is on. To support bypass iommu feature, we need to walk the PCI bus with bypass_iommu disabled and add explicit scope data in DMAR drhd structure. /mnt/sdb/wxg/qemu-next/qemu/build/x86_64-softmmu/qemu-sys

[PATCH v5 5/9] hw/pci: Add pci_bus_range() to get PCI bus number range

2021-07-08 Thread Wang Xingang
From: Xingang Wang This helps to get the min and max bus number of a PCI bus hierarchy. Signed-off-by: Xingang Wang Reviewed-by: Eric Auger --- hw/pci/pci.c | 16 include/hw/pci/pci.h | 1 + 2 files changed, 17 insertions(+) diff --git a/hw/pci/pci.c b/hw/pci/pci.c

[PATCH v5 6/9] hw/arm/virt-acpi-build: Add IORT support to bypass SMMUv3

2021-07-08 Thread Wang Xingang
From: Xingang Wang When we build IORT table with SMMUv3 and bypass iommu feature enabled, we can no longer setup one map from RC to SMMUv3 covering the whole RIDs. We need to walk the PCI bus and check whether the root bus will bypass iommu, setup RC -> SMMUv3 -> ITS map for RC which will not byp

[PATCH v5 1/9] hw/pci/pci_host: Allow PCI host to bypass iommu

2021-07-08 Thread Wang Xingang
From: Xingang Wang Add a new bypass_iommu property for PCI host and use it to check whether devices attached to the PCI root bus will bypass iommu. In pci_device_iommu_address_space(), check the property and avoid getting iommu address space for devices bypass iommu. Signed-off-by: Xingang Wang

[PATCH v5 0/9] IOMMU: Add support for IOMMU Bypass Feature

2021-07-08 Thread Wang Xingang
From: Xingang Wang Traditionally, there is a global switch to enable/disable vIOMMU. All devices in the system can only support go through vIOMMU or not, which is not flexible. We introduce this bypass iommu property to support coexist of devices go through vIOMMU and devices not. This is useful

  1   2   3   4   5   6   7   >