This is the follow up on [1]: [PATCH v1 0/2] virtio-balloon: disallow postcopy with VIRTIO_BALLOON_F_FREE_PAGE_HINT
Working on getting migration for virtio-mem completely right [2] I realized that virtio-balloon with VIRTIO_BALLOON_F_FREE_PAGE_HINT paired with postcopy might be shaky. Actually testing it, I directly found two issues, one of both being far from trivial to fix. Let's not start free page hinting if postcopy is possible. v1 -> v2: - "virtio-balloon: don't start free page hinting if postcopy is possible" -- Instead of bailing out when starting postcopy, don't start free page hinting if the postcopy capability is enabled and we might see the switch to postcopy for the current migration (where we might mess with the dirty bitmap) - "virtio-balloon: free page hinting cleanups" -- Added [1] https://lkml.kernel.org/r/20210707140655.30982-1-da...@redhat.com [2] https://lkml.kernel.org/r/20210616162940.28630-1-da...@redhat.com David Hildenbrand (2): virtio-balloon: don't start free page hinting if postcopy is possible virtio-balloon: free page hinting cleanups hw/virtio/virtio-balloon.c | 41 +++++++++++++++++++------------------- 1 file changed, 21 insertions(+), 20 deletions(-) -- 2.31.1
