Re: [PATCH v3 1/3] target/ppc: fix address translation bug for radix mmus

2021-06-28 Thread Cédric Le Goater
On 6/24/21 10:21 PM, Bruno Larsen (billionai) wrote: > This commit attempts to fix the first bug mentioned by Richard Henderson in > https://lists.nongnu.org/archive/html/qemu-devel/2021-05/msg06247.html > > To sumarize the bug here, when radix-style mmus are translating an > address, they might n

Re: [PATCH v2 1/2] migration/rdma: Fix out of order wrid

2021-06-28 Thread lizhij...@fujitsu.com
On 25/06/2021 00:42, Dr. David Alan Gilbert wrote: > * Li Zhijian (lizhij...@cn.fujitsu.com) wrote: >> destination: >> ../qemu/build/qemu-system-x86_64 -enable-kvm -netdev >> tap,id=hn0,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown -device >> e1000,netdev=hn0,mac=50:52:54:00:11:22 -boot c -

[PATCH] migration/rdma: Use error_report to suppress errno message

2021-06-28 Thread Li Zhijian
Since the prior calls are successful, in this case a errno doesn't indicate a real error which would just make us confused. before: (qemu) migrate -d rdma:192.168.22.23: source_resolve_host RDMA Device opened: kernel name rxe_eth0 uverbs device name uverbs2, infiniband_verbs class device path

Re: [RFC PATCH 03/11] hw/intc: Add CLIC device

2021-06-28 Thread LIU Zhiwei
On 2021/6/26 下午8:56, Frank Chang wrote: On Wed, Jun 16, 2021 at 10:56 AM LIU Zhiwei > wrote: On 6/13/21 6:10 PM, Frank Chang wrote: LIU Zhiwei mailto:zhiwei_...@c-sky.com>> 於 2021年4月9日 週五 下午3:57寫道: +static void riscv_clic_realize(DeviceState *

Re: [RFC PATCH 03/11] hw/intc: Add CLIC device

2021-06-28 Thread Frank Chang
LIU Zhiwei 於 2021年6月28日 週一 下午3:17寫道: > > On 2021/6/26 下午8:56, Frank Chang wrote: > > On Wed, Jun 16, 2021 at 10:56 AM LIU Zhiwei wrote: > >> >> On 6/13/21 6:10 PM, Frank Chang wrote: >> >> LIU Zhiwei 於 2021年4月9日 週五 下午3:57寫道: >> >> +static void riscv_clic_realize(DeviceState *dev, Error **errp)

Re: [RFC PATCH 03/10] hw/sd: Move proto_name to SDProto structure

2021-06-28 Thread Cédric Le Goater
On 6/24/21 4:22 PM, Philippe Mathieu-Daudé wrote: > Introduce a new structure to hold the bus protocol specific > fields: SDProto. The first field is the protocol name. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sd/sd.c | 28 > 1 file changed, 20 insertions

Re: [PATCH 2/3] gitlab: support for FreeBSD 12, 13 and macOS 11 via cirrus-run

2021-06-28 Thread Thomas Huth
On 25/06/2021 19.22, Daniel P. Berrangé wrote: This adds support for running 4 jobs via Cirrus CI runners: * FreeBSD 12 * FreeBSD 13 * macOS 11 with default XCode * macOS 11 with latest XCode The gitlab job uses a container published by the libvirt-ci project (https://gitlab.com/libvirt

Re: [RFC PATCH 04/10] hw/sd: Introduce sd_cmd_handler type

2021-06-28 Thread Cédric Le Goater
On 6/24/21 4:22 PM, Philippe Mathieu-Daudé wrote: > Add 2 command handler arrays in SDProto, for CMD and ACMD. > Have sd_normal_command() / sd_app_command() use these arrays: > if an command handler is registered, call it, otherwise fall > back to current code base. > > Signed-off-by: Philippe Mat

Re: [RFC PATCH 05/10] hw/sd: Add sd_cmd_illegal() handler

2021-06-28 Thread Cédric Le Goater
On 6/24/21 4:22 PM, Philippe Mathieu-Daudé wrote: > Log illegal commands as GUEST_ERROR. > > Note: we are logging back the SDIO commands (CMD5, CMD52-54). > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sd/sd.c | 57 ++ > 1 file changed,

Re: [PATCH 3/3] cirrus: delete FreeBSD and macOS jobs

2021-06-28 Thread Thomas Huth
On 25/06/2021 19.22, Daniel P. Berrangé wrote: The builds for these two platforms can now be performed from GitLab CI using cirrus-run. Signed-off-by: Daniel P. Berrangé --- .cirrus.yml | 55 - 1 file changed, 55 deletions(-) diff --git a/

Re: [PATCH 0/3] ci: use cirrus-run to utilize Cirrus CI from GitLab CI

2021-06-28 Thread Thomas Huth
On 25/06/2021 19.22, Daniel P. Berrangé wrote: [...] The MSys Windows job still remains in the .cirrus.yml file. This can be addressed to, if we extend libvirt-ci to have package mapping information for MSys. I think gitlab-CI offers shared Windows runners, too, see e.g.: https://about.gitlab

Re: [RFC PATCH 03/11] hw/intc: Add CLIC device

2021-06-28 Thread LIU Zhiwei
On 2021/6/28 下午3:23, Frank Chang wrote: LIU Zhiwei mailto:zhiwei_...@c-sky.com>> 於 2021年6月28日 週一 下午3:17寫道: On 2021/6/26 下午8:56, Frank Chang wrote: On Wed, Jun 16, 2021 at 10:56 AM LIU Zhiwei mailto:zhiwei_...@c-sky.com>> wrote: On 6/13/21 6:10 PM, Frank Chang wrote:

Re: [RFC PATCH 03/11] hw/intc: Add CLIC device

2021-06-28 Thread Frank Chang
LIU Zhiwei 於 2021年6月28日 週一 下午3:40寫道: > > On 2021/6/28 下午3:23, Frank Chang wrote: > > LIU Zhiwei 於 2021年6月28日 週一 下午3:17寫道: > >> >> On 2021/6/26 下午8:56, Frank Chang wrote: >> >> On Wed, Jun 16, 2021 at 10:56 AM LIU Zhiwei wrote: >> >>> >>> On 6/13/21 6:10 PM, Frank Chang wrote: >>> >>> LIU Zhiwei

Re: [RFC PATCH 00/10] hw/sd: Start splitting SD vs SPI protocols

2021-06-28 Thread Cédric Le Goater
On 6/24/21 4:21 PM, Philippe Mathieu-Daudé wrote: > Hi Cédric, > > After our discussion yesterday about how to add support for MMC > (and eMMC) I looked at how to easily add these bus protocols, > which might have commands quite different, avoiding to have big > unreadable if/else statements. > >

Re: [RFC PATCH 03/11] hw/intc: Add CLIC device

2021-06-28 Thread LIU Zhiwei
On 2021/6/28 下午3:49, Frank Chang wrote: LIU Zhiwei mailto:zhiwei_...@c-sky.com>> 於 2021年6月28日 週一 下午3:40寫道: On 2021/6/28 下午3:23, Frank Chang wrote: LIU Zhiwei mailto:zhiwei_...@c-sky.com>> 於 2021年6月28日 週一 下午3:17寫道: On 2021/6/26 下午8:56, Frank Chang wrote: On Wed,

Re: [RFC PATCH 03/11] hw/intc: Add CLIC device

2021-06-28 Thread Frank Chang
LIU Zhiwei 於 2021年6月28日 週一 下午4:03寫道: > > On 2021/6/28 下午3:49, Frank Chang wrote: > > LIU Zhiwei 於 2021年6月28日 週一 下午3:40寫道: > >> >> On 2021/6/28 下午3:23, Frank Chang wrote: >> >> LIU Zhiwei 於 2021年6月28日 週一 下午3:17寫道: >> >>> >>> On 2021/6/26 下午8:56, Frank Chang wrote: >>> >>> On Wed, Jun 16, 2021 at

Re: [RFC PATCH 03/11] hw/intc: Add CLIC device

2021-06-28 Thread LIU Zhiwei
On 2021/6/28 下午4:07, Frank Chang wrote: LIU Zhiwei mailto:zhiwei_...@c-sky.com>> 於 2021年6月28日 週一 下午4:03寫道: On 2021/6/28 下午3:49, Frank Chang wrote: LIU Zhiwei mailto:zhiwei_...@c-sky.com>> 於 2021年6月28日 週一 下午3:40寫道: On 2021/6/28 下午3:23, Frank Chang wrote: LIU Zhi

Re: [RFC PATCH 03/11] hw/intc: Add CLIC device

2021-06-28 Thread Frank Chang
LIU Zhiwei 於 2021年6月28日 週一 下午4:12寫道: > > On 2021/6/28 下午4:07, Frank Chang wrote: > > LIU Zhiwei 於 2021年6月28日 週一 下午4:03寫道: > >> >> On 2021/6/28 下午3:49, Frank Chang wrote: >> >> LIU Zhiwei 於 2021年6月28日 週一 下午3:40寫道: >> >>> >>> On 2021/6/28 下午3:23, Frank Chang wrote: >>> >>> LIU Zhiwei 於 2021年6月28

Re: [PULL 0/2] Audio 20210624 patches

2021-06-28 Thread Peter Maydell
On Thu, 24 Jun 2021 at 13:18, Gerd Hoffmann wrote: > > The following changes since commit b22726abdfa54592d6ad88f65b0297c0e8b363e2: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-6.1-pull-request' into staging > (2021-06-22 16:07:53 +0100) > > are available in the Git

Re: [PATCH 0/3] ci: use cirrus-run to utilize Cirrus CI from GitLab CI

2021-06-28 Thread Daniel P . Berrangé
On Mon, Jun 28, 2021 at 09:34:41AM +0200, Thomas Huth wrote: > On 25/06/2021 19.22, Daniel P. Berrangé wrote: > [...] > > The MSys Windows job still remains in the .cirrus.yml file. This > > can be addressed to, if we extend libvirt-ci to have package > > mapping information for MSys. > > I think

Re: [PATCH 2/3] gitlab: support for FreeBSD 12, 13 and macOS 11 via cirrus-run

2021-06-28 Thread Daniel P . Berrangé
On Mon, Jun 28, 2021 at 09:28:18AM +0200, Thomas Huth wrote: > On 25/06/2021 19.22, Daniel P. Berrangé wrote: > > This adds support for running 4 jobs via Cirrus CI runners: > > > > * FreeBSD 12 > > * FreeBSD 13 > > * macOS 11 with default XCode > > * macOS 11 with latest XCode > > > > Th

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-28 Thread wangyanan (Y)
Hi, On 2021/6/23 1:39, Daniel P. Berrangé wrote: On Tue, Jun 22, 2021 at 07:29:34PM +0200, Andrew Jones wrote: On Tue, Jun 22, 2021 at 06:14:25PM +0100, Daniel P. Berrangé wrote: On Tue, Jun 22, 2021 at 05:40:13PM +0200, Igor Mammedov wrote: On Tue, 22 Jun 2021 16:29:15 +0200 Andrew Jones wro

Re: [RFC PATCH 03/11] hw/intc: Add CLIC device

2021-06-28 Thread LIU Zhiwei
On 2021/6/28 下午4:19, Frank Chang wrote: LIU Zhiwei mailto:zhiwei_...@c-sky.com>> 於 2021年6月28日 週一 下午4:12寫道: On 2021/6/28 下午4:07, Frank Chang wrote: LIU Zhiwei mailto:zhiwei_...@c-sky.com>> 於 2021年6月28日 週一 下午4:03寫道: On 2021/6/28 下午3:49, Frank Chang wrote: LIU Zhi

reminder: softfreeze in a fortnight

2021-06-28 Thread Peter Maydell
Early reminder that softfreeze will be on the 13th July, in just over two weeks' time. Please make sure that any feature work for the 6.1 release has made it into a sub-maintainer pull request on the list by that time. If maintainers could avoid all sending their pull requests on the day of softfr

Re: [PATCH v2] ui/cocoa: Use NSWindow's ability to resize

2021-06-28 Thread BALATON Zoltan
On Mon, 28 Jun 2021, Akihiko Odaki wrote: This change brings two new features: - The window will be resizable if "Zoom To Fit" is eanbled - The window can be made full screen by clicking full screen button provided by the platform. (The left-top green button.) While this is better for consiste

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-28 Thread Andrew Jones
On Mon, Jun 28, 2021 at 04:43:05PM +0800, wangyanan (Y) wrote: > Hi, > On 2021/6/23 1:39, Daniel P. Berrangé wrote: > > On Tue, Jun 22, 2021 at 07:29:34PM +0200, Andrew Jones wrote: > > > On Tue, Jun 22, 2021 at 06:14:25PM +0100, Daniel P. Berrangé wrote: > > > > On Tue, Jun 22, 2021 at 05:40:13PM

Re: [RFC PATCH 03/11] hw/intc: Add CLIC device

2021-06-28 Thread Frank Chang
LIU Zhiwei 於 2021年6月28日 週一 下午4:47寫道: > > On 2021/6/28 下午4:19, Frank Chang wrote: > > LIU Zhiwei 於 2021年6月28日 週一 下午4:12寫道: > >> >> On 2021/6/28 下午4:07, Frank Chang wrote: >> >> LIU Zhiwei 於 2021年6月28日 週一 下午4:03寫道: >> >>> >>> On 2021/6/28 下午3:49, Frank Chang wrote: >>> >>> LIU Zhiwei 於 2021年6月28

Re: [RFC PATCH] docs/specs: QMP configuration design specification

2021-06-28 Thread Mirela Grujic
Hi, While implementing a prototype we run into a couple of challenges. We're not sure whether our current implementation would be acceptable and whether there is a better solution, so we would highly appreciate your feedback. The device_add command, which was originally used for hot-plugging

Re: [PATCH 0/2] introduce QEMU_AUTO_VFREE

2021-06-28 Thread Kevin Wolf
Am 23.06.2021 um 12:34 hat Kevin Wolf geschrieben: > Am 19.06.2021 um 16:21 hat Vladimir Sementsov-Ogievskiy geschrieben: > > Hi all! > > > > There is a good movement to use g_autofree macro, that helps to > > automatically call g_free on exit from code block. > > > > We lack similar possibility

Re: [RFC PATCH 03/11] hw/intc: Add CLIC device

2021-06-28 Thread Frank Chang
LIU Zhiwei 於 2021年4月9日 週五 下午3:57寫道: > The Core-Local Interrupt Controller (CLIC) provides low-latency, > vectored, pre-emptive interrupts for RISC-V systems. > > The CLIC also supports a new Selective Hardware Vectoring feature > that allow users to optimize each interrupt for either faster > res

Re: [PATCH v2 0/7] 9pfs: Twalk optimization

2021-06-28 Thread Christian Schoenebeck
On Freitag, 4. Juni 2021 20:23:21 CEST Christian Schoenebeck wrote: > On Freitag, 4. Juni 2021 18:31:28 CEST Greg Kurz wrote: > > On Fri, 4 Jun 2021 17:48:49 +0200 > > > > Christian Schoenebeck wrote: > > > This patch set reduces latency of Twalk handling by reducing the amount > > > of > > > thr

Re: [RFC PATCH 03/11] hw/intc: Add CLIC device

2021-06-28 Thread Frank Chang
LIU Zhiwei 於 2021年4月9日 週五 下午3:57寫道: > The Core-Local Interrupt Controller (CLIC) provides low-latency, > vectored, pre-emptive interrupts for RISC-V systems. > > The CLIC also supports a new Selective Hardware Vectoring feature > that allow users to optimize each interrupt for either faster > res

Re: [RFC PATCH] Subject: [RFC PATCH] plugins: Passed the parsed arguments directly to plugins

2021-06-28 Thread Alex Bennée
Mahmoud Mandour writes: The subject got a bit mangled. I usually send single one off patches directly from the command line like this: git send-email --subject-prefix "RFC PATCH" HEAD^.. --to qemu HEAD^.. > Arguments were passed to plugins in the following form: > -plugin path/to/plugin

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-28 Thread wangyanan (Y)
On 2021/6/28 16:58, Andrew Jones wrote: On Mon, Jun 28, 2021 at 04:43:05PM +0800, wangyanan (Y) wrote: Hi, On 2021/6/23 1:39, Daniel P. Berrangé wrote: On Tue, Jun 22, 2021 at 07:29:34PM +0200, Andrew Jones wrote: On Tue, Jun 22, 2021 at 06:14:25PM +0100, Daniel P. Berrangé wrote: On Tue, Jun

Re: [RFC PATCH 03/11] hw/intc: Add CLIC device

2021-06-28 Thread LIU Zhiwei
On 2021/6/28 下午6:24, Frank Chang wrote: LIU Zhiwei mailto:zhiwei_...@c-sky.com>> 於 2021年4月9日 週五 下午3:57寫道: The Core-Local Interrupt Controller (CLIC) provides low-latency, vectored, pre-emptive interrupts for RISC-V systems. The CLIC also supports a new Selective Hardware Vectoring

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-28 Thread wangyanan (Y)
Hi Daniel, On 2021/6/22 22:28, Daniel P. Berrangé wrote: On Tue, Jun 22, 2021 at 03:15:18PM +0100, Peter Maydell wrote: On Tue, 22 Jun 2021 at 15:11, Daniel P. Berrangé wrote: The QEMU man page says this explicitly For the PC target, the number of cores per die, the nu

Re: [RFC PATCH 0/5] ebpf: Added ebpf helper for libvirtd.

2021-06-28 Thread Yuri Benditovich
On Wed, Jun 23, 2021 at 3:47 AM Jason Wang wrote: > > > 在 2021/6/22 下午5:09, Toke Høiland-Jørgensen 写道: > > Daniel P. Berrangé writes: > > > >> On Tue, Jun 22, 2021 at 10:25:19AM +0200, Toke Høiland-Jørgensen wrote: > >>> Jason Wang writes: > >>> > 在 2021/6/22 上午11:29, Yuri Benditovich 写道: >

Re: tests: ReverseDebugging_AArch64.test_aarch64_virt -> InvalidPacketError

2021-06-28 Thread Philippe Mathieu-Daudé
On 6/28/21 7:14 AM, Pavel Dovgalyuk wrote: > On 25.06.2021 20:01, Philippe Mathieu-Daudé wrote: >> Hi Pavel, >> >> FYI as of commit 050cee12315 ("Merge remote-tracking branch >> 'remotes/stsquad/tags/pull-testing-updates-250621-1' into staging") > > Doesn't it mean, that the real culprit is hidden

Re: [RFC PATCH 04/10] hw/sd: Introduce sd_cmd_handler type

2021-06-28 Thread Philippe Mathieu-Daudé
On 6/28/21 9:29 AM, Cédric Le Goater wrote: > On 6/24/21 4:22 PM, Philippe Mathieu-Daudé wrote: >> Add 2 command handler arrays in SDProto, for CMD and ACMD. >> Have sd_normal_command() / sd_app_command() use these arrays: >> if an command handler is registered, call it, otherwise fall >> back to c

Re: tests: ReverseDebugging_AArch64.test_aarch64_virt -> InvalidPacketError

2021-06-28 Thread Pavel Dovgalyuk
On 28.06.2021 14:20, Philippe Mathieu-Daudé wrote: On 6/28/21 7:14 AM, Pavel Dovgalyuk wrote: On 25.06.2021 20:01, Philippe Mathieu-Daudé wrote: Hi Pavel, FYI as of commit 050cee12315 ("Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-updates-250621-1' into staging") Doesn't i

Re: [PATCH v3 1/1] yank: Unregister function when using TLS migration

2021-06-28 Thread Dr. David Alan Gilbert
* Alexander Graf (ag...@csgraf.de) wrote: > > On 14.06.21 13:57, Dr. David Alan Gilbert wrote: > > cc'ing in qemu-stable - I think we'd probably want this on 6.0 > > (It's currently merged as 7de2e8565335c13fb3516cddbe2e40e366cce273 ). > > Although you'll probably also want the missing dependency

[PATCH 1/4] docs: fix typo s/Intel/AMD/ in CPU model notes

2021-06-28 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- docs/system/cpu-models-x86.rst.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system/cpu-models-x86.rst.inc b/docs/system/cpu-models-x86.rst.inc index f40ee03ecc..9119f5dff5 100644 --- a/docs/system/cpu-models-x86.rst.inc +++ b/

[PATCH 0/4] docs: improve -smp documentation

2021-06-28 Thread Daniel P . Berrangé
This is a spin off from this thread: https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg06135.html to improve the documentation of the current behaviour of -smp arg. In that thread it is suggested that we change the behaviour to prefer use of cores over sockets, when topology is omitted.

[PATCH 2/4] qemu-options: re-arrange CPU topology options

2021-06-28 Thread Daniel P . Berrangé
The list of CPU topology options are presented in a fairly arbitrary order currently. Re-arrange them so that they're ordered from largest to smallest unit Signed-off-by: Daniel P. Berrangé --- qemu-options.hx | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/qemu-optio

[PATCH 3/4] qemu-options: tweak to show that CPU count is optional

2021-06-28 Thread Daniel P . Berrangé
The initial CPU count number is not required, if any of the topology options are given, since it can be computed. Signed-off-by: Daniel P. Berrangé --- qemu-options.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index aa33dfdcfd..5871

[PATCH 4/4] qemu-options: rewrite help for -smp options

2021-06-28 Thread Daniel P . Berrangé
The -smp option help is peculiarly specific about mentioning the CPU upper limits, but these are wrong. The "PC" target has varying max CPU counts depending on the machine type picked. Notes about guest OS limits are inappropriate for QEMU docs. There are way too many machine types for it to be pra

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-28 Thread Daniel P . Berrangé
On Mon, Jun 28, 2021 at 07:14:02PM +0800, wangyanan (Y) wrote: > Hi Daniel, > > On 2021/6/22 22:28, Daniel P. Berrangé wrote: > > On Tue, Jun 22, 2021 at 03:15:18PM +0100, Peter Maydell wrote: > > > On Tue, 22 Jun 2021 at 15:11, Daniel P. Berrangé > > > wrote: > > > > The QEMU man page says this

Re: [PATCH 0/2] introduce QEMU_AUTO_VFREE

2021-06-28 Thread Vladimir Sementsov-Ogievskiy
28.06.2021 13:08, Kevin Wolf wrote: Am 23.06.2021 um 12:34 hat Kevin Wolf geschrieben: Am 19.06.2021 um 16:21 hat Vladimir Sementsov-Ogievskiy geschrieben: Hi all! There is a good movement to use g_autofree macro, that helps to automatically call g_free on exit from code block. We lack simila

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-28 Thread wangyanan (Y)
On 2021/6/28 19:31, Daniel P. Berrangé wrote: On Mon, Jun 28, 2021 at 07:14:02PM +0800, wangyanan (Y) wrote: Hi Daniel, On 2021/6/22 22:28, Daniel P. Berrangé wrote: On Tue, Jun 22, 2021 at 03:15:18PM +0100, Peter Maydell wrote: On Tue, 22 Jun 2021 at 15:11, Daniel P. Berrangé wrote: The

Re: [PATCH v2] ui/cocoa: Use NSWindow's ability to resize

2021-06-28 Thread Akihiko Odaki
2021年6月28日(月) 17:57 BALATON Zoltan : > > On Mon, 28 Jun 2021, Akihiko Odaki wrote: > > This change brings two new features: > > - The window will be resizable if "Zoom To Fit" is eanbled > > - The window can be made full screen by clicking full screen button > > provided by the platform. (The left

[PATCH 01/20] target/loongarch: Add README

2021-06-28 Thread Song Gao
This patch give an introduction to the LoongArch target. Signed-off-by: Song Gao --- MAINTAINERS | 5 + target/loongarch/README | 16 2 files changed, 21 insertions(+) create mode 100644 target/loongarch/README diff --git a/MAINTAINERS b/MAINTAINERS index 3ff5

[PATCH 02/20] target/loongarch: Add CSR registers definition

2021-06-28 Thread Song Gao
This patch add basic CSR registers definition. The CSR registers definition copy from kernel arch/loongarch/include/asm/loongarchregs.h. Signed-off-by: Song Gao --- target/loongarch/cpu-csr.h | 724 + 1 file changed, 724 insertions(+) create mode 100

[PATCH 15/20] target/loongarch: Add floating point conversion instruction translation

2021-06-28 Thread Song Gao
This patch implement floating point conversion instruction translation. This includes: - FCVT.S.D, FCVT.D.S - FFINT.{S/D}.{W/L}, FTINT.{W/L}.{S/D} - FTINT{RM/RP/RZ/RNE}.{W/L}.{S/D} - FRINT.{S/D} Signed-off-by: Song Gao --- target/loongarch/fpu_helper.c | 362

[PATCH 00/20] Add LoongArch linux-user emulation support

2021-06-28 Thread Song Gao
Hi, This series adds linux-user emulation support for LoongArch. Patch 1 add an introduction to LoongArch. Patches 2-5 adds LoongArch basic definition. Patches 6-18 implements user mode instruction emulation. Patche 19 add support for disassembling via option '-d in_asm' Patch 20 add files to lin

[PATCH 03/20] target/loongarch: Add core definition

2021-06-28 Thread Song Gao
This patch add target state header,target definitions and initialization routines. Signed-off-by: Song Gao --- target/loongarch/cpu-param.h | 21 ++ target/loongarch/cpu-qom.h | 41 target/loongarch/cpu.c | 451 +++ target/loongarch/cpu.h

[PATCH 09/20] target/loongarch: Add fixed point bit instruction translation

2021-06-28 Thread Song Gao
This patch implement fixed point bit instruction translation. This includes: - EXT.W.{B/H} - CL{O/Z}.{W/D}, CT{O/Z}.{W/D} - BYTEPICK.{W/D} - REVB.{2H/4H/2W/D} - REVH.{2W/D} - BITREV.{4B/8B}, BITREV.{W/D} - BSTRINS.{W/D}, BSTRPICK.{W/D} - MASKEQZ, MASKNEZ Signed-off-by: Song Gao --- target/loong

[PATCH 14/20] target/loongarch: Add floating point comparison instruction translation

2021-06-28 Thread Song Gao
This patch implement floating point comparison instruction translation. This includes: - FCMP.cond.{S/D} Signed-off-by: Song Gao --- target/loongarch/fpu_helper.c | 613 ++ target/loongarch/helper.h | 49 target/loongarch/insns.decode | 10 + t

[PATCH 04/20] target/loongarch: Add interrupt handling support

2021-06-28 Thread Song Gao
This patch introduces functions loongarch_cpu_do_interrupt() and loongarch_cpu_exec_interrupt() Signed-off-by: Song Gao --- target/loongarch/cpu.c | 23 +++ target/loongarch/internal.h | 24 2 files changed, 47 insertions(+) diff --git a/target/

[PATCH 18/20] target/loongarch: Add branch instruction translation

2021-06-28 Thread Song Gao
This patch implement branch instruction translation. This includes: - BEQ, BNE, BLT[U], BGE[U] - BEQZ, BNEZ - B - BL - JIRL - BCEQZ, BCNEZ Signed-off-by: Song Gao --- target/loongarch/insns.decode | 30 target/loongarch/instmap.h| 13 + target/loongarch/trans.inc.c | 110

[PATCH 11/20] target/loongarch: Add fixed point atomic instruction translation

2021-06-28 Thread Song Gao
This patch implement fixed point atomic instruction translation. This includes: - LL.{W/D}, SC.{W/D} - AM{SWAP/ADD/AND/OR/XOR/MAX/MIN}[_DB].{W/D} - AM{MAX/MIN}[_DB].{WU/DU} Signed-off-by: Song Gao --- target/loongarch/insns.decode | 44 target/loongarch/instmap.h| 2 + targe

[PATCH 08/20] target/loongarch: Add fixed point shift instruction translation

2021-06-28 Thread Song Gao
This patch implement fixed point shift instruction translation. This includes: - SLL.W, SRL.W, SRA.W, ROTR.W - SLLI.W, SRLI.W, SRAI.W, ROTRI.W - SLL.D, SRL.D, SRA.D, ROTR.D - SLLI.D, SRLI.D, SRAI.D, ROTRI.D Signed-off-by: Song Gao --- target/loongarch/insns.decode | 26 target/loongar

[PATCH 13/20] target/loongarch: Add floating point arithmetic instruction translation

2021-06-28 Thread Song Gao
This patch implement floating point arithmetic instruction translation. This includes: - F{ADD/SUB/MUL/DIV}.{S/D} - F{MADD/MSUB/NMADD/NMSUB}.{S/D} - F{MAX/MIN}.{S/D} - F{MAXA/MINA}.{S/D} - F{ABS/NEG}.{S/D} - F{SQRT/RECIP/RSQRT}.{S/D} - F{SCALEB/LOGB/COPYSIGN}.{S/D} - FCLASS.{S/D} Signed-off-by: S

[PATCH v2 2/2] block/commit: use QEMU_AUTO_VFREE

2021-06-28 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/commit.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/block/commit.c b/block/commit.c index b7f0c7c061..42792b4556 100644 --- a/block/commit.c +++ b/block/commit.c @@ -119,24 +119,24 @@ static

[PATCH 12/20] target/loongarch: Add fixed point extra instruction translation

2021-06-28 Thread Song Gao
This patch implement fixed point extra instruction translation. This includes: - CRC[C].W.{B/H/W/D}.W - SYSCALL - BREAK - ASRT{LE/GT}.D - RDTIME{L/H}.W, RDTIME.D - CPUCFG Signed-off-by: Song Gao --- target/loongarch/helper.h | 4 ++ target/loongarch/insns.decode | 25 ++ target/l

[PATCH 07/20] target/loongarch: Add fixed point arithmetic instruction translation

2021-06-28 Thread Song Gao
This patch implement fixed point arithemtic instruction translation. This includes: - ADD.{W/D}, SUB.{W/D} - ADDI.{W/D}, ADDU16ID - ALSL.{W[U]/D} - LU12I.W, LU32I.D LU52I.D - SLT[U], SLT[U]I - PCADDI, PCADDU12I, PCADDU18I, PCALAU12I - AND, OR, NOR, XOR, ANDN, ORN - MUL.{W/D}, MULH.{W[U]/D[U]} - MU

[PATCH 17/20] target/loongarch: Add floating point load/store instruction translation

2021-06-28 Thread Song Gao
This patch implement floating point load/store instruction translation. This includes: - FLD.{S/D}, FST.{S/D} - FLDX.{S/D}, FSTX.{S/D} - FLD{GT/LE}.{S/D}, FST{GT/LE}.{S/D} Signed-off-by: Song Gao --- target/loongarch/insns.decode | 24 + target/loongarch/instmap.h| 17 +++ tar

[PATCH 16/20] target/loongarch: Add floating point move instruction translation

2021-06-28 Thread Song Gao
This patch implement floationg point move instruction translation. This includes: - FMOV.{S/D} - FSEL - MOVGR2FR.{W/D}, MOVGR2FRH.W - MOVFR2GR.{S/D}, MOVFRH2GR.S - MOVGR2FCSR, MOVFCSR2GR - MOVFR2CF, MOVCF2FR - MOVGR2CF, MOVCF2GR Signed-off-by: Song Gao --- target/loongarch/fpu_helper.c | 80 ++

[PATCH 10/20] target/loongarch: Add fixed point load/store instruction translation

2021-06-28 Thread Song Gao
This patch implement fixed point load/store instruction translation. This includes: - LD.{B[U]/H[U]/W[U]/D}, ST.{B/H/W/D} - LDX.{B[U]/H[U]/W[U]/D}, STX.{B/H/W/D} - LDPTR.{W/D}, STPTR.{W/D} - PRELD, PRELDX - LD{GT/LE}.{B/H/W/D}, ST{GT/LE}.{B/H/W/D} - DBAR, IBAR Signed-off-by: Song Gao --- target

[PATCH 06/20] target/loongarch: Add main translation routines

2021-06-28 Thread Song Gao
This patch add main translation routines and basic functions for translation. Signed-off-by: Song Gao --- target/loongarch/helper.h| 10 + target/loongarch/op_helper.c | 28 +++ target/loongarch/translate.c | 537 +++ target/loongarch/translate.h |

[PATCH 20/20] target/loongarch: Add linux-user emulation support

2021-06-28 Thread Song Gao
Add files to linux-user/loongarch64 Add file to default-configs Add loongarch to target/meson.build Signed-off-by: Song Gao --- MAINTAINERS| 1 + default-configs/targets/loongarch64-linux-user.mak | 4 + include/elf.h

Re: [PATCH 2/4] qemu-options: re-arrange CPU topology options

2021-06-28 Thread wangyanan (Y)
On 2021/6/28 19:30, Daniel P. Berrangé wrote: The list of CPU topology options are presented in a fairly arbitrary order currently. Re-arrange them so that they're ordered from largest to smallest unit Signed-off-by: Daniel P. Berrangé --- qemu-options.hx | 8 1 file changed, 4 in

[PATCH 19/20] target/loongarch: Add disassembler

2021-06-28 Thread Song Gao
This patch add support for disassembling via option '-d in_asm'. Signed-off-by: Song Gao --- MAINTAINERS |1 + disas/loongarch.c | 2528 +++ disas/meson.build |1 + include/disas/dis-asm.h |2 + meson.build

[PATCH v2 1/2] introduce QEMU_AUTO_VFREE

2021-06-28 Thread Vladimir Sementsov-Ogievskiy
Introduce a convenient macro, that works for qemu_memalign() like g_autofree works with g_malloc. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/qemu/osdep.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 0a54bf7be8

[PATCH v2 0/2] introduce QEMU_AUTO_VFREE

2021-06-28 Thread Vladimir Sementsov-Ogievskiy
Hi all! There is a good movement to use g_autofree macro, that helps to automatically call g_free on exit from code block. We lack similar possibility for qemu_memalign() functions family. Let's add, it seems rather simple with help of "cleanup" attribute. v2: rewrite 01 (as first version was ju

Re: [PATCH 3/4] qemu-options: tweak to show that CPU count is optional

2021-06-28 Thread wangyanan (Y)
On 2021/6/28 19:30, Daniel P. Berrangé wrote: The initial CPU count number is not required, if any of the topology options are given, since it can be computed. Signed-off-by: Daniel P. Berrangé --- qemu-options.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu

[PATCH 05/20] target/loongarch: Add memory management support

2021-06-28 Thread Song Gao
This patch introduces one memory-management-related functions - loongarch_cpu_tlb_fill() Signed-off-by: Song Gao --- target/loongarch/cpu.c| 1 + target/loongarch/internal.h | 9 target/loongarch/tlb_helper.c | 109 ++ 3 files changed, 1

[PATCH v7 02/16] python: Reduce strictness of pylint's duplicate-code check

2021-06-28 Thread Emanuele Giuseppe Esposito
From: John Snow Pylint prior to 2.8.3 (We pin at >= 2.8.0) includes function and method signatures as part of its duplicate checking algorithm. This check does not listen to pragmas, so the only way to disable it is to turn it off completely or increase the minimum duplicate lines so that it does

[PATCH v7 00/16] qemu_iotests: improve debugging options

2021-06-28 Thread Emanuele Giuseppe Esposito
This series adds the option to attach gdbserver and valgrind to the QEMU binary running in qemu_iotests. It also allows to redirect QEMU binaries output of the python tests to the stdout, instead of a log file. Patches 1-9 introduce the -gdb option to both python and bash tests, 10-14 extend the

[PATCH v7 04/16] docs/devel/testing: add debug section to the QEMU iotests chapter

2021-06-28 Thread Emanuele Giuseppe Esposito
Introduce the "Debugging a test case" section, in preparation to the additional flags that will be added in the next patches. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- docs/devel/testing.rst | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v7 05/16] qemu-iotests: add option to attach gdbserver

2021-06-28 Thread Emanuele Giuseppe Esposito
Define -gdb flag and GDB_OPTIONS environment variable to python tests to attach a gdbserver to each qemu instance. This patch only adds and parses this flag, it does not yet add the implementation for it. if -gdb is not provided but $GDB_OPTIONS is set, ignore the environment variable. Signed-off

[PATCH v7 03/16] python: qemu: pass the wrapper field from QEMUQtestmachine to QEMUMachine

2021-06-28 Thread Emanuele Giuseppe Esposito
Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Reviewed-by: Max Reitz --- python/qemu/machine/qtest.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/python/qemu/machine/qtest.py b/python/qemu/machine/qtest.py

[PATCH v7 06/16] qemu-iotests: delay QMP socket timers

2021-06-28 Thread Emanuele Giuseppe Esposito
Attaching gdbserver implies that the qmp socket should wait indefinitely for an answer from QEMU. Signed-off-by: Emanuele Giuseppe Esposito --- tests/qemu-iotests/iotests.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotest

[PATCH v7 11/16] qemu-iotests: extend QMP socket timeout when using valgrind

2021-06-28 Thread Emanuele Giuseppe Esposito
As with gdbserver, valgrind delays the test execution, so the default QMP socket timeout and the generic class Timeout in iotests.py timeouts too soon. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 6 +++--- 1 file change

[PATCH v7 01/16] python: qemu: add timer parameter for qmp.accept socket

2021-06-28 Thread Emanuele Giuseppe Esposito
Also add a new _qmp_timer field to the QEMUMachine class. Let's change the default socket timeout to None, so that if a subclass needs to add a timer, it can be done by modifying this private field. At the same time, restore the timer to be 15 seconds in iotests.py, to give an upper bound to the

[PATCH v7 12/16] qemu-iotests: allow valgrind to read/delete the generated log file

2021-06-28 Thread Emanuele Giuseppe Esposito
When using -valgrind on the script tests, it generates a log file in $TEST_DIR that is either read (if valgrind finds problems) or otherwise deleted. Provide the same exact behavior when using -valgrind on the python tests. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov

[PATCH v7 14/16] docs/devel/testing: add -valgrind option to the debug section of QEMU iotests

2021-06-28 Thread Emanuele Giuseppe Esposito
Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- docs/devel/testing.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index 8b24e6fb47..fa85592a38 100644 --- a/docs/devel/t

[PATCH v7 07/16] qemu_iotests: insert gdbserver command line as wrapper for qemu binary

2021-06-28 Thread Emanuele Giuseppe Esposito
Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index e176a84620..e7e3d92d3e 100644 --- a/test

[PATCH v7 13/16] qemu-iotests: insert valgrind command line as wrapper for qemu binary

2021-06-28 Thread Emanuele Giuseppe Esposito
If -gdb and -valgrind are both defined, return an error. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iote

[PATCH v7 08/16] qemu-iotests: add gdbserver option to script tests too

2021-06-28 Thread Emanuele Giuseppe Esposito
Remove read timer in test script when GDB_OPTIONS are set, so that the bash tests won't timeout while running gdb. The only limitation here is that running a script with gdbserver will make the test output mismatch with the expected results, making the test fail. Signed-off-by: Emanuele Giuseppe

[PATCH v7 16/16] docs/devel/testing: add -p option to the debug section of QEMU iotests

2021-06-28 Thread Emanuele Giuseppe Esposito
Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- docs/devel/testing.rst | 4 1 file changed, 4 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index fa85592a38..28a0b37b84 100644 --- a/docs/devel/testing.rst +++ b/docs/devel

[PATCH v7 09/16] docs/devel/testing: add -gdb option to the debugging section of QEMU iotests

2021-06-28 Thread Emanuele Giuseppe Esposito
Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- docs/devel/testing.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index 9d6a8f8636..8b24e6fb47 100644 --- a/docs/devel/testing.rst +++ b/d

[PATCH v7 15/16] qemu-iotests: add option to show qemu binary logs on stdout

2021-06-28 Thread Emanuele Giuseppe Esposito
Using the flag -p, allow the qemu binary to print to stdout. Also create the common function _close_qemu_log_file() to avoid accessing machine.py private fields directly and have duplicate code. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- python/qemu

[PATCH v7 10/16] qemu-iotests: extend the check script to prepare supporting valgrind for python tests

2021-06-28 Thread Emanuele Giuseppe Esposito
Currently, the check script only parses the option and sets the VALGRIND_QEMU environmental variable to "y". Add another local python variable that prepares the command line, identical to the one provided in the test scripts. Because the python script does not know in advance the valgrind PID to a

[PATCH] ui/cocoa: Update the state if absolute gets disabled

2021-06-28 Thread Akihiko Odaki
ui/cocoa used to update the internal state corresponding to qemu_input_is_absolute only when it becomes true. Use qemu_add_mouse_mode_change_notifier to get notified also when it becomes false. Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 31 ++- 1 file changed, 18 i

Re: [RFC PATCH 03/11] hw/intc: Add CLIC device

2021-06-28 Thread LIU Zhiwei
On 2021/6/28 下午6:16, Frank Chang wrote: LIU Zhiwei mailto:zhiwei_...@c-sky.com>> 於 2021年4月9日 週五 下午3:57寫道: The Core-Local Interrupt Controller (CLIC) provides low-latency, vectored, pre-emptive interrupts for RISC-V systems. The CLIC also supports a new Selective Hardware Vectoring

Re: [PATCH] target/s390x: Fix CC set by CONVERT TO FIXED/LOGICAL

2021-06-28 Thread Ulrich Weigand
On Fri, Jun 25, 2021 at 06:19:48PM -0700, Richard Henderson wrote: > On 6/23/21 7:50 AM, Ulrich Weigand wrote: > >@@ -506,6 +534,7 @@ uint64_t HELPER(cgeb)(CPUS390XState *env, uint64_t v2, > >uint32_t m34) > > { > > int old_mode = s390_swap_bfp_rounding_mode(env, round_from_m34(m34)); > >

Re: [PULL 00/15] MIPS patches for 2021-06-25

2021-06-28 Thread Peter Maydell
On Fri, 25 Jun 2021 at 11:08, Philippe Mathieu-Daudé wrote: > > MIME-Version: 1.0 > Content-Type: text/plain; charset="utf-8" > Content-Transfer-Encoding: 8bit > > The following changes since commit d0ac9a61474cf594d19082bc8976247e984ea9a3: > > Merge remote-tracking branch > 'remotes/thuth-gitl

Re: [PATCH v2] hw/audio/sb16: Restrict I/O sampling rate range for command 41h/42h

2021-06-28 Thread Stefan Hajnoczi
On Thu, Jun 24, 2021 at 10:44:47AM +0800, Qiang Liu wrote: > The I/O sampling rate range is enforced to 5000 to 45000HZ according to > commit a2cd86a9. Setting I/O sampling rate with command 41h/42h, a guest > user can break this assumption and trigger an assertion in audio_calloc > via command 0xd

Re: [PATCH 0/2] pc: acpi: revert back to 5.2 PCI slot enumeration

2021-06-28 Thread Stefan Hajnoczi
On Thu, Jun 24, 2021 at 04:42:26PM -0400, Igor Mammedov wrote: > Commit b7f23f62e40 (pci: acpi: add _DSM method to PCI devices), > regressed network interface naming for Linux guests in some cases. > This reverts PCI slot enumeration to its state before 6.0. > For details see 2/3 patch. > > Thanks

Re: [PATCH v3 1/1] yank: Unregister function when using TLS migration

2021-06-28 Thread Alexander Graf
On 28.06.21 13:28, Dr. David Alan Gilbert wrote: > * Alexander Graf (ag...@csgraf.de) wrote: >> On 14.06.21 13:57, Dr. David Alan Gilbert wrote: >>> cc'ing in qemu-stable - I think we'd probably want this on 6.0 >>> (It's currently merged as 7de2e8565335c13fb3516cddbe2e40e366cce273 ). >>> Althoug

  1   2   3   4   >