On Mon, Jun 28, 2021 at 07:14:02PM +0800, wangyanan (Y) wrote: > Hi Daniel, > > On 2021/6/22 22:28, Daniel P. Berrangé wrote: > > On Tue, Jun 22, 2021 at 03:15:18PM +0100, Peter Maydell wrote: > > > On Tue, 22 Jun 2021 at 15:11, Daniel P. Berrangé <berra...@redhat.com> > > > wrote: > > > > The QEMU man page says this explicitly > > > > > > > > For the PC target, the number of cores per die, the > > > > number of threads per cores, the number of dies per packages and > > > > the > > > > total number of sockets can be specified. Missing values will be > > > > computed. If any on the three values is given, the total number of > > > > CPUs n can be omitted. > > > Anybody feel like submitting a patch to fix the typo? Should read > > > "If any of"... > > Actually looking at the broader text for -smp, the whole thing just needs > > to be rewritten from scratch IMHO. I'll send a patch.... > Do you have any plan to rewrite the -smp text in qemu-options.hx recently? > > I suggest that we explain in more detail how the missing values will > be computed, so that qemu users can have a clear image of what a > -smp parameter collection would be parsed out if they are using an > incomplete cmdline and have read the man page. > > Also if we all agree to prefer cores over sockets for all arches since > machine type 6.2, I'll be glad to add this change for the man page > and update the parsing helpers in next version of this patch series.
I wrote a docs update on friday, which I've just sent out as a short patch series with yourself CC'd. I wrote it such that we can easily update it again, if we want to prefer cores over sockets. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
