Re: [PATCH RFC 1/6] i386/pc: Account IOVA reserved ranges above 4G boundary

2021-06-23 Thread Igor Mammedov
On Tue, 22 Jun 2021 16:49:00 +0100 Joao Martins wrote: > It is assumed that the whole GPA space is available to be > DMA addressable, within a given address space limit. Since > v5.4 based that is not true, and VFIO will validate whether > the selected IOVA is indeed valid i.e. not reserved by IO

Re: [PATCH v3 02/24] modules: collect module meta-data

2021-06-23 Thread Gerd Hoffmann
On Tue, Jun 22, 2021 at 06:03:45PM +0200, Paolo Bonzini wrote: > On 21/06/21 14:52, Gerd Hoffmann wrote: > > ninja: error: 'libui-curses.a.p/meson-generated_.._config-host.h.o', needed > > by 'ui-curses.modinfo.test', missing and no known rule to make it > > > > Hmm, not sure where this comes fro

Re: [PATCH RFC 0/6] i386/pc: Fix creation of >= 1Tb guests on AMD systems with IOMMU

2021-06-23 Thread David Edmondson
On Tuesday, 2021-06-22 at 15:16:29 -06, Alex Williamson wrote: >> Additionally, an alternative to hardcoded ranges as we do today, >> VFIO could advertise the platform valid IOVA ranges without >> necessarily >> requiring to have a PCI device added in the vfio container. T

Re: [PATCH] hw/arm/boot: Use NUMA node ID in memory node name

2021-06-23 Thread Andrew Jones
On Wed, Jun 23, 2021 at 02:43:49PM +1000, Gavin Shan wrote: > Hi Drew, > > On 6/22/21 5:13 PM, Andrew Jones wrote: > > On Tue, Jun 22, 2021 at 06:53:41PM +1000, Gavin Shan wrote: > > > On 6/3/21 2:48 PM, Gavin Shan wrote: > > > > On 6/2/21 9:36 PM, Andrew Jones wrote: > > > > > On Wed, Jun 02, 202

Re: [PATCH v3 3/5] ui: Create sync objects and fences only for blobs

2021-06-23 Thread Gerd Hoffmann
Hi, > dmabuf->buf.fd = res->dmabuf_fd; > +dmabuf->buf.blob = true; Do you actually need the 'blob' field? I think checking 'fd' instead should work too. take care, Gerd

Re: [PATCH] hw/arm/boot: Use NUMA node ID in memory node name

2021-06-23 Thread Andrew Jones
On Wed, Jun 23, 2021 at 10:07:36AM +0200, Andrew Jones wrote: > On Wed, Jun 23, 2021 at 02:43:49PM +1000, Gavin Shan wrote: > > Hi Drew, > > > > On 6/22/21 5:13 PM, Andrew Jones wrote: > > > On Tue, Jun 22, 2021 at 06:53:41PM +1000, Gavin Shan wrote: > > > > On 6/3/21 2:48 PM, Gavin Shan wrote: >

Re: [PATCH v3 4/5] ui/gtk-egl: Wait for the draw signal for dmabuf blobs

2021-06-23 Thread Gerd Hoffmann
On Mon, Jun 21, 2021 at 12:24:24PM -0700, Vivek Kasireddy wrote: > Instead of immediately drawing and submitting, queue and wait > for the draw signal if the dmabuf submitted is a blob. > > Cc: Gerd Hoffmann > Signed-off-by: Vivek Kasireddy Reviewed-by: Gerd Hoffmann

Re: [PATCH v3 2/5] ui/egl: Add egl helpers to help with synchronization

2021-06-23 Thread Gerd Hoffmann
On Mon, Jun 21, 2021 at 12:24:22PM -0700, Vivek Kasireddy wrote: > These egl helpers would be used for creating and waiting on > a sync object. > > Cc: Gerd Hoffmann > Signed-off-by: Vivek Kasireddy Reviewed-by: Gerd Hoffmann

Re: [PATCH v3 5/5] virtio-gpu: Add gl_flushed callback

2021-06-23 Thread Gerd Hoffmann
On Mon, Jun 21, 2021 at 12:24:25PM -0700, Vivek Kasireddy wrote: > Adding this callback provides a way to resume the processing of > cmds in fenceq and cmdq that were not processed because the UI > was waiting on a fence and blocked cmd processing. > > Cc: Gerd Hoffmann > Signed-off-by: Vivek Kas

[PATCH] sd: mmc: Fix SET_BLOCK_COUNT command argument

2021-06-23 Thread Cédric Le Goater
The number of blocks is defined in the lower bits [15:0] Signed-off-by: Cédric Le Goater --- hw/sd/sd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index a73d80661a10..a2553a502edc 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -1358,7 +1358,7 @@ stat

Re: [PATCH] sd: mmc: Fix SET_BLOCK_COUNT command argument

2021-06-23 Thread Bin Meng
On Wed, Jun 23, 2021 at 4:30 PM Cédric Le Goater wrote: > > The number of blocks is defined in the lower bits [15:0] I checked the physical spec v8.00 and it says bits [31:0] for CMD23 argument. > > Signed-off-by: Cédric Le Goater > --- > hw/sd/sd.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH v2 1/2] sev/i386: Introduce sev_add_kernel_loader_hashes for measured linux boot

2021-06-23 Thread Dov Murik
Hi Connor, +cc: Daniel On 23/06/2021 0:15, Connor Kuehl wrote: > On 6/21/21 2:05 PM, Dov Murik wrote: >> +static void fill_sev_hash_table_entry(SevHashTableEntry *e, const uint8_t >> *guid, >> + const uint8_t *hash, size_t hash_len) >> +{ >> +memcpy(e->gu

Re: RFC: Implementation of QMP documentation retrieval command

2021-06-23 Thread Stefan Hajnoczi
On Wed, Jun 23, 2021 at 12:27:55AM +0530, Niteesh G. S. wrote: > Hi Stefan, > On Tue, Jun 22, 2021 at 3:05 PM Stefan Hajnoczi wrote: > > > On Mon, Jun 21, 2021 at 11:56:30PM +0530, Niteesh G. S. wrote: > > > TLDR: The goal of this mail wasn't to review the dummy command I had > > posted > > > but

Re: [PATCH v2 1/2] sev/i386: Introduce sev_add_kernel_loader_hashes for measured linux boot

2021-06-23 Thread Daniel P . Berrangé
On Wed, Jun 23, 2021 at 11:41:56AM +0300, Dov Murik wrote: > Hi Connor, > > +cc: Daniel > > On 23/06/2021 0:15, Connor Kuehl wrote: > > On 6/21/21 2:05 PM, Dov Murik wrote: > >> +static void fill_sev_hash_table_entry(SevHashTableEntry *e, const uint8_t > >> *guid, > >> +

Re: [PATCH] sd: mmc: Fix SET_BLOCK_COUNT command argument

2021-06-23 Thread Philippe Mathieu-Daudé
On 6/23/21 10:39 AM, Bin Meng wrote: > On Wed, Jun 23, 2021 at 4:30 PM Cédric Le Goater wrote: >> >> The number of blocks is defined in the lower bits [15:0] > > I checked the physical spec v8.00 and it says bits [31:0] for CMD23 argument. Watch out, we only support 1-3: enum SDPhySpecification

[PATCH 1/2] usb-host: wire up timer for windows

2021-06-23 Thread Gerd Hoffmann
On windows we can't wait on file descriptors. Poll libusb using a timer instead. Fixes long-standing FIXME. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/431 Signed-off-by: Gerd Hoffmann --- hw/usb/host-libusb.c | 33 - 1 file changed, 32 insertions(+),

[PATCH 2/2] ci: add libusb for windows builds

2021-06-23 Thread Gerd Hoffmann
Add CI coverage for usb passthrough on windows. Signed-off-by: Gerd Hoffmann --- tests/docker/dockerfiles/fedora-win32-cross.docker | 1 + tests/docker/dockerfiles/fedora-win64-cross.docker | 1 + 2 files changed, 2 insertions(+) diff --git a/tests/docker/dockerfiles/fedora-win32-cross.docker

[PATCH 0/2] usb-host: windows support

2021-06-23 Thread Gerd Hoffmann
Gerd Hoffmann (2): usb-host: wire up timer for windows ci: add libusb for windows builds hw/usb/host-libusb.c | 33 ++- .../dockerfiles/fedora-win32-cross.docker | 1 + .../dockerfiles/fedora-win64-cross.docker | 1 + 3 files changed, 34 in

Re: [PATCH] sd: mmc: Fix SET_BLOCK_COUNT command argument

2021-06-23 Thread Cédric Le Goater
On 6/23/21 10:39 AM, Bin Meng wrote: > On Wed, Jun 23, 2021 at 4:30 PM Cédric Le Goater wrote: >> >> The number of blocks is defined in the lower bits [15:0] > > I checked the physical spec v8.00 and it says bits [31:0] for CMD23 argument. May be that's an eMMC thing. That's what I read from the

Re: [PATCH] sd: mmc: Fix SET_BLOCK_COUNT command argument

2021-06-23 Thread Cédric Le Goater
On 6/23/21 10:52 AM, Philippe Mathieu-Daudé wrote: > On 6/23/21 10:39 AM, Bin Meng wrote: >> On Wed, Jun 23, 2021 at 4:30 PM Cédric Le Goater wrote: >>> >>> The number of blocks is defined in the lower bits [15:0] >> >> I checked the physical spec v8.00 and it says bits [31:0] for CMD23 argument.

Re: [PATCH v2 2/1] qemu-img: Add "backing":true to unallocated map segments

2021-06-23 Thread Kevin Wolf
Am 22.06.2021 um 18:56 hat Nir Soffer geschrieben: > On Tue, Jun 22, 2021 at 6:38 PM Kevin Wolf wrote: > > > > Am 11.06.2021 um 21:03 hat Eric Blake geschrieben: > > > To save the user from having to check 'qemu-img info --backing-chain' > > > or other followup command to determine which "depth":n

Re: [PATCH RFC 1/6] i386/pc: Account IOVA reserved ranges above 4G boundary

2021-06-23 Thread Igor Mammedov
On Tue, 22 Jun 2021 16:49:00 +0100 Joao Martins wrote: > It is assumed that the whole GPA space is available to be > DMA addressable, within a given address space limit. Since > v5.4 based that is not true, and VFIO will validate whether > the selected IOVA is indeed valid i.e. not reserved by IO

Re: [PATCH] sd: mmc: Fix SET_BLOCK_COUNT command argument

2021-06-23 Thread Bin Meng
On Wed, Jun 23, 2021 at 4:52 PM Philippe Mathieu-Daudé wrote: > > On 6/23/21 10:39 AM, Bin Meng wrote: > > On Wed, Jun 23, 2021 at 4:30 PM Cédric Le Goater wrote: > >> > >> The number of blocks is defined in the lower bits [15:0] > > > > I checked the physical spec v8.00 and it says bits [31:0] f

[PATCH 0/3] [RfC] build windows installers in ci

2021-06-23 Thread Gerd Hoffmann
Side product of making usb-host work on windows. I'll go disappear into my summer vacation soon, so posting my current state as RfC. If someone feels like picking this up feel free to do so. Otherwise I'll go continue this when I'm back, but it most likely wouldn't make it into the 6.1 release t

[PATCH 1/3] ci: build & store windows installer

2021-06-23 Thread Gerd Hoffmann
Build windows installer for qemu in gitlab CI, store the result as artifact. Signed-off-by: Gerd Hoffmann --- .gitlab-ci.d/crossbuild-template.yml | 5 + .gitlab-ci.d/crossbuilds.yml | 6 ++ tests/docker/dockerfiles/fedora-win64-cross.docker | 1 + 3 f

Re: [PATCH] sd: mmc: Fix SET_BLOCK_COUNT command argument

2021-06-23 Thread Bin Meng
On Wed, Jun 23, 2021 at 4:55 PM Cédric Le Goater wrote: > > On 6/23/21 10:39 AM, Bin Meng wrote: > > On Wed, Jun 23, 2021 at 4:30 PM Cédric Le Goater wrote: > >> > >> The number of blocks is defined in the lower bits [15:0] > > > > I checked the physical spec v8.00 and it says bits [31:0] for CMD

[PATCH 3/3] ci: build & store guest agent msi

2021-06-23 Thread Gerd Hoffmann
Build guest agent windows msi install package in gitlab CI, store the result as artifact. Signed-off-by: Gerd Hoffmann --- .gitlab-ci.d/crossbuild-template.yml | 3 ++- .gitlab-ci.d/crossbuilds.yml | 2 ++ tests/docker/dockerfiles/fedora-win32-cross.docker | 1

[PATCH 2/3] [hack] scripts/copy-dlls

2021-06-23 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- .gitlab-ci.d/crossbuild-template.yml | 3 +- scripts/copy-dlls| 56 2 files changed, 58 insertions(+), 1 deletion(-) create mode 100755 scripts/copy-dlls diff --git a/.gitlab-ci.d/crossbuild-template.yml b/.gitl

Re: [PATCH] sd: mmc: Fix SET_BLOCK_COUNT command argument

2021-06-23 Thread Cédric Le Goater
On 6/23/21 11:12 AM, Bin Meng wrote: > On Wed, Jun 23, 2021 at 4:55 PM Cédric Le Goater wrote: >> >> On 6/23/21 10:39 AM, Bin Meng wrote: >>> On Wed, Jun 23, 2021 at 4:30 PM Cédric Le Goater wrote: The number of blocks is defined in the lower bits [15:0] >>> >>> I checked the physical s

Re: [PATCH RFC 6/6] i386/pc: Add a machine property for AMD-only enforcing of valid IOVAs

2021-06-23 Thread Igor Mammedov
On Tue, 22 Jun 2021 16:49:05 +0100 Joao Martins wrote: > The added enforcing is only relevant in the case of AMD where the range > right before the 1TB is restricted and cannot be DMA mapped by the > kernel consequently leading to IOMMU INVALID_DEVICE_REQUEST or possibly > other kinds of IOMMU ev

Re: [PATCH v4 0/2] Gitlab: Add issue templates

2021-06-23 Thread Alex Bennée
John Snow writes: > Add "Bug" and "Feature Request" templates to the Gitlab interface to > help improve the quality of newly reported issues. > > To see what this looks like, I've temporarily allowed my Gitlab fork to > diverge with these files merged. See my fork's "new issue" page to see > i

Re: [PATCH v2 1/2] sev/i386: Introduce sev_add_kernel_loader_hashes for measured linux boot

2021-06-23 Thread Dov Murik
On 23/06/2021 11:49, Daniel P. Berrangé wrote: > On Wed, Jun 23, 2021 at 11:41:56AM +0300, Dov Murik wrote: ... >> >> Related: I wondered if I could replace HASH_SIZE in: >> >> >> /* hard code sha256 digest size */ >> #define HASH_SIZE 32 >> >> typedef struct QEMU_PACKED SevHashTableEntr

Re: Regarding commit a9bcedd (SD card size has to be power of 2)

2021-06-23 Thread Daniel P . Berrangé
On Mon, Jun 07, 2021 at 04:29:54PM +0800, Tom Yan wrote: > Hi philmd (and others), > > So I just noticed your commit of requiring the size of an emulated SD > card to be a power of 2, when I was trying to emulate one for an > actual one (well, it's a microSD, but still), as it errored out. > > Yo

Re: [PATCH RFC 0/6] i386/pc: Fix creation of >= 1Tb guests on AMD systems with IOMMU

2021-06-23 Thread Joao Martins
On 6/22/21 10:16 PM, Alex Williamson wrote: > On Tue, 22 Jun 2021 16:48:59 +0100 > Joao Martins wrote: > >> Hey, >> >> This series lets Qemu properly spawn i386 guests with >= 1Tb with VFIO, >> particularly >> when running on AMD systems with an IOMMU. >> >> Since Linux v5.4, VFIO validates whet

Re: [PATCH RFC 1/6] i386/pc: Account IOVA reserved ranges above 4G boundary

2021-06-23 Thread Joao Martins
On 6/23/21 8:11 AM, Igor Mammedov wrote: > On Tue, 22 Jun 2021 16:49:00 +0100 > Joao Martins wrote: > >> It is assumed that the whole GPA space is available to be >> DMA addressable, within a given address space limit. Since >> v5.4 based that is not true, and VFIO will validate whether >> the se

[PATCH V9 0/6] Add passthrough support to object with network processing function

2021-06-23 Thread Zhang Chen
This series add passthrough support frame to object with network processing function. The first object is colo-compare. Current colo-compare and net-filters attached on chardev or netdev. It still need more fine-grained network control based on IPFlowSpec. Due to some real user scenarios don't need

[PATCH V9 1/6] qapi/net: Add IPFlowSpec and QMP command for filter passthrough

2021-06-23 Thread Zhang Chen
Since the real user scenario does not need to monitor all traffic. Add passthrough-filter-add and passthrough-filter-del to maintain a network passthrough list in object with network packet processing function. Add IPFlowSpec struct for all QMP commands. Most the fields of IPFlowSpec are optional,e

[PATCH V9 3/6] hmp-commands: Add new HMP command for filter passthrough

2021-06-23 Thread Zhang Chen
Add hmp_passthrough_filter_add and hmp_passthrough_filter_del make user can maintain object network passthrough list in human monitor Signed-off-by: Zhang Chen --- hmp-commands.hx | 26 +++ include/monitor/hmp.h | 2 ++ monitor/hmp-cmds.c| 76 ++

[PATCH V9 2/6] util/qemu-sockets.c: Add inet_parse_base to handle InetSocketAddressBase

2021-06-23 Thread Zhang Chen
No need to carry the flag all the time in many scenarios. Signed-off-by: Zhang Chen --- include/qemu/sockets.h | 1 + util/qemu-sockets.c| 14 ++ 2 files changed, 15 insertions(+) diff --git a/include/qemu/sockets.h b/include/qemu/sockets.h index 0c34bf2398..3a0f8fa8f2 100644 -

[PATCH V9 6/6] net/net.c: Add handler for passthrough filter command

2021-06-23 Thread Zhang Chen
Use the connection protocol,src port,dst port,src ip,dst ip as the key to passthrough certain network traffic in object with network packet processing function. Signed-off-by: Zhang Chen --- net/net.c | 199 +- 1 file changed, 197 insertions(+)

[PATCH V9 5/6] net/colo-compare: Add passthrough list to CompareState

2021-06-23 Thread Zhang Chen
Add passthrough list for each CompareState. Signed-off-by: Zhang Chen --- net/colo-compare.c | 28 net/colo-compare.h | 12 2 files changed, 40 insertions(+) diff --git a/net/colo-compare.c b/net/colo-compare.c index dcd24bb113..64e72c82f1 100644 --- a/

[PATCH V9 4/6] net/colo-compare: Move data structure and define to .h file.

2021-06-23 Thread Zhang Chen
Rename structure with COLO index and move it to .h file, It make other modules can reuse COLO code. Signed-off-by: Zhang Chen --- net/colo-compare.c | 132 - net/colo-compare.h | 86 + 2 files changed, 109 insertions(+), 10

Re: [PATCH RFC 1/6] i386/pc: Account IOVA reserved ranges above 4G boundary

2021-06-23 Thread Joao Martins
On 6/23/21 10:03 AM, Igor Mammedov wrote: > On Tue, 22 Jun 2021 16:49:00 +0100 > Joao Martins wrote: > >> It is assumed that the whole GPA space is available to be >> DMA addressable, within a given address space limit. Since >> v5.4 based that is not true, and VFIO will validate whether >> the s

Re: [PATCH RFC 6/6] i386/pc: Add a machine property for AMD-only enforcing of valid IOVAs

2021-06-23 Thread Joao Martins
On 6/23/21 10:18 AM, Igor Mammedov wrote: > On Tue, 22 Jun 2021 16:49:05 +0100 > Joao Martins wrote: > >> The added enforcing is only relevant in the case of AMD where the range >> right before the 1TB is restricted and cannot be DMA mapped by the >> kernel consequently leading to IOMMU INVALI

Re: [PATCH v4 6/6] block-copy: atomic .cancelled and .finished fields in BlockCopyCallState

2021-06-23 Thread Paolo Bonzini
On 22/06/21 12:39, Vladimir Sementsov-Ogievskiy wrote: 22.06.2021 13:20, Paolo Bonzini wrote: On 22/06/21 11:36, Vladimir Sementsov-Ogievskiy wrote: OK, I agree, let's keep it. You can also have a finished job, but get a stale value for error_is_read or ret.  The issue is not in getting the

Re: [PATCH] Update documentation to refer to new location for issues

2021-06-23 Thread Alex Bennée
Stefan Weil writes: > Signed-off-by: Stefan Weil Queued to testing/next as I'm putting together a PR, thanks. -- Alex Bennée

Re: [PATCH v5 1/7] hw/acpi/pcihp: Enhance acpi_pcihp_disable_root_bus() to support Q35

2021-06-23 Thread Marcel Apfelbaum
On Thu, Jun 17, 2021 at 10:08 PM Julia Suvorova wrote: > PCI Express does not allow hot-plug on pcie.0. Check for Q35 in > acpi_pcihp_disable_root_bus() to be able to forbid hot-plug using the > 'acpi-root-pci-hotplug' flag. > > Signed-off-by: Julia Suvorova > Reviewed-by: Igor Mammedov > --- >

[PATCH v1 0/8] misc fixes pre-PR (docs, plugins, tests)

2021-06-23 Thread Alex Bennée
Hi, This is a pre-PR series which collects up some miscellaneous random bits and pieces. This includes various documentation tweaks, a minor plugin helper API and a temporary suppression of the signals test for s390x/hppa to keep CI green. I should roll the PR on Friday morning so shout now if yo

[PATCH v1 6/8] tests/tcg: skip the signals test for hppa/s390x for now

2021-06-23 Thread Alex Bennée
There are fixes currently in flight but as this is getting in the way of a green CI we might as well skip for now. For reference the fix series are: linux-user: Move signal trampolines to new page 20210616011209.1446045-1-richard.hender...@linaro.org and linux-user: Load a vdso for x86_64

[PATCH v1 1/8] tests/acceptance: tweak the tcg/kvm tests for virt

2021-06-23 Thread Alex Bennée
Really it's only TCG that can select which GIC model you want, KVM guests should always be using the "host" version of the GIC for which QEMU already provides a handy shortcut. Make the KVM test use this and split the TCG test into it's two versions. Signed-off-by: Alex Bennée --- tests/acceptan

[PATCH v1 3/8] scripts/checkpatch: roll diff tweaking into checkpatch itself

2021-06-23 Thread Alex Bennée
Rather than relying on external tweaks lets just do it inside checkpatch's direct commitish handling which is QEMU specific code anyway. Suggested-by: Daniel P. Berrangé Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Reviewed-by: Willian Rampazzo

[PATCH v1 2/8] docs/devel: Add a single top-level header to MTTCG's doc

2021-06-23 Thread Alex Bennée
From: Luis Pires Without a single top-level header in the .rst file, the index ended up linking to all of the top-level headers separately. Now the index links to the top-level header at the beginning of the document and any inner headers are correctly linked as sub-items in the index. Signed-of

[PATCH v1 4/8] GitLab: Add "Bug" issue reporting template

2021-06-23 Thread Alex Bennée
From: John Snow Based loosely on libvirt's template, written by Peter Krempa. Signed-off-by: John Snow Reviewed-by: Alex Bennée Reviewed-by: Stefan Hajnoczi CC: Peter Krempa Message-Id: <20210607153155.1760158-2-js...@redhat.com> Signed-off-by: Alex Bennée --- .gitlab/issue_templates/bug.m

[PATCH v1 5/8] GitLab: Add "Feature Request" issue template.

2021-06-23 Thread Alex Bennée
From: John Snow Based on Peter Krempa's libvirt template, feature.md. Signed-off-by: John Snow Reviewed-by: Stefan Hajnoczi Reviewed-by: Thomas Huth Reviewed-by: Alex Bennée CC: Peter Krempa Message-Id: <20210607153155.1760158-3-js...@redhat.com> Signed-off-by: Alex Bennée --- .gitlab/iss

Re: [PATCH 0/2] introduce QEMU_AUTO_VFREE

2021-06-23 Thread Kevin Wolf
Am 19.06.2021 um 16:21 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all! > > There is a good movement to use g_autofree macro, that helps to > automatically call g_free on exit from code block. > > We lack similar possibility for qemu_memalign() functions family. Let's > add, it seems rathe

[PATCH v1 8/8] Update documentation to refer to new location for issues

2021-06-23 Thread Alex Bennée
From: Stefan Weil Signed-off-by: Stefan Weil Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20210619154253.553446-1...@weilnetz.de> Signed-off-by: Alex Bennée --- README.rst | 6 +++--- .github/lockdown.yml | 6 +++--- 2 files ch

[PATCH v1 7/8] plugins/api: expose symbol lookup to plugins

2021-06-23 Thread Alex Bennée
This is a quality of life helper for plugins so they don't need to re-implement symbol lookup when dumping an address. The strings are constant so don't need to be duplicated. One minor tweak is to return NULL instead of a zero length string to show lookup failed. Signed-off-by: Alex Bennée Messa

Re: [PATCH v5 2/7] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to Q35

2021-06-23 Thread Marcel Apfelbaum
On Thu, Jun 17, 2021 at 10:08 PM Julia Suvorova wrote: > Implement notifications and gpe to support q35 ACPI PCI hot-plug. > Use 0xcc4 - 0xcd7 range for 'acpi-pci-hotplug' io ports. > > Signed-off-by: Julia Suvorova > Reviewed-by: Igor Mammedov > --- > hw/i386/acpi-build.h| 4 > incl

Re: [PATCH v1 6/8] tests/tcg: skip the signals test for hppa/s390x for now

2021-06-23 Thread Cornelia Huck
On Wed, Jun 23 2021, Alex Bennée wrote: > There are fixes currently in flight but as this is getting in the way > of a green CI we might as well skip for now. For reference the fix > series are: > > linux-user: Move signal trampolines to new page > 20210616011209.1446045-1-richard.hender...@l

Re: [PATCH v5 3/7] hw/acpi/ich9: Enable ACPI PCI hot-plug

2021-06-23 Thread Marcel Apfelbaum
On Thu, Jun 17, 2021 at 10:08 PM Julia Suvorova wrote: > Add acpi_pcihp to ich9_pm as part of > 'acpi-pci-hotplug-with-bridge-support' option. Set default to false. > > Signed-off-by: Julia Suvorova > Reviewed-by: Igor Mammedov > --- > hw/i386/acpi-build.h | 1 + > include/hw/acpi/ich9.h |

Re: Regarding commit a9bcedd (SD card size has to be power of 2)

2021-06-23 Thread Philippe Mathieu-Daudé
Hi, On 6/23/21 11:28 AM, Daniel P. Berrangé wrote: > On Mon, Jun 07, 2021 at 04:29:54PM +0800, Tom Yan wrote: >> Hi philmd (and others), >> >> So I just noticed your commit of requiring the size of an emulated SD >> card to be a power of 2, when I was trying to emulate one for an >> actual one (we

Re: [PATCH] sd: mmc: Fix SET_BLOCK_COUNT command argument

2021-06-23 Thread Philippe Mathieu-Daudé
On 6/23/21 11:11 AM, Bin Meng wrote: > On Wed, Jun 23, 2021 at 4:52 PM Philippe Mathieu-Daudé > wrote: >> >> On 6/23/21 10:39 AM, Bin Meng wrote: >>> On Wed, Jun 23, 2021 at 4:30 PM Cédric Le Goater wrote: The number of blocks is defined in the lower bits [15:0] >>> >>> I checked the p

Re: [PATCH v5 4/7] hw/pci/pcie: Do not set HPC flag if acpihp is used

2021-06-23 Thread Marcel Apfelbaum
On Fri, Jun 18, 2021 at 12:02 AM Michael S. Tsirkin wrote: > On Thu, Jun 17, 2021 at 09:07:36PM +0200, Julia Suvorova wrote: > > Instead of changing the hot-plug type in _OSC register, do not > > set the 'Hot-Plug Capable' flag. This way guest will choose ACPI > > hot-plug if it is preferred and

Re: [PATCH v5 5/7] bios-tables-test: Allow changes in DSDT ACPI tables

2021-06-23 Thread Marcel Apfelbaum
On Thu, Jun 17, 2021 at 10:08 PM Julia Suvorova wrote: > All DSDT Q35 tables will be modified because ACPI hot-plug is enabled > by default. > > Signed-off-by: Julia Suvorova > Reviewed-by: Igor Mammedov > --- > tests/qtest/bios-tables-test-allowed-diff.h | 11 +++ > 1 file changed, 11

Re: [PATCH v5 6/7] hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35

2021-06-23 Thread Marcel Apfelbaum
On Thu, Jun 17, 2021 at 10:08 PM Julia Suvorova wrote: > Q35 has three different types of PCI devices hot-plug: PCIe Native, > SHPC Native and ACPI hot-plug. This patch changes the default choice > for cold-plugged bridges from PCIe Native to ACPI Hot-plug with > ability to use SHPC and PCIe Nati

Re: [PATCH v1 1/8] tests/acceptance: tweak the tcg/kvm tests for virt

2021-06-23 Thread Willian Rampazzo
On Wed, Jun 23, 2021 at 7:30 AM Alex Bennée wrote: > > Really it's only TCG that can select which GIC model you want, KVM > guests should always be using the "host" version of the GIC for which > QEMU already provides a handy shortcut. Make the KVM test use this and > split the TCG test into it's

Re: Regarding commit a9bcedd (SD card size has to be power of 2)

2021-06-23 Thread Michal Suchánek
On Wed, Jun 23, 2021 at 12:59:45PM +0200, Philippe Mathieu-Daudé wrote: > Hi, > > On 6/23/21 11:28 AM, Daniel P. Berrangé wrote: > > On Mon, Jun 07, 2021 at 04:29:54PM +0800, Tom Yan wrote: > >> Hi philmd (and others), > >> > >> So I just noticed your commit of requiring the size of an emulated SD

Re: [PATCH] block: BDRV_O_NO_IO for backing file on creation

2021-06-23 Thread Kevin Wolf
Am 22.06.2021 um 16:00 hat Max Reitz geschrieben: > When creating an image file with a backing file, we generally try to > open the backing file (unless -u was specified), mostly to verify that > it is there, but also to get the file size if none was specified for the > new image. > > For neither

Re: Regarding commit a9bcedd (SD card size has to be power of 2)

2021-06-23 Thread Daniel P . Berrangé
On Wed, Jun 23, 2021 at 12:59:45PM +0200, Philippe Mathieu-Daudé wrote: > Hi, > > On 6/23/21 11:28 AM, Daniel P. Berrangé wrote: > > On Mon, Jun 07, 2021 at 04:29:54PM +0800, Tom Yan wrote: > >> Hi philmd (and others), > >> > >> So I just noticed your commit of requiring the size of an emulated SD

Re: [PATCH RFC 1/6] i386/pc: Account IOVA reserved ranges above 4G boundary

2021-06-23 Thread Igor Mammedov
On Wed, 23 Jun 2021 10:37:38 +0100 Joao Martins wrote: > On 6/23/21 8:11 AM, Igor Mammedov wrote: > > On Tue, 22 Jun 2021 16:49:00 +0100 > > Joao Martins wrote: > > > >> It is assumed that the whole GPA space is available to be > >> DMA addressable, within a given address space limit. Since >

Re: [PATCH RFC 0/6] i386/pc: Fix creation of >= 1Tb guests on AMD systems with IOMMU

2021-06-23 Thread Igor Mammedov
On Wed, 23 Jun 2021 10:30:29 +0100 Joao Martins wrote: > On 6/22/21 10:16 PM, Alex Williamson wrote: > > On Tue, 22 Jun 2021 16:48:59 +0100 > > Joao Martins wrote: > > > >> Hey, > >> > >> This series lets Qemu properly spawn i386 guests with >= 1Tb with VFIO, > >> particularly > >> when runn

RE: [PATCH v5 06/14] target/hexagon: introduce new helper functions

2021-06-23 Thread Taylor Simpson
> -Original Message- > From: Alessandro Di Federico > Sent: Saturday, June 19, 2021 3:37 AM > To: qemu-devel@nongnu.org > Cc: Taylor Simpson ; Brian Cain > ; bab...@rev.ng; ni...@rev.ng; phi...@redhat.com; > richard.hender...@linaro.org; Alessandro Di Federico > Subject: [PATCH v5 06/14

Re: [PATCH RFC 1/6] i386/pc: Account IOVA reserved ranges above 4G boundary

2021-06-23 Thread Igor Mammedov
On Wed, 23 Jun 2021 10:51:59 +0100 Joao Martins wrote: > On 6/23/21 10:03 AM, Igor Mammedov wrote: > > On Tue, 22 Jun 2021 16:49:00 +0100 > > Joao Martins wrote: > > > >> It is assumed that the whole GPA space is available to be > >> DMA addressable, within a given address space limit. Since

[PULL 07/12] configure, meson: convert libtasn1 detection to meson

2021-06-23 Thread Paolo Bonzini
Make it depend on gnutls too, since it is only used as part of gnutls tests. Reviewed-by: Richard Henderson Reviewed-by: Daniel P. Berrangé Signed-off-by: Paolo Bonzini --- configure | 19 --- meson.build| 9 + tests/unit/meson.build | 2 +- 3

[PULL 00/12] Misc, mostly meson patches for 2021-06-23

2021-06-23 Thread Paolo Bonzini
The following changes since commit b22726abdfa54592d6ad88f65b0297c0e8b363e2: Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-6.1-pull-request' into staging (2021-06-22 16:07:53 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-ups

[PULL 01/12] target/i386: kvm: add support for TSC scaling

2021-06-23 Thread Paolo Bonzini
Linux 5.14 will add support for nested TSC scaling. Add the corresponding feature in QEMU; to keep support for existing kernels, do not add it to any processor yet. The handling of the VMCS enumeration MSR is ugly; once we have more than one case, we may want to add a table to check VMX features

[PULL 03/12] configure: drop unused variables for xts

2021-06-23 Thread Paolo Bonzini
All XTS configuration uses qemu_private_xts. Drop other variables as they have only ever been used to generate the summary (which has since been moved to meson.build). Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Daniel P. Berrangé Signed-off-by: Paolo Bonzin

qemu-devel@nongnu.org

2021-06-23 Thread Markus Armbruster
John Snow writes: > One of our Bite-Sized tasks on the wiki was to audit QEMU and, where > applicable, replace NULL with &error_abort. Context: NULL argument means "do not pass back an error object". This has two uses: 1. When the function permits detecting failure in another way (typically

[PULL 08/12] configure, meson: convert pam detection to meson

2021-06-23 Thread Paolo Bonzini
Reviewed-by: Daniel P. Berrangé Signed-off-by: Paolo Bonzini --- authz/meson.build | 2 +- configure | 38 -- meson.build| 30 +- meson_options.txt | 2 ++ tests/unit/meson.build | 2 +- 5 files

[PULL 10/12] configure, meson: convert libcacard detection to meson

2021-06-23 Thread Paolo Bonzini
Reviewed-by: Daniel P. Berrangé Signed-off-by: Paolo Bonzini --- configure | 28 hw/usb/meson.build | 2 +- meson.build| 9 + meson_options.txt | 2 ++ 4 files changed, 12 insertions(+), 29 deletions(-) diff --git a/configure b/configure

[PULL 02/12] meson: drop unused CONFIG_GCRYPT_HMAC

2021-06-23 Thread Paolo Bonzini
CONFIG_GCRYPT_HMAC has been removed now that all supported distros have it. Reviewed-by: Richard Henderson Reviewed-by: Daniel P. Berrangé Signed-off-by: Paolo Bonzini --- meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/meson.build b/meson.build index d8a92666fb..87147a5f3f 1006

[PULL 06/12] configure, meson: convert crypto detection to meson

2021-06-23 Thread Paolo Bonzini
Reviewed-by: Richard Henderson Reviewed-by: Daniel P. Berrangé Signed-off-by: Paolo Bonzini --- configure | 188 +++-- crypto/meson.build | 41 +++-- meson.build| 81 +- meson_options.txt | 6 ++ tests

[PULL 04/12] meson: remove preadv from summary

2021-06-23 Thread Paolo Bonzini
Meson is more verbose than the configure script; the outcome of the preadv test can be found in its output and it is not worth including it again in the summary. Reviewed-by: Daniel P. Berrangé Signed-off-by: Paolo Bonzini --- meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/meso

Re: [PATCH] hw/audio/sb16: Restrict I/O sampling rate range for command 41h/42h

2021-06-23 Thread Gerd Hoffmann
Hi, Applying: hw/audio/sb16: Restrict I/O sampling rate range for command 41h/42h error: corrupt patch at line 35 error: could not build fake ancestor > @@ -244,17 +261,7 @@ static void dma_cmd8 (SB16State *s, int mask, int > dma_len) This looks like your mailer mangled the patch. Can you rese

[PULL 05/12] tests: remove QCRYPTO_HAVE_TLS_TEST_SUPPORT

2021-06-23 Thread Paolo Bonzini
meson.build already decides whether it is possible to build the TLS test suite. There is no need to include that in the source as well. The dummy tests in fact are broken because they do not produce valid TAP output (empty output is rejected by scripts/tap-driver.pl). Cc: Daniel P. Berrangé Sign

[PULL 09/12] configure, meson: convert libusb detection to meson

2021-06-23 Thread Paolo Bonzini
Reviewed-by: Daniel P. Berrangé Signed-off-by: Paolo Bonzini --- configure | 27 --- hw/usb/meson.build | 2 +- meson.build| 11 +++ meson_options.txt | 2 ++ 4 files changed, 14 insertions(+), 28 deletions(-) diff --git a/configure b/configur

[PULL 11/12] configure, meson: convert libusbredir detection to meson

2021-06-23 Thread Paolo Bonzini
Reviewed-by: Daniel P. Berrangé Signed-off-by: Paolo Bonzini --- configure | 28 hw/usb/meson.build | 2 +- meson.build| 9 + meson_options.txt | 2 ++ 4 files changed, 12 insertions(+), 29 deletions(-) diff --git a/configure b/configure

[PULL 12/12] KVM: Fix dirty ring mmap incorrect size due to renaming accident

2021-06-23 Thread Paolo Bonzini
From: Peter Xu Found this when I wanted to try the per-vcpu dirty rate series out, then I found that it's not really working and it can quickly hang death a guest. I found strange errors (e.g. guest crash after migration) happens even without the per-vcpu dirty rate series. When merging dirty r

Re: [PATCH RFC 4/6] i386/pc: Keep PCI 64-bit hole within usable IOVA space

2021-06-23 Thread Igor Mammedov
On Tue, 22 Jun 2021 16:49:03 +0100 Joao Martins wrote: > pci_memory initialized by q35 and i440fx is set to a range > of 0 .. UINT64_MAX, and as a consequence when ACPI and pci-host > pick the hole64_start it does not account for allowed IOVA ranges. > > Rather than blindly returning, round up t

Re: [PATCH v3] Add display suboptions to man pages

2021-06-23 Thread Gerd Hoffmann
On Tue, Jun 01, 2021 at 07:41:18PM +0200, Ahmed Abouzied wrote: > From: Ahmed Abouzied > > Add display suboptions to man pages > > Updates man pages with the suboptions for the `-display`. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/128 > Buglink: https://bugs.launchpad.ne

Re: [PATCH v3] ui/gtk: New -display gtk option 'full-screen-on-monitor'.

2021-06-23 Thread Gerd Hoffmann
On Wed, Jun 23, 2021 at 04:27:44PM +0800, Khor, Swee Aun wrote: > This lets user select monitor number to display QEMU in full screen > with -display gtk,full-screen-on-monitor=. ../../ui/gtk.c: In function 'gtk_display_init': ../../ui/gtk.c:2300:25: error: format '%ld' expects argument of type 'l

[PATCH 2/3] hw/rx: rx62n switch renesas_timer.

2021-06-23 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato --- include/hw/rx/rx62n.h | 4 ++-- hw/rx/Kconfig | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/hw/rx/rx62n.h b/include/hw/rx/rx62n.h index 3ed80dba0d..c35bf3998c 100644 --- a/include/hw/rx/rx62n.h +++ b/include/hw/rx/rx62n.h

[PATCH 0/3] Integrate renesas MCU/SoC timer module

2021-06-23 Thread Yoshinori Sato
SH4 TMU and RX CMT have simler functions. Integrate the sh_timer and renesas_cmt. Yoshinori Sato (3): hw/timer: Add renesas_timer. hw/rx: rx62n switch renesas_timer. hw/sh4: sh7750 switch renesas_timer. include/hw/rx/rx62n.h| 4 +- include/hw/timer/renesas_timer.h | 89 +

[PATCH 3/3] hw/sh4: sh7750 switch renesas_timer.

2021-06-23 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato --- hw/sh4/sh7750.c | 32 +--- hw/sh4/Kconfig | 2 +- 2 files changed, 30 insertions(+), 4 deletions(-) diff --git a/hw/sh4/sh7750.c b/hw/sh4/sh7750.c index d53a436d8c..bbebac8083 100644 --- a/hw/sh4/sh7750.c +++ b/hw/sh4/sh7750.c @@ -3

[PATCH 1/3] hw/timer: Add renesas_timer.

2021-06-23 Thread Yoshinori Sato
Renesas MCU / SoC have timer modules with similar functionality. SH4-TMU 32bit count down timer. RX-CMT 16bit compare match timer. Signed-off-by: Yoshinori Sato --- include/hw/timer/renesas_timer.h | 89 ++ hw/timer/renesas_timer.c | 532 +++ hw/timer/Kco

Re: [PATCH v2] ui: Make the DisplayType enum entries conditional

2021-06-23 Thread Gerd Hoffmann
On Tue, Jun 15, 2021 at 11:04:39AM +0200, Thomas Huth wrote: > Libvirt's "domcapabilities" command has a way to state whether certain > graphic frontends are available in QEMU or not. Originally, libvirt > looked at the "--help" output of the QEMU binary to determine whether > SDL was available or

Re: [PATCH] ui/cocoa: Set UI information

2021-06-23 Thread Gerd Hoffmann
On Wed, Jun 16, 2021 at 11:19:10PM +0900, Akihiko Odaki wrote: > Signed-off-by: Akihiko Odaki > --- > ui/cocoa.m | 49 + > 1 file changed, 49 insertions(+) > > diff --git a/ui/cocoa.m b/ui/cocoa.m > index 995301502be..8b83f91723a 100644 > --- a/ui/

Re: [PATCH] ui/cocoa: Add clipboard support

2021-06-23 Thread Gerd Hoffmann
On Wed, Jun 16, 2021 at 11:19:54PM +0900, Akihiko Odaki wrote: > Signed-off-by: Akihiko Odaki Added to UI queue. thanks, Gerd

Re: [PATCH v2 1/1] input: Add lang1 and lang2 to QKeyCode

2021-06-23 Thread Gerd Hoffmann
On Thu, Jun 17, 2021 at 11:31:13AM +0900, Akihiko Odaki wrote: > lang1 and lang2 represents the keys with the same names in the > keyboard/keypad usage page (0x07) included in the "HID Usage Tables for > Universal Serial Bus (USB)" version 1.22. Although the keys are > described as "Hangul/English

Re: [PATCH] virtio-gpu: Call Virgl only in the main thread

2021-06-23 Thread Gerd Hoffmann
On Thu, Jun 17, 2021 at 08:35:20PM +0900, Akihiko Odaki wrote: > Virgl relies on callbacks provided by the OpenGL display, and such a > display may rely on eglMakeCurrent. eglMakeCurrent will fail if the > given context is current to some other thread. The easiest way to avoid > such a failure is t

  1   2   3   >