[PATCH qemu] spapr: tune rtas-size

2021-06-22 Thread Alexey Kardashevskiy
QEMU reserves space for RTAS via /rtas/rtas-size which tells the client how much space the RTAS requires to work which includes the RTAS binary blob implementing RTAS runtime. Because pseries supports FWNMI which requires plenty of space, QEMU reserves more than 2KB which is enough for the RTAS blo

Re: [PATCH V8 1/6] qapi/net: Add IPFlowSpec and QMP command for COLO passthrough

2021-06-22 Thread Jason Wang
在 2021/6/22 下午2:01, chen.zh...@intel.com 写道: On 6/21/21 7:30 PM, Dr. David Alan Gilbert wrote: * Markus Armbruster (arm...@redhat.com) wrote: Zhang Chen writes: Since the real user scenario does not need COLO to monitor all traffic. Add colo-passthrough-add and colo-passthrough-del to ma

Re: [PATCH V8 1/6] qapi/net: Add IPFlowSpec and QMP command for COLO passthrough

2021-06-22 Thread Jason Wang
在 2021/6/15 下午7:37, Zhang Chen 写道: Since the real user scenario does not need COLO to monitor all traffic. Add colo-passthrough-add and colo-passthrough-del to maintain a COLO network passthrough list. Add IPFlowSpec struct for all QMP commands. All the fields of IPFlowSpec are optional. Signe

Re: [PATCH] hw/arm/boot: Use NUMA node ID in memory node name

2021-06-22 Thread Andrew Jones
On Tue, Jun 22, 2021 at 06:53:41PM +1000, Gavin Shan wrote: > Hi Drew, > > On 6/3/21 2:48 PM, Gavin Shan wrote: > > On 6/2/21 9:36 PM, Andrew Jones wrote: > > > On Wed, Jun 02, 2021 at 11:09:32AM +1000, Gavin Shan wrote: > > > > On 6/1/21 5:50 PM, Andrew Jones wrote: > > > > > On Tue, Jun 01, 2021

Re: [RFC 0/3] qtest: pick tests that require KVM at runtime

2021-06-22 Thread Thomas Huth
On 16/06/2021 17.24, Igor Mammedov wrote: Sometimes it's necessary to execute a test that depends on KVM, however qtest is not aware if tested QEMU binary supports KVM on the host it the test is executed. For an example: test q35 machine with intel_iommu This test will run only is KVM is av

Re: [RFC 0/3] qtest: pick tests that require KVM at runtime

2021-06-22 Thread Philippe Mathieu-Daudé
On 6/22/21 9:20 AM, Thomas Huth wrote: > On 16/06/2021 17.24, Igor Mammedov wrote: >> >> Sometimes it's necessary to execute a test that depends on KVM, >> however qtest is not aware if tested QEMU binary supports KVM >> on the host it the test is executed. >> >> For an example: >>   test q35 machi

Re: [PATCH v2] block/nvme: Fix VFIO_MAP_DMA failed: No space left on device

2021-06-22 Thread Philippe Mathieu-Daudé
On 6/21/21 5:36 PM, Fam Zheng wrote: >> On 21 Jun 2021, at 16:13, Philippe Mathieu-Daudé wrote: >> On 6/21/21 3:18 PM, Fam Zheng wrote: On 21 Jun 2021, at 10:32, Philippe Mathieu-Daudé wrote: When the NVMe block driver was introduced (see commit bdd6a90a9e5, January 2018), Lin

Re: [PATCH qemu] spapr: tune rtas-size

2021-06-22 Thread Greg Kurz
On Tue, 22 Jun 2021 17:03:36 +1000 Alexey Kardashevskiy wrote: > QEMU reserves space for RTAS via /rtas/rtas-size which tells the client > how much space the RTAS requires to work which includes the RTAS binary > blob implementing RTAS runtime. Because pseries supports FWNMI which > requires plen

Re: [PATCH V8 1/6] qapi/net: Add IPFlowSpec and QMP command for COLO passthrough

2021-06-22 Thread chen.zh...@intel.com
On 6/22/21 3:04 PM, Jason Wang wrote: 在 2021/6/22 下午2:01, chen.zh...@intel.com 写道: On 6/21/21 7:30 PM, Dr. David Alan Gilbert wrote: * Markus Armbruster (arm...@redhat.com) wrote: Zhang Chen writes: Since the real user scenario does not need COLO to monitor all traffic. Add colo-passthrou

Re: [PATCH V8 1/6] qapi/net: Add IPFlowSpec and QMP command for COLO passthrough

2021-06-22 Thread chen.zh...@intel.com
On 6/22/21 3:05 PM, Jason Wang wrote: 在 2021/6/15 下午7:37, Zhang Chen 写道: Since the real user scenario does not need COLO to monitor all traffic. Add colo-passthrough-add and colo-passthrough-del to maintain a COLO network passthrough list. Add IPFlowSpec struct for all QMP commands. All the fi

Re: [PATCH qemu v21] spapr: Implement Open Firmware client interface

2021-06-22 Thread Alexey Kardashevskiy
On 6/18/21 20:13, BALATON Zoltan wrote: On Fri, 18 Jun 2021, Alexey Kardashevskiy wrote: On 6/17/21 21:29, BALATON Zoltan wrote: On Thu, 17 Jun 2021, Alexey Kardashevskiy wrote: On 17/06/2021 19:16, BALATON Zoltan wrote: On Thu, 17 Jun 2021, Alexey Kardashevskiy wrote: On 16/06/2021 20:34

Re: [RFC 0/3] qtest: pick tests that require KVM at runtime

2021-06-22 Thread Thomas Huth
On 22/06/2021 09.26, Philippe Mathieu-Daudé wrote: On 6/22/21 9:20 AM, Thomas Huth wrote: On 16/06/2021 17.24, Igor Mammedov wrote: Sometimes it's necessary to execute a test that depends on KVM, however qtest is not aware if tested QEMU binary supports KVM on the host it the test is executed.

Re: [PATCH V8 1/6] qapi/net: Add IPFlowSpec and QMP command for COLO passthrough

2021-06-22 Thread Jason Wang
在 2021/6/22 下午3:38, chen.zh...@intel.com 写道: On 6/22/21 3:04 PM, Jason Wang wrote: 在 2021/6/22 下午2:01, chen.zh...@intel.com 写道: On 6/21/21 7:30 PM, Dr. David Alan Gilbert wrote: * Markus Armbruster (arm...@redhat.com) wrote: Zhang Chen writes: Since the real user scenario does not need

Re: [PATCH v2] block/nvme: Fix VFIO_MAP_DMA failed: No space left on device

2021-06-22 Thread Philippe Mathieu-Daudé
On 6/22/21 9:29 AM, Philippe Mathieu-Daudé wrote: > On 6/21/21 5:36 PM, Fam Zheng wrote: >>> On 21 Jun 2021, at 16:13, Philippe Mathieu-Daudé wrote: >>> On 6/21/21 3:18 PM, Fam Zheng wrote: > On 21 Jun 2021, at 10:32, Philippe Mathieu-Daudé > wrote: > > When the NVMe block driver

Re: [PATCH v17 4/6] KVM: arm64: Expose KVM_ARM_CAP_MTE

2021-06-22 Thread Fuad Tabba
Hi, On Mon, Jun 21, 2021 at 12:18 PM Steven Price wrote: > > It's now safe for the VMM to enable MTE in a guest, so expose the > capability to user space. > > Reviewed-by: Catalin Marinas > Signed-off-by: Steven Price > --- > arch/arm64/kvm/arm.c | 9 + > arch/arm64/kvm/reset.c

Re: [PATCH V8 1/6] qapi/net: Add IPFlowSpec and QMP command for COLO passthrough

2021-06-22 Thread chen.zh...@intel.com
On 6/22/21 4:03 PM, Jason Wang wrote: 在 2021/6/22 下午3:38, chen.zh...@intel.com 写道: On 6/22/21 3:04 PM, Jason Wang wrote: 在 2021/6/22 下午2:01, chen.zh...@intel.com 写道: On 6/21/21 7:30 PM, Dr. David Alan Gilbert wrote: * Markus Armbruster (arm...@redhat.com) wrote: Zhang Chen writes: Since

Re: [RFC 0/3] qtest: pick tests that require KVM at runtime

2021-06-22 Thread Alex Bennée
Igor Mammedov writes: > On Fri, 18 Jun 2021 14:43:46 +0200 > Claudio Fontana wrote: > >> On 6/18/21 1:26 PM, Igor Mammedov wrote: >> > On Thu, 17 Jun 2021 18:49:17 +0200 >> > Claudio Fontana wrote: >> > >> >> On 6/16/21 5:24 PM, Igor Mammedov wrote: >> >>> >> >>> Sometimes it's necessary

Re: [PATCH v4 6/6] block-copy: atomic .cancelled and .finished fields in BlockCopyCallState

2021-06-22 Thread Paolo Bonzini
On 19/06/21 22:06, Vladimir Sementsov-Ogievskiy wrote: -    assert(call_state->finished); +    assert(qatomic_load_acquire(&call_state->finished)); Hmm. Here qatomic_load_acquire protects nothing (assertion will crash if not yet finished anyway). So, caller is double sure that block-copy is

Re: QEMU PCIe expander bridge with 64kB page guest -> guest BUG_ON()

2021-06-22 Thread Eric Auger
Adding Yubo in the loop as Jiahui's address is bouncing. On 6/21/21 6:22 PM, Eric Auger wrote: > Hi Jiahui, > > I noticed the PCIe expander bridge + PCIe root port does not work with a > 64kB page guest. One hits a kernel BUG at mm/vmalloc.c:96 > (BUG_ON(!pte_none(*pte));)! This happens with an

Re: [RFC 0/3] qtest: pick tests that require KVM at runtime

2021-06-22 Thread Philippe Mathieu-Daudé
On 6/22/21 10:07 AM, Alex Bennée wrote: > Igor Mammedov writes: >> On Fri, 18 Jun 2021 14:43:46 +0200 >> Claudio Fontana wrote: >>> On 6/18/21 1:26 PM, Igor Mammedov wrote: On Thu, 17 Jun 2021 18:49:17 +0200 Claudio Fontana wrote: > On 6/16/21 5:24 PM, Igor Mammedov wrote: >>

Re: [RFC PATCH v1] vhost-vsock: SOCK_SEQPACKET feature bit support

2021-06-22 Thread Stefano Garzarella
On Mon, Jun 21, 2021 at 05:07:41PM +0300, Arseny Krasnov wrote: This adds processing of VIRTIO_VSOCK_F_SEQPACKET features bit. Guest negotiates it with vhost, thus both will know that SOCK_SEQPACKET supported by peer. Signed-off-by: Arseny Krasnov --- hw/virtio/vhost-vsock.c

Re: [RFC PATCH 0/5] ebpf: Added ebpf helper for libvirtd.

2021-06-22 Thread Toke Høiland-Jørgensen
Jason Wang writes: > 在 2021/6/22 上午11:29, Yuri Benditovich 写道: >> On Mon, Jun 21, 2021 at 12:20 PM Jason Wang wrote: >>> >>> 在 2021/6/19 上午4:03, Andrew Melnichenko 写道: Hi Jason, I've checked "kernel.unprivileged_bpf_disabled=0" on Fedora, Ubuntu, and Debian - no need permissions

Re: [RFC PATCH 0/5] ebpf: Added ebpf helper for libvirtd.

2021-06-22 Thread Daniel P . Berrangé
On Tue, Jun 22, 2021 at 10:25:19AM +0200, Toke Høiland-Jørgensen wrote: > Jason Wang writes: > > > 在 2021/6/22 上午11:29, Yuri Benditovich 写道: > >> On Mon, Jun 21, 2021 at 12:20 PM Jason Wang wrote: > >>> > >>> 在 2021/6/19 上午4:03, Andrew Melnichenko 写道: > Hi Jason, > I've checked "kernel

Re: [PATCH v2 1/2] sev/i386: Introduce sev_add_kernel_loader_hashes for measured linux boot

2021-06-22 Thread Dov Murik
I found an issue with this patch when no -initrd is passed, see below. On 21/06/2021 22:05, Dov Murik wrote: > Add the sev_add_kernel_loader_hashes function to calculate the hashes of > the kernel/initrd/cmdline and fill a designated OVMF encrypted hash > table area. For this to work, OVMF must

Re: [PATCH v2 1/2] contrib/plugins: add execlog to log instruction execution and memory access

2021-06-22 Thread Alex Bennée
Alexandre Iooss writes: > Log instruction execution and memory access to a file. > This plugin can be used for reverse engineering or for side-channel analysis > using QEMU. > > Signed-off-by: Alexandre Iooss > --- > MAINTAINERS | 1 + > contrib/plugins/Makefile | 1 + > co

Re: [PATCH v17 4/6] KVM: arm64: Expose KVM_ARM_CAP_MTE

2021-06-22 Thread Marc Zyngier
On Tue, 22 Jun 2021 09:07:51 +0100, Fuad Tabba wrote: > > Hi, > > On Mon, Jun 21, 2021 at 12:18 PM Steven Price wrote: > > > > It's now safe for the VMM to enable MTE in a guest, so expose the > > capability to user space. > > > > Reviewed-by: Catalin Marinas > > Signed-off-by: Steven Price >

Re: [PATCH 2/2] docs/system/arm: Add quanta-gbs-bmc reference

2021-06-22 Thread Cédric Le Goater
On 6/21/21 3:31 PM, Peter Maydell wrote: > On Tue, 15 Jun 2021 at 20:29, Patrick Venture wrote: >> >> Add line item reference to quanta-gbs-bmc machine. >> >> Signed-off-by: Patrick Venture >> --- >> docs/system/arm/nuvoton.rst | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> dif

Re: [PATCH v2] hw/audio/sb16: Avoid assertion by restricting I/O sampling rate range

2021-06-22 Thread Qiang Liu
Hi folks, With this patch, having tested more, I find another way to trigger the assertion. I found it just now such that I did a quick investigation and reported it to you. I hope this would prevent merging this patch. Brief analysis: This existing patch limits s->freq in dma_cmd8 before continu

Re: [PATCH v2 2/2] docs/devel: tvg-plugins: add execlog plugin description

2021-06-22 Thread Alex Bennée
Alexandre Iooss writes: > This adds description of the execlog TCG plugin with an example. > > Signed-off-by: Alexandre Iooss > --- > docs/devel/tcg-plugins.rst | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/docs/devel/tcg-plugins.rst b/docs/devel/tcg-plugins

Re: [PATCH v2 2/2] docs/devel: tvg-plugins: add execlog plugin description

2021-06-22 Thread Alex Bennée
Alexandre Iooss writes: Sorry also missed s/tvg/tcg/ in the subject line. -- Alex Bennée

Re: [PATCH v17 5/6] KVM: arm64: ioctl to fetch/store tags in a guest

2021-06-22 Thread Fuad Tabba
Hi, On Mon, Jun 21, 2021 at 12:18 PM Steven Price wrote: > > The VMM may not wish to have it's own mapping of guest memory mapped > with PROT_MTE because this causes problems if the VMM has tag checking > enabled (the guest controls the tags in physical RAM and it's unlikely > the tags are corre

Re: [PATCH 5/6] block/nbd: Do not force-cap *pnum

2021-06-22 Thread Vladimir Sementsov-Ogievskiy
21.06.2021 21:53, Eric Blake wrote: On Sat, Jun 19, 2021 at 01:53:24PM +0300, Vladimir Sementsov-Ogievskiy wrote: +++ b/block/nbd.c @@ -1702,7 +1702,7 @@ static int coroutine_fn nbd_client_co_block_status( .type = NBD_CMD_BLOCK_STATUS, .from = offset, .len = MIN(

Re: [RFC PATCH 0/5] ebpf: Added ebpf helper for libvirtd.

2021-06-22 Thread Toke Høiland-Jørgensen
Daniel P. Berrangé writes: > On Tue, Jun 22, 2021 at 10:25:19AM +0200, Toke Høiland-Jørgensen wrote: >> Jason Wang writes: >> >> > 在 2021/6/22 上午11:29, Yuri Benditovich 写道: >> >> On Mon, Jun 21, 2021 at 12:20 PM Jason Wang wrote: >> >>> >> >>> 在 2021/6/19 上午4:03, Andrew Melnichenko 写道: >>

Re: [PATCH v2 1/2] contrib/plugins: add execlog to log instruction execution and memory access

2021-06-22 Thread Alexandre IOOSS
On 6/22/21 10:37 AM, Alex Bennée wrote: We only allocate last_exec for system.max_vcpus here. You need to check the system_emulation bool before using that information and error out if it's not system emulation. My bad, I did not test user mode emulation after converting last_exec to an array.

Re: [PATCH v2] hw/audio/sb16: Avoid assertion by restricting I/O sampling rate range

2021-06-22 Thread Philippe Mathieu-Daudé
On 6/22/21 10:54 AM, Qiang Liu wrote: > Hi folks, > > With this patch, having tested more, I find another way to trigger the > assertion. > I found it just now such that I did a quick investigation and reported > it to you. I > hope this would prevent merging this patch. No need to prevent mergin

Re: [PATCH v4 3/6] block-copy: improve comments of BlockCopyTask and BlockCopyState types and functions

2021-06-22 Thread Vladimir Sementsov-Ogievskiy
21.06.2021 10:59, Emanuele Giuseppe Esposito wrote: On 19/06/2021 17:23, Vladimir Sementsov-Ogievskiy wrote: 14.06.2021 10:33, Emanuele Giuseppe Esposito wrote: As done in BlockCopyCallState, categorize BlockCopyTask and BlockCopyState in IN, State and OUT fields. This is just to understand w

Re: [PATCH v4 3/6] block-copy: improve comments of BlockCopyTask and BlockCopyState types and functions

2021-06-22 Thread Vladimir Sementsov-Ogievskiy
21.06.2021 11:13, Emanuele Giuseppe Esposito wrote: On 19/06/2021 20:31, Vladimir Sementsov-Ogievskiy wrote: 19.06.2021 18:23, Vladimir Sementsov-Ogievskiy wrote:   typedef struct BlockCopyTask {   AioTask task; +    /* + * IN parameters. Initialized in block_copy_task_create() +

Re: [PATCH v2 2/2] docs/devel: tvg-plugins: add execlog plugin description

2021-06-22 Thread Alexandre IOOSS
On 6/22/21 10:48 AM, Alex Bennée wrote: Alexandre Iooss writes: [...] + +The execlog tool traces executed instructions with memory access. It can be used +for debugging and security analysis purposes. We should probably mention that this will generate a lot of output. Running the admittedly m

[RFC PATCH v4 2/7] hw/arm/virt: Add separate -smp parsing function for ARM machines

2021-06-22 Thread Yanan Wang
Add an ARM-specific -smp parsing function named virt_smp_parse. When support for exposing cpu topology to the guest is disabled, this function shares the same logic with smp_parse(). While when the support is enabled, an accurate virtual cpu topology is very important, so we require that cpus/socke

[RFC PATCH v4 7/7] hw/acpi/aml-build: Generate PPTT table

2021-06-22 Thread Yanan Wang
From: Andrew Jones Add the Processor Properties Topology Table (PPTT) to expose CPU topology information defined by users to ACPI guests. Note, a DT-boot Linux guest with a non-flat CPU topology will see socket and core IDs being sequential integers starting from zero, which is different from AC

[RFC PATCH v4 4/7] device_tree: Add qemu_fdt_add_path

2021-06-22 Thread Yanan Wang
qemu_fdt_add_path() works like qemu_fdt_add_subnode(), except it also adds all missing subnodes from the given path. We'll use it in a coming patch where we will add cpu-map to the device tree. And we also tweak an error message of qemu_fdt_add_subnode(). Cc: David Gibson Cc: Alistair Francis C

[RFC PATCH v4 1/7] vl: Add expose=on|off option support in -smp command line

2021-06-22 Thread Yanan Wang
Once the view of virtual cpu topology is provided to guest kernel, with a well-designed vCPU pinning to the pCPU we could get a huge benefit, e.g., the scheduling performance improvement. However a virtual cpu topology view of guest may also have a negative impact if the pinning is badly-designed.

[RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-22 Thread Yanan Wang
Hi, This is v4 of the series [1] that I posted to introduce support for generating cpu topology descriptions to guest. Comments are welcome! Description: Once the view of an accurate virtual cpu topology is provided to guest, with a well-designed vCPU pinning to the pCPU we may get a huge benefit

[RFC PATCH v4 3/7] machine: disallow -smp expose=on for non-ARM machines

2021-06-22 Thread Yanan Wang
Currently, support for exposure of cpu topology to the guest is only introduced for ARM machines and we also have an ARM specific parsing function virt_smp_parse(), so we disallow the "-smp expose=on" configuration for the other platforms. Signed-off-by: Yanan Wang --- hw/core/machine.c | 7

[RFC PATCH v4 5/7] hw/arm/virt: Add cpu-map to device tree

2021-06-22 Thread Yanan Wang
From: Andrew Jones Support device tree CPU topology descriptions. In accordance with the Devicetree Specification, the Linux Doc "arm/cpus.yaml" requires that cpus and cpu nodes in the DT are present. And we have already met the requirement by generating /cpus/cpu@* nodes for members within ms->

[RFC PATCH v4 6/7] hw/acpi/aml-build: Add Processor hierarchy node structure

2021-06-22 Thread Yanan Wang
Add a generic API to build Processor hierarchy node structure (Type 0), which is strictly consistent with descriptions in ACPI 6.2: 5.2.29.1. This function will be used to build ACPI PPTT table for cpu topology. Co-developed-by: Ying Fang Signed-off-by: Ying Fang Co-developed-by: Henglong Fan

Re: [PATCH v17 6/6] KVM: arm64: Document MTE capability and ioctl

2021-06-22 Thread Fuad Tabba
Hi, On Mon, Jun 21, 2021 at 12:18 PM Steven Price wrote: > > A new capability (KVM_CAP_ARM_MTE) identifies that the kernel supports > granting a guest access to the tags, and provides a mechanism for the > VMM to enable it. > > A new ioctl (KVM_ARM_MTE_COPY_TAGS) provides a simple way for a VMM

Re: RFC: Implementation of QMP documentation retrieval command

2021-06-22 Thread Stefan Hajnoczi
On Mon, Jun 21, 2021 at 11:56:30PM +0530, Niteesh G. S. wrote: > TLDR: The goal of this mail wasn't to review the dummy command I had posted > but > rather start a discussion regarding the implementation of the QMP > documentation > retrieval command for the TUI. It's not clear to me what exactly

Re: [PATCH v2 1/2] sev/i386: Introduce sev_add_kernel_loader_hashes for measured linux boot

2021-06-22 Thread Dov Murik
Hi Philippe, On 21/06/2021 23:32, Philippe Mathieu-Daudé wrote: > Hi Dov, > > Minor comments inlined. > > On 6/21/21 9:05 PM, Dov Murik wrote: >> Add the sev_add_kernel_loader_hashes function to calculate the hashes of >> the kernel/initrd/cmdline and fill a designated OVMF encrypted hash >> tab

Re: [PATCH v4 6/6] block-copy: atomic .cancelled and .finished fields in BlockCopyCallState

2021-06-22 Thread Vladimir Sementsov-Ogievskiy
22.06.2021 11:15, Paolo Bonzini wrote: On 19/06/21 22:06, Vladimir Sementsov-Ogievskiy wrote: -    assert(call_state->finished); +    assert(qatomic_load_acquire(&call_state->finished)); Hmm. Here qatomic_load_acquire protects nothing (assertion will crash if not yet finished anyway). So, ca

Re: [PATCH v17 3/6] KVM: arm64: Save/restore MTE registers

2021-06-22 Thread Fuad Tabba
Hi, > diff --git a/arch/arm64/include/asm/kvm_mte.h > b/arch/arm64/include/asm/kvm_mte.h > new file mode 100644 > index ..88dd1199670b > --- /dev/null > +++ b/arch/arm64/include/asm/kvm_mte.h > @@ -0,0 +1,66 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (C) 2020-2

Re: [PATCH v2 1/2] sev/i386: Introduce sev_add_kernel_loader_hashes for measured linux boot

2021-06-22 Thread Philippe Mathieu-Daudé
On 6/22/21 11:44 AM, Dov Murik wrote: > On 21/06/2021 23:32, Philippe Mathieu-Daudé wrote: >> and added qemu_uuid_copy() to complete the API, but that's fine. > > I think simple C assignment works for structs (and hence QemuUUID), > something like: > > SevHashTable *ht = ...; > ht->guid

Re: [PATCH v4 6/6] block-copy: atomic .cancelled and .finished fields in BlockCopyCallState

2021-06-22 Thread Vladimir Sementsov-Ogievskiy
21.06.2021 12:30, Emanuele Giuseppe Esposito wrote: On 19/06/2021 22:06, Vladimir Sementsov-Ogievskiy wrote: 14.06.2021 10:33, Emanuele Giuseppe Esposito wrote: By adding acquire/release pairs, we ensure that .ret and .error_is_read fields are written by block_copy_dirty_clusters before .fini

Re: [PATCH v2] hw/audio/sb16: Avoid assertion by restricting I/O sampling rate range

2021-06-22 Thread Qiang Liu
On Tue, Jun 22, 2021 at 5:16 PM Philippe Mathieu-Daudé wrote: > > On 6/22/21 10:54 AM, Qiang Liu wrote: > > Hi folks, > > > > With this patch, having tested more, I find another way to trigger the > > assertion. > > I found it just now such that I did a quick investigation and reported > > it to y

Re: [PATCH RESEND] docs: clarify absence of set_features in vhost-user

2021-06-22 Thread Stefan Hajnoczi
On Thu, Jun 17, 2021 at 04:19:26PM +0100, Alex Bennée wrote: > > Alex Bennée writes: > > > Alyssa Ross writes: > > > >> The previous wording was (at least to me) ambiguous about whether a > >> backend should enable features immediately after they were set using > >> VHOST_USER_SET_PROTOCOL_FEAT

Re: [PATCH RFC] meson: add option to use zstd for qcow2 compression by default

2021-06-22 Thread Vladimir Sementsov-Ogievskiy
21.06.2021 18:59, Kevin Wolf wrote: Am 21.06.2021 um 10:22 hat Paolo Bonzini geschrieben: On 17/06/21 21:51, Vladimir Sementsov-Ogievskiy wrote: So, it's an RFC. I also can split the patch so that refactoring of qcow2_co_create() go in a separate preparation patch. Another RFC question, should

[RFC v5 00/13] s390x cleanup

2021-06-22 Thread Cho, Yu-Chen
this is the next version of a cleanup series for s390x. v4 -> v5: * "target/s390x: start moving TCG-only code to tcg/" - add change to MAINTAINERS file * "target/s390x: move sysemu-only code out to cpu-sysemu.c" - make use of SysemuCPUOps s390_sysemu_ops to handle * "target/s390x: split cpu

[RFC v5 02/13] hw/s390x: rename tod-qemu.c to tod-tcg.c

2021-06-22 Thread Cho, Yu-Chen
we stop short of renaming the actual qom object though, so type remains TYPE_QEMU_S390_TOD, ie "s390-tod-qemu". Signed-off-by: Claudio Fontana Reviewed-by: David Hildenbrand Reviewed-by: Cornelia Huck Signed-off-by: Cho, Yu-Chen --- hw/s390x/meson.build | 2 +- hw/s390x/{tod-qem

[RFC v5 03/13] hw/s390x: only build tod-tcg from the CONFIG_TCG build

2021-06-22 Thread Cho, Yu-Chen
this will allow in later patches to remove unneeded stubs in target/s390x. Signed-off-by: Claudio Fontana Reviewed-by: David Hildenbrand Reviewed-by: Cornelia Huck Signed-off-by: Cho, Yu-Chen --- hw/s390x/meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/s3

[RFC v5 04/13] hw/s390x: tod: make explicit checks for accelerators when initializing

2021-06-22 Thread Cho, Yu-Chen
replace general "else" with specific checks for each possible accelerator. Handle qtest as a NOP, and error out for an unknown accelerator used in combination with tod. Signed-off-by: Claudio Fontana Reviewed-by: David Hildenbrand Reviewed-by: Cornelia Huck Signed-off-by: Cho, Yu-Chen --- hw

[RFC v5 01/13] target/s390x: meson: add target_user_arch

2021-06-22 Thread Cho, Yu-Chen
the lack of target_user_arch makes it hard to fully leverage the build system in order to separate user code from sysemu code. Provide it, so that we can avoid the proliferation of #ifdef in target code. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Acked-by: Cornelia Huck --- ta

[RFC v5 06/13] target/s390x: start moving TCG-only code to tcg/

2021-06-22 Thread Cho, Yu-Chen
move everything related to translate, as well as HELPER code in tcg/ mmu_helper.c stays put for now, as it contains both TCG and KVM code. The internal.h file is renamed to s390x-internal.h, because of the risk of collision with other files with the same name. After the reshuffling, update MAINT

[RFC v5 05/13] target/s390x: remove tcg-stub.c

2021-06-22 Thread Cho, Yu-Chen
now that we protect all calls to the tcg-specific functions with if (tcg_enabled()), we do not need the TCG stub anymore. Signed-off-by: Claudio Fontana Reviewed-by: David Hildenbrand Reviewed-by: Cornelia Huck Signed-off-by: Cho, Yu-Chen --- target/s390x/meson.build | 2 +- target/s390x/tcg

[RFC v5 07/13] target/s390x: move sysemu-only code out to cpu-sysemu.c

2021-06-22 Thread Cho, Yu-Chen
move sysemu-only code out to cpu-sysemu.c Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen --- target/s390x/cpu-sysemu.c | 309 ++ target/s390x/cpu.c| 285 ++- target/s390x/meson.build | 1 + target/s390x/t

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-22 Thread Daniel P . Berrangé
On Tue, Jun 22, 2021 at 05:34:06PM +0800, Yanan Wang wrote: > Hi, > > This is v4 of the series [1] that I posted to introduce support for > generating cpu topology descriptions to guest. Comments are welcome! > > Description: > Once the view of an accurate virtual cpu topology is provided to gues

[RFC v5 11/13] target/s390x: remove kvm-stub.c

2021-06-22 Thread Cho, Yu-Chen
all function calls are protected by kvm_enabled(), so we do not need the stubs. For kvm_s390_get_gs(), the last user has likely been removed with 0280b3eb7c ("s390x/kvm: use cpu model for gscb on compat machines"). Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen --- MAINTAINERS

[RFC v5 08/13] target/s390x: split cpu-dump from helper.c

2021-06-22 Thread Cho, Yu-Chen
Splitting this functionality also allows us to make helper.c sysemu-only. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Acked-by: Cornelia Huck --- target/s390x/cpu-dump.c | 131 +++ target/s390x/helper.c| 107 --

[RFC v5 09/13] target/s390x: make helper.c sysemu-only

2021-06-22 Thread Cho, Yu-Chen
Now that we have moved cpu-dump functionality out of helper.c, we can make the module sysemu-only. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Acked-by: Cornelia Huck --- target/s390x/helper.c| 6 +- target/s390x/meson.build | 2 +- 2 files changed, 2 insertions(+), 6 de

Re: [PATCH RFC] meson: add option to use zstd for qcow2 compression by default

2021-06-22 Thread Paolo Bonzini
On 22/06/21 12:16, Vladimir Sementsov-Ogievskiy wrote: Yes, this is more extensible. Looks good, I'll try. I'm just not familiar with it and followed the pattern of zstd option. You can look at -Dmalloc for an example. Paolo

[RFC v5 10/13] target/s390x: use kvm_enabled() to wrap call to kvm_s390_get_hpage_1m

2021-06-22 Thread Cho, Yu-Chen
this will allow to remove the kvm stubs. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen --- target/s390x/diag.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/s390x/diag.c b/target/s390x/diag.c index c17a2498a7..8405f69df0 100644 --- a/target/s390x/diag

[RFC v5 12/13] target/s390x: move kvm files into kvm/

2021-06-22 Thread Cho, Yu-Chen
move kvm files into kvm/ After the reshuffling, update MAINTAINERS accordingly. Make use of the new directory: target/s390x/kvm/ Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen --- MAINTAINERS| 3 +-- hw/intc/s390_flic_kvm.c| 2 +- hw/s390x/s390

Re: RFC: Implementation of QMP documentation retrieval command

2021-06-22 Thread Daniel P . Berrangé
On Tue, Jun 22, 2021 at 10:35:47AM +0100, Stefan Hajnoczi wrote: > On Mon, Jun 21, 2021 at 11:56:30PM +0530, Niteesh G. S. wrote: > > TLDR: The goal of this mail wasn't to review the dummy command I had posted > > but > > rather start a discussion regarding the implementation of the QMP > > documen

[RFC v5 13/13] target/s390x: split sysemu part of cpu models

2021-06-22 Thread Cho, Yu-Chen
split sysemu part of cpu models, also create a tiny _user.c with just the (at least for now), empty implementation of apply_cpu_model. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen --- MAINTAINERS | 1 + target/s390x/cpu_models.c| 417 +---

Re: [PATCH v4 6/6] block-copy: atomic .cancelled and .finished fields in BlockCopyCallState

2021-06-22 Thread Paolo Bonzini
On 22/06/21 11:36, Vladimir Sementsov-Ogievskiy wrote: It does.  If it returns true, you still want the load of finished to happen before the reads that follow. Hmm.. The worst case if we use just qatomic_read is that assertion will not crash when it actually should. That doesn't break the log

Re: [PATCH v2 1/2] sev/i386: Introduce sev_add_kernel_loader_hashes for measured linux boot

2021-06-22 Thread Dov Murik
On 22/06/2021 12:49, Philippe Mathieu-Daudé wrote: > On 6/22/21 11:44 AM, Dov Murik wrote: >> On 21/06/2021 23:32, Philippe Mathieu-Daudé wrote: > ... > +if (!pc_system_ovmf_table_find(SEV_HASH_TABLE_RV_GUID, &data, NULL)) { >>> >>> If we never use the data_len argument, can we simp

Re: [PATCH v17 6/6] KVM: arm64: Document MTE capability and ioctl

2021-06-22 Thread Marc Zyngier
On Tue, 22 Jun 2021 10:42:42 +0100, Fuad Tabba wrote: > > Hi, > > > On Mon, Jun 21, 2021 at 12:18 PM Steven Price wrote: > > > > A new capability (KVM_CAP_ARM_MTE) identifies that the kernel supports > > granting a guest access to the tags, and provides a mechanism for the > > VMM to enable it

Re: [PATCH 17/28] tcg: Add flags argument to tcg_gen_bswap16_*, tcg_gen_bswap32_i64

2021-06-22 Thread Philippe Mathieu-Daudé
On 6/14/21 5:58 PM, Richard Henderson wrote: > On 6/14/21 2:41 AM, Philippe Mathieu-Daudé wrote: >> On 6/14/21 10:37 AM, Richard Henderson wrote: >>> Implement the new semantics in the fallback expansion. >>> Change all callers to supply the flags that keep the >>> semantics unchanged locally. >>>

Re: [PATCH v17 5/6] KVM: arm64: ioctl to fetch/store tags in a guest

2021-06-22 Thread Marc Zyngier
Hi Fuad, On Tue, 22 Jun 2021 09:56:22 +0100, Fuad Tabba wrote: > > Hi, > > > On Mon, Jun 21, 2021 at 12:18 PM Steven Price wrote: > > > > The VMM may not wish to have it's own mapping of guest memory mapped > > with PROT_MTE because this causes problems if the VMM has tag checking > > enabled

Re: [RFC v5 00/13] s390x cleanup

2021-06-22 Thread Al Cho
There is the CI/CD result of this patches set https://gitlab.com/alcho.tw/qemu/-/pipelines/324863789 Cheers, AL From: Al Cho Sent: Tuesday, June 22, 2021 6:17 PM To: qemu-devel@nongnu.org ; qemu-s3...@nongnu.org Cc: Claudio Fontana ; Al Cho Subjec

Re: [PATCH v4 6/6] block-copy: atomic .cancelled and .finished fields in BlockCopyCallState

2021-06-22 Thread Vladimir Sementsov-Ogievskiy
22.06.2021 13:20, Paolo Bonzini wrote: On 22/06/21 11:36, Vladimir Sementsov-Ogievskiy wrote: It does.  If it returns true, you still want the load of finished to happen before the reads that follow. Hmm.. The worst case if we use just qatomic_read is that assertion will not crash when it ac

Re: [PATCH v2 1/2] contrib/plugins: add execlog to log instruction execution and memory access

2021-06-22 Thread Alex Bennée
Alexandre IOOSS writes: > [[PGP Signed Part:Undecided]] > On 6/22/21 10:37 AM, Alex Bennée wrote: >> We only allocate last_exec for system.max_vcpus here. You need to check >> the system_emulation bool before using that information and error out if >> it's not system emulation. > > My bad, I di

Re: [PATCH v2 2/2] docs/devel: tvg-plugins: add execlog plugin description

2021-06-22 Thread Alex Bennée
Alexandre IOOSS writes: > [[PGP Signed Part:Undecided]] > On 6/22/21 10:48 AM, Alex Bennée wrote: >> Alexandre Iooss writes: >>> [...] >>> + >>> +The execlog tool traces executed instructions with memory access. It can >>> be used >>> +for debugging and security analysis purposes. >> We shoul

Re: [RFC 0/3] qtest: pick tests that require KVM at runtime

2021-06-22 Thread Igor Mammedov
On Tue, 22 Jun 2021 10:22:19 +0200 Philippe Mathieu-Daudé wrote: > On 6/22/21 10:07 AM, Alex Bennée wrote: > > Igor Mammedov writes: > >> On Fri, 18 Jun 2021 14:43:46 +0200 > >> Claudio Fontana wrote: > >>> On 6/18/21 1:26 PM, Igor Mammedov wrote: > On Thu, 17 Jun 2021 18:49:17 +0200

Re: [PATCH v17 6/6] KVM: arm64: Document MTE capability and ioctl

2021-06-22 Thread Fuad Tabba
Hi Marc, On Tue, Jun 22, 2021 at 11:35 AM Marc Zyngier wrote: > > On Tue, 22 Jun 2021 10:42:42 +0100, > Fuad Tabba wrote: > > > > Hi, > > > > > > On Mon, Jun 21, 2021 at 12:18 PM Steven Price wrote: > > > > > > A new capability (KVM_CAP_ARM_MTE) identifies that the kernel supports > > > grantin

Re: [PATCH v2 01/10] target/ppc: Remove PowerPCCPUClass.handle_mmu_fault

2021-06-22 Thread Greg Kurz
On Mon, 21 Jun 2021 09:51:06 -0300 "Bruno Larsen (billionai)" wrote: > From: Richard Henderson > > Instead, use a switch on env->mmu_model. This avoids some > replicated information in cpu setup. > > Signed-off-by: Richard Henderson > --- Very nice ! Reviewed-by: Greg Kurz > target/ppc/

Re: [PATCH v6 06/16] qemu-iotests: delay QMP socket timers

2021-06-22 Thread Vladimir Sementsov-Ogievskiy
21.06.2021 13:33, Emanuele Giuseppe Esposito wrote: Attaching gdbserver implies that the qmp socket should wait indefinitely for an answer from QEMU. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy Please, let this patch go without my r-b. I don't like it,

Re: [RFC 0/3] qtest: pick tests that require KVM at runtime

2021-06-22 Thread Igor Mammedov
On Tue, 22 Jun 2021 09:59:48 +0200 Thomas Huth wrote: > On 22/06/2021 09.26, Philippe Mathieu-Daudé wrote: > > On 6/22/21 9:20 AM, Thomas Huth wrote: > >> On 16/06/2021 17.24, Igor Mammedov wrote: > >>> > >>> Sometimes it's necessary to execute a test that depends on KVM, > >>> however qtest

Re: [PATCH v17 5/6] KVM: arm64: ioctl to fetch/store tags in a guest

2021-06-22 Thread Fuad Tabba
Hi Marc, On Tue, Jun 22, 2021 at 11:25 AM Marc Zyngier wrote: > > Hi Fuad, > > On Tue, 22 Jun 2021 09:56:22 +0100, > Fuad Tabba wrote: > > > > Hi, > > > > > > On Mon, Jun 21, 2021 at 12:18 PM Steven Price wrote: > > > > > > The VMM may not wish to have it's own mapping of guest memory mapped >

Re: RFC: Implementation of QMP documentation retrieval command

2021-06-22 Thread Vladimir Sementsov-Ogievskiy
22.06.2021 13:26, Daniel P. Berrangé wrote: There's a more fundamental question about structure here too. The documentation is not a arbitrary block of text. It contains specific data items for individual parameters, and return type, along with version number annotation too. If we're returning a

Re: [PATCH v6 06/16] qemu-iotests: delay QMP socket timers

2021-06-22 Thread Emanuele Giuseppe Esposito
On 22/06/2021 12:50, Vladimir Sementsov-Ogievskiy wrote: 21.06.2021 13:33, Emanuele Giuseppe Esposito wrote: Attaching gdbserver implies that the qmp socket should wait indefinitely for an answer from QEMU. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy

Re: [PATCH v2 1/2] sev/i386: Introduce sev_add_kernel_loader_hashes for measured linux boot

2021-06-22 Thread Philippe Mathieu-Daudé
On 6/22/21 12:26 PM, Dov Murik wrote: > > > On 22/06/2021 12:49, Philippe Mathieu-Daudé wrote: >> On 6/22/21 11:44 AM, Dov Murik wrote: >>> On 21/06/2021 23:32, Philippe Mathieu-Daudé wrote: >> > > ... > >> > +if (!pc_system_ovmf_table_find(SEV_HASH_TABLE_RV_GUID, &data, NULL)) > {

Re: [PATCH v6 06/16] qemu-iotests: delay QMP socket timers

2021-06-22 Thread Vladimir Sementsov-Ogievskiy
22.06.2021 14:04, Emanuele Giuseppe Esposito wrote: On 22/06/2021 12:50, Vladimir Sementsov-Ogievskiy wrote: 21.06.2021 13:33, Emanuele Giuseppe Esposito wrote: Attaching gdbserver implies that the qmp socket should wait indefinitely for an answer from QEMU. Signed-off-by: Emanuele Giuseppe

Re: [PATCH RFC] docs: document file-posix locking protocol

2021-06-22 Thread Vladimir Sementsov-Ogievskiy
Ping. Any thoughts? 24.05.2021 17:40, Vladimir Sementsov-Ogievskiy wrote: Ping. We need to synchronize access to qcow2 images between Qemu and our internal program. For this solution to be reliable, the locking protocol should be documented at least.. 22.03.2021 21:27, Vladimir Sementsov-Ogi

Re: [RFC 0/3] qtest: pick tests that require KVM at runtime

2021-06-22 Thread Philippe Mathieu-Daudé
+Daniel (sorry Daniel) On 6/22/21 12:36 PM, Igor Mammedov wrote: > On Tue, 22 Jun 2021 10:22:19 +0200 > Philippe Mathieu-Daudé wrote: >> On 6/22/21 10:07 AM, Alex Bennée wrote: >>> Igor Mammedov writes: On Fri, 18 Jun 2021 14:43:46 +0200 Claudio Fontana wrote: > On 6/18/21 1:2

Re: [PATCH v17 2/6] KVM: arm64: Introduce MTE VM feature

2021-06-22 Thread Marc Zyngier
On Mon, 21 Jun 2021 18:00:20 +0100, Fuad Tabba wrote: > > Hi, > > On Mon, Jun 21, 2021 at 12:18 PM Steven Price wrote: > > > > Add a new VM feature 'KVM_ARM_CAP_MTE' which enables memory tagging > > for a VM. This will expose the feature to the guest and automatically > > tag memory pages touch

Re: [RFC v5 06/13] target/s390x: start moving TCG-only code to tcg/

2021-06-22 Thread Cornelia Huck
On Tue, Jun 22 2021, "Cho, Yu-Chen" wrote: > move everything related to translate, as well as HELPER code in tcg/ > > mmu_helper.c stays put for now, as it contains both TCG and KVM code. > > The internal.h file is renamed to s390x-internal.h, because of the > risk of collision with other files w

Re: [RFC v5 09/13] target/s390x: make helper.c sysemu-only

2021-06-22 Thread Cornelia Huck
On Tue, Jun 22 2021, "Cho, Yu-Chen" wrote: > Now that we have moved cpu-dump functionality out of helper.c, > we can make the module sysemu-only. > > Signed-off-by: Claudio Fontana > Signed-off-by: Cho, Yu-Chen > Acked-by: Cornelia Huck > --- > target/s390x/helper.c| 6 +- > target/s3

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-22 Thread Andrew Jones
On Tue, Jun 22, 2021 at 11:18:09AM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 22, 2021 at 05:34:06PM +0800, Yanan Wang wrote: > > Hi, > > > > This is v4 of the series [1] that I posted to introduce support for > > generating cpu topology descriptions to guest. Comments are welcome! > > > > De

[PATCH] block/ssh: add support for sha256 host key fingerprints

2021-06-22 Thread Daniel P . Berrangé
Currently the SSH block driver supports MD5 and SHA1 for host key fingerprints. This is a cryptographically sensitive operation and so these hash algorithms are inadequate by modern standards. This adds support for SHA256 which has been supported in libssh since the 0.8.1 release. Signed-off-by: D

[Bug 1836763] Re: Firebird crashes on qemu-m68k-user with pthread_mutex_init error

2021-06-22 Thread John Paul Adrian Glaubitz
** Changed in: qemu Status: Expired => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1836763 Title: Firebird crashes on qemu-m68k-user with pthread_mutex_init error Status in QEMU: Ne

  1   2   3   >