On 22/06/2021 12:49, Philippe Mathieu-Daudé wrote:
> On 6/22/21 11:44 AM, Dov Murik wrote:
>> On 21/06/2021 23:32, Philippe Mathieu-Daudé wrote:
>
...
>
>>>> + if (!pc_system_ovmf_table_find(SEV_HASH_TABLE_RV_GUID, &data, NULL)) {
>>>
>>> If we never use the data_len argument, can we simplify the prototype?
>>
>> The current uses for the OVMF reset vector GUIDed table is for simple
>> structs with known length (secret injection page address, SEV-ES reset
>> address, SEV table of hashes address). But keeping the length there
>> allows adding variable-sized entries such as strings/blobs.
>
> OK. Good opportunity to document the prototype declaration ;)
Yep. I'll send as a separate standalone patch.
P.S.
In a previous version you mentioned you ran into issues with a qemu
build with SEV disabled. I tried that by modifying
default-configs/devices/i386-softmmu.mak and uncommenting CONFIG_SEV=n
there. Is there a friendlier way to create such a build?
I'm currently building with:
cd build
../configure --target-list=x86_64-softmmu
make
Thanks,
-Dov
