[RFC PATCH 02/11] hw/nvme: add nvme_block_status_all helper

2021-06-04 Thread Klaus Jensen
From: Klaus Jensen Pull the gist of nvme_check_dulbe() into a helper function. This is in preparation for dsm refactoring. Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 41 - 1 file changed, 28 insertions(+), 13 deletions(-) diff --git a/hw/nvme/ctrl

[RFC PATCH 07/11] hw/nvme: add dw0/1 to the req completion trace event

2021-06-04 Thread Klaus Jensen
From: Klaus Jensen Some commands report additional useful information in dw0 and dw1 of the completion queue entry. Add them to the trace. Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 2 ++ hw/nvme/trace-events | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/hw

[RFC PATCH 10/11] hw/nvme: reimplement format nvm to allow cancellation

2021-06-04 Thread Klaus Jensen
From: Klaus Jensen Prior to this patch, the aios associated with broadcast format are submitted anonymously (no aiocb reference saved from the blk_aio call). Fix this by formatting the namespaces one after another, saving a reference to the aiocb for each. Signed-off-by: Klaus Jensen --- hw/n

[RFC PATCH 03/11] hw/nvme: reimplement dsm to allow cancellation

2021-06-04 Thread Klaus Jensen
From: Klaus Jensen Prior to this patch, a loop was used to issue multiple "fire and forget" aios for each range in the command. Without a reference to the aiocb returned from the blk_aio_pdiscard calls, the aios cannot be canceled. Fix this by processing the ranges one after another. As a bonus

[RFC PATCH 08/11] hw/nvme: reimplement the copy command to allow aio cancellation

2021-06-04 Thread Klaus Jensen
From: Klaus Jensen Before this patch the code would issue several aios simultaneously without saving a reference to the aiocb. Without the aiocb reference the individual copies cannot be canceled. Fix this by issuing copies of the ranges one after another. Signed-off-by: Klaus Jensen --- hw/n

[RFC PATCH 11/11] Partially revert "hw/block/nvme: drain namespaces on sq deletion"

2021-06-04 Thread Klaus Jensen
From: Klaus Jensen This partially reverts commit 98f84f5a4eca5c03e32fff20f246d9b4b96d6422. Since all "multi aio" commands are now reimplemented to properly track the nested aiocbs, we can revert the "hack" that was introduced to make sure all requests we're properly drained upon sq deletion. Th

[RFC PATCH 05/11] hw/nvme: remove assert from nvme_get_zone_by_slba

2021-06-04 Thread Klaus Jensen
From: Klaus Jensen Make nvme_get_zone_by_slba() return NULL if the slba is out of range. This allows the function to be used without guarding the call with a call to nvme_check_bounds(), in preparation for the next patch. Add asserts after calling nvme_get_zone_by_slba() instead. Signed-off-by:

Re: [PATCH v2 0/2] Fixes for "Windows fails to boot"

2021-06-04 Thread Claudio Fontana
On 6/4/21 8:32 AM, Claudio Fontana wrote: > On 6/3/21 5:10 PM, Cleber Rosa Junior wrote: >> On Thu, Jun 3, 2021 at 10:29 AM Claudio Fontana wrote: >> >>> On 6/3/21 2:29 PM, Claudio Fontana wrote: v1 -> v2: * moved hyperv realizefn call before cpu expansion (Vitaly) * added more co

Re: [PATCH] iotests/check: move general long options to double dash

2021-06-04 Thread Paolo Bonzini
On 03/06/21 14:19, Vladimir Sementsov-Ogievskiy wrote: Double-dash options give extra information to the user that short (single-dash) options can be combined, while this is not the case for iotests/check. You can combine short options for check script, as argparse supports it. We don't hav

Re: [PATCH v3 3/7] block: add max_hw_transfer to BlockLimits

2021-06-04 Thread Paolo Bonzini
On 03/06/21 19:33, Eric Blake wrote: +/* Returns the maximum hardware transfer length, in bytes; guaranteed nonzero */ +uint64_t blk_get_max_hw_transfer(BlockBackend *blk) +{ +BlockDriverState *bs = blk_bs(blk); +uint64_t max = INT_MAX; This is an unaligned value; should we instead rou

[RFC PATCH 09/11] hw/nvme: reimplement zone reset to allow cancellation

2021-06-04 Thread Klaus Jensen
From: Klaus Jensen Prior to this patch, the aios associated with zone reset are submitted anonymously (no reference saved to the aiocb from the blk_aio call). Fix this by resetting the zones one after another, saving a reference to the aiocb for each reset. Signed-off-by: Klaus Jensen --- hw/

Re: [PATCH v7 3/9] i386: hardcode supported eVMCS version to '1'

2021-06-04 Thread Vitaly Kuznetsov
Eduardo Habkost writes: > On Thu, Jun 03, 2021 at 01:48:29PM +0200, Vitaly Kuznetsov wrote: >> Currently, the only eVMCS version, supported by KVM (and described in TLFS) >> is '1'. When Enlightened VMCS feature is enabled, QEMU takes the supported >> eVMCS version range (from KVM_CAP_HYPERV_ENLI

Re: [PATCH v7 5/9] i386: expand Hyper-V features during CPU feature expansion time

2021-06-04 Thread Vitaly Kuznetsov
Eduardo Habkost writes: > On Thu, Jun 03, 2021 at 01:48:31PM +0200, Vitaly Kuznetsov wrote: >> To make Hyper-V features appear in e.g. QMP query-cpu-model-expansion we >> need to expand and set the corresponding CPUID leaves early. Modify >> x86_cpu_get_supported_feature_word() to call newly into

Re: [PATCH v7 8/9] i386: Hyper-V SynIC requires POST_MESSAGES/SIGNAL_EVENTS priviliges

2021-06-04 Thread Vitaly Kuznetsov
Eduardo Habkost writes: > On Thu, Jun 03, 2021 at 01:48:34PM +0200, Vitaly Kuznetsov wrote: >> When Hyper-V SynIC is enabled, we may need to allow Windows guests to make >> hypercalls (POST_MESSAGES/SIGNAL_EVENTS). No issue is currently observed >> because KVM is very permissive, allowing these h

[PULL 0/7] Net patches

2021-06-04 Thread Jason Wang
The following changes since commit 92f8c6fef13b31ba222c4d20ad8afd2b79c4c28e: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210525' into staging (2021-05-25 16:17:06 +0100) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-requ

[PULL 2/7] net: Added SetSteeringEBPF method for NetClientState.

2021-06-04 Thread Jason Wang
From: Andrew Melnychenko For now, that method supported only by Linux TAP. Linux TAP uses TUNSETSTEERINGEBPF ioctl. Signed-off-by: Andrew Melnychenko Signed-off-by: Jason Wang --- include/net/net.h | 2 ++ net/tap-bsd.c | 5 + net/tap-linux.c | 13 + net/tap-solaris.c

[PULL 1/7] net/tap: Added TUNSETSTEERINGEBPF code.

2021-06-04 Thread Jason Wang
From: Andrew Melnychenko Additional code that will be used for eBPF setting steering routine. Signed-off-by: Andrew Melnychenko Signed-off-by: Jason Wang --- net/tap-linux.h | 1 + 1 file changed, 1 insertion(+) diff --git a/net/tap-linux.h b/net/tap-linux.h index 2f36d10..1d06fe0 100644 ---

[PULL 3/7] ebpf: Added eBPF RSS program.

2021-06-04 Thread Jason Wang
From: Andrew Melnychenko RSS program and Makefile to build it. The bpftool used to generate '.h' file. The data in that file may be loaded by libbpf. EBPF compilation is not required for building qemu. You can use Makefile if you need to regenerate rss.bpf.skeleton.h. Signed-off-by: Yuri Bendito

[PULL 5/7] virtio-net: Added eBPF RSS to virtio-net.

2021-06-04 Thread Jason Wang
From: Andrew Melnychenko When RSS is enabled the device tries to load the eBPF program to select RX virtqueue in the TUN. If eBPF can be loaded the RSS will function also with vhost (works with kernel 5.8 and later). Software RSS is used as a fallback with vhost=off when eBPF can't be loaded or w

[PULL 6/7] docs: Added eBPF documentation.

2021-06-04 Thread Jason Wang
From: Andrew Melnychenko Signed-off-by: Yuri Benditovich Signed-off-by: Andrew Melnychenko Signed-off-by: Jason Wang --- docs/devel/ebpf_rss.rst | 125 docs/devel/index.rst| 1 + 2 files changed, 126 insertions(+) create mode 100644 docs

Re: [PATCH v7 9/9] qtest/hyperv: Introduce a simple hyper-v test

2021-06-04 Thread Vitaly Kuznetsov
Eduardo Habkost writes: > On Thu, Jun 03, 2021 at 01:48:35PM +0200, Vitaly Kuznetsov wrote: >> For the beginning, just test 'hv-passthrough' and a couple of custom >> Hyper-V enlightenments configurations through QMP. Later, it would >> be great to complement this by checking CPUID values from w

[PULL 7/7] MAINTAINERS: Added eBPF maintainers information.

2021-06-04 Thread Jason Wang
From: Andrew Melnychenko Signed-off-by: Yuri Benditovich Signed-off-by: Andrew Melnychenko Signed-off-by: Jason Wang --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a77f246..99fe76b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3309

[PULL 4/7] ebpf: Added eBPF RSS loader.

2021-06-04 Thread Jason Wang
From: Andrew Melnychenko Added function that loads RSS eBPF program. Added stub functions for RSS eBPF loader. Added meson and configuration options. By default, eBPF feature enabled if libbpf is present in the build system. libbpf checked in configuration shell script and meson script. Signed-

Re: [PULL 0/7] Net patches

2021-06-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210604073617.69622-1-jasow...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210604073617.69622-1-jasow...@redhat.com Subject: [PULL 0/7] Net patches === TEST SCRI

[PATCH] virtio-gpu: move scanout_id sanity check

2021-06-04 Thread Gerd Hoffmann
Checking scanout_id in virtio_gpu_do_set_scanout() is too late, for the "resource_id == 0" case (aka disable scanout) the scanout_id is used unchecked. Move the check into the callers to fix that. Fixes: e64d4b6a9bc3 ("virtio-gpu: Refactor virtio_gpu_set_scanout") Fixes: 32db3c63ae11 ("virtio-gpu

Re: [RFC PATCH] accel/tcg: change default codegen buffer size for i386-softmmu

2021-06-04 Thread Alex Bennée
Richard Henderson writes: > On 5/25/21 9:45 AM, Alex Bennée wrote: >> There are two justifications for making this change. The first is that >> i386 emulation is typically for smaller machines where having a 1gb of >> generated code is overkill for basic emulation. The second is the >> propensi

Re: [PATCH] iotests/check: move general long options to double dash

2021-06-04 Thread Vladimir Sementsov-Ogievskiy
04.06.2021 10:19, Paolo Bonzini wrote: On 03/06/21 14:19, Vladimir Sementsov-Ogievskiy wrote: Double-dash options give extra information to the user that short (single-dash) options can be combined, while this is not the case for iotests/check. You can combine short options for check script,

Re: [RFC v3 17/29] vhost: Shadow virtqueue buffers forwarding

2021-06-04 Thread Eugenio Perez Martin
On Thu, Jun 3, 2021 at 5:35 AM Jason Wang wrote: > > > 在 2021/6/3 上午1:18, Eugenio Perez Martin 写道: > > On Wed, Jun 2, 2021 at 11:51 AM Jason Wang wrote: > >> > >> 在 2021/5/20 上午12:28, Eugenio Pérez 写道: > >>> Initial version of shadow virtqueue that actually forward buffers. The > >>> exposed addr

Re: [PATCH 0/4] docs: add user facing docs for secret passing and authorization controls

2021-06-04 Thread Daniel P . Berrangé
ping for any reviewers for docs On Fri, May 14, 2021 at 06:31:06PM +0100, Daniel P. Berrangé wrote: > These are an important of the overall QEMU network backend security > controls but never previously documented aside from in blog posts. > > Daniel P. Berrangé (4): > docs: document how to pass

Re: [PATCH 1/2] meson: allow optional dependencies for block modules

2021-06-04 Thread Vladimir Sementsov-Ogievskiy
03.06.2021 16:07, Paolo Bonzini wrote: Right now all dependencies for block modules are passed to module_ss.add(when: ...), so they are mandatory. In the next patch we will need to add a libm dependency to a module, but libm does not exist on all systems. So, modify the creation of module_ss an

Re: [PATCH v4 01/15] python: qemu: add timer parameter for qmp.accept socket

2021-06-04 Thread Emanuele Giuseppe Esposito
On 03/06/2021 21:02, John Snow wrote: On 6/3/21 4:06 AM, Emanuele Giuseppe Esposito wrote: On 03/06/2021 01:23, John Snow wrote: On 5/20/21 3:52 AM, Emanuele Giuseppe Esposito wrote: Alsp add a new _qmp_timer field to the QEMUMachine class. Let's change the default socket timeout to None

Re: [RFC] Adding the A64FX's HPC funtions.

2021-06-04 Thread Peter Maydell
On Fri, 4 Jun 2021 at 09:29, ishii.shuuic...@fujitsu.com wrote: > > Hi, Richard. > > > Well, Peter disagreed with having them enabled by default in -cpu max, so we > > might need at least one extra property. I see no reason to have three > > properties -- one property a64fx-hpc should be sufficie

Re: [PATCH v13 4/8] KVM: arm64: Introduce MTE VM feature

2021-06-04 Thread Catalin Marinas
On Thu, Jun 03, 2021 at 05:00:31PM +0100, Catalin Marinas wrote: > On Mon, May 24, 2021 at 11:45:09AM +0100, Steven Price wrote: > > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > > index c5d1f3c87dbd..226035cf7d6c 100644 > > --- a/arch/arm64/kvm/mmu.c > > +++ b/arch/arm64/kvm/mmu.c > >

Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled

2021-06-04 Thread Peter Maydell
On Fri, 4 Jun 2021 at 06:26, Swetha Joshi wrote: > > Hello, I have tested this patch with our qemu and it works, thank you. Thanks for testing. > What are the next steps for this patch? So is it approved and ready to go in > mainline? It will go in once it has been code-reviewed. -- PMM

Re: [RFC v3 25/29] vhost: Add custom IOTLB translations to SVQ

2021-06-04 Thread Eugenio Perez Martin
On Thu, Jun 3, 2021 at 5:39 AM Jason Wang wrote: > > > 在 2021/6/3 上午1:51, Eugenio Perez Martin 写道: > > On Wed, Jun 2, 2021 at 11:52 AM Jason Wang wrote: > >> > >> 在 2021/5/20 上午12:28, Eugenio Pérez 写道: > >>> Use translations added in IOVAReverseMaps in SVQ if the vhost device > >>> does not suppo

Re: [PATCH v2 0/2] Fixes for "Windows fails to boot"

2021-06-04 Thread Claudio Fontana
On 6/4/21 9:01 AM, Claudio Fontana wrote: > On 6/4/21 8:32 AM, Claudio Fontana wrote: >> On 6/3/21 5:10 PM, Cleber Rosa Junior wrote: >>> On Thu, Jun 3, 2021 at 10:29 AM Claudio Fontana wrote: >>> On 6/3/21 2:29 PM, Claudio Fontana wrote: > v1 -> v2: > * moved hyperv realizefn call b

Re: [PATCH 01/11] hw/char: Renesas SCI module.

2021-06-04 Thread Peter Maydell
On Thu, 27 May 2021 at 06:30, Yoshinori Sato wrote: > > This module supported SCI / SCIa / SCIF. > > Hardware manual. > SCI / SCIF > https://www.renesas.com/us/en/doc/products/mpumcu/001/r01uh0457ej0401_sh7751.pdf > SCIa > https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej

[PATCH v5 00/16] qemu_iotests: improve debugging options

2021-06-04 Thread Emanuele Giuseppe Esposito
This series adds the option to attach gdbserver and valgrind to the QEMU binary running in qemu_iotests. It also allows to redirect QEMU binaries output of the python tests to the stdout, instead of a log file. Patches 1-9 introduce the -gdb option to both python and bash tests, 10-14 extend the

[PATCH v5 04/16] docs/devel/testing: add debug section to the QEMU iotests chapter

2021-06-04 Thread Emanuele Giuseppe Esposito
Introduce the "Debugging a test case" section, in preparation to the additional flags that will be added in the next patches. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- docs/devel/testing.rst | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v5 01/16] python: qemu: add timer parameter for qmp.accept socket

2021-06-04 Thread Emanuele Giuseppe Esposito
Also add a new _qmp_timer field to the QEMUMachine class. Let's change the default socket timeout to None, so that if a subclass needs to add a timer, it can be done by modifying this private field. At the same time, restore the timer to be 15 seconds in iotests.py, to give an upper bound to the

[PATCH v5 10/16] qemu-iotests: extend the check script to prepare supporting valgrind for python tests

2021-06-04 Thread Emanuele Giuseppe Esposito
Currently, the check script only parses the option and sets the VALGRIND_QEMU environmental variable to "y". Add another local python variable that prepares the command line, identical to the one provided in the test scripts. Because the python script does not know in advance the valgrind PID to a

[PATCH v5 05/16] qemu-iotests: add option to attach gdbserver

2021-06-04 Thread Emanuele Giuseppe Esposito
Define --gdb flag and GDB_OPTIONS environment variable to python tests to attach a gdbserver to each qemu instance. This patch only adds and parses this flag, it does not yet add the implementation for it. if --gdb is not provided but $GDB_OPTIONS is set, ignore the environment variable. Signed-o

[PATCH v5 03/16] python: qemu: pass the wrapper field from QEMUQtestmachine to QEMUMachine

2021-06-04 Thread Emanuele Giuseppe Esposito
Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Reviewed-by: Max Reitz --- python/qemu/machine/qtest.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/python/qemu/machine/qtest.py b/python/qemu/machine/qtest.py

[PATCH v5 16/16] docs/devel/testing: add -p option to the debug section of QEMU iotests

2021-06-04 Thread Emanuele Giuseppe Esposito
Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- docs/devel/testing.rst | 4 1 file changed, 4 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index 9cac707ee5..c038ca93d4 100644 --- a/docs/devel/testing.rst +++ b/docs/devel

[PATCH v5 02/16] python: Reduce strictness of pylint's duplicate-code check

2021-06-04 Thread Emanuele Giuseppe Esposito
From: John Snow Pylint prior to 2.8.3 (We pin at >= 2.8.0) includes function and method signatures as part of its duplicate checking algorithm. This check does not listen to pragmas, so the only way to disable it is to turn it off completely or increase the minimum duplicate lines so that it does

[PATCH v5 06/16] qemu-iotests: delay QMP socket timers

2021-06-04 Thread Emanuele Giuseppe Esposito
Attaching gdbserver implies that the qmp socket should wait indefinitely for an answer from QEMU. For Timeout class, create a @contextmanager that switches Timeout with NoTimeout (empty context manager) so that if --gdb is set, no timeout will be triggered. Signed-off-by: Emanuele Giuseppe Esposi

[PATCH v5 07/16] qemu_iotests: insert gdbserver command line as wrapper for qemu binary

2021-06-04 Thread Emanuele Giuseppe Esposito
Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index d4bfd8f1d6..c547e8c07b 100644 --- a/test

[PATCH v5 09/16] docs/devel/testing: add --gdb option to the debugging section of QEMU iotests

2021-06-04 Thread Emanuele Giuseppe Esposito
Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- docs/devel/testing.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index 9d6a8f8636..11a0359218 100644 --- a/docs/devel/testing.rst +++ b/d

[PATCH v5 08/16] qemu-iotests: add gdbserver option to script tests too

2021-06-04 Thread Emanuele Giuseppe Esposito
The only limitation here is that running a script with gdbserver will make the test output mismatch with the expected results, making the test fail. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/common.rc | 8 +++- 1 file changed,

[PATCH v5 13/16] qemu-iotests: insert valgrind command line as wrapper for qemu binary

2021-06-04 Thread Emanuele Giuseppe Esposito
If --gdb and --valgrind are both defined, return an error. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-io

RE: [PATCH 1/2] vhost-vdpa: don't initialize backend_features

2021-06-04 Thread Gautam Dawar
Hi Jason, -Original Message- From: Jason Wang Sent: Wednesday, June 2, 2021 2:18 PM To: Gautam Dawar ; m...@redhat.com; qemu-devel@nongnu.org Cc: l...@redhat.com; qemu-sta...@nongnu.org Subject: Re: [PATCH 1/2] vhost-vdpa: don't initialize backend_features Hi Gautam: 在 2021/6/2 下午3:38,

[PATCH v5 11/16] qemu-iotests: extend QMP socket timeout when using valgrind

2021-06-04 Thread Emanuele Giuseppe Esposito
As with gdbserver, valgrind delays the test execution, so the default QMP socket timeout and the generic class Timeout in iotests.py timeouts too soon. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 4 ++-- 1 file changed,

[PATCH v5 12/16] qemu-iotests: allow valgrind to read/delete the generated log file

2021-06-04 Thread Emanuele Giuseppe Esposito
When using --valgrind on the script tests, it generates a log file in $TEST_DIR that is either read (if valgrind finds problems) or otherwise deleted. Provide the same exact behavior when using --valgrind on the python tests. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sements

[PATCH v5 14/16] docs/devel/testing: add --valgrind option to the debug section of QEMU iotests

2021-06-04 Thread Emanuele Giuseppe Esposito
Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- docs/devel/testing.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index 11a0359218..9cac707ee5 100644 --- a/docs/devel/t

[PATCH v5 15/16] qemu-iotests: add option to show qemu binary logs on stdout

2021-06-04 Thread Emanuele Giuseppe Esposito
Using the flag -p, allow the qemu binary to print to stdout. Also create the common function _close_qemu_log_file() to avoid accessing machine.py private fields directly and have duplicate code. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- python/qemu

[PATCH v4 1/6] blkdebug: refactor removal of a suspended request

2021-06-04 Thread Emanuele Giuseppe Esposito
Extract to a separate function. Do not rely on FOREACH_SAFE, which is only "safe" if the *current* node is removed---not if another node is removed. Instead, just walk the entire list from the beginning when asked to resume all suspended requests with a given tag. Co-developed-by: Paolo Bonzini

[PATCH v4 0/6] blkdebug: fix racing condition when iterating on

2021-06-04 Thread Emanuele Giuseppe Esposito
When qemu_coroutine_enter is executed in a loop (even QEMU_FOREACH_SAFE), the new routine can modify the list, for example removing an element, causing problem when control is given back to the caller that continues iterating on the same list. Patch 1 solves the issue in blkdebug_debug_resume by

[PATCH v4 4/6] blkdebug: do not suspend in the middle of QLIST_FOREACH_SAFE

2021-06-04 Thread Emanuele Giuseppe Esposito
That would be unsafe in case a rule other than the current one is removed while the coroutine has yielded. Keep FOREACH_SAFE because suspend_request deletes the current rule. After this patch, *all* matching rules are deleted before suspending the coroutine, rather than just one. This doesn't affe

[PATCH v4 5/6] block/blkdebug: remove new_state field and instead use a local variable

2021-06-04 Thread Emanuele Giuseppe Esposito
There seems to be no benefit in using a field. Replace it with a local variable. Signed-off-by: Emanuele Giuseppe Esposito --- block/blkdebug.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index dffd869b32..d597753139 10064

[PATCH v4 3/6] blkdebug: track all actions

2021-06-04 Thread Emanuele Giuseppe Esposito
Add a counter for each action that a rule can trigger. This is mainly used to keep track of how many coroutine_yield() we need to perform after processing all rules in the list. Co-developed-by: Paolo Bonzini Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --

[PATCH v4 2/6] blkdebug: move post-resume handling to resume_req_by_tag

2021-06-04 Thread Emanuele Giuseppe Esposito
We want to move qemu_coroutine_yield() after the loop on rules, because QLIST_FOREACH_SAFE is wrong if the rule list is modified while the coroutine has yielded. Therefore move the suspended request to the heap and clean it up from the remove side. All that is left is for blkdebug_debug_event to h

[PATCH v4 6/6] blkdebug: protect rules and suspended_reqs with a lock

2021-06-04 Thread Emanuele Giuseppe Esposito
First, categorize the structure fields to identify what needs to be protected and what doesn't. We essentially need to protect only .state, and the 3 lists in BDRVBlkdebugState. Then, add the lock and mark the functions accordingly. Co-developed-by: Paolo Bonzini Signed-off-by: Emanuele Giusepp

Re: [PATCH 02/11] hw/char: remove sh_serial.

2021-06-04 Thread Peter Maydell
On Thu, 27 May 2021 at 06:24, Yoshinori Sato wrote: > > Migrate to renesas_sci. > > Signed-off-by: Yoshinori Sato > --- > hw/char/sh_serial.c | 431 > MAINTAINERS | 4 +- > hw/char/Kconfig | 3 - > hw/char/meson.build | 1 - > 4 file

Re: [PATCH 07/11] hw/timer: Renesas 8bit timer.

2021-06-04 Thread Peter Maydell
On Thu, 27 May 2021 at 06:30, Yoshinori Sato wrote: > > Rewrite timer api. > > Signed-off-by: Yoshinori Sato > --- > include/hw/timer/renesas_tmr.h | 58 > include/hw/timer/renesas_tmr8.h | 67 > hw/timer/renesas_tmr.c | 493 - > hw/timer/renesas

Re: [PULL 00/29] softfloat patch queue

2021-06-04 Thread Peter Maydell
On Thu, 3 Jun 2021 at 22:43, Richard Henderson wrote: > > The following changes since commit 453d9c61dd5681159051c6e4d07e7b2633de2e70: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20210603' into staging (2021-06-03 > 16:59:46 +0100) > > are available in the Git rep

[PATCH] vhost-user-gpu: reorder free calls.

2021-06-04 Thread Gerd Hoffmann
Free in correct order to avoid use-after-free. Resolves: CID 1453812 Signed-off-by: Gerd Hoffmann --- contrib/vhost-user-gpu/vhost-user-gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/vhost-user-gpu/vhost-user-gpu.c b/contrib/vhost-user-gpu/vhost-user-gpu.c ind

Re: [PULL 0/7] Net patches

2021-06-04 Thread Peter Maydell
On Fri, 4 Jun 2021 at 08:36, Jason Wang wrote: > > The following changes since commit 92f8c6fef13b31ba222c4d20ad8afd2b79c4c28e: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20210525' into staging (2021-05-25 > 16:17:06 +0100) > > are available in the git repository

Re: Switching to the GitLab bug tracker

2021-06-04 Thread Philippe Mathieu-Daudé
Hi Michael, On 5/5/21 11:58 AM, Daniel P. Berrangé wrote: > On Wed, May 05, 2021 at 11:55:30AM +0200, Stefano Garzarella wrote: >> On Tue, May 04, 2021 at 12:20:03PM +0200, Philippe Mathieu-Daudé wrote: >>> On 5/4/21 10:43 AM, Stefan Hajnoczi wrote: On Mon, May 03, 2021 at 01:16:51PM +0200, T

Re: [PATCH] vhost-user-gpu: reorder free calls.

2021-06-04 Thread Marc-André Lureau
On Fri, Jun 4, 2021 at 2:38 PM Gerd Hoffmann wrote: > Free in correct order to avoid use-after-free. > > Resolves: CID 1453812 > Signed-off-by: Gerd Hoffmann > Reviewed-by: Marc-André Lureau --- > contrib/vhost-user-gpu/vhost-user-gpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] vhost-user-gpu: reorder free calls.

2021-06-04 Thread Philippe Mathieu-Daudé
On 6/4/21 12:37 PM, Gerd Hoffmann wrote: > Free in correct order to avoid use-after-free. > > Resolves: CID 1453812 > Signed-off-by: Gerd Hoffmann > --- > contrib/vhost-user-gpu/vhost-user-gpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v13 4/8] KVM: arm64: Introduce MTE VM feature

2021-06-04 Thread Steven Price
On 03/06/2021 17:00, Catalin Marinas wrote: > On Mon, May 24, 2021 at 11:45:09AM +0100, Steven Price wrote: >> diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c >> index c5d1f3c87dbd..226035cf7d6c 100644 >> --- a/arch/arm64/kvm/mmu.c >> +++ b/arch/arm64/kvm/mmu.c >> @@ -822,6 +822,42 @@ tran

Re: [PATCH v4 7/8] hw/arm/sbsa-ref: add ITS support in SBSA GIC

2021-06-04 Thread Leif Lindholm
On Thu, Jun 03, 2021 at 11:31:21 -0400, shashi.mall...@linaro.org wrote: > On Thu, 2021-06-03 at 12:42 +0100, Leif Lindholm wrote: > > On Wed, Jun 02, 2021 at 14:00:41 -0400, Shashi Mallela wrote: > > > Included creation of ITS as part of SBSA platform GIC > > > initialization. > > > > > > Signed-

Re: [PATCH v13 7/8] KVM: arm64: ioctl to fetch/store tags in a guest

2021-06-04 Thread Steven Price
On 03/06/2021 18:13, Catalin Marinas wrote: > On Mon, May 24, 2021 at 11:45:12AM +0100, Steven Price wrote: >> diff --git a/arch/arm64/include/uapi/asm/kvm.h >> b/arch/arm64/include/uapi/asm/kvm.h >> index 24223adae150..b3edde68bc3e 100644 >> --- a/arch/arm64/include/uapi/asm/kvm.h >> +++ b/arch/a

Re: [PATCH 2/4] docs: document usage of the authorization framework

2021-06-04 Thread Marc-André Lureau
On Fri, May 14, 2021 at 9:36 PM Daniel P. Berrangé wrote: > The authorization framework provides a way to control access to network > services after a client has been authenticated. This documents how to > actually use it. > > Signed-off-by: Daniel P. Berrangé > --- > docs/system/authz.rst | 26

Re: [PATCH 0/4] docs: add user facing docs for secret passing and authorization controls

2021-06-04 Thread Marc-André Lureau
On Fri, Jun 4, 2021 at 12:44 PM Daniel P. Berrangé wrote: > ping for any reviewers for docs > > On Fri, May 14, 2021 at 06:31:06PM +0100, Daniel P. Berrangé wrote: > > These are an important of the overall QEMU network backend security > > controls but never previously documented aside from in bl

Re: [PATCH v13 4/8] KVM: arm64: Introduce MTE VM feature

2021-06-04 Thread Catalin Marinas
On Fri, Jun 04, 2021 at 11:42:11AM +0100, Steven Price wrote: > On 03/06/2021 17:00, Catalin Marinas wrote: > > On Mon, May 24, 2021 at 11:45:09AM +0100, Steven Price wrote: > >> diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > >> index c5d1f3c87dbd..226035cf7d6c 100644 > >> --- a/arch/ar

Re: [PATCH v13 7/8] KVM: arm64: ioctl to fetch/store tags in a guest

2021-06-04 Thread Catalin Marinas
On Fri, Jun 04, 2021 at 12:15:56PM +0100, Steven Price wrote: > On 03/06/2021 18:13, Catalin Marinas wrote: > > On Mon, May 24, 2021 at 11:45:12AM +0100, Steven Price wrote: > >> diff --git a/arch/arm64/include/uapi/asm/kvm.h > >> b/arch/arm64/include/uapi/asm/kvm.h > >> index 24223adae150..b3edde

Re: [Qemu-devel] [PATCH v4 0/3] tests: Reorganize MIPS TCG directories and files

2021-06-04 Thread Aleksandar Rikalo
Hi Philippe, >>> From: Aleksandar Markovic >>> >>> Reorganize MIPS TCG directories and files. >>> >>> Directories for DSP tests in system mode are deleted. They >>> introduce more complexity in test structure compared to the >>> value they add. Still, these tests may be moved somewhere >>> else,

Re: [PATCH v11 08/46] target/mips: Add emulation of nanoMIPS 16-bit branch instructions

2021-06-04 Thread Aleksandar Rikalo
Hi Philippe, On 5/29/21 3:52 PM, Philippe Mathieu-Daudé wrote: > I think this opcode never worked correctly. > > Per the "MIPS® Architecture Extension: nanoMIPS32 DSP Technical > Reference Manual — Revision 0.04" p. 88 "BPOSGE32C": > > "First, the offset argument is left-shifted by one bit to

[PATCH] vnc: avoid deprecation warnings for SASL on OS X

2021-06-04 Thread Paolo Bonzini
Apple has deprecated sasl.h functions in OS X 10.11. Therefore, all files that use SASL API need to disable -Wdeprecated-declarations. Remove the only use that is outside vnc-auth-sasl.c and add the relevant #pragma GCC diagnostic there. Signed-off-by: Paolo Bonzini --- ui/vnc-auth-sasl.c | 20

Re: [PATCH 3/3] 9pfs: reduce latency of Twalk

2021-06-04 Thread Christian Schoenebeck
On Donnerstag, 27. Mai 2021 20:24:23 CEST Christian Schoenebeck wrote: > On Donnerstag, 27. Mai 2021 19:05:43 CEST Christian Schoenebeck wrote: > > As on the previous performance optimization on Treaddir handling; > > reduce the overall latency, i.e. overall time spent on processing > > a Twalk req

[Bug 1695286] Re: Add multiboot2 support

2021-06-04 Thread Dan Cross
Marking new to migrate to the new bug tracker. It would be really great to see this in QEMU! ** Changed in: qemu Status: Incomplete => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/169528

Re: [PULL 0/7] Net patches

2021-06-04 Thread Jason Wang
在 2021/6/4 下午6:37, Peter Maydell 写道: On Fri, 4 Jun 2021 at 08:36, Jason Wang wrote: The following changes since commit 92f8c6fef13b31ba222c4d20ad8afd2b79c4c28e: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210525' into staging (2021-05-25 16:17:06 +0100) are av

Re: [PATCH v13 4/8] KVM: arm64: Introduce MTE VM feature

2021-06-04 Thread Steven Price
On 04/06/2021 12:36, Catalin Marinas wrote: > On Fri, Jun 04, 2021 at 11:42:11AM +0100, Steven Price wrote: >> On 03/06/2021 17:00, Catalin Marinas wrote: >>> On Mon, May 24, 2021 at 11:45:09AM +0100, Steven Price wrote: diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c index c5d1f

Re: [PATCH] vnc: avoid deprecation warnings for SASL on OS X

2021-06-04 Thread Philippe Mathieu-Daudé
On 6/4/21 2:09 PM, Paolo Bonzini wrote: > Apple has deprecated sasl.h functions in OS X 10.11. Therefore, > all files that use SASL API need to disable -Wdeprecated-declarations. > Remove the only use that is outside vnc-auth-sasl.c and add the > relevant #pragma GCC diagnostic there. > > Signed-

[PATCH v2] hw/intc/arm_gicv3_cpuif: Tolerate spurious EOIR writes

2021-06-04 Thread Jean-Philippe Brucker
Commit 382c7160d1cd ("hw/intc/arm_gicv3_cpuif: Fix EOIR write access check logic") added an assert_not_reached() if the guest writes the EOIR register while no interrupt is active. It turns out some software does this: EDK2, in GicV3ExitBootServicesEvent(), unconditionally write EOIR for all inter

Re: [PATCH v2] hw/intc/arm_gicv3_cpuif: Tolerate spurious EOIR writes

2021-06-04 Thread Philippe Mathieu-Daudé
On 6/4/21 3:03 PM, Jean-Philippe Brucker wrote: > Commit 382c7160d1cd ("hw/intc/arm_gicv3_cpuif: Fix EOIR write access > check logic") added an assert_not_reached() if the guest writes the EOIR > register while no interrupt is active. > > It turns out some software does this: EDK2, in > GicV3ExitB

Re: [PATCH v13 7/8] KVM: arm64: ioctl to fetch/store tags in a guest

2021-06-04 Thread Steven Price
On 04/06/2021 12:42, Catalin Marinas wrote: > On Fri, Jun 04, 2021 at 12:15:56PM +0100, Steven Price wrote: >> On 03/06/2021 18:13, Catalin Marinas wrote: >>> On Mon, May 24, 2021 at 11:45:12AM +0100, Steven Price wrote: diff --git a/arch/arm64/include/uapi/asm/kvm.h b/arch/arm64/include

Re: [PATCH] vnc: avoid deprecation warnings for SASL on OS X

2021-06-04 Thread Daniel P . Berrangé
On Fri, Jun 04, 2021 at 03:07:05PM +0200, Philippe Mathieu-Daudé wrote: > On 6/4/21 2:09 PM, Paolo Bonzini wrote: > > Apple has deprecated sasl.h functions in OS X 10.11. Therefore, > > all files that use SASL API need to disable -Wdeprecated-declarations. > > Remove the only use that is outside v

Re: [PATCH qemu v20] spapr: Implement Open Firmware client interface

2021-06-04 Thread BALATON Zoltan
On Fri, 4 Jun 2021, David Gibson wrote: On Tue, Jun 01, 2021 at 04:12:44PM +0200, BALATON Zoltan wrote: On Tue, 1 Jun 2021, Alexey Kardashevskiy wrote: On 31/05/2021 23:07, BALATON Zoltan wrote: On Sun, 30 May 2021, BALATON Zoltan wrote: On Thu, 20 May 2021, Alexey Kardashevskiy wrote: diff

[Bug 1695286] Re: Add multiboot2 support

2021-06-04 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/389 ** Tags added: i386 ** Changed in: qemu Status: New =>

Re: [PATCH] vnc: avoid deprecation warnings for SASL on OS X

2021-06-04 Thread Peter Maydell
On Fri, 4 Jun 2021 at 14:15, Daniel P. Berrangé wrote > VNC/SASL isn't going anywhere. It is fully supported on Linux and a > critically important security feature. > > If macOS removes SASL, that sucks for macOS users, but then in that case I > assume HomeBrew/MacPorts would bring it back to life

Re: [PATCH 2/3] 9pfs: capture root stat

2021-06-04 Thread Christian Schoenebeck
On Donnerstag, 27. Mai 2021 19:04:11 CEST Christian Schoenebeck wrote: > We already capture the QID of the exported 9p root path, i.e. to > prevent client access outside the defined, exported filesystem's tree. > This is currently checked by comparing the root QID with another FID's > QID. > > The

Re: [PATCH qemu v20] spapr: Implement Open Firmware client interface

2021-06-04 Thread BALATON Zoltan
On Fri, 4 Jun 2021, David Gibson wrote: On Sun, May 30, 2021 at 07:33:01PM +0200, BALATON Zoltan wrote: Hello, Two more problems I've found while testing with pegasos2 but I'm not sure how to fix them: On Thu, 20 May 2021, Alexey Kardashevskiy wrote: diff --git a/hw/ppc/vof.c b/hw/ppc/vof.c n

Re: [PATCH qemu v20] spapr: Implement Open Firmware client interface

2021-06-04 Thread BALATON Zoltan
On Fri, 4 Jun 2021, David Gibson wrote: On Wed, Jun 02, 2021 at 02:29:29PM +0200, BALATON Zoltan wrote: On Wed, 2 Jun 2021, David Gibson wrote: On Thu, May 27, 2021 at 02:42:39PM +0200, BALATON Zoltan wrote: On Thu, 27 May 2021, David Gibson wrote: On Tue, May 25, 2021 at 12:08:45PM +0200, BA

Re: [PATCH V3 08/22] cpr: QMP interfaces

2021-06-04 Thread Eric Blake
On Fri, May 07, 2021 at 05:25:06AM -0700, Steve Sistare wrote: > cprsave calls cprsave(). Syntax: > { 'enum': 'CprMode', 'data': [ 'reboot', 'restart' ] } > { 'command': 'cprsave', 'data': { 'file': 'str', 'mode': 'CprMode' } } > > cprload calls cprload(). Syntax: > { 'command': 'cprload',

Re: [Stratos-dev] [PATCH 0/5] virtio: Add vhost-user based RNG service

2021-06-04 Thread Srivatsa Vaddagiri
* Mathieu Poirier via Stratos-dev [2021-06-01 20:03:14]: > Hi all, > > This sets adds a vhost-user based random number generator (RNG), > similar to what has been done for i2c and virtiofsd. In fact > the implementation for vhost-user-rng and vhost-user-rng-pci > follow what was done for vhost

Re: [PATCH v13 4/8] KVM: arm64: Introduce MTE VM feature

2021-06-04 Thread Catalin Marinas
On Fri, Jun 04, 2021 at 01:51:38PM +0100, Steven Price wrote: > On 04/06/2021 12:36, Catalin Marinas wrote: > > On Fri, Jun 04, 2021 at 11:42:11AM +0100, Steven Price wrote: > >> On 03/06/2021 17:00, Catalin Marinas wrote: > >>> On Mon, May 24, 2021 at 11:45:09AM +0100, Steven Price wrote: > @

Re: [PATCH v7 8/9] i386: Hyper-V SynIC requires POST_MESSAGES/SIGNAL_EVENTS priviliges

2021-06-04 Thread Eric Blake
On Thu, Jun 03, 2021 at 01:48:34PM +0200, Vitaly Kuznetsov wrote: In the subject, s/priviliges/privileges/ > When Hyper-V SynIC is enabled, we may need to allow Windows guests to make > hypercalls (POST_MESSAGES/SIGNAL_EVENTS). No issue is currently observed > because KVM is very permissive, allo

Re: [RFC PATCH 5/9] qapi: Implement 'next-machine-phase' command

2021-06-04 Thread Eric Blake
On Thu, May 13, 2021 at 10:25:45AM +0200, Mirela Grujic wrote: > This command will be used to control via QMP the advancing of machine > through initialization phases. The feature is needed to enable the > machine configuration via QMP. > > The command triggers QEMU to advance the machine to the n

  1   2   3   4   >